asterisk/asterisk.git
2 years agoMerge "stasis_channels.c: Remove a very silly RAII_VAR()."
Joshua Colp [Tue, 7 Nov 2017 14:44:12 +0000 (08:44 -0600)]
Merge "stasis_channels.c: Remove a very silly RAII_VAR()."

2 years agoMerge "stasis/app.c: Optimize stasis_app_get_debug_by_name()"
Joshua Colp [Tue, 7 Nov 2017 13:57:39 +0000 (07:57 -0600)]
Merge "stasis/app.c: Optimize stasis_app_get_debug_by_name()"

2 years agoMerge "Fix ast_(v)asprintf() malloc failure usage conditions."
Joshua Colp [Tue, 7 Nov 2017 13:18:12 +0000 (07:18 -0600)]
Merge "Fix ast_(v)asprintf() malloc failure usage conditions."

2 years agoMerge "RTP Engine: Deal with errors returned from AST_VECTOR_REPLACE."
Joshua Colp [Tue, 7 Nov 2017 12:36:32 +0000 (06:36 -0600)]
Merge "RTP Engine: Deal with errors returned from AST_VECTOR_REPLACE."

2 years agores_pjproject: Handle error from adding to the buildopts vector.
Corey Farrell [Mon, 6 Nov 2017 23:17:13 +0000 (18:17 -0500)]
res_pjproject: Handle error from adding to the buildopts vector.

Change-Id: I076c7bd207c7989a23005395ce1735392657be65

2 years agoRTP Engine: Deal with errors returned from AST_VECTOR_REPLACE.
Corey Farrell [Mon, 6 Nov 2017 21:20:06 +0000 (16:20 -0500)]
RTP Engine: Deal with errors returned from AST_VECTOR_REPLACE.

Check for errors from AST_VECTOR_REPLACE and clean memory if needed.

Change-Id: I124d15cc1d645f85a72a1279f623c1993b304b0b

2 years agoMerge "dtls: Add support for ephemeral DTLS certificates."
Joshua Colp [Mon, 6 Nov 2017 18:22:38 +0000 (12:22 -0600)]
Merge "dtls: Add support for ephemeral DTLS certificates."

2 years agostasis_channels.c: Remove a very silly RAII_VAR().
Richard Mudgett [Fri, 3 Nov 2017 22:43:18 +0000 (17:43 -0500)]
stasis_channels.c: Remove a very silly RAII_VAR().

Change-Id: I28b458b3c1a442c4ef0be7b4986a95ea4149e14f

2 years agoMerge "install_prereq: Checkout of libSRTP 2.x."
Joshua Colp [Mon, 6 Nov 2017 17:57:58 +0000 (11:57 -0600)]
Merge "install_prereq: Checkout of libSRTP 2.x."

2 years agostasis/app.c: Optimize stasis_app_get_debug_by_name()
Richard Mudgett [Fri, 3 Nov 2017 21:14:15 +0000 (16:14 -0500)]
stasis/app.c: Optimize stasis_app_get_debug_by_name()

* Eliminate RAII_VAR()
* Short circuit application name lookup if global debug enabled.

Change-Id: I5f78b7bd6ca7fd2c3b07cbbe036c6a93b4681123

2 years agoFix ast_(v)asprintf() malloc failure usage conditions.
Richard Mudgett [Thu, 2 Nov 2017 23:40:20 +0000 (18:40 -0500)]
Fix ast_(v)asprintf() malloc failure usage conditions.

When (v)asprintf() fails, the state of the allocated buffer is undefined.
The library had better not leave an allocated buffer as a result or no one
will know to free it.  The most likely way it can return failure is for an
allocation failure.  If the printf conversion fails then you actually have
a threading problem which is much worse because another thread modified
the parameter values.

* Made __ast_asprintf()/__ast_vasprintf() set the returned buffer to NULL
on failure.  That is much more useful than either an uninitialized pointer
or a pointer that has already been freed.  Many uses won't have to check
for failure to ensure that the buffer won't be double freed or prevent an
attempt to free an uninitialized pointer.

* stasis.c: Fixed memory leak in multi_object_blob_to_ami() allocated by
ast_asprintf().

* ari/resource_bridges.c:ari_bridges_play_helper(): Remove assignment to
the wrong thing which is now not needed even if assigning to the right
thing.

Change-Id: Ib5252fb8850ecf0f78ed0ee2ca0796bda7e91c23

2 years agoMerge "configure: Add autoconf check for libopusfile."
Joshua Colp [Mon, 6 Nov 2017 16:38:18 +0000 (10:38 -0600)]
Merge "configure: Add autoconf check for libopusfile."

2 years agoMerge "Prevent unload of modules which implement an Optional API."
Joshua Colp [Mon, 6 Nov 2017 16:11:51 +0000 (10:11 -0600)]
Merge "Prevent unload of modules which implement an Optional API."

2 years agoMerge "Add missing menuselect dependencies."
Joshua Colp [Mon, 6 Nov 2017 15:26:18 +0000 (09:26 -0600)]
Merge "Add missing menuselect dependencies."

2 years agoMerge "Stasis/ARI: Fix off-nominal path json memory leaks."
Joshua Colp [Mon, 6 Nov 2017 14:15:02 +0000 (08:15 -0600)]
Merge "Stasis/ARI: Fix off-nominal path json memory leaks."

2 years agoMerge "AOC: Fix AOC-S json memory leak."
Joshua Colp [Mon, 6 Nov 2017 13:51:36 +0000 (07:51 -0600)]
Merge "AOC: Fix AOC-S json memory leak."

2 years agoMerge "res_stasis_mailbox.c: Fix leak of mailbox container."
Joshua Colp [Mon, 6 Nov 2017 13:17:22 +0000 (07:17 -0600)]
Merge "res_stasis_mailbox.c: Fix leak of mailbox container."

2 years agodtls: Add support for ephemeral DTLS certificates.
Sean Bright [Fri, 29 Sep 2017 14:50:17 +0000 (14:50 +0000)]
dtls: Add support for ephemeral DTLS certificates.

This mimics the behavior of Chrome and Firefox and creates an ephemeral
X.509 certificate for each DTLS session.

Currently, the only supported key type is ECDSA because of its faster
generation time, but other key types can be added in the future as
necessary.

ASTERISK-27395

Change-Id: I5122e5f4b83c6320cc17407a187fcf491daf30b4

2 years agoMerge "Build System: Fix build failure caused by recent CLI improvements."
Joshua Colp [Mon, 6 Nov 2017 12:31:28 +0000 (06:31 -0600)]
Merge "Build System: Fix build failure caused by recent CLI improvements."

2 years agoconfigure: Add autoconf check for libopusfile.
Corey Farrell [Mon, 6 Nov 2017 09:21:12 +0000 (04:21 -0500)]
configure: Add autoconf check for libopusfile.

This check is being added to make it easier for end-users of third party
open source Opus modules.  This was removed by ASTERISK-26426 but only
the module needed to be removed.

Change-Id: I62b9cd0c4fa8a77596ab0e042948a643a1152677

2 years agoinstall_prereq: Checkout of libSRTP 2.x.
Alexander Traud [Sat, 4 Nov 2017 11:05:36 +0000 (12:05 +0100)]
install_prereq: Checkout of libSRTP 2.x.

Since Asterisk 13.17, libSRTP 2.x is supported. Therefore, its latest version
is installed again via the script install_prereq.

ASTERISK-27356

Change-Id: I13125839a79052356469e41edacbebff0a937d39

2 years agoStasis/ARI: Fix off-nominal path json memory leaks.
Richard Mudgett [Wed, 1 Nov 2017 22:47:57 +0000 (17:47 -0500)]
Stasis/ARI: Fix off-nominal path json memory leaks.

Change-Id: Id569c624c426e3b22a99936473c730592d8b83fb

2 years agoAOC: Fix AOC-S json memory leak.
Richard Mudgett [Thu, 2 Nov 2017 16:38:23 +0000 (11:38 -0500)]
AOC: Fix AOC-S json memory leak.

Change-Id: I3a1d40a41a8a7d00fa4a187de6a343a79155d3ef

2 years agores_stasis_device_state.c: Optimize stasis_app_device_states_to_json()
Richard Mudgett [Wed, 1 Nov 2017 23:04:31 +0000 (18:04 -0500)]
res_stasis_device_state.c: Optimize stasis_app_device_states_to_json()

* Eliminate RAII_VAR()
* Replace looped alloca with a char[] since that is how it is used anyway.

Change-Id: Ia27e64a884afa0f50b9ffdb1cf23da6bfa51ffdf

2 years agores_stasis_mailbox.c: Fix leak of mailbox container.
Richard Mudgett [Wed, 1 Nov 2017 23:58:08 +0000 (18:58 -0500)]
res_stasis_mailbox.c: Fix leak of mailbox container.

Change-Id: I7d33c1635713047e7d1597c9d882f7dc006d94b4

2 years agoBuild System: Fix build failure caused by recent CLI improvements.
Corey Farrell [Fri, 3 Nov 2017 15:35:34 +0000 (11:35 -0400)]
Build System: Fix build failure caused by recent CLI improvements.

We use the editline library to help with filename completion in our CLI
interface.  Some systems failed to find the header when included from
loader.c.  This is fixed by setting the proper CFLAGS for the build of
loader.o.

ASTERISK-27378

Change-Id: Ib7fd496f1d7ed48141a2eadd5dd61cab2f2308be

2 years agoMerge "res_pjsip: Add to list of valid characters for from_user."
Joshua Colp [Fri, 3 Nov 2017 14:06:47 +0000 (09:06 -0500)]
Merge "res_pjsip: Add to list of valid characters for from_user."

2 years agoMerge "Modules: Additional improvements to CLI completion."
Joshua Colp [Fri, 3 Nov 2017 12:55:27 +0000 (07:55 -0500)]
Merge "Modules: Additional improvements to CLI completion."

2 years agoMerge "res/ari/resource_bridges.h: Update from 'make ari-stubs'."
Joshua Colp [Thu, 2 Nov 2017 19:08:41 +0000 (14:08 -0500)]
Merge "res/ari/resource_bridges.h: Update from 'make ari-stubs'."

2 years agores_pjsip: Add to list of valid characters for from_user.
Ben Ford [Wed, 1 Nov 2017 16:12:45 +0000 (11:12 -0500)]
res_pjsip: Add to list of valid characters for from_user.

Fixes a regression where some characters were unable to be used in
the from_user field of an endpoint. Additionally, the backtick was
removed from the list of valid characters, since it is not valid,
and it was replaced with a single quote, which is a valid character.

ASTERISK-27387

Change-Id: Id80c10a644508365c87b3182e99ea49da11b0281

2 years agoMerge "core: Don't attempt to write to a stream that does not exist."
Joshua Colp [Thu, 2 Nov 2017 16:09:41 +0000 (11:09 -0500)]
Merge "core: Don't attempt to write to a stream that does not exist."

2 years agocore: Don't attempt to write to a stream that does not exist.
Joshua Colp [Thu, 2 Nov 2017 10:34:46 +0000 (07:34 -0300)]
core: Don't attempt to write to a stream that does not exist.

When a frame is provided to ast_write ensure that a multistream
capable channel has a stream for it before attempting to give it
to the channel driver. In some cases (such as a deferred SDP
negotiation) the stream may not yet exist.

ASTERISK-27364

Change-Id: Icf84ca982a67cdd6e9a71851eb7eb1bd0e865276

2 years agoAdd missing menuselect dependencies.
Corey Farrell [Thu, 2 Nov 2017 06:57:52 +0000 (02:57 -0400)]
Add missing menuselect dependencies.

This adds menuselect dependencies for modules that use symbols of other
modules.

ASTERISK-27390

Change-Id: Ia2d2849f5b87a72af7324a82edc3f283eafb5385

2 years agores/ari/resource_bridges.h: Update from 'make ari-stubs'.
Corey Farrell [Thu, 2 Nov 2017 03:57:28 +0000 (23:57 -0400)]
res/ari/resource_bridges.h: Update from 'make ari-stubs'.

A comment was updated when I ran 'make ari-stubs'.

Change-Id: Ib5154ae3ad72aff53374c28ead540fe349c42175

2 years agoPrevent unload of modules which implement an Optional API.
Corey Farrell [Thu, 2 Nov 2017 00:46:11 +0000 (20:46 -0400)]
Prevent unload of modules which implement an Optional API.

Once an Optional API module is loaded it should stay loaded.  Unloading
an optional API module runs the risk of a crash if something else is
using it.  This patch causes all optional API providers to tell the
module loader not to unload except at shutdown.

ASTERISK-27389

Change-Id: Ia07786fe655681aec49cc8d3d96e06483b11f5e6

2 years agoModules: Additional improvements to CLI completion.
Corey Farrell [Mon, 30 Oct 2017 22:30:18 +0000 (18:30 -0400)]
Modules: Additional improvements to CLI completion.

Replace 'needsreload' argument with a 'type' argument to specify which
type of modules you want completion.  This provides more accurate CLI
completion for load and unload commands.

* 'module unload' now excludes modules that have active references or are
  not running.
* 'module load' now excludes modules that are already running.
* 'core set debug [atleast] <level> [module]' shows running modules only.

ASTERISK-27378

Change-Id: Iea3e00054461484196c46f688f02635cc886bad1

2 years agopjsip_message_filter: Only do interface lookup for wildcard addresses.
Sean Bright [Wed, 1 Nov 2017 18:58:32 +0000 (14:58 -0400)]
pjsip_message_filter: Only do interface lookup for wildcard addresses.

Change-Id: Ie083987e69dc43b6861671c218cacacc11b2072f

2 years agoMerge "features: Bridge application's BRIDGERESULT not appropriately set"
Joshua Colp [Wed, 1 Nov 2017 14:22:17 +0000 (09:22 -0500)]
Merge "features: Bridge application's BRIDGERESULT not appropriately set"

2 years agoMerge "res_ari_channels: Fix reference leak in channel_state_invalid."
Joshua Colp [Wed, 1 Nov 2017 12:42:08 +0000 (07:42 -0500)]
Merge "res_ari_channels: Fix reference leak in channel_state_invalid."

2 years agofeatures: Bridge application's BRIDGERESULT not appropriately set
Kevin Harwell [Tue, 31 Oct 2017 20:08:38 +0000 (15:08 -0500)]
features: Bridge application's BRIDGERESULT not appropriately set

The dialplan application "Bridge" was not setting the BRIDGERESULT to failure
when a failure did occur. Even worse if it did fail to join the bridge it would
still report success.

This patch now sets the BRIDGERESULT variable to an appropriate value for a
given condition state. Also, removed the value INCOMPATIBLE as a valid result
type since it is no longer used.

ASTERISK-27369 #close

Change-Id: I22588e7125a765edf35cff28c98ca143e9927554

2 years agoMerge "Build System: Fix --disable-xmldoc option."
Joshua Colp [Tue, 31 Oct 2017 20:14:53 +0000 (15:14 -0500)]
Merge "Build System: Fix --disable-xmldoc option."

2 years agores_ari_channels: Fix reference leak in channel_state_invalid.
Corey Farrell [Tue, 31 Oct 2017 18:18:45 +0000 (14:18 -0400)]
res_ari_channels: Fix reference leak in channel_state_invalid.

channel_state_invalid leaked a reference to the channel snapshot any
time it was aquired.

ASTERISK-27067 #close

Change-Id: I8c653f00416b39978513c5605c4be0f03b1df29a

2 years agoMerge "core / pjsip: Add support for grouping streams together."
Joshua Colp [Tue, 31 Oct 2017 18:27:40 +0000 (13:27 -0500)]
Merge "core / pjsip: Add support for grouping streams together."

2 years agoMerge "ast_coredumper: allow setting asterisk binary explicitly"
Joshua Colp [Tue, 31 Oct 2017 11:48:16 +0000 (06:48 -0500)]
Merge "ast_coredumper: allow setting asterisk binary explicitly"

2 years agoMerge "Modules: Fix issues with CLI completion."
Joshua Colp [Mon, 30 Oct 2017 22:18:59 +0000 (17:18 -0500)]
Merge "Modules: Fix issues with CLI completion."

2 years agocore / pjsip: Add support for grouping streams together.
Joshua Colp [Wed, 25 Oct 2017 22:31:33 +0000 (22:31 +0000)]
core / pjsip: Add support for grouping streams together.

In WebRTC streams (or media tracks in their world) can be grouped
together using the mslabel. This informs the browser that each
should be synchronized with each other.

This change extends the stream API so this information can
be stored with streams. The PJSIP support has been extended
to use the mslabel to determine grouped streams and store
this association on the streams. Finally when creating the
SDP the group information is used to cause each media stream
to use the same mslabel.

ASTERISK-27379

Change-Id: Id6299aa031efe46254edbdc7973c534d54d641ad

2 years agoMerge "alembic: Add bundle column in ps_endpoints table"
Joshua Colp [Mon, 30 Oct 2017 16:56:56 +0000 (11:56 -0500)]
Merge "alembic: Add bundle column in ps_endpoints table"

2 years agoMerge "app_agent_spool: Fix typo in dtmf features usage desctiption"
Joshua Colp [Mon, 30 Oct 2017 16:08:52 +0000 (11:08 -0500)]
Merge "app_agent_spool: Fix typo in dtmf features usage desctiption"

2 years agoMerge "ast_coredumper: Add gzipping of binaries and display of signal info"
Joshua Colp [Mon, 30 Oct 2017 15:53:42 +0000 (10:53 -0500)]
Merge "ast_coredumper:  Add gzipping of binaries and display of signal info"

2 years agoast_coredumper: allow setting asterisk binary explicitly
Tzafrir Cohen [Mon, 30 Oct 2017 14:20:18 +0000 (16:20 +0200)]
ast_coredumper: allow setting asterisk binary explicitly

Adds an extra option, --asterisk-bin=<path> to ast_coredumper. If
provided, the binary given to gdb will be the parameter, rather than
asterisk from the PATH.

ASTERISK-27380 #close

Change-Id: I25f5b91eb75059b0fb2f142e468c26b283b0a9f3

2 years agoalembic: Add bundle column in ps_endpoints table
Florian Floimair [Wed, 25 Oct 2017 06:10:29 +0000 (08:10 +0200)]
alembic: Add bundle column in ps_endpoints table

The ps_endpoints table was missing the bundle column
introduced with the bundle feature in
commit 065c3005ad92.

ASTERISK-27374 #close

Change-Id: Ic900f4f2c20f64b99ea898d50f5c0a7117472d46

2 years agoModules: Fix issues with CLI completion.
Corey Farrell [Mon, 30 Oct 2017 05:32:32 +0000 (01:32 -0400)]
Modules: Fix issues with CLI completion.

* Stop using ast_module_helper to check if a module is loaded, use
  ast_module_check instead (app_confbridge and app_meetme).
* Stop ast_module_helper from listing reload classes when needsreload
  was not requested.

ASTERISK-27378

Change-Id: Iaed8c1e4fcbeb242921dbac7929a0fe75ff4b239

2 years agoapp_agent_spool: Fix typo in dtmf features usage desctiption
Igor Goncharovskiy [Sun, 29 Oct 2017 00:18:21 +0000 (06:18 +0600)]
app_agent_spool: Fix typo in dtmf features usage desctiption

Fix typo, that specify usage wrong option 'dtmf-features' for CHANNEL() function
instead of correct 'dtmf_features'

ASTERISK-27377 #close

Change-Id: I15ecc829c1035b359584673e12cdb5c9291ac930

2 years agores_pjsip_pubsub: Resolve potential crash in allocate_subscription.
Corey Farrell [Fri, 27 Oct 2017 18:41:15 +0000 (14:41 -0400)]
res_pjsip_pubsub: Resolve potential crash in allocate_subscription.

When allocate_subscription fails to initialize fields of the new sub it
calls destroy_subscription.

Change-Id: I5b79c915ec216dc00c13c1e4172137864a4bec85

2 years agoMerge "codec.c: Defensively check the returned samples."
Joshua Colp [Fri, 27 Oct 2017 14:19:11 +0000 (09:19 -0500)]
Merge "codec.c: Defensively check the returned samples."

2 years agoMerge "app_voicemail.c: Fix compiler warning with IMAP build."
Joshua Colp [Fri, 27 Oct 2017 13:41:09 +0000 (08:41 -0500)]
Merge "app_voicemail.c: Fix compiler warning with IMAP build."

2 years agoMerge "res_pjsip: Add 'ip' as a valid option to 'identify_by' on endpoint."
Joshua Colp [Thu, 26 Oct 2017 23:45:40 +0000 (18:45 -0500)]
Merge "res_pjsip: Add 'ip' as a valid option to 'identify_by' on endpoint."

2 years agoapp_voicemail.c: Fix compiler warning with IMAP build.
Richard Mudgett [Thu, 26 Oct 2017 17:18:00 +0000 (12:18 -0500)]
app_voicemail.c: Fix compiler warning with IMAP build.

ASTERISK-27181

Change-Id: Ic4468b49860bd7f67e922baf4c9e96828c184d17

2 years agocodec.c: Defensively check the returned samples.
Richard Mudgett [Wed, 25 Oct 2017 19:38:19 +0000 (14:38 -0500)]
codec.c: Defensively check the returned samples.

Earlier versions of the codec_opus samples_count callback can return
negative error values on undecodable frames.  This resulted in a divide by
zero exception.

* Added a defensive check in ast_codec_samples_count() for a "negative"
samples count return value.  Log the event and set the count to zero.

ASTERISK-27194

Change-Id: Icf69350307ecbbc80a3d74de46af9bd80ea17819

2 years agoMerge "Single API for ast_store_lock_info and ast_remove_lock_info."
Joshua Colp [Wed, 25 Oct 2017 23:09:16 +0000 (18:09 -0500)]
Merge "Single API for ast_store_lock_info and ast_remove_lock_info."

2 years agores_pjsip: Add 'ip' as a valid option to 'identify_by' on endpoint.
Joshua Colp [Tue, 24 Oct 2017 15:33:57 +0000 (15:33 +0000)]
res_pjsip: Add 'ip' as a valid option to 'identify_by' on endpoint.

When the identify_by option on an endpoint is set to ip it will
only be identified using the res_pjsip_endpoint_identifier_ip module.
This ensures that it is not mistakenly matched using the username of
the From header. To ensure behavior has not changed the default has
been changed to "username,ip" for the identify_by option.

ASTERISK-27206

Change-Id: I2170b86a7f7e221b4f00bf14aa1ef1ac5b050bbd

2 years agoast_coredumper: Add gzipping of binaries and display of signal info
George Joseph [Wed, 25 Oct 2017 17:26:06 +0000 (11:26 -0600)]
ast_coredumper:  Add gzipping of binaries and display of signal info

The --tarball-coredump option now creates a gzipped tarball of
coredumps processed, their results txt files and copies of
/etc/os-release, /usr/sbin/asterisk, /usr/lib(64)/libasterisk* and
/usr/lib(64)/asterisk as those files are needed to properly examine
the coredump.  The file will be named
/tmp/asterisk.<timestamp>.coredumps.tar.gz or
/tmp/asterisk-<uniqueid>.coredumps.tar.gz if --tarball-uniqueid was
specified.

Added dumps of *_siginfo to the top of the txt files so you can
tell what signal was invoked.

Change-Id: Ib9ee6d83592d4b1bc90cb3419a05376a88d1ded9

2 years agohttp.c: Fix http header send content.
Ben Ford [Wed, 25 Oct 2017 14:23:55 +0000 (09:23 -0500)]
http.c: Fix http header send content.

Currently ast_http_send barricades a portion of the content that
needs to be sent in order to establish a connection for things
like the ARI client. The conditional and contents have been changed
to ensure that everything that needs to be sent, will be sent.

ASTERISK-27372

Change-Id: I8816d2d8f80f4fefc6dcae4b5fdfc97f1e46496d

2 years agoBuild System: Fix --disable-xmldoc option.
Corey Farrell [Thu, 30 Mar 2017 14:51:14 +0000 (10:51 -0400)]
Build System: Fix --disable-xmldoc option.

The configure option to disable XML documentation does not currently
work.  This patch makes it effective, but also causes an ABI change by
removing the ast_xmldoc_* symbols.  Disabling xmldoc also prevents docs
from being automatically generated, but they can still be manually
generated with 'make doc/core-en_US.xml'.

ASTERISK-26639

Change-Id: Ifac562340c09f80c83e0203de098fcac93bf8c44

2 years agoMerge "Bundled pjproject: Enable pj_assert when dev-mode is enabled."
Joshua Colp [Wed, 25 Oct 2017 14:03:19 +0000 (09:03 -0500)]
Merge "Bundled pjproject: Enable pj_assert when dev-mode is enabled."

2 years agoMerge "chan_sip: Fix SUBSCRIBE with missing "Expires" header."
Joshua Colp [Wed, 25 Oct 2017 13:17:40 +0000 (08:17 -0500)]
Merge "chan_sip: Fix SUBSCRIBE with missing "Expires" header."

2 years agoMerge "hashtab: Use ast_free."
Joshua Colp [Wed, 25 Oct 2017 12:34:23 +0000 (07:34 -0500)]
Merge "hashtab: Use ast_free."

2 years agoMerge "res_pjsip_sdp_rtp: Fix setting of address type for rtp_ipv6"
Joshua Colp [Wed, 25 Oct 2017 11:39:29 +0000 (06:39 -0500)]
Merge "res_pjsip_sdp_rtp:  Fix setting of address type for rtp_ipv6"

2 years agoMerge "main/Makefile: Remove rule for non-existant testexpr2."
Joshua Colp [Wed, 25 Oct 2017 10:24:52 +0000 (05:24 -0500)]
Merge "main/Makefile: Remove rule for non-existant testexpr2."

2 years agoMerge "res_xmpp: Ensure the connection filter is available."
Joshua Colp [Tue, 24 Oct 2017 20:40:54 +0000 (15:40 -0500)]
Merge "res_xmpp: Ensure the connection filter is available."

2 years agoSingle API for ast_store_lock_info and ast_remove_lock_info.
Corey Farrell [Mon, 23 Oct 2017 05:55:18 +0000 (01:55 -0400)]
Single API for ast_store_lock_info and ast_remove_lock_info.

This makes the 'bt' parameter unconditional for ast_store_lock_info and
ast_remove_lock_info.  The 'bt' parameter is unused when HAVE_BKTR is
undefined.

Change-Id: Ieced0e920928b735a39c3b5952b806c473d67453

2 years agoMerge "lpc10: Avoid compiler warning when DONT_OPTIMIZE/COMPILE_DOUBLE."
George Joseph [Tue, 24 Oct 2017 19:26:15 +0000 (14:26 -0500)]
Merge "lpc10: Avoid compiler warning when DONT_OPTIMIZE/COMPILE_DOUBLE."

2 years agoMerge "test_config: Fix failure and segfault when config_hook is run twice."
Joshua Colp [Tue, 24 Oct 2017 18:56:43 +0000 (13:56 -0500)]
Merge "test_config: Fix failure and segfault when config_hook is run twice."

2 years agochan_sip: Fix SUBSCRIBE with missing "Expires" header.
Corey Farrell [Tue, 24 Oct 2017 14:43:15 +0000 (10:43 -0400)]
chan_sip: Fix SUBSCRIBE with missing "Expires" header.

When chan_sip receives a SUBSCRIBE request with no "Expires" header it
processes the request as an unsubscribe.  This is incorrect, per RFC3264
when the "Expires" header is missing a default expiry should be used.

ASTERISK-18140

Change-Id: Ibf6dcd4fdd07a32c2bc38be1dd557981f08188b5

2 years agoMerge "res_pjproject.c: Upgrade bundled PJPROJECT to 2.7"
Joshua Colp [Tue, 24 Oct 2017 15:04:24 +0000 (10:04 -0500)]
Merge "res_pjproject.c: Upgrade bundled PJPROJECT to 2.7"

2 years agoMerge "chan_sip: Crypto attribute not last but first on SDP media level."
Joshua Colp [Tue, 24 Oct 2017 14:28:36 +0000 (09:28 -0500)]
Merge "chan_sip: Crypto attribute not last but first on SDP media level."

2 years agolpc10: Avoid compiler warning when DONT_OPTIMIZE/COMPILE_DOUBLE.
Alexander Traud [Tue, 24 Oct 2017 12:24:17 +0000 (14:24 +0200)]
lpc10: Avoid compiler warning when DONT_OPTIMIZE/COMPILE_DOUBLE.

ASTERISK-23556
Reported by: Marcello Ceschia

Change-Id: Ic27e88e0336a0d83877dc857938659dc5560b93c

2 years agohashtab: Use ast_free.
Corey Farrell [Sat, 7 Oct 2017 17:14:08 +0000 (13:14 -0400)]
hashtab: Use ast_free.

A few places in hashtab use free instead of ast_free, remove declaration
of ASTMM_LIBC from hashtab.c as it's no longer needed.

Change-Id: I2ff089bad71640c03c3ce97f1b00fc962ef79427

2 years agoBundled pjproject: Enable pj_assert when dev-mode is enabled.
Corey Farrell [Mon, 23 Oct 2017 06:02:22 +0000 (02:02 -0400)]
Bundled pjproject: Enable pj_assert when dev-mode is enabled.

ASTERISK-27359

Change-Id: Ib01fb6c01f9bb87129374a51cb9318c474147517

2 years agomain/Makefile: Remove rule for non-existant testexpr2.
Corey Farrell [Mon, 23 Oct 2017 18:44:36 +0000 (14:44 -0400)]
main/Makefile: Remove rule for non-existant testexpr2.

Change-Id: Ibb3e47f27a395d74d8c5263db015b05434f5969b

2 years agotest_config: Fix failure and segfault when config_hook is run twice.
Corey Farrell [Mon, 23 Oct 2017 17:42:37 +0000 (13:42 -0400)]
test_config: Fix failure and segfault when config_hook is run twice.

On second run the config_hook test was unexpectedly failing to load
test_config.conf because it was still unmodified since the last load.
This is fixed by not passing CONFIG_FLAG_FILEUNCHANGED for the initial
loads, only using it when we are tested that a reload of unmodified
files do not initiate the hook.

ASTERISK-25960

Change-Id: Ifd679509a23ed163e5cc647490bf7df4ae3cd856

2 years agores_pjsip_sdp_rtp: Fix setting of address type for rtp_ipv6
George Joseph [Mon, 23 Oct 2017 17:23:04 +0000 (11:23 -0600)]
res_pjsip_sdp_rtp:  Fix setting of address type for rtp_ipv6

create_outgoing_sdp_stream was setting "addr_type = STR_IP6" only
when an ipv6 media_address was specified on the endpoint.  If
rtp_ipv6 was set and ast_sip_get_host_ip_string returned an ipv6
address, we were leaving the addr_type set at the default of
STR_IP4.  This caused the address type to be set incorrectly on the
"o" and "c" SDP attributes even though the address was set
correctly.  Some clients don't like the mismatch.

 * Removed the test for endpoint/media_address and now check all
   addresses for ipv6.

ASTERISK-27198
Reported by: Martin Cis├írik

Change-Id: I5214fc31b728117842243807e7927a319cf77592

2 years agoMerge "bridge_softmix: Reduce topology cloning and improve renegotiation."
Joshua Colp [Mon, 23 Oct 2017 16:07:16 +0000 (11:07 -0500)]
Merge "bridge_softmix: Reduce topology cloning and improve renegotiation."

2 years agoapp_agent_pool.c: Fix online documentation typo.
Richard Mudgett [Mon, 23 Oct 2017 12:53:48 +0000 (07:53 -0500)]
app_agent_pool.c: Fix online documentation typo.

Change-Id: Ib0bc95fd0ec288c78c313823254d7a84ebfc4429

2 years agores_xmpp: Ensure the connection filter is available.
Joshua Colp [Sun, 22 Oct 2017 22:32:20 +0000 (19:32 -0300)]
res_xmpp: Ensure the connection filter is available.

Users of the API that res_xmpp provides expect that a
filter be available on the client at all times. When
OAuth authentication support was added this requirement
was not maintained.

This change merely moves the OAuth authentication to
after the filter is created, ensuring users of res_xmpp
can add things to the filter as needed.

ASTERISK-27346

Change-Id: I4ac474afe220e833288ff574e32e2b9a23394886

2 years agochan_sip: Crypto attribute not last but first on SDP media level.
Alexander Traud [Sat, 21 Oct 2017 08:44:21 +0000 (10:44 +0200)]
chan_sip: Crypto attribute not last but first on SDP media level.

This matches the behavior of the other SIP channel driver, chan_pjsip.

ASTERISK-27365

Change-Id: I8f23a51290a58b75816da2999ed1965441dfc5d6

2 years agores_pjproject.c: Upgrade bundled PJPROJECT to 2.7
Richard Mudgett [Tue, 17 Oct 2017 15:53:52 +0000 (10:53 -0500)]
res_pjproject.c: Upgrade bundled PJPROJECT to 2.7

Update patches included in bundled PJPROJECT for the new version.

ASTERISK-27355

Change-Id: I9ac5dbbffaadca25ad24fac8b9ab615e5ace6083

2 years agores_pjsip_pubsub: Prevent unload except during shutdown.
Corey Farrell [Wed, 18 Oct 2017 18:41:25 +0000 (14:41 -0400)]
res_pjsip_pubsub: Prevent unload except during shutdown.

Prevent unload of the module as certain pjsip initialization functions
cannot be reversed.  This required a reorder of the module_load so that
the non-reversable pjsip functions are not called until all potential
errors have been ruled out.

ASTERISK-24483

Change-Id: Iee900f20bdd6ee1bfe23efdec0d87765eadce8a7

2 years agoMerge "chan_sip: Fix output of 'sip set debug off'."
Joshua Colp [Thu, 19 Oct 2017 13:14:22 +0000 (08:14 -0500)]
Merge "chan_sip: Fix output of 'sip set debug off'."

2 years agoMerge "res_pjsip_refer: Prevent unload except during shutdown."
Joshua Colp [Thu, 19 Oct 2017 12:24:59 +0000 (07:24 -0500)]
Merge "res_pjsip_refer: Prevent unload except during shutdown."

2 years agoMerge "app_macro deprecation."
Joshua Colp [Thu, 19 Oct 2017 00:22:12 +0000 (19:22 -0500)]
Merge "app_macro deprecation."

2 years agores_pjsip_refer: Prevent unload except during shutdown.
Corey Farrell [Wed, 18 Oct 2017 18:37:57 +0000 (14:37 -0400)]
res_pjsip_refer: Prevent unload except during shutdown.

Prevent unload of the module as certain pjsip initialization functions
cannot be reversed.

ASTERISK-24483

Change-Id: I94597ec8b8491f5af9c57bf66dbc3b078fe2d49d

2 years agochan_sip: Fix output of 'sip set debug off'.
Corey Farrell [Wed, 18 Oct 2017 17:04:29 +0000 (13:04 -0400)]
chan_sip: Fix output of 'sip set debug off'.

When sip.conf contains 'sipdebug=yes' it is impossible to disable it
using CLI 'sip set debug off'.  This corrects the output of that CLI
command to instruct the user to turn sipdebug off in the configuration
file.

ASTERISK-23462 #close

Change-Id: I1cceade9caa9578e1b060feb832e3495ef5ad318

2 years agoapp_macro deprecation.
Corey Farrell [Mon, 16 Oct 2017 15:53:07 +0000 (11:53 -0400)]
app_macro deprecation.

* Mark the module deprecated.
* Disable the module by default.
* Produce a warning the first time a macro is used.
* Note deprecation related options in app_dial and app_queue.

ASTERISK-27350

Change-Id: I560ea043bacdbc5534a17d97854273d52c2f1bdc

2 years agores_srtp: Add support for libsrtp2 with AES-GCM.
Alexander Traud [Wed, 18 Oct 2017 08:30:25 +0000 (10:30 +0200)]
res_srtp: Add support for libsrtp2 with AES-GCM.

Beside allowing AES-GCM again, this adds AES-192 again.

ASTERISK-27356

Change-Id: Ia97a435faf26300335d9552fa676b5d17e5f7233

2 years agoMerge "res_corosync: Fix linking issue with Corosync 2.x"
Jenkins2 [Tue, 17 Oct 2017 16:08:13 +0000 (11:08 -0500)]
Merge "res_corosync: Fix linking issue with Corosync 2.x"

2 years agoMerge "cdr.c: Rename the Party A CDR container."
Joshua Colp [Tue, 17 Oct 2017 16:06:16 +0000 (11:06 -0500)]
Merge "cdr.c: Rename the Party A CDR container."

2 years agoMerge "cdr.c: Add container to key off of Party B channel names."
Jenkins2 [Tue, 17 Oct 2017 15:44:34 +0000 (10:44 -0500)]
Merge "cdr.c: Add container to key off of Party B channel names."

2 years agoMerge "contrib/script/sip_to_pjsip: implement 'all' for allow/disallow"
Jenkins2 [Tue, 17 Oct 2017 14:32:00 +0000 (09:32 -0500)]
Merge "contrib/script/sip_to_pjsip: implement 'all' for allow/disallow"

2 years agoMerge "bridge_simple: Improve renegotiation success rate."
Jenkins2 [Tue, 17 Oct 2017 13:49:20 +0000 (08:49 -0500)]
Merge "bridge_simple: Improve renegotiation success rate."