asterisk/asterisk.git
11 years agoFix handling of notification calls w/ the dialing api
Terry Wilson [Tue, 13 Oct 2009 01:51:46 +0000 (01:51 +0000)]
Fix handling of notification calls w/ the dialing api

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@223874 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 223804 via svnmerge from
Jeff Peeler [Mon, 12 Oct 2009 23:48:09 +0000 (23:48 +0000)]
Merged revisions 223804 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r223804 | jpeeler | 2009-10-12 18:12:50 -0500 (Mon, 12 Oct 2009) | 8 lines

  Ensure ringing continues for branched calls after progress is received

  While waiting for an answer, don't send progress for branched calls
  for which ringing was sent.

  (closes issue #15028)
  Reported by: fnordian
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@223832 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoClarifies trunkmaxsize, trunkfreq, and trunkmtu iax2 options
David Vossel [Mon, 12 Oct 2009 20:58:27 +0000 (20:58 +0000)]
Clarifies trunkmaxsize, trunkfreq, and trunkmtu iax2 options

SWP-151

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@223756 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoRecorded merge of revisions 223692 via svnmerge from
Kevin P. Fleming [Mon, 12 Oct 2009 15:32:11 +0000 (15:32 +0000)]
Recorded merge of revisions 223692 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r223692 | kpfleming | 2009-10-12 10:30:40 -0500 (Mon, 12 Oct 2009) | 13 lines

  Remove automatic switching from T.38 to voice mode in chan_sip.

  chan_sip has some code to automatically switch from T.38 mode to voice mode when
  a voice frame is written to the channel while it is in T.38 mode; this was
  intended to handle the situation when a FAX transmission has ended and the channel
  is not yet hung up, but is causing problems at the beginning of FAX sessions as
  well when there are still voice frames 'in flight' at the time the T.38 negotiation
  completes. This patch removes the automatic switchover.

  (issue #16025)
  Reported by: jamicque
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@223693 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoRemove automatic switching from T.38 to voice mode in chan_sip.
Kevin P. Fleming [Mon, 12 Oct 2009 14:25:29 +0000 (14:25 +0000)]
Remove automatic switching from T.38 to voice mode in chan_sip.

chan_sip has some code to automatically switch from T.38 mode to voice mode when
a voice frame is written to the channel while it is in T.38 mode; this was
intended to handle the situation when a FAX transmission has ended and the channel
is not yet hung up, but is causing problems at the beginning of FAX sessions as
well when there are still voice frames 'in flight' at the time the T.38 negotiation
completes. This patch removes the automatic switchover, and changes app_fax to
explicitly switch off T.38 mode when the FAX transmission process ends.

(closes issue #16025)
Reported by: jamicque

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@223652 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoCheck the proper page for the SENDRPID flag.
Mark Michelson [Sun, 11 Oct 2009 22:19:22 +0000 (22:19 +0000)]
Check the proper page for the SENDRPID flag.

If a pending reinvite were sent, we might not properly
send connected party info since we were checking the wrong
flag. This was a rare occurrence, but could still happen
nevertheless.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@223617 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 223550 via svnmerge from
Russell Bryant [Sun, 11 Oct 2009 18:35:24 +0000 (18:35 +0000)]
Merged revisions 223550 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r223550 | russell | 2009-10-11 13:34:37 -0500 (Sun, 11 Oct 2009) | 2 lines

  Remove a duplicate ao2_iterator_destroy().
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@223553 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 223485-223486 via svnmerge from
Russell Bryant [Sun, 11 Oct 2009 17:25:42 +0000 (17:25 +0000)]
Merged revisions 223485-223486 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r223485 | russell | 2009-10-11 12:22:52 -0500 (Sun, 11 Oct 2009) | 6 lines

  Don't use data outside of its scope.

  The purpose of this code was to have a hangup frame put on the list of deferred
  frames.  However, the code that read the hangup frame was outside of the scope
  of where the hangup frame was declared.
........
  r223486 | russell | 2009-10-11 12:25:06 -0500 (Sun, 11 Oct 2009) | 2 lines

  Remove some unnecessary code.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@223487 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoFix handling of floating times and dates
Terry Wilson [Sat, 10 Oct 2009 20:02:32 +0000 (20:02 +0000)]
Fix handling of floating times and dates

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@223449 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoAdding note about TLS usage
Olle Johansson [Sat, 10 Oct 2009 08:30:24 +0000 (08:30 +0000)]
Adding note about TLS usage

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@223415 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoAdd an additional note on TLS support
Olle Johansson [Sat, 10 Oct 2009 08:29:03 +0000 (08:29 +0000)]
Add an additional note on TLS support

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@223414 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoAdding some information on TLS support
Olle Johansson [Sat, 10 Oct 2009 08:28:21 +0000 (08:28 +0000)]
Adding some information on TLS support

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@223413 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoProperly return "free" on confirmed events that are free
Terry Wilson [Fri, 9 Oct 2009 22:04:04 +0000 (22:04 +0000)]
Properly return "free" on confirmed events that are free

CONFIRMED status doesn't imply busy or free, that is handled with the TRANSP
field. Luckily, libical already sets the is_busy status on the span for us.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@223370 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoInitiate T.38 switchover when acting as called party, regardless of FAX direction.
Kevin P. Fleming [Fri, 9 Oct 2009 20:58:44 +0000 (20:58 +0000)]
Initiate T.38 switchover when acting as called party, regardless of FAX direction.

SendFAX() and ReceiveFAX() can be given options to indicate whether they should
act as the calling or called party; this mode should be used to decide whether
to initiate a switchover to T.38, not the direction that the FAX transfer will
take place.

(closes issue #16039)
Reported by: jamicque

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@223330 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 223225 via svnmerge from
Matthew Nicholson [Fri, 9 Oct 2009 18:34:08 +0000 (18:34 +0000)]
Merged revisions 223225 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r223225 | mnicholson | 2009-10-09 13:20:11 -0500 (Fri, 09 Oct 2009) | 8 lines

  Signal timeouts by returning AST_CONTROL_RINGING when originating calls.
  (closes issue #15104)
  Reported by: nblasgen
  Patches:
        manager-timeout1.diff uploaded by mnicholson (license 96)
  Tested by: nblasgen, mnicholson
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@223273 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoRecorded merge of revisions 223213 via svnmerge from
Mark Michelson [Fri, 9 Oct 2009 18:17:34 +0000 (18:17 +0000)]
Recorded merge of revisions 223213 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r223213 | mmichelson | 2009-10-09 13:17:12 -0500 (Fri, 09 Oct 2009) | 3 lines

  Fix potential memory leak in app_dial.c
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@223215 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoFix potential memory leaks.
Mark Michelson [Fri, 9 Oct 2009 18:13:57 +0000 (18:13 +0000)]
Fix potential memory leaks.

ABE-1998

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@223211 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 223205 via svnmerge from
David Vossel [Fri, 9 Oct 2009 17:53:37 +0000 (17:53 +0000)]
Merged revisions 223205 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r223205 | dvossel | 2009-10-09 12:52:35 -0500 (Fri, 09 Oct 2009) | 10 lines

  fixes sip registration using authuser in user.conf

  (closes issue #14954)
  Reported by: tornblad
  Tested by: mmichelson, tornblad, dvossel
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@223206 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoBlocked revisions 223142 via svnmerge
David Vossel [Fri, 9 Oct 2009 17:19:18 +0000 (17:19 +0000)]
Blocked revisions 223142 via svnmerge

........
  r223142 | dvossel | 2009-10-09 12:18:54 -0500 (Fri, 09 Oct 2009) | 9 lines

  'auth=' did not parse md5 secret correctly

  (closes issue https://issues.asterisk.org/view.php?id=15949)
  Reported by: ebroad
  Patches:
        authparsefix.patch uploaded by ebroad (license 878)
        15949_trunk.diff uploaded by dvossel (license 671)
  Tested by: ebroad
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@223144 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoDon't close the sqlite database when reloading. Only close the database when unloading.
Matthew Nicholson [Fri, 9 Oct 2009 17:14:38 +0000 (17:14 +0000)]
Don't close the sqlite database when reloading.  Only close the database when unloading.

(closes issue #15953)
Reported by: frawd
Patches:
      sqlite3_rev220097.diff uploaded by frawd (license 610)
Tested by: frawd

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@223136 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years ago'auth=' did not parse md5 secret correctly
David Vossel [Fri, 9 Oct 2009 16:54:02 +0000 (16:54 +0000)]
'auth=' did not parse md5 secret correctly

(closes issue #15949)
Reported by: ebroad
Patches:
      authparsefix.patch uploaded by ebroad (license 878)
      15949_trunk.diff uploaded by dvossel (license 671)
Tested by: ebroad

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@223132 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agop->peerauth is always empty in transmit_register()
David Vossel [Fri, 9 Oct 2009 15:49:30 +0000 (15:49 +0000)]
p->peerauth is always empty in transmit_register()

When using callbackextension or specifing the peer name
in a registration string, the peer's specific auth settings
set by the "auth=" strings within the peer definition are not
used by the registration.  Thanks to ebroad for reporting the
issue and providing the patch.

(closes issue #15955)
Reported by: ebroad
Patches:
      regauthfix.patch uploaded by ebroad (license 878)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@223088 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoDon't add Attendees during copy, replace them
Terry Wilson [Fri, 9 Oct 2009 15:00:49 +0000 (15:00 +0000)]
Don't add Attendees during copy, replace them

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@223053 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoRemove global variable that makes dlopen unhappy
Terry Wilson [Thu, 8 Oct 2009 23:11:23 +0000 (23:11 +0000)]
Remove global variable that makes dlopen unhappy

This isn't the best way to do this, but it is the easiest. There are some
limitations that are going to need to be addressed at some point with reloads
and when I (or someone else) work on that, then the API can be updated to
handle passing the private config data that the calendar tech modules need in
a better way as well.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@223016 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agofixed comment line for do_magic_pickup
David Vossel [Thu, 8 Oct 2009 22:57:53 +0000 (22:57 +0000)]
fixed comment line for do_magic_pickup

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@223015 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoDeadlock between ast_cel_report_event and ast_do_masquerade
David Vossel [Thu, 8 Oct 2009 22:04:41 +0000 (22:04 +0000)]
Deadlock between ast_cel_report_event and ast_do_masquerade

chan_sip calls pbx_exec on a pvt's owner channel while only the
pvt lock is held.  Since pbx_exec calls ast_cel_report_event which
attempts to lock the channel, invalid locking order occurs.  Channels
should be locked before pvt's.

(closes issue #15512)
Reported by: lmsteffan
Patches:
      ast_cel_deadlock_15512.diff uploaded by dvossel (license 671)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@222981 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agomakes externtcpport and externtlsport static variables
David Vossel [Thu, 8 Oct 2009 20:53:14 +0000 (20:53 +0000)]
makes externtcpport and externtlsport static variables

externtcpport and externtlsport need to be declared as static
variables.  Thanks to russell for finding and pointing this out.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@222947 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 222878 via svnmerge from
Russell Bryant [Thu, 8 Oct 2009 19:52:03 +0000 (19:52 +0000)]
Merged revisions 222878 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r222878 | russell | 2009-10-08 14:45:47 -0500 (Thu, 08 Oct 2009) | 44 lines

  Make filestream frame handling safer by isolating frames before returning them.

  This patch is related to a number of issues on the bug tracker that show
  crashes related to freeing frames that came from a filestream.  A number of
  fixes have been made over time while trying to figure out these problems, but
  there re still people seeing the crash.  (Note that some of these bug reports
  include information about other problems.  I am specifically addressing
  the filestream frame crash here.)

  I'm still not clear on what the exact problem is.  However, what is _very_
  clear is that we have seen quite a few problems over time related to unexpected
  behavior when we try to use embedded frames as an optimization.  In some cases,
  this optimization doesn't really provide much due to improvements made in other
  areas.

  In this case, the patch modifies filestream handling such that the embedded frame
  will not be returned.  ast_frisolate() is used to ensure that we end up with a
  completely mallocd frame.  In reality, though, we will not actually have to malloc
  every time.  For filestreams, the frame will almost always be allocated and freed
  in the same thread.  That means that the thread local frame cache will be used.
  So, going this route doesn't hurt.

  With this patch in place, some people have reported success in not seeing the
  crash anymore.

  (SWP-150)
  (AST-208)
  (ABE-1834)

  (issue #15609)
  Reported by: aragon
  Patches:
        filestream_frisolate-1.4.diff2.txt uploaded by russell (license 2)
  Tested by: aragon, russell

  (closes issue #15817)
  Reported by: zerohalo
  Tested by: zerohalo

  (closes issue #15845)
  Reported by: marhbere

  Review: https://reviewboard.asterisk.org/r/386/
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@222880 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoBlocked revisions 222877 via svnmerge
David Vossel [Thu, 8 Oct 2009 19:46:15 +0000 (19:46 +0000)]
Blocked revisions 222877 via svnmerge

........
  r222877 | dvossel | 2009-10-08 14:45:15 -0500 (Thu, 08 Oct 2009) | 6 lines

  fixes an ast_netsock_list memory leak.

  ABE-1998
  Review: https://reviewboard.asterisk.org/r/395/
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@222879 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agofixes an ast_netsock_list memory leak.
David Vossel [Thu, 8 Oct 2009 19:35:30 +0000 (19:35 +0000)]
fixes an ast_netsock_list memory leak.

ABE-1998
Review: https://reviewboard.asterisk.org/r/395/

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@222873 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 222797 via svnmerge from
Richard Mudgett [Thu, 8 Oct 2009 16:44:33 +0000 (16:44 +0000)]
Merged revisions 222797 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r222797 | rmudgett | 2009-10-08 11:33:06 -0500 (Thu, 08 Oct 2009) | 12 lines

  Fix memory leak if chan_misdn config parameter is repeated.

  Memory leak when the same config option is set more than once in an
  misdn.conf section.  Why must this be considered?  Templates!  Defining a
  template with default port options and later adding to or overriding some
  of them.

  Patches:
        memleak-misdn.patch

  JIRA ABE-1998
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@222799 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoDeadlock in channel masquerade handling
David Vossel [Wed, 7 Oct 2009 22:58:38 +0000 (22:58 +0000)]
Deadlock in channel masquerade handling

Channels are stored in an ao2_container.  When accessing an item within
an ao2_container the proper locking order is to first lock the container,
and then the items within it.

In ast_do_masquerade both the clone and original channel must be locked
for the entire duration of the function.  The problem with this is that
it attemptes to unlink and link these channels back into the ao2_container
when one of the channel's name changes.  This is invalid locking order as
the process of unlinking and linking will lock the ao2_container while
the channels are locked!!! Now, both the channels in do_masquerade are
unlinked from the ao2_container and then locked for the entire function.
At the end of the function both channels are unlocked and linked back
into the container with their new names as hash values.

This new method of requiring all channels and tech pvts to be unlocked
before ast_do_masquerade() or ast_change_name() required several
changes throughout the code base.

(closes issue #15911)
Reported by: russell
Patches:
      masq_deadlock_trunk.diff uploaded by dvossel (license 671)
Tested by: dvossel, atis

(closes issue #15618)
Reported by: lmsteffan
Patches:
      deadlock_local_attended_transfers_trunk.diff uploaded by dvossel (license 671)
Tested by: lmsteffan, dvossel

Review: https://reviewboard.asterisk.org/r/387/

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@222761 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 222691 via svnmerge from
Richard Mudgett [Wed, 7 Oct 2009 21:56:36 +0000 (21:56 +0000)]
Merged revisions 222691 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r222691 | rmudgett | 2009-10-07 16:51:24 -0500 (Wed, 07 Oct 2009) | 14 lines

  chan_misdn.c:process_ast_dsp() memory leak

  misdn.conf: astdtmf must be set to "yes".  With "no", buffer loss does not
  occur.

  The translated frame "f2" when passing through ast_dsp_process() is not
  freed whenever it is not used further in process_ast_dsp().  Then in the
  end it is never ever freed.

  Patches:
        translate.patch

  JIRA ABE-1993
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@222692 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoChange ringt (ring timeout) styles to be consistent across chan_dahdi.
Jeff Peeler [Wed, 7 Oct 2009 20:08:14 +0000 (20:08 +0000)]
Change ringt (ring timeout) styles to be consistent across chan_dahdi.

(closes issue #15684)
Reported by: alecdavis
Patches:
      chan_dahdi.bug15684.diff2.txt uploaded by alecdavis (license 585)
Tested by: alecdavis

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@222652 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoFormatting, moving error messages to ERROR, removing references to unexisting debug...
Olle Johansson [Wed, 7 Oct 2009 18:57:29 +0000 (18:57 +0000)]
Formatting, moving error messages to ERROR, removing references to unexisting debug output. No functionality changes.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@222615 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoUse extref for doxygen references to external libraries (in this case PostgreSQL)
Olle Johansson [Wed, 7 Oct 2009 18:55:25 +0000 (18:55 +0000)]
Use extref for doxygen references to external libraries (in this case PostgreSQL)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@222614 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoRemove 'keepstats' queue option from sample config, as it's no longer used.
Jason Parker [Wed, 7 Oct 2009 18:04:56 +0000 (18:04 +0000)]
Remove 'keepstats' queue option from sample config, as it's no longer used.

https://reviewboard.asterisk.org/r/115/

(closes issue #15820)
Reported by: kshumard

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@222548 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 222542 via svnmerge from
David Vossel [Wed, 7 Oct 2009 17:44:52 +0000 (17:44 +0000)]
Merged revisions 222542 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r222542 | dvossel | 2009-10-07 12:41:21 -0500 (Wed, 07 Oct 2009) | 8 lines

  crash on transfer

  handle_invite_replaces() attempts to uplock a pvt's
  owner channel without first verifing that it exists.

  (issue #16027)
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@222543 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 222462 via svnmerge from
Jeff Peeler [Tue, 6 Oct 2009 23:56:01 +0000 (23:56 +0000)]
Merged revisions 222462 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r222462 | jpeeler | 2009-10-06 18:51:19 -0500 (Tue, 06 Oct 2009) | 8 lines

  Add missing unlock(s) in dahdi_read

  (two cases in trunk)

  (closes issue #15683)
  Reported by: alecdavis
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@222463 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoUpdates CHANGES to reflect the new externtcpport and externtlsport sip options
David Vossel [Tue, 6 Oct 2009 22:49:30 +0000 (22:49 +0000)]
Updates CHANGES to reflect the new externtcpport and externtlsport sip options

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@222399 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agocontact header port ignored transport when using externip
David Vossel [Tue, 6 Oct 2009 22:39:56 +0000 (22:39 +0000)]
contact header port ignored transport when using externip

This patch adds support for TCP/TLS in the Contact header when using
NAT, specifically externip or externhost. The original issue was that
Asterisk sent 5060 as the port in the contact header whether TLS was
used or not. Additionally, this patch adds 2 config options to sip.conf,
specifically externtcpport and externtlsport. This allows a user to
specify different external ports for TCP and TLS other than those used
internally, this is especially useful in in a PAT/port redirection setup.
Thanks to ebroad for reporting the issue and providing the patch!

(closes issue #15880)
Reported by: ebroad
Patches:
      portmap.patch uploaded by ebroad (license 878)
      externtXXport_v2.patch uploaded by ebroad (license 878)
Tested by: ebroad

Review: https://reviewboard.asterisk.org/r/392/

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@222398 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoBlocked revisions 222393 via svnmerge
Jeff Peeler [Tue, 6 Oct 2009 22:27:44 +0000 (22:27 +0000)]
Blocked revisions 222393 via svnmerge

........
  r222393 | jpeeler | 2009-10-06 17:27:13 -0500 (Tue, 06 Oct 2009) | 11 lines

  Fix potential crash when entire span request is received.

  The variable index used in this scenario for accessing the dahdi_pvts was
  wrong and was most likely copied from the several other places it is used
  correctly.

  (closes issue #15998)
  Reported by: tsearle
  Patches:
        dahdi_reset_crash.patch uploaded by tsearle (license 373)
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@222394 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoFix 222298 (crash during destruction of second channel when variable set with
Jeff Peeler [Tue, 6 Oct 2009 20:35:19 +0000 (20:35 +0000)]
Fix 222298 (crash during destruction of second channel when variable set with
setvar).

I mistakenly reasoned that setvar would be used on all channels. Since it can
be set per channel, give each dahdi channel a copy of the variable.

(related to #15899)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@222351 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoChange schema query to involve the use of an optional schema parameter.
Tilghman Lesher [Tue, 6 Oct 2009 19:31:39 +0000 (19:31 +0000)]
Change schema query to involve the use of an optional schema parameter.
This change is done in such a way as to allow the driver to continue to
function with older databases which don't have these features.
(closes issue #16000)
 Reported by: jamicque
 Patches:
       20091002__issue16000.diff.txt uploaded by tilghman (license 14)
       20091002__issue16000__1.6.1.diff.txt uploaded by tilghman (license 14)
 Tested by: jamicque

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@222309 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoFix crash during destruction of second channel when variable set with setvar.
Jeff Peeler [Tue, 6 Oct 2009 19:24:59 +0000 (19:24 +0000)]
Fix crash during destruction of second channel when variable set with setvar.

The setvar line in chan_dahdi.conf is shared among all the channels, so make
sure to only free the resources only when the last channel is destroyed.

(closes issue #15899)
Reported by: tzafrir

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@222298 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoWhen we call a gosub routine, the variables should be scoped to avoid contaminating...
Tilghman Lesher [Tue, 6 Oct 2009 19:17:11 +0000 (19:17 +0000)]
When we call a gosub routine, the variables should be scoped to avoid contaminating the caller.
This affected the ~~EXTEN~~ hack, where a subroutine might have changed the
value before it was used in the caller.
Patch by myself, tested by ebroad on #asterisk

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@222273 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMake sure digit events are not reported as "ERROR"
Tzafrir Cohen [Tue, 6 Oct 2009 16:17:30 +0000 (16:17 +0000)]
Make sure digit events are not reported as "ERROR"

dahdievent_to_analogevent used a simple switch statement to convert DAHDI
event numbers to "ANALOG_*" event numbers. However "digit" events
(DAHDI_EVENT_PULSEDIGIT, DAHDI_EVENT_DTMFDOWN, DAHDI_EVENT_DTMFUP)
are accompannied by the digit in the low word of the event number.

This fix makes dahdievent_to_analogevent() return the event number as-is
for such an event.

This is also required to fix #15924 (in addition to r222108).

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@222237 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoRecorded merge of revisions 222152 via svnmerge from
Kevin P. Fleming [Tue, 6 Oct 2009 01:24:24 +0000 (01:24 +0000)]
Recorded merge of revisions 222152 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r222152 | kpfleming | 2009-10-05 20:16:36 -0500 (Mon, 05 Oct 2009) | 20 lines

  Fix ao2_iterator API to hold references to containers being iterated.

  See Mantis issue for details of what prompted this change.

  Additional notes:

  This patch changes the ao2_iterator API in two ways: F_AO2I_DONTLOCK
  has become an enum instead of a macro, with a name that fits our
  naming policy; also, it is now necessary to call
  ao2_iterator_destroy() on any iterator that has been
  created. Currently this only releases the reference to the container
  being iterated, but in the future this could also release other
  resources used by the iterator, if the iterator implementation changes
  to use additional resources.

  (closes issue #15987)
  Reported by: kpfleming

  Review: https://reviewboard.asterisk.org/r/383/
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@222176 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoAllow non-compliant T.38 endpoints to be supportable via configuration option.
Kevin P. Fleming [Mon, 5 Oct 2009 19:45:00 +0000 (19:45 +0000)]
Allow non-compliant T.38 endpoints to be supportable via configuration option.

Many T.38 endpoints incorrectly send the maximum IFP frame size they can accept
as the T38FaxMaxDatagram value in their SDP, when in fact this value is
supposed to be the maximum UDPTL payload size (datagram size) they can accept.
If the value they supply is small enough (a commonly supplied value is '72'),
T.38 UDPTL transmissions will likely fail completely because the UDPTL packets
will not have enough room for a primary IFP frame and the redundancy used for
error correction. If this occurs, the Asterisk UDPTL stack will emit log messages
warning that data loss may occur, and that the value may need to be overridden.

This patch extends the 't38pt_udptl' configuration option in sip.conf to allow
the administrator to override the value supplied by the remote endpoint and
supply a value that allows T.38 FAX transmissions to be successful with that
endpoint. In addition, in any SIP call where the override takes effect, a debug
message will be printed to that effect. This patch also removes the
T38FaxMaxDatagram configuration option from udptl.conf.sample, since it has not
actually had any effect for a number of releases.

In addition, this patch cleans up the T.38 documentation in sip.conf.sample
(which incorrectly documented that T.38 support was passthrough only).

(issue #15586)
Reported by: globalnetinc

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@222110 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoAdd a few missing events to analog_handle_event.
Jeff Peeler [Mon, 5 Oct 2009 19:20:36 +0000 (19:20 +0000)]
Add a few missing events to analog_handle_event.

The reported bug was actually only for pulsedigit, dtmfup, and dtmfdown
handling. Also added recognition for fax events (just some verbose output) and
fixed handling for the ec_disabled_event. In order to make comparing the analog
version of events to the DAHDI events easier, the ordering has been changed to
follow that of the DAHDI events.

(closes issue #15924)
Reported by: tzafrir

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@222108 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 222026 via svnmerge from
David Vossel [Fri, 2 Oct 2009 17:34:07 +0000 (17:34 +0000)]
Merged revisions 222026 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r222026 | dvossel | 2009-10-02 12:32:13 -0500 (Fri, 02 Oct 2009) | 3 lines

  Removes unnecessary unlock, clarifies a memcpy.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@222030 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 221970 via svnmerge from
Tilghman Lesher [Fri, 2 Oct 2009 16:59:57 +0000 (16:59 +0000)]
Merged revisions 221970 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r221970 | tilghman | 2009-10-02 11:58:03 -0500 (Fri, 02 Oct 2009) | 2 lines

  Ensure the result of the hash function is positive.  Negative array offsets suck.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@221971 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoInitialize a variable that we check immediately upon startup.
Tilghman Lesher [Fri, 2 Oct 2009 03:04:34 +0000 (03:04 +0000)]
Initialize a variable that we check immediately upon startup.
(closes issue #15973)
 Reported by: atis

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@221920 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoWhitespace change.
Richard Mudgett [Fri, 2 Oct 2009 01:49:25 +0000 (01:49 +0000)]
Whitespace change.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@221881 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoWhitespace change.
Richard Mudgett [Fri, 2 Oct 2009 01:46:51 +0000 (01:46 +0000)]
Whitespace change.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@221880 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 221769 via svnmerge from
Richard Mudgett [Fri, 2 Oct 2009 01:09:31 +0000 (01:09 +0000)]
Merged revisions 221769 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r221769 | rmudgett | 2009-10-01 18:18:28 -0500 (Thu, 01 Oct 2009) | 26 lines

  Occasionally losing use of B channels in chan_misdn.

  I have not been able to reproduce the problem of losing channels.
  However, I have seen in the code a reentrancy problem that might give
  these symptoms.

  The reentrancy patch does several things:
  1) Guards B channel and B channel structure allocation.
  2) Makes the B channel structure find routines more precise in locating records.
  3) Never leave a B channel allocated if we received cause 44.

  The last item may cause temporary outgoing call problems, but they should
  clear when the line becomes idle.

  (closes issue #15490)
  Reported by: slutec18
  Patches:
        issue15490_channel_alloc_reentrancy.patch uploaded by rmudgett (license 664)
  Tested by: rmudgett, slutec18

  (closes issue #15458)
  Reported by: FabienToune
  Patches:
        issue15458_channel_alloc_reentrancy.patch uploaded by rmudgett (license 664)
  Tested by: FabienToune, rmudgett, slutec18
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@221844 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoOne more off-by-one in trunk
Tilghman Lesher [Fri, 2 Oct 2009 00:08:21 +0000 (00:08 +0000)]
One more off-by-one in trunk

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@221781 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 221776 via svnmerge from
Tilghman Lesher [Thu, 1 Oct 2009 23:59:15 +0000 (23:59 +0000)]
Merged revisions 221776 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r221776 | tilghman | 2009-10-01 18:53:12 -0500 (Thu, 01 Oct 2009) | 2 lines

  Fix a bunch of off-by-one errors
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@221777 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMove DAHDI/ISDN channel naming note from CHANGES to UPGRADE.txt.
Richard Mudgett [Thu, 1 Oct 2009 20:18:29 +0000 (20:18 +0000)]
Move DAHDI/ISDN channel naming note from CHANGES to UPGRADE.txt.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@221709 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoRevision 220906 (a merge from 1.4) was not merged correctly, causing a problem with...
Tilghman Lesher [Thu, 1 Oct 2009 20:09:46 +0000 (20:09 +0000)]
Revision 220906 (a merge from 1.4) was not merged correctly, causing a problem with non-dynamic peers.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@221705 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoPrevent deadlock if chan_dahdi attempts to change PRI channel names.
Richard Mudgett [Thu, 1 Oct 2009 19:48:58 +0000 (19:48 +0000)]
Prevent deadlock if chan_dahdi attempts to change PRI channel names.

The PRI channels can no longer change the channel name if a different B
channel is selected during call negotiation.  To prevent using the channel
name to infer what B channel a call is using and to avoid name collisions,
the channel name format is changed.

The new channel naming for PRI channels is:
DAHDI/ISDN-<span>-<sequence-number>

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@221701 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agooutbound tls connections were not defaulting to port 5061
David Vossel [Thu, 1 Oct 2009 19:33:33 +0000 (19:33 +0000)]
outbound tls connections were not defaulting to port 5061

(closes issue #15854)
Reported by: dvossel
Patches:
      sip_port_config_trunk.diff uploaded by dvossel (license 671)
Tested by: dvossel

Review: https://reviewboard.asterisk.org/r/357/

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@221697 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoSync up UPGRADE.txt with the 1.6.2 version.
Kevin P. Fleming [Thu, 1 Oct 2009 16:27:05 +0000 (16:27 +0000)]
Sync up UPGRADE.txt with the 1.6.2 version.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@221627 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoRemove ability to control T.38 FAX error correction from udptl.conf.
Kevin P. Fleming [Thu, 1 Oct 2009 16:16:09 +0000 (16:16 +0000)]
Remove ability to control T.38 FAX error correction from udptl.conf.

chan_sip has had the ability to control T.38 FAX error correction mode on a per-peer
(or global) basis for a couple of releases now, which is where it should have been
all along. This patch removes the ability to configure it in udptl.conf, but issues
a warning if the user tries to do, telling them to look at sip.conf.sample for how
to configure it now. For any SIP peers that are T.38 enabled in sip.conf, there is
already a default for FEC error correction even if the user does not specify any mode,
so this change will not turn off error correction by default, it will have the same
default value that has been in the udptl.conf sample file.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@221592 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 221588 via svnmerge from
Matthew Nicholson [Thu, 1 Oct 2009 15:26:20 +0000 (15:26 +0000)]
Merged revisions 221588 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r221588 | mnicholson | 2009-10-01 10:24:00 -0500 (Thu, 01 Oct 2009) | 2 lines

  Use unsigned ints for portinuri flags.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@221589 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoSimplify code for porturi, use TRUE/FALSE constructs when it's just TRUE or FALSE.
Olle Johansson [Thu, 1 Oct 2009 07:00:04 +0000 (07:00 +0000)]
Simplify code for porturi, use TRUE/FALSE constructs when it's just TRUE or FALSE.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@221554 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoCleaned up merge from r221432
Matthew Nicholson [Wed, 30 Sep 2009 23:04:03 +0000 (23:04 +0000)]
Cleaned up merge from r221432

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@221484 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoPrevents from division by zero
Matthias Nick [Wed, 30 Sep 2009 21:15:01 +0000 (21:15 +0000)]
Prevents from division by zero

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@221436 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 221360 via svnmerge from
Matthew Nicholson [Wed, 30 Sep 2009 20:40:20 +0000 (20:40 +0000)]
Merged revisions 221360 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r221360 | mnicholson | 2009-09-30 14:36:06 -0500 (Wed, 30 Sep 2009) | 10 lines

  Fix SRV lookup and Request-URI generation in chan_sip.

  This patch adds a new field "portinuri" to the sip dialog struct and the sip peer struct.  That field is used during RURI generation to determine if the port should be included in the RURI.  It is also used in some places to determine if an SRV lookup should occur.

  (closes issue #14418)
  Reported by: klaus3000
  Tested by: klaus3000, mnicholson

  Review: https://reviewboard.asterisk.org/r/369/
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@221432 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 221153,221157,221303 via svnmerge from
Matthias Nick [Wed, 30 Sep 2009 19:42:36 +0000 (19:42 +0000)]
Merged revisions 221153,221157,221303 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r221153 | mnick | 2009-09-30 10:37:39 -0500 (Wed, 30 Sep 2009) | 2 lines

  check bounds - prevents for buffer overflow
........
  r221157 | mnick | 2009-09-30 10:41:46 -0500 (Wed, 30 Sep 2009) | 8 lines

  added a new dialplan function 'CSV_QUOTE' and changed the cdr_custom.sample.conf

  (closes issue #15471)
  Reported by: dkerr
  Patches:
        csv_quote_14.txt uploaded by mnick (license )
  Tested by: mnick
........
  r221303 | mnick | 2009-09-30 14:02:00 -0500 (Wed, 30 Sep 2009) | 2 lines

  changed the prototype definition of csv_quote
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@221368 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoRemove spurious debug
Terry Wilson [Wed, 30 Sep 2009 18:47:53 +0000 (18:47 +0000)]
Remove spurious debug

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@221300 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoUse rtp properties instead of adding a callback
Terry Wilson [Wed, 30 Sep 2009 18:21:03 +0000 (18:21 +0000)]
Use rtp properties instead of adding a callback

Thanks, Josh.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@221278 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 221086 via svnmerge from
Terry Wilson [Wed, 30 Sep 2009 17:52:30 +0000 (17:52 +0000)]
Merged revisions 221086 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r221086 | twilson | 2009-09-30 09:49:11 -0500 (Wed, 30 Sep 2009) | 25 lines

  Change the SSRC by default when our media stream changes

  Be default, change SSRC when doing an audio stream changes Asterisk doesn't
  honor marker bit when reinvited to already-bridged RTP streams,resulting in
  far-end stack discarding packets with "old" timestamps that areactually part of
  a new stream.  This patch sends AST_CONTROL_SRCUPDATE whenever there is a
  reinvite, unless the 'constantssrc' is set to true in sip.conf.

  The original issue reported to Digium support detailed the following situation:
  ITSP <-> Asterisk 1.4.26.2 <-> SIP-based Application Server Call comes in
  fromITSP, Asterisk dials the app server which sends a re-invite back
  toAsterisk--not to negotiate to send media directly to the ITSP, but to
  indicatethat it's changing the stream it's sending to Asterisk.  The app
  servergenerates a new SSRC, sequence numbers, timestamps, and sets the marker
  bit on the new stream.  Asterisk passes through the teimstamp of the new stream,
  butdoes not reset the SSRC, sequence numbers, or set the marker bit.

  When the timestamp on the new stream is older than the timestamp on the
  originalstream, the ITSP (which doesn't know there has been any change) discards
  the newframes because it thinks they are too old.  This patch addresses this by
  changing the SSRC on a stream update unless constantssrc=true is set in
  sip.conf.

  Review: https://reviewboard.asterisk.org/r/374/
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@221266 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 221200 via svnmerge from
Tilghman Lesher [Wed, 30 Sep 2009 16:56:42 +0000 (16:56 +0000)]
Merged revisions 221200 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r221200 | tilghman | 2009-09-30 11:55:21 -0500 (Wed, 30 Sep 2009) | 7 lines

  Avoid a potential NULL dereference.
  (closes issue #15865)
   Reported by: kobaz
   Patches:
         20090915__issue15865.diff.txt uploaded by tilghman (license 14)
   Tested by: kobaz
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@221201 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoModify VoiceMailMain()'s a() argument to allow mailboxes to be specified by name.
Sean Bright [Wed, 30 Sep 2009 15:11:21 +0000 (15:11 +0000)]
Modify VoiceMailMain()'s a() argument to allow mailboxes to be specified by name.

(closes issue #14740)
Reported by: pj
Patches:
      issue14740_09022009.diff uploaded by seanbright (license 71)
Tested by: seanbright, lmadsen

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@221090 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoClarify documentation for VoiceMailMain()'s a() option.
Sean Bright [Wed, 30 Sep 2009 14:47:58 +0000 (14:47 +0000)]
Clarify documentation for VoiceMailMain()'s a() option.

We require box numbers, not names as the documentation implies.
(issue #14740)
Reported by: pj
Patches:
      __20090729-app_voicemail-documentation.patch uploaded by lmadsen (license 10)
Tested by: seanbright, lmadsen

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@221085 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoAllow locks to be inherited through a masquerade without causing starvation.
Tilghman Lesher [Wed, 30 Sep 2009 04:32:36 +0000 (04:32 +0000)]
Allow locks to be inherited through a masquerade without causing starvation.
(closes issue #14859)
 Reported by: atis
 Patches:
       20090821__issue14859.diff.txt uploaded by tilghman (license 14)
       20090925__issue14859__1.6.1.diff.txt uploaded by tilghman (license 14)
 Tested by: atis, tilghman

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@221044 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoFix channel reference leak.
Mark Michelson [Tue, 29 Sep 2009 21:28:04 +0000 (21:28 +0000)]
Fix channel reference leak.

ast_cel_report_event would geet a reference to the
bridged channel. However, certain return paths, such
as if CEL was not enabled, would result in a reference
leak. All return paths now properly unref the channel.

(closes issue #15991)
Reported by: mmichelson

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@220995 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoBlocked revisions 220907 via svnmerge
Matthew Nicholson [Tue, 29 Sep 2009 20:22:43 +0000 (20:22 +0000)]
Blocked revisions 220907 via svnmerge

........
  r220907 | mnicholson | 2009-09-29 15:14:29 -0500 (Tue, 29 Sep 2009) | 10 lines

  Avoid a deadlock in chanspy, just in case the spyee is masqueraded and chanspy_ds_chan_fixup() is called with the channel locked.

  (closes issue #15965)
  Reported by: atis
  Patches:
        chanspy-deadlock-fix1.diff uploaded by mnicholson (license 96)
  Tested by: atis
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@220928 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoGet rid of annoying and cryptic debug messages.
Mark Michelson [Tue, 29 Sep 2009 20:20:48 +0000 (20:20 +0000)]
Get rid of annoying and cryptic debug messages.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@220920 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 220873 via svnmerge from
Tilghman Lesher [Tue, 29 Sep 2009 19:57:37 +0000 (19:57 +0000)]
Merged revisions 220873 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r220873 | tilghman | 2009-09-29 12:59:26 -0500 (Tue, 29 Sep 2009) | 9 lines

  Reduce CPU usage related to building a peer merely for devicestates.
  This fixes a 100% CPU problem in the SIP driver, found by profiling
  the driver while the problem was occurring.
  (closes issue #14309)
   Reported by: pkempgen
   Patches:
         20090924__issue14309.diff.txt uploaded by tilghman (license 14)
   Tested by: pkempgen, vrban
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@220906 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoFix options 'm' and 's'. They were swapped in the code. Also document the fact that...
Matthew Nicholson [Tue, 29 Sep 2009 19:49:02 +0000 (19:49 +0000)]
Fix options 'm' and 's'. They were swapped in the code.  Also document the fact that app_confbridge does not automatically answer the channel.

(closes issue #15964)
Reported by: shrift

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@220904 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMake deletion of temporary greetings work properly with IMAP_STORAGE
Jeff Peeler [Tue, 29 Sep 2009 16:58:29 +0000 (16:58 +0000)]
Make deletion of temporary greetings work properly with IMAP_STORAGE

When imapgreetings was set to yes, the message was being deleted but wasn't
actually being expunged. When imapgreetings was set to no, the file based
message was not being deleted at all. All good now!

(closes issue #14949)
Reported by: noahisaac
Patches:
      vm_tempgreeting_removal.patch uploaded by noahisaac (license 748),
      modified by me

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@220833 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMiscellaneous minor changes.
Richard Mudgett [Mon, 28 Sep 2009 21:02:20 +0000 (21:02 +0000)]
Miscellaneous minor changes.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@220792 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 220717 via svnmerge from
Sean Bright [Mon, 28 Sep 2009 19:11:20 +0000 (19:11 +0000)]
Merged revisions 220717 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r220717 | seanbright | 2009-09-28 15:09:25 -0400 (Mon, 28 Sep 2009) | 3 lines

  When selecting DONT_OPTIMIZE in menuselect, explicitly pass -O0 to the compiler
  so we override any default optimization levels for a particular install.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@220721 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoFix building of registration entry in build_peer when using callbackextension
Jeff Peeler [Mon, 28 Sep 2009 19:10:10 +0000 (19:10 +0000)]
Fix building of registration entry in build_peer when using callbackextension

Check for remotesecret option was unintentionally always true, which therefore
caused the secret option to never be used. Thanks to dvossel for pointing out
the exact fix.

(closes issue #15943)
Reported by: tpsast

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@220718 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoLocking issues dealing with service_lock.
Richard Mudgett [Mon, 28 Sep 2009 15:27:46 +0000 (15:27 +0000)]
Locking issues dealing with service_lock.

*  Removed unneeded and uninitialized service_lock.
*  Fixed potential locking imbalance in pri_dchannel():PRI_EVENT_RESTART.
*  Fixed verbose message typo in pri_dchannel():PRI_EVENT_RESTART.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@220672 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoadd name argument for the CALLERID dialplan function to the xml documentation.
Michiel van Baak [Sun, 27 Sep 2009 20:40:16 +0000 (20:40 +0000)]
add name argument for the CALLERID dialplan function to the xml documentation.
Pointed out to me on IRC by snuff-home. Thanks

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@220629 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoAllow AES to compile, when OpenSSL is not present.
Tilghman Lesher [Sat, 26 Sep 2009 15:10:28 +0000 (15:10 +0000)]
Allow AES to compile, when OpenSSL is not present.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@220586 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoReduce indentation in sig_pri_available().
Richard Mudgett [Fri, 25 Sep 2009 19:56:18 +0000 (19:56 +0000)]
Reduce indentation in sig_pri_available().

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@220543 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoEliminate unnecessary include of version.h in manager.c.
Kevin P. Fleming [Fri, 25 Sep 2009 14:50:29 +0000 (14:50 +0000)]
Eliminate unnecessary include of version.h in manager.c.

Including version.h here causes this file to get recompiled after
every commit or update, which is not needed.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@220496 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoCorrect sense of logic test committed in revision 220494.
Kevin P. Fleming [Fri, 25 Sep 2009 14:44:40 +0000 (14:44 +0000)]
Correct sense of logic test committed in revision 220494.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@220495 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoDon't use hash-based lookups for ast_channel_get_by_name_prefix().
Kevin P. Fleming [Fri, 25 Sep 2009 14:38:41 +0000 (14:38 +0000)]
Don't use hash-based lookups for ast_channel_get_by_name_prefix().

ast_channel_get_full() tries to use OBJ_POINTER to optimize name-based
channel lookups, but this will not work properly when the channel's full
name was not supplied; for name-prefix searches, there is no value in
doing a hash-based lookup, and in fact doing so could result in many
channels being skipped.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@220494 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoAdd JABBER_RECEIVE as a dialplan function, implement SendText in Jingle channels
Philippe Sultan [Fri, 25 Sep 2009 10:54:42 +0000 (10:54 +0000)]
Add JABBER_RECEIVE as a dialplan function, implement SendText in Jingle channels

JABBER_RECEIVE (along with JabberSend) makes Asterisk interact with users over
XMPP to process calls.
SendText can be used instead of JabberSend in the context of XMPP based voice
channels (chan_gtalk and chan_jingle).

(closes issue #12569)
Reported by: eech55
Tested by: phsultan, asannucci, lmadsen, jtodd, maxgo

Review: https://reviewboard.asterisk.org/r/88/

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@220457 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoChange the default behavior of Set, AGI, and pbx_realtime to 1.6 behavior by default...
Tilghman Lesher [Thu, 24 Sep 2009 22:53:23 +0000 (22:53 +0000)]
Change the default behavior of Set, AGI, and pbx_realtime to 1.6 behavior by default (starting in 1.6.3).

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@220417 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agofixes tcptls_session memory leak caused by ref count error
David Vossel [Thu, 24 Sep 2009 20:37:20 +0000 (20:37 +0000)]
fixes tcptls_session memory leak caused by ref count error

(closes issue #15939)
Reported by: dvossel

Review: https://reviewboard.asterisk.org/r/375/

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@220365 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoAdd bridge related dial flags to the bridge app
Jeff Peeler [Thu, 24 Sep 2009 20:29:51 +0000 (20:29 +0000)]
Add bridge related dial flags to the bridge app

Most of the functionality here is gained simply by setting the feature flag
on the bridge config. However, the dial limit functionality has been moved from
app_dial to the features code and has been made public so both app_dial and
the bridge app can use it.

(closes issue #13165)
Reported by: tim_ringenbach
Patches:
      app_bridge_options_r138998.diff uploaded by tim ringenbach (license 540),
      modified by me

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@220344 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoDocumentation in the commit messages is soon forgotten, please add it to the docs...
Olle Johansson [Thu, 24 Sep 2009 19:57:23 +0000 (19:57 +0000)]
Documentation in the commit messages is soon forgotten, please add it to the docs in the product.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@220295 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 220288 via svnmerge from
Tilghman Lesher [Thu, 24 Sep 2009 19:41:02 +0000 (19:41 +0000)]
Merged revisions 220288 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r220288 | tilghman | 2009-09-24 14:39:41 -0500 (Thu, 24 Sep 2009) | 6 lines

  Implicitly sending a progress signal breaks some applications.
  Call Progress() in your dialplan if you explicitly want progress to be sent.
  (Reverts change 216430, closes issue #15957)
  Reported by: Pavel Troller on the Asterisk-Dev mailing list
  http://lists.digium.com/pipermail/asterisk-dev/2009-September/039897.html
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@220289 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 220213 via svnmerge from
Sean Bright [Thu, 24 Sep 2009 18:19:41 +0000 (18:19 +0000)]
Merged revisions 220213 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r220213 | seanbright | 2009-09-24 14:18:18 -0400 (Thu, 24 Sep 2009) | 1 line

  Resolve parallel build warnings.

  Reported by Klaus Darilion on the asterisk-dev mailing list.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@220217 65c4cc65-6c06-0410-ace0-fbb531ad65f3