17 months agoMerge "res_pjsip: Resolve transport management leak at shutdown."
Joshua Colp [Fri, 17 Aug 2018 10:38:56 +0000 (05:38 -0500)]
Merge "res_pjsip: Resolve transport management leak at shutdown."

17 months agoMerge "res_odbc: Allow unload at shutdown."
Kevin Harwell [Thu, 16 Aug 2018 22:48:01 +0000 (17:48 -0500)]
Merge "res_odbc: Allow unload at shutdown."

17 months agoCI: Fixup for non-13 branches
George Joseph [Thu, 16 Aug 2018 18:51:51 +0000 (12:51 -0600)]
CI: Fixup for non-13 branches

Change-Id: I5e1d4a09e58b92b541bc8ed6f9e10e54c4e5101f

17 months agoCI: Final version of setting correct gerrit creds
George Joseph [Thu, 16 Aug 2018 18:28:03 +0000 (12:28 -0600)]
CI:  Final version of setting correct gerrit creds

Change-Id: I7729ecceedceb12f52bf18dae259846aa1d993b3

17 months agoCI: Add https credentials to gerrit checkouts
George Joseph [Thu, 16 Aug 2018 17:08:21 +0000 (11:08 -0600)]
CI:  Add https credentials to gerrit checkouts

If the review to be tested is in a project with restricted access,
we need to use the jenkins user's gerrit https credentials when we
do the checkout or the checkout will fail.

Change-Id: I9dc9994763c5ebfeb9f1cff60fb53f6902b7fd5f

17 months agoMerge "res/res_pjsip_sdp_rtp: put rtcp-mux in answer only if offered"
George Joseph [Thu, 16 Aug 2018 14:45:33 +0000 (09:45 -0500)]
Merge "res/res_pjsip_sdp_rtp:  put rtcp-mux in answer only if offered"

17 months agores/res_pjsip_sdp_rtp: put rtcp-mux in answer only if offered
Torrey Searle [Thu, 9 Aug 2018 07:34:17 +0000 (09:34 +0200)]
res/res_pjsip_sdp_rtp:  put rtcp-mux in answer only if offered

If in the initial sdp the caller doesn't include the line

Then asterisk shoud not include rtcp-mux in the response regardless
of rtcp-mux being enabled on the endpoint

ASTERISK-28007 #close

Change-Id: I58e9b9f40a139afc0da5de41906cc608fb62adc7

17 months agores_pjsip: Resolve transport management leak at shutdown.
Corey Farrell [Wed, 15 Aug 2018 18:51:36 +0000 (14:51 -0400)]
res_pjsip: Resolve transport management leak at shutdown.

Cleanup idle check scheduled events at shutdown.

Change-Id: I61bfbb56bac69fe840c3242927d31ff3593be461

17 months agores_odbc: Allow unload at shutdown.
Corey Farrell [Wed, 15 Aug 2018 16:31:00 +0000 (12:31 -0400)]
res_odbc: Allow unload at shutdown.

This makes it possible for REF_DEBUG to report no leaks when loading

Change-Id: I1a3dea786bd6e7f4820a6dd5cbaa197fa783ce93

17 months agores_pjsip: Fix leak in pjsip_options.
Corey Farrell [Wed, 15 Aug 2018 16:12:49 +0000 (12:12 -0400)]
res_pjsip: Fix leak in pjsip_options.

sip_options_get_endpoint_state_compositor_state leaked a reference to
the first available endpoint state compositor that was found.

Change-Id: Idb6be19f7219b6eed1dfb19c1e740dd40cb3fdc7

17 months agoMerge "res_pjsip_caller_id: Add "party" parameter to RPID header."
George Joseph [Wed, 15 Aug 2018 14:44:43 +0000 (09:44 -0500)]
Merge "res_pjsip_caller_id: Add "party" parameter to RPID header."

17 months agoMerge "res_pjsip/rtp: No joint capabilities between streams."
Jenkins2 [Wed, 15 Aug 2018 14:38:12 +0000 (09:38 -0500)]
Merge "res_pjsip/rtp: No joint capabilities between streams."

17 months agoMerge "contrib/scripts: Make astgenkey executable"
George Joseph [Wed, 15 Aug 2018 12:50:48 +0000 (07:50 -0500)]
Merge "contrib/scripts: Make astgenkey executable"

17 months agoMerge "Build System: Improve ccache matching for different menuselect options."
Jenkins2 [Tue, 14 Aug 2018 18:41:32 +0000 (13:41 -0500)]
Merge "Build System: Improve ccache matching for different menuselect options."

17 months agocontrib/scripts: Make astgenkey executable
Richard Mudgett [Tue, 14 Aug 2018 16:55:42 +0000 (11:55 -0500)]
contrib/scripts: Make astgenkey executable

Change-Id: I11641d65592536dea9cbca5aa94a24c25d24dd5f

17 months agores_pjsip_caller_id: Add "party" parameter to RPID header.
Joshua Colp [Tue, 14 Aug 2018 12:29:18 +0000 (09:29 -0300)]
res_pjsip_caller_id: Add "party" parameter to RPID header.

This change adds the "party" parameter to the Remote-Party-ID header
which indicates which party the header information is applicable
to. In Asterisk this is determined on whether we are the calling
or called party. This is added to improve interoperability with some


Change-Id: I1eec3e377ffff8633b5c1dd59a05e9533122cfca

17 months agoMerge "CI: Add support for coverage processing."
Jenkins2 [Tue, 14 Aug 2018 12:34:13 +0000 (07:34 -0500)]
Merge "CI: Add support for coverage processing."

17 months agores_pjsip/rtp: No joint capabilities between streams.
Ben Ford [Tue, 7 Aug 2018 15:57:29 +0000 (10:57 -0500)]
res_pjsip/rtp: No joint capabilities between streams.

When a conference contained a mixture of audio/video and audio-only
users, a NOTICE message would pop up stating there are no joint
capabilities between streams. This happens because streams can never be
removed, but they can be in a REMOVED state. If we have the scenario
where user A joins with audio/video, user B joins with audio-only, and
user C joins with audio/video, then user A leaves, the message would
be triggered. That removed stream is still in the SDP, but Asterisk
would pass it through, causing it to be seen as a ulaw stream. A check
has been added for removed streams, setting their status to REMOVED when
handling negotiated SDPs.

Also addressed an issue where user A joins, then user B joins but does
not receive video until much later. Full frames were not being sent,
causing some PLI from the browser. Because the video was flowing in one
direction, the browser sets the SSRC to 1, but Asterisk was dropping the
PLI because of that. Added a check to see if the SSRC is 1 or not, which
sends full frames and allows video to flow between user A and user B.
This should only happen when dealing with PSFB or FUR, and in the case
of PSFB, only for PLI.


Change-Id: I26e7c6f101bc119549eeca406b5bcd25ad8ebc5e

17 months agoapp_queue: set QUEUESTATUS to LEAVEEMPTY instead of CONTINUE
Ivan Poddubny [Sun, 12 Aug 2018 16:04:42 +0000 (18:04 +0200)]
app_queue: set QUEUESTATUS to LEAVEEMPTY instead of CONTINUE

When a call leaves a queue on leaveempty condition, QUEUESTATUS
must be set to LEAVEEMPTY, no matter whether Queue was executed with or
without the "c" (continue) option.

The regression was introduced in the fix for ASTERISK_25665.
The following fix (ASTERISK_27065) was incomplete, as QUEUESTATUS was
overwritten in case when "c" is set, regardless of what was the cause
for leaving the queue.

ASTERISK-27973 #close
Reported-by: Valentin Safonov

Change-Id: Iec013fe6a26a4e825ca572a1dda4f3cee5f6f80c

17 months agoSample configs: Fix pjsip.conf syntax error.
Corey Farrell [Thu, 9 Aug 2018 20:25:41 +0000 (16:25 -0400)]
Sample configs: Fix pjsip.conf syntax error.

It is valid for a config file to be empty or contain only comments, but
not valid for a config value to be set when no uncommented context
exists.  This caused an error to be loged numerous times during start
when loading the default pjsip.conf.

Change-Id: Icf3b0d69b4ecb6e935eecd43c99ed8b32a5a1cf6

17 months agoMerge "res_pjsip_registrar: Improve performance on inbound handling."
Joshua Colp [Wed, 8 Aug 2018 17:08:49 +0000 (12:08 -0500)]
Merge "res_pjsip_registrar: Improve performance on inbound handling."

17 months agoCI: Add support for coverage processing.
Corey Farrell [Fri, 20 Jul 2018 03:28:14 +0000 (23:28 -0400)]
CI: Add support for coverage processing.

Enable coverage with `./tests/CI/ --coverage`.  This
will cause Asterisk to be compiled with coverage support.  It also
initializes 'before' coverage data for all sources.  Accept
--tested-only to disable modules which are not run by any test.
Enabling coverage also sets tested-only true by default.  To build
everything with coverage enabled use `--coverage --tested-only=0`.

./tests/CI/ is used to process the coverage and
generate HTML reports.

Fix utils/check_expr2 which failed to compiled with coverage enabled.

Add status output 5 times per stage of astobj2_test_perf to ensure
remote CLI does not timeout when compiled with coverage.  Remote CLI
disconnects if no output is received for 60 seconds.  When coverage is
enabled it takes about 70 seconds for my laptop to run the stages of
this test, so with the change a message is printed every 14 seconds.

Change-Id: I890f7d5665087426ad7d3e363187691b9afc2222

17 months agoMerge "stasis: Reduce calculation of stasis message type hash."
Joshua Colp [Wed, 8 Aug 2018 10:54:02 +0000 (05:54 -0500)]
Merge "stasis: Reduce calculation of stasis message type hash."

17 months agoMerge "res_pjsip: Make pjlib.h consistently included."
Joshua Colp [Wed, 8 Aug 2018 10:53:53 +0000 (05:53 -0500)]
Merge "res_pjsip: Make pjlib.h consistently included."

17 months agoMerge "res_pjsip.h: Fix doxygen comments."
Joshua Colp [Wed, 8 Aug 2018 10:18:44 +0000 (05:18 -0500)]
Merge "res_pjsip.h: Fix doxygen comments."

17 months agoMerge "pjproject_bundled: Fix for Solaris builds. Do not undef s_addr."
Joshua Colp [Wed, 8 Aug 2018 10:10:32 +0000 (05:10 -0500)]
Merge "pjproject_bundled: Fix for Solaris builds. Do not undef s_addr."

17 months agores_pjsip.h: Fix doxygen comments.
Richard Mudgett [Mon, 6 Aug 2018 17:19:12 +0000 (12:19 -0500)]
res_pjsip.h: Fix doxygen comments.

Change-Id: I9cf97bdc756012d1f552ab007f4aa85e0ddb4e62

17 months agostasis: Reduce calculation of stasis message type hash.
Joshua Colp [Mon, 6 Aug 2018 11:36:22 +0000 (08:36 -0300)]
stasis: Reduce calculation of stasis message type hash.

When the stasis cache is used a hash is calculated for
retrieving or inserting messages. This change calculates
a hash when the message type is initialized that is then
used each time needed. This ensures that the hash is
calculated only once for the message type.

Change-Id: I4fe6bfdafb55bf5c322dd313fbd8c32cce73ef37

17 months agoMerge "dialplan_functions: wrong srtp use status report of a dialplan function"
Joshua Colp [Mon, 6 Aug 2018 13:34:20 +0000 (08:34 -0500)]
Merge "dialplan_functions: wrong srtp use status report of a dialplan function"

17 months agoMerge "pjproject_bundled: Find shared libraries in root --with-ssl=PATH."
Joshua Colp [Mon, 6 Aug 2018 10:28:47 +0000 (05:28 -0500)]
Merge "pjproject_bundled: Find shared libraries in root --with-ssl=PATH."

17 months agopjproject_bundled: Fix for Solaris builds. Do not undef s_addr.
Alexander Traud [Mon, 30 Jul 2018 12:49:08 +0000 (14:49 +0200)]
pjproject_bundled: Fix for Solaris builds. Do not undef s_addr.

The authors of PJProject undef s_addr because of some issue in Microsoft
Windows. However in Oracle Solaris, s_addr is not a structure member, but
defined to map to the real structure member.

Updates the patch from ASTERISK_20366


Change-Id: I8223026d4d54e2a46521085fcc94bfa6ebe35b11

17 months agores_pjsip: Make pjlib.h consistently included.
Richard Mudgett [Fri, 3 Aug 2018 20:59:06 +0000 (15:59 -0500)]
res_pjsip: Make pjlib.h consistently included.

* Don't include pjlib.h twice in res_pjsip.h
* Consistently use #include <> form for pjproject includes.
(pjsip.h and pjlib.h)

Change-Id: I3f7b42044840de64edf7e9d7695cb60c45990dc7

17 months agodialplan_functions: wrong srtp use status report of a dialplan function
Salah Ahmed [Thu, 2 Aug 2018 19:37:16 +0000 (14:37 -0500)]
dialplan_functions: wrong srtp use status report of a dialplan function

If asterisk offer an endpoint with SRTP and that endpoint respond
with non srtp, in that case channel(rtp,secure,audio) reply wrong

Why delete flag AST_SRTP_CRYPTO_OFFER_OK while check identical remote_key:
Currently this flag has being set redundantly. In either case identical
or different remote_key this flag has being set. So if we
don't set it while we receive identical remote_key or non SRTP SDP
response then we can take decision of srtp use by using that flag.


Change-Id: I29dc2843cf4e5ae2604301cb4ff258f1822dc2d7

17 months agoMerge "BuildSystem: Enable ncurses for menuselect in Solaris 11."
Kevin Harwell [Fri, 3 Aug 2018 18:29:11 +0000 (13:29 -0500)]
Merge "BuildSystem: Enable ncurses for menuselect in Solaris 11."

17 months agoMerge "pjsip_wizard.conf.sample: Update remote_hosts description."
Kevin Harwell [Fri, 3 Aug 2018 18:27:24 +0000 (13:27 -0500)]
Merge "pjsip_wizard.conf.sample: Update remote_hosts description."

17 months agoMerge "res_pjsip_endpoint_identifier_ip.c: Added regex support to match_header"
Kevin Harwell [Fri, 3 Aug 2018 18:26:30 +0000 (13:26 -0500)]
Merge "res_pjsip_endpoint_identifier_ip.c: Added regex support to match_header"

17 months agopjproject_bundled: Find shared libraries in root --with-ssl=PATH.
Alexander Traud [Mon, 30 Jul 2018 11:05:34 +0000 (13:05 +0200)]
pjproject_bundled: Find shared libraries in root --with-ssl=PATH.

The script configure from Teluu expects shared libraries (.so) in a subfolder
called 'lib', when --with-xyz=PATH is specified. However for OpenSSL, the
default location is the root of the source folder = PATH. Furthermore, Asterisk
supports both, 'lib' and root. For consistency and because Asterisk is using
(only) OpenSSL in PJProject, it is enhanced to support both locations, just
like Asterisk.


Change-Id: I8eb916a88b6b8c22e29bb40bee8faaca6c73406f

17 months agores_pjsip_registrar: Improve performance on inbound handling.
Joshua Colp [Wed, 1 Aug 2018 14:45:04 +0000 (14:45 +0000)]
res_pjsip_registrar: Improve performance on inbound handling.

This change removes a sorcery lookup for retrieving all
contacts at the end of the registration process by keeping
track of the contacts that are added/updated/deleted.

This ensures at the end of the process the container of
contacts we have is the current state.

Pool usage has also been reduced by allocating one for
usage throughout the handling of a REGISTER and resetting
it to a clean state. This ensures that in most cases
we allocate once and just reuse it.


Change-Id: I1a78b2d46f9a2045dbbff1a3fd6dba84b612b3cb

17 months agoMerge "thirdparty/pjproject: fix deadlock in response retransmissions"
Joshua Colp [Thu, 2 Aug 2018 12:12:35 +0000 (07:12 -0500)]
Merge "thirdparty/pjproject: fix deadlock in response retransmissions"

17 months agoMerge "BuildSystem: Enable Jansson in Solaris 11."
Joshua Colp [Thu, 2 Aug 2018 11:39:07 +0000 (06:39 -0500)]
Merge "BuildSystem: Enable Jansson in Solaris 11."

17 months agothirdparty/pjproject: fix deadlock in response retransmissions
Torrey Searle [Tue, 17 Jul 2018 12:13:43 +0000 (14:13 +0200)]
thirdparty/pjproject: fix deadlock in response retransmissions

The tdata containing the response can be shared by both the dialog
object and the tsx object.  In order to prevent the race condition
between the tsx retransmission and the dialog sending a response,
clone the tdata before modifying it for the dialog send response.

ASTERISK-27966 #close

Change-Id: Ic381004a3a212fe1d8eca0e707fe09dba4a6ab4e

17 months agoBuild System: Improve ccache matching for different menuselect options.
Corey Farrell [Wed, 1 Aug 2018 04:54:11 +0000 (00:54 -0400)]
Build System: Improve ccache matching for different menuselect options.

Changing any Menuselect option in the `Compiler Flags` section causes a
full rebuild of the Asterisk source tree.  Every enabled option causes
a #define to be added to buildopts.h, thus breaking ccache caching for
every source file that includes "asterisk.h".  In most cases each option
only applies to one or two files.  Now we only define those options for
the specific sources which use them, this causes much better cache
matching when working with multiple builds.  For example testing code
with an without MALLOC_DEBUG will now use just over half the ccache
size, only main/astmm.o will have two builds cached instead of every

Reorder main/Makefile so _ASTCFLAGS set on specific object files are all
together, sorted by filename.  Stop adding -DMALLOC_DEBUG to CFLAGS of
bundled pjproject, this define is no longer used by any header so only
serves to break cache.

The only code change is a slight adjustment to how main/astmm.c is
initialized.  Initialization functions always exist so main/asterisk.c
can call them unconditionally.  Additionally rename the astmm
initialization functions so they are not exported.

Change-Id: Ie2085237a964f6e1e6fff55ed046e2afff83c027

17 months agoMerge "res_rtp_asterisk: In Developer Mode, do not require OpenSSL."
Joshua Colp [Wed, 1 Aug 2018 09:23:06 +0000 (04:23 -0500)]
Merge "res_rtp_asterisk: In Developer Mode, do not require OpenSSL."

17 months agoMerge "res_pjsip_pubsub: Use ast_true for "prune_on_boot"."
Joshua Colp [Tue, 31 Jul 2018 21:11:32 +0000 (16:11 -0500)]
Merge "res_pjsip_pubsub: Use ast_true for "prune_on_boot"."

17 months agopjsip_wizard.conf.sample: Update remote_hosts description.
Richard Mudgett [Tue, 31 Jul 2018 16:24:08 +0000 (11:24 -0500)]
pjsip_wizard.conf.sample: Update remote_hosts description.

Remove the note that SRV records are not supported as that is no longer


Change-Id: Id0dd6ef40e52702be9727a2b6122216cb00bb4ca

17 months agoCI: Add optional uninstall step before installing asterisk
George Joseph [Fri, 27 Jul 2018 18:23:02 +0000 (12:23 -0600)]
CI: Add optional uninstall step before installing asterisk

Change-Id: I7dedf1e925eafc3a0adf01dd9dfbe44eb642aab7

17 months agoBuildSystem: Enable ncurses for menuselect in Solaris 11.
Alexander Traud [Sat, 28 Jul 2018 16:49:17 +0000 (18:49 +0200)]
BuildSystem: Enable ncurses for menuselect in Solaris 11.

The check for the library ncurses should use not use the header <curses.h> but
<ncurses.h>, because on some platforms <curses.h> is not a drop-in replacement
for <ncurses.h>: For example in Solaris, the symbol initscr is a typedef in
<curses.h> to a symbol which does not exist in the library ncurses (initscr32).
Simply use <ncurses.h> when you link to ncurses.

Furthermore in Solaris, the header <ncurses.h> is in a subdirectory
/usr/include/ncurses and not available via pkg-config.


Change-Id: Ife367776b0ccf17d3fefed868245376bfb93745d

17 months agores_pjsip_pubsub: Use ast_true for "prune_on_boot".
Joshua Colp [Sat, 28 Jul 2018 13:00:40 +0000 (13:00 +0000)]
res_pjsip_pubsub: Use ast_true for "prune_on_boot".

Change-Id: Iedec4e7390b3e821987681da24d0298632b9873d

17 months agoBuildSystem: Enable Jansson in Solaris 11.
Alexander Traud [Sat, 28 Jul 2018 12:39:40 +0000 (14:39 +0200)]
BuildSystem: Enable Jansson in Solaris 11.

In Solaris, the header <jansson.h> is in /usr/include/jansson. To find
Jansson even in such a subdirectory, the tool pkg-config is queried via
AST_PKG_CONFIG_CHECK. For those platforms, which do not list Jansson via
pkg-config, the previous check remains and is executed thereafter.

Because the check for the NetBSD Editline library uses the tool pkg-config
the code of PKG_PROG_PKG_CONFIG must be used. Because that check happens
earlier than Jansson, it must be placed in front of that.


Change-Id: I69ea0f379f87a50049654b2487c76ee1c04fa53a

17 months agores_pjsip_endpoint_identifier_ip.c: Added regex support to match_header
Richard Mudgett [Tue, 24 Jul 2018 18:44:41 +0000 (13:44 -0500)]
res_pjsip_endpoint_identifier_ip.c: Added regex support to match_header

This patch adds regular expression support to make the identify section's
match_header option more useful when attempting to match complex headers
like the 'To' or 'From' headers.  The 'From' header has variable
components such as the tag parameter that you cannot predict.  To specify
a regular expression put slashes around the regular expression in place of
the header value.

match_header=From: /<sip:alice@127\\.0\\.0\\.1>/

* Added regex support to match_header so you could match a 'To' header
among other complex headers.

Fixed reported crashes when trying to match special headers like 'Contact'.
The identify section's match_header method used code that assumed you were
matching a generic header.  Any other type of header could cause a crash
if the header structure variant did not match the generic header enough.

* Made use code that will work for any header type instead of code
specific to generic headers.

Other fixes while in the area:

* Made check all headers of the requested name.
* Added some more sanity checks to the configured identify matching
options when applying the configuration.


Change-Id: I27dfd4ff5e2259b906640e3c330681b76b4ed1f1

17 months agores_pjsip_pubsub: Treat "prune_on_boot" as a yes / no.
Joshua Colp [Fri, 27 Jul 2018 15:46:12 +0000 (15:46 +0000)]
res_pjsip_pubsub: Treat "prune_on_boot" as a yes / no.

The alembic for the PJSIP subscription persistence table has the
"prune_on_boot" field as a boolean. While in Asterisk we are
tolerant of many different definitions of true and false in the
database we only accept "yes" and "no". This change makes the
field treated as a yes/no instead of an integer, thus storing
"yes" and "no" instead of "1" and "0".

Change-Id: Ic8b9211b36babefe78f70def6828a135a6ae7ab6

17 months agores_rtp_asterisk: In Developer Mode, do not require OpenSSL.
Alexander Traud [Fri, 27 Jul 2018 13:26:51 +0000 (15:26 +0200)]
res_rtp_asterisk: In Developer Mode, do not require OpenSSL.

OpenSSL is an optional external library and should stay optional even when
Developer Mode is configured.


Change-Id: Ia68a4cd5474b26d45e0f43b04032ad598022853b

17 months agoMerge "devicestate: Don't create topic when change isn't cached."
Joshua Colp [Fri, 27 Jul 2018 11:09:50 +0000 (06:09 -0500)]
Merge "devicestate: Don't create topic when change isn't cached."

17 months agoMerge "loader: Process dependencies for built-in modules."
Joshua Colp [Fri, 27 Jul 2018 11:04:51 +0000 (06:04 -0500)]
Merge "loader: Process dependencies for built-in modules."

17 months agoMerge "Build System: Create 'make install-configs' target."
Joshua Colp [Fri, 27 Jul 2018 10:51:44 +0000 (05:51 -0500)]
Merge "Build System: Create 'make install-configs' target."

17 months agoMerge "res_rtp_asterisk: Avoid merging command and regular T.140 text packets"
Joshua Colp [Fri, 27 Jul 2018 10:35:17 +0000 (05:35 -0500)]
Merge "res_rtp_asterisk: Avoid merging command and regular T.140 text packets"

17 months agoCI: Fix placement of job summary statments
George Joseph [Thu, 26 Jul 2018 23:54:36 +0000 (17:54 -0600)]
CI: Fix placement of job summary statments

Change-Id: Iace19e718f4e8fb48eb7dc9f98af53b115cc45f3

18 months agoloader: Process dependencies for built-in modules.
Corey Farrell [Thu, 26 Jul 2018 17:52:46 +0000 (13:52 -0400)]
loader: Process dependencies for built-in modules.

With the new module loader it was missed that built-in modules never
parsed dependencies from mod->info into vectors of mod.  This caused
manager to be initialized before acl (named_acl).  If manager.conf
used any named ACL's they would not be found and result in no ACL being
applied to the AMI user.

In addition to the manager ACL fix this adds "extconfig" to all builtin
modules which support realtime configuration.  This only matters if one
of the builtin modules is configured with 'preload', depending on
"extconfig" will cause config.c to automatically be initialize during
the preload stage.

Change-Id: I482ed6bca6c1064b05bb538d7861cd7a4f02d9fc

18 months agores_rtp_asterisk: Avoid merging command and regular T.140 text packets
neutrino88 [Wed, 18 Jul 2018 14:32:34 +0000 (10:32 -0400)]
res_rtp_asterisk: Avoid merging command and regular T.140 text packets

When realtime text packets are to be sent, the text is accumulated in a
buffer and sent regularly by a timer.  It can happen that commands such as
a backspace, CR, or LF get merged with regular text.  This breaks some

The proposed change:
* We test if the current packet contains a command.  If so we send the
buffer immediately.
* We test if the buffer contained a command.  If so we send the buffer
* We accumulate the text (or the command) in the buffer.


Change-Id: Ifbe993311410fa855cb8aa4a12084db75f413462

18 months agoMerge "CI: Add docker info to job summary"
Jenkins2 [Thu, 26 Jul 2018 16:44:30 +0000 (11:44 -0500)]
Merge "CI:  Add docker info to job summary"

18 months agoCI: Add docker info to job summary
George Joseph [Thu, 26 Jul 2018 16:34:20 +0000 (10:34 -0600)]
CI:  Add docker info to job summary

Change-Id: I45d52005a9b692ad303c11792f226ace1e449901

18 months agoBuild System: Create 'make install-configs' target.
Corey Farrell [Mon, 23 Jul 2018 18:49:33 +0000 (14:49 -0400)]
Build System: Create 'make install-configs' target.

This target requires specifying CONFIG_SRC=path_to_configs.  This can be
used to install custom configs for the Asterisk build while still
performing directory replacements on asterisk.conf.

Modify internal INSTALL_CONFIGS so first argument requires full path to
the config sources relative to Asterisk source root.

Change-Id: Idcd841df3c8d5bfe23d566bb9e2e448e9df4f8ab

18 months agojson.c: improve ast_json_to_ast_variables performance
Kevin Harwell [Wed, 25 Jul 2018 20:33:22 +0000 (15:33 -0500)]
json.c: improve ast_json_to_ast_variables performance

When converting from a json object to an ast variables list the conversion
algorithm was doing a complete traversal of the entire variables list for
every item appended from the json structure.

This patch makes it so the list is no longer traversed for each new ast
variable being appended.

Change-Id: I8bf496a1fc449485150d6db36bfc0354934a3977

18 months agodevicestate: Don't create topic when change isn't cached.
Joshua Colp [Wed, 25 Jul 2018 10:32:31 +0000 (10:32 +0000)]
devicestate: Don't create topic when change isn't cached.

When publishing a device state the change can be marked as being
cachable or not. If it is not cached the change is just published
to all interested and not stored away for later query. This was not
fully taken into account when publishing in stasis. The act of
publishing would create a topic for the device even if it may be

This change makes it so messages which are not cached won't create
a topic for the device. If a topic does already exist it will be
published to but otherwise the change will only be published to
the device state all topic.


Change-Id: I18da0e8cbb18e79602e731020c46ba4101e59f0a

18 months agoMerge "res_pjsip: Change log message from error to warning for valid use cases"
Joshua Colp [Wed, 25 Jul 2018 18:59:27 +0000 (13:59 -0500)]
Merge "res_pjsip: Change log message from error to warning for valid use cases"

18 months agoMerge "Build System: Silence build of bundled jansson."
George Joseph [Wed, 25 Jul 2018 18:59:22 +0000 (13:59 -0500)]
Merge "Build System: Silence build of bundled jansson."

18 months agoMerge "CI: Explicitly pass BRANCH_NAME to buildAsterisk and installAsterisk"
Jenkins2 [Wed, 25 Jul 2018 17:48:48 +0000 (12:48 -0500)]
Merge "CI: Explicitly pass BRANCH_NAME to buildAsterisk and installAsterisk"

18 months agoMerge "CI: Add options to initialize and cleanup database to"
Jenkins2 [Wed, 25 Jul 2018 17:48:18 +0000 (12:48 -0500)]
Merge "CI: Add options to initialize and cleanup database to"

18 months agoCI: Explicitly pass BRANCH_NAME to buildAsterisk and installAsterisk
George Joseph [Wed, 25 Jul 2018 15:20:20 +0000 (09:20 -0600)]
CI: Explicitly pass BRANCH_NAME to buildAsterisk and installAsterisk

Change-Id: I652f4a0ea5107c778e27a78bccb67b18b0c4e087

18 months agoCI: Add options to initialize and cleanup database to
George Joseph [Tue, 24 Jul 2018 18:29:19 +0000 (12:29 -0600)]
CI: Add options to initialize and cleanup database to

Change-Id: I352333233bab5377723bf37d490ba84fc55bc853

18 months agoCI: Do not `mkdir 2`.
Corey Farrell [Wed, 25 Jul 2018 14:07:51 +0000 (10:07 -0400)]
CI: Do not `mkdir 2`.

Change-Id: Ib7377d26a6c98b38bad463f47c84f1875ac84eb7

18 months agoBuild System: Silence build of bundled jansson.
Corey Farrell [Wed, 25 Jul 2018 12:34:54 +0000 (08:34 -0400)]
Build System: Silence build of bundled jansson.

Change-Id: I7392c79c0173057f5378010bf1fe65e300e8fc56

18 months agoCI: RefDebug: Fix reference to testsuite URL
George Joseph [Wed, 25 Jul 2018 12:13:43 +0000 (06:13 -0600)]
CI: RefDebug: Fix reference to testsuite URL

Change-Id: I0ee41d95a87f0d97b01f2757012b846bcfe6443d

18 months agoBuild System: Fix bundled jansson install.
Corey Farrell [Tue, 24 Jul 2018 19:28:04 +0000 (15:28 -0400)]
Build System: Fix bundled jansson install.

Update the bundled jansson Makefile to do nothing during Asterisk
install, use a target that is not phony to initiate the jansson make and

Change-Id: I7643cc3d39af9feba8fc0da676b646efc5f8b3bb

18 months agoCI: Use bundled jansson if needed.
Corey Farrell [Tue, 24 Jul 2018 15:43:45 +0000 (11:43 -0400)]
CI: Use bundled jansson if needed.

Use pkg-config to determine if jansson is at least 2.11, enabled bundled
version otherwise.

Change-Id: Ib555a8b72ff6f6925f9280ef035caa0b91ca4bd2

18 months agoMerge "Enable bundling of jansson, require 2.11."
Jenkins2 [Tue, 24 Jul 2018 15:07:23 +0000 (10:07 -0500)]
Merge "Enable bundling of jansson, require 2.11."

18 months agoMerge "res_pjsip: Update default keepalive interval to 90 seconds."
George Joseph [Tue, 24 Jul 2018 13:30:13 +0000 (08:30 -0500)]
Merge "res_pjsip: Update default keepalive interval to 90 seconds."

18 months agores_pjsip: Change log message from error to warning for valid use cases
Florian Floimair [Tue, 24 Jul 2018 09:57:25 +0000 (11:57 +0200)]
res_pjsip: Change log message from error to warning for valid use cases

If a SIP MESSAGE is triggered for an endpoint that is currently not registered
- and therefore has no valid contact associated - an error message was logged.
Since this is a valid request in a valid use cases this is now changed to a
warning, as discussed with Matt Fredrickson on the asterisk-dev mailing list.

Change-Id: I55eb62d2712818a58c7532119dec288bd98cf0c0

18 months agoMerge "CI: Set correct user:group when publishing docs"
Jenkins2 [Tue, 24 Jul 2018 11:03:03 +0000 (06:03 -0500)]
Merge "CI: Set correct user:group when publishing docs"

18 months agoMerge "CI: Add --privileged flag to docker options"
Jenkins2 [Tue, 24 Jul 2018 11:03:01 +0000 (06:03 -0500)]
Merge "CI:  Add --privileged flag to docker options"

18 months agoMerge "core: AST_DEVMODE no longer affects ABI."
George Joseph [Tue, 24 Jul 2018 10:41:39 +0000 (05:41 -0500)]
Merge "core: AST_DEVMODE no longer affects ABI."

18 months agoCI: Add --privileged flag to docker options
George Joseph [Tue, 24 Jul 2018 10:39:30 +0000 (04:39 -0600)]
CI:  Add --privileged flag to docker options

Change-Id: If92d55f15306e55dd7091ac3c47b13ebbbb03488

18 months agoMerge "build_tools/make_version: Get MAINLINE_BRANCH from .gitreview."
George Joseph [Tue, 24 Jul 2018 10:40:49 +0000 (05:40 -0500)]
Merge "build_tools/make_version: Get MAINLINE_BRANCH from .gitreview."

18 months agoCI: Set correct user:group when publishing docs
George Joseph [Tue, 24 Jul 2018 10:22:36 +0000 (04:22 -0600)]
CI: Set correct user:group when publishing docs

Change-Id: Ibabeb9ac730d9755cf54318d0da74771c939b86b

18 months agoMerge "asterisk.c: Make displayed copyright always consistent"
George Joseph [Tue, 24 Jul 2018 09:32:09 +0000 (04:32 -0500)]
Merge "asterisk.c: Make displayed copyright always consistent"

18 months agocore: AST_DEVMODE no longer affects ABI.
Richard Mudgett [Mon, 23 Jul 2018 17:21:44 +0000 (12:21 -0500)]
core: AST_DEVMODE no longer affects ABI.

calculation as it no longer affects API/ABI compatibility.

Change-Id: Id5bd6dfade173a53b3a49f715586b86e3fb24acb

18 months agoMerge "CI: Split --test-command argument."
Jenkins2 [Mon, 23 Jul 2018 18:45:19 +0000 (13:45 -0500)]
Merge "CI: Split --test-command argument."

18 months agoMerge "sched: Make ABI compatible between dev mode and non-dev mode."
George Joseph [Mon, 23 Jul 2018 18:32:01 +0000 (13:32 -0500)]
Merge "sched: Make ABI compatible between dev mode and non-dev mode."

18 months agoasterisk.c: Make displayed copyright always consistent
Richard Mudgett [Fri, 20 Jul 2018 21:21:51 +0000 (16:21 -0500)]
asterisk.c: Make displayed copyright always consistent

Change-Id: I4f5499486e8ec90d7c7ffeebc659ceda1db6d5b5

18 months agoCI: Split --test-command argument.
Corey Farrell [Mon, 23 Jul 2018 15:23:22 +0000 (11:23 -0400)]
CI: Split --test-command argument.

The --test-command argument has now been split, unit tests now use
`--unittest-command` and the testsuite uses --testsuite-command.

This will make it easier to create a script which run everything by
forwarding the same arguments to all CI scripts.

Change-Id: Ia54aa4848eaffbdf13175fcda40fc0b23080ad71

18 months agoMerge "asterisk.c: Update displayed copyright year for v16 release."
George Joseph [Mon, 23 Jul 2018 14:40:37 +0000 (09:40 -0500)]
Merge "asterisk.c: Update displayed copyright year for v16 release."

18 months agoMerge "res_pjsip: Update endpoint transport option documentation."
Joshua Colp [Mon, 23 Jul 2018 14:14:09 +0000 (09:14 -0500)]
Merge "res_pjsip: Update endpoint transport option documentation."

18 months agoMerge "CI: Fix mkdir CACHE_DIR."
Jenkins2 [Mon, 23 Jul 2018 13:39:13 +0000 (08:39 -0500)]
Merge "CI: Fix mkdir CACHE_DIR."

18 months agoMerge "CI: Fix logger.conf for unit tests."
Jenkins2 [Mon, 23 Jul 2018 13:37:33 +0000 (08:37 -0500)]
Merge "CI: Fix logger.conf for unit tests."

18 months agoxmldoc.c: Fix dump of xml document
George Joseph [Fri, 20 Jul 2018 11:20:25 +0000 (05:20 -0600)]
xmldoc.c:  Fix dump of xml document

The "xmldoc dump" cli command was simply concatenating xml documents
into the output file.  The resulting file had multiple "xml"
processing instructions and multiple root elements which is illegal.
Normally this isn't an issue because Asterisk has only 1 main xml
documentation file but codec_opus has its own file so if it's
downloaded and you do "xmldoc dump", the result is invalid.

* Added 2 new functions to xml.c:
    ast_xml_copy_node_list creates a copy of a list of children.
    ast_xml_add_child_list adds a list to an existing list.

* Modified handle_dump_docs to create a new output document and
  add to it the children from each input file.  It then dumps the
  new document to the output file.

Change-Id: I3f182d38c75776aee76413dadd2d489d54a85c07

18 months agoMerge "CI: Add wiki doc publish to periodics"
Jenkins2 [Mon, 23 Jul 2018 11:46:52 +0000 (06:46 -0500)]
Merge "CI:  Add wiki doc publish to periodics"

18 months agoCI: Fix mkdir CACHE_DIR.
Corey Farrell [Sat, 21 Jul 2018 16:58:16 +0000 (12:58 -0400)]
CI: Fix mkdir CACHE_DIR.

Change-Id: Ic9f9a61e230047836c836206731f8ff7eb3538c9

18 months agobuild_tools/make_version: Get MAINLINE_BRANCH from .gitreview.
Corey Farrell [Sat, 21 Jul 2018 15:48:29 +0000 (11:48 -0400)]
build_tools/make_version: Get MAINLINE_BRANCH from .gitreview.

Use .gitreview defaultbranch setting to determine the mainline branch.
This allows the script to be used against other directories which might
not be on the same defaultbranch.  This can be used by CI scripts to
report the testsuite version being used:
./build_tools/make_version ${TESTSUITE_DIR}

Change-Id: Ifdad4a9d8a26138c41bc6b630ecc3e34ea1c2758

18 months agosched: Make ABI compatible between dev mode and non-dev mode.
Joshua Colp [Sun, 22 Jul 2018 15:41:03 +0000 (15:41 +0000)]
sched: Make ABI compatible between dev mode and non-dev mode.

In the past there was an assertion in the ast_sched_del function
and in order to ensure it was useful the calling function name,
line number, and filename had to be passed in. This cause the ABI
to be different between dev mode and non-dev mode.

This assertion is no longer present so the special logic can be
removed to make it the same between them both.

Change-Id: Icbc69c801e357d7004efc5cf2ab936d9b83b6ab8

18 months agoasterisk.c: Update displayed copyright year for v16 release.
Richard Mudgett [Fri, 20 Jul 2018 20:52:12 +0000 (15:52 -0500)]
asterisk.c: Update displayed copyright year for v16 release.

Change-Id: I60622731d928ee9506b1d28934095f0dc3e5306e