12 months agoMerge "core: AST_DEVMODE no longer affects ABI."
George Joseph [Tue, 24 Jul 2018 10:41:39 +0000 (05:41 -0500)]
Merge "core: AST_DEVMODE no longer affects ABI."

12 months agoMerge "build_tools/make_version: Get MAINLINE_BRANCH from .gitreview."
George Joseph [Tue, 24 Jul 2018 10:40:49 +0000 (05:40 -0500)]
Merge "build_tools/make_version: Get MAINLINE_BRANCH from .gitreview."

12 months agoMerge "asterisk.c: Make displayed copyright always consistent"
George Joseph [Tue, 24 Jul 2018 09:32:09 +0000 (04:32 -0500)]
Merge "asterisk.c: Make displayed copyright always consistent"

12 months agocore: AST_DEVMODE no longer affects ABI.
Richard Mudgett [Mon, 23 Jul 2018 17:21:44 +0000 (12:21 -0500)]
core: AST_DEVMODE no longer affects ABI.

calculation as it no longer affects API/ABI compatibility.

Change-Id: Id5bd6dfade173a53b3a49f715586b86e3fb24acb

12 months agoMerge "CI: Split --test-command argument."
Jenkins2 [Mon, 23 Jul 2018 18:45:19 +0000 (13:45 -0500)]
Merge "CI: Split --test-command argument."

12 months agoMerge "sched: Make ABI compatible between dev mode and non-dev mode."
George Joseph [Mon, 23 Jul 2018 18:32:01 +0000 (13:32 -0500)]
Merge "sched: Make ABI compatible between dev mode and non-dev mode."

12 months agoasterisk.c: Make displayed copyright always consistent
Richard Mudgett [Fri, 20 Jul 2018 21:21:51 +0000 (16:21 -0500)]
asterisk.c: Make displayed copyright always consistent

Change-Id: I4f5499486e8ec90d7c7ffeebc659ceda1db6d5b5

12 months agoCI: Split --test-command argument.
Corey Farrell [Mon, 23 Jul 2018 15:23:22 +0000 (11:23 -0400)]
CI: Split --test-command argument.

The --test-command argument has now been split, unit tests now use
`--unittest-command` and the testsuite uses --testsuite-command.

This will make it easier to create a script which run everything by
forwarding the same arguments to all CI scripts.

Change-Id: Ia54aa4848eaffbdf13175fcda40fc0b23080ad71

12 months agoMerge "asterisk.c: Update displayed copyright year for v16 release."
George Joseph [Mon, 23 Jul 2018 14:40:37 +0000 (09:40 -0500)]
Merge "asterisk.c: Update displayed copyright year for v16 release."

12 months agoMerge "res_pjsip: Update endpoint transport option documentation."
Joshua Colp [Mon, 23 Jul 2018 14:14:09 +0000 (09:14 -0500)]
Merge "res_pjsip: Update endpoint transport option documentation."

12 months agoMerge "CI: Fix mkdir CACHE_DIR."
Jenkins2 [Mon, 23 Jul 2018 13:39:13 +0000 (08:39 -0500)]
Merge "CI: Fix mkdir CACHE_DIR."

12 months agoMerge "CI: Fix logger.conf for unit tests."
Jenkins2 [Mon, 23 Jul 2018 13:37:33 +0000 (08:37 -0500)]
Merge "CI: Fix logger.conf for unit tests."

12 months agoxmldoc.c: Fix dump of xml document
George Joseph [Fri, 20 Jul 2018 11:20:25 +0000 (05:20 -0600)]
xmldoc.c:  Fix dump of xml document

The "xmldoc dump" cli command was simply concatenating xml documents
into the output file.  The resulting file had multiple "xml"
processing instructions and multiple root elements which is illegal.
Normally this isn't an issue because Asterisk has only 1 main xml
documentation file but codec_opus has its own file so if it's
downloaded and you do "xmldoc dump", the result is invalid.

* Added 2 new functions to xml.c:
    ast_xml_copy_node_list creates a copy of a list of children.
    ast_xml_add_child_list adds a list to an existing list.

* Modified handle_dump_docs to create a new output document and
  add to it the children from each input file.  It then dumps the
  new document to the output file.

Change-Id: I3f182d38c75776aee76413dadd2d489d54a85c07

12 months agoMerge "CI: Add wiki doc publish to periodics"
Jenkins2 [Mon, 23 Jul 2018 11:46:52 +0000 (06:46 -0500)]
Merge "CI:  Add wiki doc publish to periodics"

12 months agoCI: Fix mkdir CACHE_DIR.
Corey Farrell [Sat, 21 Jul 2018 16:58:16 +0000 (12:58 -0400)]
CI: Fix mkdir CACHE_DIR.

Change-Id: Ic9f9a61e230047836c836206731f8ff7eb3538c9

12 months agobuild_tools/make_version: Get MAINLINE_BRANCH from .gitreview.
Corey Farrell [Sat, 21 Jul 2018 15:48:29 +0000 (11:48 -0400)]
build_tools/make_version: Get MAINLINE_BRANCH from .gitreview.

Use .gitreview defaultbranch setting to determine the mainline branch.
This allows the script to be used against other directories which might
not be on the same defaultbranch.  This can be used by CI scripts to
report the testsuite version being used:
./build_tools/make_version ${TESTSUITE_DIR}

Change-Id: Ifdad4a9d8a26138c41bc6b630ecc3e34ea1c2758

12 months agosched: Make ABI compatible between dev mode and non-dev mode.
Joshua Colp [Sun, 22 Jul 2018 15:41:03 +0000 (15:41 +0000)]
sched: Make ABI compatible between dev mode and non-dev mode.

In the past there was an assertion in the ast_sched_del function
and in order to ensure it was useful the calling function name,
line number, and filename had to be passed in. This cause the ABI
to be different between dev mode and non-dev mode.

This assertion is no longer present so the special logic can be
removed to make it the same between them both.

Change-Id: Icbc69c801e357d7004efc5cf2ab936d9b83b6ab8

12 months agoasterisk.c: Update displayed copyright year for v16 release.
Richard Mudgett [Fri, 20 Jul 2018 20:52:12 +0000 (15:52 -0500)]
asterisk.c: Update displayed copyright year for v16 release.

Change-Id: I60622731d928ee9506b1d28934095f0dc3e5306e

12 months agoMerge "pjsip_resolver.c: Use replacement function"
Kevin Harwell [Fri, 20 Jul 2018 19:44:00 +0000 (14:44 -0500)]
Merge "pjsip_resolver.c: Use replacement function"

12 months agoMerge "contrib: Update systemd README.txt."
Kevin Harwell [Fri, 20 Jul 2018 17:01:44 +0000 (12:01 -0500)]
Merge "contrib: Update systemd README.txt."

12 months agoCI: Fix logger.conf for unit tests.
Corey Farrell [Fri, 20 Jul 2018 14:25:25 +0000 (10:25 -0400)]
CI: Fix logger.conf for unit tests.

Change-Id: Idea59d60eab20105de50b34f0f0d506e6ef55d5c

12 months agoCI: Add wiki doc publish to periodics
George Joseph [Thu, 19 Jul 2018 15:34:51 +0000 (09:34 -0600)]
CI:  Add wiki doc publish to periodics

Change-Id: I29ba26134e5083bc6788ede235f1a5d4383c148a

12 months agores_pjsip: Update endpoint transport option documentation.
Richard Mudgett [Thu, 19 Jul 2018 21:17:50 +0000 (16:17 -0500)]
res_pjsip: Update endpoint transport option documentation.

Change-Id: I5394fdff6a296efc8e1695a156e616acd932ae52

12 months agopjsip_resolver.c: Use replacement function
Richard Mudgett [Thu, 19 Jul 2018 18:27:30 +0000 (13:27 -0500)]
pjsip_resolver.c: Use replacement function

* Use the replacement function ast_sip_push_task_wait_servant() instead of
the deprecated ast_sip_push_task_synchronous().

Change-Id: I145b550ba7054640c7faa3b644e63137f505c612

12 months agoMerge "Update UPDATE.txt for 16 and update ARI stubs."
Joshua Colp [Thu, 19 Jul 2018 11:18:34 +0000 (06:18 -0500)]
Merge "Update UPDATE.txt for 16 and update ARI stubs."

12 months agocontrib: Update systemd README.txt.
Corey Farrell [Wed, 18 Jul 2018 22:13:44 +0000 (18:13 -0400)]
contrib: Update systemd README.txt.

Mention need to compile Asterisk with systemd development package


Change-Id: Ib3a973be403c61cbe09572b0f912fb1aa1bff026

12 months agoMerge "Update ARI version for master/16."
George Joseph [Wed, 18 Jul 2018 20:20:29 +0000 (15:20 -0500)]
Merge "Update ARI version for master/16."

12 months agoMerge "pjproject_bundled: Repair ./configure --with-ssl=PATH."
George Joseph [Wed, 18 Jul 2018 20:19:40 +0000 (15:19 -0500)]
Merge "pjproject_bundled: Repair ./configure --with-ssl=PATH."

12 months agoMerge "res_sorcery_config: Allow configuration section to be used based on name."
George Joseph [Wed, 18 Jul 2018 19:47:22 +0000 (14:47 -0500)]
Merge "res_sorcery_config: Allow configuration section to be used based on name."

12 months agoMerge "res_rtp_asterisk: Add support for sending NACK requests."
George Joseph [Wed, 18 Jul 2018 19:46:28 +0000 (14:46 -0500)]
Merge "res_rtp_asterisk: Add support for sending NACK requests."

12 months agoMerge "res_pjsip_sdp_rtp: include ice in ANSWER only if offered"
George Joseph [Wed, 18 Jul 2018 19:29:19 +0000 (14:29 -0500)]
Merge "res_pjsip_sdp_rtp: include ice in ANSWER only if offered"

12 months agoUpdate UPDATE.txt for 16 and update ARI stubs.
Joshua Colp [Wed, 18 Jul 2018 19:20:59 +0000 (19:20 +0000)]
Update UPDATE.txt for 16 and update ARI stubs.

Copied UPGRADE.txt -> UPGRADE-16.txt
Created new UPGRADE.txt

Updated ARI stubs version to 17.

Change-Id: I4210e53f8022a2a68c7653595bdd13fbebac41ee

12 months agoUpdate ARI version for master/16.
Joshua Colp [Wed, 18 Jul 2018 19:18:13 +0000 (19:18 +0000)]
Update ARI version for master/16.

ARI goes from 3.0.0 to 4.0.0

Change-Id: I0649fa34926dc4fc89a166f1d2e3bbd965ef9ebe

12 months agoMerge "module: Remove deprecated modules and update support levels."
George Joseph [Wed, 18 Jul 2018 19:13:45 +0000 (14:13 -0500)]
Merge "module: Remove deprecated modules and update support levels."

12 months agopjproject_bundled: Repair ./configure --with-ssl=PATH.
Alexander Traud [Tue, 29 May 2018 14:31:53 +0000 (16:31 +0200)]
pjproject_bundled: Repair ./configure --with-ssl=PATH.

Previously, Asterisk did not tell its bundled PJProject about this configure
parameter. Therefore, PJProject used the platform provided OpenSSL always.


Change-Id: Iea545aec854dd0e2c061c69bb118a76ce56c5dc6

12 months agores_rtp_asterisk: Add support for sending NACK requests.
Ben Ford [Thu, 10 May 2018 18:11:06 +0000 (13:11 -0500)]
res_rtp_asterisk: Add support for sending NACK requests.

Support has been added for receiving a NACK request and handling it.
Now, Asterisk can detect when a NACK request should be sent and knows
how to construct one based on the packets we've received from the remote
end. A buffer has been added that will store out of order packets until
we receive the packet we are expecting. Then, these packets are handled
like normal and frames are queued to the core like normal. Asterisk
knows which packets to request in the NACK request using a vector
which stores the sequence numbers of the packets we are currently missing.

If a missing packet is received, cycle through the buffer until we reach
another packet we have not received yet. If the buffer reaches a certain
size, send a NACK request. If the buffer reaches its max size, queue all
frames to the core and wipe the buffer and vector.

According to RFC3711, the NACK request must be sent out in a compound
packet. All compound packets must start with a sender or receiver
report, so some work was done to refactor the current sender / receiver
code to allow it to be used without having to also include sdes
information and automatically send the report.

Also added additional functionality to ast_data_buffer, along with some

For more information, refer to the wiki page:

ASTERISK-27810 #close

Change-Id: Idab644b08a1593659c92cda64132ccc203fe991d

12 months agores_sorcery_config: Allow configuration section to be used based on name.
Joshua Colp [Wed, 18 Jul 2018 16:12:59 +0000 (16:12 +0000)]
res_sorcery_config: Allow configuration section to be used based on name.

A problem I've seen countless times is a global or system section
for PJSIP not getting applied. This is inevitably the result of
the "type=" line missing. This change alleviates that problem.

The ability to specify an explicit section name has been
added to res_sorcery_config. If the configured section
name matches this and there are no unknown things configured
the section is taken as being for the given type.

Both the PJSIP "global" and "system" types now support this
so you can just name your section "global" or "system" and it
will be matched and used, even without a "type=" line.


Change-Id: Ie22723663c1ddd24f869af8c9b4c1b59e2476893

12 months agomodule: Remove deprecated modules and update support levels.
Joshua Colp [Tue, 17 Jul 2018 10:24:02 +0000 (10:24 +0000)]
module: Remove deprecated modules and update support levels.

I have removed the STATIC_BUILD option immediately as it has not
been maintained in many years and is non-functional.


Change-Id: I64783d017b86dba9ee3c7bcfb97e59889a3f76d7

12 months agostasis: Improve message type "Use of before/init after destruction"
Chris-Savinovich [Wed, 18 Jul 2018 16:34:04 +0000 (12:34 -0400)]
stasis: Improve message type "Use of before/init after destruction"

Fixes issue where error msg
"Use of before/init after destruction"
was being printed on disabled messages
in dev mode.  With this
fix if message is disabled
a warning will print.

Change-Id: Ie0d866d1cbc60c16dbef08bc65e99505c3c1adfa

12 months agoMerge "SRTP: Lower SDES key lifetime minimum to 2^20"
George Joseph [Wed, 18 Jul 2018 15:22:30 +0000 (10:22 -0500)]
Merge "SRTP: Lower SDES key lifetime minimum to 2^20"

12 months agoMerge "res_pjsip: Remove spurious error logging when printing silent headers"
Joshua Colp [Wed, 18 Jul 2018 10:49:31 +0000 (05:49 -0500)]
Merge "res_pjsip:  Remove spurious error logging when printing silent headers"

13 months agoSRTP: Lower SDES key lifetime minimum to 2^20
Nick French [Tue, 17 Jul 2018 19:12:34 +0000 (14:12 -0500)]
SRTP: Lower SDES key lifetime minimum to 2^20

SRTP SDES key lifetime support was added in ASTERISK_17899.

In that addition, the minimum key lifetime to be accepted was
set at the 10 hours @ 20ms/packet = 1800000 packets.

The firmware in the obi1xx ATA uses a hardcoded lifetime of
2^20 packets.

Lower the limit to 2^20 to support a wider field of clients.

ASTERISK-27967 #close

Change-Id: I81a0703c595a0c9101dfdf02300149a3cc39bf94

13 months agoMerge "loader: Fix startup issues."
Joshua Colp [Tue, 17 Jul 2018 17:16:17 +0000 (12:16 -0500)]
Merge "loader: Fix startup issues."

13 months agoMerge "Build: Fix modules getting their optimization setting overridden."
Joshua Colp [Tue, 17 Jul 2018 17:15:34 +0000 (12:15 -0500)]
Merge "Build: Fix modules getting their optimization setting overridden."

13 months agoCI: Fix merge strategy
George Joseph [Tue, 17 Jul 2018 16:09:01 +0000 (10:09 -0600)]
CI: Fix merge strategy

Change-Id: I5e3fb6adfa6cbf694c0deecf02e3879297b0c12e

13 months agoCI: Fix regex in daily and ref_debug jobs
George Joseph [Tue, 17 Jul 2018 15:41:40 +0000 (09:41 -0600)]
CI: Fix regex in daily and ref_debug jobs

Change-Id: Icf2e67818b2155a158d2390b138613e1f653ea92

13 months agores_pjsip: Remove spurious error logging when printing silent headers
Nick French [Tue, 17 Jul 2018 14:09:04 +0000 (09:09 -0500)]
res_pjsip:  Remove spurious error logging when printing silent headers

Asterisk patched the pjproject source to avoid crashing when pjproject
sip_msg headers are encountered with NULL vptr's, but the patch also
output error messages for some valid headers which simply did not need
to be added to the message itself, such as hidden route headers.

pjproject has since applied a similar patch to their baseline to avoid
crashes, but their version also avoids the spurious error logging.

Lets use their patch instead.

ASTERISK-27961 #close

Change-Id: I2ddbd82c8da10e0dcc9807a48089d1f3c2d6e389

13 months agoCI: Add pre-build merge back in as RECURSIVE
George Joseph [Tue, 17 Jul 2018 15:15:58 +0000 (09:15 -0600)]
CI: Add pre-build merge back in as RECURSIVE

Change-Id: I0ff1730ef4a4f0ac9f18ccc9bc0dfe7a782f57a8

13 months agoMerge "Fix declaration of PBX_CURL for ./configure --without-libcurl"
Jenkins2 [Tue, 17 Jul 2018 14:46:30 +0000 (09:46 -0500)]
Merge "Fix declaration of PBX_CURL for ./configure --without-libcurl"

13 months agoCI: Remove pre-build merge from gates and checks
George Joseph [Tue, 17 Jul 2018 14:01:46 +0000 (08:01 -0600)]
CI: Remove pre-build merge from gates and checks

Change-Id: Ibc151f63dcec4db847915c2f3cbe5b467dd59574

13 months agoCI: Fix logic inversion in runTestsuite
George Joseph [Tue, 17 Jul 2018 12:13:35 +0000 (06:13 -0600)]
CI: Fix logic inversion in runTestsuite

Change-Id: I56399aa384468f45494c2c3650420563a0b6efe1

13 months agoCI: Add teardownRealtime
George Joseph [Tue, 17 Jul 2018 09:03:02 +0000 (03:03 -0600)]
CI: Add teardownRealtime

Change-Id: I2fe55c38607eaec2fbf69ef23a5019e0c443a64b

13 months agoloader: Fix startup issues.
Corey Farrell [Sun, 15 Jul 2018 18:58:15 +0000 (14:58 -0400)]
loader: Fix startup issues.

* Merge the preload and load stages, use load ordering to try preload's
  first.  This fixes an issue where `preload=res_config_curl` would fail
  unless res_curl and func_curl were also preloaded.  Now it is only
  required that those modules be loaded during startup: autoload or
  regular load is good enough.
* The configuration option `require` and `preload-require` were only
  effective if the modules failed to load.  These options will now abort
  Asterisk startup if required modules fail to reach the 'Running'
* Missing or invalid 'module.conf' did not prevent startup.  Asterisk
  doesn't do anything without modules so this a fatal error.

Change-Id: Ie4176699133f0e3a823b43f90c3348677e43a5f3

13 months agoCI: Prevent Jenkins from triggering jobs back to itself
George Joseph [Mon, 16 Jul 2018 18:30:26 +0000 (12:30 -0600)]
CI:  Prevent Jenkins from triggering jobs back to itself

Change-Id: I9cae8bb3d1a2cea335d3ccd88d471832549666fd

13 months agoBuild: Fix modules getting their optimization setting overridden.
Richard Mudgett [Fri, 13 Jul 2018 23:26:46 +0000 (18:26 -0500)]
Build: Fix modules getting their optimization setting overridden.

Asterisk modules that use PJPROJECT services have their compiler
optimization and possibly their symbolic debug options overridden by the
PJPROJECT configure script selected settings.

* We need to filter-out any -O and -g options in PJ_CFLAGS before echoing
out the result so the PJPROJECT_INCLUDE variable does not override the
Asterisk module settings when using bundled PJPROJECT.

NOTE: This patch only has an effect when using bundled PJPROJECT.


Change-Id: If124169735ecf572ad1535cd43bff94cb44d5b30

13 months agoCI: runUnittests: loop a few times on waitfullybooted
George Joseph [Mon, 16 Jul 2018 16:08:57 +0000 (10:08 -0600)]
CI: runUnittests: loop a few times on waitfullybooted

Change-Id: Icebc0d013896f3b2a7214945cac60647435c1651

13 months agoCI: Add realtime checks to dailies
George Joseph [Mon, 16 Jul 2018 15:49:54 +0000 (09:49 -0600)]
CI:  Add realtime checks to dailies

Change-Id: I6dc8ab1679b3505c6dde1d47e1b9276df47814f8

13 months agoCI: Add weekly REF_DEBUG testsuite run
George Joseph [Mon, 16 Jul 2018 14:13:40 +0000 (08:13 -0600)]
CI:  Add weekly REF_DEBUG testsuite run

Change-Id: I5b581d0a0d1d1bb9b38961d40b112fb448355037

13 months agoCI: Fix bad reporting of status by the verification pub
George Joseph [Mon, 16 Jul 2018 13:44:25 +0000 (07:44 -0600)]
CI: Fix bad reporting of status by the verification pub

Change-Id: I6f31a130b3ba0187149aaaa2ce94195a79e0f6a6

13 months agoCI: Make build tag an acceptable docker name
George Joseph [Mon, 16 Jul 2018 12:16:51 +0000 (06:16 -0600)]
CI: Make build tag an acceptable docker name

Change-Id: I3a4b8a4a9c488ddabf9daf651dc1334222056f38

13 months agoFix declaration of PBX_CURL for ./configure --without-libcurl
Corey Farrell [Sat, 14 Jul 2018 03:44:53 +0000 (23:44 -0400)]
Fix declaration of PBX_CURL for ./configure --without-libcurl

When `--without-libcurl` is used PBX_CURL is never set.  Set default
value 0 so the proper value is passed to menuselect.

Change-Id: I03e2842a00899cbca2dbde52bb1f6636d54bae1e

13 months agoMerge "app_confbridge: Use the SDP 'label' attribute to correlate users"
George Joseph [Fri, 13 Jul 2018 18:12:51 +0000 (13:12 -0500)]
Merge "app_confbridge:  Use the SDP 'label' attribute to correlate users"

13 months agoMerge "Bundled PJPROJECT: Disable internal connection oriented keep-alive."
George Joseph [Fri, 13 Jul 2018 18:11:50 +0000 (13:11 -0500)]
Merge "Bundled PJPROJECT: Disable internal connection oriented keep-alive."

13 months agoapp_confbridge: Use the SDP 'label' attribute to correlate users
George Joseph [Tue, 10 Jul 2018 18:28:09 +0000 (12:28 -0600)]
app_confbridge:  Use the SDP 'label' attribute to correlate users

Previously, the msid "label" attribute was used to correlate
participant info but because streams could be reused, the msid
wasn't being updated correctly when someone left the bridge and
another joined.

Now, instead of looking for the msid attribute on a channel's streams,
app_confbridge sets an "SDP:LABEL" attribute on the stream which
res_pjsip_sdp_rtp looks for.  If it finds it, it adds a "label"
attribute to the current sdp.

Change-Id: I6cbaa87fb59a2e0688d956e72d2d09e4ac20d5a5

13 months agoCI: Add daily periodics to CI
George Joseph [Fri, 13 Jul 2018 11:56:38 +0000 (05:56 -0600)]
CI: Add daily periodics to CI

Change-Id: I26933e73928e091ae72e838c02f4f2ec7c3983d6

13 months agoBundled PJPROJECT: Disable internal connection oriented keep-alive.
Alexander Traud [Wed, 11 Jul 2018 16:57:53 +0000 (11:57 -0500)]
Bundled PJPROJECT: Disable internal connection oriented keep-alive.

Turn off the periodic sending of CRLNCRLN.  Default is on (90 seconds),
which conflicts with the global section's keep_alive_interval option in

  pjsip_keep_not_alive.patch submitted by Alexander Traud (License 6520)


Change-Id: I6a197f56e1830d3b7e5ec70f17025840a290b057

13 months agores_pjsip_sdp_rtp: include ice in ANSWER only if offered
Torrey Searle [Mon, 9 Jul 2018 09:42:11 +0000 (11:42 +0200)]
res_pjsip_sdp_rtp: include ice in ANSWER only if offered

Keep track if ICE candidates were in the SDP offer & only put them
in the corresponding SDP answer if the offer condaind ICE candidates

ASTERISK-27957 #close

Change-Id: Idf2597ee48e9a287e07aa4030bfa705430a13a92

13 months agoMerge "res_parking: Add dialplan function for lot channel"
George Joseph [Thu, 12 Jul 2018 22:14:31 +0000 (17:14 -0500)]
Merge "res_parking: Add dialplan function for lot channel"

13 months agoCI: Add Asterisk Gates
George Joseph [Thu, 12 Jul 2018 21:34:14 +0000 (15:34 -0600)]
CI: Add Asterisk Gates

Change-Id: I7e2467f9120812551238d8005deb97f965279205

13 months agoCI: Remove duplicate checkout
George Joseph [Wed, 11 Jul 2018 20:55:55 +0000 (14:55 -0600)]
CI: Remove duplicate checkout

Change-Id: If5f925b4c4ed7000b153f3ed8386ce2140c886f8

13 months agoCI: Update cleanup steps and permissions
George Joseph [Wed, 11 Jul 2018 20:09:19 +0000 (14:09 -0600)]
CI: Update cleanup steps and permissions

Change-Id: I7ca92935979d94845af8e1caf4468cbd6209b7de

13 months agoCI: Fix log artifact paths
George Joseph [Wed, 11 Jul 2018 19:54:04 +0000 (13:54 -0600)]
CI: Fix log artifact paths

Change-Id: I55136de8f4d9c3b56bd4d054306a187bb04a4b7d

13 months agoCI: Remove CleanBeforeCheckout option for testsuite
George Joseph [Wed, 11 Jul 2018 19:45:01 +0000 (13:45 -0600)]
CI: Remove CleanBeforeCheckout option for testsuite

Change-Id: I510231c9087f7be5272b8ef3f3223eadaaffb754

13 months agoCI: Move gates into source repo
George Joseph [Wed, 11 Jul 2018 19:00:38 +0000 (13:00 -0600)]
CI: Move gates into source repo

Change-Id: If028ede5f3b127fa274c63ce166bc04ad7c1e5db

13 months agoCI: Initial commit for moving CI into source repo
George Joseph [Wed, 11 Jul 2018 11:14:49 +0000 (05:14 -0600)]
CI:  Initial commit for moving CI into source repo

Create tests/CI directory and add files used by Jenkins to
build and test Asterisk.

With this commit, Jenkins will run the Asterisk Unit Tests using
the Jenkinsfile at tests/CI/unittests.jenkinsfile.  Bash scripts
to do the actual building and testing are also in the same directory.
Output is placed in tests/CI/output so that directory has been
added to .gitignore.

Change-Id: I9448065465e6de2b878634510ace8fd1ef378608

13 months agores_parking: Add dialplan function for lot channel
Joshua Elson [Fri, 6 Jul 2018 22:00:06 +0000 (16:00 -0600)]
res_parking: Add dialplan function for lot channel

This commit adds a new function to res_parking.

This function, PARK_GET_CHANNEL allows the retrieval
of the channel name of the channel occupying the parking slot.

ASTERISK-22825 #close

Change-Id: Idba6ae55b8a53f734238cb3d995cedb95c0e7b74

13 months agoMerge "res_pjsip_t38.c: Be smarter about how we respond when T.38 is disabled."
Joshua Colp [Tue, 10 Jul 2018 12:21:45 +0000 (07:21 -0500)]
Merge "res_pjsip_t38.c: Be smarter about how we respond when T.38 is disabled."

13 months agoMerge "res_pjsip_pubsub: segfault in function publish_expire"
Jenkins2 [Tue, 10 Jul 2018 11:49:44 +0000 (06:49 -0500)]
Merge "res_pjsip_pubsub: segfault in function publish_expire"

13 months agoMerge "chan_ooh323: IPTOS_MINCOST is not defined on Solaris."
Jenkins2 [Tue, 10 Jul 2018 11:25:51 +0000 (06:25 -0500)]
Merge "chan_ooh323: IPTOS_MINCOST is not defined on Solaris."

13 months agoMerge "res_pjsip/pjsip_transport_management.c: Fix deadlock with transport keep alive."
Joshua Colp [Mon, 9 Jul 2018 12:14:51 +0000 (07:14 -0500)]
Merge "res_pjsip/pjsip_transport_management.c: Fix deadlock with transport keep alive."

13 months agoMerge "test.c: Make output jUnit compatible"
Jenkins2 [Mon, 9 Jul 2018 11:33:58 +0000 (06:33 -0500)]
Merge "test.c:  Make output jUnit compatible"

13 months agoMerge "res_pjsip_session: sdp group:BUNDLE attribute being truncated"
Jenkins2 [Mon, 9 Jul 2018 10:51:14 +0000 (05:51 -0500)]
Merge "res_pjsip_session: sdp group:BUNDLE attribute being truncated"

13 months agoMerge "res_pjsip_t38: Decline T.38 stream on failure case."
Joshua Colp [Mon, 9 Jul 2018 10:32:58 +0000 (05:32 -0500)]
Merge "res_pjsip_t38: Decline T.38 stream on failure case."

13 months agochan_ooh323: IPTOS_MINCOST is not defined on Solaris.
Alexander Traud [Sat, 23 Jun 2018 06:33:34 +0000 (08:33 +0200)]
chan_ooh323: IPTOS_MINCOST is not defined on Solaris.

Furthermore, <sys/sockio.h> is required for SIOCGIF*.


Change-Id: Idc9153ece769944765b66122efb11728d8d8ebde

13 months agores_pjsip_session: sdp group:BUNDLE attribute being truncated
Kevin Harwell [Fri, 6 Jul 2018 20:05:47 +0000 (15:05 -0500)]
res_pjsip_session: sdp group:BUNDLE attribute being truncated

When setting/appending the media id's to the bundle group attribute a '-1' was
being passed to the 'ast_str_set/append' function for the 'max_len' parameter.
This essentially capped the length of the string to what it was originally
allocated with. In this case 64 bytes.

This patch makes it so a '0' is passed as in for the 'max_len', which means
"no maximum length".

ASTERISK-27955 #close

Change-Id: Iec565df6600401d54a502854a53d19bb4cc34876

13 months agores_pjsip_pubsub: segfault in function publish_expire
Alexei Gradinari [Thu, 5 Jul 2018 21:02:00 +0000 (17:02 -0400)]
res_pjsip_pubsub: segfault in function publish_expire

The function pubsub_on_rx_publish_request incorrectly uses

The AST_SCHED_REPLACE_UNREF should unref old '_data'.

Because of this, there may be a double unref
of variable 'publication' when ast_sched_del is unsuccessful
that leads to use after free of the 'publication' in publish_expire.

ASTERISK-27956 #close

Change-Id: Ie0f0cfc7e036953d890b188656010b325a5cdc82

13 months agotest.c: Make output jUnit compatible
George Joseph [Fri, 6 Jul 2018 14:04:56 +0000 (08:04 -0600)]
test.c:  Make output jUnit compatible

Separate "name" into "classname" and "name".
Use '.' for classname separator instead of '/'.
Prefix reserved words with '_'.
Wrap output with a top-level "testsuites" element.

Change-Id: Iec1a985eba1c478e5c1d65d5dfd95cb708442099

13 months agores_pjsip: Add 'suppress_q850_reason_headers' option to endpoint
George Joseph [Fri, 6 Jul 2018 12:57:37 +0000 (06:57 -0600)]
res_pjsip:  Add 'suppress_q850_reason_headers' option to endpoint

A new option 'suppress_q850_reason_headers' has been added to the
endpoint object. Some devices can't accept multiple Reason headers and
get confused when both 'SIP' and 'Q.850' Reason headers are received.
This option allows the 'Q.850' Reason header to be suppressed.
The default value is 'no'.

Reported-by: Ross Beer

Change-Id: I54cf37a827d77de2079256bb3de7e90fa5e1deb1

13 months agores_pjsip_t38: Decline T.38 stream on failure case.
Joshua Colp [Thu, 5 Jul 2018 20:43:35 +0000 (20:43 +0000)]
res_pjsip_t38: Decline T.38 stream on failure case.

When negotiating an incoming T.38 stream the code incorrectly
returned failure instead of a decline for the stream when a
problem occurred or the configuration didn't allow it. This
resulted in SDP offers being rejected with a 488 response
in all cases, even when another valid stream was present.

This change makes it so the stream is now declined. If no
streams are accepted a 488 response is sent while if at least
one stream is accepted all the declined streams are, well,


Change-Id: I88bcf793788c412a9839d111a5c736bf6867807c

13 months agoMerge "bridge_softmix_binaural: Enable FFTW3 in Solaris 11."
Jenkins2 [Thu, 5 Jul 2018 20:41:12 +0000 (15:41 -0500)]
Merge "bridge_softmix_binaural: Enable FFTW3 in Solaris 11."

13 months agores_pjsip_t38.c: Be smarter about how we respond when T.38 is disabled.
Richard Mudgett [Mon, 2 Jul 2018 23:43:10 +0000 (18:43 -0500)]
res_pjsip_t38.c: Be smarter about how we respond when T.38 is disabled.

We were blindly responding with AST_T38_REFUSED when ANY T.38 control
frame came accross the bridge.  This causes T.38 Gateway to get confused
and the T.38 session to get in a strange state.

* Made the T.38 framehook only respond to request frames and ignore
response frames.


Change-Id: I5fb5967c7d1efb30a7ff375f82887ca82a55b05b

13 months agoMerge "res_pjsip_t38.c: Fix crash by ignoring 1xx messages."
Jenkins2 [Thu, 5 Jul 2018 15:53:47 +0000 (10:53 -0500)]
Merge "res_pjsip_t38.c: Fix crash by ignoring 1xx messages."

13 months agores_pjsip/pjsip_transport_management.c: Fix deadlock with transport keep alive.
Richard Mudgett [Tue, 3 Jul 2018 17:10:36 +0000 (12:10 -0500)]
res_pjsip/pjsip_transport_management.c: Fix deadlock with transport keep alive.

Using the keep_alive_interval option can result in a deadlock between the
pjproject transport manager group lock and the monitored transports ao2
container lock.  The pjproject transport manager group lock has to be
superior in the locking order to the monitored transports ao2 container
lock because of pjproject callbacks called when already holding the group
lock.  The lock inversion happens when Asterisk attempts to send a keep
alive packet over the reliable transports.

* Made keepalive_transport_thread() iterate over the monitored transports
container rather than use the ao2_callback() method.  This avoids holding
the container lock when sending the keep alive packet.


Change-Id: I5d5392a52e698bbe41a93f7d8e92bf0e61fe3951

13 months agoMerge "pjsip: Clarify certificate configuration for Websocket."
Joshua Colp [Tue, 3 Jul 2018 16:36:00 +0000 (11:36 -0500)]
Merge "pjsip: Clarify certificate configuration for Websocket."

13 months agopjsip: Clarify certificate configuration for Websocket.
Joshua Colp [Mon, 2 Jul 2018 23:44:53 +0000 (20:44 -0300)]
pjsip: Clarify certificate configuration for Websocket.

The Websocket transport uses the built-in HTTP server. As a result
the TLS configuration is done in http.conf and not in pjsip.conf.

This change adds a warning if this is configured in pjsip.conf and
also clarifies in the sample configuration file.

Change-Id: I187d994d328c3ed274b6754fd4c2a4955bdc6dd9

13 months agobridge_softmix_binaural: Enable FFTW3 in Solaris 11.
Alexander Traud [Sat, 23 Jun 2018 09:50:00 +0000 (11:50 +0200)]
bridge_softmix_binaural: Enable FFTW3 in Solaris 11.


Change-Id: Ice5640e08385a64a0a6555deaccd91e86bca154f

13 months agores_pjsip_t38.c: Fix crash by ignoring 1xx messages.
Richard Mudgett [Fri, 29 Jun 2018 23:28:26 +0000 (18:28 -0500)]
res_pjsip_t38.c: Fix crash by ignoring 1xx messages.

If we initiated a T.38 reINVITE, we would crash if we received any other
1xx response message except 100 if it were followed by a 200 response.

* Made ignore any 1xx response so we do not close out the T.38 negotiation
too early.  For good measure we'll now accept any 2xx response as
acceptance of the reINVITE T.38 offer.


Change-Id: I0ca88aae708d091db7335af73f41035a212adff4

13 months agores_pjsip_pubsub: Hold module reference for publications.
Joshua Colp [Sun, 1 Jul 2018 18:54:05 +0000 (15:54 -0300)]
res_pjsip_pubsub: Hold module reference for publications.

Incoming publications need to ensure that the module remains
loaded for the lifetime of them. This is now done by holding
a reference to the module while the publication exists. This
mirrors that of inbound subscriptions.


Change-Id: Ia98c95a15e11af25728d5fb3e56e12cda0cfc7c0

13 months agoMerge "app_confbridge: Bridge and announcers not removed if conference ends quickly"
Jenkins2 [Mon, 2 Jul 2018 12:16:55 +0000 (07:16 -0500)]
Merge "app_confbridge: Bridge and announcers not removed if conference ends quickly"

13 months agoMerge "main/cdr.c: Alleviate CDR deadlock"
Joshua Colp [Mon, 2 Jul 2018 11:54:18 +0000 (06:54 -0500)]
Merge "main/cdr.c: Alleviate CDR deadlock"