asterisk/asterisk.git
2 years agostream: Add unit tests for channel stream usage.
Joshua Colp [Tue, 14 Feb 2017 18:33:57 +0000 (18:33 +0000)]
stream: Add unit tests for channel stream usage.

This change adds unit tests cover the following:

1. That retrieving the first media stream of a specific media
type from a stream topology retrieves the expected media
stream.

2. That setting the native formats of a channel which does
not support streams results in the creation of streams on
its behalf according to the formats of the channel.

3. That setting a stream topology on a channel which supports
streams sets the topology to the provided one.

ASTERISK-26790

Change-Id: Ic53176dd3e4532e8c3e97d9e22f8a4b66a2bb755

2 years agostream: Add stream topology to channel
George Joseph [Mon, 13 Feb 2017 17:50:47 +0000 (10:50 -0700)]
stream:  Add stream topology to channel

Adds topology set and get to channel.

ASTERISK-26790

Change-Id: Ic379ea82a9486fc79dbd8c4d95c29fa3b46424f4

2 years agostream: Add stream topology unit tests and fix uncovered bugs.
Joshua Colp [Mon, 13 Feb 2017 17:00:42 +0000 (17:00 +0000)]
stream: Add stream topology unit tests and fix uncovered bugs.

This change adds unit tests for the various API calls relating
to stream topologies. This includes creation, destruction,
inspection, and manipulation.

Through this a few bugs were uncovered in the implementation:

1. Creating a topology using a format capabilities would fail as
the code considered a return value of 0 from the append stream
function to indicate an error which is incorrect.

2. Not all functions which placed a stream into a topology
set the position on the stream itself.

3. Appending a stream would cause a frack if the position
provided was the last one. This occurred because the existing
stream was queried but the index was outside of what the
vector was currently at for size.

ASTERISK-26786

Change-Id: Id5590e87c8a605deea1a89e53169a9c011d66fa0

2 years agostream: Add media stream topology definition and API
George Joseph [Fri, 10 Feb 2017 21:45:43 +0000 (14:45 -0700)]
stream:  Add media stream topology definition and API

This change adds the media stream topology definition and API for
accessing and using it.

Some refactoring of the stream was also done.

ASTERISK-26786

Change-Id: Ic930232d24d5ad66dcabc14e9b359e0ff8e7f568

2 years agostream: Add media stream definition and API with unit tests.
Joshua Colp [Tue, 7 Feb 2017 12:56:41 +0000 (12:56 +0000)]
stream: Add media stream definition and API with unit tests.

This change adds the media stream definition and API for
accessing and using it. Unit tests have also been written
which exercise aspects of the API.

ASTERISK-26773

Change-Id: I3dbe54065b55aaa51f467e1a3bafd67fb48cac87

2 years agoRevert "Update qualifies when AOR configuration changes."
Mark Michelson [Wed, 8 Feb 2017 17:50:11 +0000 (11:50 -0600)]
Revert "Update qualifies when AOR configuration changes."

This reverts commit 6492e91392b8fd394193e411c6eb64b45486093f.

The change in question was intended to prevent the need to reload in
order to update qualifies on contacts when an AOR changes. However, this
ended up causing a deadlock instead.

Change-Id: I1a835c90a5bb65b6dc3a1e94cddc12a4afc3d71e

2 years agoMerge "srv: Fix crash when ast_srv_lookup is used and 0 records are returned."
zuul [Wed, 8 Feb 2017 16:00:05 +0000 (10:00 -0600)]
Merge "srv: Fix crash when ast_srv_lookup is used and 0 records are returned."

2 years agosrv: Fix crash when ast_srv_lookup is used and 0 records are returned.
Joshua Colp [Tue, 7 Feb 2017 18:01:03 +0000 (18:01 +0000)]
srv: Fix crash when ast_srv_lookup is used and 0 records are returned.

When performing an SRV lookup using the ast_srv_lookup function it
did not properly handle the situation where 0 records are returned.
If this happened it would wrongly assume that at least one record
was present.

This change fixes the code so it will exit early if an error occurs
or if 0 records are returned.

ASTERISK-26772
patches:
  srv_lookup.patch submitted by nappsoft (license 6822)

Change-Id: I09b19081c74e0ad11c12bf54a257243b1bcb2351

2 years agores_stasis_device_state: Protect the adding/removing of subscriptions.
Joshua Colp [Mon, 6 Feb 2017 17:40:45 +0000 (17:40 +0000)]
res_stasis_device_state: Protect the adding/removing of subscriptions.

The adding and removing of device state subscriptions did not protect
fully against simultaneous manipulation. In particular the subscribe
case allowed a small window where two subscriptions could be added for
the same device state instead of just one.

This change makes the code hold the subscriptions lock for the entirety
of each operation to ensure that two are not occurring at the same time.

ASTERISK-26770

Change-Id: I3e7f8eb9d09de440c9024d2dd52029f6f20e725b

2 years agores_pjsip: Fix some off nominal tdata leaks.
Richard Mudgett [Wed, 1 Feb 2017 23:56:13 +0000 (17:56 -0600)]
res_pjsip: Fix some off nominal tdata leaks.

Change-Id: I243a4be5e7fbfe604923764969c4ee04eee89b9d

2 years agores_ari: fix memory leak for channelvars
Sebastien Duthil [Fri, 3 Feb 2017 21:26:23 +0000 (16:26 -0500)]
res_ari: fix memory leak for channelvars

In ari.conf, when setting the option channelvars, every Stasis channel
snapshot would create a list of variable/value that would not be freed
when the snapshot is freed, resulting in a often-recurring memory
leak.

ASTERISK-26767 #close

Change-Id: Ia37dd9d68063d7f879193df02ede293e5ded716d

2 years agoMerge "Update qualifies when AOR configuration changes."
Joshua Colp [Fri, 3 Feb 2017 15:32:53 +0000 (09:32 -0600)]
Merge "Update qualifies when AOR configuration changes."

2 years agoMerge "channel.c: Fix unbalanced read queue deadlocking local channels."
Joshua Colp [Fri, 3 Feb 2017 11:32:26 +0000 (05:32 -0600)]
Merge "channel.c: Fix unbalanced read queue deadlocking local channels."

2 years agoMerge "res_agi: Prevent an AGI from eating frames it should not. (Re-do)"
Joshua Colp [Fri, 3 Feb 2017 11:32:12 +0000 (05:32 -0600)]
Merge "res_agi: Prevent an AGI from eating frames it should not. (Re-do)"

2 years agoMerge "Add reload options to CLI/AMI stale object commands."
George Joseph [Fri, 3 Feb 2017 00:34:03 +0000 (18:34 -0600)]
Merge "Add reload options to CLI/AMI stale object commands."

2 years agoMerge "Frame deferral: Revert API refactoring."
Joshua Colp [Fri, 3 Feb 2017 00:08:43 +0000 (18:08 -0600)]
Merge "Frame deferral: Revert API refactoring."

2 years agoMerge "res_odbc: Remove deprecated settings from sample configuration file"
zuul [Thu, 2 Feb 2017 22:40:03 +0000 (16:40 -0600)]
Merge "res_odbc: Remove deprecated settings from sample configuration file"

2 years agochannel.c: Fix unbalanced read queue deadlocking local channels.
Richard Mudgett [Wed, 1 Feb 2017 00:28:15 +0000 (18:28 -0600)]
channel.c: Fix unbalanced read queue deadlocking local channels.

Using the timerfd timing module can cause channel freezing, lingering, or
deadlock issues.  The problem is because this is the only timing module
that uses an associated alert-pipe.  When the alert-pipe becomes
unbalanced with respect to the number of frames in the read queue bad
things can happen.  If the alert-pipe has fewer alerts queued than the
read queue then nothing might wake up the thread to handle received frames
from the channel driver.  For local channels this is the only way to wake
up the thread to handle received frames.  Being unbalanced in the other
direction is less of an issue as it will cause unnecessary reads into the
channel driver.

ASTERISK-26716 is an example of this deadlock which was indirectly fixed
by the change that found the need for this patch.

* In channel.c:__ast_queue_frame(): Adding frame lists to the read queue
did not add the same number of alerts to the alert-pipe.  Correspondingly,
when there is an exceptionally long queue event, any removed frames did
not also remove the corresponding number of alerts from the alert-pipe.

ASTERISK-26632 #close

Change-Id: Ia98137c5bf6e9d6d202ce0eb36441851875863f6

2 years agores_agi: Prevent an AGI from eating frames it should not. (Re-do)
Richard Mudgett [Tue, 31 Jan 2017 22:38:49 +0000 (16:38 -0600)]
res_agi: Prevent an AGI from eating frames it should not. (Re-do)

A dialplan intercept routine is equivalent to an interrupt routine.  As
such, the routine must be done quickly and you do not have access to the
media stream.  These restrictions are necessary because the media stream
is the responsibility of some other code and interfering with or delaying
that processing is bad.  A possible future dialplan processing
architecture change may allow the interception routine to run in a
different thread from the main thread handling the media and remove the
execution time restriction.

* Made res_agi.c:run_agi() running an AGI in an interception routine run
in DeadAGI mode.  No touchy channel frames.

ASTERISK-25951

ASTERISK-26343

ASTERISK-26716

Change-Id: I638f147ca7a7f2590d7194a8ef4090eb191e4e43

2 years agoFrame deferral: Revert API refactoring.
Richard Mudgett [Tue, 31 Jan 2017 22:32:18 +0000 (16:32 -0600)]
Frame deferral: Revert API refactoring.

There are several issues with deferring frames that are caused by the
refactoring.

1) The code deferring frames mishandles adding a deferred frame to the
deferred queue.  As a result the deferred queue can only be one frame
long.

2) Deferrable frames can come directly from the channel driver as well as
the read queue.  These frames need to be added to the deferred queue.

3) Whoever is deferring frames is really only doing the __ast_read() to
collect deferred frames and doesn't care about the returned frames except
to detect a hangup event.  When frame deferral is completed we must make
the normal frame processing see the hangup as a frame anyway.  As such,
there is no need to have varying hangup frame deferral methods.  We also
need to be aware of the AST_SOFTHANGUP_ASYNCGOTO hangup that isn't real.
That fake hangup is to cause the PBX thread to break out of loops to go
execute a new dialplan location.

4) To properly deal with deferrable frames from the channel driver as
pointed out by (2) above, means that it is possible to process a dialplan
interception routine while frames are deferred because of the
AST_CONTROL_READ_ACTION control frame.  Deferring frames is not
implemented as a re-entrant operation so you could have the unsupported
case of two sections of code thinking they have control of the media
stream.

A worse problem is because of the bad implementation of the AMI PlayDTMF
action.  It can cause two threads to be deferring frames on the same
channel at the same time.  (ASTERISK_25940)

* Rather than fix all these problems simply revert the API refactoring as
there is going to be only autoservice and safe_sleep deferring frames
anyway.

ASTERISK-26343

ASTERISK-26716 #close

Change-Id: I45069c779aa3a35b6c863f65245a6df2c7865496

2 years agoMerge "audiohooks: Muting a hook can mute underlying frames"
zuul [Thu, 2 Feb 2017 17:51:21 +0000 (11:51 -0600)]
Merge "audiohooks:  Muting a hook can mute underlying frames"

2 years agores_odbc: Remove deprecated settings from sample configuration file
Sean Bright [Thu, 2 Feb 2017 17:26:12 +0000 (12:26 -0500)]
res_odbc: Remove deprecated settings from sample configuration file

ASTERISK-26704 #close
Reported by: Anthony Messina

Change-Id: I976a1f94cf79c5f31e76174c61f5c6a65fd6354f

2 years agoMerge "res_pjsip: Handle invocation of callback on outgoing request when error occurs."
zuul [Thu, 2 Feb 2017 16:44:58 +0000 (10:44 -0600)]
Merge "res_pjsip: Handle invocation of callback on outgoing request when error occurs."

2 years agores_resolver_unbound.c: Fix frequent ref leak caught by excessive ref trap.
Richard Mudgett [Wed, 1 Feb 2017 23:14:53 +0000 (17:14 -0600)]
res_resolver_unbound.c: Fix frequent ref leak caught by excessive ref trap.

ASTERISK-26765

Change-Id: I27eb97df7f8d7e624b0b9a61c0fcee4718c86d8d

2 years agoaudiohooks: Muting a hook can mute underlying frames
Sean Bright [Wed, 1 Feb 2017 21:56:50 +0000 (16:56 -0500)]
audiohooks:  Muting a hook can mute underlying frames

If an audiohook is placed on a channel that does not require transcoding,
muting that hook will cause the underlying frames to be muted as well.

The original patch is from David Woolley but I have modified slightly.

ASTERISK-21094 #close
Reported by: David Woolley
Patches:
      ASTERISK-21094-Patch-1.8-1.txt (license #5737) patch uploaded
      by David Woolley

Change-Id: Ib2b68c6283e227cbeb5fa478b2d0f625dae338ed

2 years agoMerge "res_rtp_asterisk: Swap byte-order when sending signed linear"
Joshua Colp [Wed, 1 Feb 2017 21:36:23 +0000 (15:36 -0600)]
Merge "res_rtp_asterisk:  Swap byte-order when sending signed linear"

2 years agoUpdate qualifies when AOR configuration changes.
Mark Michelson [Wed, 1 Feb 2017 19:54:50 +0000 (13:54 -0600)]
Update qualifies when AOR configuration changes.

Prior to this change, qualifies would only update in the following
cases:
* A reload of res_pjsip.so was issued.
* A dynamic contact was re-registered after its AOR's qualify_frequency
  had been changed
This does not work well if you are using realtime for your AORs. You can
update your database to have a new qualify_frequency, but the permanent
contacts on that AOR will not have their qualifies updated. And the
dynamic contacts on that AOR will not have their qualifies updated until
the next registration, which could be a long time.

This change seeks to fix this problem by making it so that whenever AOR
configuration is applied, the contacts pertaining to that AOR have their
qualifies updated.

Additions from this patch:
* AOR sorcery objects now have an apply handler that calls into a newly
  added function in the OPTIONS code. This causes all contacts
  associated with that AOR to re-schedule qualifies.
* When it is time to qualify a contact, the OPTIONS code checks to see
  if the AOR can still be retrieved. If not, then qualification is
  canceled on the contact.

Alterations from this patch:
* The registrar code no longer updates contact's qualify_frequence and
  qualify_timeout. There is no point to this since those values already
  get updated when the AOR changes.
* Reloading res_pjsip.so no longer calls the OPTIONS initialization
  function. Reloading res_pjsip.so results in re-loading AORs, which
  results in re-scheduling qualifies.

Change-Id: I2e7c3316da28f389c45954f24c4e9389abac1121

2 years agores_pjsip: Handle invocation of callback on outgoing request when error occurs.
Joshua Colp [Tue, 31 Jan 2017 17:17:50 +0000 (17:17 +0000)]
res_pjsip: Handle invocation of callback on outgoing request when error occurs.

There are some error cases in PJSIP when sending a request that will
result in the callback for the request being invoked.  The code did not
handle this case and assumed on every error case that the callback was not
invoked.

The code has been changed to check whether the callback has been invoked
and if so to absorb the error and treat it as a success.

ASTERISK-26679
ASTERISK-26699

Change-Id: I563982ba204da5aa1428989a11c06dd9087fea91

2 years agores_rtp_asterisk: Swap byte-order when sending signed linear
Sean Bright [Mon, 30 Jan 2017 15:02:14 +0000 (10:02 -0500)]
res_rtp_asterisk:  Swap byte-order when sending signed linear

Before Asterisk 13, signed linear was converted into network byte order by a
smoother before being sent over the network. We restore this behavior by
forcing the creation of a smoother when slinear is in use and setting the
appropriate flags so that the byte order conversion is always done.

ASTERISK-24858 #close
Reported-by: Frankie Chin

Change-Id: I868449617d1a7819578f218c8c6b2111ad84f5a9

2 years agodebug_utilities: Install ast_logescalator to /var/lib/asterisk/scripts
George Joseph [Tue, 31 Jan 2017 18:46:08 +0000 (11:46 -0700)]
debug_utilities: Install ast_logescalator to /var/lib/asterisk/scripts

Forgot to install it with the original patch

Change-Id: I8bdb540a6694971ae5fe21f48d532332c6482e4c

2 years agoMerge "make_build_h: handle backslashes in external strings"
zuul [Tue, 31 Jan 2017 15:43:51 +0000 (09:43 -0600)]
Merge "make_build_h: handle backslashes in external strings"

2 years agoMerge "app_queue: Fix queues randomly disappearing on reload"
zuul [Mon, 30 Jan 2017 17:39:26 +0000 (11:39 -0600)]
Merge "app_queue: Fix queues randomly disappearing on reload"

2 years agoMerge "debug_utilities: Add ast_logescalator"
zuul [Sun, 29 Jan 2017 17:22:05 +0000 (11:22 -0600)]
Merge "debug_utilities:  Add ast_logescalator"

2 years agoMerge "libastssl/pj: libastssl/pj should have an so_version"
zuul [Sat, 28 Jan 2017 01:18:13 +0000 (19:18 -0600)]
Merge "libastssl/pj: libastssl/pj should have an so_version"

2 years agodebug_utilities: Add ast_logescalator
George Joseph [Wed, 25 Jan 2017 12:50:43 +0000 (05:50 -0700)]
debug_utilities:  Add ast_logescalator

The escalator works by creating a set of startup commands in cli.conf
that set up logger channels and issue the debug commands for the
subsystems specified.  If asterisk is running when it is executed,
the same commands will be issued to the running instance.  The original
cli.conf is saved before any changes are made and can be restored by
executing '$prog --reset'.

The log output will be stored in...
$astlogdir/message.$uniqueid
$astlogdir/debug.$uniqueid
$astlogdir/dtmf.$uniqueid
$astlogdir/fax.$uniqueid
$astlogdir/security.$uniqueid
$astlogdir/pjsip_history.$uniqueid
$astlogdir/sip_history.$uniqueid

Some minor tweaks were made to chan_sip, and res_pjsip_history
so their history output could be send to a log channel as packets
are captured.

A minor tweak was also made to manager so events are output to verbose
when "manager set debug on" is issued.

Change-Id: I799f8e5013b86dc5282961b27383d134bf09e543

2 years agoMerge "tests: use datadir for sound files"
zuul [Fri, 27 Jan 2017 18:44:05 +0000 (12:44 -0600)]
Merge "tests: use datadir for sound files"

2 years agolibastssl/pj: libastssl/pj should have an so_version
Torrey Searle [Mon, 23 Jan 2017 15:35:38 +0000 (16:35 +0100)]
libastssl/pj: libastssl/pj should have an so_version

Issue introduced in b59956a87.  In the non-darwin case libastssl/pj
should be versioned.  This causes the symbol file for this lib
to not be generated.

Change-Id: Ib07ae8c40252813c488e2c1ac6204fd42816dd4c
(cherry picked from commit 54b027916a71f2b83b2050cef5ef704ea5de39b2)

2 years agoMerge "media: Add experimental support for RTCP feedback."
George Joseph [Fri, 27 Jan 2017 13:04:52 +0000 (07:04 -0600)]
Merge "media: Add experimental support for RTCP feedback."

2 years agoMerge "res_pjsip_endpoint_identifier_ip: Fix memory leak of hosts when resolving."
zuul [Fri, 27 Jan 2017 04:11:37 +0000 (22:11 -0600)]
Merge "res_pjsip_endpoint_identifier_ip: Fix memory leak of hosts when resolving."

2 years agomake_build_h: handle backslashes in external strings
kkm [Wed, 25 Jan 2017 01:51:07 +0000 (17:51 -0800)]
make_build_h: handle backslashes in external strings

LikewiseOpen creates user names with a backslash in them. A gentle
massage with sed(1) allows such strings to be inserted into build.h
properly quoted. I am also adding the same for host name and other
strings used in the script that are more or less user-controlled.

ASTERISK-26754

Change-Id: Iac5ef2b67a68ee58f35ddbf86bb818ba6eabecae

2 years agoapp_queue: Fix queues randomly disappearing on reload
kkm [Wed, 25 Jan 2017 04:31:38 +0000 (20:31 -0800)]
app_queue: Fix queues randomly disappearing on reload

With 500+ queues and a reload every minute, a random queue disappears
upon reload. The cause is mususe of the 'dead' flag. Namely, all queues
were marked dead up front, and then "resurrected" by dropping this flag
for those found in the configuration. But a queue marked dead can be
removed also when control leaves the app entry point on a PBX thread.

With this change, the queue is marked only not found, and at the end of
reload only the queues that are still not found are actually marked as
dead, so the dead flag is never reset, and set only on positively dead
queues.

ASTERISK-26755

Change-Id: I3a4537aec9eb8d8aeeaa0193407e3523feb004bf

2 years agoMerge "PJPROJECT logging: Fix detection of max supported log level."
zuul [Fri, 27 Jan 2017 00:46:22 +0000 (18:46 -0600)]
Merge "PJPROJECT logging: Fix detection of max supported log level."

2 years agoMerge "ari: Implement 'debug all' and request/response logging"
George Joseph [Thu, 26 Jan 2017 23:06:40 +0000 (17:06 -0600)]
Merge "ari: Implement 'debug all' and request/response logging"

2 years agoMerge "res_musiconhold.c: Fix format ref leak when parsing MOH config class."
George Joseph [Thu, 26 Jan 2017 22:05:07 +0000 (16:05 -0600)]
Merge "res_musiconhold.c: Fix format ref leak when parsing MOH config class."

2 years agoMerge "frame.c: Fix off-nominal format ref leaks."
George Joseph [Thu, 26 Jan 2017 22:03:49 +0000 (16:03 -0600)]
Merge "frame.c: Fix off-nominal format ref leaks."

2 years agoMerge "test_voicemail_api: order of params to VERIFY macros"
George Joseph [Thu, 26 Jan 2017 22:02:50 +0000 (16:02 -0600)]
Merge "test_voicemail_api: order of params to VERIFY macros"

2 years agoMerge "Add notes about embedded ast_frame structs holding a format ref."
zuul [Thu, 26 Jan 2017 19:18:35 +0000 (13:18 -0600)]
Merge "Add notes about embedded ast_frame structs holding a format ref."

2 years agores_pjsip_endpoint_identifier_ip: Fix memory leak of hosts when resolving.
Joshua Colp [Thu, 26 Jan 2017 13:57:59 +0000 (13:57 +0000)]
res_pjsip_endpoint_identifier_ip: Fix memory leak of hosts when resolving.

This change adds a missing unreference of the hostname when resolving and
also cleans up the iterator.

ASTERISK-26735

Change-Id: Ic012ebaf3d89e714eec340b7b0c5e63c66af857a

2 years agoMerge "T.140: Fix format ref and memory leaks."
George Joseph [Thu, 26 Jan 2017 16:23:14 +0000 (10:23 -0600)]
Merge "T.140: Fix format ref and memory leaks."

2 years agoMerge "main/app.c: Memory corruption from early format destruction."
Joshua Colp [Thu, 26 Jan 2017 14:42:50 +0000 (08:42 -0600)]
Merge "main/app.c: Memory corruption from early format destruction."

2 years agoMerge "app_queue: add RINGCANCELED log event on caller hang up"
zuul [Thu, 26 Jan 2017 01:14:12 +0000 (19:14 -0600)]
Merge "app_queue: add RINGCANCELED log event on caller hang up"

2 years agoAdd reload options to CLI/AMI stale object commands.
Mark Michelson [Wed, 25 Jan 2017 21:26:53 +0000 (15:26 -0600)]
Add reload options to CLI/AMI stale object commands.

Marking an object as stale in a memory cache is supposed to prime the
cache so that the next time the item is retrieved, the stale item is
deleted from the cache and a background task is run to re-populate the
cache with a fresh version of the object.

The problem is, there are some object types out there for which there is
no natural reason that they would be retrieved from the backend with any
regularity. Outbound PJSIP registrations are a good example of this. At
startup, they are read, and an object-specific state is created that
refers to the initially-retrieved object for all time.

Adding the "reload" option to the CLI/AMI commands gives the cache the
opportunity to manually re-retrieve the object from the backend, both
storing the new object in the cache and applying the new object's
configuration to the module that uses that object.

Change-Id: Ieb1fe7270ceed491f057ec5cbf0e097bde96c5c8

2 years agoMerge "astobj2.c: Add excessive ref count trap."
George Joseph [Wed, 25 Jan 2017 22:00:49 +0000 (16:00 -0600)]
Merge "astobj2.c: Add excessive ref count trap."

2 years agoT.140: Fix format ref and memory leaks.
Richard Mudgett [Tue, 10 Jan 2017 23:39:02 +0000 (17:39 -0600)]
T.140: Fix format ref and memory leaks.

* channel.c:ast_sendtext(): Fix T.140 SendText memory leak.

* format_compatibility.c: T.140 RED and T.140 were swapped.

* res_rtp_asterisk.c:rtp_red_init(): Fix ast_format_t140_red ref leak.

* res_rtp_asterisk.c:rtp_red_init(): Fix data race after starting periodic
scheduled red_write().

* res_rtp_asterisk.c: Some other minor misc tweaks.

Change-Id: Ifa27a2e0f8a966b1cf628607c86fc4374b0b88cb

2 years agoMerge "stasis_bridge.c: Fix off-nominal stasis control ref leak."
zuul [Wed, 25 Jan 2017 19:32:39 +0000 (13:32 -0600)]
Merge "stasis_bridge.c: Fix off-nominal stasis control ref leak."

2 years agoMerge "res_pjsip_endpoint_identifier_ip: Ensure error defaults to 0."
George Joseph [Wed, 25 Jan 2017 17:37:03 +0000 (11:37 -0600)]
Merge "res_pjsip_endpoint_identifier_ip: Ensure error defaults to 0."

2 years agoMerge "chan_oss.c: Fix format ref leak in oss_read()."
George Joseph [Wed, 25 Jan 2017 17:21:14 +0000 (11:21 -0600)]
Merge "chan_oss.c: Fix format ref leak in oss_read()."

2 years agoMerge "pjproject_bundled: Fix setting max log level"
George Joseph [Wed, 25 Jan 2017 04:29:54 +0000 (22:29 -0600)]
Merge "pjproject_bundled: Fix setting max log level"

2 years agoMerge "res_pjsip_pubsub.c: Implement "pjsip show subscriptions" commands."
George Joseph [Tue, 24 Jan 2017 21:47:34 +0000 (15:47 -0600)]
Merge "res_pjsip_pubsub.c: Implement "pjsip show subscriptions" commands."

2 years agores_pjsip_endpoint_identifier_ip: Ensure error defaults to 0.
Joshua Colp [Tue, 24 Jan 2017 21:39:39 +0000 (21:39 +0000)]
res_pjsip_endpoint_identifier_ip: Ensure error defaults to 0.

When configuring a match using a netmask the error variable was
not defaulting to 0. For some people this would cause the code
to think an error occurred when adding the match when in reality
it added perfectly fine.

ASTERISK-26693

Change-Id: I850c250813742bddde65c84e739093c9e01dfe56

2 years agoastobj2.c: Add excessive ref count trap.
Richard Mudgett [Tue, 10 Jan 2017 23:37:38 +0000 (17:37 -0600)]
astobj2.c: Add excessive ref count trap.

Change-Id: I32e6a589cf9009450e4ff7cb85c07c9d9ef7fe4a

2 years agomain/app.c: Memory corruption from early format destruction.
Richard Mudgett [Tue, 10 Jan 2017 19:11:20 +0000 (13:11 -0600)]
main/app.c: Memory corruption from early format destruction.

* make_silence() created a malloced silence slin frame without adding a
slin format ref.  When the frame is destroyed it will unref the slin
format that never had a ref added.  Memory corruption is expected to
follow.

* Simplified and fixed counting the number of samples in a frame list for
make_silence().

* Eliminated an unnecessary RAII_VAR associated with the make_silence()
frame.

Change-Id: I47de3f9b92635b7f8b4d72309444d6c0aee6f747

2 years agoframe.c: Fix off-nominal format ref leaks.
Richard Mudgett [Wed, 11 Jan 2017 20:59:24 +0000 (14:59 -0600)]
frame.c: Fix off-nominal format ref leaks.

* ast_frisolate() could leak frame format refs on allocation
failures.

* Similified code in ast_frisolate() and code used by
ast_frisolate().

Change-Id: I79566d4d36b3d7801bf0c8294fcd3e9a86a2ed6d

2 years agostasis_bridge.c: Fix off-nominal stasis control ref leak.
Richard Mudgett [Sat, 14 Jan 2017 01:08:53 +0000 (19:08 -0600)]
stasis_bridge.c: Fix off-nominal stasis control ref leak.

Change-Id: Ib17218343a6596832060180e19386da9df150ac8

2 years agores_musiconhold.c: Fix format ref leak when parsing MOH config class.
Richard Mudgett [Tue, 10 Jan 2017 18:30:57 +0000 (12:30 -0600)]
res_musiconhold.c: Fix format ref leak when parsing MOH config class.

Change-Id: Ica8e8e2ce7604c2c61ec55bef07dc675361d2ea5

2 years agochan_oss.c: Fix format ref leak in oss_read().
Richard Mudgett [Tue, 10 Jan 2017 20:03:24 +0000 (14:03 -0600)]
chan_oss.c: Fix format ref leak in oss_read().

Change-Id: I0a5d56c7dcf327d60f86a4c25a23571733709fd0

2 years agoAdd notes about embedded ast_frame structs holding a format ref.
Richard Mudgett [Tue, 10 Jan 2017 23:48:39 +0000 (17:48 -0600)]
Add notes about embedded ast_frame structs holding a format ref.

mod_format.h: Note ast_filestream.fr holds a format ref.

translate.h: Note ast_trans_pvt.f holds a format ref.

Change-Id: I86bda354d725207b41e08920355d7c31b2d7f749

2 years agoMerge "Free endpoint ACLs when destroying PJSIP endpoints."
Joshua Colp [Tue, 24 Jan 2017 18:44:26 +0000 (12:44 -0600)]
Merge "Free endpoint ACLs when destroying PJSIP endpoints."

2 years agoPJPROJECT logging: Fix detection of max supported log level.
Richard Mudgett [Sat, 21 Jan 2017 03:13:34 +0000 (21:13 -0600)]
PJPROJECT logging: Fix detection of max supported log level.

The mechanism used for detecting the maximum log level compiled into the
linked pjproject did not work.  The API call simply stores the requested
level into an integer and does no range checking.  Asterisk was assuming
that there was range checking and limited the new value to the allowable
range.  To get the actual maximum log level compiled into the linked
pjproject we need to get and save off the initial set log level from
pjproject.  This is the maximum log level supported.

* Get and save off the initial log level setting before altering it to the
desired level on startup.  This has to be done by a macro rather than
calling a core function to avoid incorrectly linking pjproject.

* Split the initial log level warning messages to warn if the linked
pjproject cannot support the requested startup level and if it is too low
to get the pjproject buildopts for "pjproject show buildopts".

* Adjust the CLI "pjproject set log level" to check the saved max log
level and to generate normal output messages instead of a warning message.

ASTERISK-26743 #close

Change-Id: I40aa76653e2a1dece66c3f8734594b4f0471cfb4

2 years agoMerge "res_pjsip_endpoint_identifier_ip: Read settings before resolving."
George Joseph [Tue, 24 Jan 2017 14:21:52 +0000 (08:21 -0600)]
Merge "res_pjsip_endpoint_identifier_ip: Read settings before resolving."

2 years agores_pjsip_pubsub.c: Implement "pjsip show subscriptions" commands.
Richard Mudgett [Thu, 5 Jan 2017 19:21:08 +0000 (13:21 -0600)]
res_pjsip_pubsub.c: Implement "pjsip show subscriptions" commands.

ASTERISK-23828 #close

Change-Id: Ifb8a3b61f447aedc58a8e6b36a810f7566018567

2 years agoFree endpoint ACLs when destroying PJSIP endpoints.
Mark Michelson [Mon, 23 Jan 2017 22:18:18 +0000 (16:18 -0600)]
Free endpoint ACLs when destroying PJSIP endpoints.

If endpoint ACLs were specified, they were not being freed
when endpoints were destroyed. On systems with realtime endpoints, this
could add up quickly since each DB lookup would allocate the ACL without
freeing it.

ASTERISK-26731 #close
Reported by Ustinov Artem

Change-Id: Ie1f8bf5b7a0de628c975beba01e69c56893331ad

2 years agoMerge "LISTFILTER: Remove outdated ERROR message."
George Joseph [Mon, 23 Jan 2017 21:02:09 +0000 (15:02 -0600)]
Merge "LISTFILTER: Remove outdated ERROR message."

2 years agoMerge "res_pjsip_pubsub.c: Fix incorrect message string wrapping."
zuul [Mon, 23 Jan 2017 20:07:49 +0000 (14:07 -0600)]
Merge "res_pjsip_pubsub.c: Fix incorrect message string wrapping."

2 years agoari: Implement 'debug all' and request/response logging
George Joseph [Thu, 19 Jan 2017 15:05:36 +0000 (08:05 -0700)]
ari: Implement 'debug all' and request/response logging

The 'ari set debug' command has been enhanced to accept 'all' as an
application name.  This allows dumping of all apps even if an app
hasn't registered yet.  To accomplish this, a new global_debug global
variable was added to res/stasis/app.c and new APIs were added to
set and query the value.

'ari set debug' now displays requests and responses as well as events.
This required refactoring the existing debug code.

* The implementation for 'ari set debug' was moved from stasis/cli.{c,h}
  to ari/cli.{c,h}, and stasis/cli.{c,h} were deleted.
* In order to print the body of incoming requests even if a request
  failed, the consumption of the body was moved from the ari stubs
  to ast_ari_callback in res_ari.c and the moustache templates were
  then regenerated.  The body is now passed to ast_ari_invoke and then
  on to the handlers.  This results in code savings since that template
  was inserted multiple times into all the stubs.

An additional change was made to the ao2_str_container implementation
to add partial key searching and a sort function.  The existing cli
code assumed it was already there when it wasn't so the tab completion
was never working.

Change-Id: Ief936f747ce47f1fb14035fbe61152cf766406bf
(cherry picked from commit 1d890874f39a5a81b20da44358143ed9b54ab0fe)

2 years agotest_voicemail_api: order of params to VERIFY macros
Tzafrir Cohen [Sat, 21 Jan 2017 05:41:53 +0000 (07:41 +0200)]
test_voicemail_api: order of params to VERIFY macros

Fix order of parameters in calls to VM_API_INT_VERIFY and
VM_API_STRING_VERIFY

ASTERISK-26739 #close

Change-Id: I30dc6b36893aadad6012be3f16f93aa5720870d6
Note: status: builds. Not tested any further.

2 years agoMerge "res_pjsip_pubsub.c: Fix AMI event list counts."
Joshua Colp [Mon, 23 Jan 2017 17:10:25 +0000 (11:10 -0600)]
Merge "res_pjsip_pubsub.c: Fix AMI event list counts."

2 years agopjproject_bundled: Fix setting max log level
George Joseph [Mon, 23 Jan 2017 15:10:50 +0000 (08:10 -0700)]
pjproject_bundled: Fix setting max log level

An earlier attempt to prevent pjsua from spitting out an extra 6795
lines of debug output every time the testsuite called it was also
turning off the ability for asterisk to output debug info when it
needed to.  This patch reverts the earlier fix and instead adds
a pjproject patch that sets the startup log level to 1 for pjsua
pjsystest and the pjsua python binding.  This is an asterisk-only
patch that does not affect pjproject functionality and will not be
submitted upstream.

Change-Id: I347a8b58b2626f2906ccfc1d339e907627a0c9e8

2 years agores_pjsip_endpoint_identifier_ip: Read settings before resolving.
Joshua Colp [Mon, 23 Jan 2017 16:08:37 +0000 (16:08 +0000)]
res_pjsip_endpoint_identifier_ip: Read settings before resolving.

An option has been added, srv_lookups, which controls whether
SRV lookups are performed on the provided match hosts or not.
It was possible for this option to be applied after resolution
had already happened.

This change makes it so hosts are stored away, settings are read
and applied, and then resolution is done. This ensures that no
matter the ordering the srv_lookups option is in effect.

ASTERISK-26735

Change-Id: I750378cb277be0140f8c5539450270afbfc43388

2 years agoMerge "res_pjsip_pubsub.c: Eliminate trivial SCOPED_LOCK usage."
zuul [Mon, 23 Jan 2017 16:04:50 +0000 (10:04 -0600)]
Merge "res_pjsip_pubsub.c: Eliminate trivial SCOPED_LOCK usage."

2 years agomedia: Add experimental support for RTCP feedback.
Lorenzo Miniero [Tue, 29 Nov 2016 15:31:21 +0000 (16:31 +0100)]
media: Add experimental support for RTCP feedback.

This change adds experimental support for providing RTCP
feedback information to codec modules so they can dynamically
change themselves based on conditions.

ASTERISK-26584

Change-Id: Ifd6aa77fb4a7ff546c6025900fc2baf332c31857

2 years agoMerge "res_pjsip: alloca can never fail."
Joshua Colp [Mon, 23 Jan 2017 11:53:23 +0000 (05:53 -0600)]
Merge "res_pjsip: alloca can never fail."

2 years agoLISTFILTER: Remove outdated ERROR message.
Richard Mudgett [Sun, 22 Jan 2017 23:25:57 +0000 (17:25 -0600)]
LISTFILTER: Remove outdated ERROR message.

Feeding LISTFILTER an empty variable results in an invalid ERROR message.
Earlier changes made the message useless because we can no longer tell if
the variable is empty or does not exist.  It is valid to try to remove a
value from an empty list just as it is valid to try to remove a value that
is not in a non-empty list.

* Removed the outdated ERROR message.

* Added more test cases to the LISTFILTER unit test.

Change-Id: Ided9040e6359c44a335ef54e02ef5950a1863134

2 years agotests: use datadir for sound files
Tzafrir Cohen [Sat, 21 Jan 2017 20:43:48 +0000 (22:43 +0200)]
tests: use datadir for sound files

Some (voicemail-related) tests API symlinks beep.gsm and other files
from ast_config_AST_VAR_DIR. It should use ast_config_AST_DATA_DIR.

ASTERISK-26740 #close

Change-Id: Id49c56fb9e16df64b1a2b829693ca7601252df89

2 years agoMerge "abstract/fixed/adpative jitter buffer: disallow frame re-inserts"
Joshua Colp [Fri, 20 Jan 2017 19:49:12 +0000 (13:49 -0600)]
Merge "abstract/fixed/adpative jitter buffer: disallow frame re-inserts"

2 years agoMerge "debug_utilities: Create ast_loggrabber"
zuul [Fri, 20 Jan 2017 19:45:33 +0000 (13:45 -0600)]
Merge "debug_utilities:  Create ast_loggrabber"

2 years agores_pjsip_pubsub.c: Fix AMI event list counts.
Richard Mudgett [Thu, 5 Jan 2017 21:11:12 +0000 (15:11 -0600)]
res_pjsip_pubsub.c: Fix AMI event list counts.

Fix the AMI PJSIPShowSubscriptionsInbound, PJSIPShowSubscriptionsOutbound,
and PJSIPShowResourceLists actions event counts.  The reported counts may
not necessarily be accurate depending on what happens.

The subscriptions count would be wrong if Asterisk ever has outbound
subscriptions.

The resource list count could be wrong if a list were added or removed
during the AMI action being processed.

Change-Id: I4344301827523fa174960a42c413fd19abe4aed5

2 years agores_pjsip_pubsub.c: Fix incorrect message string wrapping.
Richard Mudgett [Thu, 5 Jan 2017 19:02:06 +0000 (13:02 -0600)]
res_pjsip_pubsub.c: Fix incorrect message string wrapping.

Change-Id: Id771e6fe56d89ce365ddcbb423f820af97211120

2 years agores_pjsip_pubsub.c: Eliminate trivial SCOPED_LOCK usage.
Richard Mudgett [Thu, 5 Jan 2017 19:01:17 +0000 (13:01 -0600)]
res_pjsip_pubsub.c: Eliminate trivial SCOPED_LOCK usage.

Change-Id: Ie0b69a830385452042fa19e7d267c6790ec6b6be

2 years agores_pjsip: alloca can never fail.
Richard Mudgett [Thu, 5 Jan 2017 18:58:52 +0000 (12:58 -0600)]
res_pjsip: alloca can never fail.

Change-Id: Ia2a6158e5fdf311bc2a1c0c43417978de504b1f1

2 years agodebug_utilities: Create ast_loggrabber
George Joseph [Fri, 13 Jan 2017 17:03:15 +0000 (10:03 -0700)]
debug_utilities:  Create ast_loggrabber

ast_loggrabber gathers log files from customizable search patterns,
optionally converts POSIX timestamps to a readable format and
tarballs the results.

Also a few tweaks were made to ast_coredumper.

Change-Id: I8bfe1468ada24c1344ce4abab7b002a59a659495
(cherry picked from commit c70915287837704090d75f181525765de7a17221)

2 years agores_pjsip_outbound_authenticator_digest.c: Fix spacing in warning messages.
Richard Mudgett [Sun, 1 Jan 2017 09:47:50 +0000 (03:47 -0600)]
res_pjsip_outbound_authenticator_digest.c: Fix spacing in warning messages.

Change-Id: I573f0343c0c63a785cd4da60d57cc9f8b9ce7f49

2 years agoapp_queue: add RINGCANCELED log event on caller hang up
Martin Tomec [Thu, 22 Dec 2016 10:07:33 +0000 (11:07 +0100)]
app_queue: add RINGCANCELED log event on caller hang up

QueueLog did not log ringnoanswer when the caller abandoned call
before first timeout. It was impossible to get agent membername
and ringing duration for this short calls. After some discusions
it seems that the best way is to add new event RINGCANCELED,
which is generated after caller hangup during ringing.

ASTERISK-26665

Change-Id: Ic70f7b0f32fc95c9378e5bcf63865519014805d3

2 years agoMerge "res_calendar: delete old calendars after reload"
zuul [Wed, 18 Jan 2017 00:44:02 +0000 (18:44 -0600)]
Merge "res_calendar: delete old calendars after reload"

2 years agoMerge "app_queue: Add QueueUpdate application."
Joshua Colp [Tue, 17 Jan 2017 23:26:10 +0000 (17:26 -0600)]
Merge "app_queue: Add QueueUpdate application."

2 years agoabstract/fixed/adpative jitter buffer: disallow frame re-inserts
Kevin Harwell [Thu, 12 Jan 2017 21:58:43 +0000 (15:58 -0600)]
abstract/fixed/adpative jitter buffer: disallow frame re-inserts

It was possible for a frame to be re-inserted into a jitter buffer after it
had been removed from it. A case when this happened was if a frame was read
out of the jitterbuffer, passed to the translation core, and then multiple
frames were returned from said translation core. Upon multiple frames being
returned the first is passed on, but sebsequently "chained" frames are put
back into the read queue. Thus it was possible for a frame to go back into
the jitter buffer where this would cause problems.

This patch adds a flag to frames that are inserted into the channel's read
queue after translation. The abstract jitter buffer code then checks for this
flag and ignores any frames marked as such.

Change-Id: I276c44edc9dcff61e606242f71274265c7779587

2 years agoapp_queue: Add QueueUpdate application.
Sebastian Gutierrez [Sun, 6 Nov 2016 12:30:07 +0000 (09:30 -0300)]
app_queue: Add QueueUpdate application.

Add an application that allows tracking outbound calls
using app_queue.

ASTERISK-19862

Change-Id: Ia0ab64aed934c25b2a25022adcc7c0624224346e

2 years agotaskprocessor.c: Change when high water warning logged.
Richard Mudgett [Sat, 14 Jan 2017 03:23:49 +0000 (21:23 -0600)]
taskprocessor.c: Change when high water warning logged.

The task processor queue reached X scheduled tasks message was originally
intended to get logged only once per task processor to prevent spamming
the log.  This is no longer necessary since high and low water thresholds
can better control when the message is logged.

It is beneficial to generate the warning each time a task processor
reaches the high water level because PJSIP stops processing new requests
while any high water alert is active.  Without this change you would have
to enable at least debug level 3 logging to know about a repeated alert
trigger.

* Made generate the warning message whenever a task is pushed into the
task processor that triggers the high water alert.

* Appended 'again' to the warning for a repeated high water alert trigger.

Change-Id: Iabf75a004f7edaf1e5e8c323099418e667cac999

2 years agoMerge "res_rtp_asterisk: Fix bug in function CHANNEL(rtcp, all_rtt)"
Joshua Colp [Fri, 13 Jan 2017 01:55:28 +0000 (19:55 -0600)]
Merge "res_rtp_asterisk:  Fix bug in function CHANNEL(rtcp, all_rtt)"

2 years agores_rtp_asterisk: Fix bug in function CHANNEL(rtcp, all_rtt)
Aaron An [Tue, 10 Jan 2017 11:54:16 +0000 (19:54 +0800)]
res_rtp_asterisk:  Fix bug in function CHANNEL(rtcp, all_rtt)

Function CHANNEL(rtcp,all_rtt) CHANNEL(rtcp,all_loss) CHANNEL(rtcp,all_jitter)
always return 0.0 due to wrong define of macro "AST_RTP_SATA_SET" and
"AST_RTP_STAT_STRCPY".
It should compare "combined" with "stat" not "current_stat".

ASTERISK-26710 #close
Reported-by: Aaron An
Tested-by: AaronAn

Change-Id: Id4140fafbf92e2db689dac5b17d9caa009028a15