asterisk/asterisk.git
2 years agoheaders: Consistent use of typeof and/or __typeof__.
Alexander Traud [Sat, 27 Jan 2018 09:25:11 +0000 (10:25 +0100)]
headers: Consistent use of typeof and/or __typeof__.

Because of a copy-and-paste error, the Asterisk project was using __typeof
instead of typeof. It works because typeof, __typeof, and __typeof__ are
supported by GCC, but here the escaped variant was not intended. Therefore,
for consistence, we change this to typeof.

Change-Id: I2a962c3e596e882f691a19345445b14571a5f07c

2 years agoMerge "Add missing OPTIONAL_API and ARI dependences."
Jenkins2 [Fri, 26 Jan 2018 23:40:56 +0000 (17:40 -0600)]
Merge "Add missing OPTIONAL_API and ARI dependences."

2 years agoMerge "CHANGES: Add AMI action 'PJSIPShowContacts' note."
Jenkins2 [Thu, 25 Jan 2018 13:56:31 +0000 (07:56 -0600)]
Merge "CHANGES: Add AMI action 'PJSIPShowContacts' note."

2 years agoMerge "install_prereq: For PJProject, point users to configure script."
Jenkins2 [Thu, 25 Jan 2018 13:46:31 +0000 (07:46 -0600)]
Merge "install_prereq: For PJProject, point users to configure script."

2 years agoCHANGES: Add AMI action 'PJSIPShowContacts' note.
Richard Mudgett [Wed, 24 Jan 2018 16:30:19 +0000 (10:30 -0600)]
CHANGES: Add AMI action 'PJSIPShowContacts' note.

ASTERISK-27581

Change-Id: If6af275764741a11030f0a4fd324fa29b376d74e

2 years agoMerge "res_pjsip: Add AMI action 'PJSIPShowContacts'"
Jenkins2 [Wed, 24 Jan 2018 13:56:50 +0000 (07:56 -0600)]
Merge "res_pjsip: Add AMI action 'PJSIPShowContacts'"

2 years agoMerge "install_prereq: Support package manager DNF and yum option strict=1."
Jenkins2 [Wed, 24 Jan 2018 13:48:58 +0000 (07:48 -0600)]
Merge "install_prereq: Support package manager DNF and yum option strict=1."

2 years agoMerge "res_config_mysql: Avoid the header mysql_version.h."
Jenkins2 [Tue, 23 Jan 2018 18:23:43 +0000 (12:23 -0600)]
Merge "res_config_mysql: Avoid the header mysql_version.h."

2 years agoMerge "install_prereq: Update Debian/Ubuntu libraries."
Jenkins2 [Tue, 23 Jan 2018 15:58:52 +0000 (09:58 -0600)]
Merge "install_prereq: Update Debian/Ubuntu libraries."

2 years agores_pjsip: Add AMI action 'PJSIPShowContacts'
Sungtae Kim [Sun, 14 Jan 2018 18:33:15 +0000 (19:33 +0100)]
res_pjsip: Add AMI action 'PJSIPShowContacts'

Add an AMI action which provides information on all
configured Contacts.

ASTERISK-27581

Change-Id: I2eed42c74bbc725fad26b8b33b1a5b3161950c73

2 years agoMerge "chan_unistim: Fix hold function ability to lock/crash asterisk"
Jenkins2 [Mon, 22 Jan 2018 22:41:43 +0000 (16:41 -0600)]
Merge "chan_unistim: Fix hold function ability to lock/crash asterisk"

2 years agoMerge "loader: Add support for built-in modules."
Jenkins2 [Mon, 22 Jan 2018 22:35:09 +0000 (16:35 -0600)]
Merge "loader: Add support for built-in modules."

2 years agoMerge "loader: Rework load_resource_list."
Jenkins2 [Mon, 22 Jan 2018 22:31:29 +0000 (16:31 -0600)]
Merge "loader: Rework load_resource_list."

2 years agoAdd missing OPTIONAL_API and ARI dependences.
Corey Farrell [Thu, 18 Jan 2018 15:01:26 +0000 (10:01 -0500)]
Add missing OPTIONAL_API and ARI dependences.

I've audited all modules that include any header which includes
asterisk/optional_api.h.  All modules which use OPTIONAL_API now declare
those dependencies in AST_MODULE_INFO using requires or optional_modules
as appropriate.

In addition ARI dependency declarations have been reworked.  Instead of
declaring additional required modules in res/ari/resource_*.c we now add
them to an optional array "requiresModules" in api-docs for each module.
This allows the AST_MODULE_INFO dependencies to include those missing
modules.

Change-Id: Ia0c70571f5566784f63605e78e1ceccb4f79c606

2 years agoMerge "loader: Remove global symbol only startup phase."
Joshua Colp [Mon, 22 Jan 2018 16:33:18 +0000 (10:33 -0600)]
Merge "loader: Remove global symbol only startup phase."

2 years agoMerge "loader: Process module dependencies."
Jenkins2 [Mon, 22 Jan 2018 16:16:29 +0000 (10:16 -0600)]
Merge "loader: Process module dependencies."

2 years agoMerge "pbx: Reduce verbosity while loading extensions"
Jenkins2 [Mon, 22 Jan 2018 15:39:22 +0000 (09:39 -0600)]
Merge "pbx: Reduce verbosity while loading extensions"

2 years agores_config_mysql: Avoid the header mysql_version.h.
Alexander Traud [Mon, 22 Jan 2018 15:18:51 +0000 (16:18 +0100)]
res_config_mysql: Avoid the header mysql_version.h.

ASTERISK-27607

Change-Id: I23d00ded955c4afd5f2c3c9dc96dcb48b3f74eec

2 years agoMerge "BuildSystem: Allow make clean all again."
Jenkins2 [Mon, 22 Jan 2018 15:13:29 +0000 (09:13 -0600)]
Merge "BuildSystem: Allow make clean all again."

2 years agoinstall_prereq: For PJProject, point users to configure script.
Alexander Traud [Fri, 5 Jan 2018 20:46:51 +0000 (21:46 +0100)]
install_prereq: For PJProject, point users to configure script.

The installation script and the new configure option --with-pjproject-bundled
aimed to accomplish the same. However, the installation script was out of
date. Users should go for the maintained configure option, or the Wiki.

ASTERISK-24598

Change-Id: Icbf4b562f81f7c05bd24a3805bd46c0beb4ebd44

2 years agoMerge "BuildSystem: Remove orphaned .PHONY targets."
Jenkins2 [Mon, 22 Jan 2018 14:44:05 +0000 (08:44 -0600)]
Merge "BuildSystem: Remove orphaned .PHONY targets."

2 years agoMerge "res_pjsip: Document tlsv1_1 and tlsv1_2 methods"
Jenkins2 [Mon, 22 Jan 2018 14:35:13 +0000 (08:35 -0600)]
Merge "res_pjsip: Document tlsv1_1 and tlsv1_2 methods"

2 years agoBuildSystem: Remove AC_CONFIG_AUX_DIR.
Alexander Traud [Sat, 20 Jan 2018 18:58:35 +0000 (19:58 +0100)]
BuildSystem: Remove AC_CONFIG_AUX_DIR.

ASTERISK-27602

Change-Id: I9f4d3d2bc1481748e39ad1e2b0a364d38e38978b

2 years agoMerge "BuildSystem: Detect external library Lua in version 5.3."
Jenkins2 [Sat, 20 Jan 2018 07:24:24 +0000 (01:24 -0600)]
Merge "BuildSystem: Detect external library Lua in version 5.3."

2 years agoBuildSystem: Remove orphaned .PHONY targets.
Alexander Traud [Fri, 19 Jan 2018 18:21:19 +0000 (19:21 +0100)]
BuildSystem: Remove orphaned .PHONY targets.

Change-Id: Ic44d75141b9bf99e7d72fcc82ee111b5cf6989d2

2 years agoBuildSystem: Allow make clean all again.
Alexander Traud [Fri, 19 Jan 2018 18:14:53 +0000 (19:14 +0100)]
BuildSystem: Allow make clean all again.

ASTERISK-27600
Reported by: Hamid R. Hashmi

Change-Id: I683d14d024650be04074b037b6300464519409f4

2 years agoinstall_prereq: Update Debian/Ubuntu libraries.
Alexander Traud [Fri, 19 Jan 2018 12:16:36 +0000 (13:16 +0100)]
install_prereq: Update Debian/Ubuntu libraries.

ASTERISK-27555

Change-Id: Ieb41b0cbf968af12882b39454b819ebb48b9ea46

2 years agoinstall_prereq: Support package manager DNF and yum option strict=1.
Alexander Traud [Fri, 19 Jan 2018 10:46:21 +0000 (11:46 +0100)]
install_prereq: Support package manager DNF and yum option strict=1.

This re-enables the script ./contrib/scripts/install_prereq on Fedora 22 and
newer, and on RHEL/CentOS when the option strict=1 was set for yum install.

ASTERISK-27598
Reported by: Hunter Stevens, Said Masoud

Change-Id: I40f9517122aaa6906e8fc0962b4b8008dfddb368

2 years agopbx: Reduce verbosity while loading extensions
krells [Tue, 9 Jan 2018 17:29:48 +0000 (18:29 +0100)]
pbx: Reduce verbosity while loading extensions

Each time the dial plan is reloaded, a lot of logs like these are generated:
"Added extension 'XXXXX' priority 1 to YYYYYYYYYYY"
This patch changes the log level for those logs.

ASTERISK-27084

Change-Id: I5662902161c50890997ddc56835d4cafb456c529

2 years agoMerge "BuildSystem: Avoid $EUID and use id -u instead."
Jenkins2 [Fri, 19 Jan 2018 01:31:20 +0000 (19:31 -0600)]
Merge "BuildSystem: Avoid $EUID and use id -u instead."

2 years agoMerge "loader: Miscellaneous fixes."
Jenkins2 [Fri, 19 Jan 2018 01:18:01 +0000 (19:18 -0600)]
Merge "loader: Miscellaneous fixes."

2 years agoMerge "cel_odbc.c: Fix menuslect module description display."
Jenkins2 [Thu, 18 Jan 2018 21:55:17 +0000 (15:55 -0600)]
Merge "cel_odbc.c: Fix menuslect module description display."

2 years agores_pjsip: Document tlsv1_1 and tlsv1_2 methods
Sean Bright [Thu, 18 Jan 2018 20:55:20 +0000 (15:55 -0500)]
res_pjsip: Document tlsv1_1 and tlsv1_2 methods

Change-Id: I67ed9039bf3f132fb20ee7a750e0aef0f704d7d3

2 years agoMerge "BuildSystem: Use the detected name for MD5 everywhere."
Jenkins2 [Thu, 18 Jan 2018 16:17:49 +0000 (10:17 -0600)]
Merge "BuildSystem: Use the detected name for MD5 everywhere."

2 years agoMerge "BuildSystem: Invoke install not in GNU but POSIX style."
Jenkins2 [Thu, 18 Jan 2018 16:02:53 +0000 (10:02 -0600)]
Merge "BuildSystem: Invoke install not in GNU but POSIX style."

2 years agoMerge "BuildSystem: In OpenBSD, xmlstarlet is xml."
Jenkins2 [Thu, 18 Jan 2018 15:26:50 +0000 (09:26 -0600)]
Merge "BuildSystem: In OpenBSD, xmlstarlet is xml."

2 years agoMerge "app_followme: Add a prompt to be read when a call is connected"
Jenkins2 [Thu, 18 Jan 2018 15:16:38 +0000 (09:16 -0600)]
Merge "app_followme:  Add a prompt to be read when a call is connected"

2 years agochan_unistim: Fix hold function ability to lock/crash asterisk
Igor Goncharovsky [Tue, 9 Jan 2018 05:50:11 +0000 (08:50 +0300)]
chan_unistim: Fix hold function ability to lock/crash asterisk

This patch fix chan_unistim hold functions to correctly support
hold function in different states possible in case of multiple lines
established on the phone

ASTERISK-26596 #close

Change-Id: Ib1e04e482e7c8939607a42d7fddacc07e26e14d4

2 years agoloader: Add support for built-in modules.
Corey Farrell [Mon, 30 Oct 2017 03:00:52 +0000 (23:00 -0400)]
loader: Add support for built-in modules.

* Add SRC_EMBEDDED variable to main/Makefile.  Built-in module sources
  must be listed in this variable to ensure they get the correct CFLAGS.

Change-Id: I920852bc17513a9c2627061a4ad40511e3a20499

2 years agoloader: Rework load_resource_list.
Corey Farrell [Sat, 9 Dec 2017 06:03:15 +0000 (01:03 -0500)]
loader: Rework load_resource_list.

Use a single loop in a loop to scan the resource list attempting to
dlopen each module.  The inner loop is repeated until it doesn't do any
work, then it is run one more time to allow printing of error messages.

Change-Id: I60c15cd57ff9680b62e2a94c7519401fa4a38e45

2 years agoloader: Remove global symbol only startup phase.
Corey Farrell [Sat, 9 Dec 2017 05:30:43 +0000 (00:30 -0500)]
loader: Remove global symbol only startup phase.

Dependency loader is now in place so we no longer need a separate loader
phase for global symbols only.  This simplifies the loader and allows us
to minimize calls to dlopen.

Change-Id: I33e3174d67f3b4552d3d536326dcaf0ebabb097d

2 years agoloader: Process module dependencies.
Corey Farrell [Wed, 22 Nov 2017 05:39:33 +0000 (00:39 -0500)]
loader: Process module dependencies.

* Add string vectors for requires, optional_apis and enhances.
* Add reffed_deps module vector for holding references to dependencies.
* Initialize string vectors after final dlopen of each module.
* Free string vectors and clear references from reffed_deps in
  module_destroy.
* Create functions necessary to process module dependencies and enforce
  load order.

Module dependencies result in automatic references being managed by the
module loader.  This enforces unload order.

Change-Id: I9be08d1dd331aceadc1dcba00b804d71360b2fbb

2 years agoMerge "pjproject_bundled: Prevent crash on bad outgoing header"
Jenkins2 [Wed, 17 Jan 2018 18:33:20 +0000 (12:33 -0600)]
Merge "pjproject_bundled:  Prevent crash on bad outgoing header"

2 years agoapp_followme: Add a prompt to be read when a call is connected
ghjm [Wed, 27 Dec 2017 23:44:31 +0000 (18:44 -0500)]
app_followme:  Add a prompt to be read when a call is connected

This patch adds the ability to configure a prompt which will be read
to the "winner" who pressed 1 (or the configured value) and received
the call.

ASTERISK-24372 #close

Change-Id: I6ec1c6c883347f7d1e1f597189544993c8d65272

2 years agoMerge "res_pjsip: Split type=identify to IP address and SIP header matching priorities"
Jenkins2 [Wed, 17 Jan 2018 17:42:03 +0000 (11:42 -0600)]
Merge "res_pjsip: Split type=identify to IP address and SIP header matching priorities"

2 years agoloader: Miscellaneous fixes.
Corey Farrell [Wed, 17 Jan 2018 06:28:57 +0000 (01:28 -0500)]
loader: Miscellaneous fixes.

* Remove comment about lazy load.
* Improve message about module already being loaded and running.
* Handle allocation error in add_to_load_order.
* Dead code elimination from modules_shutdown.

Change-Id: I22261599c46d0f416e568910ec9502f45143197f

2 years agoBuildSystem: Use the detected name for MD5 everywhere.
Alexander Traud [Wed, 17 Jan 2018 14:36:14 +0000 (15:36 +0100)]
BuildSystem: Use the detected name for MD5 everywhere.

Affacted the (automatic) download script for external modules:
./build_tools/download_externals

ASTERISK-27596

Change-Id: If4c3176f7bf58df32fec6e02a659f1a78d57cf4b

2 years agoBuildSystem: Invoke install not in GNU but POSIX style.
Alexander Traud [Wed, 17 Jan 2018 13:11:24 +0000 (14:11 +0100)]
BuildSystem: Invoke install not in GNU but POSIX style.

ASTERISK-27594

Change-Id: Iaaa6a19d2fe031dffcba441d0502a7ea65c93cb3

2 years agoBuildSystem: In OpenBSD, xmlstarlet is xml.
Alexander Traud [Wed, 17 Jan 2018 12:47:45 +0000 (13:47 +0100)]
BuildSystem: In OpenBSD, xmlstarlet is xml.

ASTERISK-27593

Change-Id: I1c7087f7f7582e40b3312c690d912c9a86466805

2 years agoBuildSystem: Detect external library Lua in version 5.3.
Alexander Traud [Wed, 17 Jan 2018 08:51:29 +0000 (09:51 +0100)]
BuildSystem: Detect external library Lua in version 5.3.

On some platforms, you decide to go for one specific version of Lua, for
example in OpenBSD. On other platforms, you are able to install several versions
side-by-side, for example in Ubuntu and Fedora. Asterisk already works with
Lua 5.3. Asterisk failed to detect Lua 5.3 on those platforms which allow
several versions.

ASTERISK-27592

Change-Id: If7a4b395d844a464e9a1f4f626c5bff4ee67eed8

2 years agores_pjsip: Split type=identify to IP address and SIP header matching priorities
Richard Mudgett [Sat, 23 Dec 2017 01:50:34 +0000 (19:50 -0600)]
res_pjsip: Split type=identify to IP address and SIP header matching priorities

The type=identify endpoint identification method can match by IP address
and by SIP header.  However, the SIP header matching has limited
usefulness because you cannot specify the SIP header matching priority
relative to the IP address matching.  All the matching happens at the same
priority and the order of evaluating the identify sections is
indeterminate.  e.g., If you had two type=identify sections where one
matches by IP address for endpoint alice and the other matches by SIP
header for endpoint bob then you couldn't predict which endpoint is
matched when a request comes in that matches both.

* Extract the SIP header matching criteria into its own "header" endpoint
identification method so the user can specify the relative priority of the
SIP header and the IP address matching criteria in the global
endpoint_identifier_order option.  The "ip" endpoint identification method
now only matches by IP address.

ASTERISK-27491

Change-Id: I9df142a575b7e1e3471b7cda5d3ea156cef08095

2 years agotaskprocessor.c: Increase the number of tps_singletons container buckets.
Richard Mudgett [Tue, 16 Jan 2018 14:32:20 +0000 (08:32 -0600)]
taskprocessor.c: Increase the number of tps_singletons container buckets.

Since v12 the number of taskprocessors in the system has increased a lot.
Small systems can easily have over a hundred and larger systems can have
thousands.

Most uses of the tps_singletons container deal with creating and
destroying the taskprocessors.  However, the pjsip distributor looks up
taskprocessors/serializers by name frequently.  It needs to find the
serializer for incoming SIP responses to distribute them to the
appropriate serializer.

Change-Id: Ice0603606614ba49f7c0c316c524735c064e7e43

2 years agoMerge "BuildSystem: Resolve resolv.h not via Generic but Particular Header-Check."
Jenkins2 [Tue, 16 Jan 2018 15:52:45 +0000 (09:52 -0600)]
Merge "BuildSystem: Resolve resolv.h not via Generic but Particular Header-Check."

2 years agoMerge "res_stasis_recording: Allow symbolic links in configured recordings dir."
Jenkins2 [Tue, 16 Jan 2018 15:42:25 +0000 (09:42 -0600)]
Merge "res_stasis_recording: Allow symbolic links in configured recordings dir."

2 years agopjproject_bundled: Prevent crash on bad outgoing header
George Joseph [Tue, 16 Jan 2018 14:20:28 +0000 (07:20 -0700)]
pjproject_bundled:  Prevent crash on bad outgoing header

We still need to figure out how a bad header is getting into the
outgoing message but this patch to pjproject prevents attempting
to print that header and causing a crash.

For several users, this crash happens when sending 183 progress
messages.

ASTERISK-26832
Reported by: Ross Beer, Jan Rozhon

Change-Id: Ie5c5a921c890c843587763e7f33f987dfe66bd16

2 years agoBuildSystem: Avoid $EUID and use id -u instead.
Alexander Traud [Tue, 16 Jan 2018 12:34:23 +0000 (13:34 +0100)]
BuildSystem: Avoid $EUID and use id -u instead.

Makefile included a call to ${EUID} which requires the shell bash. To keep
compatibility with other shells like dash or ksh, use id -u instead.

ASTERISK-27589

Change-Id: Ia6e74f5bc9aab4e6dc62b7439f647b7964e6f657

2 years agocel_odbc.c: Fix menuslect module description display.
Richard Mudgett [Tue, 16 Jan 2018 00:03:07 +0000 (18:03 -0600)]
cel_odbc.c: Fix menuslect module description display.

Asterisk's makefile for menuselect has a very simple source file parsing
script that looks for AST_MODULE_INFO lines to extract the quoted string
as a module description.  If it does not find a quoted string it uses the
whole line as the description.

Change-Id: I80f13a63818e4e28d683639a94a4dfaea405c1d5

2 years agoloader: Add dependency fields to module structures.
Corey Farrell [Sun, 19 Nov 2017 22:30:49 +0000 (17:30 -0500)]
loader: Add dependency fields to module structures.

* Declare 'requires' and 'enhances' text fields on module info structure.
* Rename 'nonoptreq' to 'optional_modules'.
* Update doxygen comments.

Still need to investigate dependencies among modules I cannot compile.

Change-Id: I3ad9547a0a6442409ff4e352a6d897bef2cc04bf

2 years agovector: Additional string vector definitions.
Corey Farrell [Mon, 20 Nov 2017 02:10:09 +0000 (21:10 -0500)]
vector: Additional string vector definitions.

ast_vector_string_split:
This function will add items to an ast_vector_string by splitting values
of a string buffer.  Items are appended to the vector in the order they
are found.

ast_vector_const_string:
A vector of 'const char *'.

Change-Id: I1bf02a1efeb2baeea11c59c557d39dd1197494d7

2 years agoBuildSystem: Resolve resolv.h not via Generic but Particular Header-Check.
Alexander Traud [Mon, 15 Jan 2018 16:57:11 +0000 (17:57 +0100)]
BuildSystem: Resolve resolv.h not via Generic but Particular Header-Check.

ASTERISK-27585

Change-Id: I27c67563788e6f67eeda5fb51a741823a50a95e2

2 years agoMerge "config_transport: Enable TCP_NODELAY on TLS transports"
Jenkins2 [Mon, 15 Jan 2018 16:40:27 +0000 (10:40 -0600)]
Merge "config_transport:  Enable TCP_NODELAY on TLS transports"

2 years agoMerge "BuildSystem: Really do not pass unknown-warning options to the compiler."
Jenkins2 [Mon, 15 Jan 2018 13:24:06 +0000 (07:24 -0600)]
Merge "BuildSystem: Really do not pass unknown-warning options to the compiler."

2 years agoMerge "menuselect: Remove unused dev-mode option TRACE_FRAMES."
Jenkins2 [Mon, 15 Jan 2018 13:12:22 +0000 (07:12 -0600)]
Merge "menuselect: Remove unused dev-mode option TRACE_FRAMES."

2 years agoMerge "res_config_pgsql: Avoid typecasting an int to unsigned char."
Jenkins2 [Sun, 14 Jan 2018 15:04:19 +0000 (09:04 -0600)]
Merge "res_config_pgsql: Avoid typecasting an int to unsigned char."

2 years agoconfig_transport: Enable TCP_NODELAY on TLS transports
George Joseph [Sat, 13 Jan 2018 19:49:07 +0000 (12:49 -0700)]
config_transport:  Enable TCP_NODELAY on TLS transports

We did this for TCP transports already but I'm not sure why we
didn't do it for TLS transports.

ASTERISK_27474 #not_final_fix

Change-Id: I5b1ef4b882f7b859e718236686b7898751dbb262

2 years agores_stasis_recording: Allow symbolic links in configured recordings dir.
Corey Farrell [Sat, 13 Jan 2018 00:37:43 +0000 (19:37 -0500)]
res_stasis_recording: Allow symbolic links in configured recordings dir.

If any component of ast_config_AST_RECORDING_DIR is a symbolic link we
would incorrectly assume the ARI user was trying to escape the recording
path.  Create additional check to check the recording directory's
realpath, only deny access if both do not match.

This is needed by the testsuite when run by 'run-local'.

Change-Id: I9145e841865edadcb5f75cead3471ad06bbb56c0

2 years agoMerge "install_prereq: Update Debian/Ubuntu libraries."
Jenkins2 [Fri, 12 Jan 2018 18:20:24 +0000 (12:20 -0600)]
Merge "install_prereq: Update Debian/Ubuntu libraries."

2 years agomenuselect: Remove unused dev-mode option TRACE_FRAMES.
Corey Farrell [Fri, 12 Jan 2018 18:00:26 +0000 (13:00 -0500)]
menuselect: Remove unused dev-mode option TRACE_FRAMES.

ASTERISK-27575 #close

Change-Id: Ica3a522892afed7a96816a5ecf140e1671f46ad4

2 years agoMerge "chan_ooh323: Avoid typecasting an int to unsigned short."
Jenkins2 [Fri, 12 Jan 2018 17:24:13 +0000 (11:24 -0600)]
Merge "chan_ooh323: Avoid typecasting an int to unsigned short."

2 years agoMerge "app_osplookup.c: Avoid two format truncations."
Jenkins2 [Fri, 12 Jan 2018 16:36:23 +0000 (10:36 -0600)]
Merge "app_osplookup.c: Avoid two format truncations."

2 years agoMerge "cdr_syslog: Deprecate unmaintained module"
Jenkins2 [Fri, 12 Jan 2018 15:29:37 +0000 (09:29 -0600)]
Merge "cdr_syslog: Deprecate unmaintained module"

2 years agores_config_pgsql: Avoid typecasting an int to unsigned char.
Alexander Traud [Fri, 12 Jan 2018 09:50:32 +0000 (10:50 +0100)]
res_config_pgsql: Avoid typecasting an int to unsigned char.

clang 5.0 warned about this.

ASTERISK-27576

Change-Id: If41f400a51973c06cdb9b75462e535b616bfe385

2 years agoMerge "chan_sip: Check that an iostream exists before accessing."
Joshua Colp [Fri, 12 Jan 2018 14:45:08 +0000 (08:45 -0600)]
Merge "chan_sip: Check that an iostream exists before accessing."

2 years agoMerge "Ignore quilt .pc directory, used in deb packaging"
Jenkins2 [Fri, 12 Jan 2018 14:29:43 +0000 (08:29 -0600)]
Merge "Ignore quilt .pc directory, used in deb packaging"

2 years agoBuildSystem: Really do not pass unknown-warning options to the compiler.
Alexander Traud [Fri, 12 Jan 2018 09:17:04 +0000 (10:17 +0100)]
BuildSystem: Really do not pass unknown-warning options to the compiler.

When an older GCC version is called with a too new warning option, GCC exited
with an error and Asterisk was not built. Therefore, the configure script tests
the installed compiler whether it supports that warning option. If not, Asterisk
does not pass it to the installed compiler. However, some compilers (like clang)
do not exit (error) but give just a warning in such a case. Because the compiler
did not exit, Asterisk passed the unknown-warning option.

ASTERISK-27560

Change-Id: Ia9d148e689c173df4e91699113605dab2de36038

2 years agoapp_osplookup.c: Avoid two format truncations.
Alexander Traud [Fri, 12 Jan 2018 10:27:23 +0000 (11:27 +0100)]
app_osplookup.c: Avoid two format truncations.

GCC 7 warned about this.

ASTERISK-27578

Change-Id: I4a00458dbe9b575ef04338b6a7852272745e1552

2 years agochan_ooh323: Avoid typecasting an int to unsigned short.
Alexander Traud [Fri, 12 Jan 2018 10:03:38 +0000 (11:03 +0100)]
chan_ooh323: Avoid typecasting an int to unsigned short.

clang 5.0 warned about this.

ASTERISK-27577

Change-Id: I898fe4255023138a9e8b579fe4482fcf582f2b78

2 years agoinstall_prereq: Update Debian/Ubuntu libraries.
Alexander Traud [Fri, 5 Jan 2018 21:13:52 +0000 (22:13 +0100)]
install_prereq: Update Debian/Ubuntu libraries.

ASTERISK-27555

Change-Id: I0818b6e42631be1b69237e2b41d3415275693e53

2 years agoMerge "res_pjsip_endpoint_identifier_ip.c: Remove unnecessary requirement."
Jenkins2 [Thu, 11 Jan 2018 19:36:02 +0000 (13:36 -0600)]
Merge "res_pjsip_endpoint_identifier_ip.c: Remove unnecessary requirement."

2 years agochan_sip: Check that an iostream exists before accessing.
Joshua Colp [Thu, 11 Jan 2018 18:05:05 +0000 (13:05 -0500)]
chan_sip: Check that an iostream exists before accessing.

Before getting the file descriptor for an iostream check
that it is present.

ASTERISK-27534

Change-Id: Ie0aa1394007a37c30e337ea1176a6fb3a63bc99c

2 years agoMerge "stasis_message_router: Remove silly usage of RAII_VAR."
Jenkins2 [Thu, 11 Jan 2018 14:46:34 +0000 (08:46 -0600)]
Merge "stasis_message_router: Remove silly usage of RAII_VAR."

2 years agoMerge "res_pjsip.c: Update the endpoint identification documentation."
Jenkins2 [Thu, 11 Jan 2018 14:42:52 +0000 (08:42 -0600)]
Merge "res_pjsip.c: Update the endpoint identification documentation."

2 years agoIgnore quilt .pc directory, used in deb packaging
Tzafrir Cohen [Thu, 11 Jan 2018 14:09:04 +0000 (16:09 +0200)]
Ignore quilt .pc directory, used in deb packaging

Debian packaging uses quilt to manage patches. Book-keeping for them is
done using quilt (either directly, or in a compatible format), and
tracked in the directory .pc .

Change-Id: I22c90f3d7ab8918e6216e7b686de6fa0e1fdaa7b
Signed-off-by: Tzafrir Cohen <tzafrir.cohen@xorcom.com>

2 years agoMerge "stasis_endpoints: Remove silly usage of RAII_VAR."
Jenkins2 [Thu, 11 Jan 2018 13:58:08 +0000 (07:58 -0600)]
Merge "stasis_endpoints: Remove silly usage of RAII_VAR."

2 years agoMerge "stasis_system: Remove silly usage of RAII_VAR."
Jenkins2 [Thu, 11 Jan 2018 13:25:51 +0000 (07:25 -0600)]
Merge "stasis_system: Remove silly usage of RAII_VAR."

2 years agoMerge "stasis: Remove silly usage of RAII_VAR."
Jenkins2 [Thu, 11 Jan 2018 12:58:10 +0000 (06:58 -0600)]
Merge "stasis: Remove silly usage of RAII_VAR."

2 years agoMerge "stasis_bridges: Remove silly usage of RAII_VAR."
Jenkins2 [Thu, 11 Jan 2018 12:43:33 +0000 (06:43 -0600)]
Merge "stasis_bridges: Remove silly usage of RAII_VAR."

2 years agoMerge "stasis_cache: Remove silly usage of RAII_VAR."
Jenkins2 [Thu, 11 Jan 2018 12:16:07 +0000 (06:16 -0600)]
Merge "stasis_cache: Remove silly usage of RAII_VAR."

2 years agoMerge "stasis_cache_pattern: Remove silly usage of RAII_VAR."
Jenkins2 [Thu, 11 Jan 2018 11:48:52 +0000 (05:48 -0600)]
Merge "stasis_cache_pattern: Remove silly usage of RAII_VAR."

2 years agoMerge "res_pjsip.c: Fix ident_to_str() and refactor ident_handler()."
Joshua Colp [Thu, 11 Jan 2018 10:55:21 +0000 (04:55 -0600)]
Merge "res_pjsip.c: Fix ident_to_str() and refactor ident_handler()."

2 years agostasis: Remove silly usage of RAII_VAR.
Corey Farrell [Tue, 9 Jan 2018 17:23:00 +0000 (12:23 -0500)]
stasis: Remove silly usage of RAII_VAR.

Change-Id: Ib11193531e797bcb16bba560a408eab155f706d1

2 years agostasis_cache_pattern: Remove silly usage of RAII_VAR.
Corey Farrell [Tue, 9 Jan 2018 17:09:08 +0000 (12:09 -0500)]
stasis_cache_pattern: Remove silly usage of RAII_VAR.

Change-Id: Ic98a51f555062cd863b6db3f8d76065943a9dea3

2 years agoMerge "app_confbridge: Fix NULL check in action_kick_last."
Joshua Colp [Wed, 10 Jan 2018 15:08:27 +0000 (09:08 -0600)]
Merge "app_confbridge: Fix NULL check in action_kick_last."

2 years agoMerge "bridge_softmix: Fix sfu_append_source_streams test."
Joshua Colp [Wed, 10 Jan 2018 14:19:56 +0000 (08:19 -0600)]
Merge "bridge_softmix: Fix sfu_append_source_streams test."

2 years agocdr_syslog: Deprecate unmaintained module
Sean Bright [Tue, 9 Jan 2018 22:23:54 +0000 (17:23 -0500)]
cdr_syslog: Deprecate unmaintained module

There has been an open issue against cdr_syslog (ASTERISK~14441) about
a race condition for 7.5 years that has never been addressed. Because
this module is effectively unmaintained and currently broken, there is
no sense in keeping it around.

If logging CDRs to syslog is a desirable feature, it would probably be
better to write the logs directly to the syslog server via socket
instead of using the facilities provided by openlog/syslog/closelog.
Doing so would address the race condition referenced in the associated
issue.

Change-Id: Ic77b94cd97f355a9cf5b1d3f3444964a6e0ba5dc

2 years agoMerge "res_pjsip_endpoint_identifier_ip.c: Allow multiple IdentifyDetail AMI events."
Joshua Colp [Wed, 10 Jan 2018 13:16:14 +0000 (07:16 -0600)]
Merge "res_pjsip_endpoint_identifier_ip.c: Allow multiple IdentifyDetail AMI events."

2 years agoMerge "res_pjsip: Add AMI action 'PJSIPShowAuths'"
Joshua Colp [Wed, 10 Jan 2018 12:55:29 +0000 (06:55 -0600)]
Merge "res_pjsip: Add AMI action 'PJSIPShowAuths'"

2 years agoMerge "res_stasis: Reduce RAII_VAR usage."
Joshua Colp [Wed, 10 Jan 2018 12:54:40 +0000 (06:54 -0600)]
Merge "res_stasis: Reduce RAII_VAR usage."

2 years agostasis_bridges: Remove silly usage of RAII_VAR.
Corey Farrell [Tue, 9 Jan 2018 17:16:58 +0000 (12:16 -0500)]
stasis_bridges: Remove silly usage of RAII_VAR.

Change-Id: I0fa7ab05454f183dc4ff10e26d18776d2b0fcf1f

2 years agostasis_cache: Remove silly usage of RAII_VAR.
Corey Farrell [Tue, 9 Jan 2018 17:10:27 +0000 (12:10 -0500)]
stasis_cache: Remove silly usage of RAII_VAR.

Change-Id: Ifa95e5801c949df296c7e4376347730fb0ed52ef