asterisk/asterisk.git
13 years agoMerged revisions 77424,77429 via svnmerge from
Kevin P. Fleming [Thu, 26 Jul 2007 22:17:25 +0000 (22:17 +0000)]
Merged revisions 77424,77429 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r77424 | kpfleming | 2007-07-26 17:14:21 -0500 (Thu, 26 Jul 2007) | 2 lines

use new canonical name for download server

........
r77429 | kpfleming | 2007-07-26 17:16:42 -0500 (Thu, 26 Jul 2007) | 2 lines

change protocol for downloads as well

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77432 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerged revisions 77410 via svnmerge from
Russell Bryant [Thu, 26 Jul 2007 21:24:42 +0000 (21:24 +0000)]
Merged revisions 77410 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r77410 | russell | 2007-07-26 16:23:23 -0500 (Thu, 26 Jul 2007) | 10 lines

AST_DEVMODE was defined in trunk, but not in 1.4.  When Asterisk is compiled
under dev mode, AST_DEVMODE will get defined in buildopts.h.  Change 1.4 to
define it in the same way that trunk does.  Also, revert the change that added
this define in the Makefile

The advantage to doing it this way is that buildopts.h gets installed when
you install Asterisk.  Then, when building any out of tree modules, or
building asterisk-addons, these modules know which options the rest of Asterisk
was built with.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77411 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerged revisions 77380 via svnmerge from
Mark Michelson [Thu, 26 Jul 2007 20:39:46 +0000 (20:39 +0000)]
Merged revisions 77380 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r77380 | mmichelson | 2007-07-26 15:35:17 -0500 (Thu, 26 Jul 2007) | 7 lines

Fixes to get ast_backtrace working properly. The AST_DEVMODE macro was never defined so the majority of ast_backtrace never
attempted compilation. The makefile now defines AST_DEVMODE if configure was run with --enable-dev-mode. Also, changes were
made to acccomodate 64 bit systems in ast_backtrace.

Thanks to qwell, kpfleming, and Corydon76 for their roles in allowing me to get this committed

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77381 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerged revisions 77350 via svnmerge from
Tilghman Lesher [Thu, 26 Jul 2007 19:33:47 +0000 (19:33 +0000)]
Merged revisions 77350 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r77350 | tilghman | 2007-07-26 14:32:17 -0500 (Thu, 26 Jul 2007) | 2 lines

Missed one

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77351 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerged revisions 77348 via svnmerge from
Tilghman Lesher [Thu, 26 Jul 2007 19:29:12 +0000 (19:29 +0000)]
Merged revisions 77348 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r77348 | tilghman | 2007-07-26 14:27:18 -0500 (Thu, 26 Jul 2007) | 2 lines

Oops, that builtin define should be all-lowercase.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77349 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerged revisions 77318 via svnmerge from
Mark Michelson [Thu, 26 Jul 2007 18:31:28 +0000 (18:31 +0000)]
Merged revisions 77318 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r77318 | mmichelson | 2007-07-26 13:30:29 -0500 (Thu, 26 Jul 2007) | 8 lines

Two consecutive calls to PQfinish could occur, meaning free gets called on the same variable twice.
This patch sets the connection to NULL after calls to PQfinish so that the problem does not occur.
Also in this patch, prashant_jois informed me that it is safe to pass a null pointer to PQfinish, so
I have removed the check for conn's existence from my_unload_module.

(closes issue 10295, reported by junky, patched by me with input from prashant_jois)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77319 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoDo a massive conversion for using the ast_verb() macro
Russell Bryant [Thu, 26 Jul 2007 15:49:18 +0000 (15:49 +0000)]
Do a massive conversion for using the ast_verb() macro
(closes issue #10277, patches by mvanbaak)

Basically, this changes ...

if (option_verbose > 2)
   ast_verbose(VERBOSE_PREFIX_3, "Something\n");

to ...

ast_verb(3, "Something\n");

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77299 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerge a big batch of documentation fixes for escaping, marking URLs, places
Russell Bryant [Thu, 26 Jul 2007 14:49:51 +0000 (14:49 +0000)]
Merge a big batch of documentation fixes for escaping, marking URLs, places
where verbatim text went off the end of the page on the PDF, and various
other improvements
(closes issue #10307, IgorG)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77284 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoRevert some changes to call abs() on the result of ast_random().
Russell Bryant [Thu, 26 Jul 2007 13:26:44 +0000 (13:26 +0000)]
Revert some changes to call abs() on the result of ast_random().
 * random() is defined to return a positive result, and now ast_random()
   will always do so as well

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77269 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoEnsure that the read from /dev/urandom returns a positive result
Russell Bryant [Thu, 26 Jul 2007 13:20:36 +0000 (13:20 +0000)]
Ensure that the read from /dev/urandom returns a positive result
(closes issue #10308, reported by yehavi, patched by me)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77268 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoThings expecting a positive result from ast_random() should not be surprised (closes...
Tilghman Lesher [Thu, 26 Jul 2007 13:19:07 +0000 (13:19 +0000)]
Things expecting a positive result from ast_random() should not be surprised (closes #10308)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77267 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoAdd a link to the list of assigned RTP payload types for convenience.
Russell Bryant [Thu, 26 Jul 2007 13:10:49 +0000 (13:10 +0000)]
Add a link to the list of assigned RTP payload types for convenience.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77266 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agodocument how the RTP marker bit is passed for video frames,
Luigi Rizzo [Thu, 26 Jul 2007 05:35:42 +0000 (05:35 +0000)]
document how the RTP marker bit is passed for video frames,
and why this does not overwrite useful information.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77248 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoadd an entry for h263plus in an empty slot of the rtp types.
Luigi Rizzo [Thu, 26 Jul 2007 04:47:54 +0000 (04:47 +0000)]
add an entry for h263plus in an empty slot of the rtp types.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77233 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoThe upgrade of application argument separators to comma has an effect on AEL; I comme...
Steve Murphy [Thu, 26 Jul 2007 01:33:55 +0000 (01:33 +0000)]
The upgrade of application argument separators to comma has an effect on AEL; I commented out the code that substitutes commas with vertbars, so we can get apps to parse their args correctly.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77218 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerged revisions 77191 via svnmerge from
Steve Murphy [Thu, 26 Jul 2007 01:13:07 +0000 (01:13 +0000)]
Merged revisions 77191 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r77191 | murf | 2007-07-25 16:39:27 -0600 (Wed, 25 Jul 2007) | 1 line

This fix solves problem with intense squelch noise when someone joins conf in bug 9430; We repro'd the problem with meetme opts of 'CciMo'; Josh Colp supplied this patch, and I'm applying it. It looks like playing the recorded username will louse up the next thing played into the channel. Josh rearranged the code so as to start things over before playing data directly into the conference.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77217 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerged revisions 77176 via svnmerge from
Joshua Colp [Wed, 25 Jul 2007 22:18:56 +0000 (22:18 +0000)]
Merged revisions 77176 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r77176 | file | 2007-07-25 19:16:10 -0300 (Wed, 25 Jul 2007) | 4 lines

(closes issue #10303)
Reported by: jtodd
Add SPEECH_DTMF_TERMINATOR variable so the user can specify the digit to terminate a DTMF string with. If none is specified then no terminator will be used.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77182 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agosilence a warning in ast-devmode on a potentially uninitialized var.
Luigi Rizzo [Wed, 25 Jul 2007 21:58:13 +0000 (21:58 +0000)]
silence a warning in ast-devmode on a potentially uninitialized var.
At first sight (but the function is very large so i am not 100% sure)
the code seems correct, so maybe my compiler is just not smart
enough to figure that out at the optimization level it has.

Not worthwhile merging to 1.4 i believe.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77156 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerged revisions 77154 via svnmerge from
Mark Michelson [Wed, 25 Jul 2007 21:53:35 +0000 (21:53 +0000)]
Merged revisions 77154 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r77154 | mmichelson | 2007-07-25 16:52:47 -0500 (Wed, 25 Jul 2007) | 3 lines

chan->emulate_dtmf_duration is an unsigned int, not a signed int, so use %u instead of %d in the format string

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77155 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerged revisions 77071 via svnmerge from
Joshua Colp [Wed, 25 Jul 2007 17:16:11 +0000 (17:16 +0000)]
Merged revisions 77071 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r77071 | file | 2007-07-25 14:14:14 -0300 (Wed, 25 Jul 2007) | 2 lines

Fix autoconf logic for finding OpenH323 when it is not in the first place searched (/usr/share/openh323).

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77072 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agochange the debug level to 3 for an exceedingly annoying message
Luigi Rizzo [Wed, 25 Jul 2007 14:13:17 +0000 (14:13 +0000)]
change the debug level to 3 for an exceedingly annoying message
(3-deep nested loop)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77054 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerged revisions 77022 via svnmerge from
Luigi Rizzo [Wed, 25 Jul 2007 09:45:15 +0000 (09:45 +0000)]
Merged revisions 77022 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r77022 | rizzo | 2007-07-25 11:34:01 +0200 (Wed, 25 Jul 2007) | 3 lines

set the sequence number in a frame for all frame types

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@77023 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoremove a couple of entries that got duplicated and snuck into the SIP section. Also...
Russell Bryant [Wed, 25 Jul 2007 01:06:02 +0000 (01:06 +0000)]
remove a couple of entries that got duplicated and snuck into the SIP section.  Also, align the NAT/STUN entry with the others.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76985 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerged revisions 76983 via svnmerge from
Steve Murphy [Wed, 25 Jul 2007 00:34:42 +0000 (00:34 +0000)]
Merged revisions 76983 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
r76983 | murf | 2007-07-24 18:18:32 -0600 (Tue, 24 Jul 2007) | 9 lines

Merged revisions 76978 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r76978 | murf | 2007-07-24 18:07:24 -0600 (Tue, 24 Jul 2007) | 1 line

this fixes bug 10293, where the error message because defaultzone or loadzone was not defined was confusing
........

................

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76984 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerged revisions 76937 via svnmerge from
Tilghman Lesher [Tue, 24 Jul 2007 22:13:37 +0000 (22:13 +0000)]
Merged revisions 76937 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
r76937 | tilghman | 2007-07-24 17:12:43 -0500 (Tue, 24 Jul 2007) | 10 lines

Merged revisions 76934 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r76934 | tilghman | 2007-07-24 17:11:33 -0500 (Tue, 24 Jul 2007) | 2 lines

Oops, res contains the error code, not errno.  I was wondering why a mutex was reporting "No such file or directory"...

........

................

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76940 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoAdd the flag to trigger an intentional crash on mutex errors
Tilghman Lesher [Tue, 24 Jul 2007 21:37:11 +0000 (21:37 +0000)]
Add the flag to trigger an intentional crash on mutex errors

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76925 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoBlocked revisions 76891 via svnmerge
Tilghman Lesher [Tue, 24 Jul 2007 20:45:32 +0000 (20:45 +0000)]
Blocked revisions 76891 via svnmerge

........
r76891 | tilghman | 2007-07-24 15:42:05 -0500 (Tue, 24 Jul 2007) | 2 lines

Found another place where we should be using the umask (thanks jcmoore)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76892 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoFix escaping and some of the formattting (closes issue #10285)
Tilghman Lesher [Tue, 24 Jul 2007 18:19:18 +0000 (18:19 +0000)]
Fix escaping and some of the formattting (closes issue #10285)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76874 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoRevert trivial whitespace change (for testing)
Jason Parker [Tue, 24 Jul 2007 17:43:36 +0000 (17:43 +0000)]
Revert trivial whitespace change (for testing)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76852 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoTrivial whitespace change to test comitting...
Jason Parker [Tue, 24 Jul 2007 17:23:16 +0000 (17:23 +0000)]
Trivial whitespace change to test comitting...

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76841 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerged revisions 76803 via svnmerge from
Tilghman Lesher [Tue, 24 Jul 2007 17:05:10 +0000 (17:05 +0000)]
Merged revisions 76803 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r76803 | qwell | 2007-07-24 11:32:20 -0500 (Tue, 24 Jul 2007) | 3 lines

Don't create the Asterisk channel until we are starting the PBX on it.
(ASA-2007-018)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76807 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerged revisions 76801 via svnmerge from
Mark Michelson [Tue, 24 Jul 2007 16:42:36 +0000 (16:42 +0000)]
Merged revisions 76801 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r76801 | mmichelson | 2007-07-24 11:26:58 -0500 (Tue, 24 Jul 2007) | 13 lines

Added a membercount variable to call_queue struct which keeps track of the number of logged in members in a particular queue.
This makes it so that the 'n' option for Queue() can act properly depending on which strategy is used. If the strategy is
roundrobin, rrmemory, or ringall, we want to ring each phone once before moving on in the dialplan. However, if any other strategy is
used, we will only ring one phone since it cannot be guaranteed that a different phone will ring on subsequent attempts to ring a phone.

As a side effect of this, the QUEUE_MEMBER_COUNT dialplan function now just reads the membercount variable instead of traversing through
the member list to figure out how many members there are.

Special thanks to blitzrage for helping to test this out.

(closes issue #10127, reported by bcnit, patched by me, tested by blitzrage)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76804 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoDon't download/install the sound packages if already installed.
Joshua Colp [Tue, 24 Jul 2007 16:09:20 +0000 (16:09 +0000)]
Don't download/install the sound packages if already installed.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76791 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoThe chan_skinny Dial() syntax was funky. You had to do Dial(Skinny/line@device)
Jason Parker [Tue, 24 Jul 2007 15:35:58 +0000 (15:35 +0000)]
The chan_skinny Dial() syntax was funky.  You had to do Dial(Skinny/line@device)
This allows you to just Dial(Skinny/line), as long as line isn't ambiguous.

Note that this does not remove or deprecate the "old" syntax, as it's still
 quite useful - even moreso if shared lines get implemented.

Initial patch by me, with some changes and suggestions from wedhorn.
(closes issue #10263)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76785 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agotwo small fixes when using stun (reported by Marta Carbone):
Luigi Rizzo [Tue, 24 Jul 2007 14:49:49 +0000 (14:49 +0000)]
two small fixes when using stun (reported by Marta Carbone):
+ externexpire was not initialized properly;
+ stunaddr was not handled properly on a sip reload

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76770 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoadd documentation on nat/stun support in chan_sip
Luigi Rizzo [Tue, 24 Jul 2007 07:51:14 +0000 (07:51 +0000)]
add documentation on nat/stun support in chan_sip

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76755 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMove manager users list over to an rwlist.
Joshua Colp [Tue, 24 Jul 2007 02:59:49 +0000 (02:59 +0000)]
Move manager users list over to an rwlist.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76712 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoYou need to put static in front of a static RWLIST declaration to make it really...
Joshua Colp [Mon, 23 Jul 2007 23:14:20 +0000 (23:14 +0000)]
You need to put static in front of a static RWLIST declaration to make it really static... and don't call AST_RWLIST_HEAD_DESTROY on a statically declared list.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76711 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoDon't bother calling AST_RWLIST_EMPTY on a list before AST_RWLIST_TRAVERSE, it's...
Joshua Colp [Mon, 23 Jul 2007 23:05:18 +0000 (23:05 +0000)]
Don't bother calling AST_RWLIST_EMPTY on a list before AST_RWLIST_TRAVERSE, it's just a double check.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76710 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerged revisions 76708 via svnmerge from
Tilghman Lesher [Mon, 23 Jul 2007 22:41:27 +0000 (22:41 +0000)]
Merged revisions 76708 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r76708 | tilghman | 2007-07-23 17:38:06 -0500 (Mon, 23 Jul 2007) | 4 lines

It was our stated intention for 1.4 that files created in app_voicemail should
depend upon the umask.  Unfortunately, mkstemp() creates files with mode 0600,
regardless of the umask.  This corrects that deficiency.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76709 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoEnhance AGI with several fixes:
Tilghman Lesher [Mon, 23 Jul 2007 22:02:05 +0000 (22:02 +0000)]
Enhance AGI with several fixes:
 - Makes the structures handling external AGI commands a bit more thread-safe
 - Makes AGI transparently work with both live and hungup channels
 - DeadAGI is hence no longer necessary and is deprecated
 - CLI bug fixes
 - Commands will refuse to run if the channel is dead and the command is nonsensical
   for dead channels.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76707 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoClean up res_crypto module. It now uses an rwlist to keep the keys and it should...
Joshua Colp [Mon, 23 Jul 2007 21:42:43 +0000 (21:42 +0000)]
Clean up res_crypto module. It now uses an rwlist to keep the keys and it should also be thread safe now.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76706 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMissed one conversion to comma delimiter (thanks, Juggie) and add documentation on the
Tilghman Lesher [Mon, 23 Jul 2007 20:27:26 +0000 (20:27 +0000)]
Missed one conversion to comma delimiter (thanks, Juggie) and add documentation on the
change to the Local channel name.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76704 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerge the dialplan_aesthetics branch. Most of this patch simply converts applications
Tilghman Lesher [Mon, 23 Jul 2007 19:51:41 +0000 (19:51 +0000)]
Merge the dialplan_aesthetics branch.  Most of this patch simply converts applications
using old methods of parsing arguments to using the standard macros.  However, the big
change is that the really old way of specifying application and arguments separated by
a comma will no longer work (e.g. NoOp,foo|bar).  Instead, the way that has been
recommended since long before 1.0 will become the only method available (e.g. NoOp(foo,bar).

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76703 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerged revisions 76656 via svnmerge from
Jason Parker [Mon, 23 Jul 2007 19:00:19 +0000 (19:00 +0000)]
Merged revisions 76656 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r76656 | qwell | 2007-07-23 13:59:28 -0500 (Mon, 23 Jul 2007) | 3 lines

Fix some incorrect softkey labels in messages.
Don't try to play dialtone in some unimplemented features.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76657 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerged revisions 76654 via svnmerge from
Joshua Colp [Mon, 23 Jul 2007 18:31:06 +0000 (18:31 +0000)]
Merged revisions 76654 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
r76654 | file | 2007-07-23 15:29:48 -0300 (Mon, 23 Jul 2007) | 12 lines

Merged revisions 76653 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r76653 | file | 2007-07-23 15:28:13 -0300 (Mon, 23 Jul 2007) | 4 lines

(closes issue #5866)
Reported by: tyler
Do not force channel format changes when a generator is present. The generator may have changed the formats itself and changing them back would cause issues.

........

................

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76655 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerged revisions 76620 via svnmerge from
Jason Parker [Mon, 23 Jul 2007 17:58:46 +0000 (17:58 +0000)]
Merged revisions 76620 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

(closes issue #10276)
........
r76620 | qwell | 2007-07-23 12:57:53 -0500 (Mon, 23 Jul 2007) | 4 lines

Don't try to queue up hold/unhold frames on a non-existent channel.

Issue 10276.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76621 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerged revisions 76618 via svnmerge from
Joshua Colp [Mon, 23 Jul 2007 17:49:45 +0000 (17:49 +0000)]
Merged revisions 76618 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r76618 | file | 2007-07-23 14:48:51 -0300 (Mon, 23 Jul 2007) | 2 lines

Allow app_morsecode to build on PPC Linux by putting the value of the digit char in an int.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76619 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoadd two missing entries in the replica of the sip_tech that
Luigi Rizzo [Mon, 23 Jul 2007 14:45:22 +0000 (14:45 +0000)]
add two missing entries in the replica of the sip_tech that
does not use  DTMF BEGIN frames.

1.4 seems correct (it does not have the two fields).

However, as this bug shows, the current way of creating the sip_tech
replica is too error-prone, one can easily forget to update one of
the two entries.  Perhaps it would be better to create sip_tech_info
expliclty at module load, by doing

sip_tech_info = sip_tech;
sip_tech_info.send_digit_begin = NULL

(in this case, this is something applicable to 1.4 as well).

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76564 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerged revisions 76561 via svnmerge from
Joshua Colp [Mon, 23 Jul 2007 14:38:35 +0000 (14:38 +0000)]
Merged revisions 76561 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
r76561 | file | 2007-07-23 11:34:21 -0300 (Mon, 23 Jul 2007) | 14 lines

Merged revisions 76560 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r76560 | file | 2007-07-23 11:32:07 -0300 (Mon, 23 Jul 2007) | 6 lines

(closes issue #10236)
Reported by: homesick
Patches:
      rpid_1.4_75840.patch uploaded by homesick (license 91)
Accept Remote Party ID on guest calls.

........

................

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76563 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMark str2dtmfmode() as currently unused to resolve a compiler warning and
Russell Bryant [Mon, 23 Jul 2007 14:37:26 +0000 (14:37 +0000)]
Mark str2dtmfmode() as currently unused to resolve a compiler warning and
allow building under dev mode

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76562 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years ago(closes issue #10271)
Russell Bryant [Mon, 23 Jul 2007 14:32:04 +0000 (14:32 +0000)]
(closes issue #10271)
Reported by: snuffy
Patches:
      doxygen-updates.diff uploaded by snuffy (license 35)

Another big batch of doxygen documentation updates

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76559 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agonote the debug and verbose changes in CHANGES
Russell Bryant [Mon, 23 Jul 2007 14:23:47 +0000 (14:23 +0000)]
note the debug and verbose changes in CHANGES

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76558 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years ago(closes issue #10192)
Russell Bryant [Mon, 23 Jul 2007 14:21:41 +0000 (14:21 +0000)]
(closes issue #10192)
Reported by: bbryant
Patches:
      20070720__core_debug_by_file.patch uploaded by bbryant (license 36)
  (with some modifications by me)
Tested by: russell, bbryant

This set of changes introduces the ability to set the core debug or verbose
levels on a per-file basis.  Interestingly enough, in 1.4, you have the ability
to set core debug for a single file, but that functionality was accidentally
lost in the conversion of the CLI commands to the new format.

This patch improves upon what was in 1.4 by letting you set it for more than 1
file, and by also supporting verbose.

*** Janitor Project ***

This patch also introduces a new macro, ast_verb(), which is similar
to ast_debug().  Setting the per file verbose value only works for messages that
use this macro.  Converting existing uses of ast_verbose() can be done like:

if (option_debug > 2)
   ast_verbose(VERBOSE_PREFIX_3 "Something useful\n");

...

ast_verb(3, "Something useful\n");

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76555 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agointroduce two functions, map_x_s() and map_s_x(), to map
Luigi Rizzo [Mon, 23 Jul 2007 14:18:04 +0000 (14:18 +0000)]
introduce two functions, map_x_s() and map_s_x(), to map
between integers and strings using a single translation table,
and use them in a few places instead of ad-hoc routines
that duplicate the table.

On passing, note that REFER_CONFIRMED is never used, and add a
few comments.

Nothing to backport here.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76547 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoRemove an unused function to resolve a compiler warning
Russell Bryant [Mon, 23 Jul 2007 14:02:21 +0000 (14:02 +0000)]
Remove an unused function to resolve a compiler warning

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76524 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoUse autoconf logic to determine byte swapping macro presence. This should now also...
Joshua Colp [Mon, 23 Jul 2007 13:46:57 +0000 (13:46 +0000)]
Use autoconf logic to determine byte swapping macro presence. This should now also use other macros if present.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76523 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agomove "sip prunte realtime ..." and "sip set debug ... " to NEW_CLI style.
Luigi Rizzo [Mon, 23 Jul 2007 13:29:06 +0000 (13:29 +0000)]
move "sip prunte realtime ..." and "sip set debug ... " to NEW_CLI style.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76521 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerged revisions 76519 via svnmerge from
Joshua Colp [Mon, 23 Jul 2007 13:24:03 +0000 (13:24 +0000)]
Merged revisions 76519 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r76519 | file | 2007-07-23 10:23:09 -0300 (Mon, 23 Jul 2007) | 6 lines

(closes issue #10268)
Reported by: mvanbaak
Patches:
      chan_skinny_openbsd.diff uploaded by mvanbaak (license 7)
Add another OS that has to use the Macros for byte ordering.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76520 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerged revisions 76485 via svnmerge from
Russell Bryant [Mon, 23 Jul 2007 12:29:46 +0000 (12:29 +0000)]
Merged revisions 76485 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r76485 | russell | 2007-07-23 07:25:01 -0500 (Mon, 23 Jul 2007) | 6 lines

Use a signed integer for storing the number of bytes in the packet read from
the network.  Using an unsigned value here made it impossible to handle an
error returned from recvfrom().  Furthermore, in the case that recvfrom()
did return an error, this would cause a crash due to a heap overflow.
(closes issue #10265, reported by and fix suggested by timrobbins)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76486 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoAdd some documentation on the sipregistry states and the
Luigi Rizzo [Mon, 23 Jul 2007 03:10:31 +0000 (03:10 +0000)]
Add some documentation on the sipregistry states and the
handling of the sip_register structures.
This commit only changes comments and whitespace.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76467 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoadd a bit of comments on internal functions.
Luigi Rizzo [Mon, 23 Jul 2007 02:46:10 +0000 (02:46 +0000)]
add a bit of comments on internal functions.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76458 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agorewrite "sip show {channels|subscriptions}" CLI handler
Luigi Rizzo [Sun, 22 Jul 2007 21:38:26 +0000 (21:38 +0000)]
rewrite "sip show {channels|subscriptions}" CLI handler
using the new-style cli format.
No functional changes, nothing to backport.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76408 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMake sip_destroy() return NULL so the caller can do things like
Luigi Rizzo [Sun, 22 Jul 2007 21:00:10 +0000 (21:00 +0000)]
Make sip_destroy() return NULL so the caller can do things like
     foo = sip_destroy(foo);
and reduce the chance of bugs due to dangling pointers.

Also remove a duplicate prototype for the function.

nothing to backport.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76392 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoadd two comment blocks, one on reusing nonces, and one on the handling
Luigi Rizzo [Sun, 22 Jul 2007 20:44:06 +0000 (20:44 +0000)]
add two comment blocks, one on reusing nonces, and one on the handling
of an 'authpeer' local variable.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76390 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agocomment and slightly restructure handle_request() in the part that handles
Luigi Rizzo [Sun, 22 Jul 2007 19:08:37 +0000 (19:08 +0000)]
comment and slightly restructure handle_request() in the part that handles
responses, so that there is a common exit point.
Mark two places where probably we could return -1 instead of 0 to report
an error to the caller.
(change triggered by investigations on how the 'SIP_PKT_IGNORE' field was used).

nothing to backport from this commit

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76371 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoremove unused argument from handle_invite_replaces(), and also leftover
Luigi Rizzo [Sun, 22 Jul 2007 18:46:52 +0000 (18:46 +0000)]
remove unused argument from handle_invite_replaces(), and also leftover
SIP_PKT_* stuff from the previous commit.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76366 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoCleanup of flags used in struct sip_request, moving them to
Luigi Rizzo [Sun, 22 Jul 2007 18:41:57 +0000 (18:41 +0000)]
Cleanup of flags used in struct sip_request, moving them to
individual variables. Apart from SIP_PKT_IGNORE which was used
a zillion times, the other two are used seldom.

On passing:
- move the arrays to the end of struct sip_request, so a (small)
  buffer overflow is less likely to overwrite the other fields;
- note that the 'ignore' argument to handle_invite_replaces() is not
  used and should be removed (will be done in a separate commit).

Nothing to backport in this change.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76365 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agomove two per-packet flags to proper variables.
Luigi Rizzo [Sun, 22 Jul 2007 18:03:07 +0000 (18:03 +0000)]
move two per-packet flags to proper variables.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76349 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agominor clarification on the usage of SIP_* flags.
Luigi Rizzo [Sun, 22 Jul 2007 17:27:52 +0000 (17:27 +0000)]
minor clarification on the usage of SIP_* flags.
Also correct some items that were misclassified.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76348 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agodocument the way sipdebug works, and implement it through
Luigi Rizzo [Sun, 22 Jul 2007 08:42:24 +0000 (08:42 +0000)]
document the way sipdebug works, and implement it through
variables and not flags.

NOTE:
The old behaviour (preserved in this commit) is that if sipdebug
is set in the config file, it can only be disabled by reloading the
config.  I am not sure if this is accidental or voluntary, but it
is really unconvenient and I think it should be handled in the same
way as other options i.e. consider requests from the config file
or the cli (or the command line) to be fully equivalent and act on
the same status variable.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76330 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agomove the SIP_REALTIME flag to a field in the user/peer structure.
Luigi Rizzo [Sat, 21 Jul 2007 17:57:47 +0000 (17:57 +0000)]
move the SIP_REALTIME flag to a field in the user/peer structure.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76314 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoAdd a note to document how the temporary 'pvt' should be initialized
Luigi Rizzo [Sat, 21 Jul 2007 17:32:00 +0000 (17:32 +0000)]
Add a note to document how the temporary 'pvt' should be initialized
before using it.
I am unclear on the details right now so i hope someone can comment
more. The obvious (and lazy) approach would be to bzero() all of it
(except for the string pool), but isn't that too much work ?
Feedback wanted here...

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76313 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoAdd support for using /dev/urandom to get random numbers on systems that support it.
Joshua Colp [Sat, 21 Jul 2007 14:39:52 +0000 (14:39 +0000)]
Add support for using /dev/urandom to get random numbers on systems that support it.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76296 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agowhoops... was setting needdestroy on the wrong dialog.
Luigi Rizzo [Sat, 21 Jul 2007 09:35:48 +0000 (09:35 +0000)]
whoops... was setting needdestroy on the wrong dialog.
(spotted by a diff with my own branch)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76279 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agomore two more flags to proper variables: ALREADYGONE and NEEDDESTROY.
Luigi Rizzo [Sat, 21 Jul 2007 09:18:50 +0000 (09:18 +0000)]
more two more flags to proper variables: ALREADYGONE and NEEDDESTROY.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76278 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agouse explicit variables for things that don't need to
Luigi Rizzo [Sat, 21 Jul 2007 03:53:17 +0000 (03:53 +0000)]
use explicit variables for things that don't need to
be stored in ast_flags. First victim is 'SIP_NO_HISTORY'
replaced by a 'do_history' field in the sip_pvt structure.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76231 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoUse ast_str_append() instead of ast_build_string() to construct
Luigi Rizzo [Sat, 21 Jul 2007 02:33:25 +0000 (02:33 +0000)]
Use ast_str_append() instead of ast_build_string() to construct
the sdp messages. Overall the code is slightly more readable
(because the string is fully described by a single pointer),
and more efficient (because the length is stored explicitly
so you don't need to do strlen()).
(I have been using this code for almost a year now.)

I wish we had infix string operators to do this sort of things!

Nothing to backport from this change.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76229 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoBlocked revisions 76227 via svnmerge
Russell Bryant [Sat, 21 Jul 2007 02:03:43 +0000 (02:03 +0000)]
Blocked revisions 76227 via svnmerge

................
r76227 | russell | 2007-07-20 21:02:54 -0500 (Fri, 20 Jul 2007) | 12 lines

Merged revisions 76226 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r76226 | russell | 2007-07-20 21:01:46 -0500 (Fri, 20 Jul 2007) | 4 lines

Backport a fix for a memory leak that was fixed in trunk in reivision 76221
by rizzo.  The memory used for the localaddr list was not freed during a
configuration reload.

........

................

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76228 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoWe have two 'technology' descriptors for a SIP channel, so
Luigi Rizzo [Sat, 21 Jul 2007 01:25:13 +0000 (01:25 +0000)]
We have two 'technology' descriptors for a SIP channel, so
define and use a macro to determine whether we are pointing to
one of them, so when one goes away (or a new one appears) we don't
have to touch all the code.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76224 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoOne small documentation update made to accompany 10154, the upgrading of the queue...
Steve Murphy [Sat, 21 Jul 2007 01:08:46 +0000 (01:08 +0000)]
One small documentation update made to accompany 10154, the upgrading of the queue ringing to allow periodic announcments

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76222 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoEnhance NAT support as discussed on the -dev list, i.e.:
Luigi Rizzo [Sat, 21 Jul 2007 01:01:10 +0000 (01:01 +0000)]
Enhance NAT support as discussed on the -dev list, i.e.:

+ extensive documentation changes both in sip.conf.sample and in the source;

+ allow "externip" and "externhost" to include a port number as well;

+ allow "bindaddr" to have a port number (making bindport unnecessary,
  even though it is still present for backward compatibility);

+ introduce the new "stunaddr" parameter to specify an STUN server to
  be used from the main SIP socket;

+ extend the "sip show settings" output to show all the above.

Internally:

+ change related data structures from struct in_addr to struct sockaddr_in
  to store the port numbers as well;

+ reorganize ast_sip_ouraddrfor() (should also be renamed to sip_ouraddrfor()
  because it is not a generic API, though it might become so if called with
  a socket as an additional argument, in which case it can be moved elsewhere).

As mentioned in the documentation, media sessions still do not use STUN so the
port numbers may still be incorrect when Asterisk is behind a NAT

On passing, some of the debugging messages printing media addresses are
probably using the wrong values, but this will be checked/fixed in a
subsequent commit if needed.

Part of the following chunk in the function that handles a "sip reload" is
probably needed on previous versions as well, to avoid leaking the memory
used for the "localaddr" list:

@@ -17244,13 +17274,17 @@

        /* Reset IP addresses  */
        memset(&bindaddr, 0, sizeof(bindaddr));
+       memset(&stunaddr, 0, sizeof(stunaddr));
+       memset(&internip, 0, sizeof(internip));
+       /* Free memory for local network address mask */
+ --->  ast_free_ha(localaddr); <-----
        memset(&localaddr, 0, sizeof(localaddr));
        memset(&externip, 0, sizeof(externip));
        memset(&default_prefs, 0 , sizeof(default_prefs));

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76221 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoThis update was supplied in 10154; to allow announcemnts if the 'r' option (ringing...
Steve Murphy [Sat, 21 Jul 2007 00:57:00 +0000 (00:57 +0000)]
This update was supplied in 10154; to allow announcemnts if the 'r' option (ringing) is provided.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76220 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoAdd support for default "say mode" (whether to use the "old" method or "new" method...
Jason Parker [Fri, 20 Jul 2007 22:25:41 +0000 (22:25 +0000)]
Add support for default "say mode" (whether to use the "old" method or "new" method.  "new" method being config file)
Add support for autocomplete of "say load" CLI command.

Patch by IgorG
(closes issue #10243)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76216 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerged revisions 76211 via svnmerge from
Steve Murphy [Fri, 20 Jul 2007 21:41:51 +0000 (21:41 +0000)]
Merged revisions 76211 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r76211 | murf | 2007-07-20 15:36:05 -0600 (Fri, 20 Jul 2007) | 1 line

This patch from 10249 is worth applying! It prevents downloading sound files if they are already downloaded. Darn Practical, if you ask me
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76213 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoBlocked revisions 76178 via svnmerge
Jason Parker [Fri, 20 Jul 2007 21:04:27 +0000 (21:04 +0000)]
Blocked revisions 76178 via svnmerge

........
r76178 | qwell | 2007-07-20 16:03:57 -0500 (Fri, 20 Jul 2007) | 7 lines

Allow getting a call from an existing "sub" channel.

Cancel ringing if endpoint hangs up before answering.

Fixes were backported from trunk (there was apparently a bit of confusion during merge of a previous patch).
(closes issue #10241)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76179 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoBlocked revisions 76176 via svnmerge
Jason Parker [Fri, 20 Jul 2007 20:56:07 +0000 (20:56 +0000)]
Blocked revisions 76176 via svnmerge

........
r76176 | qwell | 2007-07-20 15:54:10 -0500 (Fri, 20 Jul 2007) | 2 lines

Eliminate a compiler warning with gcc 4.2 by constifying a char *

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76177 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerged revisions 76174 via svnmerge from
Jason Parker [Fri, 20 Jul 2007 20:33:34 +0000 (20:33 +0000)]
Merged revisions 76174 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r76174 | qwell | 2007-07-20 15:32:55 -0500 (Fri, 20 Jul 2007) | 2 lines

It's possible for sub->owner to be NULL here if you cancel the call immediately after/during sending a digit.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76175 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerged revisions 76139 via svnmerge from
Mark Michelson [Fri, 20 Jul 2007 18:44:30 +0000 (18:44 +0000)]
Merged revisions 76139 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r76139 | mmichelson | 2007-07-20 13:42:27 -0500 (Fri, 20 Jul 2007) | 6 lines

When using users.conf for the entries in the directory, if multiple users had the same last name, only the first user listed would be available
in the directory.

(closes issue #10200, reported by mrskippy, patched by me)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76140 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerged revisions 76132 via svnmerge from
Russell Bryant [Fri, 20 Jul 2007 18:28:15 +0000 (18:28 +0000)]
Merged revisions 76132 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r76132 | russell | 2007-07-20 13:22:24 -0500 (Fri, 20 Jul 2007) | 6 lines

Use the define that specifies the default length of an artificially created
DTMF digit in the ast_senddigit() function.  The define is set to 100ms by
default, which is the same thing that this function was using.  But, using
the define lets changes take effect in this case, as well as the others where
it was already used.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76138 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerged revisions 76087 via svnmerge from
Joshua Colp [Fri, 20 Jul 2007 17:21:23 +0000 (17:21 +0000)]
Merged revisions 76087 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
r76087 | file | 2007-07-20 14:20:09 -0300 (Fri, 20 Jul 2007) | 14 lines

Merged revisions 76080 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r76080 | file | 2007-07-20 14:16:48 -0300 (Fri, 20 Jul 2007) | 6 lines

(closes issue #10247)
Reported by: fkasumovic
Patches:
      chan_sip.patch uploaded by fkasumovic (license #101)
Drop any peer realm authentication entries when reloading so multiple entries do not get added to the peer.

........

................

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76091 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerged revisions 76067 via svnmerge from
Joshua Colp [Fri, 20 Jul 2007 17:11:39 +0000 (17:11 +0000)]
Merged revisions 76067 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r76067 | file | 2007-07-20 14:10:17 -0300 (Fri, 20 Jul 2007) | 6 lines

(closes issue #10246)
Reported by: fkasumovic
Patches:
      res_conver.patch uploaded by fkasumovic (license #101)
Use the last occurance of . to find the extension, not the first occurance.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76070 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoIt is impossible for the externhost variable to not exist, it is however possible...
Joshua Colp [Fri, 20 Jul 2007 16:51:09 +0000 (16:51 +0000)]
It is impossible for the externhost variable to not exist, it is however possible for it to be empty.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76056 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoBlocked revisions 76054 via svnmerge
Joshua Colp [Fri, 20 Jul 2007 16:49:58 +0000 (16:49 +0000)]
Blocked revisions 76054 via svnmerge

........
r76054 | file | 2007-07-20 13:49:13 -0300 (Fri, 20 Jul 2007) | 2 lines

Move makeannouncement variable declaration to proper place.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76055 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoDon't use a field size for the last argument of printf format,
Luigi Rizzo [Fri, 20 Jul 2007 15:06:54 +0000 (15:06 +0000)]
Don't use a field size for the last argument of printf format,
because in this case the string is left-aligned and it is not
truncated anyways.

Omitting the field size prevents the generation of trailing whitespace,
which makes the string fit in smaller windows.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76037 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoExtend the 'network settings' section with indication on the
Luigi Rizzo [Fri, 20 Jul 2007 14:54:01 +0000 (14:54 +0000)]
Extend the 'network settings' section with indication on the
localnet settings (requires the change in SVN 76034), and also
give an indication on whether/why/how the remapping of addresses
in SIP message is done or not.

I think this is especially useful for debugging the configuration,
as the address remapping depends on a combination of at least 3
parameters (localnet, externhost, externip) and successful DNS lookup.

An example of the output of this section is below:

Network Settings:
---------------------------
  SIP address remapping:  Enabled using externhost
  Externhost:             foo.dyndns.net
  Externip:               80.64.128.23:0
  Externrefresh:          10
  Internal IP:            12.34.56.78:5060
  Localnet:               192.168.0.0/255.255.0.0
  10.0.0.0/255.0.0.0

I leave to the community the judgement if the above info is a
useful addition for 1.4. It is not a bugfix, but it is neither a
new feature, only a useful diagnostic tool.

Note that I would like to move there also the bindaddress/port
information, in the usual addr:port format e.g.

          Bindaddress:            0.0.0.0:5060

so that network information is all in one place.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76035 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoexpose struct ast_ha so external code can do things such as printing it
Luigi Rizzo [Fri, 20 Jul 2007 14:38:36 +0000 (14:38 +0000)]
expose struct ast_ha so external code can do things such as printing it
(e.g. chan_sip.c in a subsequent commit).

Obviously exposing the internals of a data structure is far from ideal
(especially in a case like this where the implementation is very
inefficient and will need to be changed at some point).

On the other hand, it was also unclear what additional APIs should
we provide instead, and because exposing the stucture has no impact
on source and binary compatibility, this seemed to me the best option at
this time.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76034 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoReduce some logging contention by switching several locks over to rwlocks
Tilghman Lesher [Fri, 20 Jul 2007 01:54:52 +0000 (01:54 +0000)]
Reduce some logging contention by switching several locks over to rwlocks

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76015 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoAfter some study, thought, comparing, etc. I've backed out the previous universal...
Steve Murphy [Thu, 19 Jul 2007 23:24:27 +0000 (23:24 +0000)]
After some study, thought, comparing, etc. I've backed out the previous universal mod to make ast_flags a 64 bit thing. Instead, I added a 64-bit version of ast_flags (ast_flags64), and 64-bit versions of the test-flag, set-flag, etc. macros, and an app_parse_options64 routine, and I use these in app_dial alone, to eliminate the 30-option limit it had grown to meet. There is room now for 32 more options and flags. I was heavily tempted to implement some of the other ideas that were presented, but this solution does not intro any new versions of dial, doesn't have a different API, has a minimal/zero impact on code outside of dial, and doesn't seriously (I hope) affect the code structure of dial. It's the best I can think of right now. My goal was NOT to rewrite dial. I leave that to a future, coordinated effort.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@75983 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoThis repairs a 'warning: ISO C90 forbids mixed declarations and code' message that...
Steve Murphy [Thu, 19 Jul 2007 22:00:59 +0000 (22:00 +0000)]
This repairs a 'warning: ISO C90 forbids mixed declarations and code' message that cripples my dev-mode enabled build

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@75982 65c4cc65-6c06-0410-ace0-fbb531ad65f3