asterisk/asterisk.git
13 years agocoding guidelines, coding guidelines, coding guidelines
Kevin P. Fleming [Wed, 8 Nov 2006 15:28:39 +0000 (15:28 +0000)]
coding guidelines, coding guidelines, coding guidelines

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47321 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agomerge from team/rizzo/astobj2 rev.47271
Luigi Rizzo [Wed, 8 Nov 2006 13:59:32 +0000 (13:59 +0000)]
merge from team/rizzo/astobj2 rev.47271

avoid doing p > 0 when p is a pointer;
move a lock closer to the place where it is needed

Approved By: oej

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47318 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agomerge from team/rizzo/astobj2 rev.47246
Luigi Rizzo [Wed, 8 Nov 2006 13:53:01 +0000 (13:53 +0000)]
merge from team/rizzo/astobj2 rev.47246

Same as for peers and users, replace ASTOBJ_UNREF(r, sip_registry_destroy)
with unref_registry(r);

Approved By: oej

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47317 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agomerge from team/rizzo/astobj2, rev 47243, 47244, 47245:
Luigi Rizzo [Wed, 8 Nov 2006 13:49:25 +0000 (13:49 +0000)]
merge from team/rizzo/astobj2, rev 47243, 47244, 47245:

Replace ASTOBJ_UNREF(peer, sip_destroy_peer) with unref_peer(peer);

This places the name of the destructor in one place only (where it
should be), eliminates the chance of errors in case you specify the wrong
destructor, and also lets the compiler do type checking on the argument,
again helping with keeping the code clean.

Same for users.
remove two duplicate definitions.

Approved By: oej

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47316 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agomerge rev.47224 from team/rizzo/astobj2:
Luigi Rizzo [Wed, 8 Nov 2006 13:44:27 +0000 (13:44 +0000)]
merge rev.47224 from team/rizzo/astobj2:

hide dialoglist lock/unlocking in wrapper functions.

Approved By: oej

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47315 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agosilence compiler about uninitialized variables.
Luigi Rizzo [Wed, 8 Nov 2006 13:43:06 +0000 (13:43 +0000)]
silence compiler about uninitialized variables.
The compiler is wrong, but it has the last word.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47314 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoDestroy dialog properly at unload (rizzo)
Olle Johansson [Wed, 8 Nov 2006 08:01:44 +0000 (08:01 +0000)]
Destroy dialog properly at unload (rizzo)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47313 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agofix compilation.
Luigi Rizzo [Wed, 8 Nov 2006 07:21:45 +0000 (07:21 +0000)]
fix compilation.
Overall i think the previous change to ast_channel_alloc()
to close bug 7506 should have been done by defining
an ast_set_callerid_noevent() function that does the
setting without generating the event.
Lot less code duplication, and easier to handle.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47306 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoadd a comment about where AC_PROG_LD comes from
Russell Bryant [Wed, 8 Nov 2006 03:13:46 +0000 (03:13 +0000)]
add a comment about where AC_PROG_LD comes from

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47305 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoremove aclocal.m4 from the tree since it is just an intermediate file created
Russell Bryant [Wed, 8 Nov 2006 03:12:31 +0000 (03:12 +0000)]
remove aclocal.m4 from the tree since it is just an intermediate file created
while generating the configure script.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47304 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agofix "core show profile" parsing.
Luigi Rizzo [Tue, 7 Nov 2006 23:14:04 +0000 (23:14 +0000)]
fix "core show profile" parsing.

Needs to go in 1.4 too, but ENOTIME now

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47300 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years ago%ld and time_t don't match, so cast the argument to long
Luigi Rizzo [Tue, 7 Nov 2006 22:26:48 +0000 (22:26 +0000)]
%ld and time_t don't match, so cast the argument to long
to ease portability problems

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47295 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoA fair number of changes for the sake of bug 7506
Steve Murphy [Tue, 7 Nov 2006 21:47:49 +0000 (21:47 +0000)]
A fair number of changes for the sake of bug 7506

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47290 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerged revisions 47287 via svnmerge from
Joshua Colp [Tue, 7 Nov 2006 20:16:02 +0000 (20:16 +0000)]
Merged revisions 47287 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r47287 | file | 2006-11-07 15:14:58 -0500 (Tue, 07 Nov 2006) | 2 lines

This is not the commit you are looking for...

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47288 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerged revisions 47284 via svnmerge from
Joshua Colp [Tue, 7 Nov 2006 20:12:30 +0000 (20:12 +0000)]
Merged revisions 47284 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r47284 | file | 2006-11-07 15:08:52 -0500 (Tue, 07 Nov 2006) | 2 lines

Make MOH work as it did before in chan_local, without this then it can go funky when transfers and MOH are involved. (issue #7671 reported by jmls)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47285 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerged revisions 47279 via svnmerge from
Kevin P. Fleming [Tue, 7 Nov 2006 18:56:56 +0000 (18:56 +0000)]
Merged revisions 47279 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r47279 | kpfleming | 2006-11-07 12:56:21 -0600 (Tue, 07 Nov 2006) | 2 lines

clean up sample config, and make native file playback the more obvious default choice

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47280 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agorge overhaul to voicemail imap support. Allows support for more imap servers,
Matt O'Gorman [Tue, 7 Nov 2006 18:50:58 +0000 (18:50 +0000)]
rge overhaul to voicemail imap support.  Allows support for more imap servers,
also a better implementation of several parts of the original work.
patch provided by 8033 with major upgrades. minor differences from 1.4 patch do to
changes in app_voicemail

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47278 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoBreak -> continue to make stuff work... Thanks, Luigi!
Olle Johansson [Tue, 7 Nov 2006 17:33:24 +0000 (17:33 +0000)]
Break -> continue to make stuff work... Thanks, Luigi!

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47269 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoremove another broken property merge
Kevin P. Fleming [Tue, 7 Nov 2006 14:25:00 +0000 (14:25 +0000)]
remove another broken property merge

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47259 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoremove properties that shouldn't be merged to this branch
Kevin P. Fleming [Tue, 7 Nov 2006 14:24:19 +0000 (14:24 +0000)]
remove properties that shouldn't be merged to this branch

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47258 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agouse editable URL for menuselect, and switch to trunk
Kevin P. Fleming [Tue, 7 Nov 2006 14:17:53 +0000 (14:17 +0000)]
use editable URL for menuselect, and switch to trunk

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47257 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoissue #8265 - don't reply to ACK. Imported from 1.2, 1.4
Olle Johansson [Tue, 7 Nov 2006 13:26:31 +0000 (13:26 +0000)]
issue #8265 - don't reply to ACK. Imported from 1.2, 1.4

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47252 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoStealing Tilghman's explanation from the -dev list and producing documentation...
Olle Johansson [Tue, 7 Nov 2006 13:16:05 +0000 (13:16 +0000)]
Stealing Tilghman's explanation from the -dev list and producing documentation...

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47251 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoexplain why ast_carefulwrite is written the way it is,
Luigi Rizzo [Tue, 7 Nov 2006 08:34:26 +0000 (08:34 +0000)]
explain why ast_carefulwrite is written the way it is,
and also that it doesn't really work as claimed.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47242 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerged revisions 47239 via svnmerge from
Russell Bryant [Tue, 7 Nov 2006 01:28:08 +0000 (01:28 +0000)]
Merged revisions 47239 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
r47239 | russell | 2006-11-06 20:25:10 -0500 (Mon, 06 Nov 2006) | 13 lines

Merged revisions 47238 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r47238 | russell | 2006-11-06 20:22:58 -0500 (Mon, 06 Nov 2006) | 5 lines

If random order is enabled for files mode music on hold, set a random initial
position, instead of always starting at the first file, and doing the random
operation only when switching to the next file.
(bug reported by John Lange on the asterisk-dev mailing list)

........

................

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47240 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agocheck for failure after call to calloc() (issue #8295)
Russell Bryant [Mon, 6 Nov 2006 18:05:11 +0000 (18:05 +0000)]
check for failure after call to calloc() (issue #8295)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47232 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agominor change to test live syncing
Kevin P. Fleming [Mon, 6 Nov 2006 17:27:28 +0000 (17:27 +0000)]
minor change to test live syncing

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47230 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoAdd support for manager hooks, so you could fire off manager events over IRC if you...
Joshua Colp [Mon, 6 Nov 2006 17:05:04 +0000 (17:05 +0000)]
Add support for manager hooks, so you could fire off manager events over IRC if you were crazy enough. (issue #5161 reported by anthm with mods by moi)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47229 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMake pbx_dundi compile again. Sorry. :(
Russell Bryant [Sun, 5 Nov 2006 01:04:29 +0000 (01:04 +0000)]
Make pbx_dundi compile again.  Sorry.  :(

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47213 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoList ss7 with the rest of the valid signalling types. Group SS7 options
Russell Bryant [Sat, 4 Nov 2006 22:41:12 +0000 (22:41 +0000)]
List ss7 with the rest of the valid signalling types.  Group SS7 options
together and comment them out by default.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47210 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoDon't lock dialoglist if monitor runs __sip_destroy.
Olle Johansson [Sat, 4 Nov 2006 22:16:57 +0000 (22:16 +0000)]
Don't lock dialoglist if monitor runs __sip_destroy.

Hmmm. I did not change pbx_dundi and yet it doesn't compile ;-)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47209 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agouse the AST_MODULE_LOAD_* return codes from load_module()
Russell Bryant [Sat, 4 Nov 2006 22:08:35 +0000 (22:08 +0000)]
use the AST_MODULE_LOAD_* return codes from load_module()

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47207 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agosimplify a couple of loops
Russell Bryant [Sat, 4 Nov 2006 21:54:37 +0000 (21:54 +0000)]
simplify a couple of loops

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47206 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMove IP address selection for media out of add_sdp
Olle Johansson [Sat, 4 Nov 2006 21:48:02 +0000 (21:48 +0000)]
Move IP address selection for media out of add_sdp

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47205 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoDo some minor cleanup to the section of code that sets the EID by getting the
Russell Bryant [Sat, 4 Nov 2006 21:44:48 +0000 (21:44 +0000)]
Do some minor cleanup to the section of code that sets the EID by getting the
mac address for an ethernet interface

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47204 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMake srvlookup global_srvlookup to follow the rest of the code
Olle Johansson [Sat, 4 Nov 2006 21:17:40 +0000 (21:17 +0000)]
Make srvlookup global_srvlookup to follow the rest of the code

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47203 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoSimplify previous patch
Olle Johansson [Sat, 4 Nov 2006 19:20:30 +0000 (19:20 +0000)]
Simplify previous patch

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47202 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoAdding new config option "limitpeersonly" to only apply call limits
Olle Johansson [Sat, 4 Nov 2006 19:13:30 +0000 (19:13 +0000)]
Adding new config option "limitpeersonly" to only apply call limits
to the peer side of a type=friend.

This is for trying to support BJ in his quest to solve some issues
with the queue system and type=friend objects.

BJ: Please test!

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47201 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoImporting patch for Invite/replaces from 1.4
Olle Johansson [Sat, 4 Nov 2006 18:40:51 +0000 (18:40 +0000)]
Importing patch for Invite/replaces from 1.4

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47200 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerged revisions 47196 via svnmerge from
Russell Bryant [Sat, 4 Nov 2006 18:12:31 +0000 (18:12 +0000)]
Merged revisions 47196 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r47196 | russell | 2006-11-04 13:10:22 -0500 (Sat, 04 Nov 2006) | 2 lines

Fix another bug in "core set debug" ...

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47198 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerged revisions 47195 via svnmerge from
Russell Bryant [Sat, 4 Nov 2006 18:11:18 +0000 (18:11 +0000)]
Merged revisions 47195 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r47195 | russell | 2006-11-04 12:59:39 -0500 (Sat, 04 Nov 2006) | 2 lines

Really fix the "core set debug" and "core set verbose" CLI commands.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47197 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoReverting rev 47093 until we have an agreement on how to
Olle Johansson [Sat, 4 Nov 2006 17:45:47 +0000 (17:45 +0000)]
Reverting rev 47093 until we have an agreement on how to
implement this, if at all.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47194 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerged revisions 47192 via svnmerge from
Russell Bryant [Sat, 4 Nov 2006 17:40:42 +0000 (17:40 +0000)]
Merged revisions 47192 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r47192 | russell | 2006-11-04 12:38:24 -0500 (Sat, 04 Nov 2006) | 3 lines

fix the "atleast" option to the "core set verbose" and "core set debug"
CLI commands

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47193 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agomove out another large block to a large function, and document
Luigi Rizzo [Sat, 4 Nov 2006 11:00:49 +0000 (11:00 +0000)]
move out another large block to a large function, and document
some possibly missing parts in the privacy screening code.
Now that it is more streamlined it is easier to see differences
in handling the various cases.

Have not tested the code in depth.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47189 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agouseless cast removal...
Luigi Rizzo [Sat, 4 Nov 2006 01:40:49 +0000 (01:40 +0000)]
useless cast removal...

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47187 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoremove many unnecessary casts
Luigi Rizzo [Sat, 4 Nov 2006 01:34:59 +0000 (01:34 +0000)]
remove many unnecessary casts

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47186 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoremove a useless cast
Luigi Rizzo [Sat, 4 Nov 2006 01:32:31 +0000 (01:32 +0000)]
remove a useless cast

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47185 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agodocument the "debug" parameter, and the change
Luigi Rizzo [Sat, 4 Nov 2006 01:20:38 +0000 (01:20 +0000)]
document the "debug" parameter, and the change
manager list -> manager show

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47184 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agofix indentation of a block, and do minor simplifications at the end of
Luigi Rizzo [Sat, 4 Nov 2006 01:16:20 +0000 (01:16 +0000)]
fix indentation of a block, and do minor simplifications at the end of
another one.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47182 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agocomplete previous commit.
Luigi Rizzo [Sat, 4 Nov 2006 00:56:02 +0000 (00:56 +0000)]
complete previous commit.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47181 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agomove another block into a function.
Luigi Rizzo [Sat, 4 Nov 2006 00:50:18 +0000 (00:50 +0000)]
move another block into a function.
On passing, avoid two null-pointer string dereference
while printing messages (which are
sometimes not fatal in some platforms, but still wrong).
These two lines at least should be merged to 1.4 once i am
done with all the changes here.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47180 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agomove a large block into a separate function.
Luigi Rizzo [Sat, 4 Nov 2006 00:01:40 +0000 (00:01 +0000)]
move a large block into a separate function.
Mark with XXX a possible bug in previous code which used
the wrong source in case of a forwarded call.

the function do_forward() needs to be split further, as the initial
part is replicated in another places (with some minor differences, most likely
forgotten when updating after the copy).

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47179 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoThis fix introduced via bug 8233
Steve Murphy [Fri, 3 Nov 2006 23:27:58 +0000 (23:27 +0000)]
This fix introduced via bug 8233

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47178 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoanother small set of simplifications
Luigi Rizzo [Fri, 3 Nov 2006 23:24:21 +0000 (23:24 +0000)]
another small set of simplifications

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47177 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agochange HANDLE_CAUSE into a function.
Luigi Rizzo [Fri, 3 Nov 2006 22:36:17 +0000 (22:36 +0000)]
change HANDLE_CAUSE into a function.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47175 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoremove redundant checks
Luigi Rizzo [Fri, 3 Nov 2006 22:01:34 +0000 (22:01 +0000)]
remove redundant checks

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47170 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agostart integrating the simplifications proposed in bug 0005860,
Luigi Rizzo [Fri, 3 Nov 2006 21:51:16 +0000 (21:51 +0000)]
start integrating the simplifications proposed in bug 0005860,
as usual a bit at a time to ease locating new bugs or fixes
worth merging into other branches.

In this commit, introduce a macro, S_REPLACE, that replaces
a string possibly freeing the previous value.
In one of these places (see the comment marked XXX) the previous
code might leak memory - if so, this ought to be merged in 1.4

The macro might be worth putting in one of the global headers
(e.g. include/asterisk/strings.h) as the construct is used
in a million places in the asterisk code.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47160 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoOne has to create the path and filename in order to copy a file there. (issue #8278...
Joshua Colp [Fri, 3 Nov 2006 19:15:07 +0000 (19:15 +0000)]
One has to create the path and filename in order to copy a file there. (issue #8278 reported by davebath)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47146 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoadd a new cli/manager.conf option "debug" to enable/disable
Luigi Rizzo [Fri, 3 Nov 2006 18:53:26 +0000 (18:53 +0000)]
add a new cli/manager.conf option "debug" to enable/disable
debugging code in the manager.
At the moment the debugging code is very lightweight, if the option
is enabled manager messages also carry a sequence number and
the info where they have been generated e.g.

SequenceNumber: 10
File: chan_sip.c
Line: 11927
Func: handle_response_register

It is not worthwhile having this as a compile time option
right now, because the extra work involved at runtime is
just checking one variable.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47132 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoremove old/useless usecnt stuff
Luigi Rizzo [Fri, 3 Nov 2006 18:17:08 +0000 (18:17 +0000)]
remove old/useless usecnt stuff

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47131 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoremove old/useless usecnt stuff.
Luigi Rizzo [Fri, 3 Nov 2006 18:16:20 +0000 (18:16 +0000)]
remove old/useless usecnt stuff.
I think this module doesn't compile, anyways, because
it has not been updated to the new module interface.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47130 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoFix "core show channels" and "core show modules".
Luigi Rizzo [Fri, 3 Nov 2006 18:13:26 +0000 (18:13 +0000)]
Fix "core show channels" and "core show modules".
Not sure it applies like this to 1.4 because of
deprecate versions of the same command(s).

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47129 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agomove variable declarations to the beginning of a block.
Luigi Rizzo [Fri, 3 Nov 2006 18:10:44 +0000 (18:10 +0000)]
move variable declarations to the beginning of a block.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47128 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoblock other changes of mine already applied to trunk.
Luigi Rizzo [Fri, 3 Nov 2006 18:09:24 +0000 (18:09 +0000)]
block other changes of mine already applied to trunk.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47127 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoblock more changes of mine already applied to trunk
Luigi Rizzo [Fri, 3 Nov 2006 18:05:41 +0000 (18:05 +0000)]
block more changes of mine already applied to trunk

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47126 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoblocking 47107
Luigi Rizzo [Fri, 3 Nov 2006 18:00:31 +0000 (18:00 +0000)]
blocking 47107

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47113 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoblocking 47108
Luigi Rizzo [Fri, 3 Nov 2006 17:59:42 +0000 (17:59 +0000)]
blocking 47108

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47110 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoSave the 'From' header received in a REGISTER message so we can show it
Luigi Rizzo [Fri, 3 Nov 2006 16:59:52 +0000 (16:59 +0000)]
Save the 'From' header received in a REGISTER message so we can show it
e.g. in the Manager interface. This information is available as
a callerid (or something like that) during a call, but not when a
device is registered but silent.
It may be useful to have it available e.g. when developing a user
interface/operator panel, to map numbers to names.

experimental, so not committed to 1.4

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47093 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoremove useless usecnt stuff
Luigi Rizzo [Fri, 3 Nov 2006 12:24:08 +0000 (12:24 +0000)]
remove useless usecnt stuff

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47077 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoremove useless usecnt stuff
Luigi Rizzo [Fri, 3 Nov 2006 12:22:24 +0000 (12:22 +0000)]
remove useless usecnt stuff

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47076 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoremove useless usecnt stuff
Luigi Rizzo [Fri, 3 Nov 2006 12:21:40 +0000 (12:21 +0000)]
remove useless usecnt stuff

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47075 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoremove useless usecnt stuff
Luigi Rizzo [Fri, 3 Nov 2006 12:19:22 +0000 (12:19 +0000)]
remove useless usecnt stuff

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47074 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoremove useless usecnt handling
Luigi Rizzo [Fri, 3 Nov 2006 12:15:13 +0000 (12:15 +0000)]
remove useless usecnt handling

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47073 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoremove useless usecnt handling code
Luigi Rizzo [Fri, 3 Nov 2006 12:14:00 +0000 (12:14 +0000)]
remove useless usecnt handling code

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47072 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerged revisions 47053 via svnmerge from
Tilghman Lesher [Thu, 2 Nov 2006 23:55:59 +0000 (23:55 +0000)]
Merged revisions 47053 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r47053 | tilghman | 2006-11-02 17:49:13 -0600 (Thu, 02 Nov 2006) | 2 lines

More changes making the CLI more consistent with "category verb arguments" (continuation of issue 8236)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47054 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerged revisions 47051 via svnmerge from
Tilghman Lesher [Thu, 2 Nov 2006 23:16:09 +0000 (23:16 +0000)]
Merged revisions 47051 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r47051 | tilghman | 2006-11-02 17:00:20 -0600 (Thu, 02 Nov 2006) | 2 lines

Reverse change of "show" to "list" and make several other commands more consistent with "category verb arguments"

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47052 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoLet's make application/function/hint lists read/write lists... just for kicks
Joshua Colp [Thu, 2 Nov 2006 21:40:53 +0000 (21:40 +0000)]
Let's make application/function/hint lists read/write lists... just for kicks

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47037 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoUpdates to do unblock correctly
Matthew Fredrickson [Thu, 2 Nov 2006 21:34:03 +0000 (21:34 +0000)]
Updates to do unblock correctly

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47035 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMove check for codec translators to an earlier place in the call, so we can fail...
Olle Johansson [Thu, 2 Nov 2006 20:24:10 +0000 (20:24 +0000)]
Move check for codec translators to an earlier place in the call, so we can fail gracefully (imported from 1.4)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47021 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoDisable code for not implemented functionality (T38 over RTP/TCP)
Olle Johansson [Thu, 2 Nov 2006 19:01:02 +0000 (19:01 +0000)]
Disable code for not implemented functionality (T38 over RTP/TCP)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@46999 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoSure enough, some of the uses of astobj are doing recursive locking. This
Russell Bryant [Thu, 2 Nov 2006 18:34:50 +0000 (18:34 +0000)]
Sure enough, some of the uses of astobj are doing recursive locking.  This
doesn't work with rwlocks, so, this is reverted for now.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@46994 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoastobj was already set up to use read and write locks. Now that we have wrappers
Russell Bryant [Thu, 2 Nov 2006 18:12:08 +0000 (18:12 +0000)]
astobj was already set up to use read and write locks.  Now that we have wrappers
for them, use them here.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@46991 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoConvert translation core linked list over to read/write based one, since it spends...
Joshua Colp [Thu, 2 Nov 2006 18:01:10 +0000 (18:01 +0000)]
Convert translation core linked list over to read/write based one, since it spends most of it's time only reading.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@46972 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoAdd AST_RWLIST_* set of macros which implement linked lists using read/write locks...
Joshua Colp [Thu, 2 Nov 2006 17:56:33 +0000 (17:56 +0000)]
Add AST_RWLIST_* set of macros which implement linked lists using read/write locks, the actual list manipulation is still done via the old macros.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@46967 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerged revisions 46965 via svnmerge from
Russell Bryant [Thu, 2 Nov 2006 17:51:56 +0000 (17:51 +0000)]
Merged revisions 46965 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
r46965 | russell | 2006-11-02 12:49:54 -0500 (Thu, 02 Nov 2006) | 11 lines

Merged revisions 46964 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r46964 | russell | 2006-11-02 12:47:56 -0500 (Thu, 02 Nov 2006) | 3 lines

ignore files in a music on hold directory that begin with '.'
(issue #8249, cboie)

........

................

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@46966 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoSet the AST_RWLOCK_INIT_VALUE to the PTHREAD_RWLOCK_INIT_VALUE if it is available...
Joshua Colp [Thu, 2 Nov 2006 16:51:27 +0000 (16:51 +0000)]
Set the AST_RWLOCK_INIT_VALUE to the PTHREAD_RWLOCK_INIT_VALUE if it is available, that way outside stuff can determine whether to use a constructor or deconstructor for initialization instead of using the init value.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@46940 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoChanges to show blocked/unblocked states, as well as in service, out of service state
Matthew Fredrickson [Thu, 2 Nov 2006 16:50:55 +0000 (16:50 +0000)]
Changes to show blocked/unblocked states, as well as in service, out of service state

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@46939 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerged revisions 46937 via svnmerge from
Kevin P. Fleming [Thu, 2 Nov 2006 16:45:50 +0000 (16:45 +0000)]
Merged revisions 46937 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r46937 | kpfleming | 2006-11-02 10:45:32 -0600 (Thu, 02 Nov 2006) | 2 lines

don't send INVITE when we have determined that we can't offer any audio formats due to lack of trancoding support (or incorrect configuration)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@46938 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoI'm crazy so I will add this... pthread rwlock wrappers, along with autoconf stuff...
Joshua Colp [Thu, 2 Nov 2006 16:28:13 +0000 (16:28 +0000)]
I'm crazy so I will add this... pthread rwlock wrappers, along with autoconf stuff that detects the presence of the initializer and the ability to set the kind of lock (in our case we rather like writer preferred locks so writer starvation doesn't occur... but on something like Darwin we don't get that)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@46935 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerged revisions 46930 via svnmerge from
Joshua Colp [Thu, 2 Nov 2006 16:14:03 +0000 (16:14 +0000)]
Merged revisions 46930 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
r46930 | file | 2006-11-02 11:06:39 -0500 (Thu, 02 Nov 2006) | 10 lines

Merged revisions 46920 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r46920 | file | 2006-11-02 11:02:27 -0500 (Thu, 02 Nov 2006) | 2 lines

Repeat after me oej: I will at least make sure my code compiles before I commit it.

........

................

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@46931 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoAdd simple down event support
Matthew Fredrickson [Thu, 2 Nov 2006 16:03:12 +0000 (16:03 +0000)]
Add simple down event support

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@46926 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agofind_free_chan_in_stack: cleanup buggy usage
Nadi Sarrar [Thu, 2 Nov 2006 15:47:23 +0000 (15:47 +0000)]
find_free_chan_in_stack: cleanup buggy usage

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@46906 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoDon't overwrite pkt->flags (imported from 1.2/1.4)
Olle Johansson [Thu, 2 Nov 2006 15:31:53 +0000 (15:31 +0000)]
Don't overwrite pkt->flags (imported from 1.2/1.4)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@46902 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agovarious whitespace changes to reduce indentation and to better conform to
Russell Bryant [Thu, 2 Nov 2006 14:15:12 +0000 (14:15 +0000)]
various whitespace changes to reduce indentation and to better conform to
formatting guidelines

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@46886 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoChange the buffer used in callerid_feed() and callerid_feed_jp() to be
Russell Bryant [Thu, 2 Nov 2006 14:07:48 +0000 (14:07 +0000)]
Change the buffer used in callerid_feed() and callerid_feed_jp() to be
allocated on the stack using alloca() instead of using malloc() since
they are only used locally to these functions.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@46885 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoBlocked revisions 46883 via svnmerge
Russell Bryant [Thu, 2 Nov 2006 14:03:42 +0000 (14:03 +0000)]
Blocked revisions 46883 via svnmerge

........
r46883 | russell | 2006-11-02 09:02:37 -0500 (Thu, 02 Nov 2006) | 3 lines

Add the missing call to free described in issue #8268.  Also, add a bunch of
missing calls to free in callerid_feed_jp().

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@46884 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerged revisions 46857 via svnmerge from
Russell Bryant [Wed, 1 Nov 2006 23:04:14 +0000 (23:04 +0000)]
Merged revisions 46857 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r46857 | russell | 2006-11-01 18:01:48 -0500 (Wed, 01 Nov 2006) | 2 lines

fix saying one hundred and two hundred in hebrew (issue #7810, eldadran)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@46863 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoAdd a couple of things to the CHANGES file
Russell Bryant [Wed, 1 Nov 2006 22:58:34 +0000 (22:58 +0000)]
Add a couple of things to the CHANGES file

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@46849 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerged revisions 46847 via svnmerge from
Russell Bryant [Wed, 1 Nov 2006 22:54:15 +0000 (22:54 +0000)]
Merged revisions 46847 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r46847 | russell | 2006-11-01 17:51:21 -0500 (Wed, 01 Nov 2006) | 3 lines

Fixes for cross-compilation on mips
(issue #8058, ywalther, with some modifications)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@46848 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerged revisions 46845 via svnmerge from
Russell Bryant [Wed, 1 Nov 2006 22:35:52 +0000 (22:35 +0000)]
Merged revisions 46845 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r46845 | russell | 2006-11-01 17:32:12 -0500 (Wed, 01 Nov 2006) | 5 lines

Add a check in the configure script to determine whether ld is GNU ld or not.
This is needed because module embedding only works for gnu ld.  GNU ld is now
listed as a dependency for all of the module embedding options in menuselect.
(issue #8143)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@46846 65c4cc65-6c06-0410-ace0-fbb531ad65f3