asterisk/asterisk.git
9 years agoChange needed to make Mac OS X 10.6 happy
Tilghman Lesher [Mon, 8 Mar 2010 05:12:55 +0000 (05:12 +0000)]
Change needed to make Mac OS X 10.6 happy

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@251262 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoClean transmit_* for start/stop media transmission
Michiel van Baak [Sun, 7 Mar 2010 14:53:06 +0000 (14:53 +0000)]
Clean transmit_* for start/stop media transmission

Small patch changing skinny_set_rtp_peer to use transmit_stopmediatransmission and to use new transmit_startmediatransmission.
Basic testing on 30VIP's by wedhorn
Basic testing on 7960 by me

(closes issue #16956)
Reported by: wedhorn
Patches:
      skinny-clean05b.diff uploaded by wedhorn (license 30)
Tested by: wedhorn,mvanbaak

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@251222 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoCleanup transmit_callstate handling
Michiel van Baak [Sun, 7 Mar 2010 14:46:29 +0000 (14:46 +0000)]
Cleanup transmit_callstate handling

Broke the various functions included in transmit_callstate to their own functions. Transmit_callstate now just transmits callstate.

Generally left the functionality as it was, which highlight some minor code issues (eg multiple transmit_callstate's). I did however revise the hint code usage of the old transmit_callstate as it it not appropriate to put a device on hook based on the change of a hinted device.

(closes issue #16939)
Reported by: wedhorn
Patches:
      skinny-clean04.diff uploaded by wedhorn (license 30)
Tested by: mvanbaak,wedhorn

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@251221 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agosmall log issue from bug 0016664
Alexandr Anikin [Sun, 7 Mar 2010 00:45:35 +0000 (00:45 +0000)]
small log issue from bug 0016664

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@251181 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoFix a crash in SIP blind transfer handling found by an automated external test.
Russell Bryant [Sat, 6 Mar 2010 14:16:20 +0000 (14:16 +0000)]
Fix a crash in SIP blind transfer handling found by an automated external test.

The first real test added to the external test suite found a pretty nasty crash
that occurred in Asterisk trunk.  The crash was due to a race condition between
the REFER handling and channel destruction in the channel thread.  After the
transfer has been completed, we go back to the transferrer channel and try to
lock it so we can fire off a CEL event.  However, there was no guarantee that
the channel was still around at that point since it's racing against the channel
thread.

Since ast_channel is a reference counted object, the fix is simple.  The code
unlocks the transferrer channel before finally completing the transfer with
an async goto.  At this point the channel thread is going to start call tear
down and the channel will eventually be destroyed.  To ensure that the channel
is valid when we want to fire off the CEL event, increase the channel's
reference count.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@251137 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agofixes xml error in func_pitchshift
David Vossel [Fri, 5 Mar 2010 21:51:25 +0000 (21:51 +0000)]
fixes xml error in func_pitchshift

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@251087 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoPITCH_SHIFT dialplan function
David Vossel [Fri, 5 Mar 2010 20:21:13 +0000 (20:21 +0000)]
PITCH_SHIFT dialplan function

The PITCH_SHIFT function can be used on a channel to independently
modify the pitch of both rx and tx audio streams.  Now you can
improve your conference calls by assigning a random pitch effect
to everyone entering a meetme room, or just make your day more
interesting by making your co-workers sound funny.  These are just
some of the numerious practical uses for this function. Enjoy!

https://reviewboard.asterisk.org/r/526/

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@251038 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoRemove pbx_gtkconsole and related gtk1 checks.
Russell Bryant [Fri, 5 Mar 2010 19:32:19 +0000 (19:32 +0000)]
Remove pbx_gtkconsole and related gtk1 checks.

Review: https://reviewboard.asterisk.org/r/541/

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@251022 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoFix app_followme playing wrong sound files.
Jeff Peeler [Fri, 5 Mar 2010 19:10:47 +0000 (19:10 +0000)]
Fix app_followme playing wrong sound files.

Fixes regression introduced in 140167 that uses the wrong variable names.

(closes issue #16930)
Reported by: ianc
Patches:
      fix_reload_followme.diff uploaded by ianc (license 998)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@250979 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoFix up some of chan_sip's usage of the RTP engine API.
Russell Bryant [Fri, 5 Mar 2010 05:03:41 +0000 (05:03 +0000)]
Fix up some of chan_sip's usage of the RTP engine API.

The get_local_address() function for an RTP instance was used when building an
SDP, but the results were not honored.  The RTP engine activate() function was
not being used once we have determined that media will now flow.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@250917 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMissing quote in ODBC query.
Tilghman Lesher [Fri, 5 Mar 2010 04:37:36 +0000 (04:37 +0000)]
Missing quote in ODBC query.

(closes issue #16953)
 Reported by: elguero
 Patches:
       app_voicemail-odbc-syntax-fix.diff uploaded by elguero (license 37)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@250913 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoFix up the ast_rtp_property enum.
Russell Bryant [Fri, 5 Mar 2010 02:07:33 +0000 (02:07 +0000)]
Fix up the ast_rtp_property enum.

The mis-placement of the latest entry meant that when it was set, it was writing
one index past the end of the properties array in the ast_rtp_instance (which
happened to be the local_address field).

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@250871 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 250786 via svnmerge from
Jeff Peeler [Fri, 5 Mar 2010 01:05:46 +0000 (01:05 +0000)]
Merged revisions 250786 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r250786 | jpeeler | 2010-03-04 19:02:58 -0600 (Thu, 04 Mar 2010) | 9 lines

  Fix not being able to specify a URL in MOH class directory.

  Don't attempt to chdir on a URL!

  (closes issue #16875)
  Reported by: raarts
  Patches:
        moh-http.patch uploaded by raarts (license 937)
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@250787 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoAdjust XML for func_channel to indicate that rtpdest can take a "text" argument.
Mark Michelson [Thu, 4 Mar 2010 20:12:26 +0000 (20:12 +0000)]
Adjust XML for func_channel to indicate that rtpdest can take a "text" argument.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@250730 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoRecorded merge of revisions 250613 via svnmerge from
Leif Madsen [Wed, 3 Mar 2010 21:28:31 +0000 (21:28 +0000)]
Recorded merge of revisions 250613 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r250613 | lmadsen | 2010-03-03 16:28:02 -0500 (Wed, 03 Mar 2010) | 11 lines

  Update existing Local channel documentation.

  A complete re-write of the Local channel documentation has been performed, with
  the existing information from localchannel.txt and localchannel.tex merged in.

  (issue #16637)
  Reported by: kobaz
  Patches:
        localchannel.tex uploaded by lmadsen (license 10)
        localchannel.txt uploaded by lmadsen (license 10)
  Tested by: lmadsen, jsmith, mmichelson
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@250614 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoUpdate existing Local channel documentation.
Leif Madsen [Wed, 3 Mar 2010 21:22:55 +0000 (21:22 +0000)]
Update existing Local channel documentation.

A complete re-write of the Local channel documentation has been performed, with
the existing information from localchannel.txt and localchannel.tex merged in.

(closes issue #16637)
Reported by: kobaz
Patches:
      localchannel.tex uploaded by lmadsen (license 10)
      localchannel.txt uploaded by lmadsen (license 10)
Tested by: lmadsen, jsmith, mmichelson

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@250609 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoRemoved cdrflags from ast_channel structure.
Richard Mudgett [Wed, 3 Mar 2010 19:38:06 +0000 (19:38 +0000)]
Removed cdrflags from ast_channel structure.

Only chan_dahdi set a value in cdrflags.  Everyone else just copied it
around the system.  Noone cared about any value it may have contained.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@250565 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 250480 via svnmerge from
Jeff Peeler [Wed, 3 Mar 2010 19:06:06 +0000 (19:06 +0000)]
Merged revisions 250480 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r250480 | jpeeler | 2010-03-03 13:04:11 -0600 (Wed, 03 Mar 2010) | 15 lines

  Make sure to clear red alarm after polarity reversal.

  From the issue:
  The automatic overnight line tests (or manual ones) used on UK (BT) lines causes
  a red alarm on a dahdi / TDM400P connected channel. This is because the line
  uses voltage tests (battery loss) and polarity reversal. The polarity reversal
  causes chan_dahdi to initiate v23 CallerID processing but during this the event
  DAHDI_EVENT_NOALARM is ignored so that the alarm is never cleared.

  (closes issue #14163)
  Reported by: jedi98
  Patches:
        chan_dahdi-1.4-inalarm.diff uploaded by jedi98 (license 653)
  Tested by: mattbrown, Chainsaw, mikeeccleston
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@250481 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoChanges 0ms to <1ms in cli END results during 'test execute'
David Vossel [Wed, 3 Mar 2010 19:02:13 +0000 (19:02 +0000)]
Changes 0ms to <1ms in cli END results during 'test execute'

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@250478 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 250394 via svnmerge from
David Vossel [Wed, 3 Mar 2010 18:03:19 +0000 (18:03 +0000)]
Merged revisions 250394 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r250394 | dvossel | 2010-03-03 12:02:27 -0600 (Wed, 03 Mar 2010) | 16 lines

  fixes problem with duplicate TXREQ packets

  When Asterisk receives an IAX2 TXREQ packet, try_transfer()
  will call store_by_transfercallno() to link the chan_iax2_pvt
  struct into iax_transfercallno_pvts. If a duplicate TXREQ
  packet is received for the same call, the pvt struct will be
  linked into iax_transfercallno_pvts multiple times.  This patch
  fixes this.  Thanks rain for debugging this and providing a patch!

  (closes issue #16904)
  Reported by: rain
  Patches:
        iax2-double-txreq-fix.diff uploaded by rain (license 327)
  Tested by: rain, dvossel
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@250395 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoAdd new config option to control AMI alarm event reporting in chan_dahdi.
Jeff Peeler [Wed, 3 Mar 2010 17:37:30 +0000 (17:37 +0000)]
Add new config option to control AMI alarm event reporting in chan_dahdi.

New config parameter "reportalarms" added in chan_dahdi.conf which supports the
following possible values:
"channels": report each channel alarms (current behavior, default for backward compatibility)
"spans": report an "SpanAlarm" event when the span of any configured channel is alarmed
"all": report channel and span alarms (aggregated behavior)
"none": do not report any alarms

(closes issue #16709)
Reported by: nahuelgreco
Patches:
      chan_dahdi.c.reportalarms.patch uploaded by nahuelgreco (license 162)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@250392 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoOne more fix to editline
Tilghman Lesher [Wed, 3 Mar 2010 16:43:10 +0000 (16:43 +0000)]
One more fix to editline

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@250346 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoEliminate remaining libedit warnings (shown in bamboo)
Tilghman Lesher [Wed, 3 Mar 2010 15:54:28 +0000 (15:54 +0000)]
Eliminate remaining libedit warnings (shown in bamboo)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@250303 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoUpdated CHANGES file to mention res_fax and res_fax_spandsp.
Matthew Nicholson [Wed, 3 Mar 2010 15:39:45 +0000 (15:39 +0000)]
Updated CHANGES file to mention res_fax and res_fax_spandsp.

Also fixed MODULEINFO depends and conflicts for app_fax, res_fax, and res_fax_spandsp.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@250302 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agofixes signed to unsigned int comparision issue for FaxMaxDatagram value.
David Vossel [Wed, 3 Mar 2010 00:18:28 +0000 (00:18 +0000)]
fixes signed to unsigned int comparision issue for FaxMaxDatagram value.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@250246 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agofixes assumption that test failed if it did not pass when generating results
David Vossel [Wed, 3 Mar 2010 00:04:28 +0000 (00:04 +0000)]
fixes assumption that test failed if it did not pass when generating results

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@250237 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agobase64 unit test
David Vossel [Tue, 2 Mar 2010 23:38:29 +0000 (23:38 +0000)]
base64 unit test

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@250235 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerge missed files from res_fax/res_fax_spandsp merge.
Matthew Nicholson [Tue, 2 Mar 2010 23:22:11 +0000 (23:22 +0000)]
Merge missed files from res_fax/res_fax_spandsp merge.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@250213 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerge res_fax and res_fax_spandsp.
Matthew Nicholson [Tue, 2 Mar 2010 23:11:06 +0000 (23:11 +0000)]
Merge res_fax and res_fax_spandsp.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@250190 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoadds 'p' option to PickupChan
David Vossel [Tue, 2 Mar 2010 21:58:03 +0000 (21:58 +0000)]
adds 'p' option to PickupChan

The 'p' option allows the PickupChan app to pickup
a ringing phone by looking for the first match to a
partial channel name rather than requiring a full match.

(closes issue #16613)
Reported by: syspert
Patches:
      pickipbycallid.patch uploaded by syspert (license 938)
      pickupbycallerid_v2.patch uploaded by dvossel (license 671)
Tested by: dvossel, syspert

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@250141 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoUpdate IMAP documentation.
Leif Madsen [Tue, 2 Mar 2010 21:09:27 +0000 (21:09 +0000)]
Update IMAP documentation.
Update the IMAP documentation to make it clear that storing voicemails
in the same folder as a large number of emails could potentially cause
significant slow downs when writing or retrieving voicemails.

(issue #16704)
Reported by: TimeHider
Tested by: lmadsen, TimeHider

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@250051 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 250043 via svnmerge from
Leif Madsen [Tue, 2 Mar 2010 20:52:19 +0000 (20:52 +0000)]
Merged revisions 250043 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r250043 | lmadsen | 2010-03-02 15:51:35 -0500 (Tue, 02 Mar 2010) | 7 lines

  Update documentation to clarify purpose of unanswered option.

  (closes issue #16267)
  Reported by: elsto
  Patches:
        cdr.conf.sample.patch.txt uploaded by lmadsen (license 10)
  Tested by: davidw, elsto
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@250045 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoRecorded merge of revisions 250041 via svnmerge from
Leif Madsen [Tue, 2 Mar 2010 20:46:52 +0000 (20:46 +0000)]
Recorded merge of revisions 250041 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r250041 | lmadsen | 2010-03-02 15:45:37 -0500 (Tue, 02 Mar 2010) | 4 lines

  Update documentation to not imply we support overriding options.

  (issue #16855)
  Reported by: davidw
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@250042 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoUpdate documentation to not imply we support overriding options.
Leif Madsen [Tue, 2 Mar 2010 20:36:10 +0000 (20:36 +0000)]
Update documentation to not imply we support overriding options.

(closes issue #16855)
Reported by: davidw

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@250037 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoFix literal values wrapped in documentation.
Leif Madsen [Tue, 2 Mar 2010 19:49:48 +0000 (19:49 +0000)]
Fix literal values wrapped in documentation.

(closes issue #16145)
Reported by: tilghman

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@249950 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agorevert ability to exit echo app
Alec L Davis [Tue, 2 Mar 2010 19:39:58 +0000 (19:39 +0000)]
revert ability to exit echo app

caused a regression, as only supported VOICE, not VIDEO etc.

(issue #16880)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@249947 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoAdd missing description of the PARKINGLOT variable in XML documentation.
Leif Madsen [Tue, 2 Mar 2010 19:24:43 +0000 (19:24 +0000)]
Add missing description of the PARKINGLOT variable in XML documentation.

(closes issue #16743)
Reported by: snuffy
Patches:
      parkingdoc.diff uploaded by snuffy (license 35)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@249925 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoConvert some DUNDI functions to XML documentation.
Leif Madsen [Tue, 2 Mar 2010 19:21:19 +0000 (19:21 +0000)]
Convert some DUNDI functions to XML documentation.

(closes issue #16798)
Reported by: snuffy
Patches:
      xml_dundi.diff uploaded by snuffy (license 35)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@249912 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agofixes adaptive jitterbuffer configuration
David Vossel [Tue, 2 Mar 2010 19:08:38 +0000 (19:08 +0000)]
fixes adaptive jitterbuffer configuration

When configuring the adaptive jitterbuffer, the target_extra
value not only could not be set from the configuration, but was
not even being set to its proper default.  This value is required
in order for the adaptive jitterbuffer to work correctly.  To resolve
this a config option has been added to expose this value to the conf
files, and a default value is provided when no config specific value
is present.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@249893 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoFix several XML documentation validate errors.
Leif Madsen [Tue, 2 Mar 2010 19:02:56 +0000 (19:02 +0000)]
Fix several XML documentation validate errors.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@249892 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agofix build by checking result of symlink in test_voicemail_vmsayname
Jeff Peeler [Tue, 2 Mar 2010 18:31:05 +0000 (18:31 +0000)]
fix build by checking result of symlink in test_voicemail_vmsayname

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@249891 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoAdd new application VMSayName for use with voicemail.
Jeff Peeler [Tue, 2 Mar 2010 18:22:05 +0000 (18:22 +0000)]
Add new application VMSayName for use with voicemail.

VMSayName that will play the recorded name of the voicemail user if it exists,
otherwise will play the mailbox number. A unit test has been written to verify
correct functionality called test_voicemail_vmsayname.

(closes issue #14973)
Reported by: ghjm

Review: https://reviewboard.asterisk.org/r/530/

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@249889 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agofixes ability to exit echo app
Alec L Davis [Tue, 2 Mar 2010 07:38:56 +0000 (07:38 +0000)]
fixes ability to exit echo app

when called from a ISDN channel, null frames prevent '#' exit.
Now only echo back VOICE and DTMF frames

(issue #16880)
Reported by: alecdavis
Patches:
      echo_exit.diff.txt uploaded by alecdavis (license 585)
Tested by: alecdavis

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@249801 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agofix asterisk setting of pritimers from chan_dahdi.conf
Alec L Davis [Tue, 2 Mar 2010 06:56:14 +0000 (06:56 +0000)]
fix asterisk setting of pritimers from chan_dahdi.conf

regression since sig_pri split.

(issue #16909)
Reported by: alecdavis
Patches:
      pritimer.asterisk.diff.txt uploaded by alecdavis (license 585)
Tested by: alecdavis

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@249759 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 249671 via svnmerge from
Sean Bright [Mon, 1 Mar 2010 19:36:30 +0000 (19:36 +0000)]
Merged revisions 249671 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r249671 | seanbright | 2010-03-01 14:35:01 -0500 (Mon, 01 Mar 2010) | 11 lines

  Fix crash in app_voicemail related to message counting.

  We were passing a 'struct inprocess **' and treating it like a 'struct inprocess *'
  causing a segfault.

  (closes issue #16921)
  Reported by: whardier
  Patches:
        20100301_issue16921.patch uploaded by seanbright (license 71)
  Tested by: whardier
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@249672 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoCleanup display_*message functions.
Michiel van Baak [Mon, 1 Mar 2010 19:33:26 +0000 (19:33 +0000)]
Cleanup display_*message functions.

This patch splits transmit_displaymessage into transmit_clear_display_message and transmit_display_message which better aligns with the skinny protocol. The new transmit_display_message is not used in the current code, but will be and so it is commented.

Moved handle_datetime from this function to onhook and offhook functions (display now properly cleared at the end of a call on 30VIP).

Removed skinny debug messages from inline code as there's an ast_verb in transmit_clear_display_message. Also, removed commentary that it was a clear display as it is now apparent from the function name.

Split transmit_displaypromptmessage into display and clear.

(closes issue #16878)
Reported by: wedhorn
Patches:
skinny-clean02.diff uploaded by wedhorn (license 30)
skinny-clean03.diff uploaded by wedhorn (license 30)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@249670 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agofix endianes issues in chan_skinny
Michiel van Baak [Mon, 1 Mar 2010 19:27:34 +0000 (19:27 +0000)]
fix endianes issues in chan_skinny

(closes issue #16826)
Reported by: PipoCanaja
Patches:
      chan_skinny.c_bigendianPatch_20100218.diff uploaded by PipoCanaja (license 994)
Tested by: wedhorn

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@249669 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoConstify a bit of app_voicemail, to make ODBC and IMAP compile once again.
Tilghman Lesher [Mon, 1 Mar 2010 18:36:06 +0000 (18:36 +0000)]
Constify a bit of app_voicemail, to make ODBC and IMAP compile once again.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@249623 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 249536 via svnmerge from
Jeff Peeler [Mon, 1 Mar 2010 17:11:31 +0000 (17:11 +0000)]
Merged revisions 249536 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r249536 | jpeeler | 2010-03-01 11:02:03 -0600 (Mon, 01 Mar 2010) | 11 lines

  Modify queued frames from local channels to not set the other side to up

  In this case, attended transfers were broken due to ast_feature_request_and_dial
  detecting the channel being set to up before the answer frame could be read and
  therefore failing to mark the channel as ready. This fix is a regression fix for
  244785, which should continue to work properly as well.

  (closes issue #16816)
  Reported by: jamhed
  Tested by: jamhed, corruptor
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@249538 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoFix unit test that Alec Davis broke.
Tilghman Lesher [Sun, 28 Feb 2010 20:50:01 +0000 (20:50 +0000)]
Fix unit test that Alec Davis broke.

(closes issue #16927)
 Reported by: alecdavis

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@249491 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agomake unit test check for NULL folder, which then defaults to INBOX
Alec L Davis [Sun, 28 Feb 2010 16:36:45 +0000 (16:36 +0000)]
make unit test check for NULL folder, which then defaults to INBOX

previous test, gave false level of assurance that code was healthy.

(issue #16927)
Reported by: alecdavis
Patches:
      based on app_voicemail_test.diff.txt uploaded by alecdavis (license 585)

Tested by: alecdavis

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@249449 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoProperly document voicemail API documents. Also fix a crash reported via the -dev...
Tilghman Lesher [Sun, 28 Feb 2010 07:10:22 +0000 (07:10 +0000)]
Properly document voicemail API documents.  Also fix a crash reported via the -dev list.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@249405 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agooverlap receiving: automatically send CALL PROCEEDING when dialplan starts
Alec L Davis [Sat, 27 Feb 2010 22:49:51 +0000 (22:49 +0000)]
overlap receiving: automatically send CALL PROCEEDING when dialplan starts

Following Q.931 5.2.4
When the user has determined that sufficient call information has been received the
user shall stop T302 and send CALL PROCEEDING to the network.

Previously timeouts were possible if the dialplan took a long time to issue any
response back to the network.

Verified that our local TELCO also does the same.

(issue #16789)
Reported by: alecdavis
Patches:
      overlap_receiving_trunk.diff.txt uploaded by alecdavis (license 585)
Tested by: alecdavis

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@249320 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 249234 via svnmerge from
Kevin P. Fleming [Sat, 27 Feb 2010 14:08:35 +0000 (14:08 +0000)]
Merged revisions 249234 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r249234 | kpfleming | 2010-02-27 09:07:59 -0500 (Sat, 27 Feb 2010) | 1 line

  add a reference to the now-published IAX2 RFC
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@249235 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoCleanups to fix bugs in the VM count API functions.
Tilghman Lesher [Fri, 26 Feb 2010 18:41:57 +0000 (18:41 +0000)]
Cleanups to fix bugs in the VM count API functions.

- Urgent voicemails were not attached, because the attachment code looked in the wrong folder.
- Urgent voicemails were sometimes counted twice when displaying the count of new messages.
- Backends were inconsistent as to which voicemails each API counted.
- Unit tests added to verify behavior in the future.

(closes issue #15654)
 Reported by: tomo1657
 Patches:
       20100225__issue15654.diff.txt uploaded by tilghman (license 14)
 Tested by: tilghman

(closes issue #16448)
 Reported by: hevad

Review: https://reviewboard.asterisk.org/r/525/

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@249187 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoadds Time field to "test show results" cli command
David Vossel [Fri, 26 Feb 2010 18:41:36 +0000 (18:41 +0000)]
adds Time field to "test show results" cli command

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@249186 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoSend a manager event when the manager BridgeAction command is used.
Mark Michelson [Fri, 26 Feb 2010 17:13:36 +0000 (17:13 +0000)]
Send a manager event when the manager BridgeAction command is used.

(closes issue #16769)
Reported by: syspert
Patches:
      bridgeaction.patch uploaded by syspert (license 938)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@249105 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 249100 via svnmerge from
Mark Michelson [Fri, 26 Feb 2010 17:04:58 +0000 (17:04 +0000)]
Merged revisions 249100 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r249100 | mmichelson | 2010-02-26 11:04:29 -0600 (Fri, 26 Feb 2010) | 8 lines

  For T.38 reINVITEs treat a 606 the same as a 488.

  (closes issue #16792)
  Reported by: vrban
  Patches:
        t38_606.patch uploaded by vrban (license 756)
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@249101 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoformatting tweaks and constification
Russell Bryant [Fri, 26 Feb 2010 08:45:11 +0000 (08:45 +0000)]
formatting tweaks and constification

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@249058 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoTrim trailing whitespace (to help reduce diff against cdr-q branch)
Russell Bryant [Fri, 26 Feb 2010 08:35:42 +0000 (08:35 +0000)]
Trim trailing whitespace (to help reduce diff against cdr-q branch)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@249056 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoTrim trailing whitespace, convert lists of defines to enums
Russell Bryant [Fri, 26 Feb 2010 08:26:10 +0000 (08:26 +0000)]
Trim trailing whitespace, convert lists of defines to enums

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@249050 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agotrivial formatting tweak (working on reducing diff against trunk for cdr-q)
Russell Bryant [Fri, 26 Feb 2010 08:08:38 +0000 (08:08 +0000)]
trivial formatting tweak (working on reducing diff against trunk for cdr-q)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@249013 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoremove include
Russell Bryant [Fri, 26 Feb 2010 08:07:27 +0000 (08:07 +0000)]
remove include

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@249012 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoconstification, remove include
Russell Bryant [Fri, 26 Feb 2010 08:07:09 +0000 (08:07 +0000)]
constification, remove include

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@249011 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoRemove unnecessary includes, formatting tweak
Russell Bryant [Fri, 26 Feb 2010 08:05:36 +0000 (08:05 +0000)]
Remove unnecessary includes, formatting tweak

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@249010 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoconstification and remove unnecessary include
Russell Bryant [Fri, 26 Feb 2010 08:04:07 +0000 (08:04 +0000)]
constification and remove unnecessary include

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@249009 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 248860 via svnmerge from
Jeff Peeler [Thu, 25 Feb 2010 23:09:54 +0000 (23:09 +0000)]
Merged revisions 248860 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r248860 | jpeeler | 2010-02-25 15:22:06 -0600 (Thu, 25 Feb 2010) | 18 lines

  Ensure that monitor recordings are written to the correct location (again)

  This is an extension to 248757. As such the dialplan test has been extended:

  exten => 5040, 1, monitor(wav,tmp/jeff/monitor_test,b)
  exten => 5040, n, dial(sip/5001)
  exten => 5041, 1, monitor(wav,/tmp/jeff/monitor_test2,b)
  exten => 5041, n, dial(sip/5001)
  exten => 5042, 1, monitor(wav,monitor_test3,b)
  exten => 5042, n, dial(sip/5001)
  exten => 5043, 1, monitor(wav,tmp/jeff/monitor_test3,m)
  exten => 5043, n, changemonitor(monitor_test4)
  exten => 5043, n, dial(sip/5001)
  exten => 5044, 1, monitor(wav,monitor_test4,m)
  exten => 5044, n, changemonitor(tmp/jeff/monitor_test5) ; this looks to fail by design and emits a warning
  exten => 5044, n, dial(sip/5001)
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@248952 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoFix incorrect ACL behavior when CIDR notation of "/0" is used.
Mark Michelson [Thu, 25 Feb 2010 22:41:48 +0000 (22:41 +0000)]
Fix incorrect ACL behavior when CIDR notation of "/0" is used.

AST-2010-003

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@248946 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 248859 via svnmerge from
Tilghman Lesher [Thu, 25 Feb 2010 21:22:39 +0000 (21:22 +0000)]
Merged revisions 248859 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r248859 | tilghman | 2010-02-25 15:21:05 -0600 (Thu, 25 Feb 2010) | 15 lines

  Some platforms clear /var/run at boot, which makes connecting a remote console... difficult.

  Previously, we only created the default /var/run/asterisk directory at install
  time.  While we could create it in the init script, that would not work for
  those who start asterisk manually from the command line.  So the safest thing
  to do is to create it as part of the Asterisk boot process.  This also changes
  the ownership of the directory, because the pid and ctl files are created after
  we setuid/setgid.

  (closes issue #16802)
   Reported by: Brian
   Patches:
         20100224__issue16802.diff.txt uploaded by tilghman (license 14)
   Tested by: tzafrir
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@248861 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 248757 via svnmerge from
Jeff Peeler [Thu, 25 Feb 2010 18:37:56 +0000 (18:37 +0000)]
Merged revisions 248757 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r248757 | jpeeler | 2010-02-25 12:06:54 -0600 (Thu, 25 Feb 2010) | 15 lines

  Ensure that monitor recordings are written to the correct location.

  Recordings should be placed in the monitor directory when a non-absolute path
  is used.

  Exact dialplan used for testing:
  exten => 5040, 1, monitor(wav,tmp/jeff/monitor_test,b)
  exten => 5040, n, dial(sip/5001)
  exten => 5041, 1, monitor(wav,/tmp/jeff/monitor_test2,b)
  exten => 5041, n, dial(sip/5001)
  exten => 5042, 1, monitor(wav,monitor_test3,b)
  exten => 5042, n, dial(sip/5001)

  ABE-2101
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@248793 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoBlocked revisions 248668 via svnmerge
Jeff Peeler [Wed, 24 Feb 2010 23:00:40 +0000 (23:00 +0000)]
Blocked revisions 248668 via svnmerge

........
  r248668 | jpeeler | 2010-02-24 16:58:54 -0600 (Wed, 24 Feb 2010) | 8 lines

  Make deletion of temporary greetings work properly with IMAP_STORAGE

  This same patch was merged in 220833, but was skipped in this branch
  erroneously.

  (closes issue #16170)
  Reported by: francesco_r
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@248671 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoAlso kill the .i files, or else the build process will not recreate them, when we
Tilghman Lesher [Wed, 24 Feb 2010 22:44:55 +0000 (22:44 +0000)]
Also kill the .i files, or else the build process will not recreate them, when we
change flags.  Fixes a weird symbol problem mmichelson was having in a group branch,
but also applies to trunk.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@248667 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 248582 via svnmerge from
Tilghman Lesher [Wed, 24 Feb 2010 21:17:26 +0000 (21:17 +0000)]
Merged revisions 248582 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r248582 | tilghman | 2010-02-24 15:02:18 -0600 (Wed, 24 Feb 2010) | 7 lines

  Remove color code sequences from verbose messages that go to logfiles.
  (closes issue #16786)
   Reported by: dodo
   Patches:
         logger2.patch uploaded by dodo (license 989)
   Tested by: tilghman
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@248584 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoRemove unnecessary warning message, make a couple of formatting tweaks
Russell Bryant [Wed, 24 Feb 2010 06:39:27 +0000 (06:39 +0000)]
Remove unnecessary warning message, make a couple of formatting tweaks

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@248534 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoAdd ASTERISK_FILE_VERSION macro.
Russell Bryant [Wed, 24 Feb 2010 06:38:10 +0000 (06:38 +0000)]
Add ASTERISK_FILE_VERSION macro.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@248533 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoUnit test for ast_str API.
Mark Michelson [Tue, 23 Feb 2010 22:29:06 +0000 (22:29 +0000)]
Unit test for ast_str API.

Review: https://reviewboard.asterisk.org/r/517

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@248489 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 248396 via svnmerge from
David Vossel [Tue, 23 Feb 2010 16:34:39 +0000 (16:34 +0000)]
Merged revisions 248396 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r248396 | dvossel | 2010-02-23 10:26:05 -0600 (Tue, 23 Feb 2010) | 9 lines

  fixes invite with replaces deadlock

  (closes issue #16862)
  Reported by: pwalker
  Patches:
        replaces_deadlock_1.4 uploaded by dvossel (license 671)
  Tested by: pwalker, dvossel
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@248397 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMove the REF_DEBUG comment higher in the include list.
Mark Michelson [Mon, 22 Feb 2010 20:19:00 +0000 (20:19 +0000)]
Move the REF_DEBUG comment higher in the include list.

Uncommenting the REF_DEBUG definition where it was in the source
resulted in only a small part of the astobj2 references being logged
to a file. Moving this up higher in the include list causes all references
to be logged as they should be.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@248347 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoBlocked revisions 248268 via svnmerge
Olle Johansson [Mon, 22 Feb 2010 13:55:24 +0000 (13:55 +0000)]
Blocked revisions 248268 via svnmerge

........
  r248268 | oej | 2010-02-22 14:52:34 +0100 (Mån, 22 Feb 2010) | 2 lines

  Don't log to debug unless debug is turned on
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@248269 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMinor tweaks to comment blocks and includes.
Russell Bryant [Mon, 22 Feb 2010 06:45:52 +0000 (06:45 +0000)]
Minor tweaks to comment blocks and includes.

Fix the copyright lines, tweak doxygen formatting, and remove some unnecessary
includes.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@248226 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoTweak copyright and author lines.
Russell Bryant [Mon, 22 Feb 2010 06:43:02 +0000 (06:43 +0000)]
Tweak copyright and author lines.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@248225 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoCleanup transmit_* functions, part 1
Michiel van Baak [Sun, 21 Feb 2010 12:09:53 +0000 (12:09 +0000)]
Cleanup transmit_* functions, part 1

Break transmit_tone into transmit_start_tone and transmit_stop_tone as per the skinny protocol.

(closes issue #16874)
Reported by: wedhorn
Patches:
      skinny-clean01.diff uploaded by wedhorn (license 30)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@248184 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoImprove support for RTCP reports without report blocks
Olle Johansson [Sat, 20 Feb 2010 22:37:22 +0000 (22:37 +0000)]
Improve support for RTCP reports without report blocks

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@248108 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoBlocked revisions 248106 via svnmerge
Olle Johansson [Sat, 20 Feb 2010 22:29:50 +0000 (22:29 +0000)]
Blocked revisions 248106 via svnmerge

........
r248106 | oej | 2010-02-20 23:25:42 +0100 (Lör, 20 Feb 2010) | 2 lines

Make sure we support RTCP compound messages with zero reports

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@248107 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agomfcr2 issue 0016844 - Fix portability bit fields and make mfcr2_immediate_accept...
Moises Silva [Fri, 19 Feb 2010 18:38:34 +0000 (18:38 +0000)]
mfcr2 issue 0016844 - Fix portability bit fields and make mfcr2_immediate_accept work again, reported and patched by korihor

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@248003 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agohandle_request_invite revise comment, fix coding guideline issues
David Vossel [Fri, 19 Feb 2010 17:40:26 +0000 (17:40 +0000)]
handle_request_invite revise comment, fix coding guideline issues

I'm working with this code right now trying to analyze a deadlock.
This change is just to clean up a few things before I make a more
complex patch.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@247915 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 247910 via svnmerge from
Richard Mudgett [Fri, 19 Feb 2010 17:33:33 +0000 (17:33 +0000)]
Merged revisions 247910 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
  r247910 | rmudgett | 2010-02-19 11:18:49 -0600 (Fri, 19 Feb 2010) | 55 lines

  Merged revision 247904 from
  https://origsvn.digium.com/svn/asterisk/be/branches/C.2-...

  ..........
  r247904 | rmudgett | 2010-02-19 10:49:44 -0600 (Fri, 19 Feb 2010) | 49 lines

  Make chan_misdn DTMF processing consistent with other channel technologies.

  The processing of DTMF tones on the receiving side of an ISDN channel is
  inconsistent with the way it is handled in other channels, especially
  DAHDI analog.  This causes DTMF tones sent from an ISDN phone to be
  doubled at the connected party.

  We are using the following 2 options of misdn.conf
  1) astdtmf=yes
  2) senddtmf=yes

  Option one is necessary because the asterisk DSP DTMF detection is better
  than mISDN's internal DSP.  Not as many false positives.

  Option two is necessary to transmit DTMF tones end to end when mISDN
  channels are connected to SIP channels with out of band DTMF for example.

  The symptom is that DTMF tones sent by an ISDN phone are doubled on the
  way through asterisk when two mISDN channels are connected with a Local
  channel in between or if it is bridged to an analog channel.

  The doubling of DTMF tones is because DTMF is passed inband to asterisk by
  the mISDN channel and passed out of band once again after the release of
  the DTMF tone.  Passing it inband is wrong.  Neither an analog channel nor
  SIP channel passes DTMF inband if configured to inband DTMF.  Analog and
  SIP channels filter out the DTMF tones because they use the voice frames
  returned by ast_dsp_process.  But chan_misdn passes the unfiltered input
  voice frames instead.

  To overcome one aspect of the problem, the doubling of DTMF tones when two
  mISDN channels are directly bridged, someone made an 'optimization', where
  in that case the DTMF tone passed out-of-band to the peer channel is not
  translated to an inband tone at the transmit side.  This optimization is
  bad because it does not work in general.  For example, analog channels or
  mISDN channels when bridged through an intermediary local channel will
  generate DTMF tones from out-of-band information.  Also, of course, it
  must not be done when there is no inband DTMF available.

  This patch fixes the issue.  Now chan_misdn will filter the received
  inband DTMF signal the same as other channel types.

  Another change included: No need to build an extra translation path
  because ast_process_dsp does it if required.

  Patches:
   misdn-dtmf.patch

  JIRA ABE-2080
................

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@247914 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoRevert an errant part of a previous cleanup, to fix a memory corruption issue.
Tilghman Lesher [Thu, 18 Feb 2010 23:13:46 +0000 (23:13 +0000)]
Revert an errant part of a previous cleanup, to fix a memory corruption issue.

(closes issue #16368)
 Reported by: thirionjwf
 Patches:
       res_speech.c.patch uploaded by thirionjwf (license 955)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@247841 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoIf the peer record is from realtime, it could be set to 0, due to MySQL not represent...
Tilghman Lesher [Thu, 18 Feb 2010 21:42:53 +0000 (21:42 +0000)]
If the peer record is from realtime, it could be set to 0, due to MySQL not representing NULL well in integer columns.

NULL means the value is not specified for the column, which normally means
the driver uses whatever is the default value.  However, on MySQL, placing
a NULL in either a float or integer column results in a retrieval of the 0
value.  Hence, users get an errant error on load.  This patch suppresses
that error and makes the value as if it was not there.

Note that this cannot be done in the realtime driver, because the lack of
difference between NULL and 0 can only be intepreted correctly by the
driver itself.  If we did it in the realtime driver, then it would be
effectively impossible to set any realtime field to 0, because it would act
as if the field were unspecified and possibly take on a different value.

(closes issue #16683)
 Reported by: wdoekes

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@247787 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agofixes confbridge crash when no timing module is loaded.
David Vossel [Thu, 18 Feb 2010 21:23:48 +0000 (21:23 +0000)]
fixes confbridge crash when no timing module is loaded.

(closes issue #16471)
Reported by: kjotte
Patches:
      M16471.diff uploaded by junky (license 177)
Tested by: kjotte, junky

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@247770 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agofixes Queue with C option crash
David Vossel [Thu, 18 Feb 2010 20:58:41 +0000 (20:58 +0000)]
fixes Queue with C option crash

(closes issue #16475)
Reported by: okrief
Patches:
      queue_crash.diff uploaded by dvossel (license 671)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@247736 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 247651 via svnmerge from
Matthew Nicholson [Thu, 18 Feb 2010 19:39:37 +0000 (19:39 +0000)]
Merged revisions 247651 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r247651 | mnicholson | 2010-02-18 13:38:09 -0600 (Thu, 18 Feb 2010) | 6 lines

  Copy the calling party's account code to the called party if they don't already have one.

  (closes issue #16331)
  Reported by: bluefox
  Tested by: mnicholson
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@247652 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoFix placing ISDN calls on hold preventing native bridging from being reexamined after...
Richard Mudgett [Thu, 18 Feb 2010 18:31:44 +0000 (18:31 +0000)]
Fix placing ISDN calls on hold preventing native bridging from being reexamined after a transfer.

Consider the following scenario:

                 /-- B
A == * == Network
                 \-- C

Party B calls party A (EuroISDN BRI phone)
Party A puts B on hold using the HOLD/RETRIEVE messages.
Party A calls party C.
Party A puts C on hold to talk with party B again.
Party A transfers B to C by hanging up.

The call does not get the opportunity to get re-transferred into the ISDN
network by the native bridge because native bridging is not being
reexamined after the initial transfer.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@247609 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 247508 via svnmerge from
Leif Madsen [Thu, 18 Feb 2010 16:54:43 +0000 (16:54 +0000)]
Merged revisions 247508 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r247508 | lmadsen | 2010-02-18 11:53:44 -0500 (Thu, 18 Feb 2010) | 1 line

  Add additional link to best practices document per jsmith.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@247509 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 247502 via svnmerge from
Leif Madsen [Thu, 18 Feb 2010 16:41:04 +0000 (16:41 +0000)]
Merged revisions 247502 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r247502 | lmadsen | 2010-02-18 11:38:17 -0500 (Thu, 18 Feb 2010) | 10 lines

  Add best practices documentation.

  (issue #16808)
  Reported by: lmadsen

  (issue #16810)
  Reported by: Nick_Lewis
  Tested by: lmadsen

  Review: https://reviewboard.asterisk.org/r/507/
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@247503 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoAdd a new manager event for our buddies status.
Philippe Sultan [Thu, 18 Feb 2010 16:34:08 +0000 (16:34 +0000)]
Add a new manager event for our buddies status.

The new JabberStatus event gives a concise view of the status change to the AMI
clients. Thanks fiddur!

(closes issue #16760)
Reported by: fiddur
Patches:
      244498.2.diff uploaded by fiddur (license 678)
Tested by: fiddur, phsultan

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@247500 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 247422 via svnmerge from
Russell Bryant [Thu, 18 Feb 2010 04:20:11 +0000 (04:20 +0000)]
Merged revisions 247422 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r247422 | russell | 2010-02-17 22:19:01 -0600 (Wed, 17 Feb 2010) | 10 lines

  Tweak argument handling for wget in the sounds Makefile.

  1) Fix the check to see if we are using wget to not be full of fail.  The
  configure script populates this variable with the absolute path to wget if
  it is found, so it didn't work.

  2) Allow some extra arguments to be passed in for wget.  This is just a simple
  change to allow our Bamboo build script to tell wget to be quiet and not fill
  up our logs with download status output.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@247423 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoFix a couple of bugs in test tab completion.
Mark Michelson [Wed, 17 Feb 2010 22:44:53 +0000 (22:44 +0000)]
Fix a couple of bugs in test tab completion.

1. Add missing unlock of lists.
2. Swap order of arguments to test_cat_cmp in complete_test_name.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@247381 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoTab completion for test categories and names for "test show registered" and "test...
Mark Michelson [Wed, 17 Feb 2010 22:40:43 +0000 (22:40 +0000)]
Tab completion for test categories and names for "test show registered" and "test execute" CLI commands.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@247380 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoFix two problems in ast_str functions found while writing a unit test.
Mark Michelson [Wed, 17 Feb 2010 21:22:40 +0000 (21:22 +0000)]
Fix two problems in ast_str functions found while writing a unit test.

1. The documentation for ast_str_set and ast_str_append state that
the max_len parameter may be -1 in order to limit the size of the
ast_str to its current allocated size. The problem was that the max_len
parameter in all cases was a size_t, which is unsigned. Thus a -1 was
interpreted as UINT_MAX instead of -1. Changing the max_len parameter
to be ssize_t fixed this issue.

2. Once issue 1 was fixed, there was an off-by-one error in the case
where we attempted to write a string larger than the current allotted
size to a string when -1 was passed as the max_len parameter. When trying
to write more than the allotted size, the ast_str's __AST_STR_USED was
set to 1 higher than it should have been. Thanks to Tilghman for quickly
spotting the offending line of code.

Oh, and the unit test that I referenced in the top line of this commit
will be added to reviewboard shortly. Sit tight...

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@247335 65c4cc65-6c06-0410-ace0-fbb531ad65f3