asterisk/asterisk.git
13 years agowill i ever get precedences for windows right ?
Luigi Rizzo [Sat, 17 Nov 2007 19:27:51 +0000 (19:27 +0000)]
will i ever get precedences for windows right ?
in the meantime, use a variable to ease enabling/disabling print subdirectories.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89390 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoreformulate dependencies in a more correct way
Luigi Rizzo [Sat, 17 Nov 2007 19:00:07 +0000 (19:00 +0000)]
reformulate dependencies in a more correct way

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89389 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoa quick fix to pbx_dundi.c to make it so it will compile. Hope I did the right thing...
Steve Murphy [Sat, 17 Nov 2007 17:46:36 +0000 (17:46 +0000)]
a quick fix to pbx_dundi.c to make it so it will compile. Hope I did the right thing. And some additions to removal of extens to take care of hashtab pointers in all cases.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89388 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoas discussed some time ago on the -dev list, create embedde object
Luigi Rizzo [Sat, 17 Nov 2007 17:27:26 +0000 (17:27 +0000)]
as discussed some time ago on the -dev list, create embedde object
with a .eo suffix even if they are coming from .cc sources.
This simplifies the handling in the build scripts.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89387 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoprefer socket.h over other variants (winsock etc.)
Luigi Rizzo [Sat, 17 Nov 2007 16:32:18 +0000 (16:32 +0000)]
prefer socket.h over other variants (winsock etc.)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89385 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agotrim more redundant headers
Luigi Rizzo [Sat, 17 Nov 2007 16:18:53 +0000 (16:18 +0000)]
trim more redundant headers

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89384 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoremove unnecessary includes
Luigi Rizzo [Sat, 17 Nov 2007 14:47:33 +0000 (14:47 +0000)]
remove unnecessary includes

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89383 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agofix breakage induced by previous mistake
Luigi Rizzo [Sat, 17 Nov 2007 14:45:46 +0000 (14:45 +0000)]
fix breakage induced by previous mistake

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89382 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agowrong variable, wrong order -> broken build.
Luigi Rizzo [Sat, 17 Nov 2007 14:44:03 +0000 (14:44 +0000)]
wrong variable, wrong order -> broken build.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89381 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agostart using asterisk/network.h for network related headers.
Luigi Rizzo [Sat, 17 Nov 2007 14:11:53 +0000 (14:11 +0000)]
start using asterisk/network.h for network related headers.
Also remove some unnecessary includes.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89380 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agowrapper for all generic network headers that have different names
Luigi Rizzo [Sat, 17 Nov 2007 14:00:24 +0000 (14:00 +0000)]
wrapper for all generic network headers that have different names
and locations on the various systems.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89379 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agomain is called main not amain!
Luigi Rizzo [Sat, 17 Nov 2007 12:44:22 +0000 (12:44 +0000)]
main is called main not amain!

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89378 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoconditional targets for building the windows version
Luigi Rizzo [Sat, 17 Nov 2007 12:33:15 +0000 (12:33 +0000)]
conditional targets for building the windows version

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89377 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agosupport cygwin targets
Luigi Rizzo [Sat, 17 Nov 2007 11:57:52 +0000 (11:57 +0000)]
support cygwin targets

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89376 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoand this is the last one to have asterisk compile (not run yet)
Luigi Rizzo [Sat, 17 Nov 2007 11:10:16 +0000 (11:10 +0000)]
and this is the last one to have asterisk compile (not run yet)
natively under cygwin.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89375 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoanother cygwin compatibility fix.
Luigi Rizzo [Sat, 17 Nov 2007 11:08:58 +0000 (11:08 +0000)]
another cygwin compatibility fix.
This one must be handled in a better way in configure, also for other
architectures

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89374 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agomore cygwin/mingw32 compatibility fixes
Luigi Rizzo [Sat, 17 Nov 2007 10:54:52 +0000 (10:54 +0000)]
more cygwin/mingw32 compatibility fixes

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89373 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agouse autoconf results to conditionally compile timersub
Luigi Rizzo [Sat, 17 Nov 2007 10:32:56 +0000 (10:32 +0000)]
use autoconf results to conditionally compile timersub

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89372 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agocompatibility fixes for cygwin
Luigi Rizzo [Sat, 17 Nov 2007 10:28:55 +0000 (10:28 +0000)]
compatibility fixes for cygwin

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89371 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agosome version of flex produce code that wants __STDC_VERSION__
Luigi Rizzo [Sat, 17 Nov 2007 10:26:21 +0000 (10:26 +0000)]
some version of flex produce code that wants __STDC_VERSION__
defined, but the compiler does not always define it.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89370 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agothese linker flags apply to both cygwin and mingw32
Luigi Rizzo [Sat, 17 Nov 2007 10:12:43 +0000 (10:12 +0000)]
these linker flags apply to both cygwin and mingw32

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89369 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoadd a return NULL to a function that is expected to return a value
Luigi Rizzo [Sat, 17 Nov 2007 09:54:54 +0000 (09:54 +0000)]
add a return NULL to a function that is expected to return a value
so compilers that don't understand that this code is NOTREACHED
will not complain (the fault is not much on the compiler but on the
declaration of pthread_exit on certain platforms)
s/certain platform/cygwin/ if you are really curious

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89368 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agodefine RTLD_LOCAL for platforms that don't have it.
Luigi Rizzo [Sat, 17 Nov 2007 09:51:45 +0000 (09:51 +0000)]
define RTLD_LOCAL for platforms that don't have it.
This is only to complete the build, clearly the linker
behaviour will be completely different and likely to
cause trouble in those cases.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89367 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agofilter out modules that do not compile under windows
Luigi Rizzo [Sat, 17 Nov 2007 09:48:45 +0000 (09:48 +0000)]
filter out modules that do not compile under windows
(this should be handled with the dependencies generated by
configure and menuselect, but will be fixed later)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89366 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agonetdb.h is used for gethostbyname, and it was not included in some
Luigi Rizzo [Sat, 17 Nov 2007 09:44:14 +0000 (09:44 +0000)]
netdb.h is used for gethostbyname, and it was not included in some
platforms.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89365 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoLoader for cygwin where asterisk is really a big dll
Luigi Rizzo [Sat, 17 Nov 2007 09:37:12 +0000 (09:37 +0000)]
Loader for cygwin where asterisk is really a big dll
(something like this is already in 1.2)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89364 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agotimersub is a macro not a function, so write the check in a way
Luigi Rizzo [Sat, 17 Nov 2007 09:30:22 +0000 (09:30 +0000)]
timersub is a macro not a function, so write the check in a way
that detects both formats.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89363 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agofix the build of pbx_lua
Russell Bryant [Sat, 17 Nov 2007 06:34:10 +0000 (06:34 +0000)]
fix the build of pbx_lua

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89362 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoUpdate the configure script check for sys/poll.h to also provide the result in
Russell Bryant [Sat, 17 Nov 2007 06:33:07 +0000 (06:33 +0000)]
Update the configure script check for sys/poll.h to also provide the result in
include/asterisk/autoconfig.h.  Also, move the conditional include of sys/poll.h
or asterisk/poll-compat.h into asterisk/config.h instead of the two headers it
existed in before.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89361 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoactually let this compile, oops :(
Russell Bryant [Sat, 17 Nov 2007 06:09:42 +0000 (06:09 +0000)]
actually let this compile, oops :(

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89360 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoUse the fix suggested by Tilghman on the -dev to make cutting up the BUILDSUM
Russell Bryant [Sat, 17 Nov 2007 06:07:57 +0000 (06:07 +0000)]
Use the fix suggested by Tilghman on the -dev to make cutting up the BUILDSUM
friendly to non-bash shells.  I think this should work for BSD/mingw as well,
but did not yet remove the switch statement.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89359 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agolinker flags for mingw32
Luigi Rizzo [Sat, 17 Nov 2007 04:19:02 +0000 (04:19 +0000)]
linker flags for mingw32

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89358 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoadd detection for timersub() and winsock.h/winsock2.h
Luigi Rizzo [Sat, 17 Nov 2007 04:17:53 +0000 (04:17 +0000)]
add detection for timersub() and winsock.h/winsock2.h

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89357 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoprovide definitions for __LITTLE_ENDIAN and __BIG_ENDIAN if not present.
Luigi Rizzo [Sat, 17 Nov 2007 03:28:31 +0000 (03:28 +0000)]
provide definitions for __LITTLE_ENDIAN and __BIG_ENDIAN if not present.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89356 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agouse poll as detected by configure
Luigi Rizzo [Sat, 17 Nov 2007 03:07:06 +0000 (03:07 +0000)]
use poll as detected by configure

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89355 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agouse autoconf to check for the existence of sys/poll.h
Luigi Rizzo [Sat, 17 Nov 2007 02:57:40 +0000 (02:57 +0000)]
use autoconf to check for the existence of sys/poll.h

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89354 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agothis script is run on the build system, not on the host.
Luigi Rizzo [Sat, 17 Nov 2007 02:54:23 +0000 (02:54 +0000)]
this script is run on the build system, not on the host.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89353 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agocompatibility fix for mingw32
Luigi Rizzo [Sat, 17 Nov 2007 02:50:52 +0000 (02:50 +0000)]
compatibility fix for mingw32

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89352 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoacinclude.m4: add a function to help checking sdl-config, gtk-config
Luigi Rizzo [Sat, 17 Nov 2007 01:49:26 +0000 (01:49 +0000)]
acinclude.m4: add a function to help checking sdl-config, gtk-config
and the like (this could be used for gtk and gtk2 as well)
Other files: add tests for sdl, sdl_image and avcodec and regenerate
configure and autoconfig.h.in

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89351 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoadd check for the presence of glob
Luigi Rizzo [Sat, 17 Nov 2007 00:31:32 +0000 (00:31 +0000)]
add check for the presence of glob

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89350 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agomore removal of duplicate #include lines
Luigi Rizzo [Sat, 17 Nov 2007 00:02:33 +0000 (00:02 +0000)]
more removal of duplicate #include lines

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89349 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoremove a bunch of duplicate includes
Luigi Rizzo [Fri, 16 Nov 2007 23:54:45 +0000 (23:54 +0000)]
remove a bunch of duplicate includes
Reproduce with

grep -r #include . | grep -v .svn | grep -v Binary | sort | uniq -c | sort -nr

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89348 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoFix broken parking dial-back
Terry Wilson [Fri, 16 Nov 2007 23:44:14 +0000 (23:44 +0000)]
Fix broken parking dial-back

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89347 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMy goodness, haven't handled an extension deletion. Add code to ast_context_remove_ex...
Steve Murphy [Fri, 16 Nov 2007 23:33:32 +0000 (23:33 +0000)]
My goodness, haven't handled an extension deletion. Add code to ast_context_remove_extension2() to remove an extension from the trie. Done by marking it deleted. The scoreboard won't update for it any more. Also, a couple of calls to insert hashtab had a spurious ->exten, which was removed.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89346 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agopaths are already in include/asterisk/paths.h so don't duplicate
Luigi Rizzo [Fri, 16 Nov 2007 23:28:28 +0000 (23:28 +0000)]
paths are already in include/asterisk/paths.h so don't duplicate
them in include/asterisk.h

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89345 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agowhitespace only change - adjust indentation and add some
Luigi Rizzo [Fri, 16 Nov 2007 22:37:17 +0000 (22:37 +0000)]
whitespace only change - adjust indentation and add some
comments on the content of these two files.

utils.h (which is included in over 150 files) contains a lot of
unrelated functions which require the inclusion of a large number
of other headers.  At some point we should partition its content
in a better way.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89341 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoBlocked revisions 89339 via svnmerge
Russell Bryant [Fri, 16 Nov 2007 22:33:24 +0000 (22:33 +0000)]
Blocked revisions 89339 via svnmerge

........
r89339 | russell | 2007-11-16 16:26:44 -0600 (Fri, 16 Nov 2007) | 5 lines

Temporarily revert revision 89325, which added md5 magic for keeping track of
what build options were used.  We agreed that we should remove this before
making a 1.4 release, and then we can put it back in.  Then, we can take a
month or so to play around with it to get it how we want it.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89340 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agologger.h does not need options.h
Luigi Rizzo [Fri, 16 Nov 2007 21:23:50 +0000 (21:23 +0000)]
logger.h does not need options.h

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89338 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoremove redundant #include "asterisk/compat.h",
Luigi Rizzo [Fri, 16 Nov 2007 21:08:28 +0000 (21:08 +0000)]
remove redundant #include "asterisk/compat.h",
but make sure that asterisk/compiler.h is included everywhere

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89336 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoremove duplicate headers.
Luigi Rizzo [Fri, 16 Nov 2007 20:28:19 +0000 (20:28 +0000)]
remove duplicate headers.
Properly check for netdb.h (there is actually tens of places to fix)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89335 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoput back default optimization to -O6 (previously changed by mistake)
Luigi Rizzo [Fri, 16 Nov 2007 20:15:21 +0000 (20:15 +0000)]
put back default optimization to -O6 (previously changed by mistake)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89334 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoStart untangling header inclusion in a way that does not affect
Luigi Rizzo [Fri, 16 Nov 2007 20:04:58 +0000 (20:04 +0000)]
Start untangling header inclusion in a way that does not affect
build times - tested, there is no measureable difference before and
after this commit.

In this change:

use asterisk/compat.h to include a small set of system headers:
inttypes.h, unistd.h, stddef.h, stddint.h, sys/types.h, stdarg.h,
stdlib.h, alloca.h, stdio.h

Where available, the inclusion is conditional on HAVE_FOO_H as determined
by autoconf.

Normally, source files should not include any of the above system headers,
and instead use either "asterisk.h" or "asterisk/compat.h" which does it
better.

For the time being I have left alone second-level directories
(main/db1-ast, etc.).

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89333 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoFixing a problem pointed out by Qwell
Mark Michelson [Fri, 16 Nov 2007 19:51:47 +0000 (19:51 +0000)]
Fixing a problem pointed out by Qwell

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89332 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoAdded some locks that should have been around astman_send_error,
Mark Michelson [Fri, 16 Nov 2007 19:41:15 +0000 (19:41 +0000)]
Added some locks that should have been around astman_send_error,
at least according to the comments.

(closes issue #11258, reported and patched by eliel)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89331 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoThis corrects a hashtab removal, given a bad argument
Steve Murphy [Fri, 16 Nov 2007 19:26:54 +0000 (19:26 +0000)]
This corrects a hashtab removal, given a bad argument

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89330 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoThis fixes a problem with pattern ranges; and corrects a situation in res_features...
Steve Murphy [Fri, 16 Nov 2007 18:59:02 +0000 (18:59 +0000)]
This fixes a problem with pattern ranges; and corrects a situation in res_features, where an extension would be created with the name Zap/51, as an example. THe / is bad because it would tend to mean that the 51 is to be cid matched.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89329 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoboth md5sum and variable substitutions such as ${BUILDSUM:0:8}
Luigi Rizzo [Fri, 16 Nov 2007 18:48:15 +0000 (18:48 +0000)]
both md5sum and variable substitutions such as ${BUILDSUM:0:8}
are not available in FreeBSD.
For the time being, put in a workaround so we can build the system,
and wait for the result of the discussion on whether we can store
the md5 as a string rather than 4 ints (if so, we won't need more
complex tricks with awk or sed for splitting the md5).

1.4 will be fixed when we decide the issue.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89328 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoAdding confirmation playback when forwarding voicemail messages. This will attempt
Mark Michelson [Fri, 16 Nov 2007 17:11:43 +0000 (17:11 +0000)]
Adding confirmation playback when forwarding voicemail messages. This will attempt
to play the name(s) of the person(s) to whom you are forwarding the message prior to
prompting for prepending. If no name is found, the extension is read back verbatim.

(closes issue #9046, reported and patched by jaroth)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89327 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerged revisions 89325 via svnmerge from
Kevin P. Fleming [Fri, 16 Nov 2007 16:56:59 +0000 (16:56 +0000)]
Merged revisions 89325 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r89325 | kpfleming | 2007-11-16 10:47:46 -0600 (Fri, 16 Nov 2007) | 4 lines

To help combat problems where people build external modules (asterisk-addons or others) and then change the build options of the Asterisk build in a way that makes the incompatible without warning, this commit introduces an MD5 signature of the important build-time options and includes that signature into modules when they are built. When the loader loads one of these modules and notices the problem, it will emit a warning to console and refuse to initialize the module, as doing so could cause the system to be unstable or even crash.

If you upgrade to this version of Asterisk, you must rebuild *all* of your modules that came from other sources before trying to run this version. If you are using Digium's G.729 binary codec module, you will need v33 or newer.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89326 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerged revisions 89323 via svnmerge from
Mark Michelson [Fri, 16 Nov 2007 15:44:27 +0000 (15:44 +0000)]
Merged revisions 89323 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r89323 | mmichelson | 2007-11-16 09:28:22 -0600 (Fri, 16 Nov 2007) | 5 lines

Make realtime queues accessible from the QUEUE_MEMBER_COUNT function.

(closes issue #11271, reported and patched by atis, with small modifications from me)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89324 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoadd a small new function to retrieve variables from a config
Luigi Rizzo [Fri, 16 Nov 2007 10:07:24 +0000 (10:07 +0000)]
add a small new function to retrieve variables from a config
once we have a pointer to the category.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89322 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agofixed #10631, about one way audio. thanks IgorG again.
Christian Richter [Fri, 16 Nov 2007 10:06:55 +0000 (10:06 +0000)]
fixed #10631, about one way audio. thanks IgorG again.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89321 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agomove the inner part of config file parsing to a separate function,
Luigi Rizzo [Fri, 16 Nov 2007 09:51:41 +0000 (09:51 +0000)]
move the inner part of config file parsing to a separate function,
so it can be reused in the implementation of cli commands when
they have a similar syntax.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89320 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agofixed compilation of chan_misdn, #11269, thanks IgorG.
Christian Richter [Fri, 16 Nov 2007 08:54:04 +0000 (08:54 +0000)]
fixed compilation of chan_misdn, #11269, thanks IgorG.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89319 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoIf we're going to be passing a negative value for the size of a stringfield,
Tilghman Lesher [Thu, 15 Nov 2007 23:50:15 +0000 (23:50 +0000)]
If we're going to be passing a negative value for the size of a stringfield,
in order to indicate something, then using an UNSIGNED parameter is bad,
mmmmmkay?

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89312 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerged revisions 89302 via svnmerge from
Tilghman Lesher [Thu, 15 Nov 2007 18:49:31 +0000 (18:49 +0000)]
Merged revisions 89302 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r89302 | tilghman | 2007-11-15 12:37:38 -0600 (Thu, 15 Nov 2007) | 2 lines

Start Asterisk in Debian at a more reasonable time (since zaptel is at level 20)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89304 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerged revisions 89301 via svnmerge from
Tilghman Lesher [Thu, 15 Nov 2007 18:39:46 +0000 (18:39 +0000)]
Merged revisions 89301 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r89301 | tilghman | 2007-11-15 12:23:14 -0600 (Thu, 15 Nov 2007) | 2 lines

Fix an uninitialized memory read found by valgrind

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89303 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoFix trunk breakage due to chan->lock being renamed.
Tilghman Lesher [Thu, 15 Nov 2007 18:15:48 +0000 (18:15 +0000)]
Fix trunk breakage due to chan->lock being renamed.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89300 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerged revisions 89298 via svnmerge from
Tilghman Lesher [Thu, 15 Nov 2007 18:11:36 +0000 (18:11 +0000)]
Merged revisions 89298 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r89298 | tilghman | 2007-11-15 12:05:56 -0600 (Thu, 15 Nov 2007) | 5 lines

Yet another memory corruption issue.
Reported by: atis
Patch by: tilghman
Fixes issue #10923

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89299 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerged revisions 89296 via svnmerge from
Russell Bryant [Thu, 15 Nov 2007 17:27:27 +0000 (17:27 +0000)]
Merged revisions 89296 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r89296 | russell | 2007-11-15 11:19:28 -0600 (Thu, 15 Nov 2007) | 8 lines

Update the SLAStation application to account for the case where the SLA thread
has a call out to the station,  but the user has pressed a line button to answer
the call instead of picking up the handset.  If they do, the phone sends out a
new INVITE.  So, the SLAStation app must check to see if it is picking up a
ringing trunk, and ensure that the other stations stop ringing.

(reported internally, patched by me, tested by mogorman)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89297 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoGet rid of a previously missed ast_log call for debug, no longer nec.
Steve Murphy [Thu, 15 Nov 2007 16:50:16 +0000 (16:50 +0000)]
Get rid of a previously missed ast_log call for debug, no longer nec.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89295 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoPerhaps I went overboard on initializing things. I can remove unnecc. stuff later...
Steve Murphy [Thu, 15 Nov 2007 16:30:13 +0000 (16:30 +0000)]
Perhaps I went overboard on initializing things. I can remove unnecc. stuff later. A few bug fixes. Killing small bugs on the way to killing bigger ones. Removed locking on hashtabs; there's plenty of locks already being taken. A small bug in the root_tree hashtab compare func.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89294 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoaccess channel locks through ast_channel_lock/unlock/trylock and not
Luigi Rizzo [Thu, 15 Nov 2007 16:20:47 +0000 (16:20 +0000)]
access channel locks through ast_channel_lock/unlock/trylock and not
through ast_mutex primitives.

To detect all occurrences, I have renamed the lock field in struct ast_channel
so it is clear that it shouldn't be used directly.

There are some uses in res/res_features.c (see details of the diff)
that are error prone as they try and lock two channels without
caring about the order (or without explaining why it is safe).

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89293 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoFix typo in UPGRADE.txt. 'increase' should have been used, not 'increasing'.
Joshua Colp [Thu, 15 Nov 2007 15:39:03 +0000 (15:39 +0000)]
Fix typo in UPGRADE.txt. 'increase' should have been used, not 'increasing'.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89291 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoAnd file said... let trunk build again! Accomplished by some more constification...
Joshua Colp [Thu, 15 Nov 2007 15:21:04 +0000 (15:21 +0000)]
And file said... let trunk build again! Accomplished by some more constification, and marking a function in chan_sip as purposely unused until it is fixed up.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89290 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerged revisions 89288 via svnmerge from
Mark Michelson [Thu, 15 Nov 2007 14:58:30 +0000 (14:58 +0000)]
Merged revisions 89288 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r89288 | mmichelson | 2007-11-15 08:57:28 -0600 (Thu, 15 Nov 2007) | 3 lines

Undoing previous commit since I realize it was wrong

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89289 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerged revisions 89286 via svnmerge from
Mark Michelson [Thu, 15 Nov 2007 14:55:35 +0000 (14:55 +0000)]
Merged revisions 89286 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r89286 | mmichelson | 2007-11-15 08:54:10 -0600 (Thu, 15 Nov 2007) | 4 lines

Adding a missing mutex unlock.

(closes issue 11256, reported and patched by ys)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89287 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoAlways relying on the responses when crossing NAT's are not a good
Olle Johansson [Thu, 15 Nov 2007 12:21:57 +0000 (12:21 +0000)]
Always relying on the responses when crossing NAT's are not a good
solution, it breaks communication.
Rizzo - you need to implement a configuration option for this
code. It's good, but maybe should be off by default.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89285 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerged revisions 89281 via svnmerge from
Olle Johansson [Thu, 15 Nov 2007 11:31:27 +0000 (11:31 +0000)]
Merged revisions 89281 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r89281 | oej | 2007-11-15 12:26:22 +0100 (Tor, 15 Nov 2007) | 6 lines

Don't send re-invites during pending INVITE transactions.

Patch by one47 - thanks!

Closes issue #9305

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89283 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerged revisions 89280 via svnmerge from
Olle Johansson [Thu, 15 Nov 2007 11:27:19 +0000 (11:27 +0000)]
Merged revisions 89280 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r89280 | oej | 2007-11-15 12:15:09 +0100 (Tor, 15 Nov 2007) | 5 lines

Improve support for multipart messages. Code by gasparz, changes
by me (mostly formatting). Thanks, gasparz!

Closes issue #10947

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89282 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoExit early instead of deciding to exit after processing the message.
Olle Johansson [Thu, 15 Nov 2007 10:26:00 +0000 (10:26 +0000)]
Exit early instead of deciding to exit after processing the message.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89279 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoAdd support for application/dtmf SIP INFO dtmf handling. Yep, another
Olle Johansson [Thu, 15 Nov 2007 10:21:41 +0000 (10:21 +0000)]
Add support for application/dtmf SIP INFO dtmf handling. Yep, another
way of handling DTMF in SIP. Totally undocumented, but implemented
in enough devices so we have to support it.

Code by sergee, small changes by oej.

Closes issue #11049

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89278 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoHad trouble playing with parking; spent a long time trying to reason out MATCHMORE...
Steve Murphy [Thu, 15 Nov 2007 01:42:12 +0000 (01:42 +0000)]
Had trouble playing with parking; spent a long time trying to reason out MATCHMORE mode. made these updates and xfers on zaptel lines seem to work ok now

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89277 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerged revisions 89275 via svnmerge from
Tilghman Lesher [Thu, 15 Nov 2007 00:01:22 +0000 (00:01 +0000)]
Merged revisions 89275 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r89275 | tilghman | 2007-11-14 17:23:58 -0600 (Wed, 14 Nov 2007) | 5 lines

When a recording ends with '#', we are improperly trimming an extra 200ms from the recording.
Reported by: sim
Patch by: tilghman
Closes issue #11247

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89276 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoTypo
Tilghman Lesher [Wed, 14 Nov 2007 23:08:54 +0000 (23:08 +0000)]
Typo

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89274 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoAdd callerid to the Hangup manager event.
Tilghman Lesher [Wed, 14 Nov 2007 22:59:05 +0000 (22:59 +0000)]
Add callerid to the Hangup manager event.
Reported by: outtolunc
Patch by: outtolunc
Closes issue #11248

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89273 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoRescaled the weights of the patterns to give something more independent of pattern...
Steve Murphy [Wed, 14 Nov 2007 18:05:50 +0000 (18:05 +0000)]
Rescaled the weights of the patterns to give something more independent of pattern length; and make . less likely to win. Question: which should win for 14102241145-- _1xxxxxxx.   or  _XXXXXXXXXXX  -- right now, the pure X pattern will win.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89272 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoA further problem highlighted by 11233 has been resolved; a certain combination of...
Steve Murphy [Wed, 14 Nov 2007 15:43:30 +0000 (15:43 +0000)]
A further problem highlighted by 11233 has been resolved; a certain combination of patterns in a certain order, led to a malformed trie, due to a ptr not being initialized in the loop. Also, some tree printing prettifications.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89271 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoOne more typo in config.c; and missed conversions due to the constifying of ast_varia...
Tilghman Lesher [Wed, 14 Nov 2007 15:13:22 +0000 (15:13 +0000)]
One more typo in config.c; and missed conversions due to the constifying of ast_variable_new parameters

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89270 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoTypo
Tilghman Lesher [Wed, 14 Nov 2007 14:46:45 +0000 (14:46 +0000)]
Typo

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89269 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agomake the 'name' and 'value' fields in ast_variable const char *
Luigi Rizzo [Wed, 14 Nov 2007 13:18:40 +0000 (13:18 +0000)]
make the 'name' and 'value' fields in ast_variable const char *

This prevents modifying the strings in the stored variables,
and catched a few instances where this was actually done.

Given the differences between trunk and 1.4 (and the fact that this
is effectively an API change) it is better to fix 1.4 independently.
These are

chan_sip.c::sip_register()
chan_skinny.c:: near line 2847
config.c:: near line 1774
logger.c::make_components()
res_adsi.c:: near line 1049

I may have missed some instances for modules that do not build here.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89268 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoFix up various coding guidelines issues ...
Russell Bryant [Wed, 14 Nov 2007 03:22:09 +0000 (03:22 +0000)]
Fix up various coding guidelines issues ...
 - handle memory allocation failures
 - add an ast_ prefix to a publicly exported function
 - put curly braces in the right places
 - add a bunch of spaces where they should be be used

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89266 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years ago- Use the ARRAY_LEN macro in a couple places
Russell Bryant [Wed, 14 Nov 2007 02:57:13 +0000 (02:57 +0000)]
- Use the ARRAY_LEN macro in a couple places
- return errors from load_module / unload_module

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89265 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoUse BEGIN_OPTIONS / END_OPTIONS to make the syntax highlighting in my editor happy
Russell Bryant [Wed, 14 Nov 2007 01:40:47 +0000 (01:40 +0000)]
Use BEGIN_OPTIONS / END_OPTIONS to make the syntax highlighting in my editor happy

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89264 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoInstead of reserving 800 bytes for periodic announcements, use an array of
Russell Bryant [Wed, 14 Nov 2007 01:35:28 +0000 (01:35 +0000)]
Instead of reserving 800 bytes for periodic announcements, use an array of
ast_str pointers and only alloate space for the strings as needed.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89263 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoMerged revisions 89260 via svnmerge from
Joshua Colp [Wed, 14 Nov 2007 01:16:50 +0000 (01:16 +0000)]
Merged revisions 89260 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r89260 | file | 2007-11-13 21:15:12 -0400 (Tue, 13 Nov 2007) | 4 lines

Return the proper value when the srv_callback function executes properly.
(closes issue #11240)
Reported by: jtodd

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89262 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoConvert most of the strings in the call_queue struct to use stringfields.
Russell Bryant [Wed, 14 Nov 2007 01:15:26 +0000 (01:15 +0000)]
Convert most of the strings in the call_queue struct to use stringfields.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89261 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agouse simpler technique for removing known entries from lists
Kevin P. Fleming [Wed, 14 Nov 2007 00:54:38 +0000 (00:54 +0000)]
use simpler technique for removing known entries from lists

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89259 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years ago- Simplify removing an item from a list
Russell Bryant [Wed, 14 Nov 2007 00:33:52 +0000 (00:33 +0000)]
- Simplify removing an item from a list
- move a verbose message to after the item is added to the list
- make use of the ARRAY_LEN macro in one spot

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89258 65c4cc65-6c06-0410-ace0-fbb531ad65f3

13 years agoThis hopefully will fix the re-opened 11233. Hadn't covered the case of a context...
Steve Murphy [Tue, 13 Nov 2007 23:43:41 +0000 (23:43 +0000)]
This hopefully will fix the re-opened 11233. Hadn't covered the case of a context with no patterns. (blush)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89257 65c4cc65-6c06-0410-ace0-fbb531ad65f3