asterisk/asterisk.git
14 years agoMerged revisions 46347 via svnmerge from
Jason Parker [Thu, 26 Oct 2006 20:27:52 +0000 (20:27 +0000)]
Merged revisions 46347 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r46347 | qwell | 2006-10-26 15:25:44 -0500 (Thu, 26 Oct 2006) | 2 lines

Fix small formatting issue, that causes misaligned line

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@46348 65c4cc65-6c06-0410-ace0-fbb531ad65f3

14 years agoShow if the channel is ready for video or T.38 udptl
Olle Johansson [Thu, 26 Oct 2006 20:22:14 +0000 (20:22 +0000)]
Show if the channel is ready for video or T.38 udptl

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@46346 65c4cc65-6c06-0410-ace0-fbb531ad65f3

14 years agooops - somebody forgot to change this - long ago, probably.
Jason Parker [Thu, 26 Oct 2006 18:04:46 +0000 (18:04 +0000)]
oops - somebody forgot to change this - long ago, probably.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@46341 65c4cc65-6c06-0410-ace0-fbb531ad65f3

14 years agofix various spelling mistakes in comments (issue #8237, jmls)
Russell Bryant [Thu, 26 Oct 2006 17:52:15 +0000 (17:52 +0000)]
fix various spelling mistakes in comments (issue #8237, jmls)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@46339 65c4cc65-6c06-0410-ace0-fbb531ad65f3

14 years agoMerged revisions 46329 via svnmerge from
Russell Bryant [Thu, 26 Oct 2006 16:35:34 +0000 (16:35 +0000)]
Merged revisions 46329 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r46329 | russell | 2006-10-26 11:31:05 -0500 (Thu, 26 Oct 2006) | 11 lines

- If the source has no audio or no video portion, do not call powerof() to
  get the format index.
- Don't run through the audio and video loops if there is no audio or video
  portion of the source
If 0 is passed to powerof, it will return -1.  This value of -1 was then being
used as an array index in these loops, which caused a crash on some systems.
Other than this issue, this code works as we expected it to.  If a format is
not in the source, and we have to translation path to it, it is not offered in
the list of acceptable destination formats.
(fixes issue #8231)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@46330 65c4cc65-6c06-0410-ace0-fbb531ad65f3

14 years agofix a problem that i recently introduced when
Luigi Rizzo [Thu, 26 Oct 2006 12:47:23 +0000 (12:47 +0000)]
fix a problem that i recently introduced when
the manager receives long commands.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@46319 65c4cc65-6c06-0410-ace0-fbb531ad65f3

14 years agodocument the match_auth_username option
Luigi Rizzo [Thu, 26 Oct 2006 07:32:00 +0000 (07:32 +0000)]
document the match_auth_username option

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@46308 65c4cc65-6c06-0410-ace0-fbb531ad65f3

14 years agoMerged revisions 46298 via svnmerge from
Russell Bryant [Thu, 26 Oct 2006 04:19:09 +0000 (04:19 +0000)]
Merged revisions 46298 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r46298 | russell | 2006-10-25 23:18:00 -0500 (Wed, 25 Oct 2006) | 2 lines

update backtrace documentation to reflect changes in 1.4 (issue #8230, kshumard)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@46299 65c4cc65-6c06-0410-ace0-fbb531ad65f3

14 years agoFix comment preservation code (thanks murf!)
Mark Spencer [Thu, 26 Oct 2006 01:38:47 +0000 (01:38 +0000)]
Fix comment preservation code (thanks murf!)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@46288 65c4cc65-6c06-0410-ace0-fbb531ad65f3

14 years agoOld todo: Don't add Contact headers on BYE and CANCEL.
Olle Johansson [Wed, 25 Oct 2006 20:21:05 +0000 (20:21 +0000)]
Old todo: Don't add Contact headers on BYE and CANCEL.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@46277 65c4cc65-6c06-0410-ace0-fbb531ad65f3

14 years agoFirst stab at transaction direction fix, this for trunk for testing
Olle Johansson [Wed, 25 Oct 2006 20:12:06 +0000 (20:12 +0000)]
First stab at transaction direction fix, this for trunk for testing

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@46275 65c4cc65-6c06-0410-ace0-fbb531ad65f3

14 years agoUgly code to try to remove issue discovered by Luigi as well as attack bug #7608
Olle Johansson [Wed, 25 Oct 2006 19:30:04 +0000 (19:30 +0000)]
Ugly code to try to remove issue discovered by Luigi as well as attack bug #7608

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@46259 65c4cc65-6c06-0410-ace0-fbb531ad65f3

14 years agoBlocked revisions 46255 via svnmerge
Russell Bryant [Wed, 25 Oct 2006 19:25:51 +0000 (19:25 +0000)]
Blocked revisions 46255 via svnmerge

........
r46255 | russell | 2006-10-25 15:24:11 -0400 (Wed, 25 Oct 2006) | 2 lines

regenerate configure script

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@46257 65c4cc65-6c06-0410-ace0-fbb531ad65f3

14 years agoSend CPG when we get a CONTROL_PROGRESS frame and make sure that it sends ACM (not...
Matthew Fredrickson [Wed, 25 Oct 2006 19:24:40 +0000 (19:24 +0000)]
Send CPG when we get a CONTROL_PROGRESS frame and make sure that it sends ACM (not CPG) when
we get CONTROL_PROCEEDING.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@46256 65c4cc65-6c06-0410-ace0-fbb531ad65f3

14 years agoBlocked revisions 46253 via svnmerge
Russell Bryant [Wed, 25 Oct 2006 19:21:55 +0000 (19:21 +0000)]
Blocked revisions 46253 via svnmerge

........
r46253 | russell | 2006-10-25 15:20:23 -0400 (Wed, 25 Oct 2006) | 3 lines

fix error output when checking for openh323 to refer to openh323 instead
of pwlib (issue #8222, misaksen)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@46254 65c4cc65-6c06-0410-ace0-fbb531ad65f3

14 years agoUpdate changes to do US style point code parsing/formatting (xxx.xxx.xxx)
Matthew Fredrickson [Wed, 25 Oct 2006 19:14:23 +0000 (19:14 +0000)]
Update changes to do US style point code parsing/formatting (xxx.xxx.xxx)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@46251 65c4cc65-6c06-0410-ace0-fbb531ad65f3

14 years agoMerged revisions 46249 via svnmerge from
Russell Bryant [Wed, 25 Oct 2006 19:10:43 +0000 (19:10 +0000)]
Merged revisions 46249 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r46249 | russell | 2006-10-25 14:08:18 -0500 (Wed, 25 Oct 2006) | 2 lines

update warning message to include "agi" option (issue #8225, jmls)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@46250 65c4cc65-6c06-0410-ace0-fbb531ad65f3

14 years agoMerged revisions 46237 via svnmerge from
Kevin P. Fleming [Wed, 25 Oct 2006 17:12:59 +0000 (17:12 +0000)]
Merged revisions 46237 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r46237 | kpfleming | 2006-10-25 12:08:58 -0500 (Wed, 25 Oct 2006) | 2 lines

add support for prebuilt G.722 prompts and music on hold files

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@46238 65c4cc65-6c06-0410-ace0-fbb531ad65f3

14 years agoMerge from 1.4
Olle Johansson [Wed, 25 Oct 2006 16:01:22 +0000 (16:01 +0000)]
Merge from 1.4

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@46224 65c4cc65-6c06-0410-ace0-fbb531ad65f3

14 years agoBlock change to 1.4 to block change to 1.2... This is confusing, but
Olle Johansson [Wed, 25 Oct 2006 15:54:47 +0000 (15:54 +0000)]
Block change to 1.4 to block change to 1.2... This is confusing, but
I think I got it right.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@46215 65c4cc65-6c06-0410-ace0-fbb531ad65f3

14 years agoMerged revisions 46082-46083,46152-46153 via svnmerge from
Kevin P. Fleming [Wed, 25 Oct 2006 14:55:11 +0000 (14:55 +0000)]
Merged revisions 46082-46083,46152-46153 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r46082 | kpfleming | 2006-10-23 22:45:42 -0500 (Mon, 23 Oct 2006) | 2 lines

add an API call to allow channel drivers to determine which media formats are compatible (passthrough or transcode) with the format an existing channel is already using

........
r46083 | kpfleming | 2006-10-23 22:53:32 -0500 (Mon, 23 Oct 2006) | 2 lines

ensure that the translation matrix is properly lock-protected every place it is used

........
r46152 | kpfleming | 2006-10-24 18:45:19 -0500 (Tue, 24 Oct 2006) | 2 lines

if multiple translators are registered for the same source/dest combination, ensure that the lowest-cost one is always inserted earlier in the list

........
r46153 | kpfleming | 2006-10-24 19:10:54 -0500 (Tue, 24 Oct 2006) | 2 lines

code zone experiment: don't offer formats in the outbound INVITE that aren't either passthrough or translatable

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@46203 65c4cc65-6c06-0410-ace0-fbb531ad65f3

14 years agorestore bugfix that was reverted by trunk_mtu patch
Kevin P. Fleming [Wed, 25 Oct 2006 14:47:01 +0000 (14:47 +0000)]
restore bugfix that was reverted by trunk_mtu patch

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@46202 65c4cc65-6c06-0410-ace0-fbb531ad65f3

14 years agoMerged revisions 46200 via svnmerge from
Kevin P. Fleming [Wed, 25 Oct 2006 14:44:50 +0000 (14:44 +0000)]
Merged revisions 46200 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r46200 | kpfleming | 2006-10-25 09:32:08 -0500 (Wed, 25 Oct 2006) | 2 lines

apparently developers are still not aware that they should be use ast_copy_string instead of strncpy... fix up many more users, and fix some bugs in the process

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@46201 65c4cc65-6c06-0410-ace0-fbb531ad65f3

14 years agoOk, second attempt...
Olle Johansson [Wed, 25 Oct 2006 14:26:22 +0000 (14:26 +0000)]
Ok, second attempt...

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@46199 65c4cc65-6c06-0410-ace0-fbb531ad65f3

14 years agodocument a couple of recently introduced feature
Luigi Rizzo [Wed, 25 Oct 2006 14:18:00 +0000 (14:18 +0000)]
document a couple of recently introduced feature
also including the version number where the feature appeared.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@46198 65c4cc65-6c06-0410-ace0-fbb531ad65f3

14 years agoOn the other hand, don't use 1.4 patches for trunk... Sorry.
Olle Johansson [Wed, 25 Oct 2006 14:14:53 +0000 (14:14 +0000)]
On the other hand, don't use 1.4 patches for trunk... Sorry.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@46197 65c4cc65-6c06-0410-ace0-fbb531ad65f3

14 years agoAdd ability to adapt the IAX trunk packets to the MTU size, to avoid bad audio
Olle Johansson [Wed, 25 Oct 2006 14:06:13 +0000 (14:06 +0000)]
Add ability to adapt the IAX trunk packets to the MTU size, to avoid bad audio
when the number of channels fill the MTU on a given link.

In the future, this needs to be configurable per peer with trunking enabled.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@46195 65c4cc65-6c06-0410-ace0-fbb531ad65f3

14 years agoAdding comments in the source is more persistent than just adding them
Olle Johansson [Wed, 25 Oct 2006 11:41:49 +0000 (11:41 +0000)]
Adding comments in the source is more persistent than just adding them
to the commit message :-)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@46184 65c4cc65-6c06-0410-ace0-fbb531ad65f3

14 years agoAlways add doxygen comments to new functions, more lines than one are
Olle Johansson [Wed, 25 Oct 2006 11:39:40 +0000 (11:39 +0000)]
Always add doxygen comments to new functions, more lines than one are
appreciated really. (Read the coding guidelines).

I've worked hard to make chan_sip a better place to code in, let's
keep it that way and don't add more stuff without comments.

Thank you.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@46183 65c4cc65-6c06-0410-ace0-fbb531ad65f3

14 years agoBlocked revisions 46165 via svnmerge
Tilghman Lesher [Wed, 25 Oct 2006 05:01:54 +0000 (05:01 +0000)]
Blocked revisions 46165 via svnmerge

........
r46165 | tilghman | 2006-10-24 23:58:44 -0500 (Tue, 24 Oct 2006) | 2 lines

WaitExten truncates decimals of times to wait, instead of accepting them (Bug 8208)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@46166 65c4cc65-6c06-0410-ace0-fbb531ad65f3

14 years agoMerged revisions 46154 via svnmerge from
Kevin P. Fleming [Wed, 25 Oct 2006 00:32:23 +0000 (00:32 +0000)]
Merged revisions 46154 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r46154 | kpfleming | 2006-10-24 19:26:17 -0500 (Tue, 24 Oct 2006) | 2 lines

add passthrough and file format support for G.722 16KHz audio (issue #5084, original patch by andrew, updated by mithraen)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@46155 65c4cc65-6c06-0410-ace0-fbb531ad65f3

14 years agoFix FastAGI to not wait for the non-existant pid
Mark Spencer [Tue, 24 Oct 2006 20:22:29 +0000 (20:22 +0000)]
Fix FastAGI to not wait for the non-existant pid

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@46141 65c4cc65-6c06-0410-ace0-fbb531ad65f3

14 years agoMerged revisions 46130 via svnmerge from
Joshua Colp [Tue, 24 Oct 2006 19:33:02 +0000 (19:33 +0000)]
Merged revisions 46130 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r46130 | file | 2006-10-24 15:29:56 -0400 (Tue, 24 Oct 2006) | 2 lines

We need to initialize our scheduler pthread condition... yes.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@46131 65c4cc65-6c06-0410-ace0-fbb531ad65f3

14 years agoi really think it is safe to commit this version, that
Luigi Rizzo [Tue, 24 Oct 2006 17:14:12 +0000 (17:14 +0000)]
i really think it is safe to commit this version, that
simplifies the manager queue handling as described in
the comment, and will make a lot easier to make further
work on this code.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@46120 65c4cc65-6c06-0410-ace0-fbb531ad65f3

14 years agocorrect fix for the bug i previously introduced - the strings
Luigi Rizzo [Tue, 24 Oct 2006 06:52:15 +0000 (06:52 +0000)]
correct fix for the bug i previously introduced - the strings
are meant to be always initialized, independently from their content.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@46104 65c4cc65-6c06-0410-ace0-fbb531ad65f3

14 years agoMerged revisions 46093 via svnmerge from
Russell Bryant [Tue, 24 Oct 2006 05:24:32 +0000 (05:24 +0000)]
Merged revisions 46093 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r46093 | russell | 2006-10-24 01:23:33 -0400 (Tue, 24 Oct 2006) | 3 lines

Restore the ability to remove the firmware directory without causing the
installation to fail (issue #8111)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@46094 65c4cc65-6c06-0410-ace0-fbb531ad65f3

14 years agoMerged revisions 46080 via svnmerge from
Kevin P. Fleming [Tue, 24 Oct 2006 03:15:31 +0000 (03:15 +0000)]
Merged revisions 46080 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r46080 | kpfleming | 2006-10-23 22:13:08 -0500 (Mon, 23 Oct 2006) | 2 lines

simplify and correct voicemail IMAP storage build instructions

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@46081 65c4cc65-6c06-0410-ace0-fbb531ad65f3

14 years agoMerged revisions 46078 via svnmerge from
Tilghman Lesher [Tue, 24 Oct 2006 03:09:48 +0000 (03:09 +0000)]
Merged revisions 46078 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r46078 | tilghman | 2006-10-23 22:01:00 -0500 (Mon, 23 Oct 2006) | 3 lines

Pass through a frame if we don't know what it is, rather than trying to pass a
NULL, which will segfault a channel driver (Bug 8149)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@46079 65c4cc65-6c06-0410-ace0-fbb531ad65f3

14 years agoMerged revisions 46067 via svnmerge from
Russell Bryant [Tue, 24 Oct 2006 01:28:45 +0000 (01:28 +0000)]
Merged revisions 46067 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r46067 | russell | 2006-10-23 21:27:42 -0400 (Mon, 23 Oct 2006) | 7 lines

In muted.c, check the return value of strdup.  In ael_main.c, check the return
value of calloc.  (issue #8157)

In passing fix a few minor bugs in ael_main.c.  The last argument to strncpy()
was a hard-coded 100, where it should have been 99.  I changed this to use
sizeof() - 1.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@46068 65c4cc65-6c06-0410-ace0-fbb531ad65f3

14 years agoMerged revisions 46065 via svnmerge from
Russell Bryant [Tue, 24 Oct 2006 01:05:11 +0000 (01:05 +0000)]
Merged revisions 46065 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r46065 | russell | 2006-10-23 21:04:14 -0400 (Mon, 23 Oct 2006) | 2 lines

Fix the descriptions of some of the MeetMeAdmin options (issue #8098, mflorell)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@46066 65c4cc65-6c06-0410-ace0-fbb531ad65f3

14 years agoFix a seg fault on a registration. Line 7706, in parse_register_contact,
Russell Bryant [Tue, 24 Oct 2006 00:52:06 +0000 (00:52 +0000)]
Fix a seg fault on a registration.  Line 7706, in parse_register_contact,
explicitly passes NULL as the "pass" argument to this function.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@46055 65c4cc65-6c06-0410-ace0-fbb531ad65f3

14 years agoUnlike ast_strdup(), ast_strdupa() does not take a NULL pointer as argument,
Luigi Rizzo [Mon, 23 Oct 2006 21:46:15 +0000 (21:46 +0000)]
Unlike ast_strdup(), ast_strdupa() does not take a NULL pointer as argument,
so fix the places where this might happen.

This is also a fix that ought to go into 1.4

[The difference between the two functions is a bit confusing,
and in asterisk i believe all string handling functions
should be able to handl a NULL string as argument,
but changing the API in trunk and not in 1.4 would make
backporting harder.]

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@46045 65c4cc65-6c06-0410-ace0-fbb531ad65f3

14 years agoremove a useless check for ocseq = 0.
Luigi Rizzo [Mon, 23 Oct 2006 20:01:14 +0000 (20:01 +0000)]
remove a useless check for ocseq = 0.
As discussed on the mailing lists, 0 is a legal value
for Cseq, so there is no point to treat it specially.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@46035 65c4cc65-6c06-0410-ace0-fbb531ad65f3

14 years agoget_header() always returns a non-NULL value, so checking
Luigi Rizzo [Mon, 23 Oct 2006 19:52:43 +0000 (19:52 +0000)]
get_header() always returns a non-NULL value, so checking
for NULL is certainly wrong and usually disables the
checks that we want to make instead.

This commit fixes a number of the above bugs where the result
of get_header() is immediately checked for NULL.

This is certainly a candidate for merging into 1.4

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@46026 65c4cc65-6c06-0410-ace0-fbb531ad65f3

14 years agoput another duplicated block of code in a function.
Luigi Rizzo [Mon, 23 Oct 2006 19:28:23 +0000 (19:28 +0000)]
put another duplicated block of code in a function.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@46025 65c4cc65-6c06-0410-ace0-fbb531ad65f3

14 years agoreformat a statement and comment a potentially wrong
Luigi Rizzo [Mon, 23 Oct 2006 18:38:42 +0000 (18:38 +0000)]
reformat a statement and comment a potentially wrong
assignement (altering state on an unvalidated message).

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@46015 65c4cc65-6c06-0410-ace0-fbb531ad65f3

14 years agoRemove unnecessary casts from const char * to char *,
Luigi Rizzo [Mon, 23 Oct 2006 17:49:09 +0000 (17:49 +0000)]
Remove unnecessary casts from const char * to char *,
if necessary by slightly rearranging the code.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@46004 65c4cc65-6c06-0410-ace0-fbb531ad65f3

14 years agoanother use for parse_uri().
Luigi Rizzo [Mon, 23 Oct 2006 17:41:03 +0000 (17:41 +0000)]
another use for parse_uri().
On passing, remove a wrong comment (that probably I wrote
myself!) and introduce a temporary variable to avoid a
misleading cast.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@46003 65c4cc65-6c06-0410-ace0-fbb531ad65f3

14 years agoMerged revisions 45999 via svnmerge from
Russell Bryant [Mon, 23 Oct 2006 17:08:53 +0000 (17:08 +0000)]
Merged revisions 45999 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r45999 | russell | 2006-10-23 13:07:45 -0400 (Mon, 23 Oct 2006) | 2 lines

don't crash when an incoming message has no "from" (issue #8205, jmls)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@46000 65c4cc65-6c06-0410-ace0-fbb531ad65f3

14 years agouse autodetected support for gethostbyname_r
Luigi Rizzo [Mon, 23 Oct 2006 16:54:54 +0000 (16:54 +0000)]
use autodetected support for gethostbyname_r

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@45989 65c4cc65-6c06-0410-ace0-fbb531ad65f3

14 years ago+ make sure parse_uri never returns NULL pointers - this
Luigi Rizzo [Mon, 23 Oct 2006 15:45:36 +0000 (15:45 +0000)]
+ make sure parse_uri never returns NULL pointers - this
  simplifies its usage.

+ add another client for parse_uri, in handling Contact: strings
  (on passing, document the content of the "fullcontact" field);

+ in register_verify(), mark with XXX what i believe is another
  misinterpretation on the URI format when '@' is missing.
  No code changed here, so no fixes applied.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@45977 65c4cc65-6c06-0410-ace0-fbb531ad65f3

14 years agoAfter reading better the SIP RFC on sip URI (19.1.1)
Luigi Rizzo [Mon, 23 Oct 2006 15:08:40 +0000 (15:08 +0000)]
After reading better the SIP RFC on sip URI (19.1.1)
fix parse_uri() to interpret a missing userinfo
section as a domain-only URI, and comment a wrong
interpretation of the above in check_user_full().

The function has been patched to preserve the existing
behaviour (in what admittedly is a corner case, but
could be received under attacks).
Hopefully the From: based matching will go away soon!

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@45976 65c4cc65-6c06-0410-ace0-fbb531ad65f3

14 years agoin function get_also_info(), move argument stripping
Luigi Rizzo [Mon, 23 Oct 2006 14:35:37 +0000 (14:35 +0000)]
in function get_also_info(), move argument stripping
before splitting around the @, otherwise the refer_to_domain
might contain arguments as well, causing failures.

I think this is a true bug that ought to be fixed in 1.4 as well.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@45966 65c4cc65-6c06-0410-ace0-fbb531ad65f3

14 years agostart putting the URI parsing code in one place,
Luigi Rizzo [Mon, 23 Oct 2006 14:30:33 +0000 (14:30 +0000)]
start putting the URI parsing code in one place,
introducing the function parse_uri() that splits
a URI in its components.

Right now use it only in one place, because the custom
parsing that is done here and there sometimes has
bugs that i want to figure out first.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@45965 65c4cc65-6c06-0410-ace0-fbb531ad65f3

14 years agoput common code in function terminate_uri() so we need to
Luigi Rizzo [Mon, 23 Oct 2006 13:19:13 +0000 (13:19 +0000)]
put common code in function terminate_uri() so we need to
fix it only in one place.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@45955 65c4cc65-6c06-0410-ace0-fbb531ad65f3

14 years agoMore cleanup of check_user_full with no functional change
Luigi Rizzo [Mon, 23 Oct 2006 11:08:47 +0000 (11:08 +0000)]
More cleanup of check_user_full with no functional change
apart from a small (but disabled by default) new option.
In detail:

+ introduce a new value for enum check_auth_result, AUTH_DONT_KNOW,
  used (read below) when a function does not have a conclusive response.
  Possibly this is the same as AUTH_NOT_FOUND, but need to check further.

+ move the large blocks (checking in the users list and in the peers
  list, respectively) from check_user_full() to separate functions.
  They return AUTH_DONT_KNOW in case they don't find a match, so
  the caller know that it has to try the next method.
     There is still some duplication of code here, but i
  have not tried yet to remove it.

+ [new option] a new option in sip.conf, match_auth_username,
  has been introduced, and disabled by default.
  If set, and the incoming request carries authentication info,
  the username to match in the users list is taken from there
  rather than from the From: field.
        This change is easy to identify, being made of
  - one line to declare the variable match_auth_username
  - a block of 15 lines in check_user_full()
  - one line in sip list settings
  - two lines for parsing the config file.

check_user_full() is now a lot cleaner - basically a sequence of
checks that are applied to the request. This will help future
work with new matching schemes.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@45945 65c4cc65-6c06-0410-ace0-fbb531ad65f3

14 years agoMerged revisions 45928 via svnmerge from
Joshua Colp [Mon, 23 Oct 2006 00:33:20 +0000 (00:33 +0000)]
Merged revisions 45928 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
r45928 | file | 2006-10-22 20:27:39 -0400 (Sun, 22 Oct 2006) | 10 lines

Merged revisions 45927 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r45927 | file | 2006-10-22 20:25:28 -0400 (Sun, 22 Oct 2006) | 2 lines

Don't leak memory mmmk?

........

................

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@45929 65c4cc65-6c06-0410-ace0-fbb531ad65f3

14 years agoMerged revisions 45916 via svnmerge from
Christian Richter [Sun, 22 Oct 2006 21:57:11 +0000 (21:57 +0000)]
Merged revisions 45916 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
r45916 | crichter | 2006-10-22 23:44:46 +0200 (Sun, 22 Oct 2006) | 9 lines

Merged revisions 45808 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r45808 | crichter | 2006-10-21 14:35:13 +0200 (Sat, 21 Oct 2006) | 1 line

fixed issue, that if chan_misdn is loaded and couldn't be initialized it would cause a segfault after 'reload'. Reported by Drew/Matt thx.
........

................

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@45917 65c4cc65-6c06-0410-ace0-fbb531ad65f3

14 years agomore streamlining of check_user_full
Luigi Rizzo [Sun, 22 Oct 2006 21:08:07 +0000 (21:08 +0000)]
more streamlining of check_user_full

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@45915 65c4cc65-6c06-0410-ace0-fbb531ad65f3

14 years agosimplify the flow of function check_user_full()
Luigi Rizzo [Sun, 22 Oct 2006 20:59:38 +0000 (20:59 +0000)]
simplify the flow of function check_user_full()

A large block needs reindentation now, but we don't do that because
it can be moved to a separate function.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@45905 65c4cc65-6c06-0410-ace0-fbb531ad65f3

14 years agoput duplicated code in functions.
Luigi Rizzo [Sun, 22 Oct 2006 20:51:05 +0000 (20:51 +0000)]
put duplicated code in functions.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@45904 65c4cc65-6c06-0410-ace0-fbb531ad65f3

14 years agoregenerate the configure script and autoconfig.h.in to reflect recent changes
Russell Bryant [Sun, 22 Oct 2006 19:34:30 +0000 (19:34 +0000)]
regenerate the configure script and autoconfig.h.in to reflect recent changes
for https support for the built in http server

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@45893 65c4cc65-6c06-0410-ace0-fbb531ad65f3

14 years agoFix a few issues in the previous (disabled) HTTPS code,
Luigi Rizzo [Sun, 22 Oct 2006 19:09:25 +0000 (19:09 +0000)]
Fix a few issues in the previous (disabled) HTTPS code,
and support linux as well (using fopencookie(), which should
be available in glibc).

Update configure.ac to check for funopen (BSD) and fopencookie(glibc),
and while we are at it also for gethostbyname_r
(the generated files need to be updated, or you need
to run bootstrap.sh yourself).

Document the new options in http.conf.sample
(names are only tentative, better ones are welcome).

At this point we can safely enable the option.
Anyone willing to try this on Sun and Apple platforms ?

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@45892 65c4cc65-6c06-0410-ace0-fbb531ad65f3

14 years agoImplement https support.
Luigi Rizzo [Sun, 22 Oct 2006 12:02:35 +0000 (12:02 +0000)]
Implement https support.

The changes are not large. Most of the diff comes from putting the
global variables describing an accept session into a structure, so
we can reuse the existing code for running multiple accept threads
on different ports.

Once this is done, and if your system has the funopen() library
function (and ssl, of course), it is just a matter of calling
the appropriate functions to set up the ssl connection on the
existing socket, and everything works on the secure channel now.

At the moment, the code is disabled because i have not implemented yet
the autoconf code to detect the presence of funopen(), and add -lssl
to main/Makefile if ssl libraries are present. And a bit of documentation
on the http.conf arguments, too.

If you want to manually enable https support, that is very simple
(step 0 1 2 will be eventually detected by ./configure, the
rest is something you will have to do anyways).

0. make sure your system has funopen(3). FreeBSD does, linux probably
   does too, not sure about other systems.

1. uncomment the following line in main/http.c
   // #define      DO_SSL  /* comment in/out if you want to support ssl */

2. add -lssl to AST_LIBS in main/Makefile

3. add the following options to http.conf

sslenable=yes
sslbindport=4433 ; pick one you like
sslcert=/tmp/foo.pem ; path to your certificate file.

4. generate a suitable certificate e.g. (example from mini_httpd's Makefile:

openssl req -new -x509 -days 365 -nodes -out /tmp/foo.pem -keyout /tmp/foo.pem

and here you go:

https://localhost:4433/asterisk/manager

now works.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@45869 65c4cc65-6c06-0410-ace0-fbb531ad65f3

14 years agoit is useless and possibly wrong to use ast_cli() to send the
Luigi Rizzo [Sun, 22 Oct 2006 08:28:16 +0000 (08:28 +0000)]
it is useless and possibly wrong to use ast_cli() to send the
reply back to http clients.
Use fprintf/fwrite instead, since we are already using a FILE *
to read the input.

If you wonder why, this is because it makes it trivial to
implement https support (as long as your system has funopen()).

And this is what i am going to put in with the next few commits...

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@45858 65c4cc65-6c06-0410-ace0-fbb531ad65f3

14 years agoLet's have build.h created a bit earlier so that func_version can use it and not...
Joshua Colp [Sun, 22 Oct 2006 04:44:43 +0000 (04:44 +0000)]
Let's have build.h created a bit earlier so that func_version can use it and not stop the build on a fresh machine that has never had Asterisk installed on it before...

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@45847 65c4cc65-6c06-0410-ace0-fbb531ad65f3

14 years agothe default port number was erroneously stored in host order,
Luigi Rizzo [Sat, 21 Oct 2006 20:24:04 +0000 (20:24 +0000)]
the default port number was erroneously stored in host order,
and reading from the config file used ntohs instead of htons.

this ought to be merged to 1.4 as well.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@45836 65c4cc65-6c06-0410-ace0-fbb531ad65f3

14 years agoMerged revisions 45817 via svnmerge from
Joshua Colp [Sat, 21 Oct 2006 18:52:33 +0000 (18:52 +0000)]
Merged revisions 45817 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r45817 | file | 2006-10-21 14:48:58 -0400 (Sat, 21 Oct 2006) | 2 lines

Don't use promotion on Darwin because it doesn't seem to work quite right in all cases, this should solve the unresolved symbol issue people have been seeing.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@45820 65c4cc65-6c06-0410-ace0-fbb531ad65f3

14 years agoMerged revisions 45818 via svnmerge from
Russell Bryant [Sat, 21 Oct 2006 18:50:38 +0000 (18:50 +0000)]
Merged revisions 45818 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r45818 | russell | 2006-10-21 14:49:46 -0400 (Sat, 21 Oct 2006) | 3 lines

Add a couple missing unregistrations of manager actions and remove duplicate
unregistrations of applications.  (issue #8194, jmls)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@45819 65c4cc65-6c06-0410-ace0-fbb531ad65f3

14 years agointroduce sip_pvt_lock() and sip_pvt_unlock() wrappers to
Luigi Rizzo [Fri, 20 Oct 2006 20:59:06 +0000 (20:59 +0000)]
introduce sip_pvt_lock() and sip_pvt_unlock() wrappers to
lock these data structures.

This improve readability, and also hides the underlying
locking mechanism so it is a lot easier to add diagnostic
code, or move the object locks somewhere else, etc.

On passing, rename the lock field in sip_pvt to pvt_lock,
also for ease of readability.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@45786 65c4cc65-6c06-0410-ace0-fbb531ad65f3

14 years agoMerged revisions 45775 via svnmerge from
Joshua Colp [Fri, 20 Oct 2006 19:04:23 +0000 (19:04 +0000)]
Merged revisions 45775 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r45775 | file | 2006-10-20 15:03:03 -0400 (Fri, 20 Oct 2006) | 2 lines

Pass DESTDIR and ASTSBINDIR so that the utilities get installed in the proper location (reported on asterisk-dev mailing list)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@45776 65c4cc65-6c06-0410-ace0-fbb531ad65f3

14 years agoput the constants for whether methods can create a dialog or not in an enum
Russell Bryant [Fri, 20 Oct 2006 15:54:14 +0000 (15:54 +0000)]
put the constants for whether methods can create a dialog or not in an enum

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@45764 65c4cc65-6c06-0410-ace0-fbb531ad65f3

14 years agominor comment changes, code rearrangement and field renaming
Luigi Rizzo [Fri, 20 Oct 2006 11:24:43 +0000 (11:24 +0000)]
minor comment changes, code rearrangement and field renaming
to minimize diffs with future modifications.

The current implementation is problematic for the following reasons:
+ all insertions are O(N) because the event list does not have a tail
  pointer;
+ there is only a single lock protecting both session and users queues.
+ the implementation of the queue itself is not documented.
  I think i have figured it out, more or less, but am unclear on
  whether there is proper locking in place

The rewrite (which i have working locally) uses a tailq so insertions
are O(1), separate locks for the event and session queues, and has
a documented implementation so hopefully we can figure out if/where
bug exist.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@45753 65c4cc65-6c06-0410-ace0-fbb531ad65f3

14 years agoLet's repair the SIP attack shield :-)
Olle Johansson [Fri, 20 Oct 2006 08:14:14 +0000 (08:14 +0000)]
Let's repair the SIP attack shield :-)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@45743 65c4cc65-6c06-0410-ace0-fbb531ad65f3

14 years agoDoxygen corrections
Olle Johansson [Fri, 20 Oct 2006 08:00:13 +0000 (08:00 +0000)]
Doxygen corrections

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@45742 65c4cc65-6c06-0410-ace0-fbb531ad65f3

14 years agoThis new function, VERSION(), created via bug report 8176, may help dialplan programm...
Steve Murphy [Thu, 19 Oct 2006 22:06:27 +0000 (22:06 +0000)]
This new function, VERSION(), created via bug report 8176, may help dialplan programmers in the future. In the meantime, they can use the algorithm I outline on the bug report notes; If anyone invents something better, I'd hope they post it

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@45724 65c4cc65-6c06-0410-ace0-fbb531ad65f3

14 years agoastman was slightly weirding out over the new Dial and Newcallerid events
Steve Murphy [Thu, 19 Oct 2006 19:32:25 +0000 (19:32 +0000)]
astman was slightly weirding out over the new Dial and Newcallerid events

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@45712 65c4cc65-6c06-0410-ace0-fbb531ad65f3

14 years agomore fixes to comments and very minor code rearrangement.
Luigi Rizzo [Thu, 19 Oct 2006 17:26:20 +0000 (17:26 +0000)]
more fixes to comments and very minor code rearrangement.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@45696 65c4cc65-6c06-0410-ace0-fbb531ad65f3

14 years agoMerged revisions 45694 via svnmerge from
Joshua Colp [Thu, 19 Oct 2006 17:25:43 +0000 (17:25 +0000)]
Merged revisions 45694 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r45694 | file | 2006-10-19 13:24:40 -0400 (Thu, 19 Oct 2006) | 2 lines

Let's remember to unregister JabberStatus too (issue #8184 reported by jmls)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@45695 65c4cc65-6c06-0410-ace0-fbb531ad65f3

14 years agoMerged revisions 45692 via svnmerge from
Joshua Colp [Thu, 19 Oct 2006 17:22:13 +0000 (17:22 +0000)]
Merged revisions 45692 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
r45692 | file | 2006-10-19 13:19:47 -0400 (Thu, 19 Oct 2006) | 10 lines

Merged revisions 45691 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r45691 | file | 2006-10-19 13:16:37 -0400 (Thu, 19 Oct 2006) | 2 lines

Respect language selection when seeing if the file exists (issue #8178 reported by mnicholson)

........

................

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@45693 65c4cc65-6c06-0410-ace0-fbb531ad65f3

14 years agoimplement proper XML/HTML formatting of multiple messages
Luigi Rizzo [Thu, 19 Oct 2006 17:07:08 +0000 (17:07 +0000)]
implement proper XML/HTML formatting of multiple messages
(e.g. the result of waitevent).

Also fix some comments.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@45690 65c4cc65-6c06-0410-ace0-fbb531ad65f3

14 years agoMerged revisions 45678 via svnmerge from
Joshua Colp [Thu, 19 Oct 2006 16:06:14 +0000 (16:06 +0000)]
Merged revisions 45678 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r45678 | file | 2006-10-19 12:03:09 -0400 (Thu, 19 Oct 2006) | 2 lines

If the jitterbuffer is forced on then we can't partially bridge (reported by wangster on #asterisk-dev)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@45679 65c4cc65-6c06-0410-ace0-fbb531ad65f3

14 years agomove a large block out of do_monitor() and into a function,
Luigi Rizzo [Thu, 19 Oct 2006 10:05:02 +0000 (10:05 +0000)]
move a large block out of do_monitor() and into a function,
to improve readability.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@45668 65c4cc65-6c06-0410-ace0-fbb531ad65f3

14 years ago+ move the definition of netlock as it was not related to the
Luigi Rizzo [Thu, 19 Oct 2006 09:54:51 +0000 (09:54 +0000)]
+ move the definition of netlock as it was not related to the
  comment just above;

+ decouple the struct definition and variable declaration (iflist);

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@45658 65c4cc65-6c06-0410-ace0-fbb531ad65f3

14 years agomore documentation of data structure and functions.
Luigi Rizzo [Thu, 19 Oct 2006 07:43:43 +0000 (07:43 +0000)]
more documentation of data structure and functions.
Of interest:
+ ast_get_manager_by_name_locked() is now without the ast_
  prefix as it is a local function;

+ unuse_eventqent() renamed to unref_event(), and returns
  the pointer to the next entry.

+ marked with XXX a couple of usages of unref_event()
  because i suspect we are addressing the wrong entry.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@45648 65c4cc65-6c06-0410-ace0-fbb531ad65f3

14 years agoCleaning up... Removing duplicate (again)
Olle Johansson [Thu, 19 Oct 2006 07:17:13 +0000 (07:17 +0000)]
Cleaning up... Removing duplicate (again)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@45647 65c4cc65-6c06-0410-ace0-fbb531ad65f3

14 years agorestore freeing of threadstorage objects without custom cleanup functions
Kevin P. Fleming [Thu, 19 Oct 2006 02:16:34 +0000 (02:16 +0000)]
restore freeing of threadstorage objects without custom cleanup functions
allow custom threadstorage init functions to return failure
use a custom init function for chan_sip's temp_pvt, to improve performance a bit

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@45634 65c4cc65-6c06-0410-ace0-fbb531ad65f3

14 years agoMerge fix to not leak the stringfields of a thread speicif sip_pvt. This also
Russell Bryant [Thu, 19 Oct 2006 01:04:18 +0000 (01:04 +0000)]
Merge fix to not leak the stringfields of a thread speicif sip_pvt.  This also
includes the fix not to leak the actual sip_pvt.

Merged revisions 45622 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r45622 | russell | 2006-10-18 20:59:51 -0400 (Wed, 18 Oct 2006) | 2 lines

Don't leak the actual thread-specific sip_pvt struct

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@45624 65c4cc65-6c06-0410-ace0-fbb531ad65f3

14 years agoExtend the thread storage API such that a custom initialization function can
Russell Bryant [Thu, 19 Oct 2006 01:00:57 +0000 (01:00 +0000)]
Extend the thread storage API such that a custom initialization function can
be called for each thread specific object after they are allocated.  Note that
there was already the ability to define a custom cleanup function.  Also, if
the custom cleanup function is used, it *MUST* call free on the thread
specific object at the end.  There is no way to have this magically done that
I can think of because the cleanup function registered with the pthread
implementation will only call the function back with a pointer to the
thread specific object, not the parent ast_threadstorage object.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@45623 65c4cc65-6c06-0410-ace0-fbb531ad65f3

14 years agosilent warning from a debugging message (which will go away
Luigi Rizzo [Wed, 18 Oct 2006 22:40:02 +0000 (22:40 +0000)]
silent warning from a debugging message (which will go away
soon, anyways)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@45611 65c4cc65-6c06-0410-ace0-fbb531ad65f3

14 years agoJust for Nicholson - here's an option, C, to Meetme that will allow it to continue...
Joshua Colp [Wed, 18 Oct 2006 22:19:57 +0000 (22:19 +0000)]
Just for Nicholson - here's an option, C, to Meetme that will allow it to continue in the dialplan if the person is kicked out. (issue #7994 reported by mnicholson with mods by myself)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@45610 65c4cc65-6c06-0410-ace0-fbb531ad65f3

14 years agoremove trailing whitespace
Luigi Rizzo [Wed, 18 Oct 2006 21:41:09 +0000 (21:41 +0000)]
remove trailing whitespace

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@45599 65c4cc65-6c06-0410-ace0-fbb531ad65f3

14 years agoouch! remember to unlink temporary files once done with them.
Luigi Rizzo [Wed, 18 Oct 2006 21:36:20 +0000 (21:36 +0000)]
ouch! remember to unlink temporary files once done with them.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@45598 65c4cc65-6c06-0410-ace0-fbb531ad65f3

14 years ago+ move output_format variables in the http section of the file;
Luigi Rizzo [Wed, 18 Oct 2006 21:30:21 +0000 (21:30 +0000)]
+ move output_format variables in the http section of the file;
+ more comments on struct mansession and global variables;
+ small improvements to the session matching code so it supports
  multiple sessions from the same IP

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@45597 65c4cc65-6c06-0410-ace0-fbb531ad65f3

14 years agoMerged revisions 45595 via svnmerge from
Joshua Colp [Wed, 18 Oct 2006 21:05:52 +0000 (21:05 +0000)]
Merged revisions 45595 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r45595 | file | 2006-10-18 17:03:34 -0400 (Wed, 18 Oct 2006) | 2 lines

Don't modify things if we are using vfork as this is very bad and may cause unexpected behavior (issue #7970 reported by Nick Gavrikov)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@45596 65c4cc65-6c06-0410-ace0-fbb531ad65f3

14 years agoanother bunch of comments on the data structures.
Luigi Rizzo [Wed, 18 Oct 2006 17:53:47 +0000 (17:53 +0000)]
another bunch of comments on the data structures.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@45583 65c4cc65-6c06-0410-ace0-fbb531ad65f3

14 years agodespite the large changes, this commit only moves functions
Luigi Rizzo [Wed, 18 Oct 2006 17:45:50 +0000 (17:45 +0000)]
despite the large changes, this commit only moves functions
around so that functions belonging to the same group are
close to each other.

At the beginning of each group i have added a bit of documentation
to explain what the group does and what is the typical flow - basically,
all i have learned by code inspection over the past few days should
be documented for you to read.

I have not put many doxygen annotations just because i am not
sure what are the proper ones. Hopefully some doxygen experts will jump in.

Next on the plate: try to figure out how "struct eventqent"
are supposed to work.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@45582 65c4cc65-6c06-0410-ace0-fbb531ad65f3

14 years agomore comment and formatting fixes, small simplifications
Luigi Rizzo [Wed, 18 Oct 2006 16:52:13 +0000 (16:52 +0000)]
more comment and formatting fixes, small simplifications
to functions get_input() and session_do()

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@45572 65c4cc65-6c06-0410-ace0-fbb531ad65f3

14 years agorizzo compile then commit, maybe even run it too ^_^
Matt O'Gorman [Wed, 18 Oct 2006 16:45:22 +0000 (16:45 +0000)]
rizzo compile then commit, maybe even run it too ^_^

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@45571 65c4cc65-6c06-0410-ace0-fbb531ad65f3

14 years agocomment and cleanup the main thread.
Luigi Rizzo [Wed, 18 Oct 2006 15:49:40 +0000 (15:49 +0000)]
comment and cleanup the main thread.
On passing, fix a bug: close the socket if the allocation
of a structure for the new session fails.
(the bugfix is a candidate for 1.4)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@45561 65c4cc65-6c06-0410-ace0-fbb531ad65f3