asterisk/asterisk.git
12 months agocontrib/sip_to_pjsip: add a --quiet option to avoid prints
Pascal Cadotte Michaud [Fri, 26 Oct 2018 15:53:40 +0000 (11:53 -0400)]
contrib/sip_to_pjsip: add a --quiet option to avoid prints

Using the --quiet or -q option in conjonction with /dev/stdout as the output
file allow the output to be used as a valid configuration.

Given a script that generates a valid sip.conf I can pipe the output of that
script into `sip_to_pjsip.py -q /dev/stdin /dev/stdout`. This allow me to use
that piped command in my pjsip.conf using the `exec` command.

ASTERISK-28136

Change-Id: I7b0e2e90e2549f3f8e01dc96701f111b5874c88d

12 months agoMerge "res_pjsip: Add XML documentation for "use_callerid_contact""
George Joseph [Wed, 31 Oct 2018 18:58:52 +0000 (13:58 -0500)]
Merge "res_pjsip: Add XML documentation for "use_callerid_contact""

12 months agoMerge "alembic: Fix use_callerid_contact option add script."
George Joseph [Wed, 31 Oct 2018 18:58:31 +0000 (13:58 -0500)]
Merge "alembic: Fix use_callerid_contact option add script."

12 months agoMerge "pjsip: new endpoint's options to control Connected Line updates"
George Joseph [Wed, 31 Oct 2018 18:57:15 +0000 (13:57 -0500)]
Merge "pjsip: new endpoint's options to control Connected Line updates"

12 months agoMerge "contrib/sip_to_pjsip: handle setvar in conversion"
George Joseph [Wed, 31 Oct 2018 18:55:48 +0000 (13:55 -0500)]
Merge "contrib/sip_to_pjsip: handle setvar in conversion"

12 months agoMerge "chan_sip deprecation."
George Joseph [Wed, 31 Oct 2018 18:53:07 +0000 (13:53 -0500)]
Merge "chan_sip deprecation."

12 months agores_pjsip: Add XML documentation for "use_callerid_contact"
Joshua Colp [Wed, 31 Oct 2018 12:53:08 +0000 (12:53 +0000)]
res_pjsip: Add XML documentation for "use_callerid_contact"

ASTERISK-28087

Change-Id: I69d48813ec514f5ef06c6de994cba52630e0a3b4

12 months agoalembic: Fix use_callerid_contact option add script.
Richard Mudgett [Tue, 30 Oct 2018 15:52:28 +0000 (10:52 -0500)]
alembic: Fix use_callerid_contact option add script.

ASTERISK-28087

Change-Id: I046d018015427d0916fab571b5a4f5367476f729

12 months agopjsip: new endpoint's options to control Connected Line updates
Alexei Gradinari [Mon, 22 Oct 2018 16:49:37 +0000 (12:49 -0400)]
pjsip: new endpoint's options to control Connected Line updates

This patch adds new options 'trust_connected_line' and 'send_connected_line'
to the endpoint.

The option 'trust_connected_line' is to control if connected line updates
are accepted from this endpoint.

The option 'send_connected_line' is to control if connected line updates
can be sent to this endpoint.

The default value is 'yes' for both options.

Change-Id: I16af967815efd904597ec2f033337e4333d097cd

12 months agocontrib/sip_to_pjsip: handle setvar in conversion
Pascal Cadotte Michaud [Sat, 27 Oct 2018 14:59:15 +0000 (10:59 -0400)]
contrib/sip_to_pjsip: handle setvar in conversion

Given a sip.conf with the following content:

setvar FOO=1
setvar BAR=42

I want my generated pjsip.conf to containt the following set_vars

set_var FOO=1
set_var BAR=42

in the matching endpoint section.

Change-Id: I6c822401fda4133c3b44bf31e655b4eb939d4d26

12 months agoMerge "res_pjsip_notify: improve realtime performance on CLI completion on the endpoint"
George Joseph [Mon, 29 Oct 2018 18:23:05 +0000 (13:23 -0500)]
Merge "res_pjsip_notify: improve realtime performance on CLI completion on the endpoint"

12 months agores_pjsip_notify: improve realtime performance on CLI completion on the endpoint
Alexei Gradinari [Fri, 26 Oct 2018 21:18:38 +0000 (17:18 -0400)]
res_pjsip_notify: improve realtime performance on CLI completion on the endpoint

The module 'res_pjsip_notify' inefficiently makes a lot of DB requests
on CLI completion on the endpoint.

For example if there are 10k endpoints the module makes 10k requests
of these 10k records.

Even if a part of the endpoint entered
the module makes the same 10k requests and then filtered them by itself.

This patch gathers endpoints container by prefix
and adds all gathered endpoints to completion at once.

ASTERISK-28137 #close

Change-Id: Ic20024912cc77bf4d3e476c4cd853293c52b254b

12 months agores_pjsip_session: add new flag use_callerid_contact
Torrey Searle [Tue, 2 Oct 2018 12:31:43 +0000 (14:31 +0200)]
res_pjsip_session: add new flag use_callerid_contact

Add a new global flag to res_pjsip to allow the callerid to be used
as the username in the contact header.  This allows chan_pjsip to have
the same behavour as chan_sip

ASTERISK-28087 #close

Change-Id: I9a720e058323f6862a91c62f8a8c1a4b5c087b95

12 months agochan_sip deprecation.
Corey Farrell [Wed, 10 Oct 2018 12:09:15 +0000 (08:09 -0400)]
chan_sip deprecation.

This officially deprecates chan_sip in Asterisk 17+.  A warning is
printed upon startup or module load to tell users that they should
consider migrating.  chan_sip is still built by default but the default
modules.conf skips loading it at startup.

Very important to note we are not scheduling a time where chan_sip will
be removed.  The goal of this change is to accurately inform end users
of the current state of chan_sip and encourage movement to the fully
supported chan_pjsip.

Change-Id: Icebd8848f63feab94ef882d36b2e99d73155af93

12 months agoUPDATE.txt: Fix formatting to match previous files.
Corey Farrell [Thu, 25 Oct 2018 12:54:19 +0000 (08:54 -0400)]
UPDATE.txt: Fix formatting to match previous files.

Add 'Section:' headings and use '-' for bullet points.

Change-Id: I7e2be35601ac8fea53b90d926da564512b6716e4

12 months agoMerge "res_parking: Stop setting the deprecated PARKINGSLOT channel variable."
Joshua Colp [Thu, 25 Oct 2018 12:50:52 +0000 (07:50 -0500)]
Merge "res_parking: Stop setting the deprecated PARKINGSLOT channel variable."

12 months agoMerge "app_dial/queue/followme: 'I' options to block initial updates in both directions"
Joshua Colp [Thu, 25 Oct 2018 12:46:38 +0000 (07:46 -0500)]
Merge "app_dial/queue/followme: 'I' options to block initial updates in both directions"

12 months agoMerge "bridge_softmix: Add SDP "label" attribute to streams"
Joshua Colp [Thu, 25 Oct 2018 12:45:23 +0000 (07:45 -0500)]
Merge "bridge_softmix:  Add SDP "label" attribute to streams"

12 months agoMerge "say: Remove legacy language deprecation logic"
George Joseph [Thu, 25 Oct 2018 12:38:09 +0000 (07:38 -0500)]
Merge "say: Remove legacy language deprecation logic"

12 months agoMerge "logger.c: Fix default console logging when no logger.conf available."
George Joseph [Thu, 25 Oct 2018 12:37:49 +0000 (07:37 -0500)]
Merge "logger.c: Fix default console logging when no logger.conf available."

12 months agoMerge "modules.conf.sample: Update preload usage documentation."
Joshua Colp [Thu, 25 Oct 2018 11:56:29 +0000 (06:56 -0500)]
Merge "modules.conf.sample: Update preload usage documentation."

12 months agores_parking: Stop setting the deprecated PARKINGSLOT channel variable.
Sean Bright [Thu, 18 Oct 2018 19:51:29 +0000 (15:51 -0400)]
res_parking: Stop setting the deprecated PARKINGSLOT channel variable.

Change-Id: Ia155ce2a53d61556aa4685524d1b48cfacfa3a8b

12 months agoMerge "func_callerid: Remove deprecated CALLERPRES() function."
Joshua Colp [Thu, 25 Oct 2018 10:51:18 +0000 (05:51 -0500)]
Merge "func_callerid: Remove deprecated CALLERPRES() function."

12 months agoMerge "res_pjsip: Implement additional SIP RFCs for Google Voice trunk compatability"
Joshua Colp [Thu, 25 Oct 2018 10:51:02 +0000 (05:51 -0500)]
Merge "res_pjsip: Implement additional SIP RFCs for Google Voice trunk compatability"

12 months agologger.c: Fix default console logging when no logger.conf available.
Richard Mudgett [Thu, 18 Oct 2018 00:34:37 +0000 (19:34 -0500)]
logger.c: Fix default console logging when no logger.conf available.

Default logging was not setup correctly when there was no logger.conf.
This resulted in many expected log messages not actually getting out to
the console.

Change-Id: I542e61c03b2f630ff5327f9de5641d776c6fa70c

12 months agoapp_dial/queue/followme: 'I' options to block initial updates in both directions
Alexei Gradinari [Wed, 26 Sep 2018 20:05:59 +0000 (16:05 -0400)]
app_dial/queue/followme: 'I' options to block initial updates in both directions

The 'I' option currently blocks initial CONNECTEDLINE or REDIRECTING updates
from the called parties to the caller.

This patch also blocks updates in the other direction before call is
answered.

ASTERISK-27980

Change-Id: I6ce9e151a2220ce9e95aa66666933cfb9e2a4a01

12 months agomodules.conf.sample: Update preload usage documentation.
Richard Mudgett [Mon, 22 Oct 2018 19:31:27 +0000 (14:31 -0500)]
modules.conf.sample: Update preload usage documentation.

Change-Id: Id449d4435c38148b56ac4cfd61ae4d90ac66bb90

12 months agobridge_softmix: Add SDP "label" attribute to streams
George Joseph [Tue, 16 Oct 2018 12:02:19 +0000 (06:02 -0600)]
bridge_softmix:  Add SDP "label" attribute to streams

Adding the "label" attribute used for participant info correlation
was previously done in app_confbridge but it wasn't working
correctly because it didn't have knowledge about which video
streams belonged to which channel.  Only bridge_softmix has that
data so now it's set when the bridge topology is changed.

ASTERISK-28107

Change-Id: Ieddeca5799d710cad083af3fcc3e677fa2a2a499

12 months agoMerge "astobj2: Eliminate legacy container allocation macros."
George Joseph [Wed, 24 Oct 2018 13:30:08 +0000 (08:30 -0500)]
Merge "astobj2: Eliminate legacy container allocation macros."

12 months agofunc_callerid: Remove deprecated CALLERPRES() function.
Sean Bright [Thu, 18 Oct 2018 19:24:19 +0000 (15:24 -0400)]
func_callerid: Remove deprecated CALLERPRES() function.

Change-Id: Ia1b2b386505b3102136dab02c45eaaf09f0f89c5

12 months agores_pjsip: Implement additional SIP RFCs for Google Voice trunk compatability
Nick French [Wed, 18 Jul 2018 12:45:26 +0000 (07:45 -0500)]
res_pjsip: Implement additional SIP RFCs for Google Voice trunk compatability

This change implements a few different generic things which were brought
on by Google Voice SIP.

1.  The concept of flow transports have been introduced.  These are
configurable transports in pjsip.conf which can be used to reference a
flow of signaling to a target.  These have runtime configuration that can
be changed by the signaling itself (such as Service-Routes and
P-Preferred-Identity).  When used these guarantee an individual connection
(in the case of TCP or TLS) even if multiple flow transports exist to the
same target.

2.  Service-Routes (RFC 3608) support has been added to the outbound
registration module which when received will be stored on the flow
transport and used for requests referencing it.

3.  P-Associated-URI / P-Preferred-Identity (RFC 3325) support has been
added to the outbound registration module.  If a P-Associated-URI header
is received it will be used on requests as the P-Preferred-Identity.

4.  Configurable outbound extension support has been added to the outbound
registration module.  When set the extension will be placed in the
Supported header.

5.  Header parameters can now be configured on an outbound registration
which will be placed in the Contact header.

6.  Google specific OAuth / Bearer token authentication
(draft-ietf-sipcore-sip-authn-02) has been added to the outbound
registration module.

All functionality changes are controlled by pjsip.conf configuration
options and do not affect non-configured pjsip endpoints otherwise.

ASTERISK-27971 #close

Change-Id: Id214c2d1c550a41fcf564b7df8f3da7be565bd58

12 months agoMerge "res_xmpp: Remove deprecated JabberStatus application."
George Joseph [Wed, 24 Oct 2018 12:47:58 +0000 (07:47 -0500)]
Merge "res_xmpp: Remove deprecated JabberStatus application."

12 months agoMerge "app_dial/app_queue: Update application option documentation"
George Joseph [Wed, 24 Oct 2018 12:47:19 +0000 (07:47 -0500)]
Merge "app_dial/app_queue: Update application option documentation"

12 months agoMerge "lock: Replace __ast_mutex_logger with private log_mutex_error."
George Joseph [Wed, 24 Oct 2018 12:46:11 +0000 (07:46 -0500)]
Merge "lock: Replace __ast_mutex_logger with private log_mutex_error."

12 months agosay: Remove legacy language deprecation logic
Sean Bright [Tue, 23 Oct 2018 12:37:44 +0000 (08:37 -0400)]
say: Remove legacy language deprecation logic

These language codes (tw, ge, mx, and cz) were deprecated in 1.6.2.

Change-Id: I18e4d2af2e83556fa91e39a7338030583ef05d50

12 months agores_xmpp: Remove deprecated JabberStatus application.
Sean Bright [Thu, 18 Oct 2018 19:39:34 +0000 (15:39 -0400)]
res_xmpp: Remove deprecated JabberStatus application.

Change-Id: I1a00ca22d59d6b6d2166aa56f0e9338a33e5ac60

12 months agoMerge "Fix 'statement' typo throughout code."
Richard Mudgett [Mon, 22 Oct 2018 15:25:32 +0000 (10:25 -0500)]
Merge "Fix 'statement' typo throughout code."

12 months agoMerge "options.c: Remove 'internal_timing' notice"
Richard Mudgett [Mon, 22 Oct 2018 15:23:45 +0000 (10:23 -0500)]
Merge "options.c: Remove 'internal_timing' notice"

12 months agoMerge "samples: PARKINGSLOT -> PARKING_SPACE in parking sample config"
Richard Mudgett [Mon, 22 Oct 2018 15:21:06 +0000 (10:21 -0500)]
Merge "samples: PARKINGSLOT -> PARKING_SPACE in parking sample config"

12 months agoastobj2: Eliminate legacy container allocation macros.
Corey Farrell [Tue, 16 Oct 2018 19:11:06 +0000 (15:11 -0400)]
astobj2: Eliminate legacy container allocation macros.

These macros have been documented as legacy for a long time but are
still used in new code because they exist.  Remove all references to:
* ao2_container_alloc_options
* ao2_t_container_alloc_options
* ao2_t_container_alloc

These macro's are also removed.  Only ao2_container_alloc remains due to
it's use in over 100 places.

Change-Id: I1a26258b5bf3deb081aaeed11a0baa175c933c7a

12 months agolock: Replace __ast_mutex_logger with private log_mutex_error.
Corey Farrell [Fri, 28 Sep 2018 18:31:37 +0000 (14:31 -0400)]
lock: Replace __ast_mutex_logger with private log_mutex_error.

__ast_mutex_logger used the variable `canlog` without accepting it as a
argument.  Replace with internal macro `log_mutex_error` which takes
canlog as the first arguement.  This will prevent confusion when working
with lock.c code, many of the function declare the canlog variable and
in some cases it previously appeared to be unused.

Change-Id: I83b372cb0654c5c18eadc512f65a57fa6c2e9853

12 months agoMerge "taskprocessor: Warn on unused result from pushing task."
George Joseph [Fri, 19 Oct 2018 13:39:18 +0000 (08:39 -0500)]
Merge "taskprocessor: Warn on unused result from pushing task."

12 months agoMerge "modules: Add missing run time module support levels."
George Joseph [Fri, 19 Oct 2018 13:38:15 +0000 (08:38 -0500)]
Merge "modules: Add missing run time module support levels."

12 months agoapp_dial/app_queue: Update application option documentation
Richard Mudgett [Thu, 18 Oct 2018 19:36:47 +0000 (14:36 -0500)]
app_dial/app_queue: Update application option documentation

* Update the post-answer documentation and example.  The Dial example was
incorrect and misleading for the post-answer subroutine useage.

* Fix note and warning paragraphs in option descriptions.  They don't show
up in the wiki.

Change-Id: I81019a1fd75d5b9151f76b52c38e2a90da682d14

12 months agosamples: PARKINGSLOT -> PARKING_SPACE in parking sample config
Sean Bright [Thu, 18 Oct 2018 19:56:42 +0000 (15:56 -0400)]
samples: PARKINGSLOT -> PARKING_SPACE in parking sample config

PARKINGSLOT was deprecated in Asterisk 12 but the sample config was not
updated to reflect that.

Change-Id: I3e087c19d9ee587094fa5304102d8084a79c2b3c

12 months agooptions.c: Remove 'internal_timing' notice
Sean Bright [Thu, 18 Oct 2018 19:17:32 +0000 (15:17 -0400)]
options.c: Remove 'internal_timing' notice

Change-Id: I9882394617724a497df1d6f529a87965191be3ce

12 months agoFix 'statement' typo throughout code.
Richard Mudgett [Thu, 18 Oct 2018 17:32:26 +0000 (12:32 -0500)]
Fix 'statement' typo throughout code.

Most were in comments.  A couple were in warning messages.

Pointed out by Jonathan H on the Asterisk users mailing list.

Change-Id: I6286939dff5d0a27a2758140570106f1cb351855

12 months agores_rtp_asterisk.c: Add conditional module dependency to res_pjproject
Richard Mudgett [Wed, 17 Oct 2018 21:08:19 +0000 (16:08 -0500)]
res_rtp_asterisk.c: Add conditional module dependency to res_pjproject

* The dependency ensures that res_pjproject cannot be manually unloaded
before res_rtp_asterisk.
* The dependency allows startup loading errors to report that
res_rtp_asterisk depends upon res_pjproject.

Change-Id: Icf5e7581f4ddd6189929f6174c74dd951f887377

12 months agomodules: Add missing run time module support levels.
Richard Mudgett [Wed, 17 Oct 2018 19:34:55 +0000 (14:34 -0500)]
modules: Add missing run time module support levels.

Change-Id: I29b9dbfa4bbfc49f21eba356858e38b1d3041824

12 months agoMerge "bundled pjproject: Remove timer cleanup usage patch."
Jenkins2 [Wed, 17 Oct 2018 14:00:43 +0000 (09:00 -0500)]
Merge "bundled pjproject: Remove timer cleanup usage patch."

12 months agotaskprocessor: Warn on unused result from pushing task.
Corey Farrell [Sun, 14 Oct 2018 12:58:59 +0000 (08:58 -0400)]
taskprocessor: Warn on unused result from pushing task.

Add attribute_warn_unused_result to ast_taskprocessor_push,
ast_taskprocessor_push_local and ast_threadpool_push.  This will help
ensure we perform the necessary cleanup upon failure.

Change-Id: I7e4079bd7b21cfe52fb431ea79e41314520c3f6d

13 months agoMerge "refdebug: Create refstats.py script."
George Joseph [Tue, 16 Oct 2018 18:43:07 +0000 (13:43 -0500)]
Merge "refdebug: Create refstats.py script."

13 months agobundled pjproject: Remove timer cleanup usage patch.
Richard Mudgett [Tue, 16 Oct 2018 17:28:38 +0000 (12:28 -0500)]
bundled pjproject: Remove timer cleanup usage patch.

This patch is not in the upstream pjproject and does unsafe things with
the timer->_timer_id and timer->_grp_lock values in pj_timer_entry_reset()
outside of the timer heap lock.  pj_timer_entry_reset() is also called for
timers that are not about to be rescheduled in a few places.

Change-Id: I4fe0b4bc648f7be5903cf4531b94fc87275713c1

13 months agoMerge "threadpool: Eliminate pointless AO2 usage."
George Joseph [Tue, 16 Oct 2018 15:15:28 +0000 (10:15 -0500)]
Merge "threadpool: Eliminate pointless AO2 usage."

13 months agorefdebug: Create refstats.py script.
Corey Farrell [Wed, 10 Oct 2018 09:37:23 +0000 (05:37 -0400)]
refdebug: Create refstats.py script.

This allows us to process AO2 statistics for total objects, memory
usage, memory overhead and lock usage.

* Install refstats.py and reflocks.py into the Asterisk scripts folder.
* Enable support for reflocks.py without DEBUG_THREADS.

Steal a bit from the ao2 magic to flag when an object lock is used.
Remove 'lockobj' from reflocks.py since we can now record 'used' or
'unused' for those objects.

Add comments to explain thread safety of the 'struct __priv_data'
bitfields.

Change-Id: I84e9d679cc86d772cc97c888d9d856a17e0d3a4a

13 months agores_pjsip: set callerid_tag to empty string
Alexei Gradinari [Fri, 12 Oct 2018 17:14:03 +0000 (13:14 -0400)]
res_pjsip: set callerid_tag to empty string

This patch sets the callerid_tag to empty string by default.

If the callerid_tag is set to NULL then the tag does not
become part of a connected line update.
For example:
Alice's tag is "Alice".
Bob's tag is empty.
Charlie's tag is "Charlie".
Alice calls Bob and then does attended transfer to Charlie.
When Alice hangs up the CONNECTEDLINE(tag) is "Alice"
on the interception routine on the Charlie's channel, but should be empty.

Ths patch also fix memory leaks if there are more then one options
"callerid", "callerid_tag", "voicemail_extension" and "contact_user"
in the pjsip.conf endpoint definition.

Change-Id: I86ba455c4677ca8d516d9a04ce7fb4d24dd576e4

13 months agoMerge "res_statsd.c: Fix returned reload status."
George Joseph [Mon, 15 Oct 2018 16:26:34 +0000 (11:26 -0500)]
Merge "res_statsd.c: Fix returned reload status."

13 months agothreadpool: Eliminate pointless AO2 usage.
Corey Farrell [Thu, 11 Oct 2018 11:24:40 +0000 (07:24 -0400)]
threadpool: Eliminate pointless AO2 usage.

thread_worker_pair, set_size_data and task_pushed_data structures are
allocated with AO2 objects, passed to a taskprocessor, then released.
They never have multiple owners or use locking so AO2 only adds
overhead.

Change-Id: I2204d2615d9d952670fcb48e0a9c0dd1a6ba5036

13 months agomain/astfd: Fix GCC8 format-truncation warning.
Corey Farrell [Fri, 12 Oct 2018 17:21:24 +0000 (13:21 -0400)]
main/astfd: Fix GCC8 format-truncation warning.

The field used to store call arguments was not large enough to hold the
arguments string that can be constructed for 'open'.  Expand it to
prevent this warning/error.

Change-Id: I514927f256481bc84df10a51b19d5b5fb1bc387e

13 months agoMerge "loader: Flag module as declined in all cases where it fails to load."
Jenkins2 [Wed, 10 Oct 2018 17:26:58 +0000 (12:26 -0500)]
Merge "loader: Flag module as declined in all cases where it fails to load."

13 months agores_statsd.c: Fix returned reload status.
Richard Mudgett [Tue, 9 Oct 2018 21:18:49 +0000 (16:18 -0500)]
res_statsd.c: Fix returned reload status.

The return status when there was no change in statsd.conf was incorrect.
This resulted in the wrong status message on the CLI when reloading the
module.

* Fixed cleanup on initial load if initializing statsd failed.

Change-Id: Id24fae75f1a7ff584a444a5680e867d989792481

13 months agoMerge "core/frame: generate correct T.140 payload in ast_sendtext_data()"
George Joseph [Fri, 5 Oct 2018 19:32:43 +0000 (14:32 -0500)]
Merge "core/frame: generate correct T.140 payload in ast_sendtext_data()"

13 months agoMerge "func_periodic_hook.c: Cleanup module resources on failure."
George Joseph [Fri, 5 Oct 2018 19:32:21 +0000 (14:32 -0500)]
Merge "func_periodic_hook.c: Cleanup module resources on failure."

13 months agoMerge "codec_speex.c: Cleanup module loading to DECLINE and not FAILURE."
George Joseph [Fri, 5 Oct 2018 19:30:40 +0000 (14:30 -0500)]
Merge "codec_speex.c: Cleanup module loading to DECLINE and not FAILURE."

13 months agoMerge "res_smdi.c: Fix module ref counting and inverted test."
George Joseph [Fri, 5 Oct 2018 15:52:18 +0000 (10:52 -0500)]
Merge "res_smdi.c: Fix module ref counting and inverted test."

13 months agoMerge "res_statsd.c: Made use defaults if the statsd.conf file does not exist."
George Joseph [Fri, 5 Oct 2018 15:10:28 +0000 (10:10 -0500)]
Merge "res_statsd.c: Made use defaults if the statsd.conf file does not exist."

13 months agoMerge "res_smdi.c: Made use defaults if the smdi.conf file does not exist."
George Joseph [Fri, 5 Oct 2018 15:09:50 +0000 (10:09 -0500)]
Merge "res_smdi.c: Made use defaults if the smdi.conf file does not exist."

13 months agocore/frame: generate correct T.140 payload in ast_sendtext_data()
neutrino88 [Wed, 3 Oct 2018 21:51:49 +0000 (17:51 -0400)]
core/frame: generate correct T.140 payload in ast_sendtext_data()

ast_sendtext_data() would create an incorrect T.140 text frame which
length include the null terminator byte. It causes ultimately RTP
packets to be send with this trailing 0. The proposed fix just set the
correct length to the text frame

ASTERISK-28089
Reported by: Emmanuel BUU
Tested by: Emmanuel BUU

Change-Id: I7ab1b9ed1e21683b2b667ea0a59d9aba3c77dd96

13 months agoloader: Flag module as declined in all cases where it fails to load.
Corey Farrell [Thu, 4 Oct 2018 23:33:25 +0000 (19:33 -0400)]
loader: Flag module as declined in all cases where it fails to load.

This has no effect on startup since AST_MODULE_LOAD_FAILURE aborts
startup, but it's possible for this code to be returned on manual load
of a module after startup.

It is an error for a module to not have a load callback but this is not
a fatal system error.  In this case flag the module as declined, return
AST_MODULE_LOAD_FAILURE only if a required module is broken.

Expand doxygen documentation for AST_MODULE_LOAD_*.

Change-Id: I3c030bb917f6e5a0dfd9d91491a4661b348cabf8

13 months agofunc_periodic_hook.c: Cleanup module resources on failure.
Richard Mudgett [Thu, 4 Oct 2018 18:13:24 +0000 (13:13 -0500)]
func_periodic_hook.c: Cleanup module resources on failure.

* Make load_module() cleanup if it failed to setup the module.

* Make unload_module() always return 0.  It is silly to fail unloading if
the hook function we try to unregister was not even registered.

Change-Id: I280fc6e8ba2a7ee2588ca01d870eebaf74b4ffe6

13 months agocodec_speex.c: Cleanup module loading to DECLINE and not FAILURE.
Richard Mudgett [Thu, 4 Oct 2018 16:49:09 +0000 (11:49 -0500)]
codec_speex.c: Cleanup module loading to DECLINE and not FAILURE.

If codec_speex fails to register a translator it would cause Asterisk to
exit instead of continue as a DECLINED module.

* Make unload_module() always return 0.  It is silly to fail unloading if
any translators we try to unregister were not even registered.

Change-Id: Ia262591f68333dad17673ba7104d11c88096f51a

13 months agoCI: Fix missing () in gates.jenkinsfile
George Joseph [Thu, 4 Oct 2018 18:03:05 +0000 (12:03 -0600)]
CI: Fix missing () in gates.jenkinsfile

Change-Id: I2f252e0f8c7f1a6328438fbd2be5d6574b7dfa5b

13 months agoMerge "CI: Add timestamps and timeouts to jenkinsfiles"
Jenkins2 [Thu, 4 Oct 2018 17:50:18 +0000 (12:50 -0500)]
Merge "CI: Add timestamps and timeouts to jenkinsfiles"

13 months agoMerge "jenkins: Fix cleanup command redirection."
Jenkins2 [Thu, 4 Oct 2018 16:28:39 +0000 (11:28 -0500)]
Merge "jenkins: Fix cleanup command redirection."

13 months agoCI: Add timestamps and timeouts to jenkinsfiles
George Joseph [Thu, 4 Oct 2018 15:13:22 +0000 (09:13 -0600)]
CI: Add timestamps and timeouts to jenkinsfiles

Change-Id: Ide83574dc957bc1df28e30a69079140050dfc35f

13 months agoMerge "ast_coredumper: Remove .gdbinit file on exit"
George Joseph [Thu, 4 Oct 2018 14:43:09 +0000 (09:43 -0500)]
Merge "ast_coredumper: Remove .gdbinit file on exit"

13 months agoMerge "CI: Use brace expansion instead of calling out to seq"
George Joseph [Thu, 4 Oct 2018 14:41:48 +0000 (09:41 -0500)]
Merge "CI: Use brace expansion instead of calling out to seq"

13 months agoMerge "CI: Look up configured kernel.core_pattern sysctl"
George Joseph [Thu, 4 Oct 2018 13:54:24 +0000 (08:54 -0500)]
Merge "CI: Look up configured kernel.core_pattern sysctl"

13 months agoMerge "ast_coredumper: Don't use "declare -n""
George Joseph [Thu, 4 Oct 2018 12:27:18 +0000 (07:27 -0500)]
Merge "ast_coredumper: Don't use "declare -n""

13 months agoMerge "astobj2: Comment on OBJ_NOLOCK in ao2_container_clone."
George Joseph [Thu, 4 Oct 2018 12:25:47 +0000 (07:25 -0500)]
Merge "astobj2: Comment on OBJ_NOLOCK in ao2_container_clone."

13 months agoMerge "http.c: Reload TLS even if http.conf hasn't changed"
George Joseph [Thu, 4 Oct 2018 12:23:49 +0000 (07:23 -0500)]
Merge "http.c: Reload TLS even if http.conf hasn't changed"

13 months agoast_coredumper: Remove .gdbinit file on exit
Sean Bright [Wed, 3 Oct 2018 22:02:27 +0000 (18:02 -0400)]
ast_coredumper: Remove .gdbinit file on exit

Change-Id: I1297de78628773ca368e687c6f148bf74857cae9

13 months agoCI: Look up configured kernel.core_pattern sysctl
Sean Bright [Wed, 3 Oct 2018 14:33:28 +0000 (10:33 -0400)]
CI: Look up configured kernel.core_pattern sysctl

Change-Id: I8246a0147df8d821fbbcabc1db1887104b8bedc4

13 months agojenkins: Fix cleanup command redirection.
Corey Farrell [Wed, 3 Oct 2018 20:51:01 +0000 (16:51 -0400)]
jenkins: Fix cleanup command redirection.

Fix redirection to /dev/null of cleanup commands.  The '2' was being
interpreted as part of the command instead of part of the redirect.

Change-Id: I2e3a591b165e0288c4b82b9ef475fdfd5392a90a

13 months agoast_coredumper: Don't use "declare -n"
George Joseph [Wed, 3 Oct 2018 20:29:31 +0000 (14:29 -0600)]
ast_coredumper: Don't use "declare -n"

Change-Id: I7ddfed4cd6549a0cd458e4d5cf9ac95d784de6cb

13 months agoMerge "CI: Use bindport instead of port in test http.conf"
George Joseph [Wed, 3 Oct 2018 18:56:54 +0000 (13:56 -0500)]
Merge "CI: Use bindport instead of port in test http.conf"

13 months agoMerge "core/frame: Fix ast_frdup() and ast_frisolate() for empty text frames"
George Joseph [Wed, 3 Oct 2018 18:55:24 +0000 (13:55 -0500)]
Merge "core/frame: Fix ast_frdup() and ast_frisolate() for empty text frames"

13 months agores_smdi.c: Fix module ref counting and inverted test.
Richard Mudgett [Tue, 2 Oct 2018 21:15:37 +0000 (16:15 -0500)]
res_smdi.c: Fix module ref counting and inverted test.

I think this module is so screwed up that it doesn't work anymore.  Even
with these attempts to fix things it still won't gracefully shut down.
The module refs will not go to zero to allow unloading the module.

* Fix module ref counting dealing with the SMDI interface object.  There
were several off-nominal paths that unbalanced the module ref count.  Also
the destructor freed the ao2 object itself which is bad.  Made the
smdi_read thread not hold its own ref to the SMDI interface object so when
all refs go away the destructor will stop the listener thread.

* Fixed the smdi_load() return code of 1 concerning the number of
listeners.  The test was inverted.

Change-Id: Ic288db51b58e395d6a2fc3847f77176c16988784

13 months agores_smdi.c: Made use defaults if the smdi.conf file does not exist.
Richard Mudgett [Tue, 2 Oct 2018 21:23:31 +0000 (16:23 -0500)]
res_smdi.c: Made use defaults if the smdi.conf file does not exist.

This module is an optional dependency of a couple of other modules.  If it
declines to load, it then forces other modules that can optionally use
this module to also decline.

* Made use the default configuration if the config file does not exist and
simplified some of the logic.

Change-Id: Ib93191f1fe28c0dd9ebe3d84c7762b32f83c4eb9

13 months agoastobj2: Comment on OBJ_NOLOCK in ao2_container_clone.
Corey Farrell [Tue, 2 Oct 2018 22:15:47 +0000 (18:15 -0400)]
astobj2: Comment on OBJ_NOLOCK in ao2_container_clone.

The test for OBJ_NOLOCK looks wrong but it isn't.  Add comments to
prevent confusion.

Change-Id: I9662b82eb39e7627a1f1944fd18f967a2b987344

13 months agoMerge "astobj2: Record lock usage to refs log when DEBUG_THREADS is enabled."
George Joseph [Wed, 3 Oct 2018 15:17:27 +0000 (10:17 -0500)]
Merge "astobj2: Record lock usage to refs log when DEBUG_THREADS is enabled."

13 months agoMerge "loader: Fix result of module reload error."
George Joseph [Wed, 3 Oct 2018 15:17:07 +0000 (10:17 -0500)]
Merge "loader: Fix result of module reload error."

13 months agoMerge "core: Disable astobj2 locking for some common objects."
George Joseph [Wed, 3 Oct 2018 15:16:20 +0000 (10:16 -0500)]
Merge "core: Disable astobj2 locking for some common objects."

13 months agoCI: Use brace expansion instead of calling out to seq
Sean Bright [Wed, 3 Oct 2018 14:05:55 +0000 (10:05 -0400)]
CI: Use brace expansion instead of calling out to seq

Also make the shebang in publishAsteriskDocs.sh the first line.

Change-Id: I3fdd6f22e652e4fb5b5fe85df46fa34eb6d0cf08

13 months agoCI: Use bindport instead of port in test http.conf
Sean Bright [Wed, 3 Oct 2018 13:59:52 +0000 (09:59 -0400)]
CI: Use bindport instead of port in test http.conf

Change-Id: Ife9a6879da63a56e5b8348a2024eeed4e7b1615b

13 months agohttp.c: Reload TLS even if http.conf hasn't changed
Sean Bright [Wed, 3 Oct 2018 12:56:34 +0000 (08:56 -0400)]
http.c: Reload TLS even if http.conf hasn't changed

There is currently no way to indicate to Asterisk that TLS certificates
and/or keys have been updated other than by modifying http.conf or
restarting Asterisk.

There is already code in main/tcptls.c that determines if a reload is
actually necessary based on the hashes of the certicate and dependent
files, so this change merely gives us a way to request a reload without
explicitly modifying http.conf.

Change-Id: Ie795420dcc7eb3d91336820688a29adbcc321276

13 months agoMerge "Resolve warning about duplicate 'dialplan' CLI."
Joshua Colp [Wed, 3 Oct 2018 13:31:20 +0000 (08:31 -0500)]
Merge "Resolve warning about duplicate 'dialplan' CLI."

13 months agores_statsd.c: Made use defaults if the statsd.conf file does not exist.
Richard Mudgett [Tue, 2 Oct 2018 18:29:59 +0000 (13:29 -0500)]
res_statsd.c: Made use defaults if the statsd.conf file does not exist.

This module is an optional dependency of many modules.  If it declines to
load it then forces other modules that can optionally use this module to
also decline.

* Made use default configuration if there is a config error or the config
file does not exist.

Change-Id: If1068a582ec54ab7fb437265cb5370a97a825737

13 months agocore: Disable astobj2 locking for some common objects.
Corey Farrell [Tue, 2 Oct 2018 03:12:14 +0000 (23:12 -0400)]
core: Disable astobj2 locking for some common objects.

* ACO options
* Indications
* Module loader ref_debug object
* Media index info and variants
* xmldoc items

These allocation locations were identified using reflocks.py on the
master branch.

Change-Id: Ie999b9941760be3d1946cdb6e30cb85fd97504d8

13 months agoMerge "loader: Improve error handling."
George Joseph [Tue, 2 Oct 2018 19:24:09 +0000 (14:24 -0500)]
Merge "loader: Improve error handling."