asterisk/asterisk.git
11 years agoMerged revisions 203380 via svnmerge from
Terry Wilson [Thu, 25 Jun 2009 21:15:11 +0000 (21:15 +0000)]
Merged revisions 203380 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r203380 | twilson | 2009-06-25 16:13:10 -0500 (Thu, 25 Jun 2009) | 4 lines

  I didn't see that Mark already fixed the underlying issue!

  Yay for removing useless code.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@203381 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 203375 via svnmerge from
Russell Bryant [Thu, 25 Jun 2009 21:04:55 +0000 (21:04 +0000)]
Merged revisions 203375 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r203375 | russell | 2009-06-25 16:02:18 -0500 (Thu, 25 Jun 2009) | 9 lines

  Fix a case where CDR answer time could be before the start time involving parking.

  (closes issue #13794)
  Reported by: davidw
  Patches:
        13794.patch uploaded by murf (license 17)
        13794.patch.160 uploaded by murf (license 17)
  Tested by: murf, dbrooks
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@203376 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 203311 via svnmerge from
Terry Wilson [Thu, 25 Jun 2009 20:25:39 +0000 (20:25 +0000)]
Merged revisions 203311 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r203311 | twilson | 2009-06-25 15:09:15 -0500 (Thu, 25 Jun 2009) | 2 lines

  Don't try to free NULL
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@203338 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoNew signaling module to handle PRI/BRI operations in chan_dahdi
Jeff Peeler [Thu, 25 Jun 2009 19:54:12 +0000 (19:54 +0000)]
New signaling module to handle PRI/BRI operations in chan_dahdi

This merge splits the PRI/BRI signaling logic out of chan_dahdi.c into
sig_pri.c. Functionality in theory should not change (mostly). A few trivial
changes were made in sig_analog with verbose messages and commenting.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@203304 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoUnmute when we get a dtmfup (we muted on dtmfdown) event.
Jason Parker [Thu, 25 Jun 2009 19:22:46 +0000 (19:22 +0000)]
Unmute when we get a dtmfup (we muted on dtmfdown) event.

This would occasionally cause one-way audio when using hardware DTMF detection.

(closes issue #14761)
Reported by: tzafrir
Patches:
      v1-14761.patch uploaded by dimas (license 88)
Tested by: tzafrir, dimas

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@203258 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoBlocked revisions 203230 via svnmerge
Mark Michelson [Thu, 25 Jun 2009 18:53:12 +0000 (18:53 +0000)]
Blocked revisions 203230 via svnmerge

........
  r203230 | mmichelson | 2009-06-25 13:52:22 -0500 (Thu, 25 Jun 2009) | 3 lines

  Prevent false positives when freeing a NULL pointer with MALLOC_DEBUG enabled.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@203231 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoAdd support for multicast RTP paging.
Joshua Colp [Thu, 25 Jun 2009 18:25:24 +0000 (18:25 +0000)]
Add support for multicast RTP paging.

(closes issue #11797)
Reported by: macbrody

Review: https://reviewboard.asterisk.org/r/270/

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@203227 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoPass a logmsg to ast_log_vsyslog instead of separate arguments.
Sean Bright [Thu, 25 Jun 2009 17:01:32 +0000 (17:01 +0000)]
Pass a logmsg to ast_log_vsyslog instead of separate arguments.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@203188 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoInsure ring cadence is set for fxs ports
Doug Bailey [Thu, 25 Jun 2009 16:18:48 +0000 (16:18 +0000)]
Insure ring cadence is set for fxs ports

Moved SETCADENCE ioctl call to before call into new analog signal module
to insure that it gets set.

(closes issue #15381)
Reported by: alecdavis
Patches:
      fix15381.diff uploaded by dbailey (license 819)
Tested by: dbailey

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@203126 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 203115 via svnmerge from
Russell Bryant [Thu, 25 Jun 2009 16:04:10 +0000 (16:04 +0000)]
Merged revisions 203115 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r203115 | russell | 2009-06-25 11:02:16 -0500 (Thu, 25 Jun 2009) | 11 lines

  Resolve a crash related to a T.38 reinvite race condition.

  This change resolves a crash observed locally during some T.38 testing.
  A call was set up using a call file, and when the T.38 reinvite came in,
  the channel state was still AST_STATE_DOWN.  The reason is explained by
  a comment in the code that previously lived in the handling of
  AST_STATE_RINGING.  This change modifies the logic to handle the same
  race condition for any channel state that is not UP.

  (closes ABE-1895)
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@203116 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 203036 via svnmerge from
Richard Mudgett [Wed, 24 Jun 2009 21:08:55 +0000 (21:08 +0000)]
Merged revisions 203036 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r203036 | rmudgett | 2009-06-24 16:01:43 -0500 (Wed, 24 Jun 2009) | 8 lines

  Improved chan_dahdi.conf pritimer error checking.

  Valid format is: pritimer=timer_name,timer_value

  *  Fixed segfault if the ',' is missing.
  *  Completely check the range returned by pri_timer2idx() to prevent
  possible access outside array bounds.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@203037 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 202966 via svnmerge from
Mark Michelson [Wed, 24 Jun 2009 18:29:10 +0000 (18:29 +0000)]
Merged revisions 202966 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r202966 | mmichelson | 2009-06-24 13:28:47 -0500 (Wed, 24 Jun 2009) | 3 lines

  Use the handy UNLINK macro instead of hand-coding the same thing in-line.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@202967 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoEnsure the default settings are applied for T.38 when we set it up for a peer.
Joshua Colp [Wed, 24 Jun 2009 18:08:17 +0000 (18:08 +0000)]
Ensure the default settings are applied for T.38 when we set it up for a peer.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@202925 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoIgnore some files generated when asterisk.pdf is created.
Sean Bright [Wed, 24 Jun 2009 13:53:49 +0000 (13:53 +0000)]
Ignore some files generated when asterisk.pdf is created.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@202889 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoUpdate sample cdr_tds configuration to try and eliminate some confusion.
Sean Bright [Wed, 24 Jun 2009 13:47:55 +0000 (13:47 +0000)]
Update sample cdr_tds configuration to try and eliminate some confusion.

Also change the preferred configuration option from 'hostname' (which was
misleading because it didn't actually treat the value as a hostname) to
'connection' and added some verbage explaining that the user would need to
refer to their freetds.conf file for those settings.  'hostname' was kept
as a backwards compatible configuration parameter.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@202887 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoChange some section names in the CDR tex documentation.
Sean Bright [Tue, 23 Jun 2009 23:57:07 +0000 (23:57 +0000)]
Change some section names in the CDR tex documentation.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@202841 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoRemove some trailing whitespace before making content changes.
Sean Bright [Tue, 23 Jun 2009 23:53:45 +0000 (23:53 +0000)]
Remove some trailing whitespace before making content changes.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@202840 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoClean up section hierarchy for the CDR chapter.
Russell Bryant [Tue, 23 Jun 2009 22:47:26 +0000 (22:47 +0000)]
Clean up section hierarchy for the CDR chapter.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@202804 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoI could have sworn I committed this patch ages ago, but... bug fix with setting NAI...
Matthew Fredrickson [Tue, 23 Jun 2009 22:08:43 +0000 (22:08 +0000)]
I could have sworn I committed this patch ages ago, but... bug fix with setting NAI properly on linksets in certain situations.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@202761 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMake outgoing_colp=2 misdn.conf port parameter not send redirecting or transfer messages.
Richard Mudgett [Tue, 23 Jun 2009 21:38:21 +0000 (21:38 +0000)]
Make outgoing_colp=2 misdn.conf port parameter not send redirecting or transfer messages.

If the outgoing_colp parameter is set to not send COLP information, then
it does not make sense to send redirecting or transfer messages announcing
new COLP information that is blocked.  The service provider may supply the
listed number for that line when it passes the messages to the next hop.
Why tell the switch that these events happened when the information is
otherwise suppressed?

Also blocked the number of previous redirects that may have occurred to
calls going out the port when outgoing_colp is 2.

Follow on to JIRA ABE-1853.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@202755 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoIf we delete the info, lets also delete the lines
Ryan Brindley [Tue, 23 Jun 2009 21:25:17 +0000 (21:25 +0000)]
If we delete the info, lets also delete the lines

(closes issue #14509)
Reported by: timeshell
Patches:
      20090504__bug14509.diff.txt uploaded by tilghman (license 14)
Tested by: awk, timeshell

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@202753 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 202671 via svnmerge from
David Vossel [Tue, 23 Jun 2009 16:31:30 +0000 (16:31 +0000)]
Merged revisions 202671 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r202671 | dvossel | 2009-06-23 11:28:46 -0500 (Tue, 23 Jun 2009) | 12 lines

  MWI NOTIFY contains a wrong URI if Asterisk listens to non-standard port and transport

  (closes issue #14659)
  Reported by: klaus3000
  Patches:
        patch_chan_sip_fixMWIuri_1.4.txt uploaded by klaus3000 (license 65)
        mwi_port-transport_trunk.diff uploaded by dvossel (license 671)
  Tested by: dvossel, klaus3000

  Review: https://reviewboard.asterisk.org/r/288/
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@202672 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoBlocked revisions 202601 via svnmerge
Mark Michelson [Tue, 23 Jun 2009 15:23:00 +0000 (15:23 +0000)]
Blocked revisions 202601 via svnmerge

........
  r202601 | mmichelson | 2009-06-23 10:22:35 -0500 (Tue, 23 Jun 2009) | 3 lines

  Fix more memory leaks that may result if rtp is not successfully allocated.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@202603 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoBlocked revisions 202572 via svnmerge
Mark Michelson [Tue, 23 Jun 2009 15:11:47 +0000 (15:11 +0000)]
Blocked revisions 202572 via svnmerge

........
  r202572 | mmichelson | 2009-06-23 10:08:27 -0500 (Tue, 23 Jun 2009) | 3 lines

  Fix potential memory leak in chan_sip when video rtp is not allocated properly.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@202574 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoIgnore voicemail messages that are just silence.
Russell Bryant [Tue, 23 Jun 2009 14:54:21 +0000 (14:54 +0000)]
Ignore voicemail messages that are just silence.

(closes issue #2264)
Reported by: pfn
Patches:
      silent-vm-1.6.2.txt uploaded by pfn (license 810)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@202570 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 202496 via svnmerge from
Russell Bryant [Mon, 22 Jun 2009 20:11:04 +0000 (20:11 +0000)]
Merged revisions 202496 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r202496 | russell | 2009-06-22 15:08:53 -0500 (Mon, 22 Jun 2009) | 4 lines

  Report CallerID change during a masquerade.

  Reported by: markster
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@202497 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoFix lock usage in cdr_sqlite3_custom to avoid potential crashes during reload.
Sean Bright [Mon, 22 Jun 2009 16:09:50 +0000 (16:09 +0000)]
Fix lock usage in cdr_sqlite3_custom to avoid potential crashes during reload.

Pointed out by Russell while working on the CEL branch.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@202417 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 202414 via svnmerge from
Russell Bryant [Mon, 22 Jun 2009 16:05:08 +0000 (16:05 +0000)]
Merged revisions 202414 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r202414 | russell | 2009-06-22 11:00:00 -0500 (Mon, 22 Jun 2009) | 2 lines

  Make Polycom subscription type override check more explicit.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@202415 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoattempting to load running modules
David Vossel [Mon, 22 Jun 2009 15:33:35 +0000 (15:33 +0000)]
attempting to load running modules

Modules placed in the priority heap for loading were not properly removed from the linked list.  This resulted in some modules attempting to load twice.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@202410 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 202341-202342 via svnmerge from
Mark Michelson [Mon, 22 Jun 2009 14:58:24 +0000 (14:58 +0000)]
Merged revisions 202341-202342 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r202341 | mmichelson | 2009-06-22 09:42:55 -0500 (Mon, 22 Jun 2009) | 26 lines

  Fix a situation in which Asterisk would not stop retransmitting 487s.

  If a CANCEL were received by Asterisk, we would send a 487 in response
  to the original INVITE and a 200 OK for the CANCEL. If there were a network
  hiccup which caused the 200 OK and the 487 to be lost, then the UA communicating
  with Asterisk may try to retransmit its CANCEL. Asterisk's response to this used
  to be to try sending another 487 to the canceled INVITE and another 200 OK to the
  CANCEL.

  The problem here is that the originally-sent 487 was sent "reliably" meaning that
  it will be retransmitted until it is received properly. So when we receive the second
  CANCEL it is likely that the first batch of 487s we sent is still going strong and
  reaches the UA. The result was that the second set of 487s would be retransmitted
  constantly until the maximum number of retries had been reached.

  The fix for this is that if we receive a second CANCEL for an INVITE, then we cancel
  the retransmission of the first set of 487s and start a second set. This causes the
  dialog to be terminated reasonably.

  (closes issue #14584)
  Reported by: klaus3000
  Patches:
        14584_v2.patch uploaded by mmichelson (license 60)
  Tested by: klaus3000
........
  r202342 | mmichelson | 2009-06-22 09:44:58 -0500 (Mon, 22 Jun 2009) | 3 lines

  Remove an extra debug line left from previous commit.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@202343 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 202336 via svnmerge from
Mark Michelson [Mon, 22 Jun 2009 14:35:09 +0000 (14:35 +0000)]
Merged revisions 202336 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r202336 | mmichelson | 2009-06-22 09:34:05 -0500 (Mon, 22 Jun 2009) | 25 lines

  Fix a possible infinite loop in SDP parsing during glare situation.

  There was a while loop in get_ip_and_port_from_sdp which was controlled
  by a call to get_sdp_iterate. The loop would exit either if what we were
  searching for was found or if the return was NULL. The problem is that
  get_sdp_iterate never returns NULL. This means that if what we were searching
  for was not present, the loop would run infinitely. This modification of the
  loop fixes the problem.

  (closes issue #15213)
  Reported by: schmidts

  (closes issue #15349)
  Reported by: samy

  (closes issue #14464)
  Reported by: pj

  (closes issue #15345)
  Reported by: aragon
  Patches:
        sip_inf_loop.patch uploaded by mmichelson (license 60)
  Tested by: aragon
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@202337 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoNote a bug in cdr_sqlite3_custom so I don't forget about it.
Russell Bryant [Sun, 21 Jun 2009 16:36:55 +0000 (16:36 +0000)]
Note a bug in cdr_sqlite3_custom so I don't forget about it.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@202301 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoFix possibility of crashiness during reload in custom fields handling.
Russell Bryant [Sun, 21 Jun 2009 16:11:48 +0000 (16:11 +0000)]
Fix possibility of crashiness during reload in custom fields handling.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@202262 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoStandardize return values of load_config() so reload() doesn't report an error on...
Russell Bryant [Sun, 21 Jun 2009 16:00:23 +0000 (16:00 +0000)]
Standardize return values of load_config() so reload() doesn't report an error on success.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@202258 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoLeave a note about some unsafe code in cdr_manager
Russell Bryant [Sat, 20 Jun 2009 20:56:13 +0000 (20:56 +0000)]
Leave a note about some unsafe code in cdr_manager

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@202223 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoFix version detection for API changes in spandsp.
Sean Bright [Sat, 20 Jun 2009 19:09:47 +0000 (19:09 +0000)]
Fix version detection for API changes in spandsp.

(closes issue #15355)
Reported by: deuffy

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@202183 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoRemove unnecessary usleep() from a couple of module unload callbacks.
Russell Bryant [Sat, 20 Jun 2009 14:09:40 +0000 (14:09 +0000)]
Remove unnecessary usleep() from a couple of module unload callbacks.

In passing, also tweak cdr_unregister() to hold the list lock a bit less time.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@202109 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoUse sched_yield() instead of usleep(1)
Matthew Nicholson [Fri, 19 Jun 2009 21:25:06 +0000 (21:25 +0000)]
Use sched_yield() instead of usleep(1)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@202039 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoBlocked revisions 202022 via svnmerge
Matthew Nicholson [Fri, 19 Jun 2009 21:22:14 +0000 (21:22 +0000)]
Blocked revisions 202022 via svnmerge

........
  r202022 | mnicholson | 2009-06-19 16:21:15 -0500 (Fri, 19 Jun 2009) | 4 lines

  Added deadlock protection to try_suggested_sip_codec in chan_sip.c.

  Review: https://reviewboard.asterisk.org/r/287/
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@202026 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 201993 via svnmerge from
David Vossel [Fri, 19 Jun 2009 20:24:37 +0000 (20:24 +0000)]
Merged revisions 201993 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r201993 | dvossel | 2009-06-19 15:22:02 -0500 (Fri, 19 Jun 2009) | 8 lines

  timestamp was being converted to host order as a short rather than a long

  (closes issue #15361)
  Reported by: ffloimair
  Patches:
        ts_issue.diff uploaded by dvossel (license 671)
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@201994 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoAdd note about the addition of calendar support
Terry Wilson [Fri, 19 Jun 2009 17:40:16 +0000 (17:40 +0000)]
Add note about the addition of calendar support

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@201944 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoFix 2 typos and add support for wide character types.
Tilghman Lesher [Fri, 19 Jun 2009 15:47:55 +0000 (15:47 +0000)]
Fix 2 typos and add support for wide character types.
Reported by Benny Amorsen via the asterisk-users mailing list.
http://lists.digium.com/pipermail/asterisk-users/2009-June/233622.html

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@201904 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoAdd support for allowing an RTP engine to decide on whether it is possible for specif...
Joshua Colp [Fri, 19 Jun 2009 15:41:24 +0000 (15:41 +0000)]
Add support for allowing an RTP engine to decide on whether it is possible for specific formats to be transcoded for an RTP instance.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@201902 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 201828 via svnmerge from
Tilghman Lesher [Fri, 19 Jun 2009 00:43:41 +0000 (00:43 +0000)]
Merged revisions 201828 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r201828 | tilghman | 2009-06-18 19:40:41 -0500 (Thu, 18 Jun 2009) | 6 lines

  If the "h" extension fails, give it another chance in main/pbx.c.
  If the "h" extension fails, give it another chance in main/pbx.c, when it
  returns from the bridge code.  Fixes an issue where the "h" extension may
  occasionally not fire, when a Dial is executed from a Macro.
  Debugged in #asterisk with user tompaw.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@201829 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoOne of the changes in 1.6.1 was to allow app_directory to use functionality
Tilghman Lesher [Thu, 18 Jun 2009 20:52:36 +0000 (20:52 +0000)]
One of the changes in 1.6.1 was to allow app_directory to use functionality
within app_voicemail for directory functions.  It is therefore no longer
necessary for app_directory to be linked against the ODBC libraries (and it
never was necessary for app_directory to be linked against IMAP, though it
was).

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@201783 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoClarify CUT code, and in the process, fix a bug in trunk only
Tilghman Lesher [Thu, 18 Jun 2009 18:24:23 +0000 (18:24 +0000)]
Clarify CUT code, and in the process, fix a bug in trunk only
(closes issue #15320)
 Reported by: chappell
 Patches:
       cut_fix.patch uploaded by chappell (license 8)
       cut_clarify.patch uploaded by chappell (license 8)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@201745 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoAdded deadlock protection to try_suggested_sip_codec in chan_sip.c.
Matthew Nicholson [Thu, 18 Jun 2009 17:41:09 +0000 (17:41 +0000)]
Added deadlock protection to try_suggested_sip_codec in chan_sip.c.

Review: https://reviewboard.asterisk.org/r/285/

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@201717 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agofixes some memory leaks and redundant conditions
David Vossel [Thu, 18 Jun 2009 16:37:42 +0000 (16:37 +0000)]
fixes some memory leaks and redundant conditions

(closes issue #15269)
Reported by: contactmayankjain
Patches:
      patch.txt uploaded by contactmayankjain (license 740)
      memory_leak_stuff.trunk.diff uploaded by dvossel (license 671)
Tested by: contactmayankjain, dvossel

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@201678 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 201600 via svnmerge from
Russell Bryant [Thu, 18 Jun 2009 15:27:10 +0000 (15:27 +0000)]
Merged revisions 201600 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r201600 | russell | 2009-06-18 10:24:31 -0500 (Thu, 18 Jun 2009) | 29 lines

  Fix memory corruption and leakage related reloads of non files mode MoH classes.

  For Music on Hold classes that are not files mode, meaning that we are executing
  an application that will feed us audio data, we use a thread to monitor the
  external application and read audio from it.  This thread also makes use of the
  MoH class object.  In the MoH class destructor, we used pthread_cancel() to ask
  the thread to exit.  Unfortunately, the code did not wait to ensure that the
  thread actually went away.  What needed to be done is a pthread_join() to ensure
  that the thread fully cleans up before we proceed.  By adding this one line, we
  resolve two significant problems:

    1) Since the thread was never joined, it never fully goes away.  So, on every
       reload of non-files mode MoH, an unused thread was sticking around.

    2) There was a race condition here where the application monitoring thread
       could still try to access the MoH class, even though the thread executing
       the MoH reload has already destroyed it.

  (issue #15109)
  Reported by: jvandal

  (issue #15123)
  Reported by: axisinternet

  (issue #15195)
  Reported by: amorsen

  (issue AST-208)
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@201610 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoTrunk implementation of setting an alternate RTP source.
Mark Michelson [Thu, 18 Jun 2009 15:20:17 +0000 (15:20 +0000)]
Trunk implementation of setting an alternate RTP source.

This contains the interface by which we can let an rtp instance know
that it might start receiving audio from a new source. This is similar
in nature to revision 197588 of Asterisk 1.4.

Review: https://reviewboard.asterisk.org/r/276

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@201583 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoparsing extension correctly from sip register lines
David Vossel [Thu, 18 Jun 2009 15:16:05 +0000 (15:16 +0000)]
parsing extension correctly from sip register lines

If a transport type was specified, but no extension, parsing of the extension would return whatever was after the transport rather than defaulting to 's'.

(closes issue #15111)
Reported by: ffs
Patches:
      chan_sip.c_register-parser.patch uploaded by ffs (license 730)
Tested by: ffs, dvossel

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@201570 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoAdd rtsavesysname to chan_iax
David Vossel [Wed, 17 Jun 2009 21:56:42 +0000 (21:56 +0000)]
Add rtsavesysname to chan_iax

chan_sip has an option to save the sysname on rtupdate.  This patch copies that same logic to chan_iax.

(closes issue #14837)
Reported by: barthpbx
Patches:
      iax2-rtsavesysname.patch uploaded by barthpbx (license 744)
      rt_iax.diff uploaded by dvossel (license 671)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@201534 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoInitialize additional variables, to prevent a possible crash.
Tilghman Lesher [Wed, 17 Jun 2009 21:31:39 +0000 (21:31 +0000)]
Initialize additional variables, to prevent a possible crash.
(closes issue #15186)
 Reported by: ajohnson
 Patches:
       20090528__issue15186.diff.txt uploaded by tilghman (license 14)
 Tested by: ajohnson

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@201531 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoFix problem with no audio due to ignoring the SDP.
Mark Michelson [Wed, 17 Jun 2009 20:10:01 +0000 (20:10 +0000)]
Fix problem with no audio due to ignoring the SDP.

A recent change to our SDP version comparison made audio not function
on some calls. This was because of a test wherein we were trying to
see if an unsigned value was less than 0. This is a dumb comparison
and arguably the compiler should have warned about it. Alas, though,
it slipped past. Now it's fixed by changing the variable to be a
signed type.

Found by several developers. Tested by mnicholson and dbrooks.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@201462 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 201450 via svnmerge from
Mark Michelson [Wed, 17 Jun 2009 20:04:12 +0000 (20:04 +0000)]
Merged revisions 201450 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r201450 | mmichelson | 2009-06-17 14:59:31 -0500 (Wed, 17 Jun 2009) | 9 lines

  Change the datastore traversal in ast_do_masquerade to use a safe list traversal.

  It is possible for datastore fixup functions to remove the datastore from the list
  and free it. In particular, the queue_transfer_fixup in app_queue does this. While
  I don't yet know of this causing any crashes, it certainly could.

  Found while discussing a separate issue with Brian Degenhardt.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@201458 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoast_channel_datastore_alloc is no longer used. updating datastores.txt to reflect...
David Vossel [Wed, 17 Jun 2009 20:00:51 +0000 (20:00 +0000)]
ast_channel_datastore_alloc is no longer used. updating datastores.txt to reflect that.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@201453 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 201423 via svnmerge from
David Vossel [Wed, 17 Jun 2009 19:45:35 +0000 (19:45 +0000)]
Merged revisions 201423 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r201423 | dvossel | 2009-06-17 14:28:12 -0500 (Wed, 17 Jun 2009) | 19 lines

  StopMixMonitor race condition (not giving up file immediately)

  StopMixMonitor only indicates to the MixMonitor thread to stop
  writing to the file.  It does not guarantee that the recording's
  file handle is available to the dialplan immediately after execution.
  This results in a race condition.  To resolve this, the filestream
  pointer is placed in a datastore on the channel. When StopMixMonitor
  is called, the datastore is retrieved from the channel and the
  filestream is closed immediately before returning to the dialplan.
  Documentation indicating the use of StopMixMonitor to free files
  has been updated as well.

  (closes issue #15259)
  Reported by: travisghansen
  Tested by: dvossel

  Review: https://reviewboard.asterisk.org/r/283/
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@201445 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 201380 via svnmerge from
David Brooks [Wed, 17 Jun 2009 19:15:07 +0000 (19:15 +0000)]
Merged revisions 201380 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r201380 | dbrooks | 2009-06-17 13:45:50 -0500 (Wed, 17 Jun 2009) | 9 lines

  Checks for NULL sip_pvt pointer in chan_sip.c->acf_channel_read()

  Zombie channels could be passed, and chan_sip.c wasn't checking for it.
  Could crash Asterisk. Now checking for NULL pointer.

  (closes issue #15330)
  Reported by: okrief
  Tested by: dbrooks
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@201381 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoSIP registry ref count error
David Vossel [Wed, 17 Jun 2009 15:20:26 +0000 (15:20 +0000)]
SIP registry ref count error

During a sip reload, the list of sip_registry objects are
supposed to be traversed, unlinked, and destroyed, but
destruction never takes place due to a ref counting error.
This causes a memory leak when registry items are removed
from sip.conf and reloaded.  While the registries are removed
from the global list, they are not removed from the scheduler.
Because of this, SIP register attempts continue to be sent
out for the item even though it may no longer be in the .conf.

(closes issue #15295)
Reported by: amorsen

Review: https://reviewboard.asterisk.org/r/282/

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@201344 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoupdate chan_iax to use 64bit feature flags.
David Vossel [Wed, 17 Jun 2009 14:42:06 +0000 (14:42 +0000)]
update chan_iax to use 64bit feature flags.

(closes issue #15335)
Reported by: lmadsen

Review: https://reviewboard.asterisk.org/r/284/

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@201331 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 201261 via svnmerge from
Kevin P. Fleming [Wed, 17 Jun 2009 12:04:17 +0000 (12:04 +0000)]
Merged revisions 201261 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r201261 | kpfleming | 2009-06-17 07:03:25 -0500 (Wed, 17 Jun 2009) | 9 lines

  Correct AST_LIST_APPEND_LIST behavior when list to be appended is empty.

  When the list to be appended is empty, and the list to be appended to is *not*,
  AST_LIST_APPEND_LIST would actually cause the target list to become broken,
  and no longer have a pointer to its last entry. This patch fixes the problem.

  (reported by Stanislaw Pitucha on the asterisk-dev mailing list)
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@201262 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agofix issue with build_contact introduced by the "SIP trasnport type issues" commit
David Vossel [Tue, 16 Jun 2009 22:29:30 +0000 (22:29 +0000)]
fix issue with build_contact introduced by the "SIP trasnport type issues" commit

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@201223 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoUpdate my e-mail address (thanks for the props, russell :))
Sean Bright [Tue, 16 Jun 2009 22:11:07 +0000 (22:11 +0000)]
Update my e-mail address (thanks for the props, russell :))

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@201190 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoEnable applications to enable/disable digit and tone detection.
Kevin P. Fleming [Tue, 16 Jun 2009 21:10:15 +0000 (21:10 +0000)]
Enable applications to enable/disable digit and tone detection.

Some applications (notably app_fax) do not need digit detection nor FAX tone
detection while they are running, and if Asterisk is using software DSPs to provide
the detection, this consumes extra CPU cycles that could be better spent on the
actual application. This patch allows applications to query and control the state
of digit and tone detection on a channel, and modifies app_fax to disable them
while the FAX operations are occurring (and re-enable digit detection afterwards).

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@201139 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoExplicitly test for 'static weakref' support.
Kevin P. Fleming [Tue, 16 Jun 2009 21:02:05 +0000 (21:02 +0000)]
Explicitly test for 'static weakref' support.

Since we use 'static' weakref symbols, and not all GCC versions support them,
test for that combination explicitly.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@201137 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoWhen compiling in an Emacs-spawned shell, always print directory names.
Kevin P. Fleming [Tue, 16 Jun 2009 20:50:41 +0000 (20:50 +0000)]
When compiling in an Emacs-spawned shell, always print directory names.

This change ensures that Emacs can find the proper source files when parsing
compiler error messages, since it uses the 'make' output including directory
names to do it.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@201135 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoAnother minor fix to compiler attribute checking.
Kevin P. Fleming [Tue, 16 Jun 2009 19:27:12 +0000 (19:27 +0000)]
Another minor fix to compiler attribute checking.

Defaulting to 'static' for the function scope was bad... so remove it.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@201090 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 200991 via svnmerge from
Kevin P. Fleming [Tue, 16 Jun 2009 18:54:30 +0000 (18:54 +0000)]
Merged revisions 200991 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r200991 | kpfleming | 2009-06-16 12:05:38 -0500 (Tue, 16 Jun 2009) | 11 lines

  Improve support for media paths that can generate multiple frames at once.

  There are various media paths in Asterisk (codec translators and UDPTL, primarily)
  that can generate more than one frame to be generated when the application calling
  them expects only a single frame. This patch addresses a number of those cases,
  at least the primary ones to solve the known problems. In addition it removes the
  broken TRACE_FRAMES support, fixes a number of bugs in various frame-related API
  functions, and cleans up various code paths affected by these changes.

  https://reviewboard.asterisk.org/r/175/
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@201056 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoFix problems with new compiler attribute checking in configure script.
Kevin P. Fleming [Tue, 16 Jun 2009 16:32:36 +0000 (16:32 +0000)]
Fix problems with new compiler attribute checking in configure script.

The last changes to ast_gcc_attribute.m4 caused some problems checking for
various attributes, because the scope of the symbol the attribute is applied
to can be important; this patch allows the scope to be specified for the check.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@200985 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoSIP transport type issues
David Vossel [Tue, 16 Jun 2009 16:03:30 +0000 (16:03 +0000)]
SIP transport type issues

What this patch addresses:
1. ast_sip_ouraddrfor() by default binds to the UDP address/port
reguardless if the sip->pvt is of type UDP or not.  Now when no
remapping is required, ast_sip_ouraddrfor() checks the sip_pvt's
transport type, attempting to set the address and port to the
correct TCP/TLS bindings if necessary.
2.  It is not necessary to send the port number in the Contact
header unless the port is non-standard for the transport type.
This patch fixes this and removes the todo note.
3.  In sip_alloc(), the default dialog built always uses transport
type UDP.  Now sip_alloc() looks at the sip_request (if present)
and determines what transport type to use by default.
4.  When changing the transport type of a sip_socket, the file
descriptor must be set to -1 and in some cases the tcptls_session's
ref count must be decremented and set to NULL.  I've encountered
several issues associated with this process and have created a function,
set_socket_transport(), to handle the setting of the socket type.

(closes issue #13865)
Reported by: st
Patches:
      dont_add_port_if_tls.patch uploaded by Kristijan (license 753)
      13865.patch uploaded by mmichelson (license 60)
      tls_port_v5.patch uploaded by vrban (license 756)
      transport_issues.diff uploaded by dvossel (license 671)
Tested by: mmichelson, Kristijan, vrban, jmacz, dvossel

Review: https://reviewboard.asterisk.org/r/278/

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@200946 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoadd FILE_STORAGE to Voicemail Build Options
Michiel van Baak [Tue, 16 Jun 2009 15:51:36 +0000 (15:51 +0000)]
add FILE_STORAGE to Voicemail Build Options

Voicemail can only use one storage module at the moment.
Because it's unclear that selecting one of the storage modules
in menuselect will disable filesystem storage we now have
a FILE_STORAGE option that conflicts with the other modules.

(closes issue #15333)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@200943 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoAdd Sean Bright to CREDITS - Thanks, Sean!
Russell Bryant [Tue, 16 Jun 2009 15:26:57 +0000 (15:26 +0000)]
Add Sean Bright to CREDITS - Thanks, Sean!

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@200942 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoRecorded merge of revisions 200875 via svnmerge from
Eliel C. Sardanons [Tue, 16 Jun 2009 14:12:34 +0000 (14:12 +0000)]
Recorded merge of revisions 200875 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r200875 | eliel | 2009-06-16 09:25:51 -0400 (Tue, 16 Jun 2009) | 5 lines

  Show the interface name on error, if it is not found.

  If the smdiport specified is not found, show the interface name
  instead of '(null)'.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@200878 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoShow the interface name on error, if it is not found.
Eliel C. Sardanons [Tue, 16 Jun 2009 12:32:00 +0000 (12:32 +0000)]
Show the interface name on error, if it is not found.

If the smdiport specified is not found, show the interface name
instead of '(null)'.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@200841 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoDon't claim a char * is a mansession object.
Russell Bryant [Tue, 16 Jun 2009 02:32:33 +0000 (02:32 +0000)]
Don't claim a char * is a mansession object.

Since there was only 1 bucket, and no hash function was specified, the code
actually worked perfectly fine.  However, in theory, this was invalid use of
the OBJ_POINTER flag, so remove it so the code provides a better usage example.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@200805 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agokeep backwards compatible chan_dahdi with older openr2 versions by not using the...
Moises Silva [Tue, 16 Jun 2009 02:24:30 +0000 (02:24 +0000)]
keep backwards compatible chan_dahdi with older openr2 versions by not using the new skip category feature unless supported

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@200799 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoEnsure that configure-script testing for compiler attributes actually works.
Kevin P. Fleming [Tue, 16 Jun 2009 01:28:08 +0000 (01:28 +0000)]
Ensure that configure-script testing for compiler attributes actually works.

The configure script tests for compiler attributes didn't actually enable
enough warnings or provide a proper test harness to determine whether the
compiler supports the attribute in question or not; this caused gcc 4.1 to
report that it supports 'weakref', but it doesn't actually support it in the
way that is needed for our optional API mechanism. The new configure script
test will properly distinguish between full support and partial support
for this attribute, among others.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@200764 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoAdd missing closure of verbatim environment.
Russell Bryant [Tue, 16 Jun 2009 01:26:20 +0000 (01:26 +0000)]
Add missing closure of verbatim environment.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@200762 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoDocument the new automatic 'ignoresdpversion' behavior.
Kevin P. Fleming [Tue, 16 Jun 2009 01:03:22 +0000 (01:03 +0000)]
Document the new automatic 'ignoresdpversion' behavior.

Asterisk will now automatically ignore incorrect incoming SDP version numbers
when necessary to complete a T.38 re-INVITE operation.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@200726 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoAccept T.38 re-INVITE responses with invalid SDP versions.
Kevin P. Fleming [Mon, 15 Jun 2009 20:42:38 +0000 (20:42 +0000)]
Accept T.38 re-INVITE responses with invalid SDP versions.

This commit changes the 'incoming SDP version' check logic a bit more; when
'ignoresdpversion' is *not* set for a peer, if we initiate a re-INVITE to
switch to T.38, we'll always accept the peer's SDP response, even if they
don't properly increment the SDP version number as they should. If this situation
occurs, a warning message will be generated suggesting that the peer's
configuration be changed to include the 'ignoresdpversion' configuration option
(although ideally they'd fix their SIP implementation to be RFC compliant).

AST-221

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@200689 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoLast batch of 'static' qualifiers for module-level global variables.
Kevin P. Fleming [Mon, 15 Jun 2009 19:10:10 +0000 (19:10 +0000)]
Last batch of 'static' qualifiers for module-level global variables.

Fix up modules in the 'apps' directory, and also correct the bad example of
enum definitions in include/asterisk/app.h, which many developers followed
(thanks for reading the documentation!). In addition, add some basic usage
examples of the 'pahole' and 'pglobal' tools to the coding guidelines.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@200656 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMore 'static' qualifiers on module global variables.
Kevin P. Fleming [Mon, 15 Jun 2009 17:34:30 +0000 (17:34 +0000)]
More 'static' qualifiers on module global variables.

The 'pglobal' tool is quite handy indeed :-)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@200620 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoConvert a number of global module variables to 'static'.
Kevin P. Fleming [Mon, 15 Jun 2009 17:06:34 +0000 (17:06 +0000)]
Convert a number of global module variables to 'static'.

These modules all contained variables that are module-global but not system-global,
but were not marked 'static'.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@200587 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoSome minor structure size improvements in sip_pvt and sip_peer.
Kevin P. Fleming [Mon, 15 Jun 2009 16:38:32 +0000 (16:38 +0000)]
Some minor structure size improvements in sip_pvt and sip_peer.

Using the 'pahole' tool, it is now quite easy to see where structure fields
could be organized differently to keep the compiler from having to add
padding to satisfy alignment requirements. These changes reduced the sizes of
sip_pvt and sip_peer by a few bytes each (on 64-bit platforms), and also fixed
a spelling error in a field name.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@200584 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoRedesigned 'optional API' support.
Kevin P. Fleming [Mon, 15 Jun 2009 16:07:23 +0000 (16:07 +0000)]
Redesigned 'optional API' support.

This patch provides a new implementation of the optional API support defined
in asterisk/optional_api.h; this new version provides solves compatibility
issues with the use of linker version scripts for suppressing global symbols.
In addition, there is now a functional (and tested!) implementation for Mac OS/X,
so module writers no longer need to use special tests before calling optional
API functions. All future implementations must provide these same semantics,
so that module writers can rely on them.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@200519 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 200513 via svnmerge from
Mark Michelson [Mon, 15 Jun 2009 15:22:11 +0000 (15:22 +0000)]
Merged revisions 200513 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r200513 | mmichelson | 2009-06-15 10:21:46 -0500 (Mon, 15 Jun 2009) | 5 lines

  Add INFO to our allowed methods so that endpoints know they may send it to us.

  AST-223
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@200514 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoadded openr2 to menuselect-deps.in, recent commit in menuselect made me realize this...
Moises Silva [Sun, 14 Jun 2009 06:13:48 +0000 (06:13 +0000)]
added openr2 to menuselect-deps.in, recent commit in menuselect made me realize this was never done but was working anyways
also added support for skip category request feature of openr2 and updated chan_dahdi.conf.sample

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@200477 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoInclude basic installation and usage instructions for upstart script.
Sean Bright [Fri, 12 Jun 2009 19:46:25 +0000 (19:46 +0000)]
Include basic installation and usage instructions for upstart script.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@200430 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoFirst shot at an upstart script for asterisk on Ubuntu.
Sean Bright [Fri, 12 Jun 2009 19:42:26 +0000 (19:42 +0000)]
First shot at an upstart script for asterisk on Ubuntu.

This works relatively well (assuming you are using /var/run/asterisk) as your
run directory and upstart 0.3.9.  Needs to be generalized and eventually added
to the 'make install' target for Ubuntu.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@200428 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 200360 via svnmerge from
Mark Michelson [Fri, 12 Jun 2009 19:07:51 +0000 (19:07 +0000)]
Merged revisions 200360 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r200360 | mmichelson | 2009-06-12 14:06:41 -0500 (Fri, 12 Jun 2009) | 10 lines

  Suppress a warning message and give a better return code when generating
  inband ringing after a call is answered.

  (closes issue #15158)
  Reported by: madkins
  Patches:
        15158.patch uploaded by mmichelson (license 60)
  Tested by: madkins
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@200361 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoFix some bad locking stemming from trying to forward a call to a non-existent
Mark Michelson [Fri, 12 Jun 2009 15:37:30 +0000 (15:37 +0000)]
Fix some bad locking stemming from trying to forward a call to a non-existent
extension from a queue.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@200326 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoFix a potential crash from trying to access a NULL channel pointer.
Mark Michelson [Fri, 12 Jun 2009 14:55:07 +0000 (14:55 +0000)]
Fix a potential crash from trying to access a NULL channel pointer.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@200290 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoCall chgrp instead of chown when setting run directory group ownership.
Sean Bright [Fri, 12 Jun 2009 02:20:19 +0000 (02:20 +0000)]
Call chgrp instead of chown when setting run directory group ownership.

(issue #13153)
Reported by: pabelanger

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@200254 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoBlocked revisions 200185 via svnmerge
Sean Bright [Thu, 11 Jun 2009 22:21:32 +0000 (22:21 +0000)]
Blocked revisions 200185 via svnmerge

........
  r200185 | seanbright | 2009-06-11 18:20:31 -0400 (Thu, 11 Jun 2009) | 2 lines

  Backport fix for parallel build warnings from trunk r199781.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@200190 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoFix a crash due to a potentially NULL p->options.
Mark Michelson [Thu, 11 Jun 2009 21:17:14 +0000 (21:17 +0000)]
Fix a crash due to a potentially NULL p->options.

Thanks to mnicholson for pointing it out.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@200146 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoRelease the allocated channel decreasing the reference counter.
Eliel C. Sardanons [Thu, 11 Jun 2009 15:40:03 +0000 (15:40 +0000)]
Release the allocated channel decreasing the reference counter.

When allocating the channel use ao2_ref(-1) to release it, instead of calling
ast_free().
Also avoid freeing structures inside that channel (on error) if they will be
released by the channel destructor being called if the reference counter reachs
0.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@200108 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoFix path for .flavor and .version
Leif Madsen [Thu, 11 Jun 2009 12:15:09 +0000 (12:15 +0000)]
Fix path for .flavor and .version

(issue #14737)
Reported by: davidw
Patches:
      flavor.patch uploaded by davidw (license 780)
Tested by: davidw

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@200039 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoBlocked revisions 200037 via svnmerge
Leif Madsen [Thu, 11 Jun 2009 12:13:49 +0000 (12:13 +0000)]
Blocked revisions 200037 via svnmerge

........
  r200037 | lmadsen | 2009-06-11 08:12:06 -0400 (Thu, 11 Jun 2009) | 8 lines

  Fix path for .flavor and .version.

  (issue #14737)
  Reported by: davidw
  Patches:
        flavor.patch uploaded by davidw (license 780)
  Tested by: davidw
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@200038 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoRemove some trailing whitespace and steal revision 200000.
Sean Bright [Wed, 10 Jun 2009 20:40:41 +0000 (20:40 +0000)]
Remove some trailing whitespace and steal revision 200000.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@200000 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoOnly try to use the invite_branch on outgoing INVITEs with auth credentials.
Mark Michelson [Wed, 10 Jun 2009 20:15:48 +0000 (20:15 +0000)]
Only try to use the invite_branch on outgoing INVITEs with auth credentials.

I have added a comment to the code to help ease understanding of the logic here
as well.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@199958 65c4cc65-6c06-0410-ace0-fbb531ad65f3