asterisk/asterisk.git
9 years agoFix reading samples from format_mp3 after ast_seekstream/ast_tellstream.
Sean Bright [Wed, 6 Jan 2010 15:35:43 +0000 (15:35 +0000)]
Fix reading samples from format_mp3 after ast_seekstream/ast_tellstream.

There is a bug when using ast_seekstream/ast_tellstream with format_mp3 in that
the file read position is not reset before attempting to read samples.  So when
we seek to determine the maximum size of the file (as in res_agi's STREAM FILE)
we weren't then resetting the file pointer so that we could properly read
samples.  This patch addresses that (in a similar manner to format_wav.c).

(closes issue #15224)
Reported by: rbd
Patches:
      20091230_addons_1.4_issue15224.diff uploaded by seanbright (license 71)
Tested by: rbd, seanbright

Review: https://reviewboard.asterisk.org/r/453

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@238014 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 238009 via svnmerge from
Russell Bryant [Wed, 6 Jan 2010 15:19:10 +0000 (15:19 +0000)]
Merged revisions 238009 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r238009 | russell | 2010-01-06 09:18:22 -0600 (Wed, 06 Jan 2010) | 7 lines

  Resolve a crash due to an ast_frame not being fully initialized.

  (closes issue #16531)
  Reported by: john8675309

  (closes SWP-615)
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@238010 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoWhoa, duplicate setting (dead code).
Tilghman Lesher [Wed, 6 Jan 2010 06:53:23 +0000 (06:53 +0000)]
Whoa, duplicate setting (dead code).

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@237968 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agofixes holdtime playback issue in app_queue
David Vossel [Tue, 5 Jan 2010 23:08:50 +0000 (23:08 +0000)]
fixes holdtime playback issue in app_queue

When reporting hold time, the number of seconds should be mod 60.
Otherwise audio playback could be something like "2 minutes 123 seconds"
rather than "2 minutes 3 seconds".

Also, the "minute" sound file is missing, so for the moment until
that file can be created the "minutes" file is used instead.

(closes issue #16168)
Reported by: nickilo
Patches:
      patch-unified-trunk-rev-222176 uploaded by nickilo (license )
Tested by: nickilo, wonderg

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@237920 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMismerged a bit.
Mark Michelson [Tue, 5 Jan 2010 20:56:50 +0000 (20:56 +0000)]
Mismerged a bit.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@237882 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agofixes subscriptions being lost after 'module reload'
David Vossel [Tue, 5 Jan 2010 19:29:47 +0000 (19:29 +0000)]
fixes subscriptions being lost after 'module reload'

During a module reload if multiple extension configs are present,
such as both extensions.conf and extensions.ael, watchers for one
config's hints will be lost during the merging of the other config.

This happens because hint watchers are only preserved for the
current config being merged.  The old context list is destroyed
after the merging takes place, meaning any watchers that were not
perserved will be removed.

Now all hints are preserved during merging regardless of what config
file is being merged.  These hints are only restored if they
are present within the new context list.

(closes issue #16093)
Reported by: jlaroff

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@237839 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoRemoved unused parameters from analog_available() and sig_pri_available().
Richard Mudgett [Tue, 5 Jan 2010 18:57:29 +0000 (18:57 +0000)]
Removed unused parameters from analog_available() and sig_pri_available().

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@237804 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoAdd a missing part of the connected line work into trunk.
Mark Michelson [Tue, 5 Jan 2010 18:46:19 +0000 (18:46 +0000)]
Add a missing part of the connected line work into trunk.

Part of the work done for connected line was to add an optional
argument to the 'f' option to allow for the connected party information
of the outgoing channel to be set to the argument provided. This was
overlooked during the merge of the work to trunk and is being added
back now. The CHANGES file has also been updated to note this change.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@237803 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoSpell "aficionado" like someone who isn't stupid.
Mark Michelson [Tue, 5 Jan 2010 18:42:36 +0000 (18:42 +0000)]
Spell "aficionado" like someone who isn't stupid.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@237802 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoFix build of utility apps that include utils.c.
Russell Bryant [Tue, 5 Jan 2010 17:26:50 +0000 (17:26 +0000)]
Fix build of utility apps that include utils.c.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@237749 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 237697 via svnmerge from
Russell Bryant [Tue, 5 Jan 2010 17:16:01 +0000 (17:16 +0000)]
Merged revisions 237697 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r237697 | russell | 2010-01-05 11:13:28 -0600 (Tue, 05 Jan 2010) | 7 lines

  Change a NOTICE log message to DEBUG where it belongs.

  (closes issue #16479)
  Reported by: alexrecarey

  (closes SWP-577)
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@237699 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMake CLI command 'mixmonitor start|stop <channel> work again.
Michiel van Baak [Tue, 5 Jan 2010 16:08:12 +0000 (16:08 +0000)]
Make CLI command 'mixmonitor start|stop <channel> work again.

(closes issue #16534)
Reported by: jlaguilar
Fix as suggested by jlaguilar in the bugreport

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@237656 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 237573 via svnmerge from
Tilghman Lesher [Mon, 4 Jan 2010 21:48:20 +0000 (21:48 +0000)]
Merged revisions 237573 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r237573 | tilghman | 2010-01-04 15:45:46 -0600 (Mon, 04 Jan 2010) | 6 lines

  Bounds checking for input string
  (closes issue #16407)
   Reported by: qwell
   Patches:
         20100104__issue16407.diff.txt uploaded by tilghman (license 14)
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@237574 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 237493 via svnmerge from
Tilghman Lesher [Mon, 4 Jan 2010 20:59:01 +0000 (20:59 +0000)]
Merged revisions 237493 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r237493 | tilghman | 2010-01-04 14:57:35 -0600 (Mon, 04 Jan 2010) | 8 lines

  Regression in issue #15421 - Pattern matching
  (closes issue #16482)
   Reported by: wdoekes
   Patches:
         astsvn-16482-betterfix.diff uploaded by wdoekes (license 717)
         20091223__issue16482.diff.txt uploaded by tilghman (license 14)
   Tested by: wdoekes, tilghman
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@237494 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoOops, didn't compile (thanks, kpfleming)
Tilghman Lesher [Mon, 4 Jan 2010 19:03:20 +0000 (19:03 +0000)]
Oops, didn't compile (thanks, kpfleming)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@237414 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoFurther reduce the encoded blank values back to blank in the realtime API.
Tilghman Lesher [Mon, 4 Jan 2010 18:42:10 +0000 (18:42 +0000)]
Further reduce the encoded blank values back to blank in the realtime API.
(closes issue #16533)
 Reported by: sergee
 Patches:
       200100104__issue16533.diff.txt uploaded by tilghman (license 14)
 Tested by: sergee

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@237410 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 237405 via svnmerge from
Tilghman Lesher [Mon, 4 Jan 2010 18:28:28 +0000 (18:28 +0000)]
Merged revisions 237405 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r237405 | tilghman | 2010-01-04 12:19:00 -0600 (Mon, 04 Jan 2010) | 16 lines

  Add a flag to disable the Background behavior, for AGI users.
  This is in a section of code that relates to two other issues, namely
  issue #14011 and issue #14940), one of which was the behavior of
  Background when called with a context argument that matched the current
  context.  This fix broke FreePBX, however, in a post-Dial situation.
  Needless to say, this is an extremely difficult collision of several
  different issues.  While the use of an exception flag is ugly, fixing all
  of the issues linked is rather difficult (although if someone would like
  to propose a better solution, we're happy to entertain that suggestion).
  (closes issue #16434)
   Reported by: rickead2000
   Patches:
         20091217__issue16434.diff.txt uploaded by tilghman (license 14)
         20091222__issue16434__1.6.1.diff.txt uploaded by tilghman (license 14)
   Tested by: rickead2000
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@237406 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoapp_queue segfaults if realtime field uniqueid is NULL
David Vossel [Mon, 4 Jan 2010 16:39:11 +0000 (16:39 +0000)]
app_queue segfaults if realtime field uniqueid is NULL

(closes issue #16385)
Reported by: haakon
Patches:
      app_queue.c.patch uploaded by haakon (license 880)
      app_queue.c.patch_v2 uploaded by dvossel (license 671)
Tested by: haakon

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@237327 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoFix timeout for AGI command speech recognize.
Jeff Peeler [Mon, 4 Jan 2010 16:24:51 +0000 (16:24 +0000)]
Fix timeout for AGI command speech recognize.

(closes issue #16297)
Reported by: semond

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@237323 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 237318 via svnmerge from
Tilghman Lesher [Mon, 4 Jan 2010 16:20:03 +0000 (16:20 +0000)]
Merged revisions 237318 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r237318 | tilghman | 2010-01-04 10:18:59 -0600 (Mon, 04 Jan 2010) | 3 lines

  It's also possible for the Local channel to directly execute an Application.
  Reviewboard: https://reviewboard.asterisk.org/r/452/
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@237319 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years ago- Disable res_pktccops by default
Olle Johansson [Mon, 4 Jan 2010 07:55:30 +0000 (07:55 +0000)]
- Disable res_pktccops by default
- Add dependency in chan_mgcp that was missing
- Add a small amount of doc to the source code

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@237284 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years ago1. Added reporting operator names in AuthReq.
TransNexus OSP Development [Mon, 4 Jan 2010 03:38:29 +0000 (03:38 +0000)]
1. Added reporting operator names in AuthReq.
2. Added retrieving operator names from AuthRsp and exporting them.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@237250 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoglobal_contact_ha was renamed in trunk
Tilghman Lesher [Sat, 2 Jan 2010 16:35:35 +0000 (16:35 +0000)]
global_contact_ha was renamed in trunk

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@237213 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 237135 via svnmerge from
Olle Johansson [Sat, 2 Jan 2010 09:54:22 +0000 (09:54 +0000)]
Merged revisions 237135 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r237135 | oej | 2010-01-02 10:52:30 +0100 (Lör, 02 Jan 2010) | 2 lines

Release memory of the contact acl before unloading module

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@237136 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agosmall q931 processing and signalling corrections
Alexandr Anikin [Wed, 30 Dec 2009 23:51:32 +0000 (23:51 +0000)]
small q931 processing and signalling corrections

don't decode UUIE from Q931StatusMessage
clean call without callIdentifier data
don't start tcs/msd exchange procedure after call proceeding received

(closes issue #16365)
Reported by: benngard2
Tested by: may213, benngard2

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@237098 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoAdd app_voicemail and say.c support for Vietnamese.
Jason Parker [Wed, 30 Dec 2009 22:30:21 +0000 (22:30 +0000)]
Add app_voicemail and say.c support for Vietnamese.

Also add an XXX comment that I'm baffled nobody has ever complained about.  We
say "first message", and then we go into language-specific stuff where we
proceed to say..."first message".

(closes issue #15053)
Reported by: dinhtrung
Patches:
      vietnamese.ods uploaded by dinhtrung (license 776)
      app_voicemail.c.diff uploaded by dinhtrung (license 776)

(closes issue #15626)
Reported by: dinhtrung
Patches:
      say.c.diff uploaded by dinhtrung (license 776)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@237050 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 236981 via svnmerge from
Tilghman Lesher [Wed, 30 Dec 2009 21:59:18 +0000 (21:59 +0000)]
Merged revisions 236981 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r236981 | tilghman | 2009-12-30 15:57:10 -0600 (Wed, 30 Dec 2009) | 9 lines

  Don't queue frames to channels that have no means to process them.
  (closes issue #15609)
   Reported by: aragon
   Patches:
         20091230__issue16521__1.4__chan_local_only.diff.txt uploaded by tilghman (license 14)
   Tested by: aragon

  Review: https://reviewboard.asterisk.org/r/452/
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@236982 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoOne more LOW_MEMORY compile fix.
Jeff Peeler [Wed, 30 Dec 2009 21:09:28 +0000 (21:09 +0000)]
One more LOW_MEMORY compile fix.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@236902 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoFix compiling with LOW_MEMORY.
Jeff Peeler [Wed, 30 Dec 2009 20:34:41 +0000 (20:34 +0000)]
Fix compiling with LOW_MEMORY.

Modified handle_verbose to be LOW_MEMORY aware, removed old RTP related code
in chan_sip.

(closes issue #16381)
Reported by: michael_iedema
Patches:
      ast_complete_source_filename.patch uploaded by michael iedema (license 942)
      modified by me

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@236893 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoBlocked revisions 236890 via svnmerge
Jeff Peeler [Wed, 30 Dec 2009 20:25:58 +0000 (20:25 +0000)]
Blocked revisions 236890 via svnmerge

........
  r236890 | jpeeler | 2009-12-30 14:25:11 -0600 (Wed, 30 Dec 2009) | 2 lines

  Remove conflicting function definitions (asterisk.h) so LOW_MEMORY compiles.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@236891 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoWhen the field is blank, don't warn about the field being unable to be coerced, just...
Tilghman Lesher [Wed, 30 Dec 2009 17:53:29 +0000 (17:53 +0000)]
When the field is blank, don't warn about the field being unable to be coerced, just skip the column.
(closes http://lists.digium.com/pipermail/asterisk-dev/2009-December/041362.html)
Reported by Nic Colledge on the -dev list, fixed by me.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@236847 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoShut down the SIP session timers more gracefully, in order to prevent a possible...
Tilghman Lesher [Tue, 29 Dec 2009 23:05:45 +0000 (23:05 +0000)]
Shut down the SIP session timers more gracefully, in order to prevent a possible crash.
(closes issue #16452)
 Reported by: corruptor
 Patches:
       20091221__issue16452.diff.txt uploaded by tilghman (license 14)
 Tested by: corruptor

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@236802 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years ago1. Updated for OSP Toolkit 3.6.0.
TransNexus OSP Development [Tue, 29 Dec 2009 10:59:55 +0000 (10:59 +0000)]
1. Updated for OSP Toolkit 3.6.0.
2. Added service type ported number query.
3. Formated code.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@236756 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoAllow "REMAINDER" to function properly in expressions.
Jason Parker [Mon, 28 Dec 2009 22:09:40 +0000 (22:09 +0000)]
Allow "REMAINDER" to function properly in expressions.

(closes issue #16427)
Reported by: wdoekes
Patches:
      ast16-reminder-remainder.patch uploaded by wdoekes (license 717)
Tested by: wdoekes

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@236713 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoUse recommended option, not deprecated option.
Tilghman Lesher [Mon, 28 Dec 2009 17:37:46 +0000 (17:37 +0000)]
Use recommended option, not deprecated option.
(closes issue #16515)
 Reported by: ManChicken

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@236667 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 236585 via svnmerge from
Sean Bright [Mon, 28 Dec 2009 15:22:54 +0000 (15:22 +0000)]
Merged revisions 236585 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r236585 | seanbright | 2009-12-28 10:12:08 -0500 (Mon, 28 Dec 2009) | 7 lines

  Try a test compile to see if PTHREAD_ONCE_INIT requires extra braces.

  There was conditional code (based on build platform) to optioinally wrap
  PTHREAD_ONCE_INIT in braces that was removed since it is fixed in newer versions
  of Solaris/OpenSolaris, but I am still running into it on Solaris 10 x86 so add
  a configure-time check for it.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@236613 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 236509 via svnmerge from
Sean Bright [Mon, 28 Dec 2009 12:44:58 +0000 (12:44 +0000)]
Merged revisions 236509 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r236509 | seanbright | 2009-12-28 07:43:36 -0500 (Mon, 28 Dec 2009) | 12 lines

  Avoid a crash with large numbers of MeetMe conferences.

  Similar to changes made to Queue(), when we have large numbers of conferences in
  meetme.conf (1000s) and we use alloca()/strdupa(), we can blow out the stack and
  crash, so instead just use a single fixed buffer.

  (closes issue #16509)
  Reported by: Kashif Raza
  Patches:
        20091223_16509.patch uploaded by seanbright (license 71)
  Tested by: seanbright
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@236510 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 236433 via svnmerge from
Tilghman Lesher [Sun, 27 Dec 2009 18:20:53 +0000 (18:20 +0000)]
Merged revisions 236433 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r236433 | tilghman | 2009-12-27 12:19:38 -0600 (Sun, 27 Dec 2009) | 2 lines

  Turn on colors in the daemon, since there's many requests for it on Ubuntu.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@236434 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 236357 via svnmerge from
Kevin P. Fleming [Sat, 26 Dec 2009 15:27:44 +0000 (15:27 +0000)]
Merged revisions 236357 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r236357 | kpfleming | 2009-12-26 09:26:17 -0600 (Sat, 26 Dec 2009) | 1 line

  update to latest releases with zero uid/gid
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@236358 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoUpdate CHANGES to reflect new QUEUE_MEMBER option, "ready"
David Vossel [Wed, 23 Dec 2009 19:17:42 +0000 (19:17 +0000)]
Update CHANGES to reflect new QUEUE_MEMBER option, "ready"

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@236312 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoQUEUE_MEMBER(..., ready) counts only ready agents, not free agents wrapping up
David Vossel [Wed, 23 Dec 2009 19:14:05 +0000 (19:14 +0000)]
QUEUE_MEMBER(..., ready) counts only ready agents, not free agents wrapping up

The QUEUE_MEMBER dialplan function can return total members,
logged-in members and "free" members count. A member is counted
as "free" immediately after his call ends, even though its wrap-up
time, if specified in queues.conf, has not yet expired, and the
queue will not actually route a call to it.

This Patch introduces a new "ready" option that only counts
free agents no longer in the wrap up time period.

(closes issue #16240)
Reported by: kkm
Patches:
      appqueue-memberfun-readyoption-trunk.diff uploaded by kkm (license 888)
Tested by: kkm, dvossel

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@236308 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoupdate CHANGES to reflect new 'R' app_queue option plus a minor optimization to the...
David Vossel [Wed, 23 Dec 2009 18:45:54 +0000 (18:45 +0000)]
update CHANGES to reflect new 'R' app_queue option plus a minor optimization to the feature patch

(issue #16384)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@236306 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agonew parameter 'R' to the Queue application
David Vossel [Wed, 23 Dec 2009 18:39:37 +0000 (18:39 +0000)]
new parameter 'R' to the Queue application

The 'R' argument stops moh and indicates ringing once the agent is
ringing.  This allows the person in the queue to know their call
is potentially about to be answered.

(closes issue #16384)
Reported by: haakon
Patches:
      new_app_queue.c.patch uploaded by haakon (license 880)
Tested by: haakon, loloski, dvossel

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@236304 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoAGI may be invoked from outside the dialplan
Tilghman Lesher [Wed, 23 Dec 2009 18:25:27 +0000 (18:25 +0000)]
AGI may be invoked from outside the dialplan
(closes issue #16510)
 Reported by: atis
 Patches:
       20091223__issue16510.diff.txt uploaded by tilghman (license 14)
 Tested by: atis

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@236300 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 236184 via svnmerge from
Tilghman Lesher [Wed, 23 Dec 2009 03:07:48 +0000 (03:07 +0000)]
Merged revisions 236184 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r236184 | tilghman | 2009-12-22 20:55:24 -0600 (Tue, 22 Dec 2009) | 4 lines

  If EXEC only gets a single argument, don't crash when the second is used.
  (closes issue #16504)
   Reported by: bklang
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@236186 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoAllow test_heap.c to compile when AST_DEVMODE is true, but TEST_FRAMEWORK is false
Tilghman Lesher [Wed, 23 Dec 2009 03:03:47 +0000 (03:03 +0000)]
Allow test_heap.c to compile when AST_DEVMODE is true, but TEST_FRAMEWORK is false

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@236185 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoActually use tmp for something (brings trunk back into sync with 1.6 branches).
Tilghman Lesher [Wed, 23 Dec 2009 02:52:30 +0000 (02:52 +0000)]
Actually use tmp for something (brings trunk back into sync with 1.6 branches).

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@236183 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agofixes iax "can't compress subclass 4294967295" error
David Vossel [Tue, 22 Dec 2009 21:53:46 +0000 (21:53 +0000)]
fixes iax "can't compress subclass 4294967295" error

(closes issue #16456)
Reported by: dvossel
Tested by: dvossel

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@236144 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 236062 via svnmerge from
David Vossel [Tue, 22 Dec 2009 17:00:08 +0000 (17:00 +0000)]
Merged revisions 236062 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r236062 | dvossel | 2009-12-22 10:58:19 -0600 (Tue, 22 Dec 2009) | 11 lines

  fixes issue with p->method incorrectly set to ACK

  It is possible for a second ACK to come in for a retransmitted message.
  If an ack does not match an unacked message in our queue, restore the previous
  p->method as this ACK is completely ignored.

  (closes issue #16295)
  Reported by: omolenkamp
  Patches:
        issue16295_v2.diff uploaded by dvossel (license 671)
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@236063 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoupdate CHANGES to reflect the addition of the test framework
David Vossel [Tue, 22 Dec 2009 16:11:47 +0000 (16:11 +0000)]
update CHANGES to reflect the addition of the test framework

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@236028 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoUnit Test Framework API
David Vossel [Tue, 22 Dec 2009 16:09:11 +0000 (16:09 +0000)]
Unit Test Framework API

The Unit Test Framework is a new API that manages registration and
execution of unit tests in Asterisk with the purpose of verifying the
operation of C functions.  The Framework consists of a single test
manager accompanied by a list of registered test functions defined
within the code.  A test is defined, registered, and unregistered
from the framework using a set of macros which allow the test code
to only be compiled within asterisk when the TEST_FRAMEWORK flag is
enabled in menuselect.  This allows the test code to exist in the
same file as the C functions it intends to verify.  Registered tests
may be viewed and executed via a set of new CLI commands.  CLI commands
are also present for generating and exporting test results into xml
and txt formats.

For more information and use cases please refer to the documentation
provided at the beginning of the test.h file.

Review: https://reviewboard.asterisk.org/r/447/

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@236027 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 235940 via svnmerge from
Jeff Peeler [Mon, 21 Dec 2009 19:54:20 +0000 (19:54 +0000)]
Merged revisions 235940 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r235940 | jpeeler | 2009-12-21 13:43:41 -0600 (Mon, 21 Dec 2009) | 13 lines

  Change Monitor to not assume file to write to does not contain pathing.

  227944 changed the fname_base argument to always append the configured monitor
  path. This change was necessary to properly compare files for uniqueness.
  If a full path is given though, nothing needs to be appended and that is
  handled correctly now.

  (closes issue #16377)
  (closes issue #16376)
  Reported by: bcnit
  Patches:
        res_monitor.c-issue16376-1.patch uploaded by dant (license 670)
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@235941 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoChange all refererences to 1.6.3 to be 1.8, since that will be the next feature release
Kevin P. Fleming [Mon, 21 Dec 2009 18:51:17 +0000 (18:51 +0000)]
Change all refererences to 1.6.3 to be 1.8, since that will be the next feature release

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@235904 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 235821 via svnmerge from
Tilghman Lesher [Mon, 21 Dec 2009 17:00:46 +0000 (17:00 +0000)]
Merged revisions 235821 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r235821 | tilghman | 2009-12-21 10:45:03 -0600 (Mon, 21 Dec 2009) | 8 lines

  Send parking lot announcement to the channel which parked the call, not the park-ee.
  (closes issue #16234)
   Reported by: yeshuawatso
   Patches:
         20091210__issue16234.diff.txt uploaded by tilghman (license 14)
         20091221__issue16234__1.4.diff.txt uploaded by tilghman (license 14)
   Tested by: yeshuawatso
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@235822 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agorestarts busydetector (if enabled) when DTMF is received after call is bridged.
Alec L Davis [Sun, 20 Dec 2009 08:22:35 +0000 (08:22 +0000)]
restarts busydetector (if enabled) when DTMF is received after call is bridged.

  (closes issue 0016389)
  Reported by: alecdavis
  Tested by: alecdavis
  Patch
    dtmf_busydetector.diff2.txt uploaded by alecdavis (license 585)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@235774 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoapp_dial optional parameter to option 'r' to allow play indication from indications...
Alec L Davis [Sat, 19 Dec 2009 08:59:31 +0000 (08:59 +0000)]
app_dial optional parameter to option 'r' to allow play indication from indications.conf

  (closes issue #14504)
  Reported by: alecdavis
  Tested by: alecdavis,jsmith
  Patch
 app_dial.play_ring_indications.diff7.txt uploaded by alecdavis (license 585)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@235740 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 235635 via svnmerge from
Jeff Peeler [Fri, 18 Dec 2009 22:51:37 +0000 (22:51 +0000)]
Merged revisions 235635 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r235635 | jpeeler | 2009-12-18 16:29:51 -0600 (Fri, 18 Dec 2009) | 48 lines

  Correct CDR dispositions for BUSY/FAILED

  This patch is simple in that it reorders the disposition defines so that the fix
  for issue 12946 works properly (the default CDR disposition was changed to
  AST_CDR_NOANSWER). Also, the AST_CDR_FLAG_ORIGINATED flag was set in ast_call to
  ensure all CDR records are written.

  The side effects of CDR changes are scary, so I'm documenting the test cases
  performed to attempt to catch any regressions. The following tests were all
  performed using 1.4 rev 195881 vs head (235571) + patch:

  A calls B
  C calls B (busy)
  Hangup C
  Hangup A

  (Both SIP and features)
  A calls B
  A blind transfers to C
  Hangup C

  (Both SIP and features)
  A calls B
  A attended transfers to C
  Hangup C

  A calls B
  A attended transfers to C (SIP)
  C blind transfers to A (features)
  Hangup A

  All of the test scenario CDRs matched.

  The following tests were performed just with the patch to ensure proper operation
  (with unanswered=yes):

  exten =>s,1,Answer
  exten =>s,n,ResetCDR(w)
  exten =>s,n,ResetCDR(w)

  exten =>s,1,ResetCDR(w)
  exten =>s,n,ResetCDR(w)

  (closes issue #16180)
  Reported by: aatef
  Patches:
        bug16180.patch uploaded by jpeeler (license 325)
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@235660 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 235652 via svnmerge from
Tilghman Lesher [Fri, 18 Dec 2009 22:40:46 +0000 (22:40 +0000)]
Merged revisions 235652 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r235652 | tilghman | 2009-12-18 16:39:30 -0600 (Fri, 18 Dec 2009) | 2 lines

  Revise verbiage, per #asterisk-dev discussion
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@235656 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 235572 via svnmerge from
Tilghman Lesher [Fri, 18 Dec 2009 21:19:43 +0000 (21:19 +0000)]
Merged revisions 235572 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r235572 | tilghman | 2009-12-18 15:18:16 -0600 (Fri, 18 Dec 2009) | 2 lines

  Point to the typical missing package, not the cryptic "termcap support".
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@235573 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoRemove some old code for going to the 'fax' extension when a T.38 switchover occurs...
Joshua Colp [Thu, 17 Dec 2009 23:21:07 +0000 (23:21 +0000)]
Remove some old code for going to the 'fax' extension when a T.38 switchover occurs. This would have
already happened when we detected the CNG tone so this was basically a noop.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@235521 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 235421 via svnmerge from
Tilghman Lesher [Thu, 17 Dec 2009 17:19:08 +0000 (17:19 +0000)]
Merged revisions 235421 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r235421 | tilghman | 2009-12-17 11:17:51 -0600 (Thu, 17 Dec 2009) | 8 lines

  Use context from which Macro is executed, not macro context, if applicable.
  Also, ensure that the extension COULD match, not just that it won't match more.
  (closes issue #16113)
   Reported by: OrNix
   Patches:
         20091216__issue16113.diff.txt uploaded by tilghman (license 14)
   Tested by: OrNix
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@235422 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoFix call forwarding for analog phones.
Jeff Peeler [Thu, 17 Dec 2009 00:52:03 +0000 (00:52 +0000)]
Fix call forwarding for analog phones.

(closes issue #16440)
Reported by: mmichelson

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@235382 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoAdd auth_policy option to jabber.conf for auto user registration.
Jeff Peeler [Wed, 16 Dec 2009 20:25:27 +0000 (20:25 +0000)]
Add auth_policy option to jabber.conf for auto user registration.

The option is global and currently the acceptable values as noted in the sample
config are accept or deny.

(closes issue #15228)
Reported by: lp0

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@235342 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 235181 via svnmerge from
Jared Smith [Wed, 16 Dec 2009 05:24:58 +0000 (05:24 +0000)]
Merged revisions 235181 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r235181 | jsmith | 2009-12-15 15:07:55 -0600 (Tue, 15 Dec 2009) | 4 lines

  Add a line showing that we can use CIDR notation.

  patch by jsmith, after discussion with jtodd
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@235298 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoEnhance AMI redirect to allow channels to be redirected to different places.
Jeff Peeler [Wed, 16 Dec 2009 00:31:53 +0000 (00:31 +0000)]
Enhance AMI redirect to allow channels to be redirected to different places.

New parameters ExtraContext, ExtraExtension, and ExtraPriority have been added
to redirect the second channel to a different location. Previously, it was only
possible to redirect both channels to the same place.

(closes issue #15853)
Reported by: haakon
Patches:
      trunk-manager.c.patch uploaded by haakon (license 880)
Tested by: jpeeler

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@235265 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoIs it Friday yet?
Tilghman Lesher [Tue, 15 Dec 2009 23:51:05 +0000 (23:51 +0000)]
Is it Friday yet?

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@235229 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoChange match criteria existence in ast_channel_cmp_cb to use ast_strlen_zero.
Jeff Peeler [Tue, 15 Dec 2009 23:41:20 +0000 (23:41 +0000)]
Change match criteria existence in ast_channel_cmp_cb to use ast_strlen_zero.

(closes issue #16161)
Reported by: may213
Patches:
      core-show-channel.patch uploaded by may213 (license 454)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@235226 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoreverse minor sip registration regression
David Vossel [Tue, 15 Dec 2009 18:43:06 +0000 (18:43 +0000)]
reverse minor sip registration regression

A registration regression caused by a code tweak in (issue #14331)
and a bug fix in (issue #15539) caused some sip registration
config entries to be constructed incorrectly.  Origially
issue #14331 contained the code tweak as well as a bug fix, but since
the issue was reported as a tweak the bug fix portion was moved into
issue #15539.  Both the tweak and the bug fix contained minor incorrect
logic that resulted in some SIP registrations to fail.

(issue #14331)
(issue #15539)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@235132 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 235052 via svnmerge from
Tilghman Lesher [Tue, 15 Dec 2009 15:33:49 +0000 (15:33 +0000)]
Merged revisions 235052 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r235052 | tilghman | 2009-12-15 09:29:24 -0600 (Tue, 15 Dec 2009) | 4 lines

  Mandatory argument checking
  (closes issue #16446)
   Reported by: nicchap
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@235053 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agospandsp does in fact support V.17 modulation at 14.4 kilobits per second,
Kevin P. Fleming [Tue, 15 Dec 2009 14:35:46 +0000 (14:35 +0000)]
spandsp does in fact support V.17 modulation at 14.4 kilobits per second,
so we should generate T38MaxBitRate of 14400 (even though that doesn't really
affect the FAX transmission much at all)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@235010 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoSupport option 'n', as applications like Playback, Background etc.
Alec L Davis [Tue, 15 Dec 2009 07:18:31 +0000 (07:18 +0000)]
Support option 'n', as applications like Playback, Background etc.

Suggested on asterisk-dev as trivial application change.

Reported by: alecdavis
Tested by: alecdavis

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@234976 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoWhitespace.
Alec L Davis [Tue, 15 Dec 2009 03:26:49 +0000 (03:26 +0000)]
Whitespace.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@234940 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agorestarts busydetector (if enabled) when DTMF is received.
Alec L Davis [Tue, 15 Dec 2009 03:04:59 +0000 (03:04 +0000)]
restarts busydetector (if enabled) when DTMF is received.

  (closes issue #16389)
  Reported by: alecdavis
  Tested by: alecdavis
  Patch
dtmf_busydetector.diff.txt uploaded by alecdavis (license 585)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@234897 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agofixes escape to extensions 'o' and 'a', for digits '0' and '*'
Alec L Davis [Tue, 15 Dec 2009 02:29:50 +0000 (02:29 +0000)]
fixes escape to extensions 'o' and 'a', for digits '0' and '*'

(closes issue #16437)
Reported by: alecdavis
Tested by: alecdavis
Patch
extension_o_a_fix.diff.txt uploaded by alecdavis (license 585)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@234893 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoast_stream_and_wait(chan,dir-usingkeypad) didn't capture the dialled DTMF.
Alec L Davis [Tue, 15 Dec 2009 00:54:44 +0000 (00:54 +0000)]
ast_stream_and_wait(chan,dir-usingkeypad) didn't capture the dialled DTMF.

  (closes issue #16409)
  Reported by: alecdavis
  Tested by: alecdavis
  Patch
bug_16409.diff.txt uploaded by alecdavis (license 585)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@234855 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoAllow greetings-only mailboxes for Voicemail.
Tilghman Lesher [Mon, 14 Dec 2009 23:16:00 +0000 (23:16 +0000)]
Allow greetings-only mailboxes for Voicemail.
(closes issue #15132)
 Reported by: floletarmo
 Patches:
       voicemail_changes.patch uploaded by floletarmo (license 784)
       (with some additional changes by me)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@234820 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoAllow tonelist as argument to ReadExten.
Jason Parker [Mon, 14 Dec 2009 21:32:03 +0000 (21:32 +0000)]
Allow tonelist as argument to ReadExten.

ReadExten already supported playing a tonezone from indications.conf.
It now has the ability to use a tonelist like 440+480/2000|0/4000

(closes issue #15185)
Reported by: jcovert
Patches:
      app_readexten.c.patch uploaded by jcovert (license 551)
Tested by: qwell
Patch modified by me, to maintain backwards compatibility.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@234776 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 234699 via svnmerge from
Tilghman Lesher [Mon, 14 Dec 2009 21:13:18 +0000 (21:13 +0000)]
Merged revisions 234699 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r234699 | tilghman | 2009-12-14 15:09:56 -0600 (Mon, 14 Dec 2009) | 5 lines

  Deal with the situation where .flavor exists but .version does not.
  Also make the script slightly more portable, in keeping with autoconf syntax.
  (closes issue #14737)
   Reported by: davidw
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@234700 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoUpdate IMAP build documentation.
Leif Madsen [Mon, 14 Dec 2009 17:19:58 +0000 (17:19 +0000)]
Update IMAP build documentation.
Update the IMAP build documentation to show how to build on 64-bit
platforms.

(issue #16433)
Reported by: shrift
Tested by: lmadsen

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@234631 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoThe default rate for 'timing test' is actually 50/sec, not 100/sec as advertised.
Sean Bright [Mon, 14 Dec 2009 16:08:09 +0000 (16:08 +0000)]
The default rate for 'timing test' is actually 50/sec, not 100/sec as advertised.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@234572 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 234492 via svnmerge from
Olle Johansson [Mon, 14 Dec 2009 10:46:20 +0000 (10:46 +0000)]
Merged revisions 234492 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r234492 | oej | 2009-12-14 11:16:00 +0100 (Mån, 14 Dec 2009) | 8 lines

Stop sending 183's after call hangup.

There where still cases where the 183 keep-alive mechanism would not stop
sending 183's even though the Asterisk server had sent a final reply to
the invite.

EDVX-28

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@234526 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoTrim leading/trailing spaces from the filename, to deal with common user error.
Tilghman Lesher [Sun, 13 Dec 2009 09:41:43 +0000 (09:41 +0000)]
Trim leading/trailing spaces from the filename, to deal with common user error.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@234458 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 234379 via svnmerge from
Jeff Peeler [Fri, 11 Dec 2009 23:17:09 +0000 (23:17 +0000)]
Merged revisions 234379 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r234379 | jpeeler | 2009-12-11 16:37:21 -0600 (Fri, 11 Dec 2009) | 11 lines

  Fix talking detection status after conference user is muted.

  This patch ensures that when a conference user is muted that the accompanying
  AMI Meetme talking off event is sent. Also, the meetme list output is updated
  to show the muted user as unmonitored.

  (closes issue #16247)
  Reported by: dimas
  Patches:
        v3-16247.patch uploaded by dimas (license 88)
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@234380 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 234255 via svnmerge from
Jason Parker [Thu, 10 Dec 2009 21:01:39 +0000 (21:01 +0000)]
Merged revisions 234255 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r234255 | qwell | 2009-12-10 14:58:09 -0600 (Thu, 10 Dec 2009) | 9 lines

  Fix unselecting of menuselect options via GLOBAL_MAKEOPTS and USER_MAKEOPTS.

  (closes issue #16296)
  Reported by: abelbeck
  Patches:
        issue16296-20091210.diff uploaded by qwell (license 4)
  (abelbeck described a fix, which I expanded upon)
  Tested by: abelbeck, qwell, lmadsen
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@234256 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMissed a case that emits a WARNING where none is warranted.
Tilghman Lesher [Thu, 10 Dec 2009 18:56:23 +0000 (18:56 +0000)]
Missed a case that emits a WARNING where none is warranted.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@234210 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoAdd audio announcement option to app_page
Jeff Peeler [Thu, 10 Dec 2009 17:31:23 +0000 (17:31 +0000)]
Add audio announcement option to app_page

As described in the CHANGES file:
* MeetMe has a new option 'G' to play an announcement before joining a
  conference.
* Page has a new option 'A(x)' which will playback an announcement
  simultaneously to all paged phones (and optionally excluding the caller's one
  using the new option 'n') before the call is bridged.

To add the new option to meetme, the conference flag options had to be extended
to 64 bits.

(closes issue #14365)
Reported by: dferrer
Patches:
      page_announce.patch uploaded by dferrer (license 525)
      modified by me

Review: https://reviewboard.asterisk.org/r/188/

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@234173 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 234095 via svnmerge from
Tilghman Lesher [Thu, 10 Dec 2009 16:24:26 +0000 (16:24 +0000)]
Merged revisions 234095 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r234095 | tilghman | 2009-12-10 10:08:20 -0600 (Thu, 10 Dec 2009) | 9 lines

  When we receive no response at all to our INVITE, allow the channel to be destroyed.
  (closes issue #15627)
   Reported by: falves11
   Patches:
         20091209__issue15627__1.6.0.diff.txt uploaded by tilghman (license 14)
         20091209__issue15627__1.4.diff.txt uploaded by tilghman (license 14)
   Tested by: falves11
  Review: https://reviewboard.asterisk.org/r/446/
  (closes issue #15716)
  Reported by: dant
  (closes issue #16270)
  Reported by: corruptor
  (closes issue #15356)
  Reported by: falves11
  (issue #16382)
  Reported by: lftsy
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@234129 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMove an entry from CHANGES to UPGRADE.txt.
Russell Bryant [Wed, 9 Dec 2009 23:35:24 +0000 (23:35 +0000)]
Move an entry from CHANGES to UPGRADE.txt.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@234055 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMove an entry from CHANGES that should be in UPGRADE.txt.
Russell Bryant [Wed, 9 Dec 2009 23:30:48 +0000 (23:30 +0000)]
Move an entry from CHANGES that should be in UPGRADE.txt.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@234053 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoProvide a real description of LOCAL_PEEK().
Russell Bryant [Wed, 9 Dec 2009 23:26:50 +0000 (23:26 +0000)]
Provide a real description of LOCAL_PEEK().

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@234051 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoRemove a feature from CHANGES that was listed twice for 1.6.2.
Russell Bryant [Wed, 9 Dec 2009 23:20:49 +0000 (23:20 +0000)]
Remove a feature from CHANGES that was listed twice for 1.6.2.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@234028 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoFix up the faxdetect entry in CHANGES.
Russell Bryant [Wed, 9 Dec 2009 23:13:28 +0000 (23:13 +0000)]
Fix up the faxdetect entry in CHANGES.

This feature was listed as a 1.6.2 feature, even though it's in all 1.6.X
versions.  The description of the feature was also no longer accurate.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@234008 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoRemove an entry from CHANGES that is already in UPGRADE.txt (where it should be).
Russell Bryant [Wed, 9 Dec 2009 22:15:39 +0000 (22:15 +0000)]
Remove an entry from CHANGES that is already in UPGRADE.txt (where it should be).

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@233967 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoBlocked revisions 233879 via svnmerge
Russell Bryant [Wed, 9 Dec 2009 19:59:13 +0000 (19:59 +0000)]
Blocked revisions 233879 via svnmerge

........
  r233879 | russell | 2009-12-09 13:58:46 -0600 (Wed, 09 Dec 2009) | 2 lines

  Fix breakage of the "module load <module>" CLI command.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@233880 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoBlocked revisions 233782 via svnmerge
Russell Bryant [Wed, 9 Dec 2009 15:15:02 +0000 (15:15 +0000)]
Blocked revisions 233782 via svnmerge

........
  r233782 | russell | 2009-12-09 09:14:21 -0600 (Wed, 09 Dec 2009) | 22 lines

  Set a module load priority for format modules.

  A recent change to app_voicemail made it such that the module now assumes that
  all format modules are available while processing voicemail configuration.
  However, when autoloading modules, it was possible that app_voicemail was
  loaded before the format modules. Since format modules don't depend on
  anything, set a module load priority on them to ensure that they get loaded
  first when autoloading.

  This version of the patch is specific to Asterisk 1.4 and 1.6.0.  These versions
  did not already support module load priority in the module API.  This adds a
  trivial version of this which is just a module flag to include it in a pass before
  loading "everything".

  Thanks to mmichelson for the review!

  (closes issue #16412)
  Reported by: jiddings
  Tested by: russell

  Review: https://reviewboard.asterisk.org/r/445/
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@233783 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoTypo pointed out on #asterisk-dev (by atis_work)
Tilghman Lesher [Tue, 8 Dec 2009 18:40:19 +0000 (18:40 +0000)]
Typo pointed out on #asterisk-dev (by atis_work)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@233732 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoFind another ref leak and change how we manage module references.
Tilghman Lesher [Tue, 8 Dec 2009 18:22:44 +0000 (18:22 +0000)]
Find another ref leak and change how we manage module references.
(closes issue #16388, closes issue #16279, closes issue #16390)
 Reported by: parisioa
 Patches:
       20091208__issue16388.diff.txt uploaded by tilghman (license 14)
 Tested by: parisioa, tilghman
 Review: https://reviewboard.asterisk.org/r/442/

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@233718 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoSet a module load priority for format modules.
Russell Bryant [Tue, 8 Dec 2009 18:00:16 +0000 (18:00 +0000)]
Set a module load priority for format modules.

A recent change to app_voicemail made it such that the module now assumes that
all format modules are available while processing voicemail configuration.
However, when autoloading modules, it was possible that app_voicemail was
loaded before the format modules.  Since format modules don't depend on
anything, set a module load priority on them to ensure that they get loaded
first when autoloading.

This fix applies to trunk, 1.6.1, and 1.6.2.  The fix for 1.4 and 1.6.0 will
require a different approach since the module load priority functionality is
not present in the module API.

(issue #16412)
Reported by: jiddings

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@233692 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoBlocked revisions 233618 via svnmerge
Atis Lezdins [Tue, 8 Dec 2009 00:09:34 +0000 (00:09 +0000)]
Blocked revisions 233618 via svnmerge

................
  r233618 | atis | 2009-12-08 02:02:43 +0200 (Tue, 08 Dec 2009) | 15 lines

  Merged revisions 233577 via svnmerge from
  https://origsvn.digium.com/svn/asterisk/trunk

  ........
    r233577 | atis | 2009-12-08 01:10:13 +0200 (Tue, 08 Dec 2009) | 8 lines

    Fix compatibility with valgrind 3.3 and older.

    (noticed in issue #16388)
    Reported by: parisioa
    Patches:
        valgrind.supp uloaded by atis (license 242)
    Tested by: atis, parisioa
  ........
................

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@233619 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agofixes incorrect logic in ast_uri_encode
David Vossel [Mon, 7 Dec 2009 23:28:51 +0000 (23:28 +0000)]
fixes incorrect logic in ast_uri_encode

issue #16299

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@233611 65c4cc65-6c06-0410-ace0-fbb531ad65f3