asterisk/asterisk.git
11 years agoContinue to move variables into the sip_cfg structure to make them easier to handle...
Olle Johansson [Mon, 26 Jan 2009 15:51:00 +0000 (15:51 +0000)]
Continue to move variables into the sip_cfg structure to make them easier to handle in the future as a group of settings for a group of devices.
At some point, I want one sip_cfg per domain handled, so we can have "group" settings.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@171400 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoJust moving around variable declarations so that we have all globals in the same...
Olle Johansson [Mon, 26 Jan 2009 15:11:39 +0000 (15:11 +0000)]
Just moving around variable declarations so that we have all globals in the same place.
Default setting is set before we activate the channel or at reloads, not where we declare the variable.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@171364 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 171264 via svnmerge from
Olle Johansson [Mon, 26 Jan 2009 13:44:40 +0000 (13:44 +0000)]
Merged revisions 171264 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r171264 | oej | 2009-01-26 13:51:53 +0100 (MÃ¥n, 26 Jan 2009) | 9 lines

Don't retransmit 401 on REGISTER requests when alwaysauthreject=yes

(closes issue #14284)
Reported by: klaus3000
Patches:
      patch_chan_sip_unreliable_1.4.23_14284.txt uploaded by klaus3000 (license 65)
Tested by: klaus3000

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@171326 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoAdd extensions and context on manager event when new channel is created.
Olle Johansson [Mon, 26 Jan 2009 12:32:30 +0000 (12:32 +0000)]
Add extensions and context on manager event when new channel is created.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@171263 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 171187 via svnmerge from
Tilghman Lesher [Sun, 25 Jan 2009 23:58:00 +0000 (23:58 +0000)]
Merged revisions 171187 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r171187 | tilghman | 2009-01-25 17:44:01 -0600 (Sun, 25 Jan 2009) | 6 lines

  Correctly track the hookstate
  (closes issue #13686)
   Reported by: itiliti
   Patches:
         20081013__bug13686.diff.txt uploaded by Corydon76 (license 14)
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@171188 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoBlocked revisions 171122 via svnmerge
Tilghman Lesher [Sun, 25 Jan 2009 20:41:19 +0000 (20:41 +0000)]
Blocked revisions 171122 via svnmerge

........
  r171122 | tilghman | 2009-01-25 14:40:44 -0600 (Sun, 25 Jan 2009) | 2 lines

  Err, yeah.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@171123 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoBlocked revisions 171120 via svnmerge
Tilghman Lesher [Sun, 25 Jan 2009 20:31:57 +0000 (20:31 +0000)]
Blocked revisions 171120 via svnmerge

........
  r171120 | tilghman | 2009-01-25 14:30:41 -0600 (Sun, 25 Jan 2009) | 8 lines

  Add thread to kill zombies, when child processes don't die immediately on
  SIGHUP.
  (closes issue #13968)
   Reported by: eldadran
   Patches:
         20090114__bug13968.diff.txt uploaded by Corydon76 (license 14)
   Tested by: eldadran
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@171121 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agodont segfault when a MWI event occurs on a line without a registered device
Michiel van Baak [Sun, 25 Jan 2009 16:50:53 +0000 (16:50 +0000)]
dont segfault when a MWI event occurs on a line without a registered device

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@171081 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMake the sample skinny.conf work
Michiel van Baak [Sun, 25 Jan 2009 14:35:17 +0000 (14:35 +0000)]
Make the sample skinny.conf work

(closes issue #14325)
Reported by: DEA
Patches:
      skinny.conf.sample-trunk.txt uploaded by DEA (license 3)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@171043 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 170979 via svnmerge from
Sean Bright [Sun, 25 Jan 2009 13:35:48 +0000 (13:35 +0000)]
Merged revisions 170979 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r170979 | seanbright | 2009-01-25 08:33:20 -0500 (Sun, 25 Jan 2009) | 9 lines

  Resolve a logic error that was causing Page() to crash when more than one
  channel was specified.

  (closes issue #14308)
  Reported by: bluefox
  Patches:
        20090124__bug14308.diff.txt uploaded by seanbright (license 71)
  Tested by: kc0bvu
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@170980 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoChange ARRAY_LEN() to be more C++ safe.
Russell Bryant [Sun, 25 Jan 2009 02:49:30 +0000 (02:49 +0000)]
Change ARRAY_LEN() to be more C++ safe.

When the second part of this macro is written as 0[a] instead of a[0], it will
force a failure if the macro is used on a C++ object that overloads the []
operator.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@170943 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoAdd a todo to finish the XML docs in this module
Russell Bryant [Sat, 24 Jan 2009 19:33:15 +0000 (19:33 +0000)]
Add a todo to finish the XML docs in this module

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@170902 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 170836 via svnmerge from
Tilghman Lesher [Sat, 24 Jan 2009 13:55:53 +0000 (13:55 +0000)]
Merged revisions 170836 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r170836 | tilghman | 2009-01-24 07:55:02 -0600 (Sat, 24 Jan 2009) | 2 lines

  Remove superfluous implementation note (closes issue #14319)
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@170837 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoFix asterisk.pdf generation if branch name has an underscore in it.
Richard Mudgett [Fri, 23 Jan 2009 23:10:34 +0000 (23:10 +0000)]
Fix asterisk.pdf generation if branch name has an underscore in it.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@170794 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoDon't blow up if a branch name has an underscore in it
Russell Bryant [Fri, 23 Jan 2009 22:58:37 +0000 (22:58 +0000)]
Don't blow up if a branch name has an underscore in it

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@170790 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 170719 via svnmerge from
Mark Michelson [Fri, 23 Jan 2009 20:56:07 +0000 (20:56 +0000)]
Merged revisions 170719 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r170719 | mmichelson | 2009-01-23 14:55:26 -0600 (Fri, 23 Jan 2009) | 8 lines

Add notes to the idlecheck explanation in res_odbc.conf.sample

(closes issue #14319)
Reported by: klaus3000
Patches:
      patch_idlecheck_res_odbc.conf.sample.txt uploaded by klaus3000 (license 65)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@170720 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 170671 via svnmerge from
Mark Michelson [Fri, 23 Jan 2009 20:23:00 +0000 (20:23 +0000)]
Merged revisions 170671 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r170671 | mmichelson | 2009-01-23 14:21:51 -0600 (Fri, 23 Jan 2009) | 14 lines

Update contrib/i18n.testsuite.conf to not use deprecated syntax

* Convert Wait,1 to Wait(1)
* Convert SetLanguage to Set(CHANNEL(language))
* Use 'n' for all priorities beyond the first

Also added test for Chinese numbers, too.

(closes issue #14320)
Reported by: dant
Patches:
      i18n.testsuite.conf.issue14320.v2.diff uploaded by dant (license 670)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@170677 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 170648 via svnmerge from
Joshua Colp [Fri, 23 Jan 2009 20:18:05 +0000 (20:18 +0000)]
Merged revisions 170648 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r170648 | file | 2009-01-23 16:16:39 -0400 (Fri, 23 Jan 2009) | 4 lines

  When a channel is answered make sure any indications currently playing stop. Usually the phone would do this but if the channel was already answered then they are being generated by Asterisk and we darn well need to stop them.
  (closes issue #14249)
  Reported by: RadicAlish
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@170652 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 170588 via svnmerge from
Tilghman Lesher [Fri, 23 Jan 2009 19:25:10 +0000 (19:25 +0000)]
Merged revisions 170588 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r170588 | tilghman | 2009-01-23 13:20:44 -0600 (Fri, 23 Jan 2009) | 2 lines

  Additions to AST-2009-001
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@170608 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 170568 via svnmerge from
Joshua Colp [Fri, 23 Jan 2009 19:09:18 +0000 (19:09 +0000)]
Merged revisions 170568 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r170568 | file | 2009-01-23 15:06:54 -0400 (Fri, 23 Jan 2009) | 4 lines

  When a call is forwarded stop any active indications. The new channel will provide an indication, if need be, itself.
  (closes issue #14310)
  Reported by: RadicAlish
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@170569 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 170504 via svnmerge from
Joshua Colp [Fri, 23 Jan 2009 18:09:45 +0000 (18:09 +0000)]
Merged revisions 170504 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r170504 | file | 2009-01-23 14:04:08 -0400 (Fri, 23 Jan 2009) | 4 lines

  Use the on hold flag to see if the call is on hold or not. It is possible that our address for them will still be valid even though they are on hold.
  (closes issue #14295)
  Reported by: klaus3000
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@170505 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agolet's use SENTINEL where needed
Michiel van Baak [Fri, 23 Jan 2009 17:46:02 +0000 (17:46 +0000)]
let's use SENTINEL where needed

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@170501 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoReset the ast_str used for escape substitution. We need to do this since it is a...
Joshua Colp [Fri, 23 Jan 2009 17:32:26 +0000 (17:32 +0000)]
Reset the ast_str used for escape substitution. We need to do this since it is a thread local variable that may contain the value of a previous substitution.
(closes issue #14312)
Reported by: pj

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@170498 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoWe should not do restart messages if we're in PTMP mode
Matthew Fredrickson [Fri, 23 Jan 2009 17:03:41 +0000 (17:03 +0000)]
We should not do restart messages if we're in PTMP mode

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@170463 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoDont clear the display of skinny phones when not needed.
Michiel van Baak [Fri, 23 Jan 2009 16:57:07 +0000 (16:57 +0000)]
Dont clear the display of skinny phones when not needed.

(closes issue #13182)
Reported by: pj
Patches:
      2009011901_dontcleardisplay.diff.txt uploaded by mvanbaak (license 7)
Tested by: mvanbaak, pj

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@170460 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMWI messages included in CID spill was not being properly handled and prevented the...
Doug Bailey [Fri, 23 Jan 2009 16:35:30 +0000 (16:35 +0000)]
MWI messages included in CID spill was not being properly handled and prevented the call from being processed
(issue #14313)
Reported by: seandarcy
Tested by: dbailey

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@170457 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 170392 via svnmerge from
Mark Michelson [Fri, 23 Jan 2009 15:44:27 +0000 (15:44 +0000)]
Merged revisions 170392 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r170392 | mmichelson | 2009-01-23 09:40:39 -0600 (Fri, 23 Jan 2009) | 28 lines

Fix broken call pickup

There was a subtle change in ast_do_masquerade which
resulted in failed attempts to pickup calls. The problem
was that the value of the AST_FLAG_OUTGOING flag was
copied from the clone to the original channel. In the case
of call pickup, this meant that the AST_FLAG_OUTGOING flag
ended up being cleared on the channel that was attempting
to execute the pickup.

Because this flag was not set, when ast_read came across
an answer frame, it ignored it. The result of this was that
the calling channel was never properly answered.

This fix changes the behavior in ast_do_masquerade to set
the flags on the original channel to the union of the flags
on the clone channel. This way, if the AST_FLAG_OUTGOING
flag is set on either of the two channels involved in the
masquerade, the resulting channel will have the flag set
as well.

(closes issue #14206)
Reported by: francesco_r
Patches:
      14206.patch uploaded by putnopvut (license 60)
Tested by: francesco_r, aragon, putnopvut

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@170393 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMake sure we don't set the channel to be inalarm for a D-channel drop on PTMP connections
Matthew Fredrickson [Thu, 22 Jan 2009 23:23:22 +0000 (23:23 +0000)]
Make sure we don't set the channel to be inalarm for a D-channel drop on PTMP connections

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@170351 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoCreate logfile safely.
Tilghman Lesher [Thu, 22 Jan 2009 21:25:46 +0000 (21:25 +0000)]
Create logfile safely.
(closes issue #14160)
 Reported by: tzafrir
 Patches:
       20090104__bug14160.diff.txt uploaded by Corydon76 (license 14)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@170307 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 170239 via svnmerge from
Joshua Colp [Thu, 22 Jan 2009 20:04:39 +0000 (20:04 +0000)]
Merged revisions 170239 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r170239 | file | 2009-01-22 16:02:35 -0400 (Thu, 22 Jan 2009) | 7 lines

  Don't crash if RTCP is not enabled on an RTP structure but statistics are output.
  (closes issue #14234)
  Reported by: jcovert
  Patches:
        rtp.c.patch-1.6.0.3 uploaded by jcovert (license 551)
        rtp.c.patch-svn-165599 uploaded by jcovert (license 551)
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@170240 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 170158 via svnmerge from
Tilghman Lesher [Thu, 22 Jan 2009 17:19:28 +0000 (17:19 +0000)]
Merged revisions 170158 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r170158 | tilghman | 2009-01-22 11:18:07 -0600 (Thu, 22 Jan 2009) | 6 lines

  Allow global variables after substitution to be as long as other variables.
  (closes issue #14263)
   Reported by: markd
   Patches:
         20090120__bug14263.diff.txt uploaded by Corydon76 (license 14)
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@170165 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 170147 via svnmerge from
Joshua Colp [Thu, 22 Jan 2009 16:52:21 +0000 (16:52 +0000)]
Merged revisions 170147 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r170147 | file | 2009-01-22 12:50:54 -0400 (Thu, 22 Jan 2009) | 4 lines

  If we are unable to request a DAHDI pseudo channel and we are using the user introduction without review option make sure it gets unset so other code does not blindly assume a DAHDI pseudo channel exists.
  (closes issue #14282)
  Reported by: cheesegrits
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@170148 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agochange VMWI to use new DAHDI_VMWI ioctl call.
Doug Bailey [Thu, 22 Jan 2009 15:49:24 +0000 (15:49 +0000)]
change VMWI to use new DAHDI_VMWI ioctl call.
Change configure script to detect the new ioctl call data structure.
(issue #14104)
Reported by: alecdavis
Patches:
      mwiioctl_structure_asterisk.diff4.txt uploaded by dbailey (license )
Tested by: alecdavis, dbailey

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@170112 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 170050 via svnmerge from
Joshua Colp [Thu, 22 Jan 2009 15:14:50 +0000 (15:14 +0000)]
Merged revisions 170050 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r170050 | file | 2009-01-22 11:13:56 -0400 (Thu, 22 Jan 2009) | 6 lines

  Do a string comparison instead of pointer comparison since some people specify the context they are actually in as an argument to get around some funkiness.
  (closes issue #14011)
  Reported by: dveiga
  Patches:
        pbx.c.patch uploaded by dveiga (license 665)
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@170051 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoClear the autoloop flag when parsing and setting the context/extension/priority to...
Joshua Colp [Thu, 22 Jan 2009 15:01:54 +0000 (15:01 +0000)]
Clear the autoloop flag when parsing and setting the context/extension/priority to go back to. When the channel executes a PBX again we want it to start out at the point we explicitly say and at that point it will not yet be doing autoloop.
(closes issue #14304)
Reported by: jcovert

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@170047 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years ago* Adjust some conditionals to balance curly braces.
Richard Mudgett [Thu, 22 Jan 2009 02:10:41 +0000 (02:10 +0000)]
*  Adjust some conditionals to balance curly braces.
*  Other minor changes.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@170007 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 169943 via svnmerge from
Tilghman Lesher [Thu, 22 Jan 2009 00:44:52 +0000 (00:44 +0000)]
Merged revisions 169943 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r169943 | tilghman | 2009-01-21 18:43:31 -0600 (Wed, 21 Jan 2009) | 9 lines

  AST_RWLOCK_INIT_VALUE is always defined.  What we really wanted to ask is
  whether autoconf detected a static initializer value.  This fixes rwlocks
  on all such platforms (mainly, Mac OS X).
  (closes issue #13767)
   Reported by: jcovert
   Patches:
         20090121__bug13767.diff.txt uploaded by Corydon76 (license 14)
   Tested by: jcovert, Corydon76
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@169944 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoWhitespace changes only
Richard Mudgett [Thu, 22 Jan 2009 00:23:30 +0000 (00:23 +0000)]
Whitespace changes only

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@169910 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 169867 via svnmerge from
Joshua Colp [Wed, 21 Jan 2009 23:25:27 +0000 (23:25 +0000)]
Merged revisions 169867 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r169867 | file | 2009-01-21 19:20:47 -0400 (Wed, 21 Jan 2009) | 4 lines

  Read lock the contexts to maintain the locking order when we are notified that the state of a device has changed.
  (closes issue #13839)
  Reported by: mcallist
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@169869 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoTest commit for test issue #14303
Mark Michelson [Wed, 21 Jan 2009 23:20:27 +0000 (23:20 +0000)]
Test commit for test issue #14303

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@169866 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoBlocked revisions 169797 via svnmerge
Mark Michelson [Wed, 21 Jan 2009 22:15:16 +0000 (22:15 +0000)]
Blocked revisions 169797 via svnmerge

........
r169797 | mmichelson | 2009-01-21 16:14:52 -0600 (Wed, 21 Jan 2009) | 3 lines

Adding revision 169794 to 1.4 since 1.4 is also affected by the issue

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@169798 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoFix a crash when saying certain numbers in Chinese
Mark Michelson [Wed, 21 Jan 2009 22:10:02 +0000 (22:10 +0000)]
Fix a crash when saying certain numbers in Chinese

This commit fixes a crash that was occurring when attempting to
say a number between 10000 and 100000 due to dividing by 0.

This also removes some places where a "zero" is spoken when it
should not be.

(closes issue #14291)
Reported by: dant
Patches:
      say.c-14291.diff uploaded by dant (license 670)
Tested by: dant

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@169794 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoremove duplicated sentence.
Michiel van Baak [Wed, 21 Jan 2009 22:04:16 +0000 (22:04 +0000)]
remove duplicated sentence.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@169793 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoFurther fix some oddities in sip show users and sip show peers logic
Mark Michelson [Wed, 21 Jan 2009 21:53:55 +0000 (21:53 +0000)]
Further fix some oddities in sip show users and sip show peers logic

ccesario on IRC pointed out that his sip peers were not displayed
properly when he would issue the command "sip show peers." The problem
was that the onlymatchonip field was used to determine if the endpoint
was a "peer" or "user." The tricky part is that a "friend" is supposed
to be treated as both a "user" and a "peer" but the logic would not allow
"friends" to show up as "peers" since onlymatchonip was set to FALSE
for friends.

I have modified the sip_peer structure to more explicitly keep track of
what type endpoint it is so that the various manager and CLI commands
will display the expected information

Reported by ccesario via IRC
Tested by ccesario

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@169791 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 169722 via svnmerge from
Tilghman Lesher [Wed, 21 Jan 2009 21:03:40 +0000 (21:03 +0000)]
Merged revisions 169722 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r169722 | tilghman | 2009-01-21 15:02:32 -0600 (Wed, 21 Jan 2009) | 8 lines

  Extra NULLs in the output cause some terminal types to abort in the middle of
  a color code, causing terminal weirdness.
  (closes issue #14130)
   Reported by: coolmig
   Patches:
         20090121__bug14130.diff.txt uploaded by Corydon76 (license 14)
   Tested by: Corydon76, coolmig
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@169723 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoThis patch corrects a segfault reported in 14289,
Steve Murphy [Wed, 21 Jan 2009 17:21:40 +0000 (17:21 +0000)]
This patch corrects a segfault reported in 14289,
due to a null ptr being refd.

Yes, seanbright is right in the bug comments, that is the fix.
Sorry for this oversight; I guess my personal
usage didn't have this happen!

murf

(closes issue #14289)
Reported by: jamesgolovich

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@169673 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoRemove properties that erroneously got merged into trunk
Russell Bryant [Wed, 21 Jan 2009 10:49:00 +0000 (10:49 +0000)]
Remove properties that erroneously got merged into trunk

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@169625 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoFix a regression in TCP support.
Russell Bryant [Wed, 21 Jan 2009 10:26:07 +0000 (10:26 +0000)]
Fix a regression in TCP support.

This patch fixes a problem that caused chan_sip to think that every open TCP session
was to a remote address of 0.0.0.0:0.

(closes issue #14287)
Reported by: jamesgolovich
Patches:
      bug-14287.diff.txt uploaded by jamesgolovich (license 176)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@169620 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoBlocked revisions 169581 via svnmerge
Terry Wilson [Wed, 21 Jan 2009 00:40:55 +0000 (00:40 +0000)]
Blocked revisions 169581 via svnmerge

........
  r169581 | twilson | 2009-01-20 17:49:34 -0600 (Tue, 20 Jan 2009) | 2 lines

  One-touch parking was calling back the wrong channel on timeout
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@169614 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoFix device state parsing issues for channel names with multiple slashes
Mark Michelson [Wed, 21 Jan 2009 00:33:32 +0000 (00:33 +0000)]
Fix device state parsing issues for channel names with multiple slashes

The fix being applied is a bit different for trunk and the 1.6.X branches.
For trunk, we only wish to strip off the characters beyond the second slash
if the channel is a Local channel (i.e. we are removing the /n from the device
name). Other channel technologies with multiple slashes (e.g. DAHDI) need the
information after the second slash in order to get the proper device state
information.

In addition to this fix, the 1.6.X branches are receiving a much more important
fix as well. The problem in 1.6.X is that the member's device name was being directly
changed instead of having a copy changed. This meant that we would strip off the
second slash and trailing characters and then leave the member's device name like
that permanently thereafter.

(closes issue #14014)
Reported by: kebl0155
Patches:
      14014_number2.patch uploaded by putnopvut (license 60)
Tested by: kebl0155

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@169611 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoUse the default timeout for a queue instead of -1
Mark Michelson [Tue, 20 Jan 2009 21:57:24 +0000 (21:57 +0000)]
Use the default timeout for a queue instead of -1

(closes issue #14272)
Reported by: timking

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@169574 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoConvert the character pointers in a sip_request to be pointer offsets
Mark Michelson [Tue, 20 Jan 2009 20:10:31 +0000 (20:10 +0000)]
Convert the character pointers in a sip_request to be pointer offsets

When an ast_str expands to hold more data, any pointers that were pointing
to the data prior to the expansion will be pointing at invalid memory. This
change makes such pointers used in chan_sip.c instead be offsets from the
beginning of the string so that the same math may be applied no matter where
in memory the string resides.

To help ease this transition, a macro called REQ_OFFSET_TO_STR has been added
to chan_sip.c so that given a sip_request and an offset, the string at that
offset is returned.

(closes issue #14220)
Reported by: riksta
Tested by: putnopvut

Review http://reviewboard.digium.com/r/126/

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@169557 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMake a proper builtin attended transfer to parking work
Terry Wilson [Tue, 20 Jan 2009 19:22:24 +0000 (19:22 +0000)]
Make a proper builtin attended transfer to parking work

This is an ugly hack from 1.4 that allows the timeout callback from a parked
call to use the right channel name for the callback when the park is done with
a builtin attended transfer (that isn't completed early).  This hasn't ever
worked in trunk and no one has complained yet, so eh.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@169510 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 169485 via svnmerge from
Terry Wilson [Tue, 20 Jan 2009 18:48:14 +0000 (18:48 +0000)]
Merged revisions 169485 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r169485 | twilson | 2009-01-20 12:40:56 -0600 (Tue, 20 Jan 2009) | 6 lines

  Don't play audio to the channel if we've masqueraded

  (closes issue #14066)
  Reported by: bluefox
  Tested by: otherwiseguy, bluefox
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@169486 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoast_str_SQLGetData is *not* part of the ast_str API, it's part of the ast_odbc API...
Kevin P. Fleming [Mon, 19 Jan 2009 21:42:46 +0000 (21:42 +0000)]
ast_str_SQLGetData is *not* part of the ast_str API, it's part of the ast_odbc API and just happens to use an ast_str as the buffer; move all of it to res_odbc.c and res_odbc.h, renaming appropriately

along the way fix some minor coding style issues in strings.h and add some attribute_pure annotations to functions in the ast_str API

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@169438 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agofix assignment in swapmode plug.
Michiel van Baak [Mon, 19 Jan 2009 20:14:27 +0000 (20:14 +0000)]
fix assignment in swapmode plug.
Spotted and fix provided by ys

(closes issue #14129)
Reported by: ys
Tested by: ys

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@169369 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoRedo the event-based MWI in chan_skinny.
Michiel van Baak [Mon, 19 Jan 2009 20:09:11 +0000 (20:09 +0000)]
Redo the event-based MWI in chan_skinny.

Dan saw regular segfaults with the old implementation and
rewrote it to make it really eventbased.
I altered it to be trunk compatible and wedhorn gave some feedback
and ideas how to make it even better.

(closes issue #13821)
Reported by: DEA
Patches:
      chan_skinny-mwi-events.txt uploaded by DEA (license 3)
Tested by: mvanbaak, DEA

"no probs by me" from wedhorn

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@169367 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 169364 via svnmerge from
Tilghman Lesher [Mon, 19 Jan 2009 20:05:52 +0000 (20:05 +0000)]
Merged revisions 169364 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r169364 | tilghman | 2009-01-19 13:49:25 -0600 (Mon, 19 Jan 2009) | 4 lines

  Truncate userevents at the end of a line, when the command exceeds the buffer.
  (closes issue #14278)
   Reported by: fnordian
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@169365 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMake asterisk compile on non-amd64 versions of OpenBSD.
Michiel van Baak [Mon, 19 Jan 2009 18:36:24 +0000 (18:36 +0000)]
Make asterisk compile on non-amd64 versions of OpenBSD.

The HW_PHYSMEM64 is only available in latest OpenBSD and/or amd64 versions of OpenBSD.
Use HW_PHYSMEM when HW_PHYSMEM64 is not available.

(closes issue #14129)
Reported by: ys
Patches:
      2009011600_physmem64.diff.txt uploaded by mvanbaak (license 7)
Tested by: mvanbaak, jtodd

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@169327 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoGet rid of magic number and replace with DAHDI_VMWI_NUMBER_MASK when
Doug Bailey [Mon, 19 Jan 2009 18:22:44 +0000 (18:22 +0000)]
Get rid of magic number and replace with DAHDI_VMWI_NUMBER_MASK when
determining the number of messages pending for MWI call

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@169325 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoAdd enhanced MWI generation to take advantage of new dahdi line reversal MWI ability.
Doug Bailey [Mon, 19 Jan 2009 16:33:41 +0000 (16:33 +0000)]
Add enhanced MWI generation to take advantage of new dahdi line reversal MWI ability.

(closes issue #14104)
Reported by: alecdavis
Patches:
      asttrunk-14104.diff2.txt uploaded by dbailey (license )
      chan_dahdi.rpas_and_fsk.diff.txt uploaded by alecdavis (license 585)
Tested by: alecdavis, dbailey

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@169277 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 169210 via svnmerge from
Mark Michelson [Mon, 19 Jan 2009 15:54:06 +0000 (15:54 +0000)]
Merged revisions 169210 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r169210 | mmichelson | 2009-01-19 09:52:15 -0600 (Mon, 19 Jan 2009) | 13 lines

Prevent a crash in chan_local due to a potential NULL pointer dereference

Move the check for if both channels on a local_pvt have generators to below
where p->chan is checked for NULLity (NULLness?). This prevents a crash from
occurring if p->chan is NULL.

(closes issue #14189)
Reported by: sascha
Patches:
      14189.patch uploaded by putnopvut (license 60)
Tested by: sascha

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@169211 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoAdd discriminator for when ring pulse alert signal is used to preface MWI spills
Doug Bailey [Sat, 17 Jan 2009 18:26:44 +0000 (18:26 +0000)]
Add discriminator for when ring pulse alert signal is used to preface MWI spills
This prevents the situation when MWI messages are added to caller ID spills causing the channel to be hung up

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@169153 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoChange intializer types. Found while working on asterisk-cpp. I have a new
Sean Bright [Sat, 17 Jan 2009 02:52:30 +0000 (02:52 +0000)]
Change intializer types.  Found while working on asterisk-cpp.  I have a new
favorite error message from g++:

    pbx_dundi.c:4580: sorry, unimplemented: non-trivial designated
                      initializers not supported

I like it when compilers are apologetic.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@169116 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoFix qualify for TCP peer
Terry Wilson [Sat, 17 Jan 2009 01:56:36 +0000 (01:56 +0000)]
Fix qualify for TCP peer

(closes issue #14192)
Reported by: pabelanger
Patches:
      asterisk-bug14192.diff.txt uploaded by jamesgolovich (license 176)
Tested by: jamesgolovich

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@169080 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoFix port :0 added to SIP INVITE URI when outboundproxy used
Terry Wilson [Sat, 17 Jan 2009 00:03:39 +0000 (00:03 +0000)]
Fix port :0 added to SIP INVITE URI when outboundproxy used

(closes issue #14233)
Reported by: chris-mac
Patches:
      asterisk-bug14233.diff.txt uploaded by jamesgolovich (license 176)
Tested by: jamesgolovich, chris-mac, otherwiseguy

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@169044 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 168975 via svnmerge from
Mark Michelson [Fri, 16 Jan 2009 22:43:09 +0000 (22:43 +0000)]
Merged revisions 168975 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r168975 | mmichelson | 2009-01-16 16:42:13 -0600 (Fri, 16 Jan 2009) | 18 lines

Account for possible NULL pointer when we receive a 408 in response to a REGISTER

It may be that by the time we receive a reply to a REGISTER request, the attempt has
timed out and thus the registry structure pointed to by the corresponding sip_pvt has
gone away. This situation was handled properly for a 200 OK response, but the 408
case assumed that the sip_registry struct was non-NULL, thus potentially causing a crash

This commit fixes this assumption and prints out a message to the console if we should
receive a late 408 response to a REGISTER

(closes issue #14211)
Reported by: aborghi
Patches:
      14211.diff uploaded by putnopvut (license 60)
Tested by: aborghi

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@168976 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 168716 via svnmerge from
Terry Wilson [Fri, 16 Jan 2009 22:16:23 +0000 (22:16 +0000)]
Merged revisions 168716 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r168716 | twilson | 2009-01-15 12:22:49 -0600 (Thu, 15 Jan 2009) | 12 lines

  Convert call to park_call_full to masq_park_call_announce

  Since we removed the AST_PBX_KEEPALIVE return value, we need to use masqueraded
  parking, otherwise we will try to call ast_hangup() in __pbx_run() and in
  do_parking_thread() and then promptly crash.
  (closes issue #14215)
   Reported by: waverly360
   Tested by: otherwiseguy
  (closes issue #14228)
   Reported by: kobaz
   Tested by: otherwiseguy
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@168941 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoFix a logic error that occur when using the timerfd interface
Mark Michelson [Fri, 16 Jan 2009 19:54:39 +0000 (19:54 +0000)]
Fix a logic error that occur when using the timerfd interface

This sequence of events posed a problem

timerfd_timer_open
timerfd_timer_enable_continuous
timerfd_timer_set_rate
timerfd_timer_disable_continuous

The reason was that the timing module was written under the assumption
that timerfd_timer_set_rate would not be called between enabling and
disabling continuous mode. What happened in this situation was that
timerfd_timer_enable_continuous saved off our previously set timer (in this
situation a 0 timer, meaning it never runs out). Then timerfd_timer_disable_continuous
would restore this 0 timer, even though it logically should set the timer to be whatever
was set in timerfd_timer_set_rate.

Now the behavior in timerfd_timer_set_rate is to overwrite the saved timer that may
or may not have been set in timerfd_timer_enable_continuous. Even if
timerfd_timer_enable_continuous has not been previously called, this will not harm the
operation.

Thanks to Terry Wilson for discovering the problem and giving me a really great debug
capture that pointed out the problem clearly

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@168898 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 168828 via svnmerge from
Tilghman Lesher [Fri, 16 Jan 2009 18:49:09 +0000 (18:49 +0000)]
Merged revisions 168828 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r168828 | tilghman | 2009-01-16 12:41:35 -0600 (Fri, 16 Jan 2009) | 6 lines

  Fix the conjugation of Russian and Ukrainian languages.
  (related to issue #12475)
   Reported by: chappell
   Patches:
         vm_multilang.patch uploaded by chappell (license 8)
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@168832 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoFix a spelling mistake.
Russell Bryant [Fri, 16 Jan 2009 17:09:13 +0000 (17:09 +0000)]
Fix a spelling mistake.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@168760 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agobuild in dev mode
Russell Bryant [Fri, 16 Jan 2009 16:18:41 +0000 (16:18 +0000)]
build in dev mode

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@168759 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 168745 via svnmerge from
Steve Murphy [Fri, 16 Jan 2009 00:34:31 +0000 (00:34 +0000)]
Merged revisions 168745 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r168745 | murf | 2009-01-15 17:19:12 -0700 (Thu, 15 Jan 2009) | 14 lines

  This patch fixes a problem where a goto (or jump, in this case)
  fails a consistency check because it can't find a matching
  extension. The problem was a missing instruction to end
  the range notation in the code where it converts the pattern
  into a regex and uses the regex code to determine the match.

  I tested using the AEL code the user supplied, and now,
  the consistency check passes.

  (closes issue #14141)
  Reported by: dimas
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@168746 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoThis patch allows null args in ast_expr2 func calls, and fixes commas being converted...
Steve Murphy [Thu, 15 Jan 2009 20:54:59 +0000 (20:54 +0000)]
This patch allows null args in ast_expr2 func calls, and fixes commas being converted to pipes, which was 1.4 type stuff.

If the user says count=ENUMLOOKUP(${EXTEN},ALL,c,,enum.mydomain.tld);

then it won't complain about the empty arg (c,,...) and fabled's patch
won't let it swap the commas for pipes.

Ran it thru my dialplan and no complaints.

(closes issue #14169)
Reported by: fabled
Patches:
      function-argument-separator-fix.diff uploaded by fabled (license 448)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@168737 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoremove the PBX_ODBC logic from the configure script, and add GENERIC_ODCB logic that...
Kevin P. Fleming [Thu, 15 Jan 2009 20:18:53 +0000 (20:18 +0000)]
remove the PBX_ODBC logic from the configure script, and add GENERIC_ODCB logic that includes copying the relevant LIB and INCLUDE data from either UnixODBC or iODBC, based on which was found; if both were found, prefer UnixODBC

this stops modules from being linked against both sets of libraries on systems that have both installed

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@168734 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoAdd missing brace
Mark Michelson [Thu, 15 Jan 2009 20:00:46 +0000 (20:00 +0000)]
Add missing brace

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@168732 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoFix the compactheaders option in sip.conf
Mark Michelson [Thu, 15 Jan 2009 19:16:29 +0000 (19:16 +0000)]
Fix the compactheaders option in sip.conf

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@168728 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoRemove an unneeded condition for line addition to a SIP request/response
Mark Michelson [Thu, 15 Jan 2009 19:00:06 +0000 (19:00 +0000)]
Remove an unneeded condition for line addition to a SIP request/response

In Asterisk 1.4 and 1.6.0, the sip_request structure had a statically
allocated buffer to hold the text of the request. There was a check in the
add_line function to not attempt to write the line into the buffer if we
did not have room for it.

In trunk and Asterisk versions starting with 1.6.1, an expandable ast_str
structure is used to hold the text. Since it may grow to fit an arbitrarily
sized string, this check in add_line is no longer valid.

I found this oddity while attempting to fix issue #14220; however, I do not
believe that this is the fix for that issue since the output supplied by the
reporter did not contain the warning message that would be printed had this
condition been satisfied.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@168725 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 168721 via svnmerge from
Olle Johansson [Thu, 15 Jan 2009 18:47:14 +0000 (18:47 +0000)]
Merged revisions 168721 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r168721 | oej | 2009-01-15 19:43:43 +0100 (Tor, 15 Jan 2009) | 2 lines

Meetme actually has realtime but wasn't documented

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@168722 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoResolve issue with negative vs non-negative length parameters.
Tilghman Lesher [Thu, 15 Jan 2009 18:39:56 +0000 (18:39 +0000)]
Resolve issue with negative vs non-negative length parameters.
(closes issue #14245)
 Reported by: dveiga

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@168719 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMake sure that we have the same terminology in sip.conf.sample and the source code...
Olle Johansson [Thu, 15 Jan 2009 18:08:59 +0000 (18:08 +0000)]
Make sure that we have the same terminology in sip.conf.sample and the source code warning.
Thanks Nick Lewis for pointing this out in the bug tracker.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@168712 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoClarify some misunderstandings and make it even more clear that you can refer to...
Olle Johansson [Thu, 15 Jan 2009 17:55:53 +0000 (17:55 +0000)]
Clarify some misunderstandings and make it even more clear that you can refer to a peer
in the register= line.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@168711 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoAdd a missing unlock and properly handle the 'maxusers' setting on MeetMe
Sean Bright [Thu, 15 Jan 2009 15:33:18 +0000 (15:33 +0000)]
Add a missing unlock and properly handle the 'maxusers' setting on MeetMe
conferences.  We were using the 'user number' field to compare against the
maximum allowed users, which works assuming users with lower user numbers
didn't leave the conference.

(closes issue #14117)
Reported by: sergedevorop
Patches:
      20090114__bug14117-2.diff.txt uploaded by seanbright (license 71)
Tested by: sergedevorop

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@168705 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoRelated to issue #14246
Olle Johansson [Thu, 15 Jan 2009 13:37:46 +0000 (13:37 +0000)]
Related to issue #14246
Update changes for SIPRemoveHeader()

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@168639 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoAdd capability to remove added SIP headers *before* INVITE is generated.
Olle Johansson [Thu, 15 Jan 2009 13:35:50 +0000 (13:35 +0000)]
Add capability to remove added SIP headers *before* INVITE is generated.

(closes issue #14246)
Reported by: klaus3000
Patches:
      2patch_chan_sip_SIPRemoveHeader_trunk.txt uploaded by klaus3000 (license 65)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@168638 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoAdd support for setting the Reason header when cancelling a call in the queue
Olle Johansson [Thu, 15 Jan 2009 13:01:52 +0000 (13:01 +0000)]
Add support for setting the Reason header when cancelling a call in the queue
because someone else answered. Previously, only dial() was supported.

EDV-102

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@168636 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 168628 via svnmerge from
Mark Michelson [Thu, 15 Jan 2009 00:14:17 +0000 (00:14 +0000)]
Merged revisions 168628 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r168628 | mmichelson | 2009-01-14 18:11:01 -0600 (Wed, 14 Jan 2009) | 16 lines

Fix some crashes from bad datastore handling in app_queue.c

* The queue_transfer_fixup function was searching for and removing
  the datastore from the incorrect channel, so this was fixed.

* Most datastore operations regarding the queue_transfer datastore
  were being done without the channel locked, so proper channel locking
  was added, too.

(closes issue #14086)
Reported by: ZX81
Patches:
      14086v2.patch uploaded by putnopvut (license 60)
Tested by: ZX81, festr

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@168629 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoDon't crash when typing 'core set verbose' or 'core set debug' by themselves.
Sean Bright [Wed, 14 Jan 2009 23:10:48 +0000 (23:10 +0000)]
Don't crash when typing 'core set verbose' or 'core set debug' by themselves.

(closes issue #14219)
Reported by: jamesgolovich
Patches:
      asterisk-setverbosecrash.diff.txt uploaded by jamesgolovich (license 176)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@168626 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 168622 via svnmerge from
Richard Mudgett [Wed, 14 Jan 2009 21:51:06 +0000 (21:51 +0000)]
Merged revisions 168622 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r168622 | rmudgett | 2009-01-14 15:48:22 -0600 (Wed, 14 Jan 2009) | 4 lines

  *  Fixed create_process() allocation of process ID values.
  The allocated process IDs could overflow their respective
  NT and TE fields.  Affects outgoing calls.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@168623 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoThis fixes a problem where MWI FSK spills were being injected onto off hook fxs lines.
Doug Bailey [Wed, 14 Jan 2009 21:19:45 +0000 (21:19 +0000)]
This fixes a problem where MWI FSK spills were being injected onto off hook fxs lines.
(closes issue #14143)
Reported by: alecdavis
Patches:
      chan_dahdi-14143.patch.txt uploaded by dbailey (license )
Tested by: alecdavis

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@168619 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 168614 via svnmerge from
Sean Bright [Wed, 14 Jan 2009 20:58:26 +0000 (20:58 +0000)]
Merged revisions 168614 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r168614 | seanbright | 2009-01-14 15:52:00 -0500 (Wed, 14 Jan 2009) | 9 lines

  Update autosupport script to supply info for both Zaptel and DAHDI in 1.4 and
  be sure to run dahdi_test in 1.6.x and trunk instead of zttest.

  (closes issue #14132)
  Reported by: dsedivec
  Patches:
        asterisk-1.4-autosupport.patch uploaded by dsedivec (license 638)
        asterisk-trunk-autosupport.patch uploaded by dsedivec (license 638)
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@168615 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 168608 via svnmerge from
Steve Murphy [Wed, 14 Jan 2009 20:51:26 +0000 (20:51 +0000)]
Merged revisions 168608 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r168608 | murf | 2009-01-14 12:34:35 -0700 (Wed, 14 Jan 2009) | 1 line

  app_page was failing to compile in dev-mode on my gcc-4.2.4 system. This change gets rid of the warning.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@168613 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoRestore the "sip show users" and "sip show user" CLI commands
Mark Michelson [Wed, 14 Jan 2009 20:13:48 +0000 (20:13 +0000)]
Restore the "sip show users" and "sip show user" CLI commands

(closes issue #14180)
Reported by: amorsen
Patches:
      sip_show_users_161v3.diff uploaded by putnopvut (license 60)
Tested by: blitzrage, amorsen

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@168610 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoFix compilation on FreeBSD and OSX
Michiel van Baak [Wed, 14 Jan 2009 19:36:57 +0000 (19:36 +0000)]
Fix compilation on FreeBSD and OSX

This started as work to fix the 'core show sysinfo'
CLI command but while working on it oej
pointed out that read_credentials did not compile neither.
So while being there, fix that as well.

Thanks for all the testing oej!

(closes issue #14129)
Reported by: ys
Tested by: oej, mvanbaak

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@168609 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 168603 via svnmerge from
Tilghman Lesher [Wed, 14 Jan 2009 19:11:14 +0000 (19:11 +0000)]
Merged revisions 168603 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r168603 | tilghman | 2009-01-14 13:02:55 -0600 (Wed, 14 Jan 2009) | 7 lines

  Don't read into a buffer without first checking if a value is beyond the end.
  (closes issue #13600)
   Reported by: atis
   Patches:
         20090106__bug13600.diff.txt uploaded by Corydon76 (license 14)
   Tested by: atis
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@168604 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMostly spacing changes; no functionality change at all.
Tilghman Lesher [Wed, 14 Jan 2009 18:27:57 +0000 (18:27 +0000)]
Mostly spacing changes; no functionality change at all.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@168601 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoBlocked revisions 168598 via svnmerge
Mark Michelson [Wed, 14 Jan 2009 16:20:37 +0000 (16:20 +0000)]
Blocked revisions 168598 via svnmerge

........
r168598 | mmichelson | 2009-01-14 10:19:26 -0600 (Wed, 14 Jan 2009) | 8 lines

Fix a logic error I found while searching through chan_agent.c

I found that the allow_multiple_logins function would never return
0 due to an incorrect comparison being used when traversing the
list of agents. While I was modifying this function, I also did
a little bit of coding guidelines cleanup, too.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@168599 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 168593 via svnmerge from
Terry Wilson [Wed, 14 Jan 2009 02:00:40 +0000 (02:00 +0000)]
Merged revisions 168593 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r168593 | twilson | 2009-01-13 19:27:18 -0600 (Tue, 13 Jan 2009) | 20 lines

  Don't overflow when paging more than 128 extensions

  The number of available slots for calls in app_page was hardcoded to 128.
  Proper bounds checking was not in place to enforce this limit, so if more than
  128 extensions were passed to the Page() app, Asterisk would crash.  This patch
  instead dynamically allocates memory for the ast_dial structures and removes
  the (non-functional) arbitrary limit.

  This issue would have special importance to anyone who is dynamically creating
  the argument passed to the Page application and allowing more than 128
  extensions to be added by an outside user via some external interface.

  The patch posted by a_villacis was slightly modified for some coding guidelines
  and other cleanups.  Thanks, a_villacis!
  (closes issue #14217)
  Reported by: a_villacis
  Patches:
        20080912-asterisk-app_page-fix-buffer-overflow.patch uploaded by a (license 660)
  Tested by: otherwiseguy
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@168594 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoJanitor patch for chan_misdn (make channel variable access safe)
Tilghman Lesher [Tue, 13 Jan 2009 23:57:46 +0000 (23:57 +0000)]
Janitor patch for chan_misdn (make channel variable access safe)
(closes issue #12887)
 Reported by: pputman
 Patches:
       chan_misdn_threadsafe.patch uploaded by pputman (license 81)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@168591 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoFully overwrite a same-named file when uploading
Terry Wilson [Tue, 13 Jan 2009 23:05:43 +0000 (23:05 +0000)]
Fully overwrite a same-named file when uploading

(closes issue #14190)
Reported by: timking

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@168588 65c4cc65-6c06-0410-ace0-fbb531ad65f3