asterisk/asterisk.git
9 years agoexpand code based appreviation of AST_CONFIG_DIR to configuration directory
Jeff Peeler [Wed, 27 Jan 2010 20:06:08 +0000 (20:06 +0000)]
expand code based appreviation of AST_CONFIG_DIR to configuration directory

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@243652 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 243570 via svnmerge from
Jeff Peeler [Wed, 27 Jan 2010 18:49:52 +0000 (18:49 +0000)]
Merged revisions 243570 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r243570 | jpeeler | 2010-01-27 12:47:34 -0600 (Wed, 27 Jan 2010) | 9 lines

  Extend announcement URL used with Queue from 80 chars to PATH_MAX.

  (closes issue #16488)
  Reported by: syspert
  Patches:
        soundfilelen.pacth-2 uploaded by syspert (license 938)

  Review: https://reviewboard.asterisk.org/r/475/
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@243571 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoAdd new option to asterisk.conf (lockconfdir) to protect conf dir during reloads
Jeff Peeler [Wed, 27 Jan 2010 18:29:49 +0000 (18:29 +0000)]
Add new option to asterisk.conf (lockconfdir) to protect conf dir during reloads

(closes issue #16358)
Reported by: raarts
Patches:
      lockconfdir.diff uploaded by raarts (license 937)
      modified by me

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@243551 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 243486 via svnmerge from
Mark Michelson [Wed, 27 Jan 2010 18:08:02 +0000 (18:08 +0000)]
Merged revisions 243486 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r243486 | mmichelson | 2010-01-27 12:06:43 -0600 (Wed, 27 Jan 2010) | 3 lines

  Use a safe list traversal while checking for duplicate vars in pbx_builtin_setvar_helper.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@243487 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoFix the ability to specify an OSP token for an outbound IAX2 call.
Russell Bryant [Wed, 27 Jan 2010 17:32:07 +0000 (17:32 +0000)]
Fix the ability to specify an OSP token for an outbound IAX2 call.

When this patch was originally submitted, the code allowed for the token to be
set via a channel variable.  I decided that a cleaner approach would be to
integrate it into the CHANNEL() function.  Unfortunately, that is not a suitable
approach.  It's not possible to get the value set on the channel soon enough
using that method.  So, go back to the simple channel variable method.

(closes issue #16711)
Reported by: homesick
Patches:
      iax-svn.diff uploaded by homesick (license 91)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@243482 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 243390 via svnmerge from
David Vossel [Tue, 26 Jan 2010 23:56:57 +0000 (23:56 +0000)]
Merged revisions 243390 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r243390 | dvossel | 2010-01-26 17:55:49 -0600 (Tue, 26 Jan 2010) | 9 lines

  fixes bug with channel receiving wrong privileges after call parking

  (closes issue #16429)
  Reported by: Yasuhiro Konishi
  Patches:
        features.c.diff uploaded by Yasuhiro Konishi (license 947)
  Tested by: dvossel
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@243391 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoCode clean up in app_senddtmf
David Ruggles [Tue, 26 Jan 2010 20:49:57 +0000 (20:49 +0000)]
Code clean up in app_senddtmf

Pushes code clean up done in app_externalivr back
into app_senddtmf

Review: https://reviewboard.asterisk.org/r/473/

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@243346 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 243258 via svnmerge from
Jeff Peeler [Tue, 26 Jan 2010 18:20:55 +0000 (18:20 +0000)]
Merged revisions 243258 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r243258 | jpeeler | 2010-01-26 12:19:10 -0600 (Tue, 26 Jan 2010) | 2 lines

  Remove unnecessary code in ast_read as issue 16058 has been fully solved now.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@243266 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoFix crash resulting from frames with invalid data pointers.
Jeff Peeler [Tue, 26 Jan 2010 18:07:57 +0000 (18:07 +0000)]
Fix crash resulting from frames with invalid data pointers.

In ast_frdup the frame data union does not get set to point to malloced memory
if the datalen is zero, so make sure to handle the same case in ast_frisolate
appropriately.

(closes issue #16058)
Reported by: atis
Patches:
      bug16058-fix.patch uploaded by jpeeler (license 325)
Tested by: atis

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@243244 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agomodify 'test show registered' cli output format
David Vossel [Tue, 26 Jan 2010 17:40:02 +0000 (17:40 +0000)]
modify 'test show registered' cli output format

In order to improve readability, the output from 'test show
registered' has been modified to truncate fields to fit within
the format output if they are over a certain length.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@243242 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoRFC compliant uri and display-name encode/decode
David Vossel [Tue, 26 Jan 2010 16:30:08 +0000 (16:30 +0000)]
RFC compliant uri and display-name encode/decode

1.  URI Encoding
This patch changes ast_uri_encode()'s behavior when doreserved is enabled.
Previously when doreserved was enabled only a small set of reserved
characters were encoded.  This set was comprised primarily of the reserved
characters defined in RFC3261 section 25.1, but contained other characters as
well.  Rather than only escaping the reserved set, doreserved now escapes
all characters not within the unreserved set as defined by RFC 3261 and
RFC 2396.  Also, the 'doreserved' variable has been renamed to 'do_special_char'
in attempts to avoid confusion.

When doreserve is not enabled, the previous logic of only encoding the
characters <= 0X1F and > 0X7f remains, except for the '%' character, which
must always be encoded as it signifies a HEX escaped character during the decode
process.

2. URI Decoding: Break up URI before decode.
In chan_sip.c ast_uri_decode is called on the entire URI instead of it's
individual parts after it is parsed.  This is not good as ast_uri_decode
can introduce special characters back into the URI which can mess up parsing.
This patch resolves this by not decoding a URI until parsing is completely
done.  There are many instances where we check to see if pedantic checking
is enabled before we decode a URI.  In these cases a new macro,
SIP_PEDANTIC_DECODE, is used on the individual parsed segments of the URI
rather than constantly putting if (pedantic) { decode() } checks everywhere
in the code.  In the areas where ast_uri_decode is not dependent upon
pedantic checking this macro is not used, but decoding is still moved to
each individual part of the URI.  The only behavior that should change from
this patch is the time at which decoding occurs.

Since I had to look over every place URI parsing occurs to create this
patch, I found several places where we use duplicate code for parsing.
To consolidate the code, those areas have updated to use the parse_uri()
function where possible.

3. SIP display-name decoding according to RFC3261 section 25.
To properly decode the display-name portion of a FROM header, chan_sip's
get_calleridname() function required a complete re-write.  More information
about this change can be found in the comments at the beginning of this function.

4. Unit Tests.
Unit tests for ast_uri_encode, ast_uri_decode, and get_calleridname() have been
written.  This involved the addition of the test_utils.c file for testing the
utils api.

(closes issue #16299)
Reported by: wdoekes
Patches:
      astsvn-16299-get_calleridname.diff uploaded by wdoekes (license 717)
      get_calleridname_rewrite.diff uploaded by dvossel (license 671)
Tested by: wdoekes, dvossel, Nick_Lewis

Review: https://reviewboard.asterisk.org/r/469/

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@243200 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoLog the variable name being tested.
Russell Bryant [Tue, 26 Jan 2010 15:46:53 +0000 (15:46 +0000)]
Log the variable name being tested.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@243158 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoUpdate test_substitution to show failures in the test log.
Russell Bryant [Tue, 26 Jan 2010 15:35:40 +0000 (15:35 +0000)]
Update test_substitution to show failures in the test log.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@243157 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoUpdate func_aes to its pre-ast_str_substitution state.
Russell Bryant [Tue, 26 Jan 2010 15:16:59 +0000 (15:16 +0000)]
Update func_aes to its pre-ast_str_substitution state.

This change makes the AES tests in test_substitution.c pass.  We still need to
work through what's going wrong in the ast_str version.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@243118 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoFixing last errors in the conversion, though it appears that the AES_* functions...
Tilghman Lesher [Tue, 26 Jan 2010 01:56:24 +0000 (01:56 +0000)]
Fixing last errors in the conversion, though it appears that the AES_* functions are still broken.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@243077 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoUsing a dummy channel causes CDR() testing to fail.
Tilghman Lesher [Tue, 26 Jan 2010 01:41:47 +0000 (01:41 +0000)]
Using a dummy channel causes CDR() testing to fail.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@243076 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoWish I had gotten to the review before this got submitted, because there's failures...
Tilghman Lesher [Tue, 26 Jan 2010 01:35:19 +0000 (01:35 +0000)]
Wish I had gotten to the review before this got submitted, because there's failures we need to address.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@243075 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 242969 via svnmerge from
Tilghman Lesher [Mon, 25 Jan 2010 21:51:41 +0000 (21:51 +0000)]
Merged revisions 242969 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r242969 | tilghman | 2010-01-25 15:50:22 -0600 (Mon, 25 Jan 2010) | 2 lines

  Err, and use the new menuselect define, too.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@242971 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 242966 via svnmerge from
Tilghman Lesher [Mon, 25 Jan 2010 21:38:33 +0000 (21:38 +0000)]
Merged revisions 242966 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r242966 | tilghman | 2010-01-25 15:36:33 -0600 (Mon, 25 Jan 2010) | 2 lines

  Only rebuild parsers by an option in menuselect
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@242967 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMake unit test modules depend on TEST_FRAMEWORK instead of off by default.
Russell Bryant [Mon, 25 Jan 2010 21:32:38 +0000 (21:32 +0000)]
Make unit test modules depend on TEST_FRAMEWORK instead of off by default.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@242965 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoConvert test_substitution module to the unit test API.
Russell Bryant [Mon, 25 Jan 2010 21:25:23 +0000 (21:25 +0000)]
Convert test_substitution module to the unit test API.

Review: https://reviewboard.asterisk.org/r/474/

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@242954 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agosmall corrections in call clearing
Alexandr Anikin [Mon, 25 Jan 2010 21:20:02 +0000 (21:20 +0000)]
small corrections in call clearing

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@242933 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoChange api for pbx_builtin_setvar to actually return error code if a function can...
Olle Johansson [Mon, 25 Jan 2010 21:13:20 +0000 (21:13 +0000)]
Change api for pbx_builtin_setvar to actually return error code if a function can't be written to.

This patch removes code that was duplicated from pbx.c to manager.c
in order to prevent API change in released versions of Asterisk.

There are propably also other places that would benefit from reading the
return code and react if a function returns error codes on writing a value into it.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@242919 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 242850 via svnmerge from
Olle Johansson [Mon, 25 Jan 2010 20:27:59 +0000 (20:27 +0000)]
Merged revisions 242850 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r242850 | oej | 2010-01-25 21:03:38 +0100 (Mån, 25 Jan 2010) | 2 lines

Report error when writing to functions returns error in AMI setvar action

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@242904 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 242852 via svnmerge from
Tilghman Lesher [Mon, 25 Jan 2010 20:18:15 +0000 (20:18 +0000)]
Merged revisions 242852 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r242852 | tilghman | 2010-01-25 14:15:45 -0600 (Mon, 25 Jan 2010) | 2 lines

  Restore FreeBSD to able-to-compile-ish-mode
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@242857 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoFix INTERNAL_OBJ error on stop when calendars.conf missing
Terry Wilson [Mon, 25 Jan 2010 18:01:08 +0000 (18:01 +0000)]
Fix INTERNAL_OBJ error on stop when calendars.conf missing

Initialize the calendars container before calling load_config and return FAILURE
on allocation failure. Also, use the AST_MODULE_LOAD_* values for return values.
Thanks to rmudgett for pointing out the error and the need to use the defined
values for return

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@242812 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 242728 via svnmerge from
Tilghman Lesher [Mon, 25 Jan 2010 05:45:00 +0000 (05:45 +0000)]
Merged revisions 242728 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r242728 | tilghman | 2010-01-24 23:42:22 -0600 (Sun, 24 Jan 2010) | 2 lines

  Buildbot pointed out an error (thanks, buildbot!)
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@242729 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 242723 via svnmerge from
Tilghman Lesher [Mon, 25 Jan 2010 05:34:33 +0000 (05:34 +0000)]
Merged revisions 242723 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r242723 | tilghman | 2010-01-24 23:33:37 -0600 (Sun, 24 Jan 2010) | 2 lines

  Oops, should have used CMD_PREFIX, not ECHO_PREFIX, for the commands.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@242724 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 242683 via svnmerge from
Tilghman Lesher [Mon, 25 Jan 2010 05:30:33 +0000 (05:30 +0000)]
Merged revisions 242683 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r242683 | tilghman | 2010-01-24 23:13:28 -0600 (Sun, 24 Jan 2010) | 2 lines

  Make the build of the Asterisk expression parser match that of the AEL parser.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@242719 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoAST_CONTROL_CONNECTED_LINE frame type processing added to setup DisplayIE field
Alexandr Anikin [Sun, 24 Jan 2010 22:42:11 +0000 (22:42 +0000)]
AST_CONTROL_CONNECTED_LINE frame type processing added to setup DisplayIE field
incorrect q.931 message order filtered on incoming calls (first msg must be setup,
next must be not setup)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@242645 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoInstead of crashing, allocate our header ast_str before we try to use it.
Sean Bright [Sun, 24 Jan 2010 21:49:17 +0000 (21:49 +0000)]
Instead of crashing, allocate our header ast_str before we try to use it.

(closes issue #16680)
Reported by: lmadsen
Patches:
      issue16680_20100122.patch uploaded by seanbright (license 71)
Tested by: lmadsen

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@242607 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 242520 via svnmerge from
Tilghman Lesher [Sun, 24 Jan 2010 06:40:31 +0000 (06:40 +0000)]
Merged revisions 242520 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r242520 | tilghman | 2010-01-24 00:33:01 -0600 (Sun, 24 Jan 2010) | 8 lines

  Only rebuild bison and flex source files on demand, if bison and flex are detected by the configure script.

  Changed after discussion on the -dev list about possible unnecessary build
  failures, due to checkouts/untars causing these special source files to
  possibly be newer than their resulting C files.  This should additionally
  ensure that nobody need learn about extra Makefile arguments to ensure the
  proper files get rebuilt when changes are made to these special source files.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@242521 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 242423 via svnmerge from
Tilghman Lesher [Fri, 22 Jan 2010 21:45:18 +0000 (21:45 +0000)]
Merged revisions 242423 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r242423 | tilghman | 2010-01-22 15:44:18 -0600 (Fri, 22 Jan 2010) | 7 lines

  Rebuild from flex, bison sources when necessary.

  (issue #14629)
   Reported by: Marquis
   Patches:
         20100121__issue14629.diff.txt uploaded by tilghman (license 14)
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@242424 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoAdd send DTMF feature to ExternalIVR app
David Ruggles [Fri, 22 Jan 2010 16:20:43 +0000 (16:20 +0000)]
Add send DTMF feature to ExternalIVR app

Implemented a new command 'D' that allows client
IVRs to send DTMF digits to the channel.

(closes issue #16615)
Reported by: thedavidfactor

Review: https://reviewboard.asterisk.org/r/465/

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@242357 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoThe irony of not compile-testing a test program before committing is killing me.
Tilghman Lesher [Fri, 22 Jan 2010 15:09:12 +0000 (15:09 +0000)]
The irony of not compile-testing a test program before committing is killing me.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@242317 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 242226 via svnmerge from
Olle Johansson [Fri, 22 Jan 2010 09:28:34 +0000 (09:28 +0000)]
Merged revisions 242226 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r242226 | oej | 2010-01-22 10:19:30 +0100 (Fre, 22 Jan 2010) | 3 lines

Initialize notify_types to NULL

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@242227 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoUpdate the doxygenification of some comments.
Russell Bryant [Fri, 22 Jan 2010 04:57:03 +0000 (04:57 +0000)]
Update the doxygenification of some comments.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@242186 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoConvert scheduler API entry order test to the test API.
Russell Bryant [Fri, 22 Jan 2010 04:50:38 +0000 (04:50 +0000)]
Convert scheduler API entry order test to the test API.

Review: https://reviewboard.asterisk.org/r/470/

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@242185 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoAdd test API usage example to test_skel.c.
Russell Bryant [Fri, 22 Jan 2010 04:49:26 +0000 (04:49 +0000)]
Add test API usage example to test_skel.c.

Review: https://reviewboard.asterisk.org/r/471/

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@242184 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoAdd missing argument to ast_calloc calls.
Mark Michelson [Thu, 21 Jan 2010 22:37:55 +0000 (22:37 +0000)]
Add missing argument to ast_calloc calls.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@242092 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMake sure we initialize the ast_ha structure with ast_calloc
Olle Johansson [Thu, 21 Jan 2010 21:05:56 +0000 (21:05 +0000)]
Make sure we initialize the ast_ha structure with ast_calloc

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@242043 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 241932 via svnmerge from
Sean Bright [Thu, 21 Jan 2010 15:27:42 +0000 (15:27 +0000)]
Merged revisions 241932 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r241932 | seanbright | 2010-01-21 10:25:46 -0500 (Thu, 21 Jan 2010) | 5 lines

  Fix configure check for PTHREAD_ONCE_INIT when manually adding -Wall to CFLAGS.

  (closes issue #16666)
  Reported by: romain_proformatique
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@241938 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoFormats are inconsistent between even 32-bit and 64-bit Linux. Use casts to ensure...
Tilghman Lesher [Thu, 21 Jan 2010 15:14:55 +0000 (15:14 +0000)]
Formats are inconsistent between even 32-bit and 64-bit Linux.  Use casts to ensure both compile.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@241896 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoPoint to a useful reference on the XML output format.
Russell Bryant [Thu, 21 Jan 2010 14:10:51 +0000 (14:10 +0000)]
Point to a useful reference on the XML output format.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@241856 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoModify test results XML format to match the JUnit format.
Russell Bryant [Thu, 21 Jan 2010 13:59:41 +0000 (13:59 +0000)]
Modify test results XML format to match the JUnit format.

When this code was developed, we came up with our own XML format for the test
output.  I have since started looking at integration with other tools, namely
continuous integration frameworks, and this format seems to be supported
across a number of applications.  With these changes in place, I was able
to get Atlassian Bamboo to interpret the test results.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@241855 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 241765 via svnmerge from
Tilghman Lesher [Thu, 21 Jan 2010 05:54:30 +0000 (05:54 +0000)]
Merged revisions 241765 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r241765 | tilghman | 2010-01-20 23:53:17 -0600 (Wed, 20 Jan 2010) | 2 lines

  Guard against division by zero.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@241766 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agortp timestamp to timeval calculation fix
David Vossel [Wed, 20 Jan 2010 21:14:47 +0000 (21:14 +0000)]
rtp timestamp to timeval calculation fix

The rtp timestamp to timeval calculation was only
accurate for 8kHz audio. This patch corrects this.

Review: https://reviewboard.asterisk.org/r/468/

SWP-648

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@241714 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 241626 via svnmerge from
David Vossel [Wed, 20 Jan 2010 20:01:07 +0000 (20:01 +0000)]
Merged revisions 241626 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r241626 | dvossel | 2010-01-20 14:00:04 -0600 (Wed, 20 Jan 2010) | 6 lines

  fixes parsing error in Makefile.

  Some echo lines were missing "; . Thanks to jparker for pointing out
  the problem.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@241627 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoAdd Calling and Called Subaddress to CDR record
Alec L Davis [Wed, 20 Jan 2010 17:49:30 +0000 (17:49 +0000)]
Add Calling and Called Subaddress to CDR record

Requires 'callingsubaddr' and 'calledsubaddr' fields in backend cdr.

(closes issue #16600)
Reported by: alecdavis
Patches:
      cdr_subaddr.diff.txt uploaded by alecdavis (license 585)
Tested by: alecdavis

Review: https://reviewboard.asterisk.org/r/460/

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@241581 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoFix up compile breakage from ast_tvdiff_ms() API change.
Kevin P. Fleming [Wed, 20 Jan 2010 13:01:00 +0000 (13:01 +0000)]
Fix up compile breakage from ast_tvdiff_ms() API change.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@241503 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoUpdate CDR variables as pbx starts
Alec L Davis [Wed, 20 Jan 2010 08:18:45 +0000 (08:18 +0000)]
Update CDR variables as pbx starts

Allows CDR variables added in cdr.c:set_one_cid to become visable during the call,
by executing ast_cdr_update() early in __ast_pbx run.
Reverts sig_pri changes in trunk that are specific to isdn technology only.

(closes issue #16638)
Reported by: alecdavis
Patches:
      cdr_update.diff3.txt uploaded by alecdavis (license 585)
Tested by: alecdavis

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@241416 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoInitialize data on the stack so that Park doesn't interpret random arguments.
Jeff Peeler [Tue, 19 Jan 2010 22:59:53 +0000 (22:59 +0000)]
Initialize data on the stack so that Park doesn't interpret random arguments.

passdata was only being set in pbx_substitue_variables when arguments were
passed.

(closes issue #16406)
(closes issue #16586)
Reported by: DLNoah
Patches:
      bug16586v2.patch uploaded by jpeeler (license 325)
Tested by: DLNoah

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@241366 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoEnable SendText to send strings in encoded format.
Tilghman Lesher [Tue, 19 Jan 2010 22:41:36 +0000 (22:41 +0000)]
Enable SendText to send strings in encoded format.

See http://lists.digium.com/pipermail/asterisk-users/2010-January/243462.html

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@241364 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agosmall correction from 241314
Jeff Peeler [Tue, 19 Jan 2010 18:51:19 +0000 (18:51 +0000)]
small correction from 241314

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@241315 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 241227 via svnmerge from
Jeff Peeler [Tue, 19 Jan 2010 18:46:11 +0000 (18:46 +0000)]
Merged revisions 241227 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r241227 | jpeeler | 2010-01-19 11:22:18 -0600 (Tue, 19 Jan 2010) | 13 lines

  Fix deadlock in agent_read by removing call to agent_logoff.

  One must always lock the agents list lock before the agent private. agent_read
  locks the private immediately, so locking the agents list lock is not an
  option (which is what agent_logoff requires). Because agent_read already
  has access to the agent private all that is necessary is to do the required
  hanging up that agent_logoff performed.

  (closes issue #16321)
  Reported by: valon24
  Patches:
        bug16321.patch uploaded by jpeeler (license 325)
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@241314 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoAllow parallel make (-j) to work properly.
Jason Parker [Tue, 19 Jan 2010 17:42:10 +0000 (17:42 +0000)]
Allow parallel make (-j) to work properly.

After some back and forth with the reporter, we came up with the necessary changes.

(closes issue #16489)
Reported by: Chainsaw
Patches:
      asterisk-1.6.2.1-parallel-make-minimal.patch uploaded by Chainsaw (license 723)
Tested by: Chainsaw, qwell

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@241230 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoBlocked revisions 241228 via svnmerge
Jason Parker [Tue, 19 Jan 2010 17:41:19 +0000 (17:41 +0000)]
Blocked revisions 241228 via svnmerge

........
  r241228 | qwell | 2010-01-19 11:41:00 -0600 (Tue, 19 Jan 2010) | 8 lines

  Allow parallel make (-j) to work properly.

  1.4 changes are quite different from the others.

  (issue #16489)
  Reported by: Chainsaw
  Tested by: qwell
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@241229 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoCreate iterative method for querying SRV results, and use that for finding AGI servers.
Tilghman Lesher [Tue, 19 Jan 2010 00:28:49 +0000 (00:28 +0000)]
Create iterative method for querying SRV results, and use that for finding AGI servers.

(closes issue #14775)
 Reported by: _brent_
 Patches:
       20091215__issue14775.diff.txt uploaded by tilghman (license 14)
       hagi-5.patch uploaded by brent (license 388)
 Tested by: _brent_
 Reviewboard: https://reviewboard.asterisk.org/r/378/

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@241188 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoUpdate CDR variables before pbx starts (overlap dial)
Alec L Davis [Tue, 19 Jan 2010 00:24:35 +0000 (00:24 +0000)]
Update CDR variables before pbx starts (overlap dial)

Allows CDR variables added in cdr.c:set_one_cid to become visable during the call.

(issue #16638)
Reported by: alecdavis
Patches:
      cdr_update.diff2.txt uploaded by alecdavis (license 585)
Tested by: alecdavis

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@241187 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoExtend max call limit duration from 24.8 days to 292+ million years.
Jeff Peeler [Mon, 18 Jan 2010 22:31:25 +0000 (22:31 +0000)]
Extend max call limit duration from 24.8 days to 292+ million years.

If the limit was set past MAX_INT upon answering, the call was immediately
hung up due to overflow from the return of ast_tvdiff_ms (in ast_check_hangup).
The time calculation functions ast_tvdiff_sec and ast_tvdiff_ms have been
changed to return an int64_t to prevent overflow. Also the reporter suggested
adding a message indicating the reason for the call hanging up. Given that the
new limit is so much higher, the message (which would only really be useful in
the overflow scenario) has been made a debug message only.

(closes issue #16006)
Reported by: viraptor

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@241143 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoFix an RTP instance allocation failure on Solaris.
Jason Parker [Mon, 18 Jan 2010 22:03:49 +0000 (22:03 +0000)]
Fix an RTP instance allocation failure on Solaris.

(closes issue #16543)
Reported by: crjw
Patches:
      rtp_sin_family.patch uploaded by crjw (license 963)
Tested by: crjw, qwell

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@241098 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoUpdate CDR variables before pbx starts
Alec L Davis [Mon, 18 Jan 2010 22:00:24 +0000 (22:00 +0000)]
Update CDR variables before pbx starts

Allows CDR variables added in cdr.c:set_one_cid to become visable during the call.

(closes issue #16638)
Reported by: alecdavis
Patches:
      cdr_update.diff.txt uploaded by alecdavis (license 585)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@241097 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 241015 via svnmerge from
Sean Bright [Mon, 18 Jan 2010 19:57:52 +0000 (19:57 +0000)]
Merged revisions 241015 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r241015 | seanbright | 2010-01-18 14:54:19 -0500 (Mon, 18 Jan 2010) | 12 lines

  Plug a memory leak when reading configs with their comments.

  While reading through configuration files with the intent of returning their
  full contents (comments specifically) we allocated some memory and then forgot
  to free it.  This doesn't fix 16554 but clears up a leak I had in the lab.

  (issue #16554)
  Reported by: mav3rick
  Patches:
        issue16554_20100118.patch uploaded by seanbright (license 71)
  Tested by: seanbright
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@241016 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMake HASHes inheritable across channel creation.
Tilghman Lesher [Mon, 18 Jan 2010 19:26:07 +0000 (19:26 +0000)]
Make HASHes inheritable across channel creation.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@241012 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoExternalIVR information for UPGRADE.txt
David Ruggles [Mon, 18 Jan 2010 18:00:36 +0000 (18:00 +0000)]
ExternalIVR information for UPGRADE.txt

added a paragraph about the fixes and changes to
the ExternalIVR application.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@240974 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoUpdated ExternalIVR documentation
David Ruggles [Mon, 18 Jan 2010 17:51:09 +0000 (17:51 +0000)]
Updated ExternalIVR documentation

Rewrote a large portion of the existing documentation
and added information about the TCP/IP socket interface

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@240973 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agotransmit_silence_during_record replaced by transmit_silence
David Vossel [Mon, 18 Jan 2010 17:45:18 +0000 (17:45 +0000)]
transmit_silence_during_record replaced by transmit_silence

In asterisk.conf, transmit_silence_during_record has been removed
in favor of using only the transmit_silence option.  The
transmit_silence_during_record option remains a valid option in
asterisk.conf, but has been removed from the sample config and
noted in CHANGES.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@240971 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoAdd notification of interrupted file
David Ruggles [Mon, 18 Jan 2010 17:41:44 +0000 (17:41 +0000)]
Add notification of interrupted file

Add file information to data element of T event so
the file information is sent to the client when it is
interrupted. Previously only notification of pending
files that were dropped was sent

(closes issue #16147)
Reported by: thedavidfactor
Tested by: thedavidfactor

Review: https://reviewboard.asterisk.org/r/449/

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@240969 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoBlocked revisions 240891 via svnmerge
David Vossel [Mon, 18 Jan 2010 16:52:11 +0000 (16:52 +0000)]
Blocked revisions 240891 via svnmerge

........
  r240891 | dvossel | 2010-01-18 10:51:35 -0600 (Mon, 18 Jan 2010) | 7 lines

  updated transmit_silence option documentation in asterisk.conf

  This patch updates the transmit_silence option to better document
  why the option exists, and what it affects.  Thanks to russell
  for providing the verbage for this update.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@240892 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoupdated transmit_silence option documentation in asterisk.conf
David Vossel [Mon, 18 Jan 2010 16:45:28 +0000 (16:45 +0000)]
updated transmit_silence option documentation in asterisk.conf

This patch updates the transmit_silence option to better document
why the option exists, and what it affects.  Thanks to russell
for providing the verbage for this update.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@240887 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agofixes spelling error. s/memeber/member
David Vossel [Mon, 18 Jan 2010 15:52:55 +0000 (15:52 +0000)]
fixes spelling error.  s/memeber/member

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@240842 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMuted already compiles on OS/X in trunk and 1.6 branches, fix blocked.
Olle Johansson [Mon, 18 Jan 2010 13:29:25 +0000 (13:29 +0000)]
Muted already compiles on OS/X in trunk and 1.6 branches, fix blocked.

Blocked revisions 240768 via svnmerge

........
r240768 | oej | 2010-01-18 14:27:22 +0100 (Mån, 18 Jan 2010) | 2 lines

Fix muted compilation in 1.4 only

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@240769 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoAvoid a crash on Solaris when running 'core show functions.'
Sean Bright [Sun, 17 Jan 2010 19:45:48 +0000 (19:45 +0000)]
Avoid a crash on Solaris when running 'core show functions.'

(closes issue #16309)
Reported by: asgaroth

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@240717 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoGet MoH building on OpenSolaris.
Sean Bright [Sat, 16 Jan 2010 00:54:08 +0000 (00:54 +0000)]
Get MoH building on OpenSolaris.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@240667 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoErr, oops, it was already the way I intended.
Tilghman Lesher [Fri, 15 Jan 2010 23:50:47 +0000 (23:50 +0000)]
Err, oops, it was already the way I intended.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@240629 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoNote where empty lines should reside in commit messages.
Russell Bryant [Fri, 15 Jan 2010 23:09:09 +0000 (23:09 +0000)]
Note where empty lines should reside in commit messages.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@240552 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 240547 via svnmerge from
Russell Bryant [Fri, 15 Jan 2010 23:06:32 +0000 (23:06 +0000)]
Merged revisions 240547 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r240547 | russell | 2010-01-15 17:06:11 -0600 (Fri, 15 Jan 2010) | 2 lines

  Fix a spelling error in the asterisk.conf sample.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@240548 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoClarify error message in res_timing_timerfd.
Sean Bright [Fri, 15 Jan 2010 22:07:31 +0000 (22:07 +0000)]
Clarify error message in res_timing_timerfd.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@240505 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoOops, missed an include
Tilghman Lesher [Fri, 15 Jan 2010 21:42:36 +0000 (21:42 +0000)]
Oops, missed an include

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@240500 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoThe previous attempt at using a pipe to guarantee astcanary shutdown did not work.
Tilghman Lesher [Fri, 15 Jan 2010 21:40:14 +0000 (21:40 +0000)]
The previous attempt at using a pipe to guarantee astcanary shutdown did not work.
We're revisiting the previous patch, albeit with a method that overcomes the
prior criticism that it was not POSIX-compliant.
(closes issue #16602)
 Reported by: frawd
 Patches:
       20100114__issue16602.diff.txt uploaded by tilghman (license 14)
 Tested by: frawd

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@240499 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoAdd pickup event to AMI. Also, fix AMI documentation.
Tilghman Lesher [Fri, 15 Jan 2010 21:04:34 +0000 (21:04 +0000)]
Add pickup event to AMI.  Also, fix AMI documentation.
(closes issue #16431)
 Reported by: syspert
 Patches:
       20100112__issue16431.diff.txt uploaded by tilghman (license 14)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@240421 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMake sure to set owner_line, ownder_func, and owner_file in ast_calloc_with_stringfields.
Mark Michelson [Fri, 15 Jan 2010 20:58:24 +0000 (20:58 +0000)]
Make sure to set owner_line, ownder_func, and owner_file in ast_calloc_with_stringfields.

Asterisk would crash on startup if MALLOC_DEBUG were set in menuselect. This is because
the manager action UpdateConfig had to resize its string field allocation to set the
description. When the resize occurred, ast_copy_string would crash because we were
attempting to copy a string from a NULL pointer. Setting the strings initially makes
the code much less crashy.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@240420 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMake sure that the limit is N, not N - 1.
Tilghman Lesher [Fri, 15 Jan 2010 20:58:19 +0000 (20:58 +0000)]
Make sure that the limit is N, not N - 1.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@240419 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 240414 via svnmerge from
Tilghman Lesher [Fri, 15 Jan 2010 20:54:24 +0000 (20:54 +0000)]
Merged revisions 240414 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r240414 | tilghman | 2010-01-15 14:52:27 -0600 (Fri, 15 Jan 2010) | 15 lines

  Disallow leaving more than maxmsg voicemails.
  This is a possibility because our previous method assumed that no messages are
  left in parallel, which is not a safe assumption.  Due to the vmu structure
  duplication, it was necessary to track in-process messages via a separate
  structure.  If at some point, we switch vmu to an ao2-reference-counted
  structure, which would eliminate the prior noted duplication of structures,
  then we could incorporate this new in-process structure directly into vmu.
  (closes issue #16271)
   Reported by: sohosys
   Patches:
         20100108__issue16271.diff.txt uploaded by tilghman (license 14)
         20100108__issue16271__trunk.diff.txt uploaded by tilghman (license 14)
         20100108__issue16271__1.6.0.diff.txt uploaded by tilghman (license 14)
   Tested by: jsutton
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@240415 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoEnsure payload type is properly checked when comparing against cached events.
Russell Bryant [Fri, 15 Jan 2010 20:41:11 +0000 (20:41 +0000)]
Ensure payload type is properly checked when comparing against cached events.

(closes issue #16607)
Reported by: ddv2005
Patches:
      event.patch uploaded by ddv2005 (license 769)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@240411 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoConvert a few places to use ast_calloc_with_stringfields where applicable.
Sean Bright [Fri, 15 Jan 2010 18:21:50 +0000 (18:21 +0000)]
Convert a few places to use ast_calloc_with_stringfields where applicable.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@240368 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoUpdate configure script for an OSP toolkit related change.
Russell Bryant [Fri, 15 Jan 2010 16:51:34 +0000 (16:51 +0000)]
Update configure script for an OSP toolkit related change.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@240329 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoClarify RTP NAT handling a bit.
Kevin P. Fleming [Fri, 15 Jan 2010 16:28:38 +0000 (16:28 +0000)]
Clarify RTP NAT handling a bit.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@240328 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoPlug a memory leak in res_config_ldap.
Sean Bright [Thu, 14 Jan 2010 23:13:02 +0000 (23:13 +0000)]
Plug a memory leak in res_config_ldap.

(closes issue #16257)
Reported by: nito
Patches:
      issue16257_20100111.diff uploaded by seanbright (license 71)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@240271 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoIf we aren't running on a machine that support CLOCK_MONOTONIC, don't load.
Sean Bright [Thu, 14 Jan 2010 20:30:03 +0000 (20:30 +0000)]
If we aren't running on a machine that support CLOCK_MONOTONIC, don't load.

Group developed and tested by seanbright, Corydon76, Kobaz, and Amorsen.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@240226 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoFix broken call pickup
Jeff Peeler [Thu, 14 Jan 2010 18:03:31 +0000 (18:03 +0000)]
Fix broken call pickup

The problem was the OUTGOING flag was not getting set properly on the channel,
resulting in pickup failing as ast_read thought the call was inbound. Refer to
170393 for a more verbose description as this is the same exact change.

(closes issue #16539)
Reported by: syspert
Patches:
      bug16539.patch uploaded by jpeeler (license 325)
Tested by: syspert

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@240179 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoSimilarly, ensure that matchcid is duplicated correctly when merging contexts.
Tilghman Lesher [Thu, 14 Jan 2010 17:34:53 +0000 (17:34 +0000)]
Similarly, ensure that matchcid is duplicated correctly when merging contexts.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@240175 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoEnsure that the callerid is NULL when the parent is effectively NULL.
Tilghman Lesher [Thu, 14 Jan 2010 16:52:22 +0000 (16:52 +0000)]
Ensure that the callerid is NULL when the parent is effectively NULL.
This applies only to pattern-match hints, which create exact-match
hints on the fly.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@240129 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoThis change fixes a few bugs in the way the far max IFP was calculated that were...
Matthew Nicholson [Thu, 14 Jan 2010 16:14:35 +0000 (16:14 +0000)]
This change fixes a few bugs in the way the far max IFP was calculated that were introduced in r231692.

(closes issue #16497)
Reported by: globalnetinc
Patches:
      udptl-max-ifp-fix1.diff uploaded by mnicholson (license 96)
Tested by: globalnetinc

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@240078 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoAdd documentation about how to build queues.
Leif Madsen [Thu, 14 Jan 2010 14:38:01 +0000 (14:38 +0000)]
Add documentation about how to build queues.

Add a how-to set of documentation about building queues with Asterisk.
This documentation is based on Asterisk 1.6.2 but should work on most
versions with minor modifications.

(closes issue #16237)
Reported by: lmadsen
Patches:
      Building Queues (FINAL).txt uploaded by lmadsen (license 10)
Tested by: pdhales, lmadsen, cmdrwalrus

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@240039 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoOops, another tag error
Tilghman Lesher [Wed, 13 Jan 2010 23:22:56 +0000 (23:22 +0000)]
Oops, another tag error

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@239997 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoOops, missed a closing tag
Tilghman Lesher [Wed, 13 Jan 2010 23:21:46 +0000 (23:21 +0000)]
Oops, missed a closing tag

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@239996 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoAdd the TESTTIME() dialplan function, which permits testing GotoIfTime.
Tilghman Lesher [Wed, 13 Jan 2010 21:27:34 +0000 (21:27 +0000)]
Add the TESTTIME() dialplan function, which permits testing GotoIfTime.
Specifically, by setting TESTTIME() to a particular date and time, you
can test whether a dialplan correctly branches as was intended.  This was
developed after recent questions on the -users list on how to test their
holiday dialplan logic.
(closes issue #16464)
 Reported by: tilghman
 Patches:
       20100112__issue16464.diff.txt uploaded by tilghman (license 14)

Review: https://reviewboard.asterisk.org/r/458/

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@239957 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoFlex uses fwrite incorrectly, which breaks the build. Providing a workaround.
Tilghman Lesher [Wed, 13 Jan 2010 20:38:42 +0000 (20:38 +0000)]
Flex uses fwrite incorrectly, which breaks the build.  Providing a workaround.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@239920 65c4cc65-6c06-0410-ace0-fbb531ad65f3

9 years agoMerged revisions 239838 via svnmerge from
Jeff Peeler [Wed, 13 Jan 2010 19:48:16 +0000 (19:48 +0000)]
Merged revisions 239838 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r239838 | jpeeler | 2010-01-13 13:43:33 -0600 (Wed, 13 Jan 2010) | 11 lines

  Fix regression for timed out parked call returning to caller

  This issue seems to have been exposed by the fix in 160390 whereby using a
  masquerade prevented a crash. The new channel used in the masquerade was
  not copying the macro information from the old channel.

  (closes issue #15459)
  Reported by: djrodman
  Patches:
        patch_15459.txt uploaded by mnick (license )
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@239839 65c4cc65-6c06-0410-ace0-fbb531ad65f3