Merged revisions 319997 via svnmerge from

Merged revisions 319997 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8

........
  r319997 | rmudgett | 2011-05-20 10:48:25 -0500 (Fri, 20 May 2011) | 25 lines

  Crash when using directed pickup applications.

  The directed pickup applications can cause a crash if the pickup was
  successful because the dialplan keeps executing.

  This patch does the following:

  * Completes the channel masquerade on a successful pickup before the
  application returns.  The channel is now guaranteed a zombie and must not
  continue executing the dialplan.

  * Changes the return value of the directed pickup applications to return
  zero if the pickup failed and nonzero(-1) if the pickup succeeded.

  * Made some code optimizations that no longer require re-checking the
  pickup channel to see if it is still available to pickup.

  (closes issue #19310)
  Reported by: remiq
  Patches:
        issue19310_v1.8_v2.patch uploaded by rmudgett (license 664)
  Tested by: alecdavis, remiq, rmudgett

  Review: https://reviewboard.asterisk.org/r/1221/
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@319998 65c4cc65-6c06-0410-ace0-fbb531ad65f3