app_sms: Fix uninitialized values; hangup channel when REL is sent successfully
authorMatthew Jordan <mjordan@digium.com>
Sat, 19 Apr 2014 01:31:27 +0000 (01:31 +0000)
committerMatthew Jordan <mjordan@digium.com>
Sat, 19 Apr 2014 01:31:27 +0000 (01:31 +0000)
commit21759b02ede44a565d87dc302733cbfa6fb56b08
tree60a4d53c5752339ec35b433745b78cf6f9fe7431
parentb9d7dfcc62c80d2b2827dd7b70701dfb21512c13
app_sms: Fix uninitialized values; hangup channel when REL is sent successfully

This patch fixes two issues in app_sms:
(1) Firstly, the 'flags' field on the stack in sms_exec() is uninitialised,
    causing it to use the wrong protocol in some cases. This patch correctly
    initializes the flags fields.

(2) Secondly, when disconnect supervision is not working or
    inbanddisconnect=yes is set in chan_dahdi.conf, app_sms was failing to
    terminate the call after it sent the REL(ease) message and the peer stopped
    talking to it. This patch fixes the code to handle the 'bad stop bit'
    message more gracefully in that case, and hang up the call.

Review: https://reviewboard.asterisk.org/r/1392/

ASTERISK-18331 #close
Reported by: David Woodhouse
patches:
  asterisk-fix-sms.patch uploaded by David Woodhouse (License 5754)
........

Merged revisions 412655 from http://svn.asterisk.org/svn/asterisk/branches/1.8
........

Merged revisions 412656 from http://svn.asterisk.org/svn/asterisk/branches/11
........

Merged revisions 412657 from http://svn.asterisk.org/svn/asterisk/branches/12

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@412697 65c4cc65-6c06-0410-ace0-fbb531ad65f3
apps/app_sms.c