Fix shutdown assertions in stasis-core
authorDavid M. Lee <dlee@digium.com>
Fri, 17 May 2013 21:10:32 +0000 (21:10 +0000)
committerDavid M. Lee <dlee@digium.com>
Fri, 17 May 2013 21:10:32 +0000 (21:10 +0000)
commitb97c71bb1190cb41eba9081d14724bcb39d422ba
tree2ae24b23411b0ab59b2239c4cefc5675c67de48e
parent91bab7642281b593495284bd16744a6213cb6ea8
Fix shutdown assertions in stasis-core

In r388005, macros were introduced to consistently define message
types. This added an assert if a message type was used either before
it was initialized or after it had been cleaned up. It turns out that
this assertion fires during shutdown.

This actually exposed a hidden shutdown ordering problem. Since
unsubscribing is asynchronous, it's possible that the message types
used by the subscription could be freed before the final message of
the subscription was processed.

This patch adds stasis_subscription_join(), which blocks until the
last message has been processed by the subscription. Since joining was
most commonly done right after an unsubscribe, a
stasis_unsubscribe_and_join() convenience function was also added.

Similar functions were also added to the stasis_caching_topic and
stasis_message_router, since they wrap subscriptions and have similar
problems.

Other code in trunk was refactored to join() where appropriate, or at
least verify that the subscription was complete before being
destroyed.

Review: https://reviewboard.asterisk.org/r/2540

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@389011 65c4cc65-6c06-0410-ace0-fbb531ad65f3
21 files changed:
apps/app_queue.c
apps/app_voicemail.c
channels/chan_iax2.c
channels/chan_sip.c
funcs/func_presencestate.c
include/asterisk/stasis.h
include/asterisk/stasis_message_router.h
main/app.c
main/devicestate.c
main/endpoints.c
main/manager.c
main/manager_channels.c
main/pbx.c
main/stasis.c
main/stasis_cache.c
main/stasis_channels.c
main/stasis_endpoints.c
main/stasis_message_router.c
res/res_chan_stats.c
res/res_jabber.c
res/res_stasis.c