res_pjsip: Fix contact authenticate_qualify endpoint lookup when qualifing a contact.
authorRichard Mudgett <rmudgett@digium.com>
Tue, 25 Mar 2014 16:57:41 +0000 (16:57 +0000)
committerRichard Mudgett <rmudgett@digium.com>
Tue, 25 Mar 2014 16:57:41 +0000 (16:57 +0000)
commitc1c8300e27060033cab536e0782b8d508bcfbdd5
tree8f11f996705f0dd26daf5fa616da94bdd52e5365
parenta4890eddfb4f98029c046f490e03e2ae9170dee7
res_pjsip: Fix contact authenticate_qualify endpoint lookup when qualifing a contact.

* Fixed bad use of ao2_find() in on_endpoint().

* Replaced use of find_endpoints() with find_an_endpoint() since only the
first found endpoint is ever needed.

* Fixed qualify_contact_cb() to update the contact with the aor
authenticate_qualify setting.  Otherwise, permanent contacts in the aor
type sections would have a config line order dependancy.

* Fixed off nominal path contact ref leak in qualify_contact().  The
comment saying the unref is not needed was wrong.

* Fixed off nominal path use of the endpoint parameter if it is NULL in
send_out_of_dialog_request().

* Added missing off nominal path unref of pjsip tdata in
send_out_of_dialog_request().

* Fixed off nominal path failing to call the callback in send_request_cb()
when the request is challenged for authentication.

* Eliminated silly RAII_VAR() use in qualify_contact_cb().

* Updated ast_sip_send_request() doxygen to better reflect reality.

(closes issue ASTERISK-23254)
Reported by: rmudgett

Review: https://reviewboard.asterisk.org/r/3381/
........

Merged revisions 411141 from http://svn.asterisk.org/svn/asterisk/branches/12

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@411142 65c4cc65-6c06-0410-ace0-fbb531ad65f3
include/asterisk/res_pjsip.h
res/res_pjsip.c
res/res_pjsip/pjsip_options.c