chan_sip: NOTIFYs for BLF start queuing up and fail to be sent out after retries...
authorAlec L Davis <sivad.a@paradise.net.nz>
Wed, 8 May 2013 07:21:09 +0000 (07:21 +0000)
committerAlec L Davis <sivad.a@paradise.net.nz>
Wed, 8 May 2013 07:21:09 +0000 (07:21 +0000)
commitefd28c676a4a467f1bb31d3359c43c2f1d70029b
treeceb6157dca07edbc1bffecbec0d6aa1fbefaf35d
parenta61060cf41ba4eced0120122ca447f114f791359
chan_sip: NOTIFYs for BLF start queuing up and fail to be sent out after retries fail

RFC6665 4.2.2: ... after a failed State NOTIFY transaction remove the subscription

The problem is that the State Notify requests rely on the 200OK reponse for pacing control
and to not confuse the notify susbsystem.
The issue is, the pendinginvite isn't cleared if a response isn't received,
thus further notify's are never sent.

The solution, follow RFC 6665 4.2.2's 'SHOULD' and remove the subscription after failure.

(closes issue ASTERISK-21677)

Reported by: Dan Martens
Tested by: alecdavis
alecdavis (license 585)

Review https://reviewboard.asterisk.org/r/2475/
........

Merged revisions 387875 from http://svn.asterisk.org/svn/asterisk/branches/1.8
........

Merged revisions 387880 from http://svn.asterisk.org/svn/asterisk/branches/11

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@387885 65c4cc65-6c06-0410-ace0-fbb531ad65f3
channels/chan_sip.c