Merged revisions 109908 via svnmerge from
authorSteve Murphy <murf@digium.com>
Wed, 19 Mar 2008 16:24:51 +0000 (16:24 +0000)
committerSteve Murphy <murf@digium.com>
Wed, 19 Mar 2008 16:24:51 +0000 (16:24 +0000)
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r109908 | murf | 2008-03-19 09:41:13 -0600 (Wed, 19 Mar 2008) | 72 lines

(closes issue #11442)
Reported by: tzafrir
Patches:
      11442.patch uploaded by murf (license 17)
Tested by: murf

I didn't give tzafrir very much time to test this, but if he does
still have remaining issues, he is welcome to
re-open this bug, and we'll do what is called for.

I reproduced the problem, and tested the fix, so I hope I
am not jumping by just going ahead and committing the fix.

The problem was with what file_save does with templates;
firstly, it tended to print out multiple options:

[my_category](!)(templateref)

instead of

[my_category](!,templateref)

which is fixed by this patch.

Nextly, the code to suppress output of duplicate declarations
that would occur because the reader copies inherited declarations
down the hierarchy, was not working. Thus:

 [master-template](!)
 mastervar = bar

 [template](!,master-template)
 tvar = value

 [cat](template)
 catvar = val

would be rewritten as:

 ;!
 ;! Automatically generated configuration file
 ;! Filename: experiment.conf (/etc/asterisk/experiment.conf)
 ;! Generator: Manager
 ;! Creation Date: Tue Mar 18 23:17:46 2008
 ;!

 [master-template](!)
 mastervar = bar

 [template](!,master-template)
 mastervar = bar
 tvar = value

 [cat](template)
 mastervar = bar
 tvar = value
 catvar = val

This has been fixed. Since the config reader 'explodes' inherited
vars into the category, users may, in certain circumstances, see
output different from what they originally entered, but it should
be both correct and equivalent.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@109942 65c4cc65-6c06-0410-ace0-fbb531ad65f3

main/config.c

index ebc75f2..0c09cc8 100644 (file)
@@ -1621,15 +1621,21 @@ int config_text_file_save(const char *configfile, const struct ast_config *cfg,
                        if (!cat->precomments)
                                fprintf(f,"\n");
                        fprintf(f, "[%s]", cat->name);
-                       if (cat->ignored)
-                               fprintf(f, "(!)");
-                       if (!AST_LIST_EMPTY(&cat->template_instances)) {
-                               struct ast_category_template_instance *x;
+                       if (cat->ignored || !AST_LIST_EMPTY(&cat->template_instances)) {
                                fprintf(f, "(");
-                               AST_LIST_TRAVERSE(&cat->template_instances, x, next) {
-                                       fprintf(f,"%s",x->name);
-                                       if (x != AST_LIST_LAST(&cat->template_instances))
-                                               fprintf(f,",");
+                               if (cat->ignored) {
+                                       fprintf(f, "!");
+                               }
+                               if (cat->ignored && !AST_LIST_EMPTY(&cat->template_instances)) {
+                                       fprintf(f, ",");
+                               }
+                               if (!AST_LIST_EMPTY(&cat->template_instances)) {
+                                       struct ast_category_template_instance *x;
+                                       AST_LIST_TRAVERSE(&cat->template_instances, x, next) {
+                                               fprintf(f,"%s",x->name);
+                                               if (x != AST_LIST_LAST(&cat->template_instances))
+                                                       fprintf(f,",");
+                                       }
                                }
                                fprintf(f, ")");
                        }