tcptls: Print notice when TLS is enabled but not configured.
authorAlexander Traud <pabstraud@compuserve.com>
Mon, 6 Nov 2017 09:18:24 +0000 (10:18 +0100)
committerAlexander Traud <pabstraud@compuserve.com>
Mon, 6 Nov 2017 09:18:24 +0000 (10:18 +0100)
Asterisk can be compiled without a SSL/TLS library, without the Development
Headers of OpenSSL. However, if TLS (SIP) or Secure-WebSockets (WebRTC) was
enabled in a configuration file, Asterisk did not notice the user. Asterisk
failed silently, only the corresponding TCP ports were not open.

ASTERISK-27394
Reported-by: mossley74

Change-Id: Ib8b7539a5b2af8154c22e5f7a40fc68f95d95b93

main/tcptls.c

index 4a95f72..a6d0538 100644 (file)
@@ -316,7 +316,10 @@ static void __ssl_setup_certs(struct ast_tls_config *cfg, const size_t cert_file
 static int __ssl_setup(struct ast_tls_config *cfg, int client)
 {
 #ifndef DO_SSL
-       cfg->enabled = 0;
+       if (cfg->enabled) {
+               ast_log(LOG_NOTICE, "Configured without OpenSSL Development Headers");
+               cfg->enabled = 0;
+       }
        return 0;
 #else
        int disable_ssl = 0;