Remove redundant code in dns.c
authorMatthew Jordan <mjordan@digium.com>
Sun, 14 Jul 2013 02:05:04 +0000 (02:05 +0000)
committerMatthew Jordan <mjordan@digium.com>
Sun, 14 Jul 2013 02:05:04 +0000 (02:05 +0000)
Peter J Philipp pointed out that there are two checks that ensure that len is
not less than 0. If len is less than 0, the function returns. Having both of
them is clearly redundant.

This removes the second and attempts to clarify (slightly) the error condition.

(closes issue ASTERISK-21772)
Reported by: Peter J Philipp

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@394305 65c4cc65-6c06-0410-ace0-fbb531ad65f3

main/dns.c

index c507d5a..d568275 100644 (file)
@@ -225,11 +225,7 @@ static int dns_parse_answer(void *context,
                answer += sizeof(struct dn_answer);
                len -= sizeof(struct dn_answer);
                if (len < 0) {
-                       ast_log(LOG_WARNING, "Strange result size\n");
-                       return -1;
-               }
-               if (len < 0) {
-                       ast_log(LOG_WARNING, "Length exceeds frame\n");
+                       ast_log(LOG_WARNING, "Length of DNS answer exceeds frame\n");
                        return -1;
                }