Only print out the error message if ldap_modify_ext_s actually returns an error,...
authorJoshua Colp <jcolp@digium.com>
Mon, 21 Apr 2008 14:34:06 +0000 (14:34 +0000)
committerJoshua Colp <jcolp@digium.com>
Mon, 21 Apr 2008 14:34:06 +0000 (14:34 +0000)
(closes issue #12438)
Reported by: gservat
Patches:
      res_config_ldap.c-patch-code uploaded by gservat (license 466)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114320 65c4cc65-6c06-0410-ace0-fbb531ad65f3

res/res_config_ldap.c

index 376f9af..cb1bd78 100644 (file)
@@ -1285,7 +1285,7 @@ static int update_ldap(const char *basedn, const char *table_name, const char *a
 
                for (i = 0; ldap_entry; i++) { 
                        dn = ldap_get_dn(ldapConn, ldap_entry);
 
                for (i = 0; ldap_entry; i++) { 
                        dn = ldap_get_dn(ldapConn, ldap_entry);
-                       if (!(error = ldap_modify_ext_s(ldapConn, dn, ldap_mods, NULL, NULL))) 
+                       if ((error = ldap_modify_ext_s(ldapConn, dn, ldap_mods, NULL, NULL)) != LDAP_SUCCESS) 
                                ast_log(LOG_ERROR, "Couldn't modify dn:%s because %s", dn, ldap_err2string(error));
 
                        ldap_entry = ldap_next_entry(ldapConn, ldap_entry);
                                ast_log(LOG_ERROR, "Couldn't modify dn:%s because %s", dn, ldap_err2string(error));
 
                        ldap_entry = ldap_next_entry(ldapConn, ldap_entry);