Do the (expensive) LOCAL_USER_ADD only after we are sure

that arguments are valid.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@14785 65c4cc65-6c06-0410-ace0-fbb531ad65f3

diff --git a/funcs/func_enum.c b/funcs/func_enum.c
index 5f1b01d..87f321e 100644 (file)
--- a/funcs/func_enum.c
+++ b/funcs/func_enum.c
@@ -141,14 +141,14 @@ static int function_txtcidname(struct ast_channel *chan, char *cmd,
 
        buf[0] = '\0';
 
-       LOCAL_USER_ADD(u);
 
        if (ast_strlen_zero(data)) {
                ast_log(LOG_WARNING, "TXTCIDNAME requires an argument (number)\n");
-               LOCAL_USER_REMOVE(u);
                return -1;
        }
 
+       LOCAL_USER_ADD(u);
+
        res = ast_get_txt(chan, data, dest, sizeof(dest), tech, sizeof(tech), txt,
                          sizeof(txt));