Merged revisions 184078 via svnmerge from

https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r184078 | mmichelson | 2009-03-24 17:34:45 -0500 (Tue, 24 Mar 2009) | 9 lines

  Change NULL pointer check to be ast_strlen_zero.

  The 'digit' variable is guaranteed to be non-NULL, so the if
  statement could never evaluate true. Changing to ast_strlen_zero
  makes the logic correct.

  This was found while reviewing ast_channel_ao2 code review.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@184079 65c4cc65-6c06-0410-ace0-fbb531ad65f3

diff --git a/apps/app_senddtmf.c b/apps/app_senddtmf.c
index 05faf22..9842c41 100644 (file)
--- a/apps/app_senddtmf.c
+++ b/apps/app_senddtmf.c
@@ -106,7 +106,7 @@ static int manager_play_dtmf(struct mansession *s, const struct message *m)
                astman_send_error(s, m, "Channel not specified");
                return 0;
        }
-       if (!digit) {
+       if (ast_strlen_zero(digit)) {
                astman_send_error(s, m, "No digit specified");
                ast_channel_unlock(chan);
                return 0;