Fix a race condition in res_pjsip_session with rapidly terminating the session.
authorJoshua Colp <jcolp@digium.com>
Sun, 13 Oct 2013 15:42:20 +0000 (15:42 +0000)
committerJoshua Colp <jcolp@digium.com>
Sun, 13 Oct 2013 15:42:20 +0000 (15:42 +0000)
The INVITE session state callback wrongly assumes that a session will always exist, but
when rapidly terminating the session this assumption goes out the window. As all handler
code for the INVITE session state callback requires the session it will now just exit
immediately if no session exists.

(closes issue ASTERISK-22668)
Reported by: John Bigelow
........

Merged revisions 400872 from http://svn.asterisk.org/svn/asterisk/branches/12

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@400873 65c4cc65-6c06-0410-ace0-fbb531ad65f3

res/res_pjsip_session.c

index a186bf6..4dae4b4 100644 (file)
@@ -1814,6 +1814,10 @@ static void session_inv_on_state_changed(pjsip_inv_session *inv, pjsip_event *e)
 
        print_debug_details(inv, NULL, e);
 
+       if (!session) {
+               return;
+       }
+
        switch(e->type) {
        case PJSIP_EVENT_TX_MSG:
                handle_outgoing(session, e->body.tx_msg.tdata);