Ensure Shutdown AMI event is still fired during Asterisk shutdown
authorMatthew Jordan <mjordan@digium.com>
Tue, 2 Oct 2012 21:26:27 +0000 (21:26 +0000)
committerMatthew Jordan <mjordan@digium.com>
Tue, 2 Oct 2012 21:26:27 +0000 (21:26 +0000)
Richard pointed out that having the manager dispose of itself gracefully
during shutdown meant that the Shutdown event will no longer get fired.
This patch moves the AMI event just prior to running the atexit callbacks.
........

Merged revisions 374230 from http://svn.asterisk.org/svn/asterisk/branches/1.8
........

Merged revisions 374231 from http://svn.asterisk.org/svn/asterisk/branches/10
........

Merged revisions 374248 from http://svn.asterisk.org/svn/asterisk/branches/11

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@374259 65c4cc65-6c06-0410-ace0-fbb531ad65f3

main/asterisk.c

index 03c9962..78a481d 100644 (file)
@@ -1869,11 +1869,10 @@ static void really_quit(int num, shutdown_nice_t niceness, int restart)
                        }
                }
        }
-       ast_verb(0, "Executing last minute cleanups\n");
-       ast_run_atexits();
-       /* Called on exit */
-       ast_verb(0, "Asterisk %s ending (%d).\n", ast_active_channels() ? "uncleanly" : "cleanly", num);
-       ast_debug(1, "Asterisk ending (%d).\n", num);
+       /* The manager event for shutdown must happen prior to ast_run_atexits, as
+        * the manager interface will dispose of its sessions as part of its
+        * shutdown.
+        */
        /*** DOCUMENTATION
                <managerEventInstance>
                        <synopsis>Raised when Asterisk is shutdown or restarted.</synopsis>
@@ -1893,7 +1892,16 @@ static void really_quit(int num, shutdown_nice_t niceness, int restart)
                        </syntax>
                </managerEventInstance>
        ***/
-       manager_event(EVENT_FLAG_SYSTEM, "Shutdown", "Shutdown: %s\r\nRestart: %s\r\n", ast_active_channels() ? "Uncleanly" : "Cleanly", restart ? "True" : "False");
+       manager_event(EVENT_FLAG_SYSTEM, "Shutdown", "Shutdown: %s\r\n"
+               "Restart: %s\r\n",
+               ast_active_channels() ? "Uncleanly" : "Cleanly",
+               restart ? "True" : "False");
+
+       ast_verb(0, "Executing last minute cleanups\n");
+       ast_run_atexits();
+       /* Called on exit */
+       ast_verb(0, "Asterisk %s ending (%d).\n", ast_active_channels() ? "uncleanly" : "cleanly", num);
+       ast_debug(1, "Asterisk ending (%d).\n", num);
        if (ast_socket > -1) {
                pthread_cancel(lthread);
                close(ast_socket);