do expensive 'next message number' calculation before playing sounds (issue #4955)
authorKevin P. Fleming <kpfleming@digium.com>
Tue, 23 Aug 2005 02:01:37 +0000 (02:01 +0000)
committerKevin P. Fleming <kpfleming@digium.com>
Tue, 23 Aug 2005 02:01:37 +0000 (02:01 +0000)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@6373 65c4cc65-6c06-0410-ace0-fbb531ad65f3

apps/app_voicemail.c

index 533335f..42b2820 100755 (executable)
@@ -2255,18 +2255,25 @@ static int leave_voicemail(struct ast_channel *chan, char *ext, int silent, int
                                return ERROR_LOCK_PATH;
                        }
 
-                       if (res >= 0) {
-                               /* Unless we're *really* silent, try to send the beep */
-                               res = ast_streamfile(chan, "beep", chan->language);
-                               if (!res)
-                                       res = ast_waitstream(chan, "");
-                       }
+                       /* 
+                        * This operation can be very expensive if done say over NFS or if the mailbox has 100+ messages
+                        * in the mailbox.  So we should get this first so we don't cut off the first few seconds of the 
+                        * message.  
+                        */
                        do {
                                make_file(fn, sizeof(fn), dir, msgnum);
                                if (!EXISTS(dir,msgnum,fn,chan->language))
                                        break;
                                msgnum++;
                        } while (msgnum < vmu->maxmsg);
+
+                       /* Now play the beep once we have the message number for our next message. */
+                       if (res >= 0) {
+                               /* Unless we're *really* silent, try to send the beep */
+                               res = ast_streamfile(chan, "beep", chan->language);
+                               if (!res)
+                                       res = ast_waitstream(chan, "");
+                       }
                        if (msgnum < vmu->maxmsg) {
                                /* assign a variable with the name of the voicemail file */       
                                pbx_builtin_setvar_helper(chan, "VM_MESSAGEFILE", fn);