res_pjsip: Use ast_sip_is_content_type() where appropriate
authorSean Bright <sean.bright@gmail.com>
Fri, 22 Sep 2017 15:02:11 +0000 (11:02 -0400)
committerSean Bright <sean.bright@gmail.com>
Fri, 22 Sep 2017 15:05:23 +0000 (10:05 -0500)
Change-Id: If3ab0d73d79ac4623308bd48508af2bfd554937d

res/res_pjsip_messaging.c
res/res_pjsip_publish_asterisk.c
res/res_pjsip_pubsub.c
res/res_pjsip_session.c

index d31e101..b6e7a64 100644 (file)
@@ -69,8 +69,8 @@ static enum pjsip_status_code check_content_type(const pjsip_rx_data *rdata)
                        &rdata->msg_info.msg->body->content_type, "text", "plain");
        } else {
                res = rdata->msg_info.ctype &&
-                       !pj_strcmp2(&rdata->msg_info.ctype->media.type, "text") &&
-                       !pj_strcmp2(&rdata->msg_info.ctype->media.subtype, "plain");
+                       ast_sip_is_content_type(
+                               &rdata->msg_info.ctype->media, "text", "plain");
        }
 
        return res ? PJSIP_SC_OK : PJSIP_SC_UNSUPPORTED_MEDIA_TYPE;
index 7e87762..fa5e4ce 100644 (file)
@@ -605,8 +605,7 @@ static int asterisk_publication_devicestate_state_change(struct ast_sip_publicat
        }
 
        /* We only accept JSON for content */
-       if (pj_strcmp2(&body->content_type.type, "application") ||
-               pj_strcmp2(&body->content_type.subtype, "json")) {
+       if (!ast_sip_is_content_type(&body->content_type, "application", "json")) {
                ast_debug(2, "Received unsupported content type for Asterisk event on resource '%s'\n",
                        ast_sorcery_object_get_id(config));
                return -1;
@@ -697,8 +696,7 @@ static int asterisk_publication_mwi_state_change(struct ast_sip_publication *pub
        }
 
        /* We only accept JSON for content */
-       if (pj_strcmp2(&body->content_type.type, "application") ||
-               pj_strcmp2(&body->content_type.subtype, "json")) {
+       if (!ast_sip_is_content_type(&body->content_type, "application", "json")) {
                ast_debug(2, "Received unsupported content type for Asterisk event on resource '%s'\n",
                        ast_sorcery_object_get_id(config));
                return -1;
index b0365d9..bcf8677 100644 (file)
@@ -516,6 +516,8 @@ AST_RWLIST_HEAD_STATIC(subscriptions, sip_subscription_tree);
 AST_RWLIST_HEAD_STATIC(body_generators, ast_sip_pubsub_body_generator);
 AST_RWLIST_HEAD_STATIC(body_supplements, ast_sip_pubsub_body_supplement);
 
+static pjsip_media_type rlmi_media_type;
+
 static void pubsub_on_evsub_state(pjsip_evsub *sub, pjsip_event *event);
 static void pubsub_on_rx_refresh(pjsip_evsub *sub, pjsip_rx_data *rdata,
                int *p_st_code, pj_str_t **p_st_text, pjsip_hdr *res_hdr, pjsip_msg_body **p_body);
@@ -2022,8 +2024,6 @@ static void *rlmi_clone_data(pj_pool_t *pool, const void *data, unsigned len)
 static pjsip_multipart_part *build_rlmi_body(pj_pool_t *pool, struct ast_sip_subscription *sub,
                struct body_part_list *body_parts, unsigned int full_state)
 {
-       static const pj_str_t rlmi_type = { "application", 11 };
-       static const pj_str_t rlmi_subtype = { "rlmi+xml", 8 };
        pj_xml_node *rlmi;
        pj_xml_node *name;
        pjsip_multipart_part *rlmi_part;
@@ -2054,9 +2054,7 @@ static pjsip_multipart_part *build_rlmi_body(pj_pool_t *pool, struct ast_sip_sub
        rlmi_part = pjsip_multipart_create_part(pool);
 
        rlmi_part->body = PJ_POOL_ZALLOC_T(pool, pjsip_msg_body);
-       pj_strdup(pool, &rlmi_part->body->content_type.type, &rlmi_type);
-       pj_strdup(pool, &rlmi_part->body->content_type.subtype, &rlmi_subtype);
-       pj_list_init(&rlmi_part->body->content_type.param);
+       pjsip_media_type_cp(pool, &rlmi_part->body->content_type, &rlmi_media_type);
 
        rlmi_part->body->data = pj_xml_clone(pool, rlmi);
        rlmi_part->body->clone_data = rlmi_clone_data;
@@ -3524,12 +3522,11 @@ error:
        return PJ_TRUE;
 }
 
-static pjsip_media_type simple_message_summary;
-
 static pj_bool_t pubsub_on_rx_notify_request(pjsip_rx_data *rdata)
 {
        if (rdata->msg_info.msg->body &&
-               pjsip_media_type_cmp(&rdata->msg_info.msg->body->content_type, &simple_message_summary, 0) == 0) {
+               ast_sip_is_content_type(&rdata->msg_info.msg->body->content_type,
+                                                               "application", "simple-message-summary")) {
                return pubsub_on_rx_mwi_notify_request(rdata);
        }
        return PJ_FALSE;
@@ -5365,7 +5362,7 @@ static int load_module(void)
                return AST_MODULE_LOAD_DECLINE;
        }
 
-       pjsip_media_type_init2(&simple_message_summary, "application", "simple-message-summary");
+       pjsip_media_type_init2(&rlmi_media_type, "application", "rlmi+xml");
 
        if (ast_sched_start_thread(sched)) {
                ast_log(LOG_ERROR, "Could not start scheduler thread for publication expiration\n");
index 163c2b8..c6ea446 100644 (file)
@@ -3979,8 +3979,9 @@ static void session_outgoing_nat_hook(pjsip_tx_data *tdata, struct ast_sip_trans
        int stream;
 
        /* SDP produced by us directly will never be multipart */
-       if (!transport_state || hook || !tdata->msg->body || pj_stricmp2(&tdata->msg->body->content_type.type, "application") ||
-               pj_stricmp2(&tdata->msg->body->content_type.subtype, "sdp") || ast_strlen_zero(transport->external_media_address)) {
+       if (!transport_state || hook || !tdata->msg->body ||
+               !ast_sip_is_content_type(&tdata->msg->body->content_type, "application", "sdp") ||
+               ast_strlen_zero(transport->external_media_address)) {
                return;
        }