MixMonitor: Don't use ast_strdupa() in a loop.
authorRichard Mudgett <rmudgett@digium.com>
Tue, 2 Jul 2013 21:13:56 +0000 (21:13 +0000)
committerRichard Mudgett <rmudgett@digium.com>
Tue, 2 Jul 2013 21:13:56 +0000 (21:13 +0000)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@393494 65c4cc65-6c06-0410-ace0-fbb531ad65f3

apps/app_mixmonitor.c

index 76c72a7..3f7560e 100644 (file)
@@ -1155,13 +1155,17 @@ static char *handle_cli_mixmonitor(struct ast_cli_entry *e, int cmd, struct ast_
                                char *filename = "";
                                char *filename_read = "";
                                char *filename_write = "";
+
                                mixmonitor_ds = datastore->data;
-                               if (mixmonitor_ds->fs)
-                                       filename = ast_strdupa(mixmonitor_ds->fs->filename);
-                               if (mixmonitor_ds->fs_read)
-                                       filename_read = ast_strdupa(mixmonitor_ds->fs_read->filename);
-                               if (mixmonitor_ds->fs_write)
-                                       filename_write = ast_strdupa(mixmonitor_ds->fs_write->filename);
+                               if (mixmonitor_ds->fs) {
+                                       filename = mixmonitor_ds->fs->filename;
+                               }
+                               if (mixmonitor_ds->fs_read) {
+                                       filename_read = mixmonitor_ds->fs_read->filename;
+                               }
+                               if (mixmonitor_ds->fs_write) {
+                                       filename_write = mixmonitor_ds->fs_write->filename;
+                               }
                                ast_cli(a->fd, "%p\t%s\t%s\t%s\n", mixmonitor_ds, filename, filename_read, filename_write);
                        }
                }