Merged revisions 140747 via svnmerge from
authorSteve Murphy <murf@digium.com>
Tue, 2 Sep 2008 23:44:04 +0000 (23:44 +0000)
committerSteve Murphy <murf@digium.com>
Tue, 2 Sep 2008 23:44:04 +0000 (23:44 +0000)
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r140747 | murf | 2008-09-02 17:36:56 -0600 (Tue, 02 Sep 2008) | 1 line

I am turning the warnings generated in ast_cdr_free and post_cdr into verbose level 2 messages. Really, they matter little to end users. You either get the CDR's you wanted, or you don't, and it is a bug.

For trunk, I am going one step further. These messages were pretty worthless even for debug, so I'm completely removing them.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@140749 65c4cc65-6c06-0410-ace0-fbb531ad65f3

main/cdr.c

index 111c3da..b977362 100644 (file)
@@ -431,13 +431,6 @@ void ast_cdr_free(struct ast_cdr *cdr)
 
        while (cdr) {
                struct ast_cdr *next = cdr->next;
 
        while (cdr) {
                struct ast_cdr *next = cdr->next;
-               char *chan = S_OR(cdr->channel, "<unknown>");
-               if (!ast_test_flag(cdr, AST_CDR_FLAG_POSTED) && !ast_test_flag(cdr, AST_CDR_FLAG_POST_DISABLED))
-                       ast_log(LOG_NOTICE, "CDR on channel '%s' not posted\n", chan);
-               if (ast_tvzero(cdr->end))
-                       ast_log(LOG_NOTICE, "CDR on channel '%s' lacks end\n", chan);
-               if (ast_tvzero(cdr->start))
-                       ast_log(LOG_NOTICE, "CDR on channel '%s' lacks start\n", chan);
 
                ast_cdr_free_vars(cdr, 0);
                ast_free(cdr);
 
                ast_cdr_free_vars(cdr, 0);
                ast_free(cdr);
@@ -1020,10 +1013,6 @@ static void post_cdr(struct ast_cdr *cdr)
 
                chan = S_OR(cdr->channel, "<unknown>");
                check_post(cdr);
 
                chan = S_OR(cdr->channel, "<unknown>");
                check_post(cdr);
-               if (ast_tvzero(cdr->end))
-                       ast_log(LOG_WARNING, "CDR on channel '%s' lacks end\n", chan);
-               if (ast_tvzero(cdr->start))
-                       ast_log(LOG_WARNING, "CDR on channel '%s' lacks start\n", chan);
                ast_set_flag(cdr, AST_CDR_FLAG_POSTED);
                if (ast_test_flag(cdr, AST_CDR_FLAG_POST_DISABLED))
                        continue;
                ast_set_flag(cdr, AST_CDR_FLAG_POSTED);
                if (ast_test_flag(cdr, AST_CDR_FLAG_POST_DISABLED))
                        continue;