Remove unnecessary repetition checks from res_pjsip_exten_state
authorMark Michelson <mmichelson@digium.com>
Thu, 1 May 2014 15:47:49 +0000 (15:47 +0000)
committerMark Michelson <mmichelson@digium.com>
Thu, 1 May 2014 15:47:49 +0000 (15:47 +0000)
The PBX core already takes care of ensuring that repeated state changes
are not communicated to exten state consumers. Because the check in res_pjsip_exten_state
was incomplete, it was causing valid presence state changes not to be sent out. For instance,
if the presence state did not change but the message or subtype did, then no presence-related
NOTIFY request would be sent out.

closes issue ASTERISK-23672
Reported by Mark Michelson
........

Merged revisions 413173 from http://svn.asterisk.org/svn/asterisk/branches/12

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@413174 65c4cc65-6c06-0410-ace0-fbb531ad65f3

res/res_pjsip_exten_state.c

index 7742de4..7a90679 100644 (file)
@@ -334,11 +334,6 @@ static int state_changed(char *context, char *exten,
        struct notify_task_data *task_data;
        struct exten_state_subscription *exten_state_sub = data;
 
-       if (exten_state_sub->last_exten_state == info->exten_state &&
-               exten_state_sub->last_presence_state == info->presence_state) {
-               return 0;
-       }
-
        if (!(task_data = alloc_notify_task_data(exten, exten_state_sub, info))) {
                return -1;
        }