Fix CALLERID() values for sig_pri on incoming calls.
authorRichard Mudgett <rmudgett@digium.com>
Tue, 4 Aug 2009 17:46:03 +0000 (17:46 +0000)
committerRichard Mudgett <rmudgett@digium.com>
Tue, 4 Aug 2009 17:46:03 +0000 (17:46 +0000)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@210387 65c4cc65-6c06-0410-ace0-fbb531ad65f3

channels/chan_dahdi.c
channels/sig_pri.c
channels/sig_pri.h

index fd08b14..c207fa5 100644 (file)
@@ -2563,6 +2563,62 @@ static int my_pri_play_tone(void *pvt, enum sig_pri_tone tone)
        return tone_zone_play_tone(p->subs[SUB_REAL].dfd, sig_pri_tone_to_dahditone(tone));
 }
 
+/*!
+ * \internal
+ * \brief Set the caller id information.
+ * \since 1.6.3
+ *
+ * \param pvt DAHDI private structure
+ * \param caller Caller-id information to set.
+ *
+ * \return Nothing
+ */
+static void my_pri_set_callerid(void *pvt, const struct ast_party_caller *caller)
+{
+       struct dahdi_pvt *p = pvt;
+
+       ast_copy_string(p->cid_num, S_OR(caller->id.number, ""), sizeof(p->cid_num));
+       ast_copy_string(p->cid_name, S_OR(caller->id.name, ""), sizeof(p->cid_name));
+       p->cid_ton = caller->id.number_type;
+       p->callingpres = caller->id.number_presentation;
+       ast_copy_string(p->cid_ani, S_OR(caller->ani, ""), sizeof(p->cid_ani));
+       p->cid_ani2 = caller->ani2;
+}
+
+/*!
+ * \internal
+ * \brief Set the Dialed Number Identifier.
+ * \since 1.6.3
+ *
+ * \param pvt DAHDI private structure
+ * \param dnid Dialed Number Identifier string.
+ *
+ * \return Nothing
+ */
+static void my_pri_set_dnid(void *pvt, const char *dnid)
+{
+       struct dahdi_pvt *p = pvt;
+
+       ast_copy_string(p->dnid, dnid, sizeof(p->dnid));
+}
+
+/*!
+ * \internal
+ * \brief Set the Redirecting Directory Number Information Service (RDNIS).
+ * \since 1.6.3
+ *
+ * \param pvt DAHDI private structure
+ * \param rdnis Redirecting Directory Number Information Service (RDNIS) string.
+ *
+ * \return Nothing
+ */
+static void my_pri_set_rdnis(void *pvt, const char *rdnis)
+{
+       struct dahdi_pvt *p = pvt;
+
+       ast_copy_string(p->rdnis, rdnis, sizeof(p->rdnis));
+}
+
 static struct sig_pri_callback dahdi_pri_callbacks =
 {
        .handle_dchan_exception = my_handle_dchan_exception,
@@ -2573,6 +2629,9 @@ static struct sig_pri_callback dahdi_pri_callbacks =
        .new_ast_channel = my_new_pri_ast_channel,
        .fixup_chans = my_pri_fixup_chans,
        .set_dialing = my_set_dialing,
+       .set_callerid = my_pri_set_callerid,
+       .set_dnid = my_pri_set_dnid,
+       .set_rdnis = my_pri_set_rdnis,
 };
 #endif /* defined(HAVE_PRI) */
 
index edd8693..012d21f 100644 (file)
@@ -97,7 +97,66 @@ static void sig_pri_handle_dchan_exception(struct sig_pri_pri *pri, int index)
 static void sig_pri_set_dialing(struct sig_pri_chan *p, int flag)
 {
        if (p->calls->set_dialing)
-               p->calls->set_dialing(p, flag);
+               p->calls->set_dialing(p->chan_pvt, flag);
+}
+
+/*!
+ * \internal
+ * \brief Set the caller id information in the parent module.
+ * \since 1.6.3
+ *
+ * \param p sig_pri channel structure.
+ *
+ * \return Nothing
+ */
+static void sig_pri_set_caller_id(struct sig_pri_chan *p)
+{
+       struct ast_party_caller caller;
+
+       if (p->calls->set_callerid) {
+               ast_party_caller_init(&caller);
+               caller.id.number = p->cid_num;
+               caller.id.name = p->cid_name;
+               caller.id.number_type = p->cid_ton;
+               caller.id.number_presentation = p->callingpres;
+               caller.ani = p->cid_ani;
+               caller.ani2 = p->cid_ani2;
+               p->calls->set_callerid(p->chan_pvt, &caller);
+       }
+}
+
+/*!
+ * \internal
+ * \brief Set the Dialed Number Identifier.
+ * \since 1.6.3
+ *
+ * \param p sig_pri channel structure.
+ * \param dnid Dialed Number Identifier string.
+ *
+ * \return Nothing
+ */
+static void sig_pri_set_dnid(struct sig_pri_chan *p, const char *dnid)
+{
+       if (p->calls->set_dnid) {
+               p->calls->set_dnid(p->chan_pvt, dnid);
+       }
+}
+
+/*!
+ * \internal
+ * \brief Set the Redirecting Directory Number Information Service (RDNIS).
+ * \since 1.6.3
+ *
+ * \param p sig_pri channel structure.
+ * \param rdnis Redirecting Directory Number Information Service (RDNIS) string.
+ *
+ * \return Nothing
+ */
+static void sig_pri_set_rdnis(struct sig_pri_chan *p, const char *rdnis)
+{
+       if (p->calls->set_rdnis) {
+               p->calls->set_rdnis(p->chan_pvt, rdnis);
+       }
 }
 
 static void sig_pri_unlock_private(struct sig_pri_chan *p)
@@ -638,8 +697,8 @@ static void *pri_dchannel(void *vpri)
        pthread_t threadid;
        pthread_attr_t attr;
        char ani2str[6];
-       char plancallingnum[256];
-       char plancallingani[256];
+       char plancallingnum[AST_MAX_EXTENSION];
+       char plancallingani[AST_MAX_EXTENSION];
        char calledtonstr[10];
        struct timeval lastidle = { 0, 0 };
        pthread_t p;
@@ -944,7 +1003,9 @@ static void *pri_dchannel(void *vpri)
                                        if (chanpos > -1) {
                                                sig_pri_lock_private(pri->pvts[chanpos]);
                                                /* queue DTMF frame if the PBX for this call was already started (we're forwarding KEYPAD_DIGITs further on */
-                                               if ((pri->overlapdial & DAHDI_OVERLAPDIAL_INCOMING) && pri->pvts[chanpos]->call==e->digit.call && pri->pvts[chanpos]->owner) {
+                                               if ((pri->overlapdial & DAHDI_OVERLAPDIAL_INCOMING)
+                                                       && pri->pvts[chanpos]->call == e->digit.call
+                                                       && pri->pvts[chanpos]->owner) {
                                                        /* how to do that */
                                                        int digitlen = strlen(e->digit.digits);
                                                        char digit;
@@ -972,7 +1033,9 @@ static void *pri_dchannel(void *vpri)
                                        if (chanpos > -1) {
                                                sig_pri_lock_private(pri->pvts[chanpos]);
                                                /* queue DTMF frame if the PBX for this call was already started (we're forwarding INFORMATION further on */
-                                               if ((pri->overlapdial & DAHDI_OVERLAPDIAL_INCOMING) && pri->pvts[chanpos]->call==e->ring.call && pri->pvts[chanpos]->owner) {
+                                               if ((pri->overlapdial & DAHDI_OVERLAPDIAL_INCOMING)
+                                                       && pri->pvts[chanpos]->call == e->ring.call
+                                                       && pri->pvts[chanpos]->owner) {
                                                        /* how to do that */
                                                        int digitlen = strlen(e->ring.callednum);
                                                        char digit;
@@ -1078,7 +1141,15 @@ static void *pri_dchannel(void *vpri)
                                if (chanpos > -1) {
                                        sig_pri_lock_private(pri->pvts[chanpos]);
                                        pri->pvts[chanpos]->call = e->ring.call;
+
+                                       /* Use plancallingnum as a scratch buffer since it is initialized next. */
+                                       apply_plan_to_number(plancallingnum, sizeof(plancallingnum), pri,
+                                               e->ring.redirectingnum, e->ring.callingplanrdnis);
+                                       sig_pri_set_rdnis(pri->pvts[chanpos], plancallingnum);
+
+                                       /* Setup caller-id info */
                                        apply_plan_to_number(plancallingnum, sizeof(plancallingnum), pri, e->ring.callingnum, e->ring.callingplan);
+                                       pri->pvts[chanpos]->cid_ani2 = 0;
                                        if (pri->pvts[chanpos]->use_callerid) {
                                                ast_shrink_phone_number(plancallingnum);
                                                ast_copy_string(pri->pvts[chanpos]->cid_num, plancallingnum, sizeof(pri->pvts[chanpos]->cid_num));
@@ -1093,14 +1164,22 @@ static void *pri_dchannel(void *vpri)
 #endif
                                                ast_copy_string(pri->pvts[chanpos]->cid_name, e->ring.callingname, sizeof(pri->pvts[chanpos]->cid_name));
                                                pri->pvts[chanpos]->cid_ton = e->ring.callingplan; /* this is the callingplan (TON/NPI), e->ring.callingplan>>4 would be the TON */
+                                               pri->pvts[chanpos]->callingpres = e->ring.callingpres;
+                                               if (e->ring.ani2 >= 0) {
+                                                       pri->pvts[chanpos]->cid_ani2 = e->ring.ani2;
+                                               }
                                        } else {
                                                pri->pvts[chanpos]->cid_num[0] = '\0';
                                                pri->pvts[chanpos]->cid_ani[0] = '\0';
                                                pri->pvts[chanpos]->cid_name[0] = '\0';
                                                pri->pvts[chanpos]->cid_ton = 0;
+                                               pri->pvts[chanpos]->callingpres = 0;
                                        }
-                                       apply_plan_to_number(pri->pvts[chanpos]->rdnis, sizeof(pri->pvts[chanpos]->rdnis), pri,
-                                               e->ring.redirectingnum, e->ring.callingplanrdnis);
+                                       sig_pri_set_caller_id(pri->pvts[chanpos]);
+
+                                       /* Set DNID on all incoming calls -- even immediate */
+                                       sig_pri_set_dnid(pri->pvts[chanpos], e->ring.callednum);
+
                                        /* If immediate=yes go to s|1 */
                                        if (pri->pvts[chanpos]->immediate) {
                                                ast_verb(3, "Going to extension s|1 because of immediate=yes\n");
@@ -1110,7 +1189,6 @@ static void *pri_dchannel(void *vpri)
                                        /* Get called number */
                                        else if (!ast_strlen_zero(e->ring.callednum)) {
                                                ast_copy_string(pri->pvts[chanpos]->exten, e->ring.callednum, sizeof(pri->pvts[chanpos]->exten));
-                                               ast_copy_string(pri->pvts[chanpos]->dnid, e->ring.callednum, sizeof(pri->pvts[chanpos]->dnid));
                                        } else if (pri->overlapdial)
                                                pri->pvts[chanpos]->exten[0] = '\0';
                                        else {
@@ -1118,15 +1196,13 @@ static void *pri_dchannel(void *vpri)
                                                pri->pvts[chanpos]->exten[0] = 's';
                                                pri->pvts[chanpos]->exten[1] = '\0';
                                        }
-                                       /* Set DNID on all incoming calls -- even immediate */
-                                       if (!ast_strlen_zero(e->ring.callednum))
-                                               ast_copy_string(pri->pvts[chanpos]->dnid, e->ring.callednum, sizeof(pri->pvts[chanpos]->dnid));
                                        /* No number yet, but received "sending complete"? */
                                        if (e->ring.complete && (ast_strlen_zero(e->ring.callednum))) {
                                                ast_verb(3, "Going to extension s|1 because of Complete received\n");
                                                pri->pvts[chanpos]->exten[0] = 's';
                                                pri->pvts[chanpos]->exten[1] = '\0';
                                        }
+
                                        /* Make sure extension exists (or in overlap dial mode, can exist) */
                                        if (((pri->overlapdial & DAHDI_OVERLAPDIAL_INCOMING) && ast_canmatch_extension(NULL, pri->pvts[chanpos]->context, pri->pvts[chanpos]->exten, 1, pri->pvts[chanpos]->cid_num)) ||
                                                ast_exists_extension(NULL, pri->pvts[chanpos]->context, pri->pvts[chanpos]->exten, 1, pri->pvts[chanpos]->cid_num)) {
@@ -1141,12 +1217,15 @@ static void *pri_dchannel(void *vpri)
                                                        else
                                                                pri_answer(pri->pri, e->ring.call, PVT_TO_CHANNEL(pri->pvts[chanpos]), 1);
                                                }
-                                               /* Get the use_callingpres state */
-                                               pri->pvts[chanpos]->callingpres = e->ring.callingpres;
 
                                                /* Start PBX */
-                                               if (!e->ring.complete && (pri->overlapdial & DAHDI_OVERLAPDIAL_INCOMING) && ast_matchmore_extension(NULL, pri->pvts[chanpos]->context, pri->pvts[chanpos]->exten, 1, pri->pvts[chanpos]->cid_num)) {
-                                                       /* Release the PRI lock while we create the channel */
+                                               if (!e->ring.complete
+                                                       && (pri->overlapdial & DAHDI_OVERLAPDIAL_INCOMING)
+                                                       && ast_matchmore_extension(NULL, pri->pvts[chanpos]->context, pri->pvts[chanpos]->exten, 1, pri->pvts[chanpos]->cid_num)) {
+                                                       /*
+                                                        * Release the PRI lock while we create the channel
+                                                        * so other threads can send D channel messages.
+                                                        */
                                                        ast_mutex_unlock(&pri->lock);
 
                                                        c = sig_pri_new_ast_channel(pri->pvts[chanpos], AST_STATE_RESERVED, 0, (e->ring.layer1 = PRI_LAYER_1_ALAW) ? SIG_PRI_ALAW : SIG_PRI_ULAW, e->ring.ctype, pri->pvts[chanpos]->exten, NULL);
@@ -1157,9 +1236,8 @@ static void *pri_dchannel(void *vpri)
                                                                pbx_builtin_setvar_helper(c, "CALLINGSUBADDR", e->ring.callingsubaddr);
                                                        }
                                                        if (e->ring.ani2 >= 0) {
-                                                               snprintf(ani2str, 5, "%.2d", e->ring.ani2);
+                                                               snprintf(ani2str, sizeof(ani2str), "%d", e->ring.ani2);
                                                                pbx_builtin_setvar_helper(c, "ANI2", ani2str);
-                                                               pri->pvts[chanpos]->cid_ani2 = e->ring.ani2;
                                                        }
 
 #ifdef SUPPORT_USERUSER
@@ -1168,7 +1246,7 @@ static void *pri_dchannel(void *vpri)
                                                        }
 #endif
 
-                                                       snprintf(calledtonstr, sizeof(calledtonstr)-1, "%d", e->ring.calledplan);
+                                                       snprintf(calledtonstr, sizeof(calledtonstr), "%d", e->ring.calledplan);
                                                        pbx_builtin_setvar_helper(c, "CALLEDTON", calledtonstr);
                                                        if (e->ring.redirectingreason >= 0)
                                                                pbx_builtin_setvar_helper(c, "PRIREDIRECTREASON", redirectingreason2str(e->ring.redirectingreason));
@@ -1197,19 +1275,19 @@ static void *pri_dchannel(void *vpri)
                                                        }
                                                        pthread_attr_destroy(&attr);
                                                } else {
+                                                       /*
+                                                        * Release the PRI lock while we create the channel
+                                                        * so other threads can send D channel messages.
+                                                        */
                                                        ast_mutex_unlock(&pri->lock);
-                                                       /* Release PRI lock while we create the channel */
                                                        c = sig_pri_new_ast_channel(pri->pvts[chanpos], AST_STATE_RING, 1, (e->ring.layer1 == PRI_LAYER_1_ALAW) ? SIG_PRI_ALAW : SIG_PRI_ULAW, e->ring.ctype, pri->pvts[chanpos]->exten, NULL);
 
                                                        if (c) {
-                                                               char calledtonstr[10];
-
                                                                sig_pri_unlock_private(pri->pvts[chanpos]);
 
                                                                if (e->ring.ani2 >= 0) {
-                                                                       snprintf(ani2str, 5, "%d", e->ring.ani2);
+                                                                       snprintf(ani2str, sizeof(ani2str), "%d", e->ring.ani2);
                                                                        pbx_builtin_setvar_helper(c, "ANI2", ani2str);
-                                                                       pri->pvts[chanpos]->cid_ani2 = e->ring.ani2;
                                                                }
 
 #ifdef SUPPORT_USERUSER
@@ -1224,7 +1302,7 @@ static void *pri_dchannel(void *vpri)
                                                                pri->pvts[chanpos]->reverse_charging_indication = e->ring.reversecharge;
 #endif
 
-                                                               snprintf(calledtonstr, sizeof(calledtonstr)-1, "%d", e->ring.calledplan);
+                                                               snprintf(calledtonstr, sizeof(calledtonstr), "%d", e->ring.calledplan);
                                                                pbx_builtin_setvar_helper(c, "CALLEDTON", calledtonstr);
 
                                                                sig_pri_lock_private(pri->pvts[chanpos]);
@@ -1711,7 +1789,6 @@ int sig_pri_hangup(struct sig_pri_chan *p, struct ast_channel *ast)
        p->progress = 0;
        p->alerting = 0;
        p->setup_ack = 0;
-       p->rdnis[0] = '\0';
        p->exten[0] = '\0';
        sig_pri_set_dialing(p, 0);
 
index ebf84e5..e2f0ef1 100644 (file)
@@ -71,6 +71,9 @@ struct sig_pri_callback {
        /* Note: Called with PRI lock held */
        void (* const handle_dchan_exception)(struct sig_pri_pri *pri, int index);
        void (* const set_dialing)(void *pvt, int flag);
+       void (* const set_callerid)(void *pvt, const struct ast_party_caller *caller);
+       void (* const set_dnid)(void *pvt, const char *dnid);
+       void (* const set_rdnis)(void *pvt, const char *rdnis);
 };
 
 #define NUM_DCHANS             4       /*!< No more than 4 d-channels */
@@ -123,16 +126,14 @@ struct sig_pri_chan {
        char mohinterpret[MAX_MUSICCLASS];
        int stripmsd;
 
-       /* Options to be  checked by user */
+       /* Options to be checked by user */
        int cid_ani2;                                           /*!< Automatic Number Identification number (Alternate PRI caller ID number) */
-       char cid_num[AST_MAX_EXTENSION];
        int cid_ton;                                    /*!< Type Of Number (TON) */
+       int callingpres;                                /*!< The value of calling presentation that we're going to use when placing a PRI call */
+       char cid_num[AST_MAX_EXTENSION];
        char cid_name[AST_MAX_EXTENSION];
        char cid_ani[AST_MAX_EXTENSION];
-       char rdnis[AST_MAX_EXTENSION];
-       char dnid[AST_MAX_EXTENSION];
        char exten[AST_MAX_EXTENSION];
-       int callingpres;                                /*!< The value of calling presentation that we're going to use when placing a PRI call */
        char lastcid_num[AST_MAX_EXTENSION];
        char lastcid_name[AST_MAX_EXTENSION];
 
@@ -161,7 +162,7 @@ struct sig_pri_chan {
        int mastertrunkgroup;                   /*!< what trunk group is our master */
 
        struct sig_pri_callback *calls;
-       void *chan_pvt;
+       void *chan_pvt;                                 /*!< Private structure of the user of this module. */
        ast_mutex_t service_lock;                                               /*!< Mutex for service messages */
 #if defined(HAVE_PRI_REVERSE_CHARGE)
        int reverse_charging_indication;
@@ -214,7 +215,7 @@ struct sig_pri_pri {
        int numchans;                                                           /*!< Num of channels we represent */
        struct sig_pri_chan *pvts[MAX_CHANNELS];        /*!< Member channel pvt structs */
        pthread_t master;                                                       /*!< Thread of master */
-       ast_mutex_t lock;                                                       /*!< Mutex */
+       ast_mutex_t lock;                                                       /*!< libpri access Mutex */
        time_t lastreset;                                                       /*!< time when unused channels were last reset */
        struct sig_pri_callback *calls;
 };