Sean Bright [Mon, 1 Dec 2008 23:08:24 +0000 (23:08 +0000)]
Pay attention to the return value of system(), even if we basically ignore it.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@160170
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Mon, 1 Dec 2008 21:23:37 +0000 (21:23 +0000)]
Use AST_EXT_LIB_SETUP before using AST_EXT_LIB_CHECK or bad things happen.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@160097
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Eliel C. Sardanons [Mon, 1 Dec 2008 18:52:14 +0000 (18:52 +0000)]
Introduce CLI permissions.
Based on cli_permissions.conf configuration file, we are able to permit or deny
cli commands based on some patterns and the local user and group running rasterisk.
(Sorry if I missed some of the testers).
Reviewboard: http://reviewboard.digium.com/r/11/
(closes issue #11123)
Reported by: eliel
Tested by: eliel, IgorG, Laureano, otherwiseguy, mvanbaak
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@160062
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Mon, 1 Dec 2008 17:34:31 +0000 (17:34 +0000)]
Merged revisions 160003 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r160003 | russell | 2008-12-01 11:27:30 -0600 (Mon, 01 Dec 2008) | 6 lines
Apply some logic used in iax2_indicate() to iax2_setoption(), as well, since they
both have the potential to send control frames in the middle of call setup. We
have to wait until we have received a message back from the remote end before
we try to send any more frames. Otherwise, the remote end will consider it
invalid, and we'll get stuck in an INVAL/VNAK storm.
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@160004
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Mon, 1 Dec 2008 14:56:10 +0000 (14:56 +0000)]
Merged revisions 159900 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r159900 | russell | 2008-12-01 08:52:56 -0600 (Mon, 01 Dec 2008) | 2 lines
Force a "make clean" to avoid a bizarre build issue ...
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@159911
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Michiel van Baak [Mon, 1 Dec 2008 14:09:59 +0000 (14:09 +0000)]
Merged revisions 159897 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r159897 | mvanbaak | 2008-12-01 15:05:41 +0100 (Mon, 01 Dec 2008) | 4 lines
make manager compile on OpenBSD.
The last (10th) argument to ast_channel_alloc here should be a pointer
and NULL is not really a pointer.
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@159898
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Sat, 29 Nov 2008 18:33:18 +0000 (18:33 +0000)]
Allow the '#' sign to exist within an extension (inspired by issue #13330)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@159853
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Kevin P. Fleming [Sat, 29 Nov 2008 17:57:39 +0000 (17:57 +0000)]
incorporates r159808 from branches/1.4:
------------------------------------------------------------------------
r159808 | kpfleming | 2008-11-29 10:58:29 -0600 (Sat, 29 Nov 2008) | 7 lines
update dev-mode compiler flags to match the ones used by default on Ubuntu Intrepid, so all developers will see the same warnings and errors
since this branch already had some printf format attributes, enable checking for them and tag functions that didn't have them
format attributes in a consistent way
------------------------------------------------------------------------
in addition:
move some format attributes from main/utils.c to the header files they belong in, and fix up references to the relevant functions based on new compiler warnings
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@159818
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Kevin P. Fleming [Sat, 29 Nov 2008 15:29:33 +0000 (15:29 +0000)]
we can now build with -Wformat=2, which found a couple of real bugs
because SPRINTF() use non-literal format strings (which cannot be checked), move it into its own module so the rest of func_strings can benefit from format string checking
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@159774
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Michiel van Baak [Fri, 28 Nov 2008 14:20:11 +0000 (14:20 +0000)]
Make res_config_ldap compile with the official OpenLDAP 2.3.X versions.
They removed the LDAP_DEPRECATED define from their source and since we are using a couple
of deprecated function calls we should define it with a CFLAG.
Tested by me on OpenBSD 4.4 and snuff-home on Linux to make sure everything keeps compiling.
It shouldn't break, we only define the LDAP_DEPRECATED with this which is what
all 2.2.X and older versions of OpenLDAP did in their own tree.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@159734
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Philippe Sultan [Thu, 27 Nov 2008 20:29:21 +0000 (20:29 +0000)]
Removed duplicate code
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@159701
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Wed, 26 Nov 2008 22:11:55 +0000 (22:11 +0000)]
Make a formatting change to test a new post-commit hook for reviewboard.
http://reviewboard.digium.com/r/65/
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@159666
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Wed, 26 Nov 2008 22:08:33 +0000 (22:08 +0000)]
Make a formatting change to test a new post-commit hook for reviewboard.
http://reviewboard.digium.com/r/65/
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@159665
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Wed, 26 Nov 2008 22:01:34 +0000 (22:01 +0000)]
Make a formatting change to test a new post-commit hook for reviewboard.
http://reviewboard.digium.com/r/65/
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@159664
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Kevin P. Fleming [Wed, 26 Nov 2008 21:20:50 +0000 (21:20 +0000)]
improve handling of API calls provided by loaded modules through use of some GCC features; this makes app_stack's usage of AGI APIs even cleaner, and will allow it to work 'as expected' either with or without res_agi being loaded
reviewed at http://reviewboard.digium.com/r/62
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@159631
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Kevin P. Fleming [Wed, 26 Nov 2008 21:09:58 +0000 (21:09 +0000)]
add support for event suppression for AMI-over-HTTP
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@159629
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Kevin P. Fleming [Wed, 26 Nov 2008 20:35:14 +0000 (20:35 +0000)]
Blocked revisions 159571 via svnmerge
........
r159571 | kpfleming | 2008-11-26 14:21:04 -0600 (Wed, 26 Nov 2008) | 2 lines
rename these files so as to avoid conflicts when users update their working copies and have unversioned files already in place
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@159573
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Mark Michelson [Wed, 26 Nov 2008 19:57:11 +0000 (19:57 +0000)]
Add some necessary hangup commands in the case that forwarding
a call fails
1) Hang up the original destination if the local channel cannot
be requested.
2) Hang up the local channel (in addition to the original destination)
if ast_call fails when calling the newly created local channel.
This prevents channels from sticking around forever in the
case of a botched call forward (e.g. to an extension which does not
exist).
(closes issue #13764)
Reported by: davidw
Patches:
13764_v2.patch uploaded by putnopvut (license 60)
Tested by: putnopvut, davidw
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@159554
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Kevin P. Fleming [Wed, 26 Nov 2008 19:08:56 +0000 (19:08 +0000)]
Merged revisions 159476 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r159476 | kpfleming | 2008-11-26 12:36:24 -0600 (Wed, 26 Nov 2008) | 7 lines
simplify (and slightly bug-fix) the recent developer-oriented COMPILE_DOUBLE mode
ensure that 'make clean' removes dependency files for .i files that are created in COMPILE_DOUBLE mode
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@159534
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Wed, 26 Nov 2008 18:33:04 +0000 (18:33 +0000)]
If the config file does not exist, then the first use crashes Asterisk.
(closes issue #13848)
Reported by: klaus3000
Patches:
udptl.c.patch uploaded by eliel (license 64)
Tested by: blitzrage
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@159475
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Mark Michelson [Wed, 26 Nov 2008 14:58:17 +0000 (14:58 +0000)]
Don't allow for configuration options to overwrite options
set via channel variables on a reload.
(closes issue #13921)
Reported by: davidw
Patches:
13921.patch uploaded by putnopvut (license 60)
Tested by: davidw
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@159437
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Jeff Peeler [Wed, 26 Nov 2008 03:18:01 +0000 (03:18 +0000)]
Always parse arguments in park_call_exec so that app_args is valid. This prevents a crash when executing Park from the dialplan with no arguments.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@159402
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Steve Murphy [Tue, 25 Nov 2008 23:03:01 +0000 (23:03 +0000)]
Merged revisions 159316 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r159316 | murf | 2008-11-25 15:41:10 -0700 (Tue, 25 Nov 2008) | 15 lines
(closes issue #12694)
Reported by: yraber
Patches:
12694.2nd.diff uploaded by murf (license 17)
Tested by: murf, laurav
Thanks to file (Joshua Colp) for his IAX fix.
the change to cdr.c allows no-answer to percolate
up into CDR's, and feels like the right place to
locate this fix; if BUSY is done here, no-answer
should be, too.
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@159360
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Tue, 25 Nov 2008 22:45:59 +0000 (22:45 +0000)]
Add an option, waitfordialtone, for UK analog lines which do not end a call
until the originating line hangs up.
(closes issue #12382)
Reported by: one47
Patches:
zap-waitfordialtone-trunk.080901.patch uploaded by one47 (license 23)
zap-waitfordialtone-bra-1.4.21.2.patch uploaded by fleed (license 463)
Tested by: fleed
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@159317
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Tue, 25 Nov 2008 21:57:59 +0000 (21:57 +0000)]
Merged revisions 159269 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r159269 | tilghman | 2008-11-25 15:56:48 -0600 (Tue, 25 Nov 2008) | 7 lines
Don't try to send a response on a NULL pvt.
(closes issue #13919)
Reported by: barthpbx
Patches:
chan_iax2.c.patch uploaded by eliel (license 64)
Tested by: barthpbx
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@159276
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Mark Michelson [Tue, 25 Nov 2008 21:49:42 +0000 (21:49 +0000)]
Make the options for the general and profiles more consistent
for the "pls_hold_prompt" option. This does not affect any released
version of Asterisk, so there is no need to update the CHANGES
file for this.
(closes issue #13893)
Reported by: eliel
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@159250
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Tue, 25 Nov 2008 21:42:42 +0000 (21:42 +0000)]
Merged revisions 159246 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
................
r159246 | tilghman | 2008-11-25 15:40:28 -0600 (Tue, 25 Nov 2008) | 14 lines
Merged revisions 159245 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2
........
r159245 | tilghman | 2008-11-25 15:37:06 -0600 (Tue, 25 Nov 2008) | 7 lines
Regression fix for last security fix. Set the iseqno correctly.
(closes issue #13918)
Reported by: ffloimair
Patches:
20081119__bug13918.diff.txt uploaded by Corydon76 (license 14)
Tested by: ffloimair
........
................
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@159247
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Tue, 25 Nov 2008 18:01:02 +0000 (18:01 +0000)]
Don't actually do anything with a negative priority, because we ignore it in
the result, anyway.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@159189
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Tue, 25 Nov 2008 17:44:30 +0000 (17:44 +0000)]
Don't limit the length of the hint at the final step (from ~8100 chars max
(or ~500 chars max on LOW_MEMORY) to 80 chars max). This will allow more
channels to be used in a single hint.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@159162
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Tue, 25 Nov 2008 17:35:33 +0000 (17:35 +0000)]
Blocked revisions 159158 via svnmerge
........
r159158 | russell | 2008-11-25 11:34:50 -0600 (Tue, 25 Nov 2008) | 2 lines
Add ao2_trylock() to go along with ao2_lock() and ao2_unlock()
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@159159
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Terry Wilson [Tue, 25 Nov 2008 16:18:53 +0000 (16:18 +0000)]
Add missing variable declaration for PPC code
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@159093
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Tue, 25 Nov 2008 05:19:53 +0000 (05:19 +0000)]
Copyright clarification; also, have variable set to "t" or "i" on timeout or
invalid extension, respectively.
(closes issue #13944)
Reported by: chappell
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@159054
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Tue, 25 Nov 2008 05:02:11 +0000 (05:02 +0000)]
Merged revisions 159025 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r159025 | tilghman | 2008-11-24 22:50:00 -0600 (Mon, 24 Nov 2008) | 3 lines
System call ioperm is non-portable, so check for its existence in autoconf.
(Closes issue #13863)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@159050
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Terry Wilson [Tue, 25 Nov 2008 03:49:30 +0000 (03:49 +0000)]
Make chan_usbradio compile under dev mode
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@158992
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Sean Bright [Tue, 25 Nov 2008 01:01:49 +0000 (01:01 +0000)]
This is basically a complete rollback of r155401, as it was determined that
it would be best to maintain API compatibility. Instead, this commit introduces
ao2_callback_data() which is functionally identical to ao2_callback() except
that it allows you to pass arbitrary data to the callback.
Reviewed by Mark Michelson via ReviewBoard:
http://reviewboard.digium.com/r/64
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@158959
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Matthew Nicholson [Tue, 25 Nov 2008 00:19:55 +0000 (00:19 +0000)]
Fix compiling in dev mode.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@158925
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Matthew Nicholson [Tue, 25 Nov 2008 00:05:41 +0000 (00:05 +0000)]
Make the Join event from app_queue use CallerIDNum insead of CallerID for
indicating the callerid number just like the rest of asterisk.
(closes issue #13883)
Reported by: davidw
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@158924
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Matthew Nicholson [Mon, 24 Nov 2008 21:56:22 +0000 (21:56 +0000)]
Added EVENT_FLAG_AGI and used it for manager calls in res_agi.c
(closes issue #13873)
Reported by: fnordian
Patches:
ami_agievent.patch uploaded by fnordian (license 110)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@158876
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Mon, 24 Nov 2008 21:52:34 +0000 (21:52 +0000)]
Add a bit of documentation (thanks, I-MOD) on what the silence threshold
constant actually does and what values are valid for it.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@158857
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Matthew Nicholson [Mon, 24 Nov 2008 21:27:26 +0000 (21:27 +0000)]
Make ast_streamfile() check the result of ast_openstream() before doing
anything with it.
(closes issue #13955)
Reported by: chris-mac
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@158851
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Terry Wilson [Mon, 24 Nov 2008 18:11:08 +0000 (18:11 +0000)]
This patch adds a new application for sending MWI to phones via Asterisk's event subsystem. Also, the minivm documentation is all converted to use xmldocs.
(closes issue #13946)
Reported by: Marquis
Patches:
minivmmwi_plus_xmldocs.patch uploaded by Marquis (license 32)
Tested by: otherwiseguy, Marquis
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@158808
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Sean Bright [Sun, 23 Nov 2008 03:36:52 +0000 (03:36 +0000)]
If you enabled 'notifycid' one of the limitations is that the calling channel
is only found if it dialed the extension that was subscribed to. You can now
specify 'ignore-context' for the 'notifycid' option in sip.conf which will, as
it's value implies, ignore the current context of the caller when doing the
lookup.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@158756
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Sean Bright [Sun, 23 Nov 2008 03:30:46 +0000 (03:30 +0000)]
No need to use a separate structure for this since we can just pass
our sip_pvt pointer in directly.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@158754
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Michiel van Baak [Sat, 22 Nov 2008 17:17:33 +0000 (17:17 +0000)]
last commit worked on OpenBSD but still generated warning on Ubuntu.
Initialise a variable so --enable-dev-mode does not complain
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@158723
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Michiel van Baak [Sat, 22 Nov 2008 16:57:11 +0000 (16:57 +0000)]
dont send reorder tone after a device is hungup if a dialout is abandoned or failed.
Without this reorder tone will play after hangup and both wedhorn's and my wife have threatened to use an axe on our asterisk box
(closes issue #13948)
Reported by: wedhorn
Patches:
switch.diff uploaded by wedhorn (license 30)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@158694
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Michiel van Baak [Sat, 22 Nov 2008 16:48:09 +0000 (16:48 +0000)]
Add Media Source Update to skinny's control2str
(issue #13948)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@158690
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Michiel van Baak [Sat, 22 Nov 2008 16:06:38 +0000 (16:06 +0000)]
fix a very occasional core dump in chan_skinny found by wedhorn.
(issue #13948)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@158688
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Michiel van Baak [Sat, 22 Nov 2008 15:58:49 +0000 (15:58 +0000)]
make this compile under devmode
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@158686
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Jeff Peeler [Sat, 22 Nov 2008 00:05:33 +0000 (00:05 +0000)]
Blocked revisions 158629 via svnmerge
........
r158629 | jpeeler | 2008-11-21 18:04:36 -0600 (Fri, 21 Nov 2008) | 5 lines
(closes issue #13786)
Reported by: tzafrir
When compiling against Zaptel dahdi_compat will now only define all the DAHDI defines if the Zaptel define is present. Also, there is no such thing as DAHDI_PRI.
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@158632
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Steve Murphy [Fri, 21 Nov 2008 23:40:46 +0000 (23:40 +0000)]
Merged revisions 158603 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r158603 | murf | 2008-11-21 16:14:50 -0700 (Fri, 21 Nov 2008) | 11 lines
In reference to the fix made for 13871, I was
merging the fix into 1.6.0 and realized I missed
the code in the h-exten block, and didn't catch it
because my test case had the h-exten commented out.
So, this corrects the code I missed, as a
preventative against another crash report.
Tested with the h-exten defined, all is well.
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@158606
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Fri, 21 Nov 2008 23:33:22 +0000 (23:33 +0000)]
Allow space within an extension, when the space is within a character class.
(requested by lmadsen on -dev, patch by me)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@158605
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Fri, 21 Nov 2008 23:14:11 +0000 (23:14 +0000)]
Merged revisions 158600 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r158600 | tilghman | 2008-11-21 17:07:46 -0600 (Fri, 21 Nov 2008) | 5 lines
The passed extension may not be the same in the list as the current entry,
because we strip spaces when copying the extension into the structure.
Therefore, use the copied item to place the item into the list.
(found by lmadsen on -dev, fixed by me)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@158602
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Fri, 21 Nov 2008 22:12:37 +0000 (22:12 +0000)]
Merged revisions 158539 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r158539 | russell | 2008-11-21 16:05:55 -0600 (Fri, 21 Nov 2008) | 2 lines
When compiling with DEBUG_THREADS, report the real file/func/line for ao2_lock/ao2_unlock
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@158540
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Steve Murphy [Fri, 21 Nov 2008 21:47:16 +0000 (21:47 +0000)]
Merged revisions 158483 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r158483 | murf | 2008-11-21 14:19:47 -0700 (Fri, 21 Nov 2008) | 11 lines
(closes issue #13871)
Reported by: mdu113
This one is totally my fault. The code doesn't even
create a bridge CDR if the channel CDR has POST_DISABLED.
I didn't check for that at the end of the bridge.
Fixed with a few small insertions. Tested. Looks
good. No cdr generated, no crash, no unnecc. data
objects created either.
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@158484
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Matthew Fredrickson [Fri, 21 Nov 2008 21:06:59 +0000 (21:06 +0000)]
Fix for #13963. Make physical channel mapping unconfigured default
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@158482
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Kevin P. Fleming [Fri, 21 Nov 2008 20:42:37 +0000 (20:42 +0000)]
as suggested by jtodd, document the purposes of the CHANGES and UPGRADE files
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@158449
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Jason Parker [Fri, 21 Nov 2008 19:40:57 +0000 (19:40 +0000)]
Make sure we add the Event header for CoreShowChannels.
(closes issue #13334)
Reported by: srt
Patches:
13334_missing_event_header_in_core_show_channel.diff uploaded by srt (license 378)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@158414
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Terry Wilson [Fri, 21 Nov 2008 17:08:16 +0000 (17:08 +0000)]
Reloading the config and having no changes still initialized some settings to 0. Initialize settings after doing all of the cfg checks.
(closes issue #13942)
Reported by: davidw
Patches:
cdr_diff.txt uploaded by otherwiseguy (license 396)
Tested by: davidw
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@158374
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Doug Bailey [Fri, 21 Nov 2008 15:53:49 +0000 (15:53 +0000)]
Add fix to prevent crash during reload if there is an outstanding MWI registration message pending.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@158315
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Mark Michelson [Fri, 21 Nov 2008 15:25:58 +0000 (15:25 +0000)]
Blocked revisions 158306 via svnmerge
........
r158306 | mmichelson | 2008-11-21 09:24:19 -0600 (Fri, 21 Nov 2008) | 5 lines
This change had somehow gotten reverted due to a
completely unrelated commit. Thanks to Theo Belder
on the Asterisk-dev list for pointing this out.
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@158307
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Mark Michelson [Fri, 21 Nov 2008 01:22:18 +0000 (01:22 +0000)]
Use a more expressive constant for a 64-bit scanned int
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@158266
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Mark Michelson [Fri, 21 Nov 2008 01:14:20 +0000 (01:14 +0000)]
Use some magic constants to get the right size
for this sscanf statement. Thanks Richard!
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@158265
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Mark Michelson [Fri, 21 Nov 2008 00:59:23 +0000 (00:59 +0000)]
Fix the build for 32-bit systems. %lu is only 32-bits
on 32-bit systems, so we need to use %llu instead. Of course
%llu is 128-bits on 64-bit systems, so we have to cast to
unsigned long long. No harm, but it's sure annoying.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@158262
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Mark Michelson [Thu, 20 Nov 2008 23:12:50 +0000 (23:12 +0000)]
Change the remote user agent session version variable
from an int to a uint64_t. This prevents potential comparison
problems from happening if the version string exceeds
INT_MAX. This was an apparent problem for one user who could
not properly place a call on hold since the version in the
SDP of the re-INVITE to place the call on hold greatly
exceeded INT_MAX.
This also aligns with RFC 2327 better since it recommends
using an NTP timestamp for the version (which is a
64-bit number).
(closes issue #13531)
Reported by: sgofferj
Patches:
13531.patch uploaded by putnopvut (license 60)
Tested by: sgofferj
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@158230
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Sean Bright [Thu, 20 Nov 2008 19:41:23 +0000 (19:41 +0000)]
Fix one case where the application argument was not converted from a pipe to
a comma. This was causing problems with switch statements with empty expressions.
(closes issue #13901)
Reported by: smurfix
Patches:
20081118_bug13901.diff uploaded by seanbright (license 71)
Tested by: seanbright
Reviewed by: murf
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@158188
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Mark Michelson [Thu, 20 Nov 2008 18:20:00 +0000 (18:20 +0000)]
Merged revisions 158072 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk
........
r158072 | twilson | 2008-11-20 11:48:58 -0600 (Thu, 20 Nov 2008) | 2 lines
Begin on a crusade to end trailing whitespace!
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@158133
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Mark Michelson [Thu, 20 Nov 2008 17:54:31 +0000 (17:54 +0000)]
Merged revisions 158071 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r158071 | mmichelson | 2008-11-20 11:48:42 -0600 (Thu, 20 Nov 2008) | 16 lines
We don't handle 4XX responses to BYE well. According to
section 15 of RFC 3261, we should terminate a dialog if we
receive a 481 or 408 in response to our BYE. Since I am aware
of at least one phone manufacturer who may sometimes send a
404 as well, I am being liberal and saying that any 4XX response
to a BYE should result in a terminated dialog.
(closes issue #12994)
Reported by: pabelanger
Patches:
12994.patch uploaded by putnopvut (license 60)
Closes AST-129
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@158082
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Ryan Brindley [Thu, 20 Nov 2008 17:53:42 +0000 (17:53 +0000)]
more formatting corrections :: one line for loops and if statements still need {}
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@158078
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Terry Wilson [Thu, 20 Nov 2008 17:48:58 +0000 (17:48 +0000)]
Begin on a crusade to end trailing whitespace!
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@158072
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Ryan Brindley [Thu, 20 Nov 2008 17:46:56 +0000 (17:46 +0000)]
formatting changes :: one line for loops and if statements should have {}
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@158070
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Mark Michelson [Thu, 20 Nov 2008 17:39:06 +0000 (17:39 +0000)]
Merged revisions 158053 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r158053 | mmichelson | 2008-11-20 11:33:06 -0600 (Thu, 20 Nov 2008) | 12 lines
Make sure to set the hangup cause on the calling channel in the case
that ast_call() fails. For incoming SIP channels, this was causing
us to send a 603 instead of a 486 when the call-limit was reached on
the destination channel.
(closes issue #13867)
Reported by: still_nsk
Patches:
13867.diff uploaded by putnopvut (license 60)
Tested by: blitzrage
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@158066
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Jeff Peeler [Thu, 20 Nov 2008 17:37:31 +0000 (17:37 +0000)]
(closes issue #12929)
Reported by: snyfer
This handles the case for a zero length file to attempt to be streamed. Instead of failing from not playing any data, go ahead and return success as ast_streamfile should consider playing nothing a success when there is nothing to play.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@158062
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Jason Parker [Thu, 20 Nov 2008 17:37:05 +0000 (17:37 +0000)]
Whitespace fix
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@158061
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Kevin P. Fleming [Thu, 20 Nov 2008 00:08:12 +0000 (00:08 +0000)]
Merged revisions 157859 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r157859 | kpfleming | 2008-11-19 15:34:47 -0600 (Wed, 19 Nov 2008) | 7 lines
the gcc optimizer frequently finds broken code (use of uninitalized variables, unreachable code, etc.), which is good. however, developers usually compile with the optimizer turned off, because if they need to debug the resulting code, optimized code makes that process very difficult. this means that we get code changes committed that weren't adequately checked over for these sorts of problems.
with this build system change, if (and only if) --enable-dev-mode was used and DONT_OPTIMIZE is turned on, when a source file is compiled it will actually be preprocessed (into a .i or .ii file), then compiled once with optimization (with the result sent to /dev/null) and again without optimization (but only if the first compile succeeded, of course).
while making these changes, i did some cleanup work in Makefile.rules to move commonly-used combinations of flag variables into their own variables, to make the file easier to read and maintain
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@157974
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Terry Wilson [Thu, 20 Nov 2008 00:06:46 +0000 (00:06 +0000)]
Fix compiling
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@157973
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Mark Michelson [Wed, 19 Nov 2008 23:30:42 +0000 (23:30 +0000)]
Add a space to the output
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@157940
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Mark Michelson [Wed, 19 Nov 2008 23:29:14 +0000 (23:29 +0000)]
Add a RES_NOT_DYNAMIC case for the CLI command
'queue remove member'
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@157939
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Mark Michelson [Wed, 19 Nov 2008 22:17:05 +0000 (22:17 +0000)]
Commit CHANGES change I promised when submitting
res_timing_timerfd
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@157906
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Wed, 19 Nov 2008 22:01:00 +0000 (22:01 +0000)]
Add info about REALTIME_FIELD and REALTIME_HASH
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@157893
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Mark Michelson [Wed, 19 Nov 2008 21:55:25 +0000 (21:55 +0000)]
Cast this value since a uint64_t is not the same
as an unsigned long long on a 64-bit machine.
Reported by kpfleming on IRC
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@157874
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Wed, 19 Nov 2008 21:54:39 +0000 (21:54 +0000)]
Two new functions, REALTIME_FIELD, and REALTIME_HASH, which should make
querying realtime from the dialplan a little more consistent and easy to use.
The original REALTIME function is preserved, for those who are already
accustomed to that interface.
(closes issue #13651)
Reported by: Corydon76
Patches:
20081119__bug13651__2.diff.txt uploaded by Corydon76 (license 14)
Tested by: blitzrage, Corydon76
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@157870
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Mark Michelson [Wed, 19 Nov 2008 19:37:32 +0000 (19:37 +0000)]
Merge the changes from the res_timing_timerfd branch.
This provides a new timing interface. In order to use it,
you must be running a Linux with a kernel version of
2.6.25 or newer and glibc 2.8 or newer.
This timing interface is a good alternative if a timing
source is necessary (e.g. for IAX trunking) but DAHDI is
otherwise unnecessary for the system.
For now, this commit contains the actual work done in the
res_timing_timerfd branch. There are no notices in the README
or CHANGES files yet, but they will be added in my next commit.
The timing API of Asterisk also needs to have a bit of work done
with regards to choosing which timing interface to use. This commit
makes the choice a build-time decision, by only allowing one of
the timer interfaces to be chosen in menuselect. It would be preferable
if the choice could be made at run-time, however. The preferred timing
interface could be loaded and tested, and if it does not work, choice
number two may be used instead. That sort of thing. That is beyond
the scope of work in this branch though.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@157820
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Terry Wilson [Wed, 19 Nov 2008 19:25:14 +0000 (19:25 +0000)]
Fix checking for CONFIG_STATUS_FILEINVALID so that modules don't crash upon trying to parse an invalid config
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@157818
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Wed, 19 Nov 2008 18:28:14 +0000 (18:28 +0000)]
Add check for t38_terminal_init in spandsp (not found in 0.0.6, so it should fail reasonably)
(closes issue #13473)
Reported by: genie
Patches:
20080916__bug13473.diff.txt uploaded by Corydon76 (license 14)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@157784
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Kevin P. Fleming [Wed, 19 Nov 2008 13:45:48 +0000 (13:45 +0000)]
correct small bug introduced during API conversion
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@157743
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Kevin P. Fleming [Wed, 19 Nov 2008 13:27:02 +0000 (13:27 +0000)]
move relevant entries into UPGRADE.txt and resync UPGRADE-1.6.txt with previous branches
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@157739
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Kevin P. Fleming [Wed, 19 Nov 2008 12:42:19 +0000 (12:42 +0000)]
make some corrections to the ast_agi_register_multiple(), ast_agi_unregister_multiple() and ast_agi_fdprintf() API calls to be consistent with API guidelines
also, move UPGRADE.txt to UPGRADE-1.6.txt and make the new UPGRADE.txt contain information about upgrading between Asterisk 1.6 releases
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@157706
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Terry Wilson [Wed, 19 Nov 2008 05:37:10 +0000 (05:37 +0000)]
Comment out config line that is in a commented out context
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@157675
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Wed, 19 Nov 2008 01:02:45 +0000 (01:02 +0000)]
Starting with a change to ensure that ast_verbose() preserves ABI compatibility
in 1.6.1 (as compared to 1.6.0 and versions of 1.4), this change also
deprecates the use of Asterisk with FreeBSD 4, given the central use of va_copy
in core functions. va_copy() is C99, anyway, and we already require C99 for
other purposes, so this isn't really a big change anyway. This change also
simplifies some of the core ast_str_* functions.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@157639
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Mark Michelson [Wed, 19 Nov 2008 00:59:48 +0000 (00:59 +0000)]
If malloc returns NULL, we need to return NULL immediately or
else Asterisk will crash when attempting to dereference the NULL
pointer
(closes issue #13858)
Reported by: eliel
Patches:
astmm.c.patch uploaded by eliel (license 64)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@157632
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Sean Bright [Wed, 19 Nov 2008 00:27:45 +0000 (00:27 +0000)]
Fix a few build problems on Solaris (and check for an md5 utility in
configure instead of the icky loop I was doing before).
(closes issue #13842)
Reported by: snuffy
Patches:
bug13842_20081106.diff uploaded by snuffy (license 35)
13842.diff uploaded by seanbright (license 71)
Tested by: snuffy
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@157600
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Mark Michelson [Tue, 18 Nov 2008 23:59:02 +0000 (23:59 +0000)]
This change prevents a crash from occurring if res_musiconhold.so
is unloaded and then Asterisk is stopped. The problem was that
we are not unregistering the ast_moh_destroy function at exit.
(closes issue #13761)
Reported by: eliel
Patches:
res_musiconhold.c.patch uploaded by eliel (license 64)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@157592
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Mark Michelson [Tue, 18 Nov 2008 23:39:41 +0000 (23:39 +0000)]
Add some missing $(DESTDIR)s to the bininstall
target of the Makefile.
(closes issue #13875)
Reported by: pabelanger
Patches:
Makefile.155928 uploaded by pabelanger (license 224)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@157564
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Mark Michelson [Tue, 18 Nov 2008 23:28:23 +0000 (23:28 +0000)]
Fix the logic for when delete=yes when IMAP storage
is in use so that the message is deleted from both
local and IMAP storage.
(closes issue #13642)
Reported by: jaroth
Patches:
deleteyes.patch uploaded by jaroth (license 50)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@157562
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Mark Michelson [Tue, 18 Nov 2008 22:54:08 +0000 (22:54 +0000)]
Merged revisions 157503 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r157503 | mmichelson | 2008-11-18 16:47:57 -0600 (Tue, 18 Nov 2008) | 13 lines
Add some missing invite state changes necessary in the sip_write
function. Not setting the invite state correctly on the call was
resulting in the Record application leaving empty files. I also
have updated the doxygen comment next to the declaration of the
INV_EARLY_MEDIA constant to reflect that we also use this state
when we *send* a 18X response to an INVITE.
(closes issue #13878)
Reported by: nahuelgreco
Patches:
sip-early-media-recording-1.4.22.patch uploaded by nahuelgreco (license 162)
Tested by: putnopvut
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@157512
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Mark Michelson [Tue, 18 Nov 2008 21:59:24 +0000 (21:59 +0000)]
Based on Russell's advice on the asterisk-dev list, I have
changed from using a global lock in update_call_counter to
using the locks within the sip_pvt and sip_peer structures
instead.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@157496
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Jason Parker [Tue, 18 Nov 2008 21:15:08 +0000 (21:15 +0000)]
Remove echo line that is unnecessary (Thanks seanbright).
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@157463
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Jason Parker [Tue, 18 Nov 2008 21:03:12 +0000 (21:03 +0000)]
Make this executable
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@157461
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Jason Parker [Tue, 18 Nov 2008 21:01:46 +0000 (21:01 +0000)]
Add init script for ArchLinux
(closes issue #13667)
Reported by: sherif
Patches:
archlinux_rc_makefile.patch uploaded by sherif (license 591)
archlinux_rc_makefile-2.patch uploaded by mvanbaak (license 7)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@157460
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Mark Michelson [Tue, 18 Nov 2008 20:23:58 +0000 (20:23 +0000)]
* Add a lock to be used in the update_call_counter function.
* Revert logic to mirror 1.4's in the sense that it will not allow
the call counter to dip below 0.
These two measures prevent potential races that could cause a SIP peer
to appear to be busy forever.
(closes issue #13668)
Reported by: mjc
Patches:
hintfix_trunk_rev152649.patch uploaded by wolfelectronic (license 586)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@157427
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
projects / asterisk/asterisk.git / log