Eliel C. Sardanons [Wed, 5 Nov 2008 01:44:04 +0000 (01:44 +0000)]
- Add PlayTones() and StopPlayTones() applications XML documentation.
- Fix a dot that was outside of the <para> in the ForkCDR() XML documentation.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@154467
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Sean Bright [Tue, 4 Nov 2008 23:23:39 +0000 (23:23 +0000)]
Introduce a new API call ast_channel_search_locked, which iterates through the
channel list calling a caller-defined callback. The callback returns non-zero
if a match is found. This should speed up some of the code that I committed
earlier today in chan_sip (which is also updated by this commit).
Reviewed by russellb and kpfleming via ReviewBoard:
http://reviewboard.digium.com/r/28/
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@154429
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Tue, 4 Nov 2008 23:03:00 +0000 (23:03 +0000)]
Switch to using a thread condition to signal that a child thread is ready for
work, rather than a busy wait.
(closes issue #13011)
Reported by: jpgrayson
Patches:
chan_iax2_find_idle.patch uploaded by jpgrayson (license 492)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@154428
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Tue, 4 Nov 2008 20:51:18 +0000 (20:51 +0000)]
Merged revisions 154365 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r154365 | tilghman | 2008-11-04 14:49:33 -0600 (Tue, 04 Nov 2008) | 9 lines
On busy systems, it's possible for the values checked within a single line
of code to change, unless the structure is locked to ensure a consistent
state.
(closes issue #13717)
Reported by: kowalma
Patches:
20081102__bug13717.diff.txt uploaded by Corydon76 (license 14)
Tested by: kowalma
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@154366
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Eliel C. Sardanons [Tue, 4 Nov 2008 20:12:41 +0000 (20:12 +0000)]
We need to pass the DTD to xmlstarlet to validate against it the XML.
(I thought it was being read within the DOCTYPE definition inside the XML).
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@154329
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Richard Mudgett [Tue, 4 Nov 2008 19:07:26 +0000 (19:07 +0000)]
Merged revisions 154266 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r154266 | rmudgett | 2008-11-04 13:01:08 -0600 (Tue, 04 Nov 2008) | 4 lines
JIRA ABE-1703
mISDN sets the channel to the wrong state when it receives
the indication AST_CONTROL_RINGING.
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@154268
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Tue, 4 Nov 2008 18:59:48 +0000 (18:59 +0000)]
Recorded merge of revisions 154263 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r154263 | tilghman | 2008-11-04 12:58:05 -0600 (Tue, 04 Nov 2008) | 3 lines
Make the monitor thread non-detached, so it can be joined (suggested by Russell
on -dev list).
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@154264
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Tue, 4 Nov 2008 18:47:20 +0000 (18:47 +0000)]
Slightly optimize ast_devstate_str and rename global functions devstate2str and config_text_file_save to have an ast_ prefix
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@154260
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Eliel C. Sardanons [Tue, 4 Nov 2008 18:06:50 +0000 (18:06 +0000)]
Add XML documentation for the ForkCDR() application.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@154225
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Sean Bright [Tue, 4 Nov 2008 17:23:33 +0000 (17:23 +0000)]
GLOB_BRACE is already added to MY_GLOB_FLAGS if it is supported on the
platform. This should resolve some build errors on Solaris.
(issue #13704)
Reported by: dougm
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@154191
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Sean Bright [Tue, 4 Nov 2008 17:00:45 +0000 (17:00 +0000)]
Allow devices that accept dialog-info+xml (like snoms) to get the Caller ID of
the calling party when subscribed to the state of an extension that is ringing.
This has some limitations which are documented in sip.conf.sample.
(closes issue #13827)
Reported by: seanbright
Patches:
issue13827.patch uploaded by seanbright (license 71)
Reviewed by: russellb
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@154187
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Sean Bright [Tue, 4 Nov 2008 16:50:34 +0000 (16:50 +0000)]
Fix build errors.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@154186
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Kevin P. Fleming [Tue, 4 Nov 2008 15:07:54 +0000 (15:07 +0000)]
improve configure script to remember the previous value of each dependency in build_tools/menuselect-deps, so that (once it has been written) menuselect can use this information to warn the user when a previously met dependency is no longer met
along the way, change tags used in configure script, menuselect-deps and code for various dependencies to be consistently named
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@154151
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Eliel C. Sardanons [Tue, 4 Nov 2008 14:38:20 +0000 (14:38 +0000)]
Add XML documentation for:
Applications
- DAHDISendKeypadFacility()
- DAHDISendCallreroutingFacility()
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@154149
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Mon, 3 Nov 2008 22:28:12 +0000 (22:28 +0000)]
Merged revisions 154066 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r154066 | tilghman | 2008-11-03 16:27:10 -0600 (Mon, 03 Nov 2008) | 5 lines
Attempting to expunge a mailbox when the mailstream is NULL will crash Asterisk.
(Closes issue #13829)
Reported by: jaroth
Patch by: me (modified jaroth's patch)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@154072
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Mon, 3 Nov 2008 21:57:14 +0000 (21:57 +0000)]
Merged revisions 154060 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r154060 | tilghman | 2008-11-03 15:48:21 -0600 (Mon, 03 Nov 2008) | 3 lines
Remove the potential for a division by zero error.
(Closes issue #13810)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@154061
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Mon, 3 Nov 2008 21:01:30 +0000 (21:01 +0000)]
Should have passed the string pointer, not the ast_str structure.
(closes issue #13830)
Reported by: Marquis
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@154023
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Olle Johansson [Mon, 3 Nov 2008 18:02:14 +0000 (18:02 +0000)]
Updating docs
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@153983
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Eliel C. Sardanons [Mon, 3 Nov 2008 17:11:22 +0000 (17:11 +0000)]
Add LOCAL() function XML documentation.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@153947
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Olle Johansson [Mon, 3 Nov 2008 15:25:35 +0000 (15:25 +0000)]
Spaces to replace tabs...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@153905
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Olle Johansson [Mon, 3 Nov 2008 15:16:33 +0000 (15:16 +0000)]
Adding a separation of remote authentication and our authentication.
remotesecret => our password for a remote service
secret => our authentication when someone calls us
Secret => still has both functions if remotesecret is not used.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@153904
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Eliel C. Sardanons [Mon, 3 Nov 2008 13:33:58 +0000 (13:33 +0000)]
Add XML documentation for:
Functions
- IAXPEER()
- IAXVAR()
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@153852
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Eliel C. Sardanons [Mon, 3 Nov 2008 12:35:05 +0000 (12:35 +0000)]
Add XML documentation for:
Applications
- SIPDtmfMode()
- SIPAddHeader()
Functions
- SIP_HEADER()
- SIPPEER()
- SIPCHANINFO()
- CHECKSIPDOMAIN()
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@153803
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Kevin P. Fleming [Mon, 3 Nov 2008 12:26:35 +0000 (12:26 +0000)]
when --without-<foo> is passed to the configure script, explicitly inform menuselect that the package was disabled by the user
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@153787
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Eliel C. Sardanons [Mon, 3 Nov 2008 01:01:25 +0000 (01:01 +0000)]
Add XML documentation for:
- WaitForSilence()
- WaitForNoise()
- WaitForRing()
- IVRDemo()
- DBDel()
- DBDeltree()
(issue #13699)
Reported by: snuffy
Patches:
bug13699_20081016.diff uploaded by snuffy (license 35)
(With minor changes)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@153747
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Kevin P. Fleming [Sun, 2 Nov 2008 23:34:39 +0000 (23:34 +0000)]
instead of trying to forcibly load res_agi when app_stack is loaded (even if the administrator didn't want it loaded), use GCC weak symbols to determine whether it was loaded already or not; if it was loaded, then use it.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@153709
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Sun, 2 Nov 2008 20:06:03 +0000 (20:06 +0000)]
Merged revisions 153651 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r153651 | russell | 2008-11-02 13:51:17 -0600 (Sun, 02 Nov 2008) | 2 lines
features.h depends on linkedlists.h, so include it
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@153652
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Kevin P. Fleming [Sun, 2 Nov 2008 19:39:41 +0000 (19:39 +0000)]
fix one more warning missed because i did not have new enough libpri installed
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@153650
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Kevin P. Fleming [Sun, 2 Nov 2008 19:09:41 +0000 (19:09 +0000)]
fix small bug introduced while cleaning up compiler warnings
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@153618
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Kevin P. Fleming [Sun, 2 Nov 2008 18:53:11 +0000 (18:53 +0000)]
mark this revision as merged manually
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@153617
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Kevin P. Fleming [Sun, 2 Nov 2008 18:52:13 +0000 (18:52 +0000)]
bring over all the fixes for the warnings found by gcc 4.3.x from the 1.4 branch, and add the ones needed for all the new code here too
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@153616
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Eliel C. Sardanons [Sun, 2 Nov 2008 06:24:53 +0000 (06:24 +0000)]
Add IAX2Provision() application XML documentation.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@153582
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Sun, 2 Nov 2008 05:56:50 +0000 (05:56 +0000)]
validate-docs is a PHONY target
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@153580
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Sun, 2 Nov 2008 05:55:46 +0000 (05:55 +0000)]
Add a handy makefile target so that you can validate the documentation against the DTD
by running "make validate-docs"
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@153578
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Sun, 2 Nov 2008 05:47:13 +0000 (05:47 +0000)]
Modify the Makefile logic for extracting documentation.
- Build the documentation when you run "make", as opposed to "make install"
- Only rebuild the documentation when source code has been changed
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@153577
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Eliel C. Sardanons [Sun, 2 Nov 2008 05:10:22 +0000 (05:10 +0000)]
Add Flash() application XML documentation.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@153543
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Eliel C. Sardanons [Sun, 2 Nov 2008 04:57:02 +0000 (04:57 +0000)]
Fix a typo in the name of the application.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@153541
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Sean Bright [Sun, 2 Nov 2008 04:14:20 +0000 (04:14 +0000)]
There is a troublesome assert() in the alsa/control.h header that causes
GCC 4.3.2 to complain that the passed argument will always evaluate to
true. So to get things to compile, disable assert when building
chan_usbradio.so.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@153507
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Sean Bright [Sun, 2 Nov 2008 02:57:27 +0000 (02:57 +0000)]
Another little one.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@153472
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Sun, 2 Nov 2008 02:55:25 +0000 (02:55 +0000)]
fix a typo (thanks sean)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@153470
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Sun, 2 Nov 2008 02:50:33 +0000 (02:50 +0000)]
Fix various spelling and grammatical issues in documentation
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@153468
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Sun, 2 Nov 2008 02:20:10 +0000 (02:20 +0000)]
- Use a for loop instead of a while loop
- Get rid of an unnecessary variable
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@153437
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Sun, 2 Nov 2008 02:14:19 +0000 (02:14 +0000)]
Instead of doing a couple of strlen() calls each iteration of the loop, only do it once
at the beginning of the function
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@153435
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Sat, 1 Nov 2008 23:46:12 +0000 (23:46 +0000)]
Don't ignore the result of find_peer() when looking for a peer by IP in check_peer_ok().
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@153403
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Sat, 1 Nov 2008 21:10:07 +0000 (21:10 +0000)]
Merge changes from team/group/appdocsxml
This commit introduces the first phase of an effort to manage documentation of the
interfaces in Asterisk in an XML format. Currently, a new format is available for
applications and dialplan functions. A good number of conversions to the new format
are also included.
For more information, see the following message to asterisk-dev:
http://lists.digium.com/pipermail/asterisk-dev/2008-October/034968.html
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@153365
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Sat, 1 Nov 2008 20:41:38 +0000 (20:41 +0000)]
Ensure that the sip_pvt properly has its refcount incremented when the scheduler holds
a reference to it for session timer processing.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@153362
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Sean Bright [Sat, 1 Nov 2008 01:55:04 +0000 (01:55 +0000)]
The default in chan_sip for notifyringing is yes, so update the sample
conf to reflect that.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@153296
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Mark Michelson [Fri, 31 Oct 2008 20:05:46 +0000 (20:05 +0000)]
* Fixed timeout logic in the dialing API as setting timeouts
had no effect
* Updated dialing API documentation to indicate that timeouts
are specified in milliseconds
* Added a new timeout argument to the Page application. If time
expires, any endpoints which have not answered will be hung up.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@153223
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Terry Wilson [Fri, 31 Oct 2008 18:55:33 +0000 (18:55 +0000)]
Recent CDR fixes moved execution of the 'h' exten into the bridging code, so variables that were set after ast_bridge_call was called would not show up in the 'h' exten. Added a callback function to handle setting variables, etc. from w/in the bridging code. Calls back into a nested function within the function calling ast_bridge_call
(closes issue #13793)
Reported by: greenfieldtech
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@153181
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Fri, 31 Oct 2008 17:18:49 +0000 (17:18 +0000)]
Failover for func_odbc, allowing an INSERT query to be performed when the UPDATE query initially
affects 0 rows.
(closes issue #13083)
Reported by: Corydon76
Patches:
20081031__bug13083.diff.txt uploaded by Corydon76 (license 14)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@153124
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Fri, 31 Oct 2008 16:35:21 +0000 (16:35 +0000)]
Merged revisions 153114 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r153114 | tilghman | 2008-10-31 11:30:32 -0500 (Fri, 31 Oct 2008) | 3 lines
Turn off qualify on uncached realtime peers.
(Closes issue #13383)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@153122
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Fri, 31 Oct 2008 09:31:10 +0000 (09:31 +0000)]
Use the ast_str API call to reset the string instead of manually editing its internals
(closes issue #13816)
Reported by: eliel
Patches:
channel.c.patch uploaded by eliel (license 64)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@153057
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Sean Bright [Thu, 30 Oct 2008 20:59:17 +0000 (20:59 +0000)]
Merged revisions 152992 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r152992 | seanbright | 2008-10-30 16:58:24 -0400 (Thu, 30 Oct 2008) | 2 lines
The -I argument to aclocal needs a space before the include directory name.
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@152993
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Thu, 30 Oct 2008 20:46:17 +0000 (20:46 +0000)]
Add a todo for a new timing API implementation that would work for Linux systems
as of kernel 2.6.25 and glibc 2.8
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@152990
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Thu, 30 Oct 2008 20:35:46 +0000 (20:35 +0000)]
Merged revisions 152958 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r152958 | tilghman | 2008-10-30 15:33:28 -0500 (Thu, 30 Oct 2008) | 3 lines
Cannot join detached threads. See http://www.opengroup.org/onlinepubs/
000095399/functions/pthread_join.html
(Closes issue #13400)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@152969
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Thu, 30 Oct 2008 19:45:52 +0000 (19:45 +0000)]
Merged revisions 152922 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r152922 | tilghman | 2008-10-30 14:43:38 -0500 (Thu, 30 Oct 2008) | 6 lines
Unlock before returning, when extension doesn't exist.
(closes issue #13807)
Reported by: eliel
Patches:
chan_local.c.patch uploaded by eliel (license 64)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@152923
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Thu, 30 Oct 2008 19:40:15 +0000 (19:40 +0000)]
Fix the sip_peer reference count with respect to scheduler entries for
scheduling peer pokes, and scheduling peer poke expirations.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@152920
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Thu, 30 Oct 2008 19:35:36 +0000 (19:35 +0000)]
Fix the sip_peer reference count with respect to scheduler entries for
registration expirations.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@152915
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Thu, 30 Oct 2008 19:28:06 +0000 (19:28 +0000)]
Fix a bug in AST_SCHED_REPLACE_UNREF(). The reference count of the object
_must_ be increased before creating the scheduler entry. Otherwise, you
create a race condition where the reference count may hit zero and the
object can disappear out from under you. This could also would have
incorrectly decreased the reference count in the case that the scheduler
add failed.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@152887
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Mark Michelson [Thu, 30 Oct 2008 19:23:16 +0000 (19:23 +0000)]
I just noticed this construct and thought it was
silly to have a bunch of case statements with duplicated
code in each case. Instead, just use the built-in fallthrough
capability of case statements and reduce the code to
a single instance
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@152879
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Thu, 30 Oct 2008 19:21:53 +0000 (19:21 +0000)]
Modify the documentation of the sip_registry struct
- Remove a comment that says that the monitor thread is the only one that
ever touches these objects. This is no longer the case with TCP. Also,
I would eventually like to get the scheduler in its own thread, so this
is just a poor assumption to make.
- Note that reference counting of these objects with respect to scheduler
entries is not complete. There are some leaked references when deleting
scheduler entries.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@152877
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Thu, 30 Oct 2008 19:18:16 +0000 (19:18 +0000)]
- spaces to tabs
- add some braces
- remove unnecessary cast
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@152875
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Kevin P. Fleming [Thu, 30 Oct 2008 16:54:29 +0000 (16:54 +0000)]
Merged revisions 152811 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r152811 | kpfleming | 2008-10-30 11:53:48 -0500 (Thu, 30 Oct 2008) | 3 lines
instead of comparing the string pointer to 0, let's compare the value that was actually parsed out of the string (found by sparse)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@152812
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Kevin P. Fleming [Thu, 30 Oct 2008 16:53:11 +0000 (16:53 +0000)]
try to get this committed before the buildbot complains about a broken tree
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@152810
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Kevin P. Fleming [Thu, 30 Oct 2008 16:49:02 +0000 (16:49 +0000)]
fix a few small things found by using sparse
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@152809
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Mark Michelson [Thu, 30 Oct 2008 16:38:19 +0000 (16:38 +0000)]
After seeing another problem in #asterisk stemming from
the low default value of featuredigittimeout, I decided it
was high time to change it. I have changed the default to
2000 ms based on a suggestion from Leif Madsen.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@152807
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Thu, 30 Oct 2008 04:26:34 +0000 (04:26 +0000)]
Set up an example stdexten that preserves the original context and extension in
the CDR.
(Related to issue #13799)
Reported by: davidw
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@152765
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Thu, 30 Oct 2008 02:08:02 +0000 (02:08 +0000)]
Pay attention to the searchcontexts entry in voicemail.conf (related to AST-125)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@152727
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Thu, 30 Oct 2008 00:45:47 +0000 (00:45 +0000)]
Track down and fix annoying lock errors
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@152689
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Mark Michelson [Wed, 29 Oct 2008 20:53:53 +0000 (20:53 +0000)]
If there was no named defined in a voicemail.conf mailbox
entry, then app_directory would crash when attempting to
read that entry from the file. We now check for the NULL
or empty string properly so that there will be no crash.
(closes issue #13804)
Reported by: bluecrow76
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@152646
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Steve Murphy [Wed, 29 Oct 2008 05:47:13 +0000 (05:47 +0000)]
Merged revisions 152538 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r152538 | murf | 2008-10-28 23:19:04 -0600 (Tue, 28 Oct 2008) | 14 lines
A little documentation cross-ref between features and
dial and queue... I wasted some time (stupidly) trying
to get the one-touch parking stuff working, because it
didn't occur to me that I had to also have the corresponding
options in the dial command! Duh! (In all this time, I never
set this up before!)
So, to keep some poor fool from suffering the same fate,
I made the features.conf.sample file mention the corresponding
opts in dial/queue; and the docs for dial/app specifically
mention the corresponding decls in the feature.conf file.
I hope this doesn't spoil some vast, eternal plan...
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@152605
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Wed, 29 Oct 2008 05:34:26 +0000 (05:34 +0000)]
Merged revisions 152539 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r152539 | russell | 2008-10-29 00:23:51 -0500 (Wed, 29 Oct 2008) | 7 lines
Fix an incorrect usage of sizeof()
(closes issue #13795)
Reported by: andrew53
Patches:
chan_sip_sizeof.patch uploaded by andrew53 (license 519)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@152569
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Steve Murphy [Wed, 29 Oct 2008 05:01:00 +0000 (05:01 +0000)]
Merged revisions 152535 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r152535 | murf | 2008-10-28 22:36:32 -0600 (Tue, 28 Oct 2008) | 46 lines
The magic trick to avoid this crash is not to
try to find the channel by name in the list,
which is slow and resource consuming, but rather
to pay attention to the result codes from the
ast_bridge_call, to which I added the
AST_PBX_NO_HANGUP_PEER_PARKED value, which
now are returned when a channel is parked.
Why? because CDR's aren't generated via parking,
so nothing is needed, but if a transfer occurred,
there are critical things I need.
If you get AST_PBX_KEEPALIVE,
then don't touch the channel pointer.
If you get AST_PBX_NO_HANGUP_PEER, or
AST_PBX_NO_HANGUP_PEER_PARKED, then don't
touch the peer pointer.
Updated the several places where the results
from a bridge were not being properly obeyed,
and fixed some code I had introduced so that
the results of the bridge were not overridden
(in trunk).
All the places that previously tested for
AST_PBX_NO_HANGUP_PEER now have to check for
both AST_PBX_NO_HANGUP_PEER and AST_PBX_NO_HANGUP_PEER_PARKED.
I tested this against the 4 common parking
scenarios:
1. A calls B; B answers; A parks B; B hangs up while A is getting the parking
slot announcement, immediately after being put on hold.
2. A calls B; B answers; A parks B; B hangs up after A has been hung up, but
before the park times out.
3. A calls B; B answers; B parks A; A hangs up while B is getting the parking slot announcement, immediately after being put on hold.
4. A calls B; B answers; B parks A; A hangs up after B has been hung up, but before the park times out.
No crash.
I also ran the scenarios above against valgrind, and accesses looked good.
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@152536
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Tue, 28 Oct 2008 22:33:40 +0000 (22:33 +0000)]
Merged revisions 152463 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r152463 | tilghman | 2008-10-28 17:32:34 -0500 (Tue, 28 Oct 2008) | 3 lines
Quoting in the wrong direction
(Fixes AST-107)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@152467
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Doug Bailey [Tue, 28 Oct 2008 22:26:35 +0000 (22:26 +0000)]
Add more polycom firmware files to static mapping
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@152448
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Tue, 28 Oct 2008 21:38:26 +0000 (21:38 +0000)]
Only re-add the io port if it was closed, otherwise reload causes a memory
leak.
(closes issue #13785)
Reported by: eliel
Patches:
chan_mgcp.c.patch uploaded by eliel (license 64)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@152442
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Tue, 28 Oct 2008 17:07:39 +0000 (17:07 +0000)]
Merged revisions 152368 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r152368 | tilghman | 2008-10-28 12:04:56 -0500 (Tue, 28 Oct 2008) | 8 lines
Reset all DIAL variables back to blank, in case Dial is called multiple times
per call (which could otherwise lead to inconsistent status reports).
(closes issue #13216)
Reported by: ruddy
Patches:
20081014__bug13216.diff.txt uploaded by Corydon76 (license 14)
Tested by: ruddy
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@152369
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Jeff Peeler [Mon, 27 Oct 2008 23:31:39 +0000 (23:31 +0000)]
Merged revisions 152286 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r152286 | jpeeler | 2008-10-27 18:28:49 -0500 (Mon, 27 Oct 2008) | 2 lines
Buffer policy setting for half is not needed.
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@152287
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Mon, 27 Oct 2008 21:34:04 +0000 (21:34 +0000)]
Merged revisions 152215 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r152215 | tilghman | 2008-10-27 16:32:00 -0500 (Mon, 27 Oct 2008) | 6 lines
Inherit ALL elements of CallerID across a local channel.
(closes issue #13368)
Reported by: Peter Schlaile
Patches:
20080826__bug13368.diff.txt uploaded by Corydon76 (license 14)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@152216
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Mon, 27 Oct 2008 16:44:55 +0000 (16:44 +0000)]
Set ARGC in subroutines with the number of arguments passed.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@152174
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Mon, 27 Oct 2008 16:24:11 +0000 (16:24 +0000)]
Oops, only delete the ARG variables once upon release. The following section
would have removed them again (removing variables from 2 stack frames, instead
of just one).
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@152134
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Jason Parker [Mon, 27 Oct 2008 16:03:12 +0000 (16:03 +0000)]
Remove options argument parsing/syntax (it isn't used any longer)
(closes issue #13789)
Reported by: IgorG
Patches:
app_transfer.c.diff uploaded by IgorG (license 20)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@152132
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Sean Bright [Sun, 26 Oct 2008 20:25:08 +0000 (20:25 +0000)]
Merged revisions 152059 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r152059 | seanbright | 2008-10-26 16:23:36 -0400 (Sun, 26 Oct 2008) | 7 lines
Since passing \0 as the second argument to strchr is valid (and will
match the trailing \0 of a string) we need to check that first, otherwise
we end up with incorrect results. Fix suggested by reporter.
(closes issue #13787)
Reported by: meitinger
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@152060
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Olle Johansson [Sun, 26 Oct 2008 10:23:01 +0000 (10:23 +0000)]
Trying to fix the user/peer matching correctly. This will need some testing before
getting merged into 1.6.1
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@152020
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Olle Johansson [Sun, 26 Oct 2008 09:45:17 +0000 (09:45 +0000)]
Moving more variables to the sip_cfg structure, as I have some future ideas for the usage of that structure.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@152019
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Olle Johansson [Sun, 26 Oct 2008 09:19:19 +0000 (09:19 +0000)]
Doxygen changes and some formatting.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@151980
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Sat, 25 Oct 2008 11:02:11 +0000 (11:02 +0000)]
Merged revisions 151905 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r151905 | russell | 2008-10-25 05:59:02 -0500 (Sat, 25 Oct 2008) | 8 lines
Move AMI initialization to occur after loading modules. This prevents a
deadlock when someone tries to initiate a module reload from the AMI just
as Asterisk is starting.
(closes issue #13778)
Reported by: hotsblanc
Fix suggested by hotsblanc
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@151906
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Terry Wilson [Thu, 23 Oct 2008 21:27:35 +0000 (21:27 +0000)]
allow to compile under --enable-dev-mode (gcc didn't actually complain when I was using ccache...)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@151830
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Terry Wilson [Thu, 23 Oct 2008 16:09:25 +0000 (16:09 +0000)]
Blocked revisions 151763 via svnmerge
........
r151763 | twilson | 2008-10-23 11:04:42 -0500 (Thu, 23 Oct 2008) | 9 lines
Backport fix from 1.6.0 that allows you to set parkedcalltransfers=no|caller|callee|both, but default to both which would be the equivalent of the existing behaviour.
The problem was that if someone parked a call, the callee and caller would both get assigned the builtin transfer feature, which would not only be potentially giving someone the ability to transfer themselves when they shouldn't have it, but would also dissallow reinviting the media off of the call.
(closes issue #12854)
Reported by: davidw
Patches:
parkingfix4.diff.txt uploaded by otherwiseguy
Tested by: davidw, otherwiseguy
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@151764
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Thu, 23 Oct 2008 15:54:19 +0000 (15:54 +0000)]
Clarify documentation, following merge of realtime_update2 branch
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@151762
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Olle Johansson [Thu, 23 Oct 2008 15:38:26 +0000 (15:38 +0000)]
Thanks russellb for reminding an old man....
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@151761
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Olle Johansson [Thu, 23 Oct 2008 15:30:16 +0000 (15:30 +0000)]
Adding a small new feature.
Setting _SIPFROMDOMAIN in a channel will set the domain we use for the URI in the outbound call leg.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@151739
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Thu, 23 Oct 2008 15:28:43 +0000 (15:28 +0000)]
Simplify some nested functions, as suggested by Russell on -dev
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@151732
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Doug Bailey [Thu, 23 Oct 2008 15:09:20 +0000 (15:09 +0000)]
Add patch to handle how IE7 issues POST requests using Window path spec including backslash delimiters
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@151722
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Wed, 22 Oct 2008 22:11:31 +0000 (22:11 +0000)]
Added debugging CLI functions
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@151682
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
BJ Weschke [Wed, 22 Oct 2008 20:45:03 +0000 (20:45 +0000)]
revert the changes in issue #13705 - it's being re-opened as while the results fixed the complaint in the issue, it introduced other more undesirable issues than what was already reported
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@151642
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Wed, 22 Oct 2008 20:05:15 +0000 (20:05 +0000)]
Add a contributed script for running Asterisk without installing it, first.
(closes issue #11680)
Reported by: tzafrir
Patches:
live_ast_6 uploaded by tzafrir (license 46)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@151601
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Mark Michelson [Wed, 22 Oct 2008 20:05:14 +0000 (20:05 +0000)]
Change some logical ands to bitwise ands and add
messages alerting that a channel is being ignored
if the PROC_DAHDI_NOCHAN option is set in process_dahdi.
(closes issue #13759)
Reported by: smurfix
Patches:
dahdi.patch uploaded by smurfix (license 547)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@151600
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Wed, 22 Oct 2008 17:45:05 +0000 (17:45 +0000)]
Print out the right var in the log message
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@151555
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Wed, 22 Oct 2008 17:44:05 +0000 (17:44 +0000)]
Fix this check to use the proper variable (the result from get_in_brackets)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@151554
65c4cc65-6c06-0410-ace0-
fbb531ad65f3