Russell Bryant [Wed, 24 Nov 2010 23:30:32 +0000 (23:30 +0000)]
Merged revisions 296230 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
................
r296230 | russell | 2010-11-24 17:29:44 -0600 (Wed, 24 Nov 2010) | 20 lines
Merged revisions 296221 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2
................
r296221 | russell | 2010-11-24 17:28:19 -0600 (Wed, 24 Nov 2010) | 13 lines
Merged revisions 296213 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r296213 | russell | 2010-11-24 17:26:43 -0600 (Wed, 24 Nov 2010) | 6 lines
Make Asterisk less crashy.
Since we might not put a new translation path on the channel, go ahead and
set it to NULL right after destroying the old one to ensure we don't try
to free an invalid translation path later on.
........
................
................
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@296235
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Richard Mudgett [Wed, 24 Nov 2010 22:52:07 +0000 (22:52 +0000)]
Merged revisions 296167 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
................
r296167 | rmudgett | 2010-11-24 16:49:48 -0600 (Wed, 24 Nov 2010) | 57 lines
Merged revisions 296166 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2
................
r296166 | rmudgett | 2010-11-24 16:42:45 -0600 (Wed, 24 Nov 2010) | 50 lines
Merged revisions 296165 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r296165 | rmudgett | 2010-11-24 16:41:07 -0600 (Wed, 24 Nov 2010) | 43 lines
Oneway audio to SIP phone from FXS port after FXS port gets a CallWaiting pip.
The FXS connected phone has to have CW/CID support to fail, as it will
send back a DTMF 'A' or 'D' when it's ready to receive CallerID. A normal
phone with no CID never fails. Also the SIP phone does not hear MOH when
the CW call is answered.
The DTMF end frame is suppressed when the phone acknowledges the CW signal
for CID. The problem is the DTMF begin frame needs to be suppressed as
well. The DTMF begin frame is causing SIP to start sending the DTMF RTP
frames. Since the DTMF end frame is suppressed, SIP will not stop sending
those DTMF RTP packets.
* Suppress the DTMF begin and end frames when the channel driver is
looking for DTMF digits.
* Fixed a couple issues caused by not cleaning up the CID spill if you
answer the CW call while it is sending the CID spill.
* Fixed not sending CW/CID spill to the phone when the call is natively
bridged. (Fixed by not using native bridge if CW/CID is possible.)
* Suppress received audio when sending CW/CID spills. The other parties
involved do not need to hear the CW/CID spills and may be confused if the
CW call is for them.
(closes issue #18129)
Reported by: alecdavis
Patches:
issue_18129_v1.8_v3.patch uploaded by rmudgett (license 664)
Tested by: alecdavis, rmudgett
NOTE:
* v1.4 does not have the main problem fixed by suppressing the DTMF start
frames. The other three items fixed are relevant.
* If you really must restore native bridging between analog ports, you
need to disable CW/CID either by configuring chan_dahdi.conf
callwaitingcallerid=no or dialing *70 before dialing the number to
temporarily disable CW.
........
................
................
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@296168
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Wed, 24 Nov 2010 20:24:38 +0000 (20:24 +0000)]
Merged revisions 296084 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
................
r296084 | russell | 2010-11-24 14:23:46 -0600 (Wed, 24 Nov 2010) | 26 lines
Merged revisions 296083 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2
................
r296083 | russell | 2010-11-24 14:23:11 -0600 (Wed, 24 Nov 2010) | 19 lines
Merged revisions 296082 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r296082 | russell | 2010-11-24 14:22:32 -0600 (Wed, 24 Nov 2010) | 12 lines
Fix false reporting of an error by set_format().
In the case that the native format was able to be changed to match the
new requested format, the code proceeded to attempt to build a translation
path, anyway. The result would be NULL, since no translation path is
necessary and resulted in this function thinking an error has occurred.
This case is now specifically caught and no attempt to build a translation
path is attempted.
Thanks to our automated tests and bamboo.asterisk.org for catching this problem
and making a whole lot of noise when things started failing. :-)
........
................
................
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@296085
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Wed, 24 Nov 2010 17:23:39 +0000 (17:23 +0000)]
Merged revisions 296002 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
................
r296002 | russell | 2010-11-24 11:13:08 -0600 (Wed, 24 Nov 2010) | 52 lines
Merged revisions 296001 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2
................
r296001 | russell | 2010-11-24 11:03:16 -0600 (Wed, 24 Nov 2010) | 45 lines
Merged revisions 296000 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r296000 | russell | 2010-11-24 10:48:39 -0600 (Wed, 24 Nov 2010) | 38 lines
Handle failures building translation paths more effectively.
The problem scenario occurred on a heavily loaded system that was using the
codec_dahdi module and exceeded the hardware transcoding capacity. The failure
mode at that point was not good. The report came in to us as an Asterisk
lock-up. The "core show locks" shows a ton of threads locked up (but no
obvious deadlock). Upon deeper investigation, when the system is in this
state, the CPU was maxed out. The CPU was being consumed by the Asterisk
logger spewing messages on every audio frame for calls set up after transcoder
capacity was reached.
The purpose of this patch is to make Asterisk handle failures to create a
translation path in a more graceful manner. If we can't translate, then the
call just needs to be dropped, as it's not going to work. These are the
changes:
1) In set_format() of channel.c (which is called by set_read_format() and
set_write_format()), it was ignoring if ast_translator_build_path() failed and
returned NULL. It now pays attention to that case and returns a result
reflecting failure. With this change in place, the bridging code will
immediately detect a failure and end the bridge instead of proceeding to try to
bridge frames that can't be translated and making channel drivers freak out by
sending them frames in a format they weren't expecting.
2) In ast_indicate_data() of channel.c, failure of ast_playtones_start() was
ignored. It is now reflected in the return value of the function. This didn't
turn out to have any affect on the bug, but seemed like a good change to leave
in.
3) In app_dial(), when only sending a call to a single endpoint, it will
attempt to do some bridging of its own of early audio. It uses
make_compatible() when it's going to do this. However, it ignored failure from
make compatible. So, even with the fix from #1, if there was early audio going
through app_dial, there would still be a period of invalid frames passing
through. After detecting failure here, Dial() exits.
ABE-2658
........
................
................
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@296034
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Olle Johansson [Tue, 23 Nov 2010 10:34:17 +0000 (10:34 +0000)]
Merged revisions 295949 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
................
r295949 | oej | 2010-11-23 11:30:05 +0100 (Tis, 23 Nov 2010) | 21 lines
Merged revisions 295907 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2
................
r295907 | oej | 2010-11-23 10:36:38 +0100 (Tis, 23 Nov 2010) | 14 lines
Merged revisions 295906 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r295906 | oej | 2010-11-23 10:28:14 +0100 (Tis, 23 Nov 2010) | 8 lines
Fix support of saynumber(1,n) in the Swedish language
(closes issue #18353)
Reported by: oej
Review: https://reviewboard.asterisk.org/r/1031/
........
................
................
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@295950
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Sean Bright [Mon, 22 Nov 2010 20:05:10 +0000 (20:05 +0000)]
Merged revisions 295869 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
................
r295869 | seanbright | 2010-11-22 15:03:49 -0500 (Mon, 22 Nov 2010) | 9 lines
Merged revisions 295868 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2
........
r295868 | seanbright | 2010-11-22 15:02:37 -0500 (Mon, 22 Nov 2010) | 2 lines
Change some documentation to suggest dahdi_monitor instead of ztmonitor.
........
................
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@295870
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Richard Mudgett [Mon, 22 Nov 2010 19:42:02 +0000 (19:42 +0000)]
Merged revisions 295866 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
................
r295866 | rmudgett | 2010-11-22 13:36:10 -0600 (Mon, 22 Nov 2010) | 60 lines
Merged revisions 295843 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2
................
r295843 | rmudgett | 2010-11-22 13:28:23 -0600 (Mon, 22 Nov 2010) | 53 lines
Merged revisions 295790 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r295790 | rmudgett | 2010-11-22 12:46:26 -0600 (Mon, 22 Nov 2010) | 46 lines
The channel redirect function (CLI or AMI) hangs up the call instead of redirecting the call.
To recreate the problem:
1) Party A calls Party B
2) Invoke CLI "channel redirect" command to redirect channel call leg
associated with A.
3) All associated channels are hung up.
Note that if the CLI command were done on the channel call leg associated
with B it works.
This regression was a result of the fix for issue #16946
(https://reviewboard.asterisk.org/r/740/).
The regression affects all features that use an async goto to execute the
dialplan because of an external event: Channel redirect, AMI redirect, SIP
REFER, and FAX detection.
The struct ast_channel._softhangup code is a mess. The variable is used
for several purposes that do not necessarily result in the call being hung
up. I have added doxygen comments to describe how the various _softhangup
bits are used. I have corrected all the places where the variable was
tested in a non-bit oriented manner.
The primary fix is the new AST_CONTROL_END_OF_Q frame. It acts as a weak
hangup request so the soft hangup requests that do not normally result in
a hangup do not hangup.
JIRA SWP-2470
JIRA SWP-2489
(closes issue #18171)
Reported by: SantaFox
(closes issue #18185)
Reported by: kwemheuer
(closes issue #18211)
Reported by: zahir_koradia
(closes issue #18230)
Reported by: vmarrone
(closes issue #18299)
Reported by: mbrevda
(closes issue #18322)
Reported by: nerbos
Review: https://reviewboard.asterisk.org/r/1013/
........
................
................
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@295867
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Erin Spiceland [Mon, 22 Nov 2010 18:43:31 +0000 (18:43 +0000)]
Revert to the previous behavior of AGI command WAIT FOR DIGIT, since the
behavior of the command with this patch is almost exactly like that of GET DATA.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@295789
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Richard Mudgett [Sat, 20 Nov 2010 03:13:24 +0000 (03:13 +0000)]
Merged revisions 295747 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r295747 | rmudgett | 2010-11-19 21:11:15 -0600 (Fri, 19 Nov 2010) | 13 lines
One way audio before answering call waiting call on analog port.
* Analog call waiting Caller ID spills could get stuck resulting in one
way audio until the waiting call is answered. This only happens on the
second (and later) call waiting call if the active call is not the first
call.
* The CLI/AMI "dahdi show channel" command could report the wrong channel
information.
Must keep the struct analog_pvt.owner and struct dahdi_pvt.owner pointer
in sync.
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@295748
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Sat, 20 Nov 2010 00:52:47 +0000 (00:52 +0000)]
Merged revisions 295711 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
................
r295711 | russell | 2010-11-19 18:50:00 -0600 (Fri, 19 Nov 2010) | 36 lines
Merged revisions 295710 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2
........
r295710 | russell | 2010-11-19 18:45:51 -0600 (Fri, 19 Nov 2010) | 29 lines
Fix cache of device state changes for multiple servers.
This patch addresses a regression where device states across multiple servers
were not being processing completely correctly. The code works to determine
the overall state by looking at the last known state of a device on each
server. However, there was a regression due to some invasive rewrites of how
the cache works that led to the cache only storing the last device state change
for a device, regardless of which server it was on.
The code is set up to cache device state change events by ensuring that each
event in the cache has a unique device name + entity ID (server ID). The code
that was responsible for comparing raw information elements (which EID is)
always returned a match due to a memcmp() with a length of 0.
There isn't much code to fix the actual bug. This patch also introduces a new
CLI command that was very useful for debugging this problem. The command
allows you to dump the contents of the event cache.
(closes issue #18284)
Reported by: klaus3000
Patches:
issue18284.rev1.txt uploaded by russell (license 2)
Tested by: russell, klaus3000
(closes issue #18280)
Reported by: klaus3000
Review: https://reviewboard.asterisk.org/r/1012/
........
................
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@295712
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Terry Wilson [Fri, 19 Nov 2010 22:15:49 +0000 (22:15 +0000)]
Merged revisions 295673 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
................
r295673 | twilson | 2010-11-19 14:06:10 -0800 (Fri, 19 Nov 2010) | 22 lines
Merged revisions 295672 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2
................
r295672 | twilson | 2010-11-19 13:55:48 -0800 (Fri, 19 Nov 2010) | 15 lines
Merged revisions 295628 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r295628 | twilson | 2010-11-19 12:53:36 -0800 (Fri, 19 Nov 2010) | 8 lines
Discard responses with more than one Via
This is not a perfect solution as headers that are joined via commas are not
detected. This is a parsing issue that to fix "correctly" would necessitate
a new SIP parser.
Review: https://reviewboard.asterisk.org/r/1019/
........
................
................
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@295674
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Brett Bryant [Fri, 19 Nov 2010 21:42:10 +0000 (21:42 +0000)]
Merged revisions 295670 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r295670 | bbryant | 2010-11-19 16:40:21 -0500 (Fri, 19 Nov 2010) | 8 lines
Patch for deadlock from ordering issue between channel/queue locks in app_queue
(set_queue_variables).
(closes issue #18031)
Reported by: rain
Review: https://reviewboard.asterisk.org/r/1018/
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@295671
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Erin Spiceland [Fri, 19 Nov 2010 19:32:56 +0000 (19:32 +0000)]
Add extra functionality to AGI command WAIT FOR DIGIT.
Add the ability to play a sound file, listen for more than just one digit,
specify
escape characters. Backwards compatible (to work with only timeout specified).
(closes issue #15531)
Reported by: diLLec
Patches:
asterisk-res_agi-203638-patched.patch uploaded by diLLec (license 839)
Tested by: diLLec, espiceland
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@295554
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Richard Mudgett [Fri, 19 Nov 2010 16:49:54 +0000 (16:49 +0000)]
Merged revisions 295516 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r295516 | rmudgett | 2010-11-19 10:47:11 -0600 (Fri, 19 Nov 2010) | 13 lines
Bring sig_analog extraction more into alignment with orig-trunk/v1.6.2 chan_dahdi.
* Restore SMDI support.
* Fixed initial value of struct analog_pvt.use_callerid. It may get
forced on depending upon other config options.
* Call analog_dnd() instead of manual inlined code.
* Removed unused struct analog_pvt.usedistinctiveringdetection.
* Removed the struct analog_pvt.unknown_alarm flag. It was really the
struct analog_pvt.inalarm flag.
* Use ast_debug() instead of ast_log(LOG_DEBUG).
* Rename several function's index variable to idx.
* Some formatting tweaks.
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@295517
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Leif Madsen [Thu, 18 Nov 2010 20:31:23 +0000 (20:31 +0000)]
Merged revisions 295477 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r295477 | lmadsen | 2010-11-18 14:30:35 -0600 (Thu, 18 Nov 2010) | 6 lines
'sip notify clear-mwi' needs terminating CRLF.
(closes issue #18275)
Reported by: klaus3000
Patches:
fix_body_CRLF_patch.txt uploaded by klaus3000 (license 65)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@295478
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Paul Belanger [Thu, 18 Nov 2010 18:08:43 +0000 (18:08 +0000)]
Merged revisions 295441 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
................
r295441 | pabelanger | 2010-11-18 13:02:12 -0500 (Thu, 18 Nov 2010) | 11 lines
Merged revisions 295440 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2
........
r295440 | pabelanger | 2010-11-18 12:51:34 -0500 (Thu, 18 Nov 2010) | 4 lines
Fix compiler warnings when using openssl-dev 1.0.0+
Review: https://reviewboard.asterisk.org/r/1016/
........
................
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@295442
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Paul Belanger [Thu, 18 Nov 2010 05:13:45 +0000 (05:13 +0000)]
Merged revisions 295404 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r295404 | pabelanger | 2010-11-18 00:12:05 -0500 (Thu, 18 Nov 2010) | 2 lines
Add RedHat specific dependencies
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@295405
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Paul Belanger [Wed, 17 Nov 2010 14:22:42 +0000 (14:22 +0000)]
Merged revisions 295361 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r295361 | pabelanger | 2010-11-17 09:09:38 -0500 (Wed, 17 Nov 2010) | 2 lines
Uncomment settings under [global], to surpress warning when loading Asterisk.
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@295364
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Richard Mudgett [Tue, 16 Nov 2010 23:04:55 +0000 (23:04 +0000)]
Merged revisions 295282 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
................
r295282 | rmudgett | 2010-11-16 17:02:36 -0600 (Tue, 16 Nov 2010) | 16 lines
Merged revisions 295281 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2
................
r295281 | rmudgett | 2010-11-16 16:57:07 -0600 (Tue, 16 Nov 2010) | 9 lines
Merged revisions 295280 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r295280 | rmudgett | 2010-11-16 16:52:06 -0600 (Tue, 16 Nov 2010) | 1 line
Dead code elimination in channel.c:ast_channel_bridge() variable who.
........
................
................
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@295283
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Tue, 16 Nov 2010 22:41:32 +0000 (22:41 +0000)]
Merged revisions 295278 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r295278 | russell | 2010-11-16 16:41:11 -0600 (Tue, 16 Nov 2010) | 2 lines
Check for pdftotext and give a useful error if not found.
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@295279
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Tue, 16 Nov 2010 21:46:39 +0000 (21:46 +0000)]
Merged revisions 295201 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r295201 | russell | 2010-11-16 15:46:18 -0600 (Tue, 16 Nov 2010) | 2 lines
Remove intentional typo I had added when testing the check. oops.
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@295202
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Tue, 16 Nov 2010 20:50:31 +0000 (20:50 +0000)]
Merged revisions 295164 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r295164 | russell | 2010-11-16 14:50:03 -0600 (Tue, 16 Nov 2010) | 2 lines
Check for wikiexport.py in PATH and give a useful error message if not found.
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@295165
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Tue, 16 Nov 2010 17:14:09 +0000 (17:14 +0000)]
Remove a trailing space.
(testing something with bamboo ...)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@295125
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Mon, 15 Nov 2010 19:11:12 +0000 (19:11 +0000)]
Merged revisions 295078 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
................
r295078 | tilghman | 2010-11-15 12:30:13 -0600 (Mon, 15 Nov 2010) | 16 lines
Merged revisions 295062 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2
................
r295062 | tilghman | 2010-11-15 12:24:02 -0600 (Mon, 15 Nov 2010) | 9 lines
Merged revisions 295026 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r295026 | tilghman | 2010-11-15 11:58:37 -0600 (Mon, 15 Nov 2010) | 2 lines
Create test verifying results of expression parser
........
................
................
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@295079
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Mon, 15 Nov 2010 07:45:42 +0000 (07:45 +0000)]
Merged revisions 294989 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
................
r294989 | tilghman | 2010-11-15 01:44:38 -0600 (Mon, 15 Nov 2010) | 15 lines
Merged revisions 294988 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2
........
r294988 | tilghman | 2010-11-15 01:42:39 -0600 (Mon, 15 Nov 2010) | 8 lines
It is possible to crash Asterisk by feeding the curl engine invalid data.
(closes issue #18161)
Reported by: wdoekes
Patches:
20101029__issue18161.diff.txt uploaded by tilghman (license 14)
Tested by: tilghman
........
................
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@294990
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Jeff Peeler [Fri, 12 Nov 2010 21:15:03 +0000 (21:15 +0000)]
Merged revisions 294911 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
................
r294911 | jpeeler | 2010-11-12 15:14:43 -0600 (Fri, 12 Nov 2010) | 11 lines
Merged revisions 294910 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2
........
r294910 | jpeeler | 2010-11-12 15:14:23 -0600 (Fri, 12 Nov 2010) | 4 lines
Return correct error code if lock path fails. The recent changes to open_mailbox actually caused it to be fixed, but let's be consistent.
Reported by alecdavis in asterisk-dev.
........
................
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@294912
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Jeff Peeler [Fri, 12 Nov 2010 20:53:08 +0000 (20:53 +0000)]
Merged revisions 294905 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
................
r294905 | jpeeler | 2010-11-12 14:52:06 -0600 (Fri, 12 Nov 2010) | 30 lines
Merged revisions 294904 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2
................
r294904 | jpeeler | 2010-11-12 14:51:15 -0600 (Fri, 12 Nov 2010) | 23 lines
Merged revisions 294903 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r294903 | jpeeler | 2010-11-12 14:49:09 -0600 (Fri, 12 Nov 2010) | 16 lines
Fix regression causing abort in voicemail after opening a mailbox with no mesgs.
In order to be more safe, some error handling code was changed to respect more
error conditions including the potential memory allocation failure for deleted
and heard message tracking introduced in 293004. However, last_message_index
returns -1 for zero messages (perhaps as expected) and was triggering the
stricter error checking. Because last_message_index is only called directly
in one place, just return 0 from open_mailbox (for file based storage) when no
messages are detected unless a real error has occurred.
(closes issue #18240)
Reported by: leobrown
Patches:
bug18240.1-6-2.diff.txt uploaded by alecdavis (license 585)
Tested by: pabelanger
........
................
................
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@294907
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Richard Mudgett [Fri, 12 Nov 2010 02:46:03 +0000 (02:46 +0000)]
Merged revisions 294823 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
................
r294823 | rmudgett | 2010-11-11 20:45:22 -0600 (Thu, 11 Nov 2010) | 25 lines
Merged revisions 294822 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2
................
r294822 | rmudgett | 2010-11-11 20:44:12 -0600 (Thu, 11 Nov 2010) | 18 lines
Merged revisions 294821 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r294821 | rmudgett | 2010-11-11 20:41:13 -0600 (Thu, 11 Nov 2010) | 11 lines
Asterisk is getting a "No D-channels available!" warning message every 4 seconds.
Asterisk is just whining too much with this message: "No D-channels
available! Using Primary channel XXX as D-channel anyway!".
Filtered the message so it only comes out once if there is no D channel
available without an intervening D channel available period.
(closes issue #17270)
Reported by: jmls
........
................
................
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@294824
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Thu, 11 Nov 2010 22:18:33 +0000 (22:18 +0000)]
Merged revisions 294745 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r294745 | russell | 2010-11-11 16:17:57 -0600 (Thu, 11 Nov 2010) | 6 lines
Remove CCSS architecture PDF.
It has been moved to:
https://wiki.asterisk.org/wiki/display/AST/CCSS+Architecture
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@294749
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Thu, 11 Nov 2010 22:14:25 +0000 (22:14 +0000)]
Merged revisions 294740 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r294740 | russell | 2010-11-11 16:13:38 -0600 (Thu, 11 Nov 2010) | 11 lines
Remove most of the contents of the doc dir in favor of the wiki content.
This merge does the following things:
* Removes most of the contents from the doc/ directory in favor
of the wiki - http://wiki.asterisk.org/
* Updates the build_tools/prep_tarball script to know how to export
the contents of the wiki in both PDF and plain text formats so that
the documentation is still included in Asterisk release tarballs.
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@294741
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Jeff Peeler [Thu, 11 Nov 2010 22:01:01 +0000 (22:01 +0000)]
Merged revisions 294734 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
................
r294734 | jpeeler | 2010-11-11 15:58:25 -0600 (Thu, 11 Nov 2010) | 32 lines
Merged revisions 294733 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2
................
r294733 | jpeeler | 2010-11-11 15:57:22 -0600 (Thu, 11 Nov 2010) | 25 lines
Merged revisions 294688 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r294688 | jpeeler | 2010-11-11 15:12:27 -0600 (Thu, 11 Nov 2010) | 18 lines
Fix problem with qualify option packets for realtime peers never stopping.
The option packets not only never stopped, but if a realtime peer was not in
the peer list multiple options dialogs could accumulate over time. This
scenario has the potential to progress to the point of saturating a link just
from options packets. The fix was to ensure that the poke scheduler checks to
see if a peer is in the peer list before continuing to poke. The reason a peer
must be in the peer list to be able to properly manage an options dialog is
because otherwise the call pointer is lost when the peer is regenerated from
the database, which is how existing qualify dialogs are detected.
(closes issue #16382)
(closes issue #17779)
Reported by: lftsy
Patches:
bug16382-3.patch uploaded by jpeeler (license 325)
Tested by: zerohalo
........
................
................
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@294735
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Wed, 10 Nov 2010 23:27:33 +0000 (23:27 +0000)]
Merged revisions 294605 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r294605 | tilghman | 2010-11-10 17:26:39 -0600 (Wed, 10 Nov 2010) | 2 lines
Fixing the Mac OS X build (bamboo warning)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@294606
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Wed, 10 Nov 2010 23:14:45 +0000 (23:14 +0000)]
Merged revisions 294569 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r294569 | tilghman | 2010-11-10 17:13:37 -0600 (Wed, 10 Nov 2010) | 8 lines
Properly queue files with inotify(7).
(closes issue #18089)
Reported by: abelbeck
Patches:
20101021__issue18089.diff.txt uploaded by tilghman (license 14)
Tested by: tilghman
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@294570
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Wed, 10 Nov 2010 14:15:53 +0000 (14:15 +0000)]
Merged revisions 294535 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r294535 | russell | 2010-11-10 08:14:51 -0600 (Wed, 10 Nov 2010) | 5 lines
Tweak a couple of CLI commands back to their original form.
The "module" in this case is two parts, so there are two words before
the verb of the CLI command.
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@294536
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Wed, 10 Nov 2010 12:52:46 +0000 (12:52 +0000)]
Merged revisions 294501 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
................
r294501 | russell | 2010-11-10 06:46:27 -0600 (Wed, 10 Nov 2010) | 14 lines
Merged revisions 294500 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2
........
r294500 | russell | 2010-11-10 06:41:41 -0600 (Wed, 10 Nov 2010) | 7 lines
Improve a debug message to be more readable and consistent.
(closes issue #18282)
Reported by: klaus3000
Patches:
ast_devstate2str-patch.txt uploaded by klaus3000 (license 65)
........
................
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@294502
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Richard Mudgett [Tue, 9 Nov 2010 22:52:00 +0000 (22:52 +0000)]
Merged revisions 294466 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r294466 | rmudgett | 2010-11-09 16:46:45 -0600 (Tue, 09 Nov 2010) | 1 line
Allow ast_do_masquerade() failure to be reported again.
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@294467
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Tue, 9 Nov 2010 20:35:05 +0000 (20:35 +0000)]
Merged revisions 294430 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
................
r294430 | tilghman | 2010-11-09 14:33:05 -0600 (Tue, 09 Nov 2010) | 15 lines
Merged revisions 294429 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2
........
r294429 | tilghman | 2010-11-09 14:27:23 -0600 (Tue, 09 Nov 2010) | 8 lines
Detect GMime properly on systems where gmime flags and libs are configured with pkg-config.
(closes issue #16155)
Reported by: jcollie
Patches:
20100917__issue16155.diff.txt uploaded by tilghman (license 14)
Tested by: tilghman
........
................
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@294431
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Richard Mudgett [Tue, 9 Nov 2010 17:00:07 +0000 (17:00 +0000)]
Merged revisions 294349 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r294349 | rmudgett | 2010-11-09 10:55:32 -0600 (Tue, 09 Nov 2010) | 17 lines
Analog lines do not transfer CONNECTED LINE or execute the interception macros.
Add connected line update for sig_analog transfers and simplify the
corresponding sig_pri and chan_misdn transfer code.
Note that if you create a three-way call in sig_analog before transferring
the call, the distinction of the caller/callee interception macros make
little sense. The interception macro writer needs to be prepared for
either caller/callee macro to be executed. The current implementation
swaps which caller/callee interception macro is executed after a three-way
call is created.
Review: https://reviewboard.asterisk.org/r/996/
JIRA ABE-2589
JIRA SWP-2372
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@294351
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Jeff Peeler [Mon, 8 Nov 2010 22:33:01 +0000 (22:33 +0000)]
Merged revisions 294313 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
................
r294313 | jpeeler | 2010-11-08 16:32:13 -0600 (Mon, 08 Nov 2010) | 9 lines
Merged revisions 294312 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2
........
r294312 | jpeeler | 2010-11-08 16:30:49 -0600 (Mon, 08 Nov 2010) | 1 line
add missing unlock not present in 294277
........
................
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@294314
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Jeff Peeler [Mon, 8 Nov 2010 22:03:54 +0000 (22:03 +0000)]
Merged revisions 294278 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
................
r294278 | jpeeler | 2010-11-08 15:59:45 -0600 (Mon, 08 Nov 2010) | 23 lines
Merged revisions 294277 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2
........
r294277 | jpeeler | 2010-11-08 15:58:13 -0600 (Mon, 08 Nov 2010) | 16 lines
Fix playback failure when using IAX with the timerfd module.
To fix this issue the alert pipe will now be used when the timerfd module is
in use. There appeared to be a race that was not solved by adding locking in the
timerfd module, but needed to be there anyway. The race was between the timer
being put in non-continuous mode in ast_read on the channel thread and the IAX
frame scheduler queuing a frame which would enable continuous mode before the
non-continuous mode event was read. This race for now is simply avoided.
(closes issue #18110)
Reported by: tpanton
Tested by: tpanton
I put tested by tpanton because it was tested on his hardware. Thanks for the
remote access to debug this issue!
........
................
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@294279
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Matthew Nicholson [Mon, 8 Nov 2010 21:04:01 +0000 (21:04 +0000)]
Merged revisions 294243 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
................
r294243 | mnicholson | 2010-11-08 14:56:30 -0600 (Mon, 08 Nov 2010) | 15 lines
Merged revisions 294242 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2
........
r294242 | mnicholson | 2010-11-08 14:50:21 -0600 (Mon, 08 Nov 2010) | 8 lines
Go off hold when we get an empty reinvite telling us to.
(closes issue 0014448)
Reported by: frawd
(closes issue #17878)
Reported by: frawd
........
................
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@294244
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Terry Wilson [Mon, 8 Nov 2010 19:59:39 +0000 (19:59 +0000)]
Merged revisions 294207 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r294207 | twilson | 2010-11-08 13:56:10 -0600 (Mon, 08 Nov 2010) | 2 lines
Set a default waittime, and make sure to convert it to milliseconds
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@294208
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Richard Mudgett [Mon, 8 Nov 2010 17:19:04 +0000 (17:19 +0000)]
Merged revisions 294125 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r294125 | rmudgett | 2010-11-08 11:16:01 -0600 (Mon, 08 Nov 2010) | 33 lines
valgrind reported references to freed memory during a mISDN hangup collision.
Bad things have been happening in chan_misdn because the chan_misdn
channel private struct chan_list is not protected from reentrancy. Hangup
collisions have be causing read and write accesses to freed memory.
Converted chan_misdn struct chan_list to an ao2 object for its reference
counting feature.
**********
Removed an impediment to converting chan_list to an ao2 object.
The use of the other_ch member in chan_list is shaky at best. It is set
if the incoming and outgoing call legs are mISDN. The use of the other_ch
member goes against the Asterisk architecture and can even cause problems.
1) It is used to disable echo cancellation. This could be bad if the call
is forked and the winning call leg is not mISDN or the winning call leg is
not the last mISDN channel called by the fork. The other_ch would become
a dangling pointer.
2) It is used when the far end is alerting to hear the far end's inband
audio instead of Asterisk's generated ringback tone. This is bad if the
call is forked. You would only hear the last forked mISDN channel and it
may not be ringing yet.
The other_ch would become a dangling pointer if the call is later
transferred.
**********
JIRA SWP-2423
JIRA ABE-2614
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@294127
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Brett Bryant [Fri, 5 Nov 2010 22:17:16 +0000 (22:17 +0000)]
Merged revisions 294084 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r294084 | bbryant | 2010-11-05 18:03:11 -0400 (Fri, 05 Nov 2010) | 9 lines
Fixed deadlock avoidance issues while locking channel when adding the
Max-Forwards header to a request.
(closes issue #17949)
(closes issue #18200)
Reported by: bwg
Review: https://reviewboard.asterisk.org/r/997/
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@294086
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
David Vossel [Fri, 5 Nov 2010 21:56:38 +0000 (21:56 +0000)]
Perform proper handling of forked outbound INVITE requests.
RFC3261 section 12 about dialog creation says an INVITE transaction
results in an established dialog once it receives the 200 OK response.
It is possible to receive multiple differing 200 OK responses for a
single outbound INVITE Request, and this should result in establishing
multiple dialogs.
This patch allows for all differing 200 OK responses to an INVITE request
to establish a separate dialog, but only the first dialog is kept. All other
resulting dialogs from the initial request are immediately ACKed and then
immediately terminated with a BYE request.
Review: https://reviewboard.asterisk.org/r/946/
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@294083
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Terry Wilson [Fri, 5 Nov 2010 16:07:56 +0000 (16:07 +0000)]
Merged revisions 294049 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r294049 | twilson | 2010-11-05 09:05:50 -0700 (Fri, 05 Nov 2010) | 2 lines
Corret spelling and example
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@294050
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Terry Wilson [Fri, 5 Nov 2010 15:37:52 +0000 (15:37 +0000)]
Merged revisions 294047 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r294047 | twilson | 2010-11-05 08:36:20 -0700 (Fri, 05 Nov 2010) | 2 lines
Tell people to use the correct common name for clients as well
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@294048
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
David Vossel [Fri, 5 Nov 2010 15:26:01 +0000 (15:26 +0000)]
Merged revisions 293924 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r293924 | dvossel | 2010-11-04 16:39:51 -0500 (Thu, 04 Nov 2010) | 4 lines
Fixes ringback tone on sip semi-attended transfer.
ABE-2168
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@294046
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Shaun Ruffell [Fri, 5 Nov 2010 00:08:09 +0000 (00:08 +0000)]
Merged revisions 293970 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
................
r293970 | sruffell | 2010-11-04 19:07:11 -0500 (Thu, 04 Nov 2010) | 32 lines
Merged revisions 293969 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2
................
r293969 | sruffell | 2010-11-04 19:06:02 -0500 (Thu, 04 Nov 2010) | 25 lines
Merged revisions 293968 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r293968 | sruffell | 2010-11-04 19:02:53 -0500 (Thu, 04 Nov 2010) | 17 lines
codecs/codec_dahdi: Prevent "choppy" audio when receiving unexpected frame sizes.
dahdi-linux 2.4.0 (specifically commit 9034) added the capability for
the wctc4xxp to return more than a single packet of data in response to
a read. However, when decoding packets, codec_dahdi was still assuming
that the default number of samples was in each read.
In other words, each packet your provider sent you, regardless of size,
would result in 20 ms of decoded data (30 ms if decoding G723). If your
provider was sending 60 ms packets then codec_dahdi would end up
stripping 40 ms of data from each transcoded frame resulting in "choppy"
audio.
This would only affect systems where G729 packets are arriving in sizes
greater than 20ms or G723 packets arriving in sizes greater than 30ms.
DAHDI-744.
........
................
................
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@293971
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Paul Belanger [Thu, 4 Nov 2010 13:29:20 +0000 (13:29 +0000)]
Merged revisions 293887 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r293887 | pabelanger | 2010-11-04 09:27:54 -0400 (Thu, 04 Nov 2010) | 8 lines
Do not output port in IPaddress for AMI sippeers.
(closes issue #18248)
Reported by: orn
Patches:
ami_sippeers.patch uploaded by pabelanger (license 224)
Tested by: orn
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@293888
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Terry Wilson [Wed, 3 Nov 2010 18:43:18 +0000 (18:43 +0000)]
Merged revisions 293803 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r293803 | twilson | 2010-11-03 11:05:14 -0700 (Wed, 03 Nov 2010) | 25 lines
Avoid valgrind warnings for ast_rtp_instance_get_xxx_address
The documentation for ast_rtp_instance_get_(local/remote)_address stated that
they returned 0 for success and -1 on failure. Instead, they returned 0 if the
address structure passed in was already equivalent to the address instance
local/remote address or 1 otherwise. 90% of the calls to these functions
completely ignored the return address and passed in an uninitialized struct,
which would make valgrind complain even though the operation was technically
safe.
This patch fixes the documentation and converts the get_xxx_address functions
to void since all they really do is copy the address and cannot fail.
Additionally two new functions
(ast_rtp_instance_get_and_cmp_(local/remote)_address) are created for the 3
times where the return value was actually checked. The
get_and_cmp_local_address function is currently unused, but exists for the sake
of symmetry.
The only functional change as a result of this change is that we will not do an
ast_sockaddr_cmp() on (mostly uninitialized) addresses before doing the
ast_sockaddr_copy() in the get_*_address functions. So, even though it is an
API change, it shouldn't have a noticeable change in behavior.
Review: https://reviewboard.asterisk.org/r/995/
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@293809
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Richard Mudgett [Wed, 3 Nov 2010 18:38:27 +0000 (18:38 +0000)]
Merged revisions 293807 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
................
r293807 | rmudgett | 2010-11-03 13:35:19 -0500 (Wed, 03 Nov 2010) | 34 lines
Merged revisions 293806 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2
................
r293806 | rmudgett | 2010-11-03 13:31:57 -0500 (Wed, 03 Nov 2010) | 27 lines
Merged revisions 293805 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r293805 | rmudgett | 2010-11-03 13:23:04 -0500 (Wed, 03 Nov 2010) | 20 lines
Party A in an analog 3-way call would continue to hear ringback after party C answers.
All parties are analog FXS ports.
1) A calls B.
2) A flash hooks to call C.
3) A flash hooks to bring C into 3-way call before C answers. (A and B hear ringback)
4) C answers
5) A continues to hear ringback during the 3-way call. (All parties can hear each other.)
* Fixed use of wrong variable in dahdi_bridge() that stopped ringback on
the wrong subchannel.
* Made several debug messages have more information.
A similar issue happens if B and C are SIP channels. B continues to hear
ringback. For some reason this only affects v1.8 and trunk.
* Don't start ringback on the real and 3-way subchannels when creating the
3-way conference. Removing this code is benign on v1.6.2 and earlier.
........
................
................
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@293808
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Jeff Peeler [Tue, 2 Nov 2010 23:10:07 +0000 (23:10 +0000)]
Merged revisions 293724 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
................
r293724 | jpeeler | 2010-11-02 18:09:06 -0500 (Tue, 02 Nov 2010) | 22 lines
Merged revisions 293723 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2
................
r293723 | jpeeler | 2010-11-02 18:07:13 -0500 (Tue, 02 Nov 2010) | 15 lines
Merged revisions 293722 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r293722 | jpeeler | 2010-11-02 18:02:51 -0500 (Tue, 02 Nov 2010) | 8 lines
Add enabled/disabled information for rtautoclear sip show settings output.
When setting to zero/"no", the numeric default was shown making it not obvious
the disabled setting was respected.
(closes issue #18123)
Reported by: zerohalo
........
................
................
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@293725
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Richard Mudgett [Tue, 2 Nov 2010 21:31:17 +0000 (21:31 +0000)]
Merged revisions 293648 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
................
r293648 | rmudgett | 2010-11-02 16:29:25 -0500 (Tue, 02 Nov 2010) | 20 lines
Merged revisions 293647 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2
................
r293647 | rmudgett | 2010-11-02 16:26:30 -0500 (Tue, 02 Nov 2010) | 13 lines
Merged revisions 293639 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r293639 | rmudgett | 2010-11-02 16:24:13 -0500 (Tue, 02 Nov 2010) | 6 lines
Make warning message have more useful information in it.
Change "Unable to get index, and nullok is not asserted" to "Unable to get
index for '<channel-name>' on channel <number> (<function>(), line
<number>)".
........
................
................
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@293649
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Paul Belanger [Tue, 2 Nov 2010 20:47:37 +0000 (20:47 +0000)]
Merged revisions 293611 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r293611 | pabelanger | 2010-11-02 16:45:09 -0400 (Tue, 02 Nov 2010) | 2 lines
If manager and tls are disabled, do not display TCP/TLS Bindaddress.
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@293612
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Paul Belanger [Tue, 2 Nov 2010 15:14:12 +0000 (15:14 +0000)]
New CLI command 'gtalk show settings'.
Review: https://reviewboard.asterisk.org/r/984/
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@293578
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Mark Michelson [Tue, 2 Nov 2010 14:43:11 +0000 (14:43 +0000)]
Add to the CHANGES file that the HTTP server supports IPv6 addressing.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@293577
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Richard Mudgett [Mon, 1 Nov 2010 17:32:16 +0000 (17:32 +0000)]
Merged revisions 293530 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r293530 | rmudgett | 2010-11-01 12:29:30 -0500 (Mon, 01 Nov 2010) | 10 lines
Analog 3-way call would not connect all parties if one was using sig_pri.
Also the "dahdi show channel" would not show the correct 3-way call
status.
* Synchronized the inthreeway flag between chan_dahdi and sig_analog.
* Fixed a my_set_linear_mode() sign error and made take an analog sub
channel enum.
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@293531
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Paul Belanger [Mon, 1 Nov 2010 16:11:50 +0000 (16:11 +0000)]
Merged revisions 293496 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r293496 | pabelanger | 2010-11-01 12:09:05 -0400 (Mon, 01 Nov 2010) | 13 lines
Use ast_sockaddr_from_sin function not memcpy
This resolves some IAX2 registration issue report on the
asterisk-users mailing list.
(closes issue #18202)
Reported by: pabelanger
Patches:
update_registry.patch.v2 uploaded by pabelanger (license 224)
Tested by: pabelanger, Nic Colledge (mailing list)
Review: https://reviewboard.asterisk.org/r/993
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@293497
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Richard Mudgett [Sat, 30 Oct 2010 01:55:15 +0000 (01:55 +0000)]
Merged revisions 293418 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
................
r293418 | rmudgett | 2010-10-29 20:53:29 -0500 (Fri, 29 Oct 2010) | 16 lines
Merged revisions 293417 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2
................
r293417 | rmudgett | 2010-10-29 20:49:15 -0500 (Fri, 29 Oct 2010) | 9 lines
Merged revisions 293416 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r293416 | rmudgett | 2010-10-29 20:45:49 -0500 (Fri, 29 Oct 2010) | 1 line
Remove some more code that serves no purpose.
........
................
................
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@293419
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Richard Mudgett [Sat, 30 Oct 2010 00:50:32 +0000 (00:50 +0000)]
Merged revisions 293341 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
................
r293341 | rmudgett | 2010-10-29 19:46:41 -0500 (Fri, 29 Oct 2010) | 16 lines
Merged revisions 293340 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2
................
r293340 | rmudgett | 2010-10-29 19:40:10 -0500 (Fri, 29 Oct 2010) | 9 lines
Merged revisions 293339 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r293339 | rmudgett | 2010-10-29 19:34:12 -0500 (Fri, 29 Oct 2010) | 1 line
Remove some code that serves no purpose.
........
................
................
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@293342
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Jeff Peeler [Fri, 29 Oct 2010 21:50:18 +0000 (21:50 +0000)]
Merged revisions 293305 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r293305 | jpeeler | 2010-10-29 16:48:38 -0500 (Fri, 29 Oct 2010) | 9 lines
Modify sip_setoption to not complain about unknown options.
This now behaves just like the other setoption callbacks. For the curious the
offending option for the reporter was AST_OPTION_CHANNEL_WRITE which was getting
passed due to a fix for chan_local in 286189.
(closes issue #17985)
Reported by: globalnetinc
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@293306
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Mark Michelson [Fri, 29 Oct 2010 20:46:06 +0000 (20:46 +0000)]
Enable IPv6 for the built-in HTTP server.
Review: https://reviewboard.asterisk.org/r/986
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@293273
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Thu, 28 Oct 2010 20:01:28 +0000 (20:01 +0000)]
Merged revisions 293197 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
................
r293197 | tilghman | 2010-10-28 15:00:06 -0500 (Thu, 28 Oct 2010) | 33 lines
Merged revisions 293195-293196 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2
................
r293195 | tilghman | 2010-10-28 14:52:52 -0500 (Thu, 28 Oct 2010) | 12 lines
Merged revisions 293194 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r293194 | tilghman | 2010-10-28 14:44:37 -0500 (Thu, 28 Oct 2010) | 5 lines
"!00" evaluated as false, which is incorrect. Fixing.
Reported (though the reporter did not understand he was reporting a bug) on the asterisk-users list:
http://lists.digium.com/pipermail/asterisk-users/2010-October/255505.html
........
................
r293196 | tilghman | 2010-10-28 14:54:34 -0500 (Thu, 28 Oct 2010) | 12 lines
Merged revisions 293194 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r293194 | tilghman | 2010-10-28 14:44:37 -0500 (Thu, 28 Oct 2010) | 5 lines
"!00" evaluated as false, which is incorrect. Fixing.
Reported (though the reporter did not understand he was reporting a bug) on the asterisk-users list:
http://lists.digium.com/pipermail/asterisk-users/2010-October/255505.html
........
................
................
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@293198
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Jeff Peeler [Thu, 28 Oct 2010 16:11:53 +0000 (16:11 +0000)]
Merged revisions 293159 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
................
r293159 | jpeeler | 2010-10-28 11:11:08 -0500 (Thu, 28 Oct 2010) | 18 lines
Merged revisions 293158 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2
........
r293158 | jpeeler | 2010-10-28 11:09:40 -0500 (Thu, 28 Oct 2010) | 11 lines
Fix infinite loop in FILTER().
Specifically when you're using characters above \x7f or invalid character
escapes (e.g. \xgg).
(closes issue #18060)
Reported by: wdoekes
Patches:
issue18060_func_strings_filter_infinite_loop.patch uploaded by wdoekes (license 717)
Tested by: wdoekes
........
................
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@293160
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Jeff Peeler [Tue, 26 Oct 2010 18:54:25 +0000 (18:54 +0000)]
Merged revisions 293119 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
................
r293119 | jpeeler | 2010-10-26 13:49:08 -0500 (Tue, 26 Oct 2010) | 43 lines
Merged revisions 293118 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2
................
r293118 | jpeeler | 2010-10-26 13:33:24 -0500 (Tue, 26 Oct 2010) | 36 lines
Merged revisions 293004 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r293004 | jpeeler | 2010-10-25 17:55:28 -0500 (Mon, 25 Oct 2010) | 29 lines
Fix inprocess_container in voicemail to correctly restrict max messages.
The comparison function logic was off, so the number of sessions for a given
mailbox were not being incremented properly. This problem caused the maximum
number of messages per folder to not be respected when simultaneously leaving
multiple voicemails just below the threshold.
These problems should be fixed by the above, but just in case:
Fixed resequence_mailbox to rely on the actual number of detected number of
files in a directory rather than just assuming only 10 messages more than the
maximum had been left. Also if more messages than the maximum are deleted they
are actually removed now.
The second purpose of this commit should have been separated out probably, but
is related to the above. Again, if the number of messages in a given voicemail
folder exceeds the maximum set limit make sure to allocate enough space for the
deleted and heard index tracking array.
A few random fixes:
There was a forgotten decrement of the inprocess count in imap_store_file.
When using IMAP storage, do not look in the directory where file based storage
messages may still reside and influence the message count.
Ensure to use only the first format in sendmail.
ABE-2516
........
................
................
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@293120
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Richard Mudgett [Tue, 26 Oct 2010 16:33:50 +0000 (16:33 +0000)]
Merged revisions 293081 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r293081 | rmudgett | 2010-10-26 11:32:59 -0500 (Tue, 26 Oct 2010) | 1 line
No need to define the struct if there are no users.
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@293082
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Richard Mudgett [Tue, 26 Oct 2010 16:01:08 +0000 (16:01 +0000)]
Merged revisions 293046 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r293046 | rmudgett | 2010-10-26 10:53:58 -0500 (Tue, 26 Oct 2010) | 4 lines
Allow the DAHDI driver to compile, even with a sufficiently older version of libpri.
Fixes our Bamboo builds.
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@293047
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Mon, 25 Oct 2010 21:16:25 +0000 (21:16 +0000)]
Merged revisions 292969 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r292969 | tilghman | 2010-10-25 16:15:19 -0500 (Mon, 25 Oct 2010) | 2 lines
Several more defines that need to be altered for compiling against an older version of libpri
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@292970
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Mon, 25 Oct 2010 19:30:39 +0000 (19:30 +0000)]
Merged revisions 292906 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r292906 | tilghman | 2010-10-25 14:28:35 -0500 (Mon, 25 Oct 2010) | 4 lines
Allow the DAHDI driver to compile, even with a sufficiently older version of libpri.
Fixes our Bamboo builds.
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@292915
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
David Vossel [Mon, 25 Oct 2010 19:11:42 +0000 (19:11 +0000)]
Merged revisions 292868 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
................
r292868 | dvossel | 2010-10-25 14:07:50 -0500 (Mon, 25 Oct 2010) | 39 lines
Merged revisions 292867 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2
................
r292867 | dvossel | 2010-10-25 14:06:21 -0500 (Mon, 25 Oct 2010) | 32 lines
Merged revisions 292866 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r292866 | dvossel | 2010-10-25 14:05:07 -0500 (Mon, 25 Oct 2010) | 27 lines
This patch turns chan_local pvts into astobj2 objects.
chan_local does some dangerous things involving deadlock avoidance.
tech_pvt functions like hangup and queue_frame are provided with a
locked channel upon entry. Those functions are completely safe as
long as you don't attempt to give up that channel lock, but that is
impossible to guarantee due to the required deadlock avoidance necessary
to lock both the tech_pvt and both channels involved.
In the past, we have tried to account for this by doing things like
setting a "glare" flag that indicates what function should destroy the
pvt. This was used in local_hangup and local_queue_frame to decided
who should destroy the pvt if they collided in separate threads. I
have removed the need to do this by converting all chan_local tech_pvts
to astobj2. This means we can ref a pvt before deadlock avoidance
and not have to worry about that pvt possibly getting destroyed under
us. It also cleans up where we destroy the tech_pvt. The only unlink
from the tech_pvt container occurs in local_hangup now, which is where
it should occur.
Since there still may be thread collisions on some functions like
local_hangup after deadlock avoidance, I have added some checks to detect
those collisions and exit appropriately. I think this patch is going to
solve quite a bit of weirdness we have had with local channels in the past.
........
................
................
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@292869
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Terry Wilson [Fri, 22 Oct 2010 22:40:55 +0000 (22:40 +0000)]
Merged revisions 292825 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r292825 | twilson | 2010-10-22 15:35:29 -0700 (Fri, 22 Oct 2010) | 4 lines
Don't create directories without at least o+x
Also, making files that you are going to modify read-only is dumb.
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@292826
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Terry Wilson [Fri, 22 Oct 2010 22:21:54 +0000 (22:21 +0000)]
Merged revisions 292794 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r292794 | twilson | 2010-10-22 15:18:36 -0700 (Fri, 22 Oct 2010) | 2 lines
Make files readable only by the owner
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@292808
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Leif Madsen [Fri, 22 Oct 2010 21:29:20 +0000 (21:29 +0000)]
Merged revisions 292787 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
................
r292787 | lmadsen | 2010-10-22 16:28:43 -0500 (Fri, 22 Oct 2010) | 21 lines
Merged revisions 292786 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2
........
r292786 | lmadsen | 2010-10-22 16:16:12 -0500 (Fri, 22 Oct 2010) | 13 lines
Update the LDIF file for LDAP.
The LDIF file asterisk.ldif was quite a bit out of date from the asterisk.ldap-schema file, so I've
now updated that to be in sync. The asterisk.ldif file being out of sync was a problem on my systems
where I was doing an ldapadd to import the schema into the LDAP database, and the existing file
would cause problems and ERROR messages when registering.
Additional documention has been added based on feedback in the issue I'm closing.
(closes issue #13861)
Reported by: scramatte
Patches:
ldap-update.txt uploaded by lmadsen (license 10)
Tested by: lmadsen, jcovert, suretec, rgenthner
........
................
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@292788
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Terry Wilson [Fri, 22 Oct 2010 17:16:57 +0000 (17:16 +0000)]
Merged revisions 292740 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r292740 | twilson | 2010-10-22 09:49:34 -0700 (Fri, 22 Oct 2010) | 45 lines
Add TLS cert helper script
This script is useful for quickly generating self-signed CA, server, and client
certificates for use with Asterisk. It is still recommended to obtain
certificates from a recognized Certificate Authority and to develop an
understanding how SSL certificates work. Real security is hard work.
OPTIONS:
-h Show this message
-m Type of cert "client" or "server". Defaults to server.
-f Config filename (openssl config file format)
-c CA cert filename (creates new CA cert/key as ca.crt/ca.key if not passed)
-k CA key filename
-C Common name (cert field)
For a server cert, this should be the same address that clients
attempt to connect to. Usually this will be the Fully Qualified
Domain Name, but might be the IP of the server. For a CA or client
cert, it is merely informational. Make sure your certs have unique
common names.
-O Org name (cert field)
An informational string (company name)
-o Output filename base (defaults to asterisk)
-d Output directory (defaults to the current directory)
Example:
To create a CA and a server (pbx.mycompany.com) cert with output in /tmp:
ast_tls_cert -C pbx.mycompany.com -O "My Company" -d /tmp
This will create a CA cert and key as well as asterisk.pem and the the two
files that it is made from: asterisk.crt and asterisk.key. Copy asterisk.pem
and ca.crt somewhere (like /etc/asterisk) and set tlscertfile=/etc/asterisk.pem
and tlscafile=/etc/ca.crt. Since this is a self-signed key, many devices will
require you to import the ca.crt file as a trusted cert.
To create a client cert using the CA cert created by the example above:
ast_tls_cert -m client -c /tmp/ca.crt -k /tmp/ca.key -C "Joe User" -O \
"My Company" -d /tmp -o joe_user
This will create client.crt/key/pem in /tmp. Use this if your device supports
a client certificate. Make sure that you have the ca.crt file set up as
a tlscafile in the necessary Asterisk configs. Make backups of all .key files
in case you need them later.
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@292743
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Mark Michelson [Fri, 22 Oct 2010 17:10:59 +0000 (17:10 +0000)]
Merged revisions 292741 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r292741 | mmichelson | 2010-10-22 12:09:52 -0500 (Fri, 22 Oct 2010) | 12 lines
Prevent multiple runs of event_sub_test from producing false failure results.
The array of test subscriptions was declared "static," meaning that the
data.count field would retain its value between runs of the test. After the
first test run, this would result in false reports of test failures.
I chose to just remove the "static" keyword from the structure since it's not
a huge deal to construct this structure during each run of the test. Another
alternative would have been to zero out the data.count fields of each test
subscription instead.
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@292742
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Richard Mudgett [Fri, 22 Oct 2010 15:47:56 +0000 (15:47 +0000)]
Merged revisions 292704 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r292704 | rmudgett | 2010-10-22 10:47:08 -0500 (Fri, 22 Oct 2010) | 19 lines
Connected line is not updated when chan_dahdi/sig_pri or chan_misdn transfers a call.
When a call is transfered by ECT or implicitly by disconnect in sig_pri or
implicitly by disconnect in chan_misdn, the connected line information is
not exchanged. The connected line interception macros also need to be
executed if defined.
The CALLER interception macro is executed for the held call.
The CALLEE interception macro is executed for the active/ringing call.
JIRA ABE-2589
JIRA SWP-2296
Patches:
abe_2589_c3bier.patch uploaded by rmudgett (license 664)
abe_2589_v1.8_v2.patch uploaded by rmudgett (license 664)
Review: https://reviewboard.asterisk.org/r/958/
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@292705
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Thu, 21 Oct 2010 22:11:24 +0000 (22:11 +0000)]
Merged revisions 292667 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r292667 | tilghman | 2010-10-21 17:09:25 -0500 (Thu, 21 Oct 2010) | 2 lines
Compile correctly on Linux (asterisk/localtime.h depends upon asterisk/autoconfig.h loading first).
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@292668
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Paul Belanger [Thu, 21 Oct 2010 18:23:41 +0000 (18:23 +0000)]
Merged revisions 292628 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r292628 | pabelanger | 2010-10-21 14:13:18 -0400 (Thu, 21 Oct 2010) | 5 lines
Fix typo in SUSE init script.
Reported by: Dave Cotton on asterisk-users list.
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@292630
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
David Vossel [Thu, 21 Oct 2010 16:46:15 +0000 (16:46 +0000)]
Merged revisions 292595 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r292595 | dvossel | 2010-10-21 11:14:33 -0500 (Thu, 21 Oct 2010) | 14 lines
Fixes recursive lock problem in manager.c
It is possible for a AMI session to freeze because of invalid
use of recursive locks during the EVENT processing. This
patch removes the unnecessary locks.
(closes issue #18167)
Reported by: sustav
Patches:
manager_locking_v1.diff uploaded by dvossel (license 671)
Tested by: sustav
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@292597
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Leif Madsen [Thu, 21 Oct 2010 13:17:24 +0000 (13:17 +0000)]
Merged revisions 292557 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
................
r292557 | lmadsen | 2010-10-21 08:12:19 -0500 (Thu, 21 Oct 2010) | 14 lines
Merged revisions 292556 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2
........
r292556 | lmadsen | 2010-10-21 08:11:52 -0500 (Thu, 21 Oct 2010) | 6 lines
Change res_ldap.sample.conf to match the schema.
(closes issue #17376)
Reported by: jcovert
Patches:
res_ldap.conf.sample.patch uploaded by jcovert (license 551)
........
................
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@292559
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Thu, 21 Oct 2010 11:38:14 +0000 (11:38 +0000)]
Merged revisions 292523 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r292523 | russell | 2010-10-21 06:36:47 -0500 (Thu, 21 Oct 2010) | 4 lines
Add var=value to log message on update failure, and add newline.
... just for you, Leif.
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@292524
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Richard Mudgett [Thu, 21 Oct 2010 01:03:42 +0000 (01:03 +0000)]
Merged revisions 292489 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r292489 | rmudgett | 2010-10-20 20:02:50 -0500 (Wed, 20 Oct 2010) | 7 lines
Send CONNECT_ACKNOWLEDGE for CIS calls too.
The originator of the Q.SIG call completion signaling link was not changed
to the active state when the CONNECT message came in. The T309 processing
would immediately kill the signaling link because it was not in the active
state.
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@292490
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Paul Belanger [Thu, 21 Oct 2010 00:23:32 +0000 (00:23 +0000)]
Merged revisions 292436 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r292436 | pabelanger | 2010-10-20 20:21:59 -0400 (Wed, 20 Oct 2010) | 8 lines
Application not properly unregister in voicemail
(closes issue #18128)
Reported by: junky
Patches:
vm_unregister.diff uploaded by junky (license 177)
Tested by: pabelanger, lmadsen
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@292443
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Paul Belanger [Thu, 21 Oct 2010 00:09:53 +0000 (00:09 +0000)]
Merged revisions 292413 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
................
r292413 | pabelanger | 2010-10-20 20:07:17 -0400 (Wed, 20 Oct 2010) | 24 lines
Merged revisions 292412 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2
................
r292412 | pabelanger | 2010-10-20 20:05:45 -0400 (Wed, 20 Oct 2010) | 17 lines
Merged revisions 292411 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r292411 | pabelanger | 2010-10-20 20:00:51 -0400 (Wed, 20 Oct 2010) | 10 lines
Record priv-recordintro as sln, not gsm
This removes the gsm->sln step when transcoding
priv-recordintro.
(closes issue #18176)
Reported by: pabelanger
Patches:
chan_sip.diff uploaded by pabelanger (license 224)
........
................
................
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@292414
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Wed, 20 Oct 2010 00:41:49 +0000 (00:41 +0000)]
Merged revisions 292376 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r292376 | tilghman | 2010-10-19 19:40:29 -0500 (Tue, 19 Oct 2010) | 5 lines
Oops. This module uses the generic timer and no longer uses DAHDI.
This causes a problem with the Solaris and other system builds that have gcc
4.1 (where optional_api is non-optional).
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@292377
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Paul Belanger [Tue, 19 Oct 2010 22:19:10 +0000 (22:19 +0000)]
Merged revisions 292343 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r292343 | pabelanger | 2010-10-19 18:14:23 -0400 (Tue, 19 Oct 2010) | 2 lines
Add resample and imap_tk dependencies.
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@292345
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Terry Wilson [Tue, 19 Oct 2010 19:35:24 +0000 (19:35 +0000)]
Merged revisions 292309 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r292309 | twilson | 2010-10-19 12:27:32 -0700 (Tue, 19 Oct 2010) | 10 lines
Add sip show peer info about crypto and remove dated comment
This patch adds information about the encryption setting to 'sip show
peers' and removes an out-of-date comment from res_srtp.c and instead
directs users to the proper documentation.
(closes issue #18140)
Reported by: chodorenko
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@292310
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Leif Madsen [Mon, 18 Oct 2010 22:14:05 +0000 (22:14 +0000)]
Merged revisions 292225 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
................
r292225 | lmadsen | 2010-10-18 16:51:23 -0500 (Mon, 18 Oct 2010) | 24 lines
Merged revisions 292224 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2
................
r292224 | lmadsen | 2010-10-18 16:50:47 -0500 (Mon, 18 Oct 2010) | 17 lines
Merged revisions 292222 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r292222 | lmadsen | 2010-10-18 16:47:25 -0500 (Mon, 18 Oct 2010) | 9 lines
Add support for the new English (Australian Accent) sound files.
(closes issue #17426)
Reported by: camsown
Patches:
core-sounds-en_AU.txt uploaded by camsown (license 1050)
add_AU_sounds.patch.txt uploaded by lmadsen (license 10)
Tested by: camsown, lmadsen, jtodd, qwell
........
................
................
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@292231
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Jeff Peeler [Mon, 18 Oct 2010 21:56:45 +0000 (21:56 +0000)]
Merged revisions 292227 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
................
r292227 | jpeeler | 2010-10-18 16:55:46 -0500 (Mon, 18 Oct 2010) | 25 lines
Merged revisions 292226 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2
................
r292226 | jpeeler | 2010-10-18 16:54:38 -0500 (Mon, 18 Oct 2010) | 18 lines
Merged revisions 292223 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r292223 | jpeeler | 2010-10-18 16:50:30 -0500 (Mon, 18 Oct 2010) | 11 lines
Fix improper operator key acceptance and clean up temp recording files.
This is a fix for when pressing the operator key after recording an unavailable,
busy, name, or temporary message in mailbox options. The operator key should not
be accepted here, but should be allowed during the message recording. If the
operator key is pressed during ensure the file is saved or deleted as
apporopriate. Also, ensure removal of temporary recorded files after an early
hang up or when message acceptance confirmation times out.
ABE-2518
........
................
................
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@292228
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Mon, 18 Oct 2010 19:52:58 +0000 (19:52 +0000)]
Merged revisions 292188 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r292188 | russell | 2010-10-18 14:50:04 -0500 (Mon, 18 Oct 2010) | 9 lines
Resolve some compiler errors in ast_sockaddr_is_any().
These errors came up once this function was used from within netsock2.c.
The errors were like the following:
netsock2.c:393: error: dereferencing pointer ‘({anonymous})’ does break strict-aliasing rules
The usage of a union here avoids this problem.
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@292189
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
David Vossel [Mon, 18 Oct 2010 19:16:48 +0000 (19:16 +0000)]
Merged revisions 292155 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r292155 | dvossel | 2010-10-18 14:16:00 -0500 (Mon, 18 Oct 2010) | 2 lines
Fixes build error for systems not supporting IPV6_TCLASS.
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@292156
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Matthew Nicholson [Mon, 18 Oct 2010 17:18:58 +0000 (17:18 +0000)]
Merged revisions 292122 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r292122 | mnicholson | 2010-10-18 12:15:24 -0500 (Mon, 18 Oct 2010) | 5 lines
Fix the cmgr parser.
(closes issue 0018152)
Reported by: menschentier
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@292124
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
David Vossel [Mon, 18 Oct 2010 16:03:24 +0000 (16:03 +0000)]
Merged revisions 292085 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r292085 | dvossel | 2010-10-18 11:02:17 -0500 (Mon, 18 Oct 2010) | 7 lines
Fixes qos settings for sockets bound to any IPv6 or IPv4 address.
(closes issue #18099)
Reported by: jamesnet
Patches:
issues_18099_v3.diff uploaded by dvossel (license 671
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@292086
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Jeff Peeler [Mon, 18 Oct 2010 15:33:35 +0000 (15:33 +0000)]
Merged revisions 292083 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r292083 | jpeeler | 2010-10-18 10:32:40 -0500 (Mon, 18 Oct 2010) | 4 lines
Disable use of inotify for call file handling as it is not working properly.
(related to #18089)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@292084
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tzafrir Cohen [Sat, 16 Oct 2010 11:51:54 +0000 (11:51 +0000)]
Merged revisions 292050 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
................
r292050 | tzafrir | 2010-10-16 12:47:00 +0200 (ש', 16 אוק 2010) | 22 lines
Merged revisions 292049 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2
........
r292049 | tzafrir | 2010-10-16 12:03:04 +0200 (ש', 16 אוק 2010) | 15 lines
Base directory for MOH should be ASTDATADIR
If the directive 'directory' is relative, make it relative to the
datadir, rather than to the varlibdir. In the sample configuration
it is relative ('moh').
This has no effect unless you have actively set the datadir explicitly
(at build time or at run time).
(closes issue #16906)
Patches:
moh_datadir uploaded by tzafrir (license 46)
Review: https://reviewboard.asterisk.org/r/974/
........
................
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@292052
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Terry Wilson [Fri, 15 Oct 2010 21:49:49 +0000 (21:49 +0000)]
Merged revisions 292016 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r292016 | twilson | 2010-10-15 16:40:56 -0500 (Fri, 15 Oct 2010) | 5 lines
Ref/unref res_srtp when we create/destroy a session
This avoids unhappy crashing when we try to 'core stop gracefully' and res_srtp
tries to unload before chan_sip does. Thanks, Russell!
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@292017
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
David Vossel [Fri, 15 Oct 2010 20:12:46 +0000 (20:12 +0000)]
Merged revisions 291942 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r291942 | dvossel | 2010-10-15 15:12:04 -0500 (Fri, 15 Oct 2010) | 8 lines
Fixes peer's host port information being lost on sip reload.
(closes issue #18135)
Reported by: lmadsen
Patches:
crazy_ports_v2.diff uploaded by dvossel (license 671)
Tested by: lmadsen
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@291943
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Paul Belanger [Fri, 15 Oct 2010 19:53:06 +0000 (19:53 +0000)]
Merged revisions 291940 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
................
r291940 | pabelanger | 2010-10-15 15:50:22 -0400 (Fri, 15 Oct 2010) | 16 lines
Merged revisions 291939 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2
................
r291939 | pabelanger | 2010-10-15 15:35:20 -0400 (Fri, 15 Oct 2010) | 9 lines
Merged revisions 291938 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r291938 | pabelanger | 2010-10-15 15:30:41 -0400 (Fri, 15 Oct 2010) | 2 lines
Clean up formatting.
........
................
................
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@291941
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Terry Wilson [Fri, 15 Oct 2010 16:54:07 +0000 (16:54 +0000)]
Merged revisions 291905 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
................
r291905 | twilson | 2010-10-15 09:39:58 -0700 (Fri, 15 Oct 2010) | 14 lines
Merged revisions 291904 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2
........
r291904 | twilson | 2010-10-15 09:16:57 -0700 (Fri, 15 Oct 2010) | 7 lines
Don't crash or deadlock on module unload
We can't hold the lock while pthread_join is called since aji_log_hook will
attempt to lock from the other therad. We reorder the pthread_join and
ast_aji_disconnect so that we don't do an SSL_read() while SSL_shutdown is
running, causing a crash.
........
................
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@291906
65c4cc65-6c06-0410-ace0-
fbb531ad65f3