asterisk/asterisk.git
15 years agoAdd a cmenuselect/cmenuconfig, to force curses.
Jason Parker [Wed, 5 Mar 2008 23:21:52 +0000 (23:21 +0000)]
Add a cmenuselect/cmenuconfig, to force curses.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@106250 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoAdd the nmenuselect makefile targets. This is a newt menuselect interface which
Russell Bryant [Wed, 5 Mar 2008 22:50:00 +0000 (22:50 +0000)]
Add the nmenuselect makefile targets.  This is a newt menuselect interface which
was written by seanbright.  It is much sexier than my curses one.  :)

(issue #12139)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@106240 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoMerged revisions 106235 via svnmerge from
Joshua Colp [Wed, 5 Mar 2008 22:43:22 +0000 (22:43 +0000)]
Merged revisions 106235 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r106235 | file | 2008-03-05 18:32:10 -0400 (Wed, 05 Mar 2008) | 4 lines

Add a control frame to indicate the source of media has changed. Depending on the underlying technology it may need to change some things.
(closes issue #12148)
Reported by: jcomellas

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@106239 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoMerged revisions 106237 via svnmerge from
Russell Bryant [Wed, 5 Mar 2008 22:40:58 +0000 (22:40 +0000)]
Merged revisions 106237 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r106237 | russell | 2008-03-05 16:37:09 -0600 (Wed, 05 Mar 2008) | 3 lines

Fix a potential deadlock and a few different potential crashes.
(closes issue #12145, reported by thiagarcia, patched by me)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@106238 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoAdding the Atxfer manager command. With this, you may initiate
Mark Michelson [Wed, 5 Mar 2008 22:33:05 +0000 (22:33 +0000)]
Adding the Atxfer manager command. With this, you may initiate
an attended transfer over AMI

(closes issue #10585)
Reported by: ornati
Patches:
      atxfer-trunk-r90428.diff uploaded by ornati (license 210)
  (with modifications from me)
Tested by: putnopvut

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@106236 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agodocument var_metric usage to prevent bugreports that are actually configuration issues
Michiel van Baak [Wed, 5 Mar 2008 21:19:06 +0000 (21:19 +0000)]
document var_metric usage to prevent bugreports that are actually configuration issues

(closes issue #12151)
Reported by: caio1982
Patches:
      DB_metric3.diff uploaded by caio1982 (license 22)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@106186 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoBlocked revisions 106178 via svnmerge
Michiel van Baak [Wed, 5 Mar 2008 21:15:57 +0000 (21:15 +0000)]
Blocked revisions 106178 via svnmerge

........
r106178 | mvanbaak | 2008-03-05 22:12:36 +0100 (Wed, 05 Mar 2008) | 5 lines

document var_metric so no bugreports will come in when it's actually a configuration issue.
(issue #12151)
Reported and patched by: caio1982
1.4 patch by me

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@106179 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoShould check these values for non-NULL before scanning.
Tilghman Lesher [Wed, 5 Mar 2008 17:40:42 +0000 (17:40 +0000)]
Should check these values for non-NULL before scanning.
(Closes issue #12147)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@106139 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoFix code up to what it was meant to be.
Joshua Colp [Wed, 5 Mar 2008 16:39:22 +0000 (16:39 +0000)]
Fix code up to what it was meant to be.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@106110 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoCreate a centralized configuration option for silencethreshold
Tilghman Lesher [Wed, 5 Mar 2008 16:23:44 +0000 (16:23 +0000)]
Create a centralized configuration option for silencethreshold
(closes issue #11236)
 Reported by: philipps
 Patches:
       20080218__bug11236.diff.txt uploaded by Corydon76 (license 14)
 Tested by: philipps

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@106072 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoMerged revisions 106038 via svnmerge from
Kevin P. Fleming [Wed, 5 Mar 2008 15:40:40 +0000 (15:40 +0000)]
Merged revisions 106038 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r106038 | kpfleming | 2008-03-05 09:32:35 -0600 (Wed, 05 Mar 2008) | 7 lines

when a PRI call must be moved to a different B channel at the request of the other endpoint, ensure that any DSP active on the original channel is moved to the new one

(closes issue #11917)
Reported by: mavetju
Tested by: mavetju

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@106040 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoMerged revisions 106015 via svnmerge from
Tilghman Lesher [Wed, 5 Mar 2008 15:23:32 +0000 (15:23 +0000)]
Merged revisions 106015 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r106015 | tilghman | 2008-03-05 09:17:16 -0600 (Wed, 05 Mar 2008) | 7 lines

Correctly initialize retransid in SIP, and ensure that the warning when failing to delete a schedule entry can actually hit the log.
(closes issue #12140)
 Reported by: slavon
 Patches:
       sch2.patch uploaded by slavon (license 288)
(Patch slightly modified by me)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@106036 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years ago - simplify a few statements with ARRAY_LEN()
Russell Bryant [Wed, 5 Mar 2008 04:34:29 +0000 (04:34 +0000)]
 - simplify a few statements with ARRAY_LEN()
 - constify the stregy int to string mappings array

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@105984 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoMerged revisions 105932 via svnmerge from
Russell Bryant [Wed, 5 Mar 2008 01:54:16 +0000 (01:54 +0000)]
Merged revisions 105932 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r105932 | russell | 2008-03-04 19:52:18 -0600 (Tue, 04 Mar 2008) | 5 lines

Fix a bug that I just noticed in the RTP code.  The calculation for setting the
len field in an ast_frame of audio was wrong when G.722 is in use.  The len field
represents the number of ms of audio that the frame contains.  It would have
set the value to be twice what it should be.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@105933 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoFix the SHARED() read callback to properly unlock the channel. This function
Russell Bryant [Wed, 5 Mar 2008 00:45:39 +0000 (00:45 +0000)]
Fix the SHARED() read callback to properly unlock the channel.  This function
could not have worked, as it left the channel locked in all cases.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@105899 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoThere are several places in manager.c where BUFSIZ is used for a buffer
Mark Michelson [Tue, 4 Mar 2008 23:24:56 +0000 (23:24 +0000)]
There are several places in manager.c where BUFSIZ is used for a buffer
which will contain nowhere near that amount of data. This makes these buffers
more reasonably sized.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@105864 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoFix minor misuses of snprintf
Tilghman Lesher [Tue, 4 Mar 2008 23:10:45 +0000 (23:10 +0000)]
Fix minor misuses of snprintf

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@105841 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoWhitespace changes only
Tilghman Lesher [Tue, 4 Mar 2008 23:04:29 +0000 (23:04 +0000)]
Whitespace changes only

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@105840 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoadd a destroy API call for a server instance
Russell Bryant [Tue, 4 Mar 2008 22:28:03 +0000 (22:28 +0000)]
add a destroy API call for a server instance

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@105804 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoMore public API name changes to use an appropriate ast_ prefix
Russell Bryant [Tue, 4 Mar 2008 22:23:21 +0000 (22:23 +0000)]
More public API name changes to use an appropriate ast_ prefix

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@105785 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoRename public object server_instance to ast_tcptls_server_instance
Russell Bryant [Tue, 4 Mar 2008 22:15:18 +0000 (22:15 +0000)]
Rename public object server_instance to ast_tcptls_server_instance

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@105773 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoFix some bugs in the SIP tcp helper thread.
Russell Bryant [Tue, 4 Mar 2008 20:36:16 +0000 (20:36 +0000)]
Fix some bugs in the SIP tcp helper thread.
 - fix a spot where a lock wouldn't get unlocked in an error condition
 - call ast_mutex_destroy() on the lock before freeing its memory

(related to issue #11972)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@105734 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoSet username to default to the category name if it isn't overridden by a usernmae...
Terry Wilson [Tue, 4 Mar 2008 20:32:55 +0000 (20:32 +0000)]
Set username to default to the category name if it isn't overridden by a usernmae= setting in users.conf

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@105733 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoMerged revisions 105676 via svnmerge from
Joshua Colp [Tue, 4 Mar 2008 18:11:38 +0000 (18:11 +0000)]
Merged revisions 105676 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r105676 | file | 2008-03-04 14:10:34 -0400 (Tue, 04 Mar 2008) | 2 lines

In addition to setting the marker bit let's change our ssrc so they know for sure it is a different source.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@105677 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoMerged revisions 105674 via svnmerge from
Joshua Colp [Tue, 4 Mar 2008 18:08:42 +0000 (18:08 +0000)]
Merged revisions 105674 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r105674 | file | 2008-03-04 14:05:28 -0400 (Tue, 04 Mar 2008) | 8 lines

When a new source of audio comes in (such as music on hold) make sure the marker bit gets set.
(closes issue #10355)
Reported by: wdecarne
Patches:
      10355.diff uploaded by file (license 11)
(closes issue #11491)
Reported by: kanderson

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@105675 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoUpdate CHANGES heading
Russell Bryant [Tue, 4 Mar 2008 16:55:17 +0000 (16:55 +0000)]
Update CHANGES heading

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@105597 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoSimplify a trivial snprintf() with ast_copy_string()
Russell Bryant [Tue, 4 Mar 2008 04:57:29 +0000 (04:57 +0000)]
Simplify a trivial snprintf() with ast_copy_string()

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@105595 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoMake it so you don't have to cast away const in a couple places
Russell Bryant [Tue, 4 Mar 2008 04:47:32 +0000 (04:47 +0000)]
Make it so you don't have to cast away const in a couple places

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@105594 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoremove unnecessary casts
Russell Bryant [Tue, 4 Mar 2008 04:44:28 +0000 (04:44 +0000)]
remove unnecessary casts

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@105593 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoBlocked revisions 105591 via svnmerge
Russell Bryant [Tue, 4 Mar 2008 04:31:53 +0000 (04:31 +0000)]
Blocked revisions 105591 via svnmerge

........
r105591 | russell | 2008-03-03 22:31:29 -0600 (Mon, 03 Mar 2008) | 4 lines

Backport a minor bug fix from trunk that I found while doing random code
cleanup.  Properly break out of the loop when a context isn't found when
verify that includes are valid.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@105592 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years ago - Add curly braces around the while loop
Russell Bryant [Tue, 4 Mar 2008 04:28:48 +0000 (04:28 +0000)]
 - Add curly braces around the while loop
 - Properly break out of the loop on error when an included context is not found

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@105590 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoUse ast_copy_string() instead of strncpy(), and use sizeof() instead of
Russell Bryant [Tue, 4 Mar 2008 04:26:39 +0000 (04:26 +0000)]
Use ast_copy_string() instead of strncpy(), and use sizeof() instead of
a magic number

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@105589 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoFix some code that was improperly changed in revision 104866 from issue #12079.
Russell Bryant [Mon, 3 Mar 2008 18:49:34 +0000 (18:49 +0000)]
Fix some code that was improperly changed in revision 104866 from issue #12079.

(closes issue #12129, reported by elguero, patched by me)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@105574 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoMerged revisions 105572 via svnmerge from
Jason Parker [Mon, 3 Mar 2008 18:08:05 +0000 (18:08 +0000)]
Merged revisions 105572 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r105572 | qwell | 2008-03-03 12:06:52 -0600 (Mon, 03 Mar 2008) | 7 lines

Fix types for astNumChannels and astConfigCallsProcessed.

(closes issue #12114)
Reported by: jeffg
Patches:
      12114.patch uploaded by jeffg (license 192)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@105573 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoMerged revisions 105570 via svnmerge from
Russell Bryant [Mon, 3 Mar 2008 17:17:27 +0000 (17:17 +0000)]
Merged revisions 105570 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r105570 | russell | 2008-03-03 11:16:53 -0600 (Mon, 03 Mar 2008) | 3 lines

In the case of an ast_channel allocation failure, take the local_pvt out of the
pvt list before destroying it.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@105571 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoMerged revisions 105568 via svnmerge from
Russell Bryant [Mon, 3 Mar 2008 17:06:35 +0000 (17:06 +0000)]
Merged revisions 105568 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r105568 | russell | 2008-03-03 11:05:16 -0600 (Mon, 03 Mar 2008) | 3 lines

Fix a potential memory leak of the local_pvt struct when ast_channel allocation
fails.  Also, in passing, centralize the code necessary to destroy a local_pvt.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@105569 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoMerged revisions 105565 via svnmerge from
Russell Bryant [Mon, 3 Mar 2008 16:02:19 +0000 (16:02 +0000)]
Merged revisions 105565 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r105565 | russell | 2008-03-03 10:01:50 -0600 (Mon, 03 Mar 2008) | 3 lines

Update the copyright information for autoservice.  Most of the code in this file
now is stuff that I have written recently ...

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@105566 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years ago3) In addition to merging the changes below, change trunk back to a regular
Russell Bryant [Mon, 3 Mar 2008 15:59:50 +0000 (15:59 +0000)]
3) In addition to merging the changes below, change trunk back to a regular
   LIST instead of an RWLIST.  The way this list works makes it such that
   a RWLIST provides no additional benefit.  Also, a mutex is needed for
   use with the thread condition.

Merged revisions 105563 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r105563 | russell | 2008-03-03 09:50:43 -0600 (Mon, 03 Mar 2008) | 24 lines

Merge in some changes from team/russell/autoservice-nochans-1.4

These changes fix up some dubious code that I came across while auditing what
happens in the autoservice thread when there are no channels currently in
autoservice.

1) Change it so that autoservice thread doesn't keep looping around calling
   ast_waitfor_n() on 0 channels twice a second.  Instead, use a thread condition
   so that the thread properly goes to sleep and does not wake up until a
   channel is put into autoservice.

   This actually fixes an interesting bug, as well.  If the autoservice thread
   is already running (almost always is the case), then when the thread goes
   from having 0 channels to have 1 channel to autoservice, that channel would
   have to wait for up to 1/2 of a second to have the first frame read from it.

2) Fix up the code in ast_waitfor_nandfds() for when it gets called with no
   channels and no fds to poll() on, such as was the case with the previous code
   for the autoservice thread.  In this case, the code would call alloca(0), and
   pass the result as the first argument to poll().  In this case, the 2nd
   argument to poll() specified that there were no fds, so this invalid pointer
   shouldn't actually get dereferenced, but, this code makes it explicit and
   ensures the pointers are NULL unless we have valid data to put there.

(related to issue #12116)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@105564 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoMerged revisions 105560 via svnmerge from
Joshua Colp [Mon, 3 Mar 2008 15:30:29 +0000 (15:30 +0000)]
Merged revisions 105560 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r105560 | file | 2008-03-03 11:28:59 -0400 (Mon, 03 Mar 2008) | 7 lines

It is possible for no audio to pass between the current digit and next digit so expand logic that clears emulation to AST_FRAME_NULL.
(closes issue #11911)
Reported by: edgreenberg
Patches:
      v1-11911.patch uploaded by dimas (license 88)
Tested by: tbsky

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@105561 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoMerged revisions 105557 via svnmerge from
Joshua Colp [Mon, 3 Mar 2008 15:16:57 +0000 (15:16 +0000)]
Merged revisions 105557 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r105557 | file | 2008-03-03 11:15:39 -0400 (Mon, 03 Mar 2008) | 6 lines

Add a comment to describe some logic.
(closes issue #12120)
Reported by: flefoll
Patches:
      chan_sip.c.br14.patch-just-a-comment uploaded by flefoll (license 244)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@105558 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoAdd support for 16KHz signed linear.
Joshua Colp [Sat, 1 Mar 2008 03:59:41 +0000 (03:59 +0000)]
Add support for 16KHz signed linear.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@105509 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoDrop bad property
Tilghman Lesher [Sat, 1 Mar 2008 02:03:51 +0000 (02:03 +0000)]
Drop bad property

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@105479 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoAsterisk, when parking can drop rights a caller when a parking timeout occurs. Also...
Terry Wilson [Sat, 1 Mar 2008 01:30:37 +0000 (01:30 +0000)]
Asterisk, when parking can drop rights a caller when a parking timeout occurs.  Also, when doing built-in attended transfers, sometimes incorrectly passes rights from the transferrer to the transferee.  This patch tries to fixes the parking issue and lays some groundwork for later fixing the transfer issue.

(closes issue #11520)
Reported by: pliew
Tested by: otherwiseguy

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@105477 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoAdd a "devstate change" CLI command to control custom device states. Also,
Russell Bryant [Sat, 1 Mar 2008 00:53:25 +0000 (00:53 +0000)]
Add a "devstate change" CLI command to control custom device states.  Also,
do some additional code cleanup and improvement in passing.

(closes issue #12106)
Reported by: nizon
Patches:
      devstate-patch.txt uploaded by nizon (license 415)
        -- Updated to trunk, and tab completion added by me

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@105461 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoConvert to use ast_str
Tilghman Lesher [Fri, 29 Feb 2008 23:53:42 +0000 (23:53 +0000)]
Convert to use ast_str

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@105411 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoMerged revisions 105409 via svnmerge from
Russell Bryant [Fri, 29 Feb 2008 23:36:46 +0000 (23:36 +0000)]
Merged revisions 105409 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r105409 | russell | 2008-02-29 17:34:32 -0600 (Fri, 29 Feb 2008) | 23 lines

Fix a major bug in autoservice.  There was a race condition in the handling of
the list of channels in autoservice.  The problem was that it was possible for
a channel to get removed from autoservice and destroyed, while the autoservice
thread was still messing with the channel.  This led to memory corruption, and
caused crashes.  This explains multiple backtraces I have seen that have
references to autoservice, but do to the nature of the issue (memory corruption),
could cause crashes in a number of areas.

(fixes the crash in BE-386)
(closes issue #11694)
(closes issue #11940)

The following issues could be related.  If you are the reporter of one of these,
please update to include this fix and try again.

(potentially fixes issue #11189)
(potentially fixes issue #12107)
(potentially fixes issue #11573)
(potentially fixes issue #12008)
(potentially fixes issue #11189)
(potentially fixes issue #11993)
(potentially fixes issue #11791)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@105410 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoAdd documentation for setting username/password in SIP dial string.
Joshua Colp [Fri, 29 Feb 2008 18:34:46 +0000 (18:34 +0000)]
Add documentation for setting username/password in SIP dial string.
(closes issue #11587)
Reported by: sobomax
Patches:
      dialstring_doc.diff uploaded by sobomax (license 359)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@105378 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoMerged revisions 105326 via svnmerge from
Philippe Sultan [Fri, 29 Feb 2008 14:50:40 +0000 (14:50 +0000)]
Merged revisions 105326 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r105326 | phsultan | 2008-02-29 15:47:10 +0100 (Fri, 29 Feb 2008) | 1 line

Fix a potential memory leak
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@105327 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoRemove unnecessary if statements before calling iks_delete (redundant check is
Philippe Sultan [Fri, 29 Feb 2008 14:15:03 +0000 (14:15 +0000)]
Remove unnecessary if statements before calling iks_delete (redundant check is
done inside iks_delete), thus making the code conform with coding guidelines.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@105263 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoMerged revisions 105261 via svnmerge from
Joshua Colp [Fri, 29 Feb 2008 13:55:22 +0000 (13:55 +0000)]
Merged revisions 105261 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r105261 | file | 2008-02-29 09:48:13 -0400 (Fri, 29 Feb 2008) | 4 lines

Bump up the size of the uniqueid variable.
(closes issue #12107)
Reported by: asgaroth

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@105262 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoAutomatically create new buddy upon reception of a presence stanza of
Philippe Sultan [Fri, 29 Feb 2008 13:12:34 +0000 (13:12 +0000)]
Automatically create new buddy upon reception of a presence stanza of
type subscribed.

(closes issue #12066)
Reported by: ffadaie
Patches:
      branch-1.4-12066-1.diff uploaded by phsultan (license 73)
      trunk-12066-1.diff uploaded by phsultan (license 73)
Tested by: ffadaie, phsultan

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@105210 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoMerged revisions 105113 via svnmerge from
Tilghman Lesher [Fri, 29 Feb 2008 01:15:20 +0000 (01:15 +0000)]
Merged revisions 105113 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r105113 | tilghman | 2008-02-28 15:56:54 -0600 (Thu, 28 Feb 2008) | 7 lines

Update init script for LSB compat
(closes issue #9843)
 Reported by: ibc
 Patches:
       rc.debian.asterisk.patch uploaded by ibc (license 211)
 Tested by: paravoid

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@105176 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoMerged revisions 105116 via svnmerge from
Russell Bryant [Thu, 28 Feb 2008 22:39:26 +0000 (22:39 +0000)]
Merged revisions 105116 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r105116 | russell | 2008-02-28 16:23:05 -0600 (Thu, 28 Feb 2008) | 8 lines

Fix a bug in the lock tracking code that was discovered by mmichelson.  The issue
is that if the lock history array was full, then the functions to mark a lock as
acquired or not would adjust the stats for whatever lock is at the end of the array,
which may not be itself.  So, do a sanity check to make sure that we're updating
lock info for the proper lock.

(This explains the bizarre stats on lock #63 in BE-396, thanks Mark!)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@105144 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoMerged revisions 105059 via svnmerge from
Mark Michelson [Thu, 28 Feb 2008 20:14:38 +0000 (20:14 +0000)]
Merged revisions 105059 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r105059 | mmichelson | 2008-02-28 14:11:57 -0600 (Thu, 28 Feb 2008) | 6 lines

When using autofill, members who are in use should be counted towards the
number of available members to call if ringinuse is set to yes.

Thanks to jmls who brought this issue up on IRC

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@105061 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoMerged revisions 104841 via svnmerge from
Mark Michelson [Thu, 28 Feb 2008 20:14:04 +0000 (20:14 +0000)]
Merged revisions 104841 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r104841 | mmichelson | 2008-02-27 15:49:20 -0600 (Wed, 27 Feb 2008) | 17 lines

Two fixes:

1. Make the list of ast_dial_channels a lockable list. This is because in some cases,
   the ast_dial may exist in multiple threads due to asynchronous execution of its application, and
   I found some cases where race conditions could exist.

2. Check in ast_dial_join to be sure that the channel still exists before attempting to lock it, since
   it could have gotten hung up but the is_running_app flag on the ast_dial_channel may not have been
   cleared yet.

(closes issue #12038)
Reported by: jvandal
Patches:
      12038v2.patch uploaded by putnopvut (license 60)
Tested by: jvandal

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@105060 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoMerged revisions 105005 via svnmerge from
Jason Parker [Thu, 28 Feb 2008 19:21:15 +0000 (19:21 +0000)]
Merged revisions 105005 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r105005 | qwell | 2008-02-28 13:20:10 -0600 (Thu, 28 Feb 2008) | 9 lines

Make pbx_exec pass an empty string into applications, if we get NULL.
This protects against possible segfaults in applications that may try
 to use data before checking length (ast_strdupa'ing it, for example)

(closes issue #12100)
Reported by: foxfire
Patches:
      12100-nullappargs.diff uploaded by qwell (license 4)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@105006 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoFix crash when configuration does not match hardware detection.
Tilghman Lesher [Thu, 28 Feb 2008 14:42:32 +0000 (14:42 +0000)]
Fix crash when configuration does not match hardware detection.
(closes issue #12096)
 Reported by: mmickan
 Patches:
       chan_vpb.cc.diff uploaded by mmickan (license 400)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@104974 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoMerged revisions 104920 via svnmerge from
Jason Parker [Thu, 28 Feb 2008 04:37:28 +0000 (04:37 +0000)]
Merged revisions 104920 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r104920 | qwell | 2008-02-27 22:31:21 -0600 (Wed, 27 Feb 2008) | 2 lines

According to a video at www.cisco.com, the 7921G supports 6 line appearances.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@104921 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoMerged revisions 104868 via svnmerge from
Tilghman Lesher [Thu, 28 Feb 2008 00:11:31 +0000 (00:11 +0000)]
Merged revisions 104868 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r104868 | tilghman | 2008-02-27 18:05:06 -0600 (Wed, 27 Feb 2008) | 7 lines

Compatibility fix for PPC64
(closes issue #12081)
 Reported by: jcollie
 Patches:
       asterisk-1.4.18-funcdesc.patch uploaded by jcollie (license 412)
 Tested by: jcollie, Corydon76

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@104869 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoreduce indentation in alloc_sub
Russell Bryant [Wed, 27 Feb 2008 23:58:49 +0000 (23:58 +0000)]
reduce indentation in alloc_sub
(issue #12079)
Reported by: tzafrir
Patches:
      alloc_sub uploaded by tzafrir (license 46)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@104866 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoMerged revisions 104787 via svnmerge from
Joshua Colp [Wed, 27 Feb 2008 21:02:08 +0000 (21:02 +0000)]
Merged revisions 104787 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r104787 | file | 2008-02-27 16:56:23 -0400 (Wed, 27 Feb 2008) | 2 lines

Don't loop around infinitely trying to spy on our own channel, and don't forget to free/detach the datastore upon hangup of the spy.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@104788 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoMerged revisions 104783 via svnmerge from
Mark Michelson [Wed, 27 Feb 2008 20:37:32 +0000 (20:37 +0000)]
Merged revisions 104783 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r104783 | mmichelson | 2008-02-27 14:36:26 -0600 (Wed, 27 Feb 2008) | 4 lines

Bump a couple of more buffers up by 2 so that annoying warnings aren't generated
like crazy on every fileexists_core call.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@104784 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoRemove useless 's' and 'key' variables, in favor of 'val', which serves the exact...
Jason Parker [Wed, 27 Feb 2008 19:36:34 +0000 (19:36 +0000)]
Remove useless 's' and 'key' variables, in favor of 'val', which serves the exact same purpose.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@104756 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoMerged revisions 104704 via svnmerge from
Tilghman Lesher [Wed, 27 Feb 2008 18:20:35 +0000 (18:20 +0000)]
Merged revisions 104704 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r104704 | tilghman | 2008-02-27 12:15:10 -0600 (Wed, 27 Feb 2008) | 2 lines

Ensure the session ID can't be 0.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@104705 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoMerged revisions 104665 via svnmerge from
Joshua Colp [Wed, 27 Feb 2008 17:45:55 +0000 (17:45 +0000)]
Merged revisions 104665 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r104665 | file | 2008-02-27 13:41:40 -0400 (Wed, 27 Feb 2008) | 2 lines

Bump up the buffer by 2.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@104687 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoMerged revisions 104625 via svnmerge from
Russell Bryant [Wed, 27 Feb 2008 17:36:50 +0000 (17:36 +0000)]
Merged revisions 104625 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r104625 | russell | 2008-02-27 11:33:04 -0600 (Wed, 27 Feb 2008) | 4 lines

Fix a problem in ChanSpy where it could get stuck in an infinite loop without
being able to detect that the calling channel hung up.
(closes issue #12076, reported by junky, patched by me)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@104643 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoMerged revisions 104598 via svnmerge from
Jason Parker [Wed, 27 Feb 2008 17:31:31 +0000 (17:31 +0000)]
Merged revisions 104598 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r104598 | qwell | 2008-02-27 11:26:55 -0600 (Wed, 27 Feb 2008) | 8 lines

Inherit language from the transfering channel on a blind transfer.

(closes issue #11682)
Reported by: caio1982
Patches:
      local_atxfer_lang3-1.4.diff uploaded by caio1982 (license 22)
Tested by: caio1982, victoryure

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@104617 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoMerged revisions 104596 via svnmerge from
Joshua Colp [Wed, 27 Feb 2008 17:12:08 +0000 (17:12 +0000)]
Merged revisions 104596 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r104596 | file | 2008-02-27 13:07:33 -0400 (Wed, 27 Feb 2008) | 4 lines

Use the lock (which already existed, it just wasn't used) on the updaters list to protect the contents instead of the overall module list lock.
(closes issue #12080)
Reported by: ChaseVenters

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@104597 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoAfter further discussion revert my previous commit for this. Currently in order to...
Joshua Colp [Wed, 27 Feb 2008 17:04:16 +0000 (17:04 +0000)]
After further discussion revert my previous commit for this. Currently in order to ensure devicestate is the expected value in another module (such as app_queue) then chan_sip must be loaded before hand.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@104595 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoMerged revisions 104593 via svnmerge from
Kevin P. Fleming [Wed, 27 Feb 2008 16:54:14 +0000 (16:54 +0000)]
Merged revisions 104593 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r104593 | kpfleming | 2008-02-27 10:53:06 -0600 (Wed, 27 Feb 2008) | 8 lines

fallback to standard English prompts properly when using new prompt directory layout

(closes issue #11831)
Reported by: IgorG
Patches:
      fallbacken.v1.diff uploaded by IgorG (license 20) (modified by me to improve code and conform rest of function to coding guidelines)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@104594 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoBlocked revisions 104591 via svnmerge
Russell Bryant [Wed, 27 Feb 2008 16:46:49 +0000 (16:46 +0000)]
Blocked revisions 104591 via svnmerge

........
r104591 | russell | 2008-02-27 10:45:00 -0600 (Wed, 27 Feb 2008) | 4 lines

When we receive a known alarm, make sure that the unknown alarm flag is not still
set to make sure that when we come back out of alarm, it gets reported in the log
and manager interface (after discussion with tzafrir on the -dev list)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@104592 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoWhen queueing up a device state change when the peer is loaded from the configuration...
Joshua Colp [Wed, 27 Feb 2008 16:26:57 +0000 (16:26 +0000)]
When queueing up a device state change when the peer is loaded from the configuration give it a state of not in use. We have to do this because the channel technology may not yet be registered so the state could not be queried and would be considered invalid.
(closes issue #12087)
Reported by: liorm

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@104539 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoMerged revisions 104536 via svnmerge from
Joshua Colp [Wed, 27 Feb 2008 15:58:28 +0000 (15:58 +0000)]
Merged revisions 104536 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r104536 | file | 2008-02-27 11:52:02 -0400 (Wed, 27 Feb 2008) | 4 lines

Only stop the MWI monitor thread if it was actually started.
(closes issue #12086)
Reported by: francesco_r

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@104537 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoopen(2) needs a mode argument when O_CREAT is specified.
Tilghman Lesher [Wed, 27 Feb 2008 15:34:28 +0000 (15:34 +0000)]
open(2) needs a mode argument when O_CREAT is specified.
(Closes issue #12083)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@104534 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoFix T38 passthrough regression introduced by state changes.
Joshua Colp [Wed, 27 Feb 2008 15:31:09 +0000 (15:31 +0000)]
Fix T38 passthrough regression introduced by state changes.
(closes issue #12078)
Reported by: dimas
Patches:
      v1-12078.patch uploaded by dimas (license 88)
(closes issue #12074)
Reported by: Ivan

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@104533 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoBring Voicetronix driver up to date with current drivers
Tilghman Lesher [Wed, 27 Feb 2008 08:20:15 +0000 (08:20 +0000)]
Bring Voicetronix driver up to date with current drivers
(closes issue #12084)
 Reported by: mmickan
 Patches:
       chan_vpb.cc.diff uploaded by mmickan (license 400)
       module.h.diff uploaded by mmickan (license 400)
       vpb.conf.sample uploaded by mmickan (license 400)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@104502 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agonote that the chan_sip conversion is already in progress
Russell Bryant [Wed, 27 Feb 2008 04:42:59 +0000 (04:42 +0000)]
note that the chan_sip conversion is already in progress

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@104473 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoadd another janitor project
Russell Bryant [Wed, 27 Feb 2008 04:33:30 +0000 (04:33 +0000)]
add another janitor project

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@104444 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoAdd the stuff from the janitor projects page that is still relevant. I figure
Russell Bryant [Wed, 27 Feb 2008 04:14:54 +0000 (04:14 +0000)]
Add the stuff from the janitor projects page that is still relevant.  I figure
that if we keep this in the tree, it will be much easier to keep up to date.
The page on asterisk.org just links to this on svn.digium.com/view

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@104419 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoCreate placeholder file...for now.
Jason Parker [Wed, 27 Feb 2008 03:52:18 +0000 (03:52 +0000)]
Create placeholder file...for now.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@104418 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoWhitespace changes only
Tilghman Lesher [Wed, 27 Feb 2008 02:05:36 +0000 (02:05 +0000)]
Whitespace changes only

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@104388 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoMerged revisions 104334 via svnmerge from
Russell Bryant [Wed, 27 Feb 2008 01:16:06 +0000 (01:16 +0000)]
Merged revisions 104334 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r104334 | russell | 2008-02-26 19:15:02 -0600 (Tue, 26 Feb 2008) | 3 lines

Avoid some recursion in the cleanup code for the chanspy datastore
(closes issue #12076, reported by junky, patched by me)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@104335 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoBlocked revisions 104332 via svnmerge
Russell Bryant [Wed, 27 Feb 2008 00:55:12 +0000 (00:55 +0000)]
Blocked revisions 104332 via svnmerge

........
r104332 | russell | 2008-02-26 18:54:29 -0600 (Tue, 26 Feb 2008) | 5 lines

Zaptel 1.4 now exposes FXO battery state as an alarm.  However, Asterisk 1.4
does not know what to do with these alarms.  Only Asterisk 1.6 cares about it.
So, if we get an unknown alarm in chan_zap, don't generate confusing log messages
about it.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@104333 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agosmall change to allow this file to compile. No problem if you don't install the libsn...
Steve Murphy [Tue, 26 Feb 2008 22:14:22 +0000 (22:14 +0000)]
small change to allow this file to compile. No problem if you don't install the libsnmp package.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@104301 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoI swear I compiled this ... *cough*
Russell Bryant [Tue, 26 Feb 2008 20:33:08 +0000 (20:33 +0000)]
I swear I compiled this ... *cough*

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@104270 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agofix this module, too
Russell Bryant [Tue, 26 Feb 2008 20:30:50 +0000 (20:30 +0000)]
fix this module, too

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@104260 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agofix this module
Russell Bryant [Tue, 26 Feb 2008 20:28:47 +0000 (20:28 +0000)]
fix this module

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@104251 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoRe-add the automatically generated version.h, so that modules can include for
Russell Bryant [Tue, 26 Feb 2008 20:19:03 +0000 (20:19 +0000)]
Re-add the automatically generated version.h, so that modules can include for
making build time decisions for cross asterisk version compatibility

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@104245 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoRename version.h to ast_version.h. Next, I will be re-adding version.h as an
Russell Bryant [Tue, 26 Feb 2008 20:02:14 +0000 (20:02 +0000)]
Rename version.h to ast_version.h.  Next, I will be re-adding version.h as an
automatically generated file like it used to be.  This still needs to be there
for modules that have to check it to compile against multiple asterisk versions.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@104244 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoAdd an 'e' option to ResetCDR which re-enables a CDR that has been disabled.
Joshua Colp [Tue, 26 Feb 2008 19:14:04 +0000 (19:14 +0000)]
Add an 'e' option to ResetCDR which re-enables a CDR that has been disabled.
(closes issue #11170)
Reported by: kratzers
Patches:
      ResetCDR.1.diff uploaded by kratzers (license 307)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@104215 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years ago1) Make braces mandatory for if/for/while, even around single statements.
Tilghman Lesher [Tue, 26 Feb 2008 18:40:26 +0000 (18:40 +0000)]
1) Make braces mandatory for if/for/while, even around single statements.
2) Revise the argument parsing section, showing use of the standard macros.
3) Fix a typo.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@104176 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoMerged revisions 104141 via svnmerge from
Jason Parker [Tue, 26 Feb 2008 18:27:08 +0000 (18:27 +0000)]
Merged revisions 104141 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r104141 | qwell | 2008-02-26 12:26:12 -0600 (Tue, 26 Feb 2008) | 1 line

Add badshell to .PHONY target (thanks Kevin)
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@104142 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoMerged revisions 104139 via svnmerge from
Jason Parker [Tue, 26 Feb 2008 18:10:20 +0000 (18:10 +0000)]
Merged revisions 104139 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r104139 | qwell | 2008-02-26 12:09:13 -0600 (Tue, 26 Feb 2008) | 2 lines

Since all shells aren't as awesome as bash, we have to fail if somebody tries to use a literal "~" in DESTDIR.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@104140 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoFormatting and doxygen while waiting on an airport...
Olle Johansson [Tue, 26 Feb 2008 16:51:25 +0000 (16:51 +0000)]
Formatting and doxygen while waiting on an airport...

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@104137 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoMerged revisions 104135 via svnmerge from
Jason Parker [Tue, 26 Feb 2008 16:36:49 +0000 (16:36 +0000)]
Merged revisions 104135 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r104135 | qwell | 2008-02-26 10:35:06 -0600 (Tue, 26 Feb 2008) | 5 lines

Revert previous abspath change.
...abspath is new in GNU make 3.81.  I feel so...defeated.

Must find new fix!

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@104136 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoMerged revisions 104132 via svnmerge from
Jason Parker [Tue, 26 Feb 2008 16:09:38 +0000 (16:09 +0000)]
Merged revisions 104132 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r104132 | qwell | 2008-02-26 10:08:44 -0600 (Tue, 26 Feb 2008) | 9 lines

Fix a very bizarre issue we were seeing with our buildbot when using a DESTDIR that
 wasn't an absolute path (such as DESTDIR=~/asterisk-1.4).

Apparently what was happening, was that some of the targets were being expanded to
 the full path, so $@ ended up being /root/asterisk-1.4/[...]/ rather than ~/asterisk-1.4/[...]/

It appears that this may be a new "feature" in GNU make.
(*cough* http://en.wikipedia.org/wiki/Principle_of_least_surprise *cough*)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@104133 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoRemove more hardcoded pipe symbols and replace with commas.
Mark Michelson [Tue, 26 Feb 2008 14:51:21 +0000 (14:51 +0000)]
Remove more hardcoded pipe symbols and replace with commas.

(closes issue #12072)
Reported by: SimonSharman
Patches:
      features.patch uploaded by SimonSharman (license 410)
Tested by: SimonSharman

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@104127 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoUse the readhandle for reads (closes issue #12069)
Tilghman Lesher [Tue, 26 Feb 2008 06:43:16 +0000 (06:43 +0000)]
Use the readhandle for reads (closes issue #12069)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@104125 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoAdd a \todo to convert this module to the event system
Russell Bryant [Tue, 26 Feb 2008 00:38:02 +0000 (00:38 +0000)]
Add a \todo to convert this module to the event system

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@104124 65c4cc65-6c06-0410-ace0-fbb531ad65f3

15 years agoUpdate CHANGES for SMDI stuff
Russell Bryant [Tue, 26 Feb 2008 00:35:30 +0000 (00:35 +0000)]
Update CHANGES for SMDI stuff

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@104123 65c4cc65-6c06-0410-ace0-fbb531ad65f3