11 years agoMerged revisions 211953 via svnmerge from
Matthew Nicholson [Wed, 12 Aug 2009 23:14:36 +0000 (23:14 +0000)]
Merged revisions 211953 via svnmerge from

  r211953 | mnicholson | 2009-08-12 18:04:02 -0500 (Wed, 12 Aug 2009) | 10 lines

  This patch adds additional checking when generating queue log TRANSFER events.

  The additional checks prevent generation of false TRANSFER events in certain situations.

  (closes issue #14536)
  Reported by: aragon
        queue-log-xfer-fix1.diff uploaded by mnicholson (license 96)
  Tested by: aragon, mnicholson

git-svn-id: 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoThis patch adds support for choosing a realm based on the domain in the From or To...
Matthew Nicholson [Wed, 12 Aug 2009 22:18:09 +0000 (22:18 +0000)]
This patch adds support for choosing a realm based on the domain in the From or To header in the incoming request.  Eligible domains are taken from the domains list in the config file.  This functionality is enabled when domainsasrealm is enabled in the config file.

(closes issue #11361)
Reported by: arkadia
      sip_realm_mnich_to_added_2.patch uploaded by arkadia (license 233)
Tested by: arkadia

git-svn-id: 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoFix chan_dahdi option ringtimeout
Jeff Peeler [Wed, 12 Aug 2009 20:47:45 +0000 (20:47 +0000)]
Fix chan_dahdi option ringtimeout

dahdi_read relies on the dahdi_pvt copy of ringt which was not getting set
in sig_analog. This patch adds a callback to do so.

(closes issue #15288)
Reported by: alecdavis
      chan_dahdi.ringtimeout.diff.txt uploaded by alecdavis (license 585)
Tested by: alecdavis

git-svn-id: 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMake asterisk handle 423 Interval Too Short messages better.
Matthew Nicholson [Wed, 12 Aug 2009 19:53:14 +0000 (19:53 +0000)]
Make asterisk handle 423 Interval Too Short messages better.

This change uses separate values for the acceptable minimum expiry provided by the 423 error and the expiry value stored in the configuration file.  Previously, the value pulled from the configuration file would be overwritten.

(closes issue #14366)
Reported by: Nick_Lewis
      sip-expiry-fix1.diff uploaded by mnicholson (license 96)
      chan_sip.c-reqexpiry.patch uploaded by Nick (license 657)
Tested by: mnicholson

git-svn-id: 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoBlocked revisions 211807 via svnmerge
Mark Michelson [Wed, 12 Aug 2009 18:47:51 +0000 (18:47 +0000)]
Blocked revisions 211807 via svnmerge

  r211807 | mmichelson | 2009-08-12 13:46:09 -0500 (Wed, 12 Aug 2009) | 10 lines

  Backport fix so that outbound CANCEL requests have same branch as challenged INVITEs.

  There already was code present to be sure that a CANCEL will contain the same branch-id
  as the INVITE it is cancelling. However, for INVITES which are challenged downstream,
  this mechanism did not work properly. Now this is taken care of.

  This is a backport of a fix already present in all 1.6.X branches and in trunk. It also
  fixes ABE-1907.

git-svn-id: 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoAdded three new attributes and applied a patch to res_config_ldap.c
Gavin Henry [Wed, 12 Aug 2009 16:00:46 +0000 (16:00 +0000)]
Added three new attributes and applied a patch to res_config_ldap.c

attributetype ( AstAccountSubscribeContext
        NAME 'AstAccountSubscribeContext'
        DESC 'Asterisk subscribe context'
        EQUALITY caseIgnoreMatch
        SUBSTR caseIgnoreSubstringsMatch

attributetype ( AstAccountIpAddr
        NAME 'AstAccountIpAddr'
        DESC 'Asterisk aaccount IP address'
        EQUALITY caseIgnoreMatch
        SUBSTR caseIgnoreSubstringsMatch

attributetype ( AstAccountUserAgent
        NAME 'AstAccountUserAgent'
        DESC 'Asterisk account user context'
        EQUALITY caseIgnoreMatch
        SUBSTR caseIgnoreSubstringsMatch

and patch fix_empty_attributes_1.6.1.4_v2.patch

(closes issue #13725)
Reported by: macogeek
      fix_empty_attributes_1.6.1.4_v2.patch uploaded by xvisor (license 863)
Tested by: suretec

git-svn-id: 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoAlways specify which RTP engine is desired for a new RTP instance.
Russell Bryant [Wed, 12 Aug 2009 10:11:36 +0000 (10:11 +0000)]
Always specify which RTP engine is desired for a new RTP instance.

This fixes a crash reported in #asterisk-dev where chan_mgcp unexpectedly
allocated an RTP instance from res_rtp_multicast, since by not specifying an
engine, you get the first one in the list of engines.

git-svn-id: 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoEncapsulate testing for which signaling styles are used by sig_pri.
Richard Mudgett [Mon, 10 Aug 2009 23:21:57 +0000 (23:21 +0000)]
Encapsulate testing for which signaling styles are used by sig_pri.

Created the dahdi_sig_pri_lib_handles() function and
SIG_PRI_LIB_HANDLE_CASES macro to simplify testing for which signaling
styles are handled by sig_pri.

git-svn-id: 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 211583 via svnmerge from
Tilghman Lesher [Mon, 10 Aug 2009 19:49:41 +0000 (19:49 +0000)]
Merged revisions 211583 via svnmerge from

  r211583 | tilghman | 2009-08-10 14:48:48 -0500 (Mon, 10 Aug 2009) | 1 line

  Conversion specifiers, not format specifiers

git-svn-id: 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoAST-2009-005
Tilghman Lesher [Mon, 10 Aug 2009 19:20:57 +0000 (19:20 +0000)]

git-svn-id: 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoadd manager events when a skinny device registers/unregisters
Michiel van Baak [Mon, 10 Aug 2009 18:01:47 +0000 (18:01 +0000)]
add manager events when a skinny device registers/unregisters
like we have in chan_sip

(closes issue #15499)
Reported by: arifzaman
      2009072600-skinnymanagerevents.diff.txt uploaded by mvanbaak (license 7)

git-svn-id: 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoFix PRI/BRI channels when in alarm condition to only be marked for hangup if
Jeff Peeler [Mon, 10 Aug 2009 17:17:06 +0000 (17:17 +0000)]
Fix PRI/BRI channels when in alarm condition to only be marked for hangup if
T309 is not enabled.

git-svn-id: 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoRestoring some code to sig_pri. Not sure if it is really needed.
Richard Mudgett [Mon, 10 Aug 2009 15:53:23 +0000 (15:53 +0000)]
Restoring some code to sig_pri.  Not sure if it is really needed.

Putting some DSP code back into sig_pri that was removed by the
chan_dahdi/sig_pri reorganization.

git-svn-id: 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoFix up some issues with getting a channel by "name".
Russell Bryant [Mon, 10 Aug 2009 15:46:39 +0000 (15:46 +0000)]
Fix up some issues with getting a channel by "name".

Even though the get_channel_by_name() API advertised that you could search by
name or uniqueid (just as the old API did), searching by uniqueid was not
actually implemented.  This patch fixes that problem.

The ast_channel_get_full() function now makes a second search attempt by
uniqueid if the parameter was a name.  The channel comparison function also
now knows how to compare by unqieueid.

Finally, a bug was fixed in passing where OBJ_POINTER was being passed in some
scenarios where it should not have been.

git-svn-id: 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoFix retrieval of the port used for the video stream when adding SDP to a SIP message.
Joshua Colp [Mon, 10 Aug 2009 14:07:44 +0000 (14:07 +0000)]
Fix retrieval of the port used for the video stream when adding SDP to a SIP message.

(closes issue #15121)
Reported by: jsmith

git-svn-id: 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 211274 via svnmerge from
Tilghman Lesher [Sun, 9 Aug 2009 15:42:02 +0000 (15:42 +0000)]
Merged revisions 211274 via svnmerge from

  r211274 | tilghman | 2009-08-09 10:41:01 -0500 (Sun, 09 Aug 2009) | 2 lines

  Small oops.  Clear the flags which have been checked.

git-svn-id: 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoCheck for NULL frame, before dereferencing pointer.
Tilghman Lesher [Sun, 9 Aug 2009 07:11:22 +0000 (07:11 +0000)]
Check for NULL frame, before dereferencing pointer.
(closes issue #15617)
 Reported by: rain

git-svn-id: 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoFixed some unsafe down cast pointer operations for sig_pri.
Richard Mudgett [Fri, 7 Aug 2009 23:30:32 +0000 (23:30 +0000)]
Fixed some unsafe down cast pointer operations for sig_pri.

You cannot cast the struct dahdi_pvt.sig_pvt pointer to a specific
signaling private pointer without first checking that it is in fact
pointing to the correct signaling private structure.

git-svn-id: 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoFix static on line when PRI does overlap dialing.
Richard Mudgett [Fri, 7 Aug 2009 23:17:41 +0000 (23:17 +0000)]
Fix static on line when PRI does overlap dialing.

The wrong encoding law was used because = was used when it should
have been ==.

git-svn-id: 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoRecorded merge of revisions 211112 via svnmerge from
Russell Bryant [Fri, 7 Aug 2009 20:12:21 +0000 (20:12 +0000)]
Recorded merge of revisions 211112 via svnmerge from

  r211112 | russell | 2009-08-07 15:11:31 -0500 (Fri, 07 Aug 2009) | 4 lines

  Resolve a deadlock involving app_chanspy and masquerades.


git-svn-id: 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 211038 via svnmerge from
Tilghman Lesher [Fri, 7 Aug 2009 18:17:41 +0000 (18:17 +0000)]
Merged revisions 211038 via svnmerge from

  r211038 | tilghman | 2009-08-07 13:16:28 -0500 (Fri, 07 Aug 2009) | 14 lines

  QUEUE_MEMBER_LIST _really_ wants the interface name, not the membername.

  This is a partial revert of revision 82590, which was an attempted cleanup,
  but in reality, it broke QUEUE_MEMBER_LIST, which has always been intended
  as a method by which component interfaces could be queried from the queue.
  Membername isn't useful here, because that field cannot be used to obtain
  further information about the member.  See the documentation on
  QUEUE_MEMBER_LIST, RemoveQueueMember, QUEUE_MEMBER_PENALTY, and the various
  AMI commands which take a member argument for further justification.
  (closes issue #15664)
   Reported by: rain
         app_queue-queue_member_list.diff uploaded by rain (license 327)

git-svn-id: 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoWorkaround broken T.38 endpoints that offer tiny MaxDatagram sizes.
Kevin P. Fleming [Fri, 7 Aug 2009 13:08:00 +0000 (13:08 +0000)]
Workaround broken T.38 endpoints that offer tiny MaxDatagram sizes.

Some T.38 endpoints treat T38FaxMaxDatagram as the maximum IFP size that should
be sent to them, rather than the maximum packet payload size. If such an
endpoint also requests UDPRedundancy as the error correction mode, we'll end
up calculating a tiny maximum IFP size, so small as to be unusable. This patch
sets a lower bound on what we'll consider the remote's maximum IFP size to be,
assuming that endpoints that do this really can accept larger packets than
they've offered to accept.

(closes issue #15649)
Reported by: dazza76

git-svn-id: 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 210913 via svnmerge from
Tilghman Lesher [Thu, 6 Aug 2009 21:46:01 +0000 (21:46 +0000)]
Merged revisions 210913 via svnmerge from

  r210913 | tilghman | 2009-08-06 16:45:01 -0500 (Thu, 06 Aug 2009) | 7 lines

  Because channel information can be accessed outside of the channel thread, we must lock the channel prior to modifying it.
  (closes issue #15397)
   Reported by: caspy
         20090714__issue15397.diff.txt uploaded by tilghman (license 14)
   Tested by: caspy

git-svn-id: 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoAllow Gosub to recognize quote delimiters without consuming them.
Tilghman Lesher [Thu, 6 Aug 2009 21:29:26 +0000 (21:29 +0000)]
Allow Gosub to recognize quote delimiters without consuming them.
(closes issue #15557)
 Reported by: rain
       20090723__issue15557.diff.txt uploaded by tilghman (license 14)
 Tested by: rain


git-svn-id: 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMiscellaneous minor fixes to sig_analog.
Richard Mudgett [Thu, 6 Aug 2009 20:15:11 +0000 (20:15 +0000)]
Miscellaneous minor fixes to sig_analog.

*  Sanity adjustments to __analog_ss_thread for sig_analog environment.
*  Deleted some duplicated code.
*  Fixed analog_ss_thread_start passing the wrong pointer.

git-svn-id: 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoSanity adjustments to pri_ss_thread for sig_pri environment.
Richard Mudgett [Thu, 6 Aug 2009 19:52:11 +0000 (19:52 +0000)]
Sanity adjustments to pri_ss_thread for sig_pri environment.

git-svn-id: 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoAccept additional T.38 reinvites after an initial one has been handled.
Joshua Colp [Thu, 6 Aug 2009 17:47:04 +0000 (17:47 +0000)]
Accept additional T.38 reinvites after an initial one has been handled.

Discussion of this subject has yielded that it is not actually acceptable to change
T.38 parameters after the initial reinvite but declining is harsh and can cause the
fax to fail when it may be possible to allow it to continue. This patch changes things
so that additional T.38 reinvites are accepted but parameter changes ignored. This gives
the fax a fighting chance.

(closes issue #15610)
Reported by: huangtx2009

git-svn-id: 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMinor improvements to app_fax.
Kevin P. Fleming [Thu, 6 Aug 2009 16:07:15 +0000 (16:07 +0000)]
Minor improvements to app_fax.

This patch makes some small changes to handle watchdog timeouts in a better way,
and also uses a 'cleaner' method of including the spandsp header files.

(closes issue #14769)
Reported by: andrew
      app_fax-20090406.diff uploaded by andrew (license 240)
      v1-14769.patch uploaded by dimas (license 88)
Tested by: freh, deti, caspy, dimas, sgimeno, Dovid

git-svn-id: 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoFix potential deadlock issue with USERUSERINFO channel variable.
Richard Mudgett [Wed, 5 Aug 2009 23:44:39 +0000 (23:44 +0000)]
Fix potential deadlock issue with USERUSERINFO channel variable.

git-svn-id: 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMore changes from chan_dahdi that did not make it into sig_pri.
Richard Mudgett [Wed, 5 Aug 2009 22:46:37 +0000 (22:46 +0000)]
More changes from chan_dahdi that did not make it into sig_pri.

*  Q.SIG channel mapping option.
*  discardremoteholdretrieval option.
*  libPRI debug defines.
*  pri_set_overlapdial() now set correctly.
*  pthread creation of pri_ss_thread now matches.

git-svn-id: 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 210575 via svnmerge from
Richard Mudgett [Wed, 5 Aug 2009 19:40:03 +0000 (19:40 +0000)]
Merged revisions 210575 via svnmerge from

  r210575 | rmudgett | 2009-08-05 14:18:56 -0500 (Wed, 05 Aug 2009) | 14 lines

  Dialplan starts execution before the channel setup is complete.

  *  Issue 15655: For the case where dialing is complete for an incoming
  call, dahdi_new() was asked to start the PBX and then the code set more
  channel variables.  If the dialplan hungup before these channel variables
  got set, asterisk would likely crash.
  *  Fixed potential for overlap incoming call to erroneously set channel
  variables as global dialplan variables if the ast_channel structure failed
  to get allocated.
  *  Added missing set of CALLINGSUBADDR in the dialing is complete case.

  (closes issue #15655)
  Reported by: alecdavis

git-svn-id: 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 210563 via svnmerge from
Leif Madsen [Wed, 5 Aug 2009 18:49:58 +0000 (18:49 +0000)]
Merged revisions 210563 via svnmerge from

  r210563 | lmadsen | 2009-08-05 13:46:21 -0500 (Wed, 05 Aug 2009) | 11 lines

  Update imapstorage.txt documentation.
  Updated the imapstorage.txt documentation to reflect that issues with
  c-client versions older than 2007 seem to cause crashing issues that
  are not seen with more recent versions. Documentation has been updated
  to reflect this.

  (closes issue #14496)
  Reported by: vbcrlfuser
        __20090727-imap-documentation-patch.txt uploaded by lmadsen (license 10)
  Tested by: lmadsen, mmichelson, dbrooks

git-svn-id: 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoRevert some silly code that snuck into trunk from my working copy. Sorry!
Russell Bryant [Wed, 5 Aug 2009 14:09:24 +0000 (14:09 +0000)]
Revert some silly code that snuck into trunk from my working copy.  Sorry!

git-svn-id: 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoignore the .i files when compiling in 'DONT_OPTIMIZE' in the addons/mp3 directory
Michiel van Baak [Wed, 5 Aug 2009 08:03:36 +0000 (08:03 +0000)]
ignore the .i files when compiling in 'DONT_OPTIMIZE' in the addons/mp3 directory

git-svn-id: 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoBlocked revisions 210067 via svnmerge
David Brooks [Tue, 4 Aug 2009 18:59:36 +0000 (18:59 +0000)]
Blocked revisions 210067 via svnmerge

  r210067 | dbrooks | 2009-08-03 11:15:20 -0500 (Mon, 03 Aug 2009) | 11 lines

  Fixes dialplan wildcard extension taking precedence over call pickup code.

  Prior to this patch, a wildcard extension in the dialplan (for example, _*.) would take
  precedence over picking up a call in the channel's pickup group. This patch simply moves
  the block of code handling pickup group matching to above the extension matching code.

  (closes issue #14735)
  Reported by: stevedavies


git-svn-id: 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoFix CALLERID() values for sig_pri on incoming calls.
Richard Mudgett [Tue, 4 Aug 2009 17:46:03 +0000 (17:46 +0000)]
Fix CALLERID() values for sig_pri on incoming calls.

git-svn-id: 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoInitial minimum ast_party_caller support.
Richard Mudgett [Tue, 4 Aug 2009 16:36:41 +0000 (16:36 +0000)]
Initial minimum ast_party_caller support.

git-svn-id: 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoRemoved some dead code.
Richard Mudgett [Tue, 4 Aug 2009 16:36:03 +0000 (16:36 +0000)]
Removed some dead code.

git-svn-id: 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoFix broken call pickup
Jeff Peeler [Tue, 4 Aug 2009 15:35:49 +0000 (15:35 +0000)]
Fix broken call pickup

The find_channel_by_group callback was only looking at the channel that was
attempting to make the pickup instead of the other channels in the container.

git-svn-id: 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 210237 via svnmerge from
Kevin P. Fleming [Tue, 4 Aug 2009 14:53:00 +0000 (14:53 +0000)]
Merged revisions 210237 via svnmerge from

  r210237 | kpfleming | 2009-08-04 09:51:39 -0500 (Tue, 04 Aug 2009) | 10 lines

  Eliminate spurious compiler warnings from system headers on *BSD platforms.

  Ensure that system headers located in /usr/local/include are actually treated
  as system headers by the compiler, and not as local headers which are subject
  to warnings from the -Wundef compiler option and others.

  (closes issue #15606)
  Reported by: mvanbaak

git-svn-id: 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoRename 'canreinvite' option to 'directmedia', with backwards compatibility.
Kevin P. Fleming [Mon, 3 Aug 2009 20:48:48 +0000 (20:48 +0000)]
Rename 'canreinvite' option to 'directmedia', with backwards compatibility.

It is clear from multiple mailing list, forum, wiki and other sorts of posts
that users don't really understand the effects that the 'canreinvite' config
option actually has, and that in some cases they think that setting it to 'no'
will actually cause various other features (T.38, MOH, etc.) to not work properly,
when in fact this is not the case. This patch changes the proper name of the
option to what it should have been from the beginning ('directmedia'), but
preserves backwards compatibility for existing configurations.

git-svn-id: 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoChanges from chan_dahdi that did not make it into sig_pri.
Richard Mudgett [Mon, 3 Aug 2009 18:05:46 +0000 (18:05 +0000)]
Changes from chan_dahdi that did not make it into sig_pri.

*  Moved SUPPORT_USERUSER to sig_pri.c
*  Whitespace changes.
*  Added missing unlock in pri_dchannel():PRI_EVENT_RING case.
*  Balanced curly braces.
*  ast_debug/ast_log changes from chan_dahdi.
*  sig_pri_indicate() should default to return -1 if the indication is not

git-svn-id: 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoTrim trailing whitespace.
Richard Mudgett [Mon, 3 Aug 2009 16:24:13 +0000 (16:24 +0000)]
Trim trailing whitespace.

git-svn-id: 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoBlocked revisions 210064-210066 via svnmerge
Tilghman Lesher [Mon, 3 Aug 2009 16:16:40 +0000 (16:16 +0000)]
Blocked revisions 210064-210066 via svnmerge

  r210064 | tilghman | 2009-08-03 10:39:41 -0500 (Mon, 03 Aug 2009) | 4 lines

  Apparently, some platforms don't have the index() function.
  (closes issue #15639)
   Reported by: nmav
  r210065 | tilghman | 2009-08-03 10:42:10 -0500 (Mon, 03 Aug 2009) | 3 lines

  Helps if we export the index() function.
  (Related to issue #15639)
  r210066 | tilghman | 2009-08-03 11:11:29 -0500 (Mon, 03 Aug 2009) | 3 lines

  Reverting index() fix, applying a different methodology, based upon developer discussions.
  (related to issue #15639)

git-svn-id: 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoFix order and redundancy of channel rename manager events in ast_do_masquerade.
Mark Michelson [Mon, 3 Aug 2009 14:29:17 +0000 (14:29 +0000)]
Fix order and redundancy of channel rename manager events in ast_do_masquerade.

Patch contributed by Mark Spencer.

git-svn-id: 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoAdd an 'sms' option to mobile.conf to manually enable or disable SMS support.
Matthew Nicholson [Mon, 3 Aug 2009 14:01:39 +0000 (14:01 +0000)]
Add an 'sms' option to mobile.conf to manually enable or disable SMS support.

(closes issue #15071)
Reported by: ughnz
      optional-sms1.diff uploaded by mnicholson (license 96)
Tested by: ughnz, mnicholson

git-svn-id: 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoUpdate documentation in relation to UnixODBC
Bradley Latus [Sat, 1 Aug 2009 23:33:31 +0000 (23:33 +0000)]
Update documentation in relation to UnixODBC

(closes issue #15516)
Reported by: snuffy
      bug_odbc_tex_update_v2.diff uploaded by snuffy (license 35)

git-svn-id: 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years ago(closes issue #15515)
Bradley Latus [Sat, 1 Aug 2009 23:25:16 +0000 (23:25 +0000)]
(closes issue #15515)

git-svn-id: 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 209879 via svnmerge from
Russell Bryant [Sat, 1 Aug 2009 11:29:25 +0000 (11:29 +0000)]
Merged revisions 209879 via svnmerge from

  r209879 | russell | 2009-08-01 06:27:25 -0500 (Sat, 01 Aug 2009) | 5 lines

  Resolve a valgrind warning about a read from uninitialized memory.

  (issue #15396)
  Reported by: aragon

git-svn-id: 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 209838 via svnmerge from
Russell Bryant [Sat, 1 Aug 2009 11:02:07 +0000 (11:02 +0000)]
Merged revisions 209838 via svnmerge from

  r209838 | russell | 2009-08-01 05:59:05 -0500 (Sat, 01 Aug 2009) | 13 lines

  Modify how Playtones() is used in Milliwatt() to resolve gain issue.

  When Milliwatt() was changed internally to use Playtones() so that the proper
  tone was used, it introduced a drop in gain in the output signal.  So, use
  the playtones API directly and specify a volume argument such that the output
  matches the gain of the original Milliwatt() code.

  (closes issue #15386)
  Reported by: rue_mohr
        issue_15386.rev2.diff uploaded by russell (license 2)
  Tested by: rue_mohr

git-svn-id: 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoFix ast_event_queue_and_cache() to actually do the cache() part.
Russell Bryant [Sat, 1 Aug 2009 10:43:40 +0000 (10:43 +0000)]
Fix ast_event_queue_and_cache() to actually do the cache() part.

(closes issue #15624)
Reported by: ffossard
Tested by: russell

git-svn-id: 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoRevert accidental Makefile change.
Kevin P. Fleming [Sat, 1 Aug 2009 01:04:06 +0000 (01:04 +0000)]
Revert accidental Makefile change.

git-svn-id: 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoMerged revisions 209759 via svnmerge from
Kevin P. Fleming [Sat, 1 Aug 2009 01:03:07 +0000 (01:03 +0000)]
Merged revisions 209759 via svnmerge from

  r209759 | kpfleming | 2009-07-31 19:52:00 -0500 (Fri, 31 Jul 2009) | 7 lines

  Minor changes inspired by testing with latest GCC.

  The latest GCC (what will become 4.5.x) has a few new warnings, that in these
  cases found some either downright buggy code, or at least seriously poorly
  designed code that could be improved.

git-svn-id: 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoFix some places where ast_event_type was used instead of ast_event_ie_type.
Russell Bryant [Fri, 31 Jul 2009 21:53:31 +0000 (21:53 +0000)]
Fix some places where ast_event_type was used instead of ast_event_ie_type.

git-svn-id: 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoAdd configuration sample code for previous commit.
Mark Michelson [Fri, 31 Jul 2009 17:57:00 +0000 (17:57 +0000)]
Add configuration sample code for previous commit.

git-svn-id: 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoImprove chan_sip's ability to determine what methods should and should not be used...
Mark Michelson [Fri, 31 Jul 2009 17:55:44 +0000 (17:55 +0000)]
Improve chan_sip's ability to determine what methods should and should not be used in a dialog.

The previous effort here was to store what a peer is capable of receiving by parsing REGISTER
requests from the peer and keeping that information for as long as the registration was active.
The problem with this is that there are a great number of SIP devices which give no indication
of the methods allowed in their REGISTER requests, and it is unreasonable to try to guess what
the device may or may not support. In addition, some SIP devices have been found to claim support
for a specific method, but their handling the method is less than ideal, or they are actually

With this patch, we now determine what methods a device supports  by parsing the Allow header we
receive from them, and we do this with each new dialog. In addition, a configuration option has
been added so that an administrator can essentially blacklist certain methods from being used
with certain peers if the admin knows that support for a specific method is dodgy or nonexistent.


git-svn-id: 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoAllow passing 'noisy' to configure's --enable-dev-mode argument to turn on verbose...
Sean Bright [Thu, 30 Jul 2009 23:37:31 +0000 (23:37 +0000)]
Allow passing 'noisy' to configure's --enable-dev-mode argument to turn on verbose builds.

(closes issue #15607)
Reported by: mvanbaak
      20090730_issue15607.patch uploaded by seanbright (license 71)
Tested by: seanbright

git-svn-id: 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoAdd missing ifdef-s for service maintenance message functionality
Jeff Peeler [Thu, 30 Jul 2009 23:31:41 +0000 (23:31 +0000)]
Add missing ifdef-s for service maintenance message functionality

(closes issue #15614)
Reported by: fabled

git-svn-id: 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoFixes numerous spelling errors. Patch submitted by alecdavis.
David Brooks [Thu, 30 Jul 2009 16:07:05 +0000 (16:07 +0000)]
Fixes numerous spelling errors. Patch submitted by alecdavis.

(closes issue #15595)
Reported by: alecdavis

git-svn-id: 65c4cc65-6c06-0410-ace0-fbb531ad65f3

11 years agoFix a crash that can result if text codecs are allowed but textsupport is disabled.
Mark Michelson [Thu, 30 Jul 2009 14:38:21 +0000 (14:38 +0000)]
Fix a crash that can result if text codecs are allowed but textsupport is disabled.

(closes issue #15596)
Reported by: fabled
      sip-red.patch uploaded by fabled (license 448)

git-svn-id: 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoThis patch adds the ability to send a CUSD command to a bluetooth device.
Matthew Nicholson [Wed, 29 Jul 2009 21:46:17 +0000 (21:46 +0000)]
This patch adds the ability to send a CUSD command to a bluetooth device.

(closes issue #15278)
Reported by: Artem
      cusd5.patch uploaded by Artem (license 800)
Tested by: mnicholson, Artem


git-svn-id: 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoFixed a comment for hfp_parse_clip
Matthew Nicholson [Wed, 29 Jul 2009 21:13:42 +0000 (21:13 +0000)]
Fixed a comment for hfp_parse_clip

git-svn-id: 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoDefine side-effect-safe MIN and MAX macros and remove duplicate definitions from...
Kevin P. Fleming [Tue, 28 Jul 2009 13:49:46 +0000 (13:49 +0000)]
Define side-effect-safe MIN and MAX macros and remove duplicate definitions from various files.

git-svn-id: 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoRegex FTL
Tilghman Lesher [Tue, 28 Jul 2009 00:20:26 +0000 (00:20 +0000)]
Regex FTL

git-svn-id: 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 209315 via svnmerge from
Tilghman Lesher [Tue, 28 Jul 2009 00:14:12 +0000 (00:14 +0000)]
Merged revisions 209315 via svnmerge from

  r209315 | tilghman | 2009-07-27 19:12:03 -0500 (Mon, 27 Jul 2009) | 2 lines

  Publish French extra sounds

git-svn-id: 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoCleanup T.38 negotiation changes.
Kevin P. Fleming [Mon, 27 Jul 2009 21:43:36 +0000 (21:43 +0000)]
Cleanup T.38 negotiation changes.

Convert LOG_NOTICE messages about T.38 negotiation in debug level 1 messages,
clean up some looping logic, and correct an improper use of ast_free() for
freeing an ast_frame.

git-svn-id: 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMake T.38 switchover in ReceiveFAX synchronous.
Kevin P. Fleming [Mon, 27 Jul 2009 21:21:43 +0000 (21:21 +0000)]
Make T.38 switchover in ReceiveFAX synchronous.

In receive mode, if the channel that ReceiveFAX is running on supports T.38,
we should *always* attempt to switch T.38, rather than listening for an incoming
CNG tone and only triggering on that. The channel may be using a low-bitrate
codec that distorts the CNG tone, the sending FAX endpoint may not send CNG
at all, or there could be a variety of other reasons that we don't detect it,
but in all those cases if T.38 is available we certainly want to use it.

git-svn-id: 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoGracefully handle malformed RTP text packets.
Mark Michelson [Mon, 27 Jul 2009 20:54:54 +0000 (20:54 +0000)]
Gracefully handle malformed RTP text packets.


git-svn-id: 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoHonor channel's music class when using realtime music on hold.
Mark Michelson [Mon, 27 Jul 2009 20:11:42 +0000 (20:11 +0000)]
Honor channel's music class when using realtime music on hold.

(closes issue #15051)
Reported by: alexh
      15051.patch uploaded by mmichelson (license 60)
Tested by: alexh

git-svn-id: 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 209131 via svnmerge from
Mark Michelson [Mon, 27 Jul 2009 17:50:04 +0000 (17:50 +0000)]
Merged revisions 209131 via svnmerge from

  r209131 | mmichelson | 2009-07-27 12:44:06 -0500 (Mon, 27 Jul 2009) | 18 lines

  Allow for UDPTL to use only even-numbered ports if desired.

  There are some VoIP providers out there that will not accept SDP
  offers with odd numbered UDPTL ports. While it is my personal opinion
  that these VoIP providers are misinterpreting RFC 2327, it really is
  not a big deal to play along with their silly little games. Of course,
  since restricting UDPTL ports to only even numbers reduces the range
  of available ports by half, so the option to use only even port numbers
  is off by default. A user can enable the behavior by setting
  use_even_ports=yes in udptl.conf.

  (closes issue #15182)
  Reported by: CGMChris
        15182.patch uploaded by mmichelson (license 60)
  Tested by: CGMChris

git-svn-id: 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoFixing typos. Replaces "recieved" with "received" and "initilize" with "initialize"
David Brooks [Mon, 27 Jul 2009 16:33:50 +0000 (16:33 +0000)]
Fixing typos. Replaces "recieved" with "received" and "initilize" with "initialize"

(closes issue #15571)
Reported by: alecdavis

git-svn-id: 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoRestore explicit export of ASTCFLAGS/ASTLDFLAGS and underscore-variants to sub-makes.
Kevin P. Fleming [Mon, 27 Jul 2009 15:38:59 +0000 (15:38 +0000)]
Restore explicit export of ASTCFLAGS/ASTLDFLAGS and underscore-variants to sub-makes.

During the recent Makefile improvements I made, it seemed the 'make' was
automatically carrying down the ASTCFLAGS/ASTLDFLAGS settings to sub-makes,
so I removed the explict export of them. However, there are some circumstances
where make does this, and some where it does not, so I've brought them back
to ensure they are always exported. I also removed an extraneous double setting
of _ASTLDFLAGS on *BSD platforms.

git-svn-id: 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoBlocked revisions 208990 via svnmerge
Michiel van Baak [Mon, 27 Jul 2009 09:56:49 +0000 (09:56 +0000)]
Blocked revisions 208990 via svnmerge

  r208990 | mvanbaak | 2009-07-27 11:56:13 +0200 (Mon, 27 Jul 2009) | 5 lines

  backport rev 205532 from trunk:

  pthread_self returns a pthread_t which is not an unsigned int on all
  pthread implementations. Casting it to an unsigned int fixes compiler warnings.

git-svn-id: 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 208923 via svnmerge from
Jeff Peeler [Mon, 27 Jul 2009 01:20:37 +0000 (01:20 +0000)]
Merged revisions 208923 via svnmerge from

  r208923 | jpeeler | 2009-07-26 20:18:31 -0500 (Sun, 26 Jul 2009) | 2 lines

  Fix logic errors from 208746

git-svn-id: 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoadd OpenBSD to the install_prereq script
Michiel van Baak [Sun, 26 Jul 2009 14:00:52 +0000 (14:00 +0000)]
add OpenBSD to the install_prereq script

git-svn-id: 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agolibxml2-dev is needed as well by default.
Michiel van Baak [Sat, 25 Jul 2009 12:28:38 +0000 (12:28 +0000)]
libxml2-dev is needed as well by default.

git-svn-id: 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoadd default alias reload to run module reload.
Michiel van Baak [Sat, 25 Jul 2009 12:03:25 +0000 (12:03 +0000)]
add default alias reload to run module reload.

Requiring 'module reload' to reload everything, including
core etc makes russell very unhappy.

The default configuration already loads the 'friendly' aliases template.
Added 'reload=module reload' to that template.

Also removed the comment in main/cli.c that reload should come back.

git-svn-id: 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 208746 via svnmerge from
Jeff Peeler [Sat, 25 Jul 2009 06:23:18 +0000 (06:23 +0000)]
Merged revisions 208746 via svnmerge from

  r208746 | jpeeler | 2009-07-25 01:19:50 -0500 (Sat, 25 Jul 2009) | 7 lines

  Fix compiling under dev-mode with gcc 4.4.0.

  Mostly trivial changes, but I did not know of any other way to fix the
  "dereferencing type-punned pointer will break strict-aliasing rules" error
  without creating a tmp variable in chan_skinny.

git-svn-id: 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoRemove trailing whitespace.
Russell Bryant [Fri, 24 Jul 2009 21:12:43 +0000 (21:12 +0000)]
Remove trailing whitespace.

git-svn-id: 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoNote that "reload" needs to be added back.
Russell Bryant [Fri, 24 Jul 2009 20:54:37 +0000 (20:54 +0000)]
Note that "reload" needs to be added back.

I keep getting annoyed at having to type "module reload" to reload everything,
so I'm adding a note that we need to add "reload" back.  "module reload" doesn't
really make sense as the command to reload everything, including the core.

git-svn-id: 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoDon't log a warning for something that does not affect operation.
Russell Bryant [Fri, 24 Jul 2009 20:25:23 +0000 (20:25 +0000)]
Don't log a warning for something that does not affect operation.

git-svn-id: 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoBlocked revisions 208622 via svnmerge
Mark Michelson [Fri, 24 Jul 2009 19:26:26 +0000 (19:26 +0000)]
Blocked revisions 208622 via svnmerge

  r208622 | mmichelson | 2009-07-24 14:24:28 -0500 (Fri, 24 Jul 2009) | 16 lines

  Don't impose an arbitrary limit on member lines in queues.conf

  I know what some of you are thinking: "UGH! Mark, why are you using
  ast_strdup and ast_free for the string when you can just use ast_strdupa
  and let the memory free itself?! Have the bats been chewing on your brain

  Based on past experiences, I don't like using ast_strdupa inside a loop.
  It's a good way to potentially exhaust stack space. Also, since this only
  happens when reloading queues, I don't think that heap allocations and
  frees are going to be a huge problem.

  (closes issue #15559)
  Reported by: amorsen

git-svn-id: 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 208592 via svnmerge from
Russell Bryant [Fri, 24 Jul 2009 18:42:32 +0000 (18:42 +0000)]
Merged revisions 208592 via svnmerge from

  r208592 | russell | 2009-07-24 13:38:24 -0500 (Fri, 24 Jul 2009) | 7 lines

  Do not log an ERROR if autoservice_stop() returns -1.

  This does not indicate an error.  A return of -1 just means that the channel
  has been hung up.

  (reported in #asterisk-dev)

git-svn-id: 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 208587 via svnmerge from
Mark Michelson [Fri, 24 Jul 2009 18:31:04 +0000 (18:31 +0000)]
Merged revisions 208587 via svnmerge from

  r208587 | mmichelson | 2009-07-24 13:26:50 -0500 (Fri, 24 Jul 2009) | 10 lines

  Only send a BYE when hanging up a channel that is up.

  For cases where Asterisk sends an INVITE and receives a non 2XX final
  response, Asterisk would follow the INVITE transaction by immediately
  sending a BYE, which was unnecessary.

  (closes issue #14575)
  Reported by: chris-mac

git-svn-id: 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoResolve a T.38 negotiation issue left over from the udptl-updates merge.
Kevin P. Fleming [Fri, 24 Jul 2009 15:02:53 +0000 (15:02 +0000)]
Resolve a T.38 negotiation issue left over from the udptl-updates merge.

The udptl-updates branch that was merged yesterday failed to properly send back
T.38 SDP responses with the correct error correction mode, if the incoming SDP
from the other end caused us to change error correction modes. This patch
corrects that situation.

git-svn-id: 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agouse aptitude for debian based systems
Michiel van Baak [Fri, 24 Jul 2009 14:35:49 +0000 (14:35 +0000)]
use aptitude for debian based systems

The function to check wether we need to install packages was using
dpkg-query which was gives wrong output on Debian 5

Also, the apt-get has been replaced with aptitude because aptitude
is now the preferred way to handle packages on Debian

(closes issue #15570)
Reported by: mvanbaak
      2009072400_installprereq-aptitude.diff uploaded by mvanbaak (license 7)

git-svn-id: 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoT.38 change note is not necessary in this branch
Kevin P. Fleming [Thu, 23 Jul 2009 22:32:52 +0000 (22:32 +0000)]
T.38 change note is not necessary in this branch

git-svn-id: 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoRework of T.38 negotiation and UDPTL API to address interoperability problems
Kevin P. Fleming [Thu, 23 Jul 2009 21:57:24 +0000 (21:57 +0000)]
Rework of T.38 negotiation and UDPTL API to address interoperability problems

Over the past couple of months, a number of issues with Asterisk
negotiating (and successfully completing) T.38 sessions with various
endpoints have been found. This patch attempts to address many of
them, primarily focused around ensuring that the endpoints'
MaxDatagram size is honored, and in addition by ensuring that T.38
session parameter negotiation is performed correctly according to the
ITU T.38 Recommendation.

The major changes here are:

1) T.38 applications in Asterisk (app_fax) only generate/receive IFP
packets, they do not ever work with UDPTL packets. As a result of
this, they cannot be allowed to generate packets that would overflow
the other endpoints' MaxDatagram size after the UDPTL stack adds any
error correction information. With this patch, the application is told
the maximum *IFP* size it can generate, based on a calculation using
the far end MaxDatagram size and the active error correction mode on
the T.38 session. The same is true for sending *our* MaxDatagram size
to the remote endpoint; it is computed from the value that the
application says it can accept (for a single IFP packet) combined with
the active error correction mode.

2) All treatment of T.38 session parameters as 'capabilities' in
chan_sip has been removed; these parameters are not at all like
audio/video stream capabilities. There are strict rules to follow for
computing an answer to a T.38 offer, and chan_sip now follows those
rules, using the desired parameters from the application (or channel)
that wants to accept the T.38 negotiation.

3) chan_sip now stores and forwards ast_control_t38_parameters
structures for tracking 'our' and 'their' T.38 session parameters;
this greatly simplifies negotiation, especially for pass-through

4) Since T.38 negotiation without specifying parameters or receiving
the final negotiated parameters is not very worthwhile, the
AST_CONTROL_T38 control frame has been removed. A note has been added
to UPGRADE.txt about this removal, since any out-of-tree applications
that use it will no longer function properly until they are upgraded


git-svn-id: 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 208386 via svnmerge from
Mark Michelson [Thu, 23 Jul 2009 19:34:49 +0000 (19:34 +0000)]
Merged revisions 208386 via svnmerge from

  r208386 | mmichelson | 2009-07-23 14:24:21 -0500 (Thu, 23 Jul 2009) | 17 lines

  Fix a problem where a 491 response could be sent out of dialog.

  This generalizes the fix for issue 13849. The initial fix corrected the
  problem that Asterisk would reply with a 491 if a reinvite were received
  from an endpoint and we had not yet received an ACK from that endpoint
  for the initial INVITE it had sent us. This expansion also allows Asterisk
  to appropriately handle an INVITE with authorization credentials if Asterisk
  had not received an ACK from the previous transaction in which Asterisk had
  responded to an unauthorized INVITE with a 407.

  (closes issue #14239)
  Reported by: klaus3000
        14239.patch uploaded by mmichelson (license 60)
  Tested by: klaus3000


git-svn-id: 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 208380 via svnmerge from
Jeff Peeler [Thu, 23 Jul 2009 19:21:50 +0000 (19:21 +0000)]
Merged revisions 208380 via svnmerge from

  r208380 | jpeeler | 2009-07-23 14:19:53 -0500 (Thu, 23 Jul 2009) | 6 lines

  Only set the priindication setting when not performing a reload

  (closes issue #14696)
  Reported by: fdecher

git-svn-id: 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 208312 via svnmerge from
Mark Michelson [Thu, 23 Jul 2009 16:29:37 +0000 (16:29 +0000)]
Merged revisions 208312 via svnmerge from

  r208312 | mmichelson | 2009-07-23 11:29:18 -0500 (Thu, 23 Jul 2009) | 3 lines

  Remove inaccurate XXX comment.

git-svn-id: 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoFix sending of interface identifier unconditionally in sig_pri
Jeff Peeler [Thu, 23 Jul 2009 15:59:44 +0000 (15:59 +0000)]
Fix sending of interface identifier unconditionally in sig_pri

The wrong logic was being used in chan_dahdi to convert a sig_pri_chan
to the proper libpri channel number. The most significant bit must only
be set only when trunk groups are being used.

(closes issue #15452)
Reported by: alecdavis
      bug15452.patch uploaded by jpeeler (license 325)
Tested by: alecdavis

git-svn-id: 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 208262 via svnmerge from
Mark Michelson [Thu, 23 Jul 2009 15:46:34 +0000 (15:46 +0000)]
Merged revisions 208262 via svnmerge from

  r208262 | mmichelson | 2009-07-23 10:43:07 -0500 (Thu, 23 Jul 2009) | 8 lines

  Properly handle 183 responses which do not contain an SDP.

  (closes issue #15442)
  Reported by: ffloimair
        15442.patch uploaded by mmichelson (license 60)
  Tested by: tkarl, ffloimair

git-svn-id: 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoFix potential crash if p->owner is NULL.
Mark Michelson [Thu, 23 Jul 2009 14:46:53 +0000 (14:46 +0000)]
Fix potential crash if p->owner is NULL.

Problem was observed when a call-forwarding loop was accidentally


git-svn-id: 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoResolve compiler warning on mac.
Russell Bryant [Thu, 23 Jul 2009 01:31:18 +0000 (01:31 +0000)]
Resolve compiler warning on mac.

git-svn-id: 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoReset the fax buffers back to default settings regardless of signaling in use -
Jeff Peeler [Wed, 22 Jul 2009 22:42:33 +0000 (22:42 +0000)]
Reset the fax buffers back to default settings regardless of signaling in use -
Pointed out by Matt F.
Also in the case of not using a signaling module, set the law back to the
default as well.

git-svn-id: 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoMerged revisions 208083 via svnmerge from
Tilghman Lesher [Wed, 22 Jul 2009 22:35:57 +0000 (22:35 +0000)]
Merged revisions 208083 via svnmerge from

  r208083 | tilghman | 2009-07-22 15:23:53 -0500 (Wed, 22 Jul 2009) | 4 lines

  Export symbols for functions included in our compatibility headers.
  (closes issue #15556)
   Reported by: smw1218

git-svn-id: 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoRestore an int declaration on PPC platforms.
Jason Parker [Wed, 22 Jul 2009 21:43:57 +0000 (21:43 +0000)]
Restore an int declaration on PPC platforms.

This x is one crafty little bugger...
It was used for 2 different things (one of which was only done on PPC) in 1.4.
One of the uses were removed in trunk, and with it went the declaration.

(closes issue #14038)
Reported by: ffloimair

git-svn-id: 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoClarify documentation on 'realtime update2' to show more than one condition.
Tilghman Lesher [Wed, 22 Jul 2009 16:49:42 +0000 (16:49 +0000)]
Clarify documentation on 'realtime update2' to show more than one condition.
(closes issue #15357)
 Reported by: snuffy
       bug_fix_doc_update2.diff uploaded by snuffy (license 35)
       (slightly modified by me)

git-svn-id: 65c4cc65-6c06-0410-ace0-fbb531ad65f3

12 years agoRemove trailing whitespace.
Russell Bryant [Wed, 22 Jul 2009 14:35:49 +0000 (14:35 +0000)]
Remove trailing whitespace.

git-svn-id: 65c4cc65-6c06-0410-ace0-fbb531ad65f3