Russell Bryant [Fri, 22 Jan 2010 04:50:38 +0000 (04:50 +0000)]
Convert scheduler API entry order test to the test API.
Review: https://reviewboard.asterisk.org/r/470/
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@242185
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Fri, 22 Jan 2010 04:49:26 +0000 (04:49 +0000)]
Add test API usage example to test_skel.c.
Review: https://reviewboard.asterisk.org/r/471/
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@242184
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Mark Michelson [Thu, 21 Jan 2010 22:37:55 +0000 (22:37 +0000)]
Add missing argument to ast_calloc calls.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@242092
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Olle Johansson [Thu, 21 Jan 2010 21:05:56 +0000 (21:05 +0000)]
Make sure we initialize the ast_ha structure with ast_calloc
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@242043
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Sean Bright [Thu, 21 Jan 2010 15:27:42 +0000 (15:27 +0000)]
Merged revisions 241932 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r241932 | seanbright | 2010-01-21 10:25:46 -0500 (Thu, 21 Jan 2010) | 5 lines
Fix configure check for PTHREAD_ONCE_INIT when manually adding -Wall to CFLAGS.
(closes issue #16666)
Reported by: romain_proformatique
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@241938
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Thu, 21 Jan 2010 15:14:55 +0000 (15:14 +0000)]
Formats are inconsistent between even 32-bit and 64-bit Linux. Use casts to ensure both compile.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@241896
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Thu, 21 Jan 2010 14:10:51 +0000 (14:10 +0000)]
Point to a useful reference on the XML output format.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@241856
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Thu, 21 Jan 2010 13:59:41 +0000 (13:59 +0000)]
Modify test results XML format to match the JUnit format.
When this code was developed, we came up with our own XML format for the test
output. I have since started looking at integration with other tools, namely
continuous integration frameworks, and this format seems to be supported
across a number of applications. With these changes in place, I was able
to get Atlassian Bamboo to interpret the test results.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@241855
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Thu, 21 Jan 2010 05:54:30 +0000 (05:54 +0000)]
Merged revisions 241765 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r241765 | tilghman | 2010-01-20 23:53:17 -0600 (Wed, 20 Jan 2010) | 2 lines
Guard against division by zero.
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@241766
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
David Vossel [Wed, 20 Jan 2010 21:14:47 +0000 (21:14 +0000)]
rtp timestamp to timeval calculation fix
The rtp timestamp to timeval calculation was only
accurate for 8kHz audio. This patch corrects this.
Review: https://reviewboard.asterisk.org/r/468/
SWP-648
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@241714
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
David Vossel [Wed, 20 Jan 2010 20:01:07 +0000 (20:01 +0000)]
Merged revisions 241626 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r241626 | dvossel | 2010-01-20 14:00:04 -0600 (Wed, 20 Jan 2010) | 6 lines
fixes parsing error in Makefile.
Some echo lines were missing "; . Thanks to jparker for pointing out
the problem.
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@241627
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Alec L Davis [Wed, 20 Jan 2010 17:49:30 +0000 (17:49 +0000)]
Add Calling and Called Subaddress to CDR record
Requires 'callingsubaddr' and 'calledsubaddr' fields in backend cdr.
(closes issue #16600)
Reported by: alecdavis
Patches:
cdr_subaddr.diff.txt uploaded by alecdavis (license 585)
Tested by: alecdavis
Review: https://reviewboard.asterisk.org/r/460/
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@241581
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Kevin P. Fleming [Wed, 20 Jan 2010 13:01:00 +0000 (13:01 +0000)]
Fix up compile breakage from ast_tvdiff_ms() API change.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@241503
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Alec L Davis [Wed, 20 Jan 2010 08:18:45 +0000 (08:18 +0000)]
Update CDR variables as pbx starts
Allows CDR variables added in cdr.c:set_one_cid to become visable during the call,
by executing ast_cdr_update() early in __ast_pbx run.
Reverts sig_pri changes in trunk that are specific to isdn technology only.
(closes issue #16638)
Reported by: alecdavis
Patches:
cdr_update.diff3.txt uploaded by alecdavis (license 585)
Tested by: alecdavis
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@241416
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Jeff Peeler [Tue, 19 Jan 2010 22:59:53 +0000 (22:59 +0000)]
Initialize data on the stack so that Park doesn't interpret random arguments.
passdata was only being set in pbx_substitue_variables when arguments were
passed.
(closes issue #16406)
(closes issue #16586)
Reported by: DLNoah
Patches:
bug16586v2.patch uploaded by jpeeler (license 325)
Tested by: DLNoah
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@241366
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Tue, 19 Jan 2010 22:41:36 +0000 (22:41 +0000)]
Enable SendText to send strings in encoded format.
See http://lists.digium.com/pipermail/asterisk-users/2010-January/243462.html
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@241364
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Jeff Peeler [Tue, 19 Jan 2010 18:51:19 +0000 (18:51 +0000)]
small correction from 241314
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@241315
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Jeff Peeler [Tue, 19 Jan 2010 18:46:11 +0000 (18:46 +0000)]
Merged revisions 241227 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r241227 | jpeeler | 2010-01-19 11:22:18 -0600 (Tue, 19 Jan 2010) | 13 lines
Fix deadlock in agent_read by removing call to agent_logoff.
One must always lock the agents list lock before the agent private. agent_read
locks the private immediately, so locking the agents list lock is not an
option (which is what agent_logoff requires). Because agent_read already
has access to the agent private all that is necessary is to do the required
hanging up that agent_logoff performed.
(closes issue #16321)
Reported by: valon24
Patches:
bug16321.patch uploaded by jpeeler (license 325)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@241314
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Jason Parker [Tue, 19 Jan 2010 17:42:10 +0000 (17:42 +0000)]
Allow parallel make (-j) to work properly.
After some back and forth with the reporter, we came up with the necessary changes.
(closes issue #16489)
Reported by: Chainsaw
Patches:
asterisk-1.6.2.1-parallel-make-minimal.patch uploaded by Chainsaw (license 723)
Tested by: Chainsaw, qwell
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@241230
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Jason Parker [Tue, 19 Jan 2010 17:41:19 +0000 (17:41 +0000)]
Blocked revisions 241228 via svnmerge
........
r241228 | qwell | 2010-01-19 11:41:00 -0600 (Tue, 19 Jan 2010) | 8 lines
Allow parallel make (-j) to work properly.
1.4 changes are quite different from the others.
(issue #16489)
Reported by: Chainsaw
Tested by: qwell
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@241229
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Tue, 19 Jan 2010 00:28:49 +0000 (00:28 +0000)]
Create iterative method for querying SRV results, and use that for finding AGI servers.
(closes issue #14775)
Reported by: _brent_
Patches:
20091215__issue14775.diff.txt uploaded by tilghman (license 14)
hagi-5.patch uploaded by brent (license 388)
Tested by: _brent_
Reviewboard: https://reviewboard.asterisk.org/r/378/
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@241188
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Alec L Davis [Tue, 19 Jan 2010 00:24:35 +0000 (00:24 +0000)]
Update CDR variables before pbx starts (overlap dial)
Allows CDR variables added in cdr.c:set_one_cid to become visable during the call.
(issue #16638)
Reported by: alecdavis
Patches:
cdr_update.diff2.txt uploaded by alecdavis (license 585)
Tested by: alecdavis
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@241187
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Jeff Peeler [Mon, 18 Jan 2010 22:31:25 +0000 (22:31 +0000)]
Extend max call limit duration from 24.8 days to 292+ million years.
If the limit was set past MAX_INT upon answering, the call was immediately
hung up due to overflow from the return of ast_tvdiff_ms (in ast_check_hangup).
The time calculation functions ast_tvdiff_sec and ast_tvdiff_ms have been
changed to return an int64_t to prevent overflow. Also the reporter suggested
adding a message indicating the reason for the call hanging up. Given that the
new limit is so much higher, the message (which would only really be useful in
the overflow scenario) has been made a debug message only.
(closes issue #16006)
Reported by: viraptor
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@241143
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Jason Parker [Mon, 18 Jan 2010 22:03:49 +0000 (22:03 +0000)]
Fix an RTP instance allocation failure on Solaris.
(closes issue #16543)
Reported by: crjw
Patches:
rtp_sin_family.patch uploaded by crjw (license 963)
Tested by: crjw, qwell
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@241098
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Alec L Davis [Mon, 18 Jan 2010 22:00:24 +0000 (22:00 +0000)]
Update CDR variables before pbx starts
Allows CDR variables added in cdr.c:set_one_cid to become visable during the call.
(closes issue #16638)
Reported by: alecdavis
Patches:
cdr_update.diff.txt uploaded by alecdavis (license 585)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@241097
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Sean Bright [Mon, 18 Jan 2010 19:57:52 +0000 (19:57 +0000)]
Merged revisions 241015 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r241015 | seanbright | 2010-01-18 14:54:19 -0500 (Mon, 18 Jan 2010) | 12 lines
Plug a memory leak when reading configs with their comments.
While reading through configuration files with the intent of returning their
full contents (comments specifically) we allocated some memory and then forgot
to free it. This doesn't fix 16554 but clears up a leak I had in the lab.
(issue #16554)
Reported by: mav3rick
Patches:
issue16554_20100118.patch uploaded by seanbright (license 71)
Tested by: seanbright
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@241016
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Mon, 18 Jan 2010 19:26:07 +0000 (19:26 +0000)]
Make HASHes inheritable across channel creation.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@241012
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
David Ruggles [Mon, 18 Jan 2010 18:00:36 +0000 (18:00 +0000)]
ExternalIVR information for UPGRADE.txt
added a paragraph about the fixes and changes to
the ExternalIVR application.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@240974
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
David Ruggles [Mon, 18 Jan 2010 17:51:09 +0000 (17:51 +0000)]
Updated ExternalIVR documentation
Rewrote a large portion of the existing documentation
and added information about the TCP/IP socket interface
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@240973
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
David Vossel [Mon, 18 Jan 2010 17:45:18 +0000 (17:45 +0000)]
transmit_silence_during_record replaced by transmit_silence
In asterisk.conf, transmit_silence_during_record has been removed
in favor of using only the transmit_silence option. The
transmit_silence_during_record option remains a valid option in
asterisk.conf, but has been removed from the sample config and
noted in CHANGES.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@240971
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
David Ruggles [Mon, 18 Jan 2010 17:41:44 +0000 (17:41 +0000)]
Add notification of interrupted file
Add file information to data element of T event so
the file information is sent to the client when it is
interrupted. Previously only notification of pending
files that were dropped was sent
(closes issue #16147)
Reported by: thedavidfactor
Tested by: thedavidfactor
Review: https://reviewboard.asterisk.org/r/449/
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@240969
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
David Vossel [Mon, 18 Jan 2010 16:52:11 +0000 (16:52 +0000)]
Blocked revisions 240891 via svnmerge
........
r240891 | dvossel | 2010-01-18 10:51:35 -0600 (Mon, 18 Jan 2010) | 7 lines
updated transmit_silence option documentation in asterisk.conf
This patch updates the transmit_silence option to better document
why the option exists, and what it affects. Thanks to russell
for providing the verbage for this update.
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@240892
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
David Vossel [Mon, 18 Jan 2010 16:45:28 +0000 (16:45 +0000)]
updated transmit_silence option documentation in asterisk.conf
This patch updates the transmit_silence option to better document
why the option exists, and what it affects. Thanks to russell
for providing the verbage for this update.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@240887
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
David Vossel [Mon, 18 Jan 2010 15:52:55 +0000 (15:52 +0000)]
fixes spelling error. s/memeber/member
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@240842
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Olle Johansson [Mon, 18 Jan 2010 13:29:25 +0000 (13:29 +0000)]
Muted already compiles on OS/X in trunk and 1.6 branches, fix blocked.
Blocked revisions 240768 via svnmerge
........
r240768 | oej | 2010-01-18 14:27:22 +0100 (Mån, 18 Jan 2010) | 2 lines
Fix muted compilation in 1.4 only
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@240769
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Sean Bright [Sun, 17 Jan 2010 19:45:48 +0000 (19:45 +0000)]
Avoid a crash on Solaris when running 'core show functions.'
(closes issue #16309)
Reported by: asgaroth
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@240717
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Sean Bright [Sat, 16 Jan 2010 00:54:08 +0000 (00:54 +0000)]
Get MoH building on OpenSolaris.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@240667
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Fri, 15 Jan 2010 23:50:47 +0000 (23:50 +0000)]
Err, oops, it was already the way I intended.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@240629
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Fri, 15 Jan 2010 23:09:09 +0000 (23:09 +0000)]
Note where empty lines should reside in commit messages.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@240552
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Fri, 15 Jan 2010 23:06:32 +0000 (23:06 +0000)]
Merged revisions 240547 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r240547 | russell | 2010-01-15 17:06:11 -0600 (Fri, 15 Jan 2010) | 2 lines
Fix a spelling error in the asterisk.conf sample.
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@240548
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Sean Bright [Fri, 15 Jan 2010 22:07:31 +0000 (22:07 +0000)]
Clarify error message in res_timing_timerfd.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@240505
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Fri, 15 Jan 2010 21:42:36 +0000 (21:42 +0000)]
Oops, missed an include
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@240500
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Fri, 15 Jan 2010 21:40:14 +0000 (21:40 +0000)]
The previous attempt at using a pipe to guarantee astcanary shutdown did not work.
We're revisiting the previous patch, albeit with a method that overcomes the
prior criticism that it was not POSIX-compliant.
(closes issue #16602)
Reported by: frawd
Patches:
20100114__issue16602.diff.txt uploaded by tilghman (license 14)
Tested by: frawd
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@240499
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Fri, 15 Jan 2010 21:04:34 +0000 (21:04 +0000)]
Add pickup event to AMI. Also, fix AMI documentation.
(closes issue #16431)
Reported by: syspert
Patches:
20100112__issue16431.diff.txt uploaded by tilghman (license 14)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@240421
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Mark Michelson [Fri, 15 Jan 2010 20:58:24 +0000 (20:58 +0000)]
Make sure to set owner_line, ownder_func, and owner_file in ast_calloc_with_stringfields.
Asterisk would crash on startup if MALLOC_DEBUG were set in menuselect. This is because
the manager action UpdateConfig had to resize its string field allocation to set the
description. When the resize occurred, ast_copy_string would crash because we were
attempting to copy a string from a NULL pointer. Setting the strings initially makes
the code much less crashy.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@240420
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Fri, 15 Jan 2010 20:58:19 +0000 (20:58 +0000)]
Make sure that the limit is N, not N - 1.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@240419
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Fri, 15 Jan 2010 20:54:24 +0000 (20:54 +0000)]
Merged revisions 240414 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r240414 | tilghman | 2010-01-15 14:52:27 -0600 (Fri, 15 Jan 2010) | 15 lines
Disallow leaving more than maxmsg voicemails.
This is a possibility because our previous method assumed that no messages are
left in parallel, which is not a safe assumption. Due to the vmu structure
duplication, it was necessary to track in-process messages via a separate
structure. If at some point, we switch vmu to an ao2-reference-counted
structure, which would eliminate the prior noted duplication of structures,
then we could incorporate this new in-process structure directly into vmu.
(closes issue #16271)
Reported by: sohosys
Patches:
20100108__issue16271.diff.txt uploaded by tilghman (license 14)
20100108__issue16271__trunk.diff.txt uploaded by tilghman (license 14)
20100108__issue16271__1.6.0.diff.txt uploaded by tilghman (license 14)
Tested by: jsutton
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@240415
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Fri, 15 Jan 2010 20:41:11 +0000 (20:41 +0000)]
Ensure payload type is properly checked when comparing against cached events.
(closes issue #16607)
Reported by: ddv2005
Patches:
event.patch uploaded by ddv2005 (license 769)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@240411
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Sean Bright [Fri, 15 Jan 2010 18:21:50 +0000 (18:21 +0000)]
Convert a few places to use ast_calloc_with_stringfields where applicable.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@240368
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Fri, 15 Jan 2010 16:51:34 +0000 (16:51 +0000)]
Update configure script for an OSP toolkit related change.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@240329
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Kevin P. Fleming [Fri, 15 Jan 2010 16:28:38 +0000 (16:28 +0000)]
Clarify RTP NAT handling a bit.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@240328
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Sean Bright [Thu, 14 Jan 2010 23:13:02 +0000 (23:13 +0000)]
Plug a memory leak in res_config_ldap.
(closes issue #16257)
Reported by: nito
Patches:
issue16257_20100111.diff uploaded by seanbright (license 71)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@240271
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Sean Bright [Thu, 14 Jan 2010 20:30:03 +0000 (20:30 +0000)]
If we aren't running on a machine that support CLOCK_MONOTONIC, don't load.
Group developed and tested by seanbright, Corydon76, Kobaz, and Amorsen.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@240226
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Jeff Peeler [Thu, 14 Jan 2010 18:03:31 +0000 (18:03 +0000)]
Fix broken call pickup
The problem was the OUTGOING flag was not getting set properly on the channel,
resulting in pickup failing as ast_read thought the call was inbound. Refer to
170393 for a more verbose description as this is the same exact change.
(closes issue #16539)
Reported by: syspert
Patches:
bug16539.patch uploaded by jpeeler (license 325)
Tested by: syspert
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@240179
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Thu, 14 Jan 2010 17:34:53 +0000 (17:34 +0000)]
Similarly, ensure that matchcid is duplicated correctly when merging contexts.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@240175
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Thu, 14 Jan 2010 16:52:22 +0000 (16:52 +0000)]
Ensure that the callerid is NULL when the parent is effectively NULL.
This applies only to pattern-match hints, which create exact-match
hints on the fly.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@240129
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Matthew Nicholson [Thu, 14 Jan 2010 16:14:35 +0000 (16:14 +0000)]
This change fixes a few bugs in the way the far max IFP was calculated that were introduced in r231692.
(closes issue #16497)
Reported by: globalnetinc
Patches:
udptl-max-ifp-fix1.diff uploaded by mnicholson (license 96)
Tested by: globalnetinc
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@240078
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Leif Madsen [Thu, 14 Jan 2010 14:38:01 +0000 (14:38 +0000)]
Add documentation about how to build queues.
Add a how-to set of documentation about building queues with Asterisk.
This documentation is based on Asterisk 1.6.2 but should work on most
versions with minor modifications.
(closes issue #16237)
Reported by: lmadsen
Patches:
Building Queues (FINAL).txt uploaded by lmadsen (license 10)
Tested by: pdhales, lmadsen, cmdrwalrus
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@240039
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Wed, 13 Jan 2010 23:22:56 +0000 (23:22 +0000)]
Oops, another tag error
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@239997
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Wed, 13 Jan 2010 23:21:46 +0000 (23:21 +0000)]
Oops, missed a closing tag
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@239996
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Wed, 13 Jan 2010 21:27:34 +0000 (21:27 +0000)]
Add the TESTTIME() dialplan function, which permits testing GotoIfTime.
Specifically, by setting TESTTIME() to a particular date and time, you
can test whether a dialplan correctly branches as was intended. This was
developed after recent questions on the -users list on how to test their
holiday dialplan logic.
(closes issue #16464)
Reported by: tilghman
Patches:
20100112__issue16464.diff.txt uploaded by tilghman (license 14)
Review: https://reviewboard.asterisk.org/r/458/
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@239957
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Wed, 13 Jan 2010 20:38:42 +0000 (20:38 +0000)]
Flex uses fwrite incorrectly, which breaks the build. Providing a workaround.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@239920
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Jeff Peeler [Wed, 13 Jan 2010 19:48:16 +0000 (19:48 +0000)]
Merged revisions 239838 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r239838 | jpeeler | 2010-01-13 13:43:33 -0600 (Wed, 13 Jan 2010) | 11 lines
Fix regression for timed out parked call returning to caller
This issue seems to have been exposed by the fix in 160390 whereby using a
masquerade prevented a crash. The new channel used in the masquerade was
not copying the macro information from the old channel.
(closes issue #15459)
Reported by: djrodman
Patches:
patch_15459.txt uploaded by mnick (license )
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@239839
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Leif Madsen [Wed, 13 Jan 2010 19:31:13 +0000 (19:31 +0000)]
Add more examples to extensions.conf showing how to use various
functionality and provide commonly useful features.
(closes issue #16090)
Reported by: pprindeville
Patches:
extensions.conf-bugid16090.patch#3 uploaded by pprindeville (license 347)
Tested by: tzafrir, pprindeville, lmadsen
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@239834
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Wed, 13 Jan 2010 18:16:13 +0000 (18:16 +0000)]
Code previously added to ast_expr2f.c warranted a change in the source file ast_expr2.fl.
Also, made a Makefile change to ensure that the expression parser C source files get
regenerated correctly, when we need that to happen.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@239797
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
David Vossel [Wed, 13 Jan 2010 17:16:58 +0000 (17:16 +0000)]
Blocked revisions 239718 via svnmerge
........
r239718 | dvossel | 2010-01-13 11:16:12 -0600 (Wed, 13 Jan 2010) | 23 lines
add silence gen to wait apps
asterisk.conf's 'transmit_silence' option existed before
this patch, but was limited to only generating silence
while recording and sending DTMF. Now enabling the
transmit_silence option generates silence during wait
times as well.
To achieve this, ast_safe_sleep has been modified to
generate silence anytime no other generators are present
and transmit_silence is enabled. Wait apps not using
ast_safe_sleep now generate silence when transmit_silence
is enabled as well.
(closes issue 0016524)
Reported by: kobaz
(closes issue 0016523)
Reported by: kobaz
Tested by: dvossel
Review: https://reviewboard.asterisk.org/r/456/
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@239719
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
David Vossel [Wed, 13 Jan 2010 16:31:14 +0000 (16:31 +0000)]
add silence gen to wait apps
asterisk.conf's 'transmit_silence' option existed before
this patch, but was limited to only generating silence
while recording and sending DTMF. Now enabling the
transmit_silence option generates silence during wait
times as well.
To achieve this, ast_safe_sleep has been modified to
generate silence anytime no other generators are present
and transmit_silence is enabled. Wait apps not using
ast_safe_sleep now generate silence when transmit_silence
is enabled as well.
(closes issue #16524)
Reported by: kobaz
(closes issue #16523)
Reported by: kobaz
Tested by: dvossel
Review: https://reviewboard.asterisk.org/r/456/
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@239712
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Olle Johansson [Wed, 13 Jan 2010 10:45:19 +0000 (10:45 +0000)]
MAX() moved to utils.h
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@239665
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Olle Johansson [Wed, 13 Jan 2010 10:24:23 +0000 (10:24 +0000)]
SIP Show channelstats fix - use float division to show proper stats
(closes issue #15819)
Reported by: klaus3000
Patches:
asterisk-sip-show-channelstats-trunk.txt uploaded by klaus3000 (license 65)
Tested by: klaus3000, oej
This patch is for trunk only and will be blocked in 1.6.2
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@239663
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
TransNexus OSP Development [Wed, 13 Jan 2010 07:02:13 +0000 (07:02 +0000)]
Updated channel variable list of osplookup application.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@239625
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
TransNexus OSP Development [Wed, 13 Jan 2010 07:00:13 +0000 (07:00 +0000)]
Updated XML doc for OSP.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@239624
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Tue, 12 Jan 2010 19:58:00 +0000 (19:58 +0000)]
Blank callerid and NULL callerid should not compare equal.
The second is the default state for matching CID in the dialplan (no matching)
while the first matches one particular CallerID. This is a regression.
(fixes AST-314, SWP-611)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@239571
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Alec L Davis [Tue, 12 Jan 2010 18:55:54 +0000 (18:55 +0000)]
add Dialed Number Identifier (DNID) field to cdr records.
reviewboard link: https://reviewboard.asterisk.org/r/455/
Reported by: alecdavis
Tested by: alecdavis
Patch
cdr_dnid.diff2.txt uploaded by alecdavis (license 585)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@239525
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Leif Madsen [Tue, 12 Jan 2010 18:22:45 +0000 (18:22 +0000)]
Note that direct T.38 is not supported.
(closes issue #16411)
Reported by: stanusr
Patches:
__20091210-sip.conf.sample-documentation.txt uploaded by lmadsen (license 10)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@239520
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Sean Bright [Tue, 12 Jan 2010 17:09:12 +0000 (17:09 +0000)]
Fix crash in res_config_ldap.
We need to allocate enough room for 2 pointers, not 2 characters.
(closes issue #16397)
Reported by: bklang
Patches:
res_config_ldap.patch uploaded by applsplatz (license 949)
Tested by: applsplatz
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@239473
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
David Vossel [Tue, 12 Jan 2010 16:14:41 +0000 (16:14 +0000)]
fixes text support in sdp answer
The code that handled setting 'm=text' in the sdp was not executing
in the correct order. The check to see if text was needed came after
the check to add 'm=text' to the sdp, this resulted in 'm=text' always
being set to 0 because it looked like text was never required.
(closes issue #16457)
Reported by: peterj
Patches:
textportinsdp.diff uploaded by peterj (license 951)
issue16457.diff uploaded by dvossel (license 671)
Tested by: peterj
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@239427
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Olle Johansson [Tue, 12 Jan 2010 07:48:16 +0000 (07:48 +0000)]
Adding Tilghman's documentation from asterisk-dev to the actual file.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@239389
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Tue, 12 Jan 2010 03:21:40 +0000 (03:21 +0000)]
Merged revisions 239307 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r239307 | tilghman | 2010-01-11 21:18:36 -0600 (Mon, 11 Jan 2010) | 8 lines
Portability and other fixes for the safe_asterisk script
(closes issue #16416)
Reported by: bklang
Patches:
safe_asterisk-compat-1.patch uploaded by bklang (license 919)
20100106__issue16416__trunk.diff.txt uploaded by tilghman (license 14)
Tested by: bklang
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@239308
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Mon, 11 Jan 2010 23:53:32 +0000 (23:53 +0000)]
Add LSB headers to init scripts.
(closes issue #14864)
Reported by: lathama
Patches:
lsb-init-info-debian.diff uploaded by pkempgen (license 169)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@239270
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Mon, 11 Jan 2010 23:19:51 +0000 (23:19 +0000)]
Socket level option is SOL_SOCKET, not SO_SOCKET.
(issue #16580)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@239245
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Mon, 11 Jan 2010 23:00:55 +0000 (23:00 +0000)]
Permit more options in the Makefile as to startup options
(closes issue #16454)
Reported by: syspert
Patches:
20091228__issue16454__3.diff.txt uploaded by tilghman (license 14)
Tested by: syspert
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@239231
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Mon, 11 Jan 2010 22:06:38 +0000 (22:06 +0000)]
Including bundle1.o breaks Tiger and Leopard
(issue #16449)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@239191
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Mon, 11 Jan 2010 21:03:46 +0000 (21:03 +0000)]
Permit dates and times to be stored in timezones other than the default (typically, UTC)
(closes issue #16401)
Reported by: lordmortis
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@239152
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Sean Bright [Mon, 11 Jan 2010 16:41:44 +0000 (16:41 +0000)]
Pass NULL for the ao2_callback function pointer instead of duplicating cb_true.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@239114
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Sean Bright [Mon, 11 Jan 2010 16:40:23 +0000 (16:40 +0000)]
Fix ao2_callback when both OBJ_MULTIPLE and OBJ_NODATA are passed.
There is an issue which only affects trunk and the new ao2_callback OBJ_MULTIPLE
implementation. When both OBJ_MULTIPLE and OBJ_NODATA are passed, only the first
object is visited, regardless of what is returned by the specified callback. This
causes a problem when we are clearing a container, i.e.:
ao2_callback(container, OBJ_UNLINK | OBJ_NODATA | OBJ_MULTIPLE, NULL, NULL);
Only unlinks the first object. This patch resolves this.
(closes issue #16564)
Reported by: pj
Patches:
issue16564_20100111.diff uploaded by seanbright (license 71)
Tested by: pj, seanbright
Review: https://reviewboard.asterisk.org/r/457/
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@239113
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Sean Bright [Mon, 11 Jan 2010 16:22:09 +0000 (16:22 +0000)]
Fix spelling of 'category.'
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@239111
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Sun, 10 Jan 2010 19:37:30 +0000 (19:37 +0000)]
According to POSIX, the capital L modifier applies only to floating point types.
Fixes a crash on Solaris.
(closes issue #16572)
Reported by: crjw
Patches:
frame_changes.patch uploaded by crjw (license 963)
Plus several others found and fixed by me
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@239074
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Alexandr Anikin [Sun, 10 Jan 2010 17:53:59 +0000 (17:53 +0000)]
add docallbacks flag in q931decode function because
when we decode received q931 packet we must do callbacks and
when we print sended q931 packet we must not.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@239037
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Sun, 10 Jan 2010 06:56:36 +0000 (06:56 +0000)]
It's been long enough -- make the behavior introduced in 1.6 the default.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@239000
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Sat, 9 Jan 2010 01:08:04 +0000 (01:08 +0000)]
Merged revisions 238915 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r238915 | tilghman | 2010-01-08 18:57:58 -0600 (Fri, 08 Jan 2010) | 6 lines
-1 is interpreted as an error, intead of the maximum mask.
(closes issue #16241)
Reported by: vnovy
Patches:
manager.c.patch uploaded by vnovy (license 922)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@238916
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Jeff Peeler [Fri, 8 Jan 2010 23:30:55 +0000 (23:30 +0000)]
Merged revisions 238834 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r238834 | jpeeler | 2010-01-08 17:28:37 -0600 (Fri, 08 Jan 2010) | 4 lines
Stop a crash when no peer is passed to masq_park_call.
(distantly related to issue #16406)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@238835
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Fri, 8 Jan 2010 22:54:59 +0000 (22:54 +0000)]
Add the class actually used in the MusicOnHold start event.
(closes issue #16499)
Reported by: syspert
Patches:
mohclass.patch uploaded by syspert (license 938)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@238795
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Fri, 8 Jan 2010 22:17:03 +0000 (22:17 +0000)]
Initialize variables that we attempt to free later.
(closes issue #16302)
Reported by: yahsyn
Patches:
20091124__issue16302.diff.txt uploaded by tilghman (license 14)
Tested by: yahsyn
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@238754
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Matthew Nicholson [Fri, 8 Jan 2010 21:04:51 +0000 (21:04 +0000)]
Added a test for ast_format_reduce_str().
(related to issue #16560)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@238716
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
David Vossel [Fri, 8 Jan 2010 19:39:30 +0000 (19:39 +0000)]
fixes AUDIOHOOK_INHERIT regression
During the process of removing an audiohook from one channel
and attaching it to another the audiohook's status is updated
to DONE and then back to whatever it was previously. Typically
updating the status after setting it to DONE is not a good idea
because DONE can trigger unrecoverable audiohook destruction
events... because of this a conditional check was added to
audiohook_update_status to explicitly prevent the audiohook
from ever changing after being set to DONE. It was this check
that prevented audiohook inherit from work properly though.
Now ast_audiohook_move_by_source is treated as a special exception,
as the audiohook must be returned to its previous status after
attaching it to the new channel. This is only a safe operation
because the audiohook's lock is held the entire time, otherwise
this could cause trouble.
(closes issue #16522)
Reported by: corruptor
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@238635
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Matthew Nicholson [Fri, 8 Jan 2010 19:32:11 +0000 (19:32 +0000)]
Merged revisions 238629 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r238629 | mnicholson | 2010-01-08 13:20:44 -0600 (Fri, 08 Jan 2010) | 5 lines
Properly calculate the remaining space in the output string when reducing format strings.
(closes issue #16560)
Reported by: goldwein
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@238630
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Jeff Peeler [Fri, 8 Jan 2010 17:18:41 +0000 (17:18 +0000)]
Stop trying to find a parking space after traversing the parkinglot one time.
(closes issue #16428)
Reported by: Yasuhiro Konishi
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@238583
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Richard Mudgett [Thu, 7 Jan 2010 21:24:06 +0000 (21:24 +0000)]
Fix using the wrong pointer type in do_idle_thread().
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@238527
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
David Vossel [Thu, 7 Jan 2010 20:42:27 +0000 (20:42 +0000)]
fixes ast_transfer stall until hangup if called with a channel that doesn't support transfers
ast_transfer sets res to 0 if there is no technology transfer function,
but then tests for it to be negative before deciding to do an early exit.
As a result, it will will wait for an AST_CONTROL_TRANSFER message that
will never come.
(closes issue #16424)
Reported by: davidw
Patches:
Issue_16424_trunk_234134.patch uploaded by davidw (license 780)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@238492
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
David Vossel [Thu, 7 Jan 2010 20:15:27 +0000 (20:15 +0000)]
Merged revisions 238411 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r238411 | dvossel | 2010-01-07 14:14:25 -0600 (Thu, 07 Jan 2010) | 10 lines
fixes crash in "scheduled_destroy" in chan_iax
A signed short was used to represent a callnumber. This is makes
it possible to attempt to access the iaxs array with a negative
index.
(closes issue #16565)
Reported by: jensvb
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@238412
65c4cc65-6c06-0410-ace0-
fbb531ad65f3