David Vossel [Tue, 14 Jun 2011 14:37:41 +0000 (14:37 +0000)]
Store sip peer name as var data on a outofcall msg.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@323325
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Kinsey Moore [Mon, 13 Jun 2011 20:44:59 +0000 (20:44 +0000)]
Config inheritance doesn't work with ConfBridge() menu definitions
Current behavior in ConfBridge menu definitions is that first definition takes
precedence, even in templated situations. This change allows inheritance and
overriding to work as expected so that the last definition takes precedence.
(closes ASTERISK-17986)
Review: https://reviewboard.asterisk.org/r/1267/
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@323272
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Leif Madsen [Mon, 13 Jun 2011 19:54:27 +0000 (19:54 +0000)]
Merged revisions 323213 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r323213 | lmadsen | 2011-06-13 15:51:52 -0400 (Mon, 13 Jun 2011) | 6 lines
Avoid dividing by zero with L() option to Dial()
Reported by: nicolasom
Patches:
issue-17995.patch - nicolasom (License #5994)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@323214
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
David Vossel [Mon, 13 Jun 2011 19:43:57 +0000 (19:43 +0000)]
Addition of "outofcall_message_context" sip.conf option.
Review: https://reviewboard.asterisk.org/r/1265/
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@323212
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Leif Madsen [Mon, 13 Jun 2011 19:03:46 +0000 (19:03 +0000)]
Merged revisions 323154 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r323154 | lmadsen | 2011-06-13 15:00:41 -0400 (Mon, 13 Jun 2011) | 6 lines
Tweak documentation for AGI Hangup command.
(closes issue ASTERISK-17999)
Reported by: Ben Klang
Patches:
hangup-doc.diff - uploaded by Ben Klang (License #5876)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@323155
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Kinsey Moore [Mon, 13 Jun 2011 14:38:57 +0000 (14:38 +0000)]
MOH for only user not working with ConfBridge
This adds the playing_moh flag to the conference_bridge_user struct that
signifies when MOH should be playing so code doesn't have to guess whether
MOH is playing.
This change also adds the necessary checking to ensure that MOH continues
playing for a single user in a conference after the join sound is played when
configured to do so.
(closes ASTERISK-17988)
Review: https://reviewboard.asterisk.org/r/1263/
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@323107
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Kinsey Moore [Mon, 13 Jun 2011 14:30:51 +0000 (14:30 +0000)]
ConfBridge: Use of bridge or user profiles that don't exist
Bridge and user profiles are not checked for existence before use. The lack
of a fully formed bridge profile can cause a segfault when sounds are accessed.
This change ensures that bridge and user profiles exist prior to usage
attempts.
Review: https://reviewboard.asterisk.org/r/1264/
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@323106
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Matthew Nicholson [Fri, 10 Jun 2011 19:22:48 +0000 (19:22 +0000)]
Merged revisions 323040 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r323040 | mnicholson | 2011-06-10 14:20:41 -0500 (Fri, 10 Jun 2011) | 5 lines
Unlock the sip channel during fax detection like chan_dahdi does to prevent a deadlock with ast_autoservice_stop.
(closes issue ASTERISK-17798)
tested by mnicholson
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@323041
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Terry Wilson [Fri, 10 Jun 2011 15:30:50 +0000 (15:30 +0000)]
Merged revisions 322981 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r322981 | twilson | 2011-06-10 08:29:00 -0700 (Fri, 10 Jun 2011) | 11 lines
Avoid a DB1 infinite loop bug
Explicity check the last entry in the DB and make sure that we don't iterate
past it. Since there can be no duplicates, this just makes sure that we stop
after matching the last key.
This patch also refactors the code to get away from some code duplication. A
previous patch added many astdb tests and this patch passed them.
Review: https://reviewboard.asterisk.org/r/1259/
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@322982
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Terry Wilson [Fri, 10 Jun 2011 03:28:29 +0000 (03:28 +0000)]
Merged revisions 322923 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r322923 | twilson | 2011-06-09 19:33:23 -0700 (Thu, 09 Jun 2011) | 2 lines
Add some astdb unit tests
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@322940
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Terry Wilson [Thu, 9 Jun 2011 22:32:56 +0000 (22:32 +0000)]
Merged revisions 322865 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r322865 | twilson | 2011-06-09 15:29:20 -0700 (Thu, 09 Jun 2011) | 4 lines
Correct ast_db_deltree documentation
ast_db_deltree returns -1 on error, otherwise the number of deletions
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@322866
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Matthew Nicholson [Thu, 9 Jun 2011 17:43:27 +0000 (17:43 +0000)]
Merged revisions 322807 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r322807 | mnicholson | 2011-06-09 12:37:07 -0500 (Thu, 09 Jun 2011) | 5 lines
don't drop any voice frames when checking for T.38 during early media
(closes issue ASTERISK-17705)
Review: https://reviewboard.asterisk.org/r/1186/
patch by oej
reported by oej
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@322808
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Richard Mudgett [Thu, 9 Jun 2011 16:47:07 +0000 (16:47 +0000)]
Merged revisions 322749 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r322749 | rmudgett | 2011-06-09 11:31:53 -0500 (Thu, 09 Jun 2011) | 15 lines
Remove potential deadlock in call pickup race.
Deadlock is possible in ast_do_pickup() when holding the target channel
lock and trying to get the chan channel lock. Also, holding the target
lock when calling ast_channel_masquerade() is not a good idea because that
routine does deadlock avoidance.
* Removed the need to hold the target lock after marking the target with a
datastore and getting the connected line data off of the target channel.
* Moved can_pickup() to ast_can_pickup() in features.c. Now all the call
pickup methods use the same basic call pickup availability check.
Review: https://reviewboard.asterisk.org/r/1234/
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@322750
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Jonathan Rose [Thu, 9 Jun 2011 14:15:04 +0000 (14:15 +0000)]
Blocked revisions 322585 via svnmerge
........
r322585 | jrose | 2011-06-09 09:06:42 -0500 (Thu, 09 Jun 2011) | 11 lines
Adds ast_escape_encoded utility to properly handle escaping of quoted field before uri.
This commit backports a feature in trunk affecting initreqprep so that display name won't
be encoded improperly. Also includes unit tests for the ast_escape_quoted function.
This patch gives 1.8 a much improved outlook in countries which don't use standard
ASCII characters.
(closes issue ASTERISK-16949)
Reported by: Örn Arnarson
Review: https://reviewboard.asterisk.org/r/1235/
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@322586
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Damien Wedhorn [Thu, 9 Jun 2011 11:05:07 +0000 (11:05 +0000)]
Add autoanswer to skinny.
Autoanswer added to skinny based on incoming chan var SKINNY_AUTOANSWER.
Initial value must be the time to autoanswer in ms, then optionally :BEEP
to play a tone when answered and :MUTE to mute the mic when answering.
eg 3000:MUTE:BEEP will ring for 3 secs, then answer, mute the mic, and
play a beep. just 3000 would answer afer 3 secs of ringing with no
beep and full two way audio.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@322544
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Richard Mudgett [Wed, 8 Jun 2011 20:48:03 +0000 (20:48 +0000)]
Merged revisions 322484 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r322484 | rmudgett | 2011-06-08 15:46:55 -0500 (Wed, 08 Jun 2011) | 15 lines
Ring all queue with more than 255 agents will cause crash.
1. Create a ring-all queue with 500 permanent agents.
2. Call it.
3. Asterisk will crash.
The watchers array in app_queue.c has a hard limit of 255. Bounds
checking is not done on this array. No sane person should put 255 people
in a ring-all queue, but we should not crash anyway.
* Added bounds checking to the watchers array.
JIRA AST-464
JIRA SWP-2903
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@322485
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Richard Mudgett [Wed, 8 Jun 2011 18:48:16 +0000 (18:48 +0000)]
Merged revisions 322425 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r322425 | rmudgett | 2011-06-08 13:46:30 -0500 (Wed, 08 Jun 2011) | 16 lines
SRV lookup attempted for SIP peers listed as an IP address.
Asterisk attempts to SRV lookup a host name even if the host name is an IP
address. Regression introduced when IPv6 support was added.
* Restored the check in ast_dnsmgr_lookup() to see if the given host name
is an IP address. The IP address could be in either IPv4 or IPv6 formats.
(closes issue ASTERISK-17815)
Reported by: Byron Clark
Tested by: Byron Clark, Richard Mudgett
Patches:
issue19248_v1.8.patch - uploaded by Richard Mudgett (License #5621)
Review: https://reviewboard.asterisk.org/r/1240/
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@322426
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Damien Wedhorn [Wed, 8 Jun 2011 11:38:56 +0000 (11:38 +0000)]
Remove skinny do_monitor and use ast_sched_start instead
The do_monitor seemed to be there for task scheduling and network monitoring. However, the network monitoring has a dedicated thread so the ast_io_wait was basically just a usleep as it didn't actually seem to be monitoring anything.
Review: https://reviewboard.asterisk.org/r/1256/
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@322381
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Gregory Nietsky [Wed, 8 Jun 2011 06:45:55 +0000 (06:45 +0000)]
Merged revisions 322322 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r322322 | irroot | 2011-06-08 08:18:38 +0200 (Wed, 08 Jun 2011) | 18 lines
Make handle_request_publish do dialog expiration and destruction.
This patch fixes handle_request_publish so that it does dialog expiration and destruction.
Without this patch the incoming PUBLISH requests will get stuck in the dialog list.
Restarting asterisk is the only way to remove them.
Personal observation on one system the server hung up while looping through the channels
rendering asterisk unusable and all sip phones unregisterd when they try reregister
more requests are added.
(closes issue #18898)
Reported by: gareth
Tested by: loloski, Chainsaw, wimpy, se, kuj, irroot
Jira: https://issues.asterisk.org/jira/browse/ASTERISK-17915
Review: https://reviewboard.asterisk.org/r/1253
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@322323
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Richard Mudgett [Tue, 7 Jun 2011 23:14:25 +0000 (23:14 +0000)]
Correct some whitespace and a reference debug message.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@322284
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Tue, 7 Jun 2011 19:17:31 +0000 (19:17 +0000)]
Actually check the "sendtodialplan" option setting for xmpp.
(closes issue ASTERISK-17978)
Reported by: elguero
Patches:
stop_messages_going_to_dialplan.patch (license #5026)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@322244
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Paul Belanger [Tue, 7 Jun 2011 18:01:28 +0000 (18:01 +0000)]
Merged revisions 322189 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r322189 | pabelanger | 2011-06-07 13:59:13 -0400 (Tue, 07 Jun 2011) | 4 lines
Use correct syntax for 'sip notify snom-reboot'
(closes issue ASTERISK-17915)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@322190
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Gregory Nietsky [Mon, 6 Jun 2011 19:39:25 +0000 (19:39 +0000)]
Remove Unused Var Warning rt_handle_member_record
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@322128
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Gregory Nietsky [Mon, 6 Jun 2011 19:30:56 +0000 (19:30 +0000)]
Refactor rt_handle_member_record
Review: https://reviewboard.asterisk.org/r/1172
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@322111
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Jonathan Rose [Mon, 6 Jun 2011 19:15:10 +0000 (19:15 +0000)]
Merged revisions 322069 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r322069 | jrose | 2011-06-06 14:07:56 -0500 (Mon, 06 Jun 2011) | 8 lines
Fixes level toggling for logger set levels since it was reversed
(closes issue ASTERISK-17850)
Reported by: Luke H
Tested by: jrose, Luke H
Review: https://reviewboard.asterisk.org/r/1244/
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@322070
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Richard Mudgett [Fri, 3 Jun 2011 22:15:56 +0000 (22:15 +0000)]
Merged revisions 321926 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r321926 | rmudgett | 2011-06-03 17:09:36 -0500 (Fri, 03 Jun 2011) | 18 lines
Asterisk crash when unloading cdr_radius/cel_radius.
The rc_openlog() API call is passed a string that is used by openlog() to
format log messages. The openlog() does not copy the string it just keeps
a pointer to it. When the module is unloaded, the string is gone from
memory. Depending upon module load order and if the other module then has
an error, a crash happens.
* Pass rc_openlog() a strdup'd string with the understanding that there
will be a small memory leak if the cdr_radius/cel_radius modules are
unloaded.
* Call rc_destroy() to free the rc handle memory when the module is
unloaded.
JIRA AST-483
JIRA SWP-3062
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@321927
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Richard Mudgett [Fri, 3 Jun 2011 21:49:58 +0000 (21:49 +0000)]
Merged revisions 321924 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r321924 | rmudgett | 2011-06-03 16:49:17 -0500 (Fri, 03 Jun 2011) | 5 lines
Be more explicit for CCSS generic device state event subscription.
Make CCSS generic device state event subscription specify the
AST_EVENT_IE_STATE ie exists to be safe.
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@321925
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Richard Mudgett [Fri, 3 Jun 2011 21:02:32 +0000 (21:02 +0000)]
Merged revisions 321871 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r321871 | rmudgett | 2011-06-03 15:58:13 -0500 (Fri, 03 Jun 2011) | 27 lines
Event subscription fixes.
Must commit the subscription fixes together with the integration
subscription tests. The subscription fixes cause an erroneously passing
test to fail. The new subscription tests detect errors without the
subscription fixes.
* Added missing event_names[] table entry.
* Reworked ast_event_check_subscriber()/match_sub_ie_val_to_event() to
correctly detect if a subscriber exists for the proposed event.
* Made match_ie_val() and match_sub_ie_val_to_event() check the buffer
length for RAW payload types.
* Fixed error handling memory leak in ast_event_sub_activate(),
ast_event_unsubscribe(), and ast_event_queue().
* Made ast_event_new() and ast_event_check_subscriber() better protect
themselves from an invalid payload type.
* Added container lock protection between removing old cache events and
adding the new cached event in
ast_event_queue_and_cache()/event_update_cache().
* Added new event subscription tests.
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@321872
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Richard Mudgett [Fri, 3 Jun 2011 19:57:03 +0000 (19:57 +0000)]
Merged revisions 321812-321813 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r321812 | rmudgett | 2011-06-03 14:55:21 -0500 (Fri, 03 Jun 2011) | 1 line
Correct IAX2 and SIP event subscription description string.
........
r321813 | rmudgett | 2011-06-03 14:56:09 -0500 (Fri, 03 Jun 2011) | 1 line
Constify subscription description parameter string.
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@321814
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Fri, 3 Jun 2011 18:33:09 +0000 (18:33 +0000)]
Blocked revisions 321753 via svnmerge
........
r321753 | russell | 2011-06-03 13:32:45 -0500 (Fri, 03 Jun 2011) | 2 lines
Backport an astobj2 unit test so that it runs on 1.8 as well.
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@321754
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Fri, 3 Jun 2011 18:25:11 +0000 (18:25 +0000)]
Fix some astobj2 iterator breakage, add another unit test.
Review: https://reviewboard.asterisk.org/r/1254/
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@321752
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Leif Madsen [Fri, 3 Jun 2011 13:18:21 +0000 (13:18 +0000)]
Merged revisions 321685 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r321685 | lmadsen | 2011-06-03 08:17:50 -0500 (Fri, 03 Jun 2011) | 5 lines
Also document the 'queue-minute' option.
(closes issue #19386)
Reported by: juanmol
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@321689
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Thu, 2 Jun 2011 22:09:05 +0000 (22:09 +0000)]
Fix message destination extension.
Don't send all messages to 's'. Get the destination from the request URI.
(Found using automated test cases).
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@321617
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Richard Mudgett [Wed, 1 Jun 2011 23:12:25 +0000 (23:12 +0000)]
Merged revisions 321547 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r321547 | rmudgett | 2011-06-01 18:11:55 -0500 (Wed, 01 Jun 2011) | 1 line
CDR comment tweaks.
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@321548
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Wed, 1 Jun 2011 21:31:40 +0000 (21:31 +0000)]
Support routing text messages outside of a call.
Asterisk now has protocol independent support for processing text messages
outside of a call. Messages are routed through the Asterisk dialplan.
SIP MESSAGE and XMPP are currently supported. There are options in sip.conf
and jabber.conf that enable these features.
There is a new application, MessageSend(). There are two new functions,
MESSAGE() and MESSAGE_DATA(). Documentation will be available on
the project wiki, wiki.asterisk.org.
Thanks to Terry Wilson for the assistance with development and to David Vossel
for helping with some additional testing.
Review: https://reviewboard.asterisk.org/r/1042/
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@321546
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Brett Bryant [Wed, 1 Jun 2011 20:11:08 +0000 (20:11 +0000)]
Merged revisions 321537 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r321537 | bbryant | 2011-06-01 16:10:02 -0400 (Wed, 01 Jun 2011) | 8 lines
This patch fixes an issue with using the wrong voicemail folders with greetings.
(closes issue #17871)
Reported by: edhorton
Patches:
digium_bug_17871_2 uploaded by fhackenberger (license 592)
Tested by: edhorton, fhackenberger
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@321538
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Alexandr Anikin [Wed, 1 Jun 2011 10:45:12 +0000 (10:45 +0000)]
Merged revisions 321528 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r321528 | may | 2011-06-01 14:40:19 +0400 (Wed, 01 Jun 2011) | 14 lines
Fix double alerting, add forced alerting before answer
Fix double alerting (it wasn't fixed here by issue #18542)
Add forced alerting before connect (if it wasn't before)
Try to send all packets from outgoing queue rather than one only
Call goes into clearing state when disconnect command is received
(closes issue #19361)
Reported by: vmikhelson
Patches:
issue19361-3.patch uploaded by may213 (license 454)
Tested by: vmikhelson
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@321529
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Richard Mudgett [Tue, 31 May 2011 20:55:06 +0000 (20:55 +0000)]
Merged revisions 321517 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r321517 | rmudgett | 2011-05-31 15:54:35 -0500 (Tue, 31 May 2011) | 1 line
Update some comments.
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@321518
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
David Vossel [Tue, 31 May 2011 19:01:42 +0000 (19:01 +0000)]
Merged revisions 321515 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r321515 | dvossel | 2011-05-31 13:52:54 -0500 (Tue, 31 May 2011) | 12 lines
Chan_local locking cleanup.
This patch removes all of the unnecessary deadlock
avoidance loops that occur in chan_local. It also
resolves an issue with a deadlock triggered by
local channel optimizations.
(issue #18028)
Review: https://reviewboard.asterisk.org/r/1231/
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@321516
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Leif Madsen [Tue, 31 May 2011 16:06:21 +0000 (16:06 +0000)]
Merged revisions 321511 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r321511 | lmadsen | 2011-05-31 12:04:47 -0400 (Tue, 31 May 2011) | 8 lines
Enhance NOTICE message to know who couldn't access the dialplan.
(closes issue #19390)
Reported by: lmadsen
Patches:
__20110531-sip-notice-tweak.txt uploaded by lmadsen (license 10)
Tested by: russell
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@321512
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Richard Mudgett [Sat, 28 May 2011 00:29:48 +0000 (00:29 +0000)]
Merged revisions 321436 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r321436 | rmudgett | 2011-05-27 19:27:52 -0500 (Fri, 27 May 2011) | 4 lines
Some hagi launch cleanup.
Inspired by issue 19256. This patch would also fix the crash.
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@321445
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Richard Mudgett [Fri, 27 May 2011 23:46:07 +0000 (23:46 +0000)]
Merged revisions 321392 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r321392 | rmudgett | 2011-05-27 18:45:41 -0500 (Fri, 27 May 2011) | 12 lines
Crash when using hagi and no servers are available.
When none of the servers returned by the SRV querey respond, asterisk
crashes. The problem is that if the loop over all the SRV entries
finishes then the srv_context has already been cleaned up.
* Make ast_srv_cleanup() check to see if the context is already cleaned
up.
(closes issue #19256)
Reported by: byronclark
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@321393
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Richard Mudgett [Fri, 27 May 2011 22:09:03 +0000 (22:09 +0000)]
Merged revisions 321337 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
Also revert -r321331 and -r321332.
........
r321337 | rmudgett | 2011-05-27 17:06:43 -0500 (Fri, 27 May 2011) | 7 lines
The app_privacy args have undocumented "options" position, interferes with "context" position.
* Add documention for unused "options" position to match existing code.
(closes issue #19273)
Reported by: mdavenport
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@321338
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Leif Madsen [Fri, 27 May 2011 21:55:39 +0000 (21:55 +0000)]
Blocked revisions 321335 via svnmerge
........
r321335 | lmadsen | 2011-05-27 17:54:54 -0400 (Fri, 27 May 2011) | 7 lines
Fix issue with playback of H.261 video.
(closes issue #19379)
Reported by: neutrino88
Patches:
videoprompt.patch uploaded by neutrino88 (license 297)
(changes by russell)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@321336
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Leif Madsen [Fri, 27 May 2011 21:40:52 +0000 (21:40 +0000)]
Merged revisions 321333 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r321333 | lmadsen | 2011-05-27 17:40:23 -0400 (Fri, 27 May 2011) | 7 lines
Allow parking lot hints and musicclass to be set.
(closes issue #19378)
Reported by: sboily_proformatique
Patches:
pf_parkinghint_music_fix uploaded by sboily proformatique (license 206)
Tested by: russell
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@321334
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Richard Mudgett [Fri, 27 May 2011 21:37:05 +0000 (21:37 +0000)]
Add note about PrivacyManager to UPGRADE.txt
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@321332
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Richard Mudgett [Fri, 27 May 2011 21:34:04 +0000 (21:34 +0000)]
Merged revisions 321330 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r321330 | rmudgett | 2011-05-27 16:31:25 -0500 (Fri, 27 May 2011) | 8 lines
The app_privacy args have undocumented "options" position, interferes with "context" position.
* Add documention for unused "options" position to match existing code.
The trunk(v1.10) version will remove the unused options position.
(closes issue #19273)
Reported by: mdavenport
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@321331
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Jonathan Rose [Fri, 27 May 2011 16:35:49 +0000 (16:35 +0000)]
Merged revisions 321273 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r321273 | jrose | 2011-05-27 09:59:34 -0500 (Fri, 27 May 2011) | 3 lines
markm committed a patch I was working on yesterday, this fixes it to mesh up with suggestions by mnicholson.
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@321289
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Alec L Davis [Fri, 27 May 2011 08:37:59 +0000 (08:37 +0000)]
Merged revisions 321211 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r321211 | alecdavis | 2011-05-27 20:31:15 +1200 (Fri, 27 May 2011) | 16 lines
Fix *8 directed pickup locks system during pickupsound play out
move playout from sip_pickup_thread to bridge using BRIDGE_PLAY_SOUND method,
This stop the clash of 2 threads trying to write audio to same channel.
In addition fixes choppy audio beep in issue 19177.
(issue #18654)
(issue #19177)
Reported by: Docent
Patches:
review1232-1.8.diff.txt alecdavis (license 585)
Tested by: alecdavis
Review: https://reviewboard.asterisk.org/r/1232/
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@321212
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Mark Murawki [Thu, 26 May 2011 21:50:06 +0000 (21:50 +0000)]
Merged revisions 321155 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r321155 | markm | 2011-05-26 17:48:45 -0400 (Thu, 26 May 2011) | 10 lines
Fixed build problem with dev mode enabled, which was caused by commit 321100. Reformulated patch to be more generic.
Moved the sip uri parse variable initalization to parse_uri_full in reqresp_parser.c. This will ensure that any use of parse uri will have null output variables if the parse fails.
(closes issue #19346)
Reported by: kobaz
Tested by: kobaz,JonathanRose
Review: [full review board URL with trailing slash]
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@321156
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Mark Murawki [Thu, 26 May 2011 20:16:28 +0000 (20:16 +0000)]
Merged revisions 321100 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r321100 | markm | 2011-05-26 16:09:35 -0400 (Thu, 26 May 2011) | 11 lines
ast_sockaddr_resolve() in netsock2.c may deref a null pointer
Added a null check in netsock2 ast_sockaddr_resolve() as well as added default initalizers in chan_sip parse_uri_legacy_check() to make sure that invalid uris will make null (and not undefined) user,pass,domain,transport variables
(closes issue #19346)
Reported by: kobaz
Patches:
netsock2.patch uploaded by kobaz (license 834)
Tested by: kobaz, Marquis
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@321101
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Richard Mudgett [Thu, 26 May 2011 18:10:46 +0000 (18:10 +0000)]
Merged revisions 321044 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r321044 | rmudgett | 2011-05-26 13:10:17 -0500 (Thu, 26 May 2011) | 1 line
Update ast_sockaddr comment with an important note.
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@321045
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Terry Wilson [Thu, 26 May 2011 17:35:55 +0000 (17:35 +0000)]
Merged revisions 321042 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r321042 | twilson | 2011-05-26 10:29:54 -0700 (Thu, 26 May 2011) | 6 lines
Initialize stack-allocated ast_sockaddrs before use
It is important to always initialize ast_sockaddrs before use--even if they
are passed to ast_sockaddr_copy as the underlying storage could be bigger
than what ends up being copied--leaving part of the data unitialized.
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@321043
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Thu, 26 May 2011 16:54:06 +0000 (16:54 +0000)]
Merged revisions 320947 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r320947 | russell | 2011-05-26 10:57:13 -0500 (Thu, 26 May 2011) | 2 lines
Remove some variables that were set but unused.
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@321003
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Terry Wilson [Thu, 26 May 2011 15:55:22 +0000 (15:55 +0000)]
Use va_copy for stringfields
The ast_string_field_build_va functions were written to take to separate
va_lists to work around FreeBSD 4 not having va_copy defined.
In the end, we don't support anything using gcc < 3 anyway because we use
va_copy all over the place anyway. This patch just simplifies things by
removing the second va_list function arguments in favor of va_copy.
Review: https://reviewboard.asterisk.org/r/1233/
--This line, and those below, will be ignored--
M include/asterisk/stringfields.h
M main/utils.c
M main/channel.c
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@320946
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Richard Mudgett [Wed, 25 May 2011 22:28:01 +0000 (22:28 +0000)]
Merged revisions 320883 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r320883 | rmudgett | 2011-05-25 17:25:18 -0500 (Wed, 25 May 2011) | 17 lines
Native SIP CCSS sends bad CC cancel SUBSCRIBE message.
The SUBSCRIBE message used to cancel a CC request has incorrect To/From
SIP headers. They are reversed and the dialog tags are the same when they
should not be. If pedantic mode was disabled, then the cancel would have
succeeded despite the incorrect message.
* The SIP_OUTGOING flag was not set correctly for the dialog and I had to
move some CC subscribe handling code as a result.
* Initialized the dialog subscribed type to CALL_COMPLETION earlier. If a
CC request SUBSCRIBE message comes in and the CC instance is not found,
the 404 response was duplicated.
JIRA AST-568
JIRA SWP-3493
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@320884
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Richard Mudgett [Wed, 25 May 2011 17:14:11 +0000 (17:14 +0000)]
Merged revisions 320823 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r320823 | rmudgett | 2011-05-25 12:06:38 -0500 (Wed, 25 May 2011) | 18 lines
The AMI Newstate event contains different information between v1.4 and v1.8.
The addition of connected line support in v1.8 changes the behavior of the
channel caller ID somewhat. The channel caller ID value no longer time
shares with the connected line ID on outgoing call legs. The timing of
some AMI events/responses output the connected line ID as caller ID.
These party ID's are now separate.
* The ConnectedLineNum and ConnectedLineName headers were added to many
AMI events/responses if the CallerIDNum/CallerIDName headers were also
present.
(closes issue #18252)
Reported by: gje
Tested by: rmudgett
Review: https://reviewboard.asterisk.org/r/1227/
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@320825
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Richard Mudgett [Wed, 25 May 2011 16:50:38 +0000 (16:50 +0000)]
Merged revisions 320796 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r320796 | rmudgett | 2011-05-25 11:23:11 -0500 (Wed, 25 May 2011) | 17 lines
Give zombies a safe channel driver to use.
Recent crashes from zombie channels suggests that they need a safe home to
goto. When a masquerade happens, the physical part of the zombie channel
is hungup. The hangup normally sets the channel private pointer to NULL.
If someone then blindly does a callback to the channel driver, a crash is
likely because the private pointer is NULL.
The masquerade now sets the channel technology of zombie channels to the
kill channel driver.
Related to the following issues:
(issue #19116)
(issue #19310)
Review: https://reviewboard.asterisk.org/r/1224/
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@320820
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Gregory Nietsky [Wed, 25 May 2011 15:43:28 +0000 (15:43 +0000)]
CHANNEL(pickupgroup)
Allow Setting / Reading the pickupgroup of a channel with func_channel.c
(closes issue #19045)
Reported by: irroot
Review: https://reviewboard.asterisk.org/r/1148/
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@320772
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Terry Wilson [Wed, 25 May 2011 00:52:21 +0000 (00:52 +0000)]
Merged revisions 320716 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r320716 | twilson | 2011-05-24 17:49:10 -0700 (Tue, 24 May 2011) | 4 lines
Cast data as char * before using S_OR
This is required for compiling successfully under dev mode
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@320717
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Richard Mudgett [Mon, 23 May 2011 18:00:02 +0000 (18:00 +0000)]
Merged revisions 320650 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r320650 | rmudgett | 2011-05-23 12:53:44 -0500 (Mon, 23 May 2011) | 16 lines
Add ConnectedLineNum/Name headers to output of AMI action Status.
* Add ConnectedLineNum and ConnectedLineName headers to the output of the
AMI action Status. This makes it easier to find out who the channel is
connected to without having to lookup BridgedChannel or when they are
connected to an application (e.g.: VoiceMail) which has no bridged
channel.
* Bridged channels with no CallerID had "" instead of "<unknown>" output,
that might be a bug as "<unknown>" was what older versions used.
(closes issue #18158)
Reported by: gareth
Patches:
svn-292308.diff uploaded by gareth (license 208)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@320651
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
David Vossel [Mon, 23 May 2011 16:28:14 +0000 (16:28 +0000)]
Merged revisions 320568 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
................
r320568 | dvossel | 2011-05-23 11:18:33 -0500 (Mon, 23 May 2011) | 14 lines
Merged revisions 320562 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2
........
r320562 | dvossel | 2011-05-23 11:15:18 -0500 (Mon, 23 May 2011) | 9 lines
Adds missing part to the ast_tcptls_server_start fails second attempt to bind patch.
(closes issue #19289)
Reported by: wdoekes
Patches:
issue19289_delay_old_address_setting_tcptls_2.patch uploaded by wdoekes (license 717)
........
................
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@320606
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Mon, 23 May 2011 16:20:59 +0000 (16:20 +0000)]
Merged revisions 320573 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r320573 | tilghman | 2011-05-23 11:19:32 -0500 (Mon, 23 May 2011) | 7 lines
GNU libiconv uses symbol "libiconv_open" instead of "iconv_open".
(closes issue #19344)
Reported by: rohanl
Patches:
iconv-check.patch uploaded by rohanl (license 1284)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@320579
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Kevin P. Fleming [Mon, 23 May 2011 15:48:37 +0000 (15:48 +0000)]
Merged revisions 320560 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r320560 | kpfleming | 2011-05-23 10:47:14 -0500 (Mon, 23 May 2011) | 4 lines
Don't generate spurious "No: command not found" messages when running the
configure script on a system that has neither gmime-config nor pkg-config.
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@320561
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Jonathan Rose [Mon, 23 May 2011 14:40:59 +0000 (14:40 +0000)]
Merged revisions 320504 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r320504 | jrose | 2011-05-23 09:33:20 -0500 (Mon, 23 May 2011) | 10 lines
Fixes segfault occuring in chan_sip.c at __set_address_from_contact
Checks to see if domain contains anything before sending it off to ast_sockaddr_resolve
which is where the segfault was occuring due to null str.
(closes issue #18857)
Reported by: sybasesql
Review: https://reviewboard.asterisk.org/r/1225/
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@320505
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Sun, 22 May 2011 23:36:02 +0000 (23:36 +0000)]
Merged revisions 320445 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
................
r320445 | tilghman | 2011-05-22 18:34:57 -0500 (Sun, 22 May 2011) | 15 lines
Merged revisions 320444 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2
........
r320444 | tilghman | 2011-05-22 18:25:51 -0500 (Sun, 22 May 2011) | 8 lines
Don't crash when the connection fails.
(closes issue #19250)
Reported by: seadweller
Patches:
20110514__issue19250.diff.txt uploaded by tilghman (license 14)
Tested by: seadweller, sum
........
................
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@320446
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
David Vossel [Fri, 20 May 2011 21:40:19 +0000 (21:40 +0000)]
Merged revisions 320338 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
................
r320338 | dvossel | 2011-05-20 16:39:36 -0500 (Fri, 20 May 2011) | 14 lines
Merged revisions 320271 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2
........
r320271 | dvossel | 2011-05-20 16:24:48 -0500 (Fri, 20 May 2011) | 8 lines
Fixes issue with ast_tcptls_server_start failing on second attempt to bind.
(closes issue #19289)
Reported by: wdoekes
Patches:
issue19289_delay_old_address_setting_tcptls.patch uploaded by wdoekes (license 717)
........
................
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@320340
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Richard Mudgett [Fri, 20 May 2011 20:53:30 +0000 (20:53 +0000)]
Merged revisions 320237 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
................
r320237 | rmudgett | 2011-05-20 15:49:03 -0500 (Fri, 20 May 2011) | 27 lines
Merged revisions 320236 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2
................
r320236 | rmudgett | 2011-05-20 15:44:54 -0500 (Fri, 20 May 2011) | 20 lines
Merged revisions 320235 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r320235 | rmudgett | 2011-05-20 15:38:22 -0500 (Fri, 20 May 2011) | 13 lines
The meetme CLI command completion leaves conferences mutex locked.
When issuing a meetme kick CLI command and an invalid (non-existent)
conference number is specified, pressing Tab leaves the conferences mutex
locked and, therefore, all conferences deadlock.
Add missing unlock.
(closes issue #19336)
Reported by: zvision
Patches:
app_meetme.diff uploaded by zvision (license 798)
........
................
................
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@320238
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Matthew Nicholson [Fri, 20 May 2011 18:49:48 +0000 (18:49 +0000)]
Merged revisions 320180 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r320180 | mnicholson | 2011-05-20 13:48:46 -0500 (Fri, 20 May 2011) | 16 lines
This commit modifies the way polling is done on TLS sockets.
Because of the buffering the TLS layer does, polling is unreliable. If poll is
called while there is data waiting to be read in the TLS layer but not at the
network layer, the messaging processing engine will not proceed until something
else writes data to the socket, which may not occur. This change modifies the
logic around TLS sockets to only poll after a failed read on a non-blocking
socket. This way we know that there is no data waiting to be read from the
buffering layer.
(closes issue #19182)
Reported by: st
Patches:
ssl-poll-fix3.diff uploaded by mnicholson (license 96)
Tested by: mnicholson
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@320181
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Jonathan Rose [Fri, 20 May 2011 18:29:59 +0000 (18:29 +0000)]
Merged revisions 320162 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r320162 | jrose | 2011-05-20 13:12:21 -0500 (Fri, 20 May 2011) | 15 lines
Fixes an imapfolder related crash
imapfolders being set in the general section of voicemail would cause the inbox folder name to
change. Since sound file names are made based on the names of the folders, this would cause
the audio related to that folder name to change and if Asterisk attempted to play it, the
channel would instantly hang up when the audio file couldn't be found. This patch searches for
the name of the folder first to leave existing behavior in tact and if that fails, it uses
the normal inbox name to get the sound file instead.
(closes issue #16104)
Reported by: blkline
Review: https://reviewboard.asterisk.org/r/1215/
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@320178
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Richard Mudgett [Fri, 20 May 2011 17:04:53 +0000 (17:04 +0000)]
Merged revisions 320059 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r320059 | rmudgett | 2011-05-20 12:03:49 -0500 (Fri, 20 May 2011) | 1 line
Misc comment cleanup in features.c.
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@320060
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Richard Mudgett [Fri, 20 May 2011 16:46:02 +0000 (16:46 +0000)]
Merged revisions 320057 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r320057 | rmudgett | 2011-05-20 11:43:02 -0500 (Fri, 20 May 2011) | 19 lines
Crash while transferring a call during DTMF feature timeout.
When a call is being attended transferred during the time between
AST_FRAME_DTMF_BEGIN and AST_FRAME_DTMF_END, the transferred channel
becomes a zombie (so tech data is not available), making ast_dtmf_stream()
segfault when it tries to send the DTMF digit (at least with SIP
channels).
Patch based on feature-end-zombie.patch uploaded by Irontec (license 1256)
* Check for zombies when ast_channel_bridge() returns.
* Guarantee that the fo parameter value is initialized in
ast_channel_bridge() before any returns.
(closes issue #19116)
Reported by: Irontec
Tested by: rmudgett
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@320058
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Jonathan Rose [Fri, 20 May 2011 16:27:12 +0000 (16:27 +0000)]
Adds STRREPLACE function
Adds a new STRREPLACe function to func_strings.c that allows users to search and replace
against a variable in the dialplan.
(closes issue #18023)
Reported by: wdoekes
Review: https://reviewboard.asterisk.org/r/1219/
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@320040
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Richard Mudgett [Fri, 20 May 2011 16:20:25 +0000 (16:20 +0000)]
Merged revisions 320007 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r320007 | rmudgett | 2011-05-20 11:19:01 -0500 (Fri, 20 May 2011) | 2 lines
Change some variable names to make pickup code easier to understand.
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@320013
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Richard Mudgett [Fri, 20 May 2011 15:52:20 +0000 (15:52 +0000)]
Merged revisions 319997 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r319997 | rmudgett | 2011-05-20 10:48:25 -0500 (Fri, 20 May 2011) | 25 lines
Crash when using directed pickup applications.
The directed pickup applications can cause a crash if the pickup was
successful because the dialplan keeps executing.
This patch does the following:
* Completes the channel masquerade on a successful pickup before the
application returns. The channel is now guaranteed a zombie and must not
continue executing the dialplan.
* Changes the return value of the directed pickup applications to return
zero if the pickup failed and nonzero(-1) if the pickup succeeded.
* Made some code optimizations that no longer require re-checking the
pickup channel to see if it is still available to pickup.
(closes issue #19310)
Reported by: remiq
Patches:
issue19310_v1.8_v2.patch uploaded by rmudgett (license 664)
Tested by: alecdavis, remiq, rmudgett
Review: https://reviewboard.asterisk.org/r/1221/
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@319998
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Jonathan Rose [Fri, 20 May 2011 13:42:15 +0000 (13:42 +0000)]
Merged revisions 319938 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r319938 | jrose | 2011-05-20 08:28:24 -0500 (Fri, 20 May 2011) | 12 lines
Adds legacy_useroption_parsing to address interoperability concerns.
With the new option engaged, Asterisk should interpret user fields with useroptions
contained within the userfield of the uri by stripping them out of the original message
whenever a semicolon is encountered in the userfield string.
(closes issue #18344)
Reported by: danimal
Tested by: jrose
Review: https://reviewboard.asterisk.org/r/1223/
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@319939
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Jonathan Rose [Thu, 19 May 2011 18:36:38 +0000 (18:36 +0000)]
Merged revisions 319866 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r319866 | jrose | 2011-05-19 13:32:38 -0500 (Thu, 19 May 2011) | 11 lines
Fix Randomize option on Park()
The randomize option was generally not working like it should have at all on Park().
This patch restores intended functionality.
(closes issue #18862)
Reported by: davidw
Tested by: jrose
Review: https://reviewboard.asterisk.org/r/1222/
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@319867
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Mark Murawki [Thu, 19 May 2011 18:12:49 +0000 (18:12 +0000)]
Merged revisions 319812 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r319812 | markm | 2011-05-19 13:59:01 -0400 (Thu, 19 May 2011) | 9 lines
In cel_odbc, an uninitialized RWLIST is attempted to be locked.
Added INIT and DESTROY for the RWLIST odbc_tables
(closes issue #19331)
Reported by: kobaz
Patches:
odbc_cel.patch uploaded by kobaz (license 834)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@319813
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Richard Mudgett [Thu, 19 May 2011 16:52:47 +0000 (16:52 +0000)]
Merged revisions 319758 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r319758 | rmudgett | 2011-05-19 11:50:48 -0500 (Thu, 19 May 2011) | 21 lines
CCSS generic agent with POTS and ISDN phones fail caller busy call-back test.
If the following is true after a CCSS activation:
* The generic agent is for an analog phone or ISDN phone. (Caller party)
* The called party becomes available.
* The caller party is not available.
When the caller party becomes available, the caller is not alerted to the
called party being available. The generic agent still thinks the caller
is busy.
* Fixed the generic agent device state event subscription to look for all
device states that are considered available.
* Encapsulated the device state test for CCSS generic device available in
cc_generic_is_device_available(). Made the generic agent and monitor use
the new function instead of the manually coded inline equivalent.
JIRA AST-559
JIRA SWP-3462
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@319759
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Terry Wilson [Wed, 18 May 2011 23:18:32 +0000 (23:18 +0000)]
Merged revisions 319654 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
................
r319654 | twilson | 2011-05-18 16:15:58 -0700 (Wed, 18 May 2011) | 22 lines
Merged revisions 319653 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2
................
r319653 | twilson | 2011-05-18 16:11:57 -0700 (Wed, 18 May 2011) | 15 lines
Merged revisions 319652 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r319652 | twilson | 2011-05-18 16:04:35 -0700 (Wed, 18 May 2011) | 8 lines
Make sure everyone gets an unhold when a transfer succeeds
Some phones, like the Snom phones, send a hold to the transfer target after
before sending the REFER. We need to make sure that we unhold the parties
that are being connected after the masquerade. If Local channels with the /nm
option are used when dialing the parties, hold music would still be playing on
the transfer target, even after being connected with the transferee.
........
................
................
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@319661
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Terry Wilson [Wed, 18 May 2011 20:25:32 +0000 (20:25 +0000)]
Merged revisions 319552 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r319552 | twilson | 2011-05-18 13:22:36 -0700 (Wed, 18 May 2011) | 11 lines
Unbreak the storing of registrations for restart
The fix for issue 18882 broke retrieving non-realtime peers from the ast_db
on restart/reload. This patch tries to unbreak things while leaving the intent
of the original fix intact.
(closes issue #19318)
Reported by: remiq
Patches:
diff.txt uploaded by twilson (license 396)
Tested by: lmadsen, remiq
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@319564
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Terry Wilson [Wed, 18 May 2011 20:07:07 +0000 (20:07 +0000)]
Merged revisions 319529 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
................
r319529 | twilson | 2011-05-18 13:05:34 -0700 (Wed, 18 May 2011) | 24 lines
Merged revisions 319528 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2
................
r319528 | twilson | 2011-05-18 13:02:06 -0700 (Wed, 18 May 2011) | 17 lines
Merged revisions 319527 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r319527 | twilson | 2011-05-18 12:56:08 -0700 (Wed, 18 May 2011) | 10 lines
Fix app_dial ring groups
Revert part of r315643. We need to remove the datastore here as well.
The code in bridging code will catch anything that app_dial might miss.
(closes issue #19311)
Reported by: mspuhler
Patches:
issue_19311_no_answer.diff uploaded by elguero (license 37)
........
................
................
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@319530
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Richard Mudgett [Tue, 17 May 2011 22:04:59 +0000 (22:04 +0000)]
Merged revisions 319469 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
................
r319469 | rmudgett | 2011-05-17 16:57:56 -0500 (Tue, 17 May 2011) | 22 lines
Merged revision 319468 from
https://origsvn.digium.com/svn/asterisk/be/branches/C.3-bier
..........
r319468 | rmudgett | 2011-05-17 16:49:31 -0500 (Tue, 17 May 2011) | 15 lines
The mISDN HDLC mode is prevented on dialed channels.
The use of mISDN HDLC mode is prevented if the mISDN dial technology
option 'h1' is used when config option astdtmf=yes.
There is a bug in channels/misdn/isdn_lib.c which prevents the use of HDLC
mode. Instead of setting the channel to HDLC mode it is set to
transparent(no dsp, no hdlc), although hdlc is not "no hdlc". I.e the
logging message is correct, but the if condition is not.
Make check the nodsp and hdlc flags.
JIRA ABE-2787
JIRA SWP-3437
..........
................
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@319471
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Damien Wedhorn [Tue, 17 May 2011 21:59:55 +0000 (21:59 +0000)]
Remove extraneous line variables.
The vars were either explicitly or implicitly not used.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@319470
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Richard Mudgett [Tue, 17 May 2011 20:13:27 +0000 (20:13 +0000)]
Option needed for Q931_IE_TIME_DATE to be optional in CONNECT message.
The NEC SV8300 rejects the Q931_IE_TIME_DATE for Q.SIG.
Add option to specify if and how much of the current time is put in
Q931_IE_TIME_DATE.
* Send date/time ie never.
* Send date/time ie date only.
* Send date/time ie date and hour.
* Send date/time ie date, hour, and minute.
* Send date/time ie date, hour, minute, and second.
* Send date/time ie default: Libpri will send date and hhmm only when in
NT PTMP mode to support ISDN phones.
(closes issue #19221)
Reported by: kenner
JIRA SWP-3396
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@319427
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Leif Madsen [Tue, 17 May 2011 12:54:13 +0000 (12:54 +0000)]
Merged revisions 319367 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r319367 | lmadsen | 2011-05-17 07:53:50 -0500 (Tue, 17 May 2011) | 10 lines
Don't create [general] voicemail context when using users.conf
Prior to this patch, app_voicemail would create a [general] context when parsing users.conf.
(closes issue #18891)
Reported by: pdugas
Patches:
app_voicemail-ignore-general.patch uploaded by pdugas (license 1222)
app_voicemail-ignore-general-style-guidelines.patch uploaded by seanbright (license 71)
Tested by: pdugas
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@319368
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Leif Madsen [Tue, 17 May 2011 12:40:02 +0000 (12:40 +0000)]
Merged revisions 319365 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r319365 | lmadsen | 2011-05-17 07:39:37 -0500 (Tue, 17 May 2011) | 6 lines
Make Debian init script lsb compliant
(closes issue #18896)
Reported by: manwe
Patches:
debian_init_lsb.patch uploaded by manwe (license 1223)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@319366
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Damien Wedhorn [Mon, 16 May 2011 21:39:33 +0000 (21:39 +0000)]
Fix up skinny hints.
Probably haven't been working for a couple of years. May still need
some more love, but they are now working, both as a hint device and
monitoring a hint. Changes centre around the long ago change
to remove the requirement for a device name in a skinny line, and
changes to the transmit_* functions.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@319316
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Jonathan Rose [Mon, 16 May 2011 21:08:50 +0000 (21:08 +0000)]
Merged revisions 319261 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r319261 | jrose | 2011-05-16 16:00:55 -0500 (Mon, 16 May 2011) | 2 lines
Makes busy detection in dsp.c always allow for at least one frame (20ms) of error so that 200ms tone lengths don't get ignored by single frame error lengths.
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@319262
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Richard Mudgett [Mon, 16 May 2011 20:41:31 +0000 (20:41 +0000)]
Merged revisions 319259 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r319259 | rmudgett | 2011-05-16 15:33:37 -0500 (Mon, 16 May 2011) | 13 lines
Deadlock between generic CCSS agent and native ISDN CCSS.
Deadlock can occur when the generic CCSS agent is deleting duplicate CC
offers and the native ISDN CC driver is processing an incoming CC message.
The cc_core_instances container lock cannot be held when an agent or
monitor callback is invoked without the possibility of a deadlock.
* Make kill_duplicate_offers() remove the reference in cc_core_instances
outside of the container lock.
JIRA AST-566
JIRA SWP-3469
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@319260
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Terry Wilson [Mon, 16 May 2011 18:21:17 +0000 (18:21 +0000)]
Merged revisions 319204 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
................
r319204 | twilson | 2011-05-16 13:17:43 -0500 (Mon, 16 May 2011) | 11 lines
Merged revisions 319202 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2
........
r319202 | twilson | 2011-05-16 11:00:21 -0700 (Mon, 16 May 2011) | 4 lines
Unlink a peer from peers_by_ip when expiring a registration
Review: https://reviewboard.asterisk.org/r/1218/
........
................
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@319212
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
David Vossel [Mon, 16 May 2011 15:58:12 +0000 (15:58 +0000)]
Merged revisions 319145 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
................
r319145 | dvossel | 2011-05-16 10:57:26 -0500 (Mon, 16 May 2011) | 9 lines
Merged revisions 319144 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.6.2
........
r319144 | dvossel | 2011-05-16 10:56:16 -0500 (Mon, 16 May 2011) | 2 lines
Fixes issue with peer ref-counting during handle_request_subscribe.
(closes issue #19293)
Reported by: irroot
........
................
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@319146
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Matthew Nicholson [Mon, 16 May 2011 15:54:52 +0000 (15:54 +0000)]
Merged revisions 319142 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r319142 | mnicholson | 2011-05-16 10:53:26 -0500 (Mon, 16 May 2011) | 8 lines
Make sure tcptls_session exists before dereferencing it.
(closes issue #19192)
Reported by: stknob
Patches:
10-tcptls-unreachable-peer-segfault.patch uploaded by Chainsaw (license 723)
Tested by: vois, Chainsaw
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@319143
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Gregory Nietsky [Mon, 16 May 2011 14:56:53 +0000 (14:56 +0000)]
When a error in T.38 negotiation happens or its rejected on a channel the
state of the channel reverts to unknown this should be rejected.
this is important for negotiating T.38 gateway see #13405
This patch adds a option T38_REJECTED that behaves as T38_DISABLED except it reports state rejected.
Trivial Change to res_fax to honnor UNAVAILABLE and REJECTED states.
(closes issue #18889)
Reported by: irroot
Tested by: irroot, darkbasic, mnicholson
Review: https://reviewboard.asterisk.org/r/1115
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@319087
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Paul Belanger [Mon, 16 May 2011 14:38:16 +0000 (14:38 +0000)]
Merged revisions 319085 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r319085 | pabelanger | 2011-05-16 10:35:21 -0400 (Mon, 16 May 2011) | 10 lines
Support gmime-2.4
(closes issue #18863)
Reported by: tzafrir
Patches:
gmime-2.4-18.diff uploaded by tzafrir (license 46)
Tested by: tzafrir
Review: https://reviewboard.asterisk.org/r/1213/
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@319086
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
David Vossel [Mon, 16 May 2011 14:29:06 +0000 (14:29 +0000)]
Merged revisions 319083 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r319083 | dvossel | 2011-05-16 09:26:33 -0500 (Mon, 16 May 2011) | 5 lines
Fixes Big Endian build issue.
(closes issue #19298)
Reported by: tzafrir
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@319084
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Damien Wedhorn [Sun, 15 May 2011 23:17:57 +0000 (23:17 +0000)]
Add activatesub and dialandactivate sub.
When called, activatesub first cleans up the active sub and then
handles the sub passed. dialandactivatesub first sets sub->exten
and then calls activatesub. Revise handle_offhook to utilise the
callid sent to chan_skinny. Some other minor fixes especially around
d->hookstate (which still needs some more work).
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@319024
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Brett Bryant [Fri, 13 May 2011 18:10:45 +0000 (18:10 +0000)]
Merged revisions 318921 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r318921 | bbryant | 2011-05-13 14:09:34 -0400 (Fri, 13 May 2011) | 8 lines
Fixes a segmentation fault in dynamic hints when a channel technology isn't
loaded for a hint.
(closes issue #18495)
Reported by: bertrand
Tested by: bertrand
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@318922
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Brett Bryant [Fri, 13 May 2011 18:06:27 +0000 (18:06 +0000)]
Merged revisions 318919 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r318919 | bbryant | 2011-05-13 14:04:50 -0400 (Fri, 13 May 2011) | 10 lines
This patch fixes an issue with SRTP which makes HOLD/UNHOLD impossible when too
much time has passed between sending audio.
(closes issue #18206)
Reported by: bernhardsi
Patches:
res_srtp_unhold.patch uploaded by bernhards (license 1138)
Tested by: bernhards, notthematrix
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@318920
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Brett Bryant [Fri, 13 May 2011 17:58:53 +0000 (17:58 +0000)]
Merged revisions 318917 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.8
........
r318917 | bbryant | 2011-05-13 13:56:04 -0400 (Fri, 13 May 2011) | 11 lines
This patch allows TCP peers into the ast_db where they were previously
restricted.
(closes issue #18882)
Reported by: cmaj
Patches:
patch-chan_sip-1.8.3-rc2-allow-tcp-peer-store-db-and-readonly-rt-backend.diff.txt
uploaded by cmaj (license 830)
Tested by: cmaj
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@318918
65c4cc65-6c06-0410-ace0-
fbb531ad65f3