Tilghman Lesher [Tue, 27 May 2008 18:59:06 +0000 (18:59 +0000)]
Merged revisions 118465 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r118465 | tilghman | 2008-05-27 13:58:09 -0500 (Tue, 27 May 2008) | 8 lines
NULL character should terminate only commands back to the core, not log
messages to the console.
(closes issue #12731)
Reported by: seanbright
Patches:
20080527__bug12731.diff.txt uploaded by Corydon76 (license 14)
Tested by: seanbright
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@118466
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Michiel van Baak [Tue, 27 May 2008 17:33:21 +0000 (17:33 +0000)]
Zap is now DAHDI, mkay
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@118419
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Michiel van Baak [Tue, 27 May 2008 17:21:12 +0000 (17:21 +0000)]
small update to the g() option of app_voicemail to
note that gain changes only work on zap channels right now.
issue #12578 shows it's not clear right now.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@118417
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Mark Michelson [Tue, 27 May 2008 16:43:36 +0000 (16:43 +0000)]
Merged revisions 118365 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r118365 | mmichelson | 2008-05-27 11:38:38 -0500 (Tue, 27 May 2008) | 14 lines
Add a unique id to the datastore allocated in app_chanspy since
it is possible that multiple spies may be listening to the same
channel.
(closes issue #12376)
Reported by: DougUDI
Patches:
12376_chanspy_uid.diff uploaded by putnopvut (license 60)
Tested by: destiny6628
(closes issue #12243)
Reported by: atis
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@118371
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Tue, 27 May 2008 15:46:58 +0000 (15:46 +0000)]
Merged revisions 118358 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r118358 | tilghman | 2008-05-27 10:45:37 -0500 (Tue, 27 May 2008) | 3 lines
Add a note that pbx_config.so is needed for Local channels.
(Closes issue #12671)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@118359
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Tue, 27 May 2008 14:51:13 +0000 (14:51 +0000)]
Add printf attribute to asprintf
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@118328
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Tue, 27 May 2008 13:30:10 +0000 (13:30 +0000)]
When binding anonymously, credentials are still needed.
(closes issue #12601)
Reported by: suretec
Patches:
res_config_ldap.c.patch uploaded by suretec (license 70)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@118302
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Tue, 27 May 2008 13:13:17 +0000 (13:13 +0000)]
In compat14 mode, don't translate pipes inside expressions, as they aren't
argument delimiters, but rather 'or' symbols.
(Closes issue #12723)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@118300
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Sun, 25 May 2008 16:17:05 +0000 (16:17 +0000)]
Merged revisions 118251 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r118251 | tilghman | 2008-05-25 11:02:04 -0500 (Sun, 25 May 2008) | 12 lines
Realtime flag affects construction in multiple ways, so consulting whether
rtcachefriends was set was done too soon (needed to be done inside build_peer,
not just as a flag to build_peer).
Also, fullcontact needed to be reconstructed, because realtime separates the
embedded ';' into multiple fields.
(closes issue #12722)
Reported by: barthpbx
Patches:
20080525__bug12722.diff.txt uploaded by Corydon76 (license 14)
Tested by: barthpbx
(Much of the discussion happened on #asterisk-dev for diagnosing this issue)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@118252
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Sun, 25 May 2008 14:31:29 +0000 (14:31 +0000)]
Change space-zero to now evaluate to false, as is expected by a great many.
(Inspired by a post on the -users list)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@118223
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Jeff Peeler [Sat, 24 May 2008 01:14:41 +0000 (01:14 +0000)]
add document describing API changes from 1.4.0 to 1.6.0
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@118178
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Jeff Peeler [Sat, 24 May 2008 00:37:01 +0000 (00:37 +0000)]
Fixes segfault in parking, patch submitted by bmd.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@118176
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Mark Michelson [Fri, 23 May 2008 22:41:28 +0000 (22:41 +0000)]
Make sure not to include non-existent headers if they indeed are non-existent
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@118175
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Mark Michelson [Fri, 23 May 2008 22:35:50 +0000 (22:35 +0000)]
A new feature thanks to the fine folks at Switchvox!
If a deadlock is detected, then the typical lock information will be
printed along with a backtrace of the stack for the offending threads.
Use of this requires compiling with DETECT_DEADLOCKS and having glibc
installed.
Furthermore, issuing the "core show locks" CLI command will print the
normal lock information as well as a backtraces for each lock. This
requires that DEBUG_THREADS is enabled and that glibc is installed.
All the backtrace features may be disabled by running the configure
script with --without-execinfo as an argument
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@118173
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Jeff Peeler [Fri, 23 May 2008 21:26:39 +0000 (21:26 +0000)]
Merged revisions 118163 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r118163 | jpeeler | 2008-05-23 16:21:35 -0500 (Fri, 23 May 2008) | 1 line
Fix a few things I missed to ensure zt_chan_conf structure is not modified in mkintf
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@118164
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Brett Bryant [Fri, 23 May 2008 21:19:42 +0000 (21:19 +0000)]
Add new functionality to http server that requires manager authentication for any path that includes a directory named 'private'. This patch also
requires manager authentication for any POST's being sent to the server as well to help secure uploads.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@118161
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Mark Michelson [Fri, 23 May 2008 20:55:02 +0000 (20:55 +0000)]
Get rid of warnings for those silly compilers which warn when freeing
a const pointer
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@118159
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Mark Michelson [Fri, 23 May 2008 19:57:40 +0000 (19:57 +0000)]
Use a deep copy on strings that come from ast_events. Otherwise it is
likely that after the event is freed, we no longer refer to valid memory.
(closes issue #12712)
Reported by: tomo1657
Patches:
12712.patch uploaded by putnopvut (license 60)
Tested by: tomo1657
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@118157
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Fri, 23 May 2008 18:09:14 +0000 (18:09 +0000)]
Protect the object from changing while the 'odbc show' CLI command is running
(Closes issue #12704)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@118129
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Michiel van Baak [Fri, 23 May 2008 17:12:04 +0000 (17:12 +0000)]
add option 'a' to chanisavail.
If you give chanisavail a list of channels, it will only
return the first available channel.
When this option is set, it will return all the available
channels from the given list.
(closes issue #12248)
Reported by: dagmoller
Patches:
app_chanisavail-snv.patch-v2.txt uploaded by dagmoller (license 436)
- major changes by me because russellb pointed out some buffer overflows
and codeguideline issues.
Converted it all to the ast_str_* api
Tested by: dagmoller, mvanbaak
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@118101
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Fri, 23 May 2008 13:20:13 +0000 (13:20 +0000)]
Blocked revisions 118055 via svnmerge
........
r118055 | tilghman | 2008-05-23 08:18:44 -0500 (Fri, 23 May 2008) | 2 lines
Add format type checking for recently de-inlined function
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@118059
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Fri, 23 May 2008 13:00:10 +0000 (13:00 +0000)]
Merged revisions 118052 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r118052 | tilghman | 2008-05-23 07:59:16 -0500 (Fri, 23 May 2008) | 3 lines
Add information on using the Asterisk console, including tab command line
completion. (Closes issue #12681)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@118053
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Fri, 23 May 2008 12:37:31 +0000 (12:37 +0000)]
Merged revisions 118048 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r118048 | russell | 2008-05-23 07:30:53 -0500 (Fri, 23 May 2008) | 9 lines
Don't declare a function that takes variable arguments as inline, because it's
not valid, and on some compilers, will emit a warning.
http://gcc.gnu.org/onlinedocs/gcc/Inline.html#Inline
(closes issue #12289)
Reported by: francesco_r
Patches by Tilghman, final patch by me
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@118049
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Philippe Sultan [Fri, 23 May 2008 10:33:21 +0000 (10:33 +0000)]
- remove whitespaces between tags in received XML packets before giving
them to the parser ;
- report Gtalk error messages from a buddy to the console.
This patch makes Asterisk "Google Jingle" (chan_gtalk) implementation
work with Empathy. Note that this is only true for audio streams, not
video.
Thank you to PH for his great help!
(closes issue #12647)
Reported by: PH
Patches:
trunk-12647-1.diff uploaded by phsultan (license 73)
Tested by: phsultan, PH
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@118020
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Sean Bright [Thu, 22 May 2008 21:43:54 +0000 (21:43 +0000)]
Split the compile flags out and wire up some dependencies
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@117988
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Thu, 22 May 2008 21:42:50 +0000 (21:42 +0000)]
Add a compatibility option for upgrading realtime extensions
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@117986
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Thu, 22 May 2008 21:27:00 +0000 (21:27 +0000)]
Fix trunk breakage
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@117983
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Sean Bright [Thu, 22 May 2008 20:01:33 +0000 (20:01 +0000)]
A couple more places the frame data change was missed.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@117950
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Thu, 22 May 2008 18:54:41 +0000 (18:54 +0000)]
Merged revisions 117899 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r117899 | tilghman | 2008-05-22 13:53:53 -0500 (Thu, 22 May 2008) | 2 lines
Also remove preamble from asynchronous events (reported by jsmith on #asterisk-dev)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@117900
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Michiel van Baak [Thu, 22 May 2008 17:50:40 +0000 (17:50 +0000)]
one more place I forgot
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@117870
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Michiel van Baak [Thu, 22 May 2008 17:16:08 +0000 (17:16 +0000)]
chan_console fixes because of ast_frame.data => ast_frame.data.ptr
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@117834
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Jason Parker [Thu, 22 May 2008 17:10:53 +0000 (17:10 +0000)]
Fix a few places where frame data was used directly.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@117828
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Michiel van Baak [Thu, 22 May 2008 17:08:18 +0000 (17:08 +0000)]
oops
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@117825
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Michiel van Baak [Thu, 22 May 2008 17:06:00 +0000 (17:06 +0000)]
forgot chan_misdn
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@117822
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Thu, 22 May 2008 16:50:32 +0000 (16:50 +0000)]
Blocked revisions 117809 via svnmerge
........
r117809 | tilghman | 2008-05-22 11:47:03 -0500 (Thu, 22 May 2008) | 6 lines
Take into account the length of delimiters when calculating result string length.
(closes issue #12696)
Reported by: adomjan
Patches:
func_realtime.c-longdelimiter.patch uploaded by adomjan (license 487)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@117812
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Michiel van Baak [Thu, 22 May 2008 16:29:54 +0000 (16:29 +0000)]
- revert change to ast_queue_hangup and create ast_queue_hangup_with_cause
- make data member of the ast_frame struct a named union instead of a void
Recently the ast_queue_hangup function got a new parameter, the hangupcause
Feedback came in that this is no good and that instead a new function should be created.
This I did.
The hangupcause was stored in the seqno member of the ast_frame struct. This is not very
elegant, and since there's already a data member that one should be used.
Problem is, this member was a void *.
Now it's a named union so it can hold a pointer, an uint32 and there's a padding in case someone
wants to store another type in there in the future.
This commit is so massive, because all ast_frame.data uses have to be
altered to ast_frame.data.data
Thanks russellb and kpfleming for the feedback.
(closes issue #12674)
Reported by: mvanbaak
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@117802
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Mark Michelson [Thu, 22 May 2008 16:05:18 +0000 (16:05 +0000)]
Committing a fix pointed out by Atis Lezdins on the asterisk-dev list. Thanks!
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@117794
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Sean Bright [Thu, 22 May 2008 15:49:17 +0000 (15:49 +0000)]
Minor text fix. roster -> resource.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@117792
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Thu, 22 May 2008 13:40:52 +0000 (13:40 +0000)]
Store build-time options as a string in AST_BUILDOPTS in buildopts.h. Also,
display this information in the "core show settings" CLI command. This is
useful if you want to verify that you're running a build with DONT_OPTIMIZE,
DEBUG_THREADS, etc.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@117756
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Thu, 22 May 2008 05:10:01 +0000 (05:10 +0000)]
Enhance ExternalIVR with new options and commands.
(closes issue #12705)
Reported by: ctooley
Patches:
new_externalivr_argument_format-v2.diff uploaded by ctooley (license 136)
new_externalivr_documentation.diff uploaded by ctooley (license 136)
and a few additional fixes by me
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@117725
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Mark Michelson [Wed, 21 May 2008 22:34:27 +0000 (22:34 +0000)]
This change makes it so that logs will report the correct source of verbose messages.
Until this change, all verbose messages in Asterisk's log files reported logger.c
as the source of the message.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@117693
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Jeff Peeler [Wed, 21 May 2008 21:31:17 +0000 (21:31 +0000)]
Merged revisions 117582 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r117582 | jpeeler | 2008-05-21 15:11:14 -0500 (Wed, 21 May 2008) | 2 lines
Ensure that passed in zt_chan_conf structure is not modified in mkintf.
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@117658
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Jeff Peeler [Wed, 21 May 2008 20:44:04 +0000 (20:44 +0000)]
Merged revisions 117462 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r117462 | jpeeler | 2008-05-21 11:58:40 -0500 (Wed, 21 May 2008) | 3 lines
Pass a pointer for the conf parameter to the function mkintf rather than the whole zt_chan_conf structure.
Another commit is following to make sure the zt_chan_conf structure is not modified.
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@117628
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Mark Michelson [Wed, 21 May 2008 20:27:45 +0000 (20:27 +0000)]
Add a new manager event, AgentRingNoAnswer to
app_queue.
(closes issue #12591)
Reported by: CCHAsteria
Patches:
app_queue_RNA_event.diff uploaded by CCHAsteria (license 477)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@117625
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Joshua Colp [Wed, 21 May 2008 19:39:42 +0000 (19:39 +0000)]
Merged revisions 117574 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r117574 | file | 2008-05-21 16:38:28 -0300 (Wed, 21 May 2008) | 2 lines
Apply the autoframing setting to dialogs that do not get matched against a user or peer.
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@117575
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Wed, 21 May 2008 18:45:26 +0000 (18:45 +0000)]
Blocked revisions 117523 via svnmerge
........
r117523 | tilghman | 2008-05-21 13:44:53 -0500 (Wed, 21 May 2008) | 2 lines
Revert accidental commit of the last change
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@117524
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Wed, 21 May 2008 18:43:26 +0000 (18:43 +0000)]
Merged revisions 117519 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r117519 | tilghman | 2008-05-21 13:40:14 -0500 (Wed, 21 May 2008) | 3 lines
Strip the preamble from the output also when -rx is not being used
(Related to issue #12702)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@117520
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Mark Michelson [Wed, 21 May 2008 18:31:05 +0000 (18:31 +0000)]
Optimize the update_realtime_member_field function by not having
to query the database for the member and instead using a cached
uniqueid.
Special thanks to atis for creating this and for keeping it up
to date with necessary changes
(closes issue #11896)
Reported by: atis
Patches:
realtime_uniqueid_v6.patch uploaded by atis (license 242)
Tested by: atis
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@117517
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Wed, 21 May 2008 18:29:05 +0000 (18:29 +0000)]
Merged revisions 117514 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r117514 | russell | 2008-05-21 13:28:46 -0500 (Wed, 21 May 2008) | 4 lines
Don't filter the magic character in the network verboser. It gets filtered
once it reaches the client.
(related to issue #12702, pointed out by tilghman)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@117515
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Wed, 21 May 2008 18:20:11 +0000 (18:20 +0000)]
Merged revisions 117507 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r117507 | russell | 2008-05-21 13:19:34 -0500 (Wed, 21 May 2008) | 7 lines
1) Don't print the verbose marker in front of every message from ast_verbose()
being sent to remote consoles.
2) Fix pbx_gtkconsole to filter out the verbose marker.
(related to issue #12702)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@117508
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Wed, 21 May 2008 18:12:19 +0000 (18:12 +0000)]
Merged revisions 117479 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r117479 | russell | 2008-05-21 13:11:51 -0500 (Wed, 21 May 2008) | 6 lines
Don't display the verbose marker for calls to ast_verbose() that do not include
a VERBOSE_PREFIX in front of the message.
(closes issue #12702)
Reported by: johnlange
Patched by me
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@117481
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Wed, 21 May 2008 13:39:41 +0000 (13:39 +0000)]
On socket-based connections, there is no error FD, so don't try waiting on one.
(closes issue #12697)
Reported by: ctooley
Patches:
fix_externalivr_waitfor_nandfds-v3.diff uploaded by ctooley (license 136)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@117431
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Luigi Rizzo [Wed, 21 May 2008 11:24:50 +0000 (11:24 +0000)]
do not die on SDL_ACTIVEEVENT reporting lost focus.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@117401
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Mark Michelson [Wed, 21 May 2008 02:20:31 +0000 (02:20 +0000)]
Be sure that we cache included files for each source file which loads
a configuration file. As it was, only the first did so. This led to
a problem if the included file was changed (but not the configuration
file which includes it) and the second source file attempted to reload
the configuration. It would not see that the included file had changed.
In this particular example, res_phoneprov and chan_sip both loaded
sip.conf, which included a file call sip.peers.conf. Since res_phoneprov
was the first to load sip.conf, only it cached the fact that sip.conf
included sip.peers.conf. If sip.peers.conf were changed and sip.conf were
not and a sip reload were issued (meaning that chan_sip attempts to
reload sip.conf only if it and its included files have changed) the changes
made to sip.peers.conf would not be seen and therefore no action would be
taken.
(closes issue #12693)
Reported by: marsosa
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@117367
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Steve Murphy [Wed, 21 May 2008 01:00:28 +0000 (01:00 +0000)]
These changes were made via the comments atis_work made at 4:30am (Mountain Time zone- US)
in #asterisk-dev on 20 May 2008. He noted that a backslash was being inserted before commas
in app call arguments in the extensions.conf.aeldump file that you get from aelparse with the
-w arg. This was being generated from code left over from 1.4, where commas were substituted
with '|', and any remaining commas needed to be escaped.
Many thanks to atis for his comment; please let us know if these changes break anything!
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@117335
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Luigi Rizzo [Tue, 20 May 2008 18:07:24 +0000 (18:07 +0000)]
+ Implement a variant of astman_get_header() to return the first or
last match, and possibly skip empty fields. The function is useful
(and used here) when a form submits multiple 'Action' fields to the
Manager.
This change slightly modifies the current behaviour, but only in the
case the user supplies multiple 'Action: ' lines and the first
ones are empty, so the change is totally harmless.
+ Fix style on a couple of "if (displayconnects)" statements;
+ Expand a bit the 'Manager Test' interface, to make it slightly
more user friendly. But also comment that the HTML should not
be embedded in the C source.
None of this stuff needs to be applied to 1.4.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@117297
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Luigi Rizzo [Tue, 20 May 2008 17:48:43 +0000 (17:48 +0000)]
Document the possible presence of multiple variables with the
same name in http queries, which might confuse the manager.
Replace calls to ast_uri_decode() with a local function that also
replaces '+' with ' ', as this is the normal encoding for
spaces in http requests.
This allows passing cli commands to the manager through the
http interface.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@117295
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Luigi Rizzo [Tue, 20 May 2008 16:39:39 +0000 (16:39 +0000)]
Reverse the check for Cookie: and remove leftover code implementing
the same thing.
Add an ast_debug() call to help debugging the url matching.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@117266
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Tue, 20 May 2008 16:25:16 +0000 (16:25 +0000)]
Increase limit of unshared connections from 1023 to 4.2 billion.
(Related to issue #12677)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@117264
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Tue, 20 May 2008 16:13:48 +0000 (16:13 +0000)]
Revert part of previous fix, and heavily comment the logic for object
destruction, for future users.
(Closes issue #12677)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@117262
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Mon, 19 May 2008 20:45:25 +0000 (20:45 +0000)]
Minor formatting change to test a mantis change ...
(issue #12674)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@117212
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Mon, 19 May 2008 20:06:38 +0000 (20:06 +0000)]
Change the default for the pridialplan parameter to the far more common case of
'unknown', and better document the use of each parameter.
(closes issue #12633)
Reported by: tzafrir
Patches:
pridialplan_unknown_2.diff uploaded by tzafrir (license 46)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@117182
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Joshua Colp [Mon, 19 May 2008 16:53:33 +0000 (16:53 +0000)]
Merged revisions 117135 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r117135 | file | 2008-05-19 13:50:52 -0300 (Mon, 19 May 2008) | 6 lines
Use the right pthread lock and condition when waiting.
(closes issue #12664)
Reported by: tomo1657
Patches:
res_smdi.c.patch uploaded by tomo1657 (license 484)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@117136
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Joshua Colp [Mon, 19 May 2008 16:22:56 +0000 (16:22 +0000)]
Remove a premature mutex destroy (the destruction callback will end up destroying it) and use a callback to purge remaining classes.
(closes issue #12677)
Reported by: falves11
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@117133
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Mon, 19 May 2008 16:07:09 +0000 (16:07 +0000)]
Merged revisions 117086 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r117086 | tilghman | 2008-05-19 11:05:05 -0500 (Mon, 19 May 2008) | 2 lines
The addition of usleep(2) within ast_assert requires the inclusion of the unistd.h header
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@117088
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Joshua Colp [Mon, 19 May 2008 16:03:33 +0000 (16:03 +0000)]
The logger closes the files it is logging to when reloading so we have to read in the logger configuration even if it has not changed so that the logs get opened again.
(closes issue #12665)
Reported by: DennisD
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@117085
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Luigi Rizzo [Mon, 19 May 2008 15:47:46 +0000 (15:47 +0000)]
trap potential failures of SDL when SDL_WINDOWID is pointing to a
random window.
This commit is essentially a workaround for some undesirable behaviour of SDL;
we should not be doing this in the application, but in the library.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@117084
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Joshua Colp [Mon, 19 May 2008 15:24:44 +0000 (15:24 +0000)]
Merged revisions 117081 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r117081 | file | 2008-05-19 12:22:10 -0300 (Mon, 19 May 2008) | 6 lines
Make chan_h323 work with pwlib 1.12.0
(closes issue #12682)
Reported by: bamby
Patches:
pwlib_nopipe.diff uploaded by bamby (license 430)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@117082
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Luigi Rizzo [Mon, 19 May 2008 14:54:34 +0000 (14:54 +0000)]
fix example configuration for video support in chan_oss
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@117053
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Luigi Rizzo [Mon, 19 May 2008 14:22:04 +0000 (14:22 +0000)]
Some fixes to the code to support running on an externally
supplied window.
SDL (at least recent 1.2.x versions) has the ability to run the
graphic output into an externally supplied window, whose ID in the
environment variable SDL_WINDOWID. Ideally, applications should
run unchanged irrespective of who creates the window. Unfortunately,
SDL does not subscribe to mouse, key and resize events on externally
supplied windows, so we need to do ask for these events explicitly.
On passing, also add some code to handle SDL_ACTIVEEVENT so if
the X11 window is killed while we are active, we call
"stop now" to terminate the asterisk instance.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@117052
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Luigi Rizzo [Mon, 19 May 2008 13:33:08 +0000 (13:33 +0000)]
Allow users to specify 'startgui=1' in oss.conf so that the
graphic screen for the video console is activated at startup.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@117024
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Mon, 19 May 2008 03:44:28 +0000 (03:44 +0000)]
Merged revisions 116978 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r116978 | russell | 2008-05-18 22:44:04 -0500 (Sun, 18 May 2008) | 4 lines
Avoid access of uninitialized memory. This caused a bunch of crashes for me
while doing load testing of development branch where I'm working on some
performance improvements.
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@116979
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Sun, 18 May 2008 21:15:58 +0000 (21:15 +0000)]
Add a set of text to the file astcanary uses to communicate back the main
Asterisk process, which explains the purpose for the file being there. This
should assist people who find the file and wonder why it exists.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@116948
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Sun, 18 May 2008 19:58:10 +0000 (19:58 +0000)]
Remove duplicate colon on Reason header
(closes issue #12678)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@116919
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Joshua Colp [Sat, 17 May 2008 19:39:35 +0000 (19:39 +0000)]
Improve native transfers when a chain of IAX2 connections are in use.
(closes issue #7567)
Reported by: tjd
Patches:
bug_7567_update_v2.diff uploaded by snuffy (license 35)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@116884
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Joshua Colp [Fri, 16 May 2008 21:34:45 +0000 (21:34 +0000)]
Try to fix attended transfers.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@116848
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Joshua Colp [Fri, 16 May 2008 20:30:24 +0000 (20:30 +0000)]
Merged revisions 116799 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r116799 | file | 2008-05-16 17:28:11 -0300 (Fri, 16 May 2008) | 4 lines
Check to make sure an RTP structure exists before calling ast_rtp_new_source on it.
(closes issue #12669)
Reported by: sbisker
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@116800
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Matthew Fredrickson [Fri, 16 May 2008 20:00:04 +0000 (20:00 +0000)]
Try to see if we can make our ringback situation a little better
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@116797
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Sean Bright [Fri, 16 May 2008 17:08:59 +0000 (17:08 +0000)]
Compile under dev-mode, please.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@116765
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Jim Dixon [Fri, 16 May 2008 00:51:14 +0000 (00:51 +0000)]
Bring all app_rpt and chan_usbradio stuff up to date
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@116731
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Thu, 15 May 2008 22:05:47 +0000 (22:05 +0000)]
Add an extra check in ast_strlen_zero, and make ast_assert() not print the
file, line, and function name twice.
(Closes issue #12650)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@116694
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Jeff Peeler [Thu, 15 May 2008 21:54:18 +0000 (21:54 +0000)]
Fixes a problem I was having with two SIP phones using Packet2Packet bridging dropping audio nearly immediately. The problem was that the lock on the SIP dialog was not being unlocked while the bridge was still active. (Related to issue #12566)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@116663
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Thu, 15 May 2008 17:58:22 +0000 (17:58 +0000)]
Don't unload config on reload, when config has not changed.
(Closes issue #12652)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@116631
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Mark Michelson [Thu, 15 May 2008 15:40:29 +0000 (15:40 +0000)]
When counting urgent messages when using IMAP storage, take into account that
the urgent messages are not in their own folder but are actually "flagged" messages
in the INBOX.
(closes issue #12659)
Reported by: jaroth
Patches:
urgentfolder_v2.patch uploaded by jaroth (license 50)
Tested by: jaroth
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@116594
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Mark Michelson [Thu, 15 May 2008 15:24:29 +0000 (15:24 +0000)]
Modify externnotify to take the number of urgent voicemails as a final argument instead
of the string "Urgent"
(closes issue #12660)
Reported by: jaroth
Patches:
externnotify.patch uploaded by jaroth (license 50)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@116592
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Mark Michelson [Thu, 15 May 2008 15:13:11 +0000 (15:13 +0000)]
Prevent crashes from occurring due to a strcmp of a NULL pointer.
(closes issue #12661)
Reported by: jaroth
Patches:
urgentcompare.patch uploaded by jaroth (license 50)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@116590
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Luigi Rizzo [Thu, 15 May 2008 10:56:29 +0000 (10:56 +0000)]
Use casts or intermediate variables to remove a number
of platform/compiler-dependent warnings when handing
struct timeval fields, both reading and printing them.
It is a lost battle to handle the different ways struct timeval
is handled on the various platforms and compilers, so try
to be pragmatic and go through int/long which are universally
supported.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@116557
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Mark Michelson [Wed, 14 May 2008 22:15:12 +0000 (22:15 +0000)]
Adding a new option to Chanspy(). The 'd' option allows for the spy to
press DTMF digits to switch between spying modes. Pressing 4 activates spy mode,
pressing 5 activates whisper mode, and pressing 6 activates barge mode. Use of
this feature overrides the normal operation of DTMF numbers.
This feature is courtesy of Switchvox.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@116522
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Joshua Colp [Wed, 14 May 2008 21:54:03 +0000 (21:54 +0000)]
Fix pedanticness.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@116471
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Wed, 14 May 2008 21:40:43 +0000 (21:40 +0000)]
Merged revisions 116463 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r116463 | russell | 2008-05-14 16:32:00 -0500 (Wed, 14 May 2008) | 4 lines
Add ast_assert(), which can be used to handle fatal errors. It is only compiled
in if dev-mode is enabled, and only aborts if DO_CRASH is defined.
(inspired by issue #12650)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@116469
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Wed, 14 May 2008 21:39:06 +0000 (21:39 +0000)]
Merged revisions 116466 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r116466 | tilghman | 2008-05-14 16:38:09 -0500 (Wed, 14 May 2008) | 7 lines
Avoid zombies when the channel exits before the AGI.
(closes issue #12648)
Reported by: gkloepfer
Patches:
20080514__bug12648.diff.txt uploaded by Corydon76 (license 14)
Tested by: gkloepfer
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@116467
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Joshua Colp [Wed, 14 May 2008 21:11:49 +0000 (21:11 +0000)]
Add a missing context unlock.
(closes issue #12649)
Reported by: ys
Patches:
pbx.c.diff uploaded by ys (license 281)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@116461
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Jason Parker [Wed, 14 May 2008 20:43:26 +0000 (20:43 +0000)]
Merged revisions 116409 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r116409 | qwell | 2008-05-14 15:43:08 -0500 (Wed, 14 May 2008) | 1 line
Document exitcontext in app_voicemail sample config
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@116410
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Jason Parker [Wed, 14 May 2008 20:36:55 +0000 (20:36 +0000)]
Voicemail "* exit" should not require an exitcontext to be specified.
The behavior in 1.4 was that it would use the current context if an exitcontext existed.
(closes issue #12605)
Reported by: kenjreno
Patches:
12605-starexit.diff uploaded by qwell (license 4)
Tested by: file
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@116407
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Joshua Colp [Wed, 14 May 2008 18:54:16 +0000 (18:54 +0000)]
Merged revisions 116352 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r116352 | file | 2008-05-14 15:53:39 -0300 (Wed, 14 May 2008) | 4 lines
Add linux-gnueabi in.
(closes issue #12529)
Reported by: tzafrir
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@116353
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Joshua Colp [Wed, 14 May 2008 18:25:54 +0000 (18:25 +0000)]
Make the ldap version setting work without having both version and protocol set.
(closes issue #12613)
Reported by: suretec
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@116350
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Wed, 14 May 2008 16:53:23 +0000 (16:53 +0000)]
Merged revisions 116296 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r116296 | tilghman | 2008-05-14 11:46:48 -0500 (Wed, 14 May 2008) | 2 lines
Detect another way for a connection to have gone away.
(closes issue #12618)
Reported by: ctooley
Patches:
1.4-externalivr-test_fd.diff uploaded by ctooley (license 136)
trunk-externalivr-test_fd.diff uploaded by ctooley (license 136)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@116298
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Jeff Peeler [Wed, 14 May 2008 16:52:30 +0000 (16:52 +0000)]
Fixed a few problems with multiparking: call not being parked in the correct parking spot, caller not being notified of parking spot position, and improperly hanging up the call during a transfer due to timing out (not providing the extension in which to transfer).
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@116297
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Olle Johansson [Wed, 14 May 2008 14:16:51 +0000 (14:16 +0000)]
Don't add linefeed on received MESSAGE
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@116240
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Olle Johansson [Wed, 14 May 2008 14:03:42 +0000 (14:03 +0000)]
Properly declare charset for text messages.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@116239
65c4cc65-6c06-0410-ace0-
fbb531ad65f3