asterisk/asterisk.git
16 years agosome simplifications to
Luigi Rizzo [Tue, 28 Nov 2006 14:07:09 +0000 (14:07 +0000)]
some simplifications to
ast_dynamic_str_thread_build_va_couldnt_we_choose_a_shorter_name()

I am unsure whether the truncation of the string in case of a failed
attempt should be done unconditionally. See the XXX mark.

Russel, ideas ?

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48084 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agodo not return 500 Internal error if the AMI command provides
Luigi Rizzo [Tue, 28 Nov 2006 13:08:56 +0000 (13:08 +0000)]
do not return 500 Internal error if the AMI command provides
no output.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48083 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agomosty comment and documentation cleanup on waitevent.
Luigi Rizzo [Tue, 28 Nov 2006 12:05:25 +0000 (12:05 +0000)]
mosty comment and documentation cleanup on waitevent.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48082 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoMove the code to purge stale sessions to a function,
Luigi Rizzo [Tue, 28 Nov 2006 11:20:39 +0000 (11:20 +0000)]
Move the code to purge stale sessions to a function,
to simplify the body of the main loop of the accepting thread.
Rename purge_unused() to purge_events() so one knows what the
function does.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48081 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoVarious simplifications of the code:
Luigi Rizzo [Tue, 28 Nov 2006 10:23:25 +0000 (10:23 +0000)]
Various simplifications of the code:
+ use a wrapper around ast_carefulwrite(), used in two places,
  to make life easier when we decide to use a different interface
  to the socket.

+ put an ast_verbose() message on astman_append on a case that
  should never happen now that we use a temporary file for
  AMI-over-HTTP sessions

+ document and slightly simplify process_events() by removing
  unnecessary parentheses.

+ in get_input(), use ast_wait_for_input() instead of poll().

  We may want to move to a completely non-blocking

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48080 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoMore informative message on invalid commands.
Luigi Rizzo [Tue, 28 Nov 2006 09:43:44 +0000 (09:43 +0000)]
More informative message on invalid commands.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48079 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoanother normalization of AMI vs HTTP identification.
Luigi Rizzo [Tue, 28 Nov 2006 09:39:16 +0000 (09:39 +0000)]
another normalization of AMI vs HTTP identification.
Should really define a macro IS_AMI(s) so it is clear what
we want to do.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48078 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoalways use managerid to determine whether this is an AMI or HTTP session,
Luigi Rizzo [Tue, 28 Nov 2006 09:27:37 +0000 (09:27 +0000)]
always use managerid to determine whether this is an AMI or HTTP session,
and document it.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48077 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoIn the previous commit i forgot to set the poll_timeout to -1,
Luigi Rizzo [Tue, 28 Nov 2006 00:02:42 +0000 (00:02 +0000)]
In the previous commit i forgot to set the poll_timeout to -1,
causing the http threads to do busy waiting around the socket...

Fix the mistake, sorry for the inconvenience!

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48074 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agodocument the support for running a server on TCP/TLS and
Luigi Rizzo [Mon, 27 Nov 2006 21:25:55 +0000 (21:25 +0000)]
document the support for running a server on TCP/TLS and
opening an SSL socket.

We are almost ready to make this code available to other modules.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48073 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoadd a new http.conf option, sslbindaddr.
Luigi Rizzo [Mon, 27 Nov 2006 20:21:40 +0000 (20:21 +0000)]
add a new http.conf option, sslbindaddr.
Because https is more secure than http, it usually
makes sense to keep this service more open than the
one on the unencrypted port.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48071 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoin the helper thread, separate the FILE * creation from the actual
Luigi Rizzo [Mon, 27 Nov 2006 19:19:48 +0000 (19:19 +0000)]
in the helper thread, separate the FILE * creation from the actual
function doing work on the socket. This is another generalization
to provide a generic mechanism to open TCP/TLS socket with a thread
managing the accpet and children threads managing the individual
sessions.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48067 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agostaticize a global variable and remove an unused field structure.
Luigi Rizzo [Mon, 27 Nov 2006 18:51:10 +0000 (18:51 +0000)]
staticize a global variable and remove an unused field structure.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48062 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoMerged revisions 48054 via svnmerge from
Joshua Colp [Mon, 27 Nov 2006 18:10:59 +0000 (18:10 +0000)]
Merged revisions 48054 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
r48054 | file | 2006-11-27 13:06:50 -0500 (Mon, 27 Nov 2006) | 10 lines

Merged revisions 48053 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r48053 | file | 2006-11-27 13:03:57 -0500 (Mon, 27 Nov 2006) | 2 lines

Use the proper function to get the new message count instead of always using the filesystem. (issue #8421 reported by slimey)

........

................

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48056 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoMerged revisions 48049 via svnmerge from
Tilghman Lesher [Mon, 27 Nov 2006 17:31:56 +0000 (17:31 +0000)]
Merged revisions 48049 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
r48049 | tilghman | 2006-11-27 11:20:37 -0600 (Mon, 27 Nov 2006) | 10 lines

Merged revisions 48045 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r48045 | tilghman | 2006-11-27 11:15:54 -0600 (Mon, 27 Nov 2006) | 2 lines

Random MOH wasn't really random (bug 8381)

........

................

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48050 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoBlocked revisions 48046 via svnmerge
Russell Bryant [Mon, 27 Nov 2006 17:19:47 +0000 (17:19 +0000)]
Blocked revisions 48046 via svnmerge

........
r48046 | russell | 2006-11-27 12:17:40 -0500 (Mon, 27 Nov 2006) | 2 lines

Remove a couple of unused variables (issue #8380, casper)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48048 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoMore fixes for referencing a structure after it has been freed. (issue #8425 reported...
Joshua Colp [Mon, 27 Nov 2006 15:48:57 +0000 (15:48 +0000)]
More fixes for referencing a structure after it has been freed. (issue #8425 reported by arkadia)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48040 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoMerged revisions 48038 via svnmerge from
Joshua Colp [Mon, 27 Nov 2006 15:33:56 +0000 (15:33 +0000)]
Merged revisions 48038 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
r48038 | file | 2006-11-27 10:32:19 -0500 (Mon, 27 Nov 2006) | 10 lines

Merged revisions 48037 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r48037 | file | 2006-11-27 10:30:37 -0500 (Mon, 27 Nov 2006) | 2 lines

Do not reference the freed outgoing structure in the debug message. (issue #8425 reported by arkadia)

........

................

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48039 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoremove an extra comma in an initializer
Luigi Rizzo [Mon, 27 Nov 2006 14:47:15 +0000 (14:47 +0000)]
remove an extra comma in an initializer

Detected by: AST_DEVMODE=yes

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48034 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoDoxygen updates
Olle Johansson [Mon, 27 Nov 2006 06:59:20 +0000 (06:59 +0000)]
Doxygen updates

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48033 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoChange error message (imported from 1.4)
Olle Johansson [Mon, 27 Nov 2006 06:44:40 +0000 (06:44 +0000)]
Change error message (imported from 1.4)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48032 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years ago- Add some comments on thread storage with a brief explanation of what it is
Russell Bryant [Sun, 26 Nov 2006 06:55:33 +0000 (06:55 +0000)]
- Add some comments on thread storage with a brief explanation of what it is
  as well as what the motivation is for using it.
- Add a comment by the declaration of ast_inet_ntoa() noting that this function
  is not reentrant, and the result of a previous call to the function is no
  longer valid after calling it again.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48019 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoMerged revisions 48017 via svnmerge from
Steve Murphy [Sun, 26 Nov 2006 00:31:13 +0000 (00:31 +0000)]
Merged revisions 48017 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r48017 | murf | 2006-11-25 17:26:16 -0700 (Sat, 25 Nov 2006) | 1 line

might as well also document the raw values of the flag vars
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48018 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoMerged revisions 48015 via svnmerge from
Steve Murphy [Sun, 26 Nov 2006 00:15:42 +0000 (00:15 +0000)]
Merged revisions 48015 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r48015 | murf | 2006-11-25 17:01:34 -0700 (Sat, 25 Nov 2006) | 1 line

A little bit of func_cdr documentation upgrade-- no bug# involved, although 8221 may have inspired it.
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48016 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoLittle fix so we use the right message
Matthew Fredrickson [Sat, 25 Nov 2006 21:50:42 +0000 (21:50 +0000)]
Little fix so we use the right message

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48014 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoMake compiler happier
Matthew Fredrickson [Sat, 25 Nov 2006 21:46:58 +0000 (21:46 +0000)]
Make compiler happier

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48013 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agobug fix
Matthew Fredrickson [Sat, 25 Nov 2006 21:35:23 +0000 (21:35 +0000)]
bug fix

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48012 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoMake sure we don't send a group reset on a group larger than 32 CICs
Matthew Fredrickson [Sat, 25 Nov 2006 21:32:33 +0000 (21:32 +0000)]
Make sure we don't send a group reset on a group larger than 32 CICs

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48011 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoAdd ss7 show linkset command
Matthew Fredrickson [Sat, 25 Nov 2006 20:54:38 +0000 (20:54 +0000)]
Add ss7 show linkset command

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48010 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoUpdates to show linkset command
Matthew Fredrickson [Sat, 25 Nov 2006 20:30:04 +0000 (20:30 +0000)]
Updates to show linkset command

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48009 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agogeneralize a bit the functions used to create an tcp socket
Luigi Rizzo [Sat, 25 Nov 2006 17:37:04 +0000 (17:37 +0000)]
generalize a bit the functions used to create an tcp socket
and then run a service on it.
The code in manager.c does essentially the same things,
so we will be able to reuse the code in here (probably
moving it to netsock.c or another appropriate library file).

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48008 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoChanging ERROR to lesser level. Imported from 1.2/1.4
Olle Johansson [Sat, 25 Nov 2006 09:48:30 +0000 (09:48 +0000)]
Changing ERROR to lesser level. Imported from 1.2/1.4

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48004 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years ago- Adding comment on suspicious memory allocation. Seems like it's never freed, but...
Olle Johansson [Sat, 25 Nov 2006 09:45:57 +0000 (09:45 +0000)]
- Adding comment on suspicious memory allocation. Seems like it's never freed, but I don't
  have a clear understanding of the frame allocation/deallocation, so I just mark this
  for investigation. (Reported by Ed Guy). We're trying to see if a free() hurts...

- Doxygen comments on p2p rtp bridge stuff.  I am a bit worried about shortcutting
  rtcp this way, but will need feedback from rtcp gurus. This should work for
  video calls too, and possibly UDPTL.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48003 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoset pointers to NULL after freeing memory to avoid multiple free()
Luigi Rizzo [Sat, 25 Nov 2006 09:02:42 +0000 (09:02 +0000)]
set pointers to NULL after freeing memory to avoid multiple free()

probably 1.4/1.2 issue as well if someone can look into that.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@48001 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoremoved the svnmerge-integrated property from trunk; it's confusing svnmerge in newly...
Steve Murphy [Fri, 24 Nov 2006 18:17:25 +0000 (18:17 +0000)]
removed the svnmerge-integrated property from trunk; it's confusing svnmerge in newly created branches

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47997 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoThis fix inspired by a patch supplied in bug 8189, which points out problems with...
Steve Murphy [Fri, 24 Nov 2006 17:40:49 +0000 (17:40 +0000)]
This fix inspired by a patch supplied in bug 8189, which points out problems with the PLC code

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47995 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoDoxygen update
Olle Johansson [Fri, 24 Nov 2006 14:00:19 +0000 (14:00 +0000)]
Doxygen update
- Document cause codes
- Document a bit more on channel variables - global, predefined and local
- Fix some doxygen in channel.h. Adding one comment for two definitions does not
  work. They won't be copied to each.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47986 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoRemove unused memory allocation
Olle Johansson [Thu, 23 Nov 2006 11:04:25 +0000 (11:04 +0000)]
Remove unused memory allocation

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47960 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoDocument new configuration option.
Olle Johansson [Thu, 23 Nov 2006 10:46:09 +0000 (10:46 +0000)]
Document new configuration option.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47957 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoMerged revisions 47944 via svnmerge from
Joshua Colp [Wed, 22 Nov 2006 21:49:11 +0000 (21:49 +0000)]
Merged revisions 47944 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r47944 | file | 2006-11-22 16:47:43 -0500 (Wed, 22 Nov 2006) | 2 lines

Video will never reach Packet2Packet bridging and can do more harm then good.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47945 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoClarify a bit more.
Joshua Colp [Wed, 22 Nov 2006 17:47:14 +0000 (17:47 +0000)]
Clarify a bit more.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47935 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoNeed to update the CHANGES file as well for the maxfiles option.
Joshua Colp [Wed, 22 Nov 2006 17:43:36 +0000 (17:43 +0000)]
Need to update the CHANGES file as well for the maxfiles option.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47934 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoAdd support to set the maximum number of files open when Asterisk loads using the...
Joshua Colp [Wed, 22 Nov 2006 17:41:07 +0000 (17:41 +0000)]
Add support to set the maximum number of files open when Asterisk loads using the 'maxfiles' configuration option. (issue #7499 reported by rkarlsba)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47933 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoDon't over-deprecate... :-)
Olle Johansson [Wed, 22 Nov 2006 11:28:12 +0000 (11:28 +0000)]
Don't over-deprecate... :-)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47923 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoRestore some sense of security to manager
Mark Spencer [Wed, 22 Nov 2006 05:49:06 +0000 (05:49 +0000)]
Restore some sense of security to manager

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47912 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoMerged revisions 47897 via svnmerge from
Joshua Colp [Tue, 21 Nov 2006 17:34:22 +0000 (17:34 +0000)]
Merged revisions 47897 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r47897 | file | 2006-11-21 12:32:27 -0500 (Tue, 21 Nov 2006) | 2 lines

If we have the non standard G726-32 setting turned on we want to return G726-32 to the SDP, not our AAL2 string. (issue #8330 reported by voipgate)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47898 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoTreat 101 as 100, not 183 session progress
Olle Johansson [Tue, 21 Nov 2006 15:25:38 +0000 (15:25 +0000)]
Treat 101 as 100, not 183 session progress

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47893 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agobetter fix for the previous bug.
Luigi Rizzo [Tue, 21 Nov 2006 11:53:06 +0000 (11:53 +0000)]
better fix for the previous bug.

In general this code needs a deep revision, because the body of
do_forward() deletes/overwrites the output channel without freeing
the resouce in some cases, and without notifying the caller.

Also, on FreeBSD with MALLOC_OPTIONS set i am seeing various panics
(duplicate freee etc.)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47881 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agodo not ast_hangup() on a NULL channel.
Luigi Rizzo [Tue, 21 Nov 2006 11:07:30 +0000 (11:07 +0000)]
do not ast_hangup() on a NULL channel.
In the original code this would happen in the case of
o->forwards >=  AST_MAX_FORWARDS

Likely an 1.2/1.4 isse as well - please someone have a look,
while I am hunting a few more similar panics now.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47880 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoMerged revisions 47864-47865 via svnmerge from
Tilghman Lesher [Mon, 20 Nov 2006 20:04:11 +0000 (20:04 +0000)]
Merged revisions 47864-47865 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r47864 | tilghman | 2006-11-20 14:01:58 -0600 (Mon, 20 Nov 2006) | 2 lines

Oops, merge missed release of odbc object

........
........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47866 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoMerged revisions 47860 via svnmerge from
Joshua Colp [Mon, 20 Nov 2006 19:52:38 +0000 (19:52 +0000)]
Merged revisions 47860 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
r47860 | file | 2006-11-20 14:51:36 -0500 (Mon, 20 Nov 2006) | 10 lines

Merged revisions 47859 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r47859 | file | 2006-11-20 14:50:21 -0500 (Mon, 20 Nov 2006) | 2 lines

Don't forget to byte swap if we are exiting the smoother feed early. (issue #8287 reported by arturs)

........

................

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47861 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoBlocked revisions 47856 via svnmerge
Joshua Colp [Mon, 20 Nov 2006 16:19:13 +0000 (16:19 +0000)]
Blocked revisions 47856 via svnmerge

................
r47856 | file | 2006-11-20 11:17:47 -0500 (Mon, 20 Nov 2006) | 9 lines

Blocked revisions 47855 via svnmerge

........
r47855 | file | 2006-11-20 11:16:22 -0500 (Mon, 20 Nov 2006) | 2 lines

Free history items at the end of use of the temporary SIP pvt structure. (issue #8383 reported by benh)

........

................

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47857 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoUse RTP/RTCP fds on the RTP structure, don't bother storing them.
Joshua Colp [Mon, 20 Nov 2006 16:06:10 +0000 (16:06 +0000)]
Use RTP/RTCP fds on the RTP structure, don't bother storing them.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47854 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoMerged revisions 47852 via svnmerge from
Joshua Colp [Mon, 20 Nov 2006 16:04:14 +0000 (16:04 +0000)]
Merged revisions 47852 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r47852 | file | 2006-11-20 10:58:50 -0500 (Mon, 20 Nov 2006) | 2 lines

Only remove/destroy the RTCP I/O item if it exists.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47853 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoMerged revisions 47850 via svnmerge from
Joshua Colp [Mon, 20 Nov 2006 15:55:58 +0000 (15:55 +0000)]
Merged revisions 47850 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r47850 | file | 2006-11-20 10:51:37 -0500 (Mon, 20 Nov 2006) | 2 lines

Use a separate variable in the channel structure to store the context that the channel was dialed from. (issue #8382 reported by jiddings)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47851 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoErased the svnmerge-integrated prop from trunk. Please, in your svnmerge-ings, don...
Steve Murphy [Mon, 20 Nov 2006 14:08:04 +0000 (14:08 +0000)]
Erased the svnmerge-integrated prop from trunk. Please, in your svnmerge-ings, don't let these props leak into the trunk or branches.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47847 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoUpdate docs for videosupport
Olle Johansson [Mon, 20 Nov 2006 11:46:45 +0000 (11:46 +0000)]
Update docs for videosupport

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47846 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoProperly reset schedule items (rizzo)
Olle Johansson [Mon, 20 Nov 2006 11:36:45 +0000 (11:36 +0000)]
Properly reset schedule items (rizzo)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47844 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoAdded a few words to explain the change to AEL concerning Gosub()
Steve Murphy [Sun, 19 Nov 2006 04:22:33 +0000 (04:22 +0000)]
Added a few words to explain the change to AEL concerning Gosub()

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47836 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoAdded a few words of explanation about macros
Steve Murphy [Sun, 19 Nov 2006 04:12:39 +0000 (04:12 +0000)]
Added a few words of explanation about macros

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47835 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agocomments-only change:
Luigi Rizzo [Sat, 18 Nov 2006 22:14:20 +0000 (22:14 +0000)]
comments-only change:
document a bit more when manager events are delivered
to the clients.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47834 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoESS-ification.
Luigi Rizzo [Sat, 18 Nov 2006 20:17:06 +0000 (20:17 +0000)]
ESS-ification.

no need to bring this in 1.4, it is just code cleanup

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47829 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoMove this macro from cli.c to cli.h so apps can use it
Luigi Rizzo [Sat, 18 Nov 2006 20:08:17 +0000 (20:08 +0000)]
Move this macro from cli.c to cli.h so apps can use it
without duplicating the macro or the code:

/*!
 * In many cases we need to print singular or plural
 * words depending on a count. This macro helps us e.g.
 *     printf("we have %d object%s", n, ESS(n));
 */
#define ESS(x) ((x) == 1 ? "" : "s")

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47827 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoMerged revisions 47823 via svnmerge from
Luigi Rizzo [Sat, 18 Nov 2006 18:03:42 +0000 (18:03 +0000)]
Merged revisions 47823 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r47823 | rizzo | 2006-11-18 18:59:35 +0100 (Sat, 18 Nov 2006) | 5 lines

fix bug 7450 - Parsing fails if From header contains angle brackets
(the bug was only in a corner case where the < was right after the
opening quote, and the fix is trivial).

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47824 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoprevent the sound thread from consuming all the available CPU
Luigi Rizzo [Sat, 18 Nov 2006 08:19:41 +0000 (08:19 +0000)]
prevent the sound thread from consuming all the available CPU
doing busy-wait on the output audio device.
As it is set now, it tries to push a frame every 10ms,
which is still too frequent but avoids deep restructuring
of the code (which i should do, though).

Note, this is only for ring tones, regular audio coming
from the network is still delivered as soon as it is
available.

Eventually this could well end up in the 1.4 branch, but
since i am probably the only user of chan_oss there isn't
much urgency to do that.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47822 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoThis update fulfils the request of bug 7109, which claimed the language arg to ast_st...
Steve Murphy [Fri, 17 Nov 2006 23:18:51 +0000 (23:18 +0000)]
This update fulfils the request of bug 7109, which claimed the language arg to ast_stream_and_wait() was redundant. Almost all calls just used chan->language, and seeing how chan is the first argument, this certainly seems redundant. A change of language could just as easily be done by simply changing the channel language before calling.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47821 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoremove a debugging message
Luigi Rizzo [Fri, 17 Nov 2006 22:56:58 +0000 (22:56 +0000)]
remove a debugging message

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47818 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoconvert "help" to new style,
Luigi Rizzo [Fri, 17 Nov 2006 22:53:57 +0000 (22:53 +0000)]
convert "help" to new style,
fix completion of arguments past the first one
that i broke earlier today.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47817 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agostandardize "module show [like]"
Luigi Rizzo [Fri, 17 Nov 2006 22:02:15 +0000 (22:02 +0000)]
standardize "module show [like]"

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47815 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoAdd ability to notify an external application/script that the voicemail password...
Jason Parker [Fri, 17 Nov 2006 21:51:42 +0000 (21:51 +0000)]
Add ability to notify an external application/script that the voicemail password was,
while also still changing the password "internally".

Issue 7371, initial patch by pdunkel, with rewrite/config comments by me.
Additional modifications (yay bitmask) by pdunkel.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47814 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agodescribe a bit the patterns that you can have in the commands,
Luigi Rizzo [Fri, 17 Nov 2006 21:50:55 +0000 (21:50 +0000)]
describe a bit the patterns that you can have in the commands,
and add support for wildcard (spelled as '%').

On passing fix a bug in the expansion code which was hidden and
appeared when implementing the wildcard
The fix is just the line 'src != argindex', in case someone wants
to test this on 1.4 - but i would just keep this in trunk.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47813 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoAdd ability to add custom queue log via manager interface.
Jason Parker [Fri, 17 Nov 2006 20:46:36 +0000 (20:46 +0000)]
Add ability to add custom queue log via manager interface.

Issue 7806, patch by alexrch, with slight modifications by me.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47806 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoAdd some sense of link state. Don't make calls if link is down. Only reset if we...
Matthew Fredrickson [Fri, 17 Nov 2006 18:26:33 +0000 (18:26 +0000)]
Add some sense of link state.  Don't make calls if link is down.  Only reset if we're bringing the
link up for the first time.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47801 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agomerge the implemenmtation of "core set debug" and "core set verbose".
Luigi Rizzo [Fri, 17 Nov 2006 12:26:15 +0000 (12:26 +0000)]
merge the implemenmtation of "core set debug" and "core set verbose".
No externally visible changes.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47790 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoremove an unused function
Luigi Rizzo [Fri, 17 Nov 2006 11:31:55 +0000 (11:31 +0000)]
remove an unused function

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47789 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agouse the regexp cli support on some of the command
Luigi Rizzo [Fri, 17 Nov 2006 11:15:54 +0000 (11:15 +0000)]
use the regexp cli support on some of the command

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47788 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agointroduce a bit of regexp support in the internal CLI api.
Luigi Rizzo [Fri, 17 Nov 2006 11:12:13 +0000 (11:12 +0000)]
introduce a bit of regexp support in the internal CLI api.
Now you can specify a cli command as
"console autoanswer [on|off]"

which means the on|off argument is optional, or

"console {mute|unmute}"

which means the mute|unmute argument is mandatory.

The blocks in [] or {} do not necessarily need to be at the
end of the string.

Completions for the variant parts are generated automatically.
This should significantly simplify the implementation of
the various handlers.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47787 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoMake sure we choose the last channel as the dchannel if it's not E1 (for BRI). ...
Matthew Fredrickson [Fri, 17 Nov 2006 01:05:28 +0000 (01:05 +0000)]
Make sure we choose the last channel as the dchannel if it's not E1 (for BRI).  (#8077) Thanks Tzafrir.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47784 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoMerged revisions 47782 via svnmerge from
Jason Parker [Thu, 16 Nov 2006 23:20:52 +0000 (23:20 +0000)]
Merged revisions 47782 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r47782 | qwell | 2006-11-16 17:19:46 -0600 (Thu, 16 Nov 2006) | 2 lines

Fix a couple of typos.  Initially pointed out by mrobinson.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47783 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoconvert two entries to new style
Luigi Rizzo [Thu, 16 Nov 2006 23:05:50 +0000 (23:05 +0000)]
convert two entries to new style

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47779 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoMerged revisions 47777 via svnmerge from
Kevin P. Fleming [Thu, 16 Nov 2006 23:00:51 +0000 (23:00 +0000)]
Merged revisions 47777 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
r47777 | kpfleming | 2006-11-16 17:00:10 -0600 (Thu, 16 Nov 2006) | 12 lines

update documentation regarding IAX2 transfers and CDRs

Merged revisions 47776 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r47776 | kpfleming | 2006-11-16 16:57:31 -0600 (Thu, 16 Nov 2006) | 2 lines

update clearly wrong documentation regarding cdr_custom

........

................

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47778 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoRemove the interim variable for range modifications, and set it on the structure...
Jason Parker [Thu, 16 Nov 2006 22:51:00 +0000 (22:51 +0000)]
Remove the interim variable for range modifications, and set it on the structure directly.
Also move the default checking to where it gets set initially.

Fixes suggested by file.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47775 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoconvert some handlers to new style.
Luigi Rizzo [Thu, 16 Nov 2006 22:44:29 +0000 (22:44 +0000)]
convert some handlers to new style.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47772 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoAdd ability to modify range for dring matching.
Jason Parker [Thu, 16 Nov 2006 22:32:23 +0000 (22:32 +0000)]
Add ability to modify range for dring matching.

Issue #8369, patch by ssuehring, modified slightly by me.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47771 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agofix indentation
Luigi Rizzo [Thu, 16 Nov 2006 22:03:27 +0000 (22:03 +0000)]
fix indentation

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47770 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoremove an unused function
Luigi Rizzo [Thu, 16 Nov 2006 21:57:23 +0000 (21:57 +0000)]
remove an unused function

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47769 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoMerged revisions 47764 via svnmerge from
Joshua Colp [Thu, 16 Nov 2006 21:13:17 +0000 (21:13 +0000)]
Merged revisions 47764 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r47764 | file | 2006-11-16 16:11:06 -0500 (Thu, 16 Nov 2006) | 2 lines

Compare technology using the pointers instead of a straight comparison based on name. (issue #8228 reported by dean bath)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47765 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoBlocked revisions 47762 via svnmerge
Joshua Colp [Thu, 16 Nov 2006 20:32:17 +0000 (20:32 +0000)]
Blocked revisions 47762 via svnmerge

................
r47762 | file | 2006-11-16 15:30:54 -0500 (Thu, 16 Nov 2006) | 9 lines

Blocked revisions 47761 via svnmerge

........
r47761 | file | 2006-11-16 15:29:28 -0500 (Thu, 16 Nov 2006) | 2 lines

Look for the header file specifically in all cases, not just the existence of the directory. (issue #8358 reported by mrness)

........

................

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47763 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoMerged revisions 47758 via svnmerge from
Kevin P. Fleming [Thu, 16 Nov 2006 20:10:59 +0000 (20:10 +0000)]
Merged revisions 47758 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r47758 | kpfleming | 2006-11-16 14:09:10 -0600 (Thu, 16 Nov 2006) | 2 lines

check for pre-1.4 versions of Zaptel and abort the configure script if found with an appropriate error message

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47759 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoMake it possible to enable/disable onhold tracking, in order to make life easier
Olle Johansson [Thu, 16 Nov 2006 19:29:28 +0000 (19:29 +0000)]
Make it possible to enable/disable onhold tracking, in order to make life easier
for realtime users.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47756 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoMerged revisions 47751 via svnmerge from
Joshua Colp [Thu, 16 Nov 2006 18:32:27 +0000 (18:32 +0000)]
Merged revisions 47751 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
r47751 | file | 2006-11-16 13:29:12 -0500 (Thu, 16 Nov 2006) | 10 lines

Merged revisions 47750 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r47750 | file | 2006-11-16 13:26:50 -0500 (Thu, 16 Nov 2006) | 2 lines

Because of the way chan_local is written we should be extra careful and make sure our callback functions have a tech_pvt. (issue #8275 reported by mflorell)

........

................

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47752 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoMerged revisions 47748 via svnmerge from
Joshua Colp [Thu, 16 Nov 2006 17:53:58 +0000 (17:53 +0000)]
Merged revisions 47748 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r47748 | file | 2006-11-16 12:52:48 -0500 (Thu, 16 Nov 2006) | 2 lines

Don't unreference the SLA object if there is no SLA object in the devicestate callback. (issue #8354 reported by loloski)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47749 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoBe gone 1.2 props!
Joshua Colp [Thu, 16 Nov 2006 17:17:16 +0000 (17:17 +0000)]
Be gone 1.2 props!

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47747 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoMerging a fix that was already fixed.
Olle Johansson [Thu, 16 Nov 2006 17:15:42 +0000 (17:15 +0000)]
Merging a fix that was already fixed.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47746 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoMerging implementation of invite states from my "invitestate" branch for 1.2. This...
Olle Johansson [Thu, 16 Nov 2006 16:02:41 +0000 (16:02 +0000)]
Merging implementation of invite states from my "invitestate" branch for 1.2. This is a bit more
clean platform for the handling of BYE/CANCEL than what we had. It might also need to changes
in other parts of the code, since we know the state of the INVITE transaction.

Please observe that this is is not dialog states at all, this is INVITE transaction states.

Hello Michael Proctor, and thank you! :-)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47740 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoBlock upgrade to UPGRADE
Olle Johansson [Thu, 16 Nov 2006 15:22:24 +0000 (15:22 +0000)]
Block upgrade to UPGRADE

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47737 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years ago- CANCEL never uses authentication
Olle Johansson [Thu, 16 Nov 2006 15:12:30 +0000 (15:12 +0000)]
- CANCEL never uses authentication
- Add docs on canreinvite

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47734 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoreduce indentation on a large function.
Luigi Rizzo [Thu, 16 Nov 2006 14:58:24 +0000 (14:58 +0000)]
reduce indentation on a large function.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47732 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agouse atomic instructions to update the inuse counters
Luigi Rizzo [Thu, 16 Nov 2006 14:41:28 +0000 (14:41 +0000)]
use atomic instructions to update the inuse counters
for CLI entriesC. The lock is not protecting this field.

I wonder if the field should be declared 'volatile' as well.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47731 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agomake kevin (and 64 bit machines) happy and
Luigi Rizzo [Thu, 16 Nov 2006 14:21:30 +0000 (14:21 +0000)]
make kevin (and 64 bit machines) happy and
remove a cast from char* to int in handling the return
values from new-style handlers.

On passing, note that main/loader.c::ast_load_resource() always return 0
so errors are not propagated up. I am not sure this is the intended
behaviour.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@47727 65c4cc65-6c06-0410-ace0-fbb531ad65f3