5 years agoMerge " Update with realtime fixes."
Joshua Colp [Fri, 29 Jul 2016 00:18:06 +0000 (19:18 -0500)]
Merge " Update with realtime fixes."

5 years agoMerge "dsp.c: Add fax and DTMF detection unit tests."
Joshua Colp [Thu, 28 Jul 2016 22:35:13 +0000 (17:35 -0500)]
Merge "dsp.c: Add fax and DTMF detection unit tests."

5 years agoMerge "dsp.c: Added descriptive comments to Goertzel calculations."
Joshua Colp [Thu, 28 Jul 2016 22:35:09 +0000 (17:35 -0500)]
Merge "dsp.c: Added descriptive comments to Goertzel calculations."

5 years agoMerge "dsp.c: Fix incorrect format reference typo."
Joshua Colp [Thu, 28 Jul 2016 22:35:05 +0000 (17:35 -0500)]
Merge "dsp.c: Fix incorrect format reference typo."

5 years agoMerge "dsp.c: Correct DTMF twist dsp.conf documentation."
Joshua Colp [Thu, 28 Jul 2016 22:35:01 +0000 (17:35 -0500)]
Merge "dsp.c: Correct DTMF twist dsp.conf documentation."

5 years agoMerge "rtp_engine: Failed assertion and wrong name given for codec"
zuul [Thu, 28 Jul 2016 20:46:36 +0000 (15:46 -0500)]
Merge "rtp_engine: Failed assertion and wrong name given for codec"

5 years agoMerge "Portably sscanf tv_usec"
Joshua Colp [Thu, 28 Jul 2016 16:38:57 +0000 (11:38 -0500)]
Merge "Portably sscanf tv_usec"

5 years agoPortably sscanf tv_usec
David M. Lee [Wed, 27 Jul 2016 15:33:23 +0000 (10:33 -0500)]
Portably sscanf tv_usec

In a timeval, tv_usec is defined as a suseconds_t, which could be
different underlying types on different platforms. Instead of trying to
scanf directly into the timeval, scanf into a long int, then copy that
into the timeval.

Change-Id: I29f22d049d3f7746b6c0cc23fbf4293bdaa5eb95

5 years agortp_engine: Failed assertion and wrong name given for codec
Kevin Harwell [Wed, 27 Jul 2016 17:36:22 +0000 (12:36 -0500)]
rtp_engine: Failed assertion and wrong name given for codec

Fixed an assert check that would trigger when the passed in value was negative.
The negative value was being cast to an unsigned value. This resulted in the
check failing.

Also fixed another problem when loading formats in the engine. When setting the
mime type the format's name was being passed in instead of the codec's name.

Change-Id: I1a201cd419ba4d8e9a40d337e36b6fbe1737192c

5 years agoReplace strdupa with more portable ast_strdupa
David M. Lee [Wed, 27 Jul 2016 14:56:29 +0000 (09:56 -0500)]
Replace strdupa with more portable ast_strdupa

The strdupa function is a GNU extension, and not widely portable. We
have an ast_strdupa function used within Asterisk which is preferred.
I pulled the definition up from menuselect.c into the menuselect.h
header file so it can be shared across menuselect.

Change-Id: I9593c97f78386b47dc1e83201e80cb2f62b36c2e

5 years agodsp.c: Add fax and DTMF detection unit tests.
Richard Mudgett [Fri, 22 Jul 2016 03:44:55 +0000 (22:44 -0500)]
dsp.c: Add fax and DTMF detection unit tests.

* Add fax amplitude and frequency sweep tests.
* Add DTMF amplitude and twist unit tests.

Change-Id: I8d77c9a1eec89e440d715f998c928687e870c3f7

5 years agodsp.c: Added descriptive comments to Goertzel calculations.
Richard Mudgett [Thu, 21 Jul 2016 16:56:53 +0000 (11:56 -0500)]
dsp.c: Added descriptive comments to Goertzel calculations.

* Added doxygen to describe some struct members and what is going on in
the code.

Change-Id: I2ec706a33b52aee42b16dcc356c2bd916a45190d

5 years agodsp.c: Fix incorrect format reference typo.
Richard Mudgett [Wed, 13 Jul 2016 18:48:25 +0000 (13:48 -0500)]
dsp.c: Fix incorrect format reference typo.

Change-Id: Ia131da3ec29acf385cb43a586a29ecc975eb3896

5 years agodsp.c: Correct DTMF twist dsp.conf documentation.
Richard Mudgett [Tue, 26 Jul 2016 02:18:21 +0000 (21:18 -0500)]
dsp.c: Correct DTMF twist dsp.conf documentation.

Change-Id: Idf97e3a72f1edc5fca58f2fa7b20785922be0cae

5 years Update with realtime fixes.
Joshua Colp [Fri, 22 Jul 2016 09:43:20 +0000 (06:43 -0300)] Update with realtime fixes.

When configuring SIP URIs in the pjsip.conf file it is
necessary to escape the semicolon so the parser does not
treat it as a comment. This change allows this to work in
the astconfigparser implementation.

A secondary bug where some data was lost if a configuration
option included a "=" in its value was also fixed.

A bug where sections would be considered equal despite
being different has also been fixed.

Change-Id: If229f656ef22050b50e7b34e90c4bffe796431f8

5 years agodsp.c: Fix erroneous fax tone detection.
Richard Mudgett [Fri, 22 Jul 2016 03:28:25 +0000 (22:28 -0500)]
dsp.c: Fix erroneous fax tone detection.

The Goertzel calculations get less accurate the lower the signal level
being worked with becomes because there is less resolution remaining.
If it is too low we can erroneously detect a tone where none really
exists.  The searched for fax frequencies not only need to be so much
stronger than the background noise they must also be a minimum strength.

* Add needed minimum threshold test to tone_detect().

* Set TONE_THRESHOLD to allow low volume frequency spread detection.

ASTERISK-26237 #close
Reported by: Richard Mudgett

Change-Id: I84dbba7f7628fa13720add6a88eae3b129e066fc

5 years agoMerge "codecs: Add iLBC 20."
zuul [Tue, 26 Jul 2016 15:52:35 +0000 (10:52 -0500)]
Merge "codecs: Add iLBC 20."

5 years agoMerge "menuselect: Various menuselect enhancements"
Joshua Colp [Tue, 26 Jul 2016 11:40:16 +0000 (06:40 -0500)]
Merge "menuselect:  Various menuselect enhancements"

5 years agoMerge "asterisk.c: Add auto generation and persistence of UUID"
zuul [Tue, 26 Jul 2016 02:14:12 +0000 (21:14 -0500)]
Merge "asterisk.c:  Add auto generation and persistence of UUID"

5 years agoMerge "pbx.c: Remove duplicate code."
zuul [Tue, 26 Jul 2016 00:47:30 +0000 (19:47 -0500)]
Merge "pbx.c: Remove duplicate code."

5 years agomenuselect: Various menuselect enhancements
George Joseph [Sun, 24 Jul 2016 23:27:26 +0000 (17:27 -0600)]
menuselect:  Various menuselect enhancements

* Add 'external' as a support level.
* Add ability for module directories to add entries to the menu
  by adding members to the <module_prefix>/<module_prefix>.xml file.
* Expand the description field to 3 lines in the ncurses implementation.
* Allow the description field to wrap in the newt implementation.
* Add description field to the gtk implementation.

Change-Id: I7f9600a1984a42ce0696db574c1051bc9ad7c808

5 years agoari: Update version.
Joshua Colp [Sun, 24 Jul 2016 21:51:25 +0000 (18:51 -0300)]
ari: Update version.

New functionality has been added so the version has been
bumped to one over the 13 version.

Change-Id: I5d30077f62640c0ac83599b4e9a9b657bf184f69

5 years agoMerge "Fix sqlalchemy error regarding identifier length."
zuul [Sat, 23 Jul 2016 21:54:29 +0000 (16:54 -0500)]
Merge "Fix sqlalchemy error regarding identifier length."

5 years agoasterisk.c: Add auto generation and persistence of UUID
George Joseph [Sat, 23 Jul 2016 13:51:48 +0000 (07:51 -0600)]
asterisk.c:  Add auto generation and persistence of UUID

Upcoming features will require the generation and persistence
of a UUID.

Change-Id: I3ec0062427e133217db6ef496a4216f427c3b92d

5 years agoMerge "chan_sip: Enable Session-Timers for SIP over TCP (and TLS)."
zuul [Fri, 22 Jul 2016 21:55:15 +0000 (16:55 -0500)]
Merge "chan_sip: Enable Session-Timers for SIP over TCP (and TLS)."

5 years agoFix sqlalchemy error regarding identifier length.
Mark Michelson [Fri, 22 Jul 2016 19:44:50 +0000 (14:44 -0500)]
Fix sqlalchemy error regarding identifier length.

sqlalchemy was complaining:

sqlalchemy.exc.IdentifierError: Identifier
'ps_contacts_qualifyfreq_exptime' exceeds maximum length of 30

This fixes the problem by changing the index name to be
"ps_contacts_qualifyfreq_exp" instead.

ASTERISK-26227 #close
Reported by Mark Michelson

Change-Id: I0ed784f87504be2a59ee8d3242ef6f625d5ed1a9

5 years agoMerge "Create Asterisk-14: Update CHANGES and UPGRADE files"
zuul [Fri, 22 Jul 2016 12:48:39 +0000 (07:48 -0500)]
Merge "Create Asterisk-14:  Update CHANGES and UPGRADE files"

5 years agoMerge "res_pjsip: Whitespace and comment cleanup."
zuul [Fri, 22 Jul 2016 12:42:09 +0000 (07:42 -0500)]
Merge "res_pjsip: Whitespace and comment cleanup."

5 years agoMerge "res_pjsip_pubsub: fixed a bug when pjsip_tx_data_dec_ref is called twice."
Joshua Colp [Fri, 22 Jul 2016 09:51:12 +0000 (04:51 -0500)]
Merge "res_pjsip_pubsub: fixed a bug when pjsip_tx_data_dec_ref is called twice."

5 years agochan_sip: Enable Session-Timers for SIP over TCP (and TLS).
Alexander Traud [Tue, 19 Jul 2016 11:16:02 +0000 (13:16 +0200)]
chan_sip: Enable Session-Timers for SIP over TCP (and TLS).

Asterisk defaults to timers=accept/refresher=uas. In that scenario, only in that
scenario, Sessions-Timers (RFC 4028) had no effect via TCP. This change enables
Session-Timers for SIP over TCP (and for SIP over TLS).

However with longer international calls via TCP, the SIP channel might break,
because all hops on the Internet route must stay online (have not a single power
outage, for example). Therefore with Session-Timers enabled (which are enabled
at default), you might see dropped calls. Consequently even with this change,
you might be better-off going for session-timers=refuse in your sip.conf.

ASTERISK-19968 #close

Change-Id: I1cd33453c77c56c8e1394cd60a6f17bb61c1d957

5 years agocodecs: Add iLBC 20.
Alexander Traud [Tue, 19 Jul 2016 18:39:38 +0000 (20:39 +0200)]
codecs: Add iLBC 20.

Asterisk already supported iLBC 30. This change adds iLBC 20. Now, Asterisk
defaults to iLBC 20 but falls back to iLBC 30, when the remote party requests

ASTERISK-26218 #close
ASTERISK-26221 #close
Reported by: Aaron Meriwether

Change-Id: I07f523a3aa1338bb5217a1bf69c1eeb92adedffa

5 years agoMerge "chan_sip: Prevent deadlock when issuing "sip show channels""
zuul [Fri, 22 Jul 2016 05:33:47 +0000 (00:33 -0500)]
Merge "chan_sip: Prevent deadlock when issuing "sip show channels""

5 years agores_pjsip: Whitespace and comment cleanup.
Richard Mudgett [Fri, 15 Jul 2016 21:16:18 +0000 (16:16 -0500)]
res_pjsip: Whitespace and comment cleanup.

Change-Id: I11139a4a95df34e223ba622aa6227e33ab8f6c38

5 years agopbx.c: Remove duplicate code.
Corey Farrell [Fri, 22 Jul 2016 03:34:46 +0000 (23:34 -0400)]
pbx.c: Remove duplicate code.

Merge code found in both branches of a conditional in

The updated code initializes peer_table and peer_label_table of the
extension before linking it to the context.

Change-Id: Ic759e27cdc9906c6877df41d28ee9c5be8f41c20

5 years agoMerge "res_srtp: Enable AES-256 and AES-GCM."
zuul [Fri, 22 Jul 2016 02:11:07 +0000 (21:11 -0500)]
Merge "res_srtp: Enable AES-256 and AES-GCM."

5 years agoMerge "chan_dahdi.c: Fix deadlock potential in fax redirection."
zuul [Fri, 22 Jul 2016 01:47:33 +0000 (20:47 -0500)]
Merge "chan_dahdi.c: Fix deadlock potential in fax redirection."

5 years agoMerge "chan_sip.c: Fix deadlock potential in fax redirection."
zuul [Fri, 22 Jul 2016 01:36:30 +0000 (20:36 -0500)]
Merge "chan_sip.c: Fix deadlock potential in fax redirection."

5 years agoMerge "chan_pjsip.c: Fix deadlock potential in fax redirection."
zuul [Fri, 22 Jul 2016 01:34:44 +0000 (20:34 -0500)]
Merge "chan_pjsip.c: Fix deadlock potential in fax redirection."

5 years agoMerge "res_fax.c: Fix deadlock potential in FAXOPT(faxdetect) framehook."
zuul [Fri, 22 Jul 2016 00:58:55 +0000 (19:58 -0500)]
Merge "res_fax.c: Fix deadlock potential in FAXOPT(faxdetect) framehook."

5 years agoMerge "res_fax: Fix FAXOPT(faxdetect) timeout option."
Joshua Colp [Thu, 21 Jul 2016 23:25:55 +0000 (18:25 -0500)]
Merge "res_fax: Fix FAXOPT(faxdetect) timeout option."

5 years agoMerge "chan_dahdi: Add faxdetect_timeout option."
Joshua Colp [Thu, 21 Jul 2016 23:25:52 +0000 (18:25 -0500)]
Merge "chan_dahdi: Add faxdetect_timeout option."

5 years agoMerge "res_pjsip: Add fax_detect_timeout endpoint option."
Joshua Colp [Thu, 21 Jul 2016 23:25:47 +0000 (18:25 -0500)]
Merge "res_pjsip: Add fax_detect_timeout endpoint option."

5 years agoCreate Asterisk-14: Update CHANGES and UPGRADE files
George Joseph [Thu, 21 Jul 2016 21:35:39 +0000 (15:35 -0600)]
Create Asterisk-14:  Update CHANGES and UPGRADE files

Change-Id: I35b5f6657670cfa8985796fa1e1fe86ad299efdc

5 years agochan_sip: Prevent deadlock when issuing "sip show channels"
George Joseph [Thu, 21 Jul 2016 14:05:03 +0000 (08:05 -0600)]
chan_sip: Prevent deadlock when issuing "sip show channels"

sip_show_channels locks the dialogs container first then locks each
sip_pvt so it can spit out the details.  The rest of sip dialog
processing locks the sip_pvt first then locks the dialogs container
if it needs to.  Both lock in the order they need but deadlocks can
result.  To fix, sip_show_channels and sip_show_channelstats have
been converted to use an iterator rather than ao2_callback.  This way
the container is locked only while getting the next entry and is
unlocked when the callback is called.

ASTERISK-23013 #close

Change-Id: Id9980419909e811f89484950ed46ef117b9eb990

5 years agoMerge "pbx: Create pbx_sw.c for management of 'struct ast_sw'."
zuul [Thu, 21 Jul 2016 20:55:10 +0000 (15:55 -0500)]
Merge "pbx: Create pbx_sw.c for management of 'struct ast_sw'."

5 years agoMerge "Add conditional support for noreturn functions."
zuul [Thu, 21 Jul 2016 20:29:22 +0000 (15:29 -0500)]
Merge "Add conditional support for noreturn functions."

5 years agopbx: Create pbx_sw.c for management of 'struct ast_sw'.
Corey Farrell [Sat, 16 Jul 2016 00:28:16 +0000 (20:28 -0400)]
pbx: Create pbx_sw.c for management of 'struct ast_sw'.

This changes context switches from a linked list to a vector, makes
'struct ast_sw' opaque to pbx.c.

Although ast_walk_context_switches is maintained the procedure is no
longer efficient except for the first call (inc==NULL).  This
functionality is replaced by two new functions implemented by vector
* ast_context_switches_count (AST_VECTOR_SIZE)
* ast_context_switches_get (AST_VECTOR_GET)

As with ast_walk_context_switches callers of these functions are
expected to have locked contexts.  Only a few places in Asterisk walked
the switches, they have been converted to use the new functions.

Change-Id: I08deb016df22eee8288eb03de62593e45a1f0998

5 years agores_pjsip_pubsub: fixed a bug when pjsip_tx_data_dec_ref is called twice.
Alexei Gradinari [Thu, 21 Jul 2016 15:28:36 +0000 (11:28 -0400)]
res_pjsip_pubsub: fixed a bug when pjsip_tx_data_dec_ref is called twice.

This patch removed call of pjsip_tx_data_dec_ref in send_notify
if send_request failed.
The pjsip_dlg_send_request deletes the message on error by itself.

It seems this patch fixes next issues:

Change-Id: I8b05917c93d993f95d604c042ace5f1a5500f59a

5 years agores_srtp: Enable AES-256 and AES-GCM.
Alexander Traud [Wed, 13 Jul 2016 10:24:46 +0000 (12:24 +0200)]
res_srtp: Enable AES-256 and AES-GCM.

ASTERISK-26190 #close

Change-Id: I11326d80edd656524a51a19450e586c583aa0a0b

5 years agoMerge "Makefile: Retain XML Declaration and DTD in docs."
zuul [Wed, 20 Jul 2016 16:36:08 +0000 (11:36 -0500)]
Merge "Makefile: Retain XML Declaration and DTD in docs."

5 years agoMerge "Unit tests: Use AST_TEST_DEFINE in conditional code only."
zuul [Wed, 20 Jul 2016 16:31:52 +0000 (11:31 -0500)]
Merge "Unit tests: Use AST_TEST_DEFINE in conditional code only."

5 years agoMerge "pbx: Create pbx_ignorepat.c for management of 'struct ast_ignorepat'."
zuul [Wed, 20 Jul 2016 15:57:41 +0000 (10:57 -0500)]
Merge "pbx: Create pbx_ignorepat.c for management of 'struct ast_ignorepat'."

5 years agoMerge "res_rtp_asterisk: Count a roll-over of the sequence number even on lost packets."
zuul [Wed, 20 Jul 2016 15:29:19 +0000 (10:29 -0500)]
Merge "res_rtp_asterisk: Count a roll-over of the sequence number even on lost packets."

5 years agoMerge "res_pjsip_mwi: remove unneeded check on endpoint's contacts."
zuul [Wed, 20 Jul 2016 14:57:58 +0000 (09:57 -0500)]
Merge "res_pjsip_mwi: remove unneeded check on endpoint's contacts."

5 years agoAdd conditional support for noreturn functions.
Corey Farrell [Tue, 19 Jul 2016 03:46:19 +0000 (23:46 -0400)]
Add conditional support for noreturn functions.

This adds support for tagging functions with the noreturn attribute.
If DO_CRASH is enabled then ast_do_crash never returns.  If AST_DEVMODE
and DO_CRASH are enabled then failed assertions never return.  This can
resolve a large number of false positives with static analyzers.

ASTERISK-26220 #close

Change-Id: Icfb61e5fe54574eced4c3e88b317244f467ec753

5 years agoMerge "Makefile: Suppress echoing of target 'config' again."
zuul [Tue, 19 Jul 2016 22:35:59 +0000 (17:35 -0500)]
Merge "Makefile: Suppress echoing of target 'config' again."

5 years agochan_dahdi.c: Fix deadlock potential in fax redirection.
Richard Mudgett [Tue, 19 Jul 2016 18:18:47 +0000 (13:18 -0500)]
chan_dahdi.c: Fix deadlock potential in fax redirection.

The dahdi_handle_dtmf() and my_handle_dtmf() have the potential to
deadlock if an incoming fax happens during the Playback or similar

* Fixed the potential deadlock by not calling ast_async_goto() with the
channel lock held.

ASTERISK-26216 #close
Reported by: Richard Mudgett

Change-Id: I9144b84ade5f96690996624ec8a2d40c56af40aa

5 years agochan_sip.c: Fix deadlock potential in fax redirection.
Richard Mudgett [Wed, 13 Jul 2016 23:49:08 +0000 (18:49 -0500)]
chan_sip.c: Fix deadlock potential in fax redirection.

The sip_read() has the potential to deadlock if an incoming fax happens
during the Playback or similar application.

* Fixed the potential deadlock by not calling ast_async_goto() with the
channel lock held.

* Made always eat the fax detection frame whether there is a fax extension
or not.

Reported by: Richard Mudgett

Change-Id: I6d3f5cccd4b77c3aa6ffc1a54c0f6bde61c9278e

5 years agochan_pjsip.c: Fix deadlock potential in fax redirection.
Richard Mudgett [Wed, 13 Jul 2016 23:48:01 +0000 (18:48 -0500)]
chan_pjsip.c: Fix deadlock potential in fax redirection.

The chan_pjsip_cng_tone_detected() has the potential to deadlock if an
incoming fax happens during the Playback or similar application.

* Fixed the potential deadlock by not calling ast_async_goto() with the
channel lock held.

* Made always eat the fax detection frame whether there is a fax extension
or not.

Reported by: Richard Mudgett

Change-Id: I32aecbb4818af646dc5a619f0dc040e9b1f222e5

5 years agores_fax.c: Fix deadlock potential in FAXOPT(faxdetect) framehook.
Richard Mudgett [Tue, 12 Jul 2016 22:33:29 +0000 (17:33 -0500)]
res_fax.c: Fix deadlock potential in FAXOPT(faxdetect) framehook.

The fax_detect_framehook() has the potential to deadlock if an incoming
fax happens during the Playback or similar application.

* Fixed the potential deadlock by not calling ast_async_goto() with the
channel lock held.

* Made always eat the fax detection frame whether there is a fax extension
or not.

* Made only detach the framehook if we detected a fax and not on other
possible frames.

Reported by: Richard Mudgett

Change-Id: I99da35c26d1cd802626ffb4c1b4eb5b015581b6d

5 years agores_fax: Fix FAXOPT(faxdetect) timeout option.
Richard Mudgett [Tue, 12 Jul 2016 22:24:54 +0000 (17:24 -0500)]
res_fax: Fix FAXOPT(faxdetect) timeout option.

The fax detection timeout option did not work because basically the wrong
variable was checked in fax_detect_framehook().  As a result, the timer
would timeout immediately and disable fax detection.

* Fixed ignoring negative timeout values.  We'd complain and then go right
on using the negative value.

* Fixed destroy_faxdetect() in the off-nominal case of an incomplete
object creation.

* Added more range checking to FAXOPT(gateway) timeout parameter.

ASTERISK-26214 #close
Reported by: Richard Mudgett

Change-Id: Idc5e698dfe33572de9840bc68cd9fc043cbad976

5 years agochan_dahdi: Add faxdetect_timeout option.
Richard Mudgett [Mon, 18 Jul 2016 21:16:56 +0000 (16:16 -0500)]
chan_dahdi: Add faxdetect_timeout option.

The new option allows the channel driver's faxdetect option to timeout on
a call after the specified number of seconds into a call.  The new feature
is disabled if the timeout is set to zero.  The option is disabled by

* Don't clear dsp_features after passing them to the dsp code in
my_pri_ss7_open_media().  We should still remember them especially for the
new faxdetect_timeout option.

Reported by: Richard Mudgett

Change-Id: Ieffd3fe788788d56282844774365546dce8ac810

5 years agores_pjsip: Add fax_detect_timeout endpoint option.
Richard Mudgett [Sat, 16 Jul 2016 01:44:52 +0000 (20:44 -0500)]
res_pjsip: Add fax_detect_timeout endpoint option.

The new endpoint option allows the PJSIP channel driver's fax_detect
endpoint option to timeout on a call after the specified number of
seconds into a call.  The new feature is disabled if the timeout is set
to zero.  The option is disabled by default.

Reported by: Richard Mudgett

Change-Id: Id5a87375fb2c4f9dc1d4b44c78ec8735ba65453d

5 years agoMakefile: Retain XML Declaration and DTD in docs.
Alexander Traud [Tue, 19 Jul 2016 09:48:25 +0000 (11:48 +0200)]
Makefile: Retain XML Declaration and DTD in docs.

Since Asterisk 12, the documentation got an XML Stylesheet. Because of a typo,
the XML Declaration and DTD were overwritten by this.

ASTERISK-26212 #close

Change-Id: If5ee4625068042e98ab3fcb22a25e2f15d0c68bd

5 years agoUnit tests: Use AST_TEST_DEFINE in conditional code only.
Corey Farrell [Mon, 18 Jul 2016 23:40:22 +0000 (19:40 -0400)]
Unit tests: Use AST_TEST_DEFINE in conditional code only.

If AST_TEST_DEFINE is not conditional to TEST_FRAMEWORK it produces dead
code.  This places all existing unit tests into a conditional block if
they weren't already.

ASTERISK-26211 #close

Change-Id: I8ef83ee11cbc991b07b7a37ecb41433e8c734686

5 years agores_pjsip_mwi: remove unneeded check on endpoint's contacts.
Alexei Gradinari [Mon, 18 Jul 2016 14:22:57 +0000 (10:22 -0400)]
res_pjsip_mwi: remove unneeded check on endpoint's contacts.

The function create_mwi_subscriptions_for_endpoint checks
if there is active contacts by retrieving aors and contacts.

This function is used to create all unsolicited mwi subscriptions
on startup and is used when contact added.

In both cases it's not necessary to check if there are contacts.
The contacts are needed when asterisk sends mwi.

ASTERISK-26200 #close

Change-Id: I98e43bdc97f3c0829951cd9bf5f3c6348c6ac1fa

5 years agoMerge "pbx: Create pbx_include.c for management of 'struct ast_include'."
Joshua Colp [Mon, 18 Jul 2016 12:07:36 +0000 (07:07 -0500)]
Merge "pbx: Create pbx_include.c for management of 'struct ast_include'."

5 years agores_rtp_asterisk: Count a roll-over of the sequence number even on lost packets.
Alexander Traud [Mon, 18 Jul 2016 10:13:25 +0000 (12:13 +0200)]
res_rtp_asterisk: Count a roll-over of the sequence number even on lost packets.

With this change, the initial RTP sequence number is randomly chosen not between
0 and 65535 (0xffff) but 0 and 32767 (0x7fff). This assures, the roll-over
counter (ROC) synchronization is not lost for sRTP, when the very first RTP
packets get lost; see

ASTERISK-26207 #close

Change-Id: I9a527e3aa3ce8f3becc5131d7ba32b57b5845464

5 years agoMakefile: Suppress echoing of target 'config' again.
Alexander Traud [Mon, 18 Jul 2016 09:14:59 +0000 (11:14 +0200)]
Makefile: Suppress echoing of target 'config' again.

ASTERISK-26038 #close

Change-Id: I5746cf639f3fdc6332e8a97cf01f979e30bf403f

5 years agopbx: Create pbx_ignorepat.c for management of 'struct ast_ignorepat'.
Corey Farrell [Fri, 15 Jul 2016 07:59:48 +0000 (03:59 -0400)]
pbx: Create pbx_ignorepat.c for management of 'struct ast_ignorepat'.

This changes context ignore patterns from a linked list to a vector,
makes 'struct ast_ignorepat' opaque to pbx.c.

Although ast_walk_context_ignorepats is maintained the procedure is no
longer efficient except for the first call (inc==NULL).  This
functionality is replaced by two new functions implemented by vector
* ast_context_ignorepats_count (AST_VECTOR_SIZE)
* ast_context_ignorepats_get (AST_VECTOR_GET)

As with ast_walk_context_ignorepats callers of these functions are
expected to have locked contexts.  Only a few places in Asterisk walked
the ignorepats, they have been converted to use the new functions.

Change-Id: I78f2157d275ef1b7d624b4ff7d770d38e5d7f20a

5 years agoMerge "app_queue: Only remove queue member from pending when state changes."
zuul [Fri, 15 Jul 2016 16:57:52 +0000 (11:57 -0500)]
Merge "app_queue: Only remove queue member from pending when state changes."

5 years agopbx: Create pbx_include.c for management of 'struct ast_include'.
Corey Farrell [Thu, 14 Jul 2016 18:51:42 +0000 (14:51 -0400)]
pbx: Create pbx_include.c for management of 'struct ast_include'.

This changes context includes from a linked list to a vector, makes
'struct ast_include' opaque to pbx.c.

Although ast_walk_context_includes is maintained the procedure is no
longer efficient except for the first call (inc==NULL).  This
functionality is replaced by two new functions implemented by vector
* ast_context_includes_count (AST_VECTOR_SIZE)
* ast_context_includes_get (AST_VECTOR_GET)

As with ast_walk_context_includes callers of these functions are
expected to have locked contexts.  Only a few places in Asterisk walked
the includes, they have been converted to use the new functions.

const have been applied where possible to parameters for ast_include

Change-Id: Ib5c882e27cf96fb2aec67a39c18b4c71c9c83b60

5 years agofeatures.c: Remove unneeded adsi.h include.
Corey Farrell [Thu, 14 Jul 2016 08:25:43 +0000 (04:25 -0400)]
features.c: Remove unneeded adsi.h include.

adsi.h is no longer used by features.c since parking was moved to a

Change-Id: I2248b8a455225a17cb6ddaafd6c20c511a1eaf59

5 years agoUpdate support for SILK format.
Mark Michelson [Thu, 30 Jun 2016 20:58:53 +0000 (15:58 -0500)]
Update support for SILK format.

This commit adds scaffolding in order to support the SILK audio format
on calls. Roughly, this is what is added:

* Cached silk formats. One for each possible sample rate.
* ast_codec structures for each possible sample rate.
* RTP payload mappings for "SILK".

In addition, this change overhauls the res_format_attr_silk file in the
following ways:

* The "samplerate" attribute is scrapped. That's native to the format.
* There are far more checks to ensure that attributes have been
  allocated before attempting to reference them.
* We do not SDP fmtp lines for attributes set to 0.

These changes make way to be able to install a codec_silk module and
have it actually work. It also should allow for passthrough silk calls
in Asterisk.

Change-Id: Ieeb39c95a9fecc9246bcfd3c45a6c9b51c59380e

5 years agoMerge "translate: explicit format destination not properly set"
zuul [Thu, 14 Jul 2016 18:40:43 +0000 (13:40 -0500)]
Merge "translate: explicit format destination not properly set"

5 years agoMerge "threadpool: Fix leak in ast_threadpool_serializer_group error path."
zuul [Thu, 14 Jul 2016 18:33:52 +0000 (13:33 -0500)]
Merge "threadpool: Fix leak in ast_threadpool_serializer_group error path."

5 years agoMerge "pbx: Fix leak of timezone for time based includes."
zuul [Thu, 14 Jul 2016 17:14:44 +0000 (12:14 -0500)]
Merge "pbx: Fix leak of timezone for time based includes."

5 years agoMerge "BuildSystem: Avoid obsolete warning with pthread.m4 on autoconf."
zuul [Thu, 14 Jul 2016 17:05:19 +0000 (12:05 -0500)]
Merge "BuildSystem: Avoid obsolete warning with pthread.m4 on autoconf."

5 years agoMerge "res_rtp_asterisk: Enable Forward Secrecy (PFS) for DTLS."
Joshua Colp [Thu, 14 Jul 2016 15:32:54 +0000 (10:32 -0500)]
Merge "res_rtp_asterisk: Enable Forward Secrecy (PFS) for DTLS."

5 years agoMerge "stasis_endpoint.c: Fix contactstatus_to_json()."
zuul [Thu, 14 Jul 2016 14:37:00 +0000 (09:37 -0500)]
Merge "stasis_endpoint.c: Fix contactstatus_to_json()."

5 years agoMerge "pjsip_options.c: Fix container operation."
zuul [Thu, 14 Jul 2016 13:37:06 +0000 (08:37 -0500)]
Merge "pjsip_options.c: Fix container operation."

5 years agoMerge "pjsip_configuration.c: Misc cleanups."
zuul [Thu, 14 Jul 2016 13:37:05 +0000 (08:37 -0500)]
Merge "pjsip_configuration.c: Misc cleanups."

5 years agoapp_queue: Only remove queue member from pending when state changes.
Joshua Colp [Thu, 14 Jul 2016 12:45:10 +0000 (09:45 -0300)]
app_queue: Only remove queue member from pending when state changes.

It is possible for a not in use state change to occur multiple
times causing a queue member to be removed from the pending call
container prematurely.

The first not in use state change will remove the queue member
from the container. At this moment the member may be called and
placed in the pending container. After this another not in use
state change can be received which will remove it from the
container. Despite being called at this point the code will
incorrectly see that there are no pending calls to it.

This change only removes it from the pending container if the
state has actually changed.

ASTERISK-26133 #close
  app_queue.diff submitted by Richard Miller (license 5685)

Change-Id: Ie5a7f17a44f98e9159e9b85009ce3f8393aa78c0

5 years agoMerge "chan_sip: Fix reference leak in mwi_event_cb"
Joshua Colp [Thu, 14 Jul 2016 09:54:48 +0000 (04:54 -0500)]
Merge "chan_sip: Fix reference leak in mwi_event_cb"

5 years agopbx: Fix leak of timezone for time based includes.
Corey Farrell [Thu, 14 Jul 2016 07:40:26 +0000 (03:40 -0400)]
pbx: Fix leak of timezone for time based includes.

Create include_free to run ast_destroy_timing and ast_free, use that in
all places that freed an ast_include structure.  This fixes a couple of
paths that previously did not run ast_destroy_timing.

ASTERISK-26196 #close

Change-Id: I1671bd111bef0dc113e8bf8f77f89fcfc395d838

5 years agoMerge "res/res_corosync: Raise a Stasis message on node join/leave events"
zuul [Thu, 14 Jul 2016 03:11:40 +0000 (22:11 -0500)]
Merge "res/res_corosync: Raise a Stasis message on node join/leave events"

5 years agoMerge "res/res_pjsip_session: Check for presence of an active negotiator"
zuul [Wed, 13 Jul 2016 23:48:39 +0000 (18:48 -0500)]
Merge "res/res_pjsip_session: Check for presence of an active negotiator"

5 years agotranslate: explicit format destination not properly set
Kevin Harwell [Wed, 13 Jul 2016 22:45:27 +0000 (17:45 -0500)]
translate: explicit format destination not properly set

If the destination format's name differed from the codec name then the
translator's explict_dst field would be improperly set. In some circumstances
it would end up setting it to a newly created format that has the same name
as the codec when it actually needed to be the given destination codec.

This could cause the translation path to use the wrong format. For instance,
if an endpoint had specified 'myulaw' as a format the translator could end up
using a 'ulaw' format (with whatever/default settings) instead. If the format
attribute settings differed between the two then there may unexpected results
during processing.

This patch removes the name check when building the translation path. This
should make it always set the translator's explicit_dst to the given destination
format as long as the sample rate and types match.

Change-Id: Iaf8a03831d68e657d89569d54b505074efbefab5

5 years agostasis_endpoint.c: Fix contactstatus_to_json().
Richard Mudgett [Fri, 8 Jul 2016 16:46:04 +0000 (11:46 -0500)]
stasis_endpoint.c: Fix contactstatus_to_json().

The roundtrip_usec json member is optional.  If it isn't present then
don't put it into the converted json structure where ast_json_pack()
will choke on it.

Change-Id: I39bb2f86154ef54591270c58bfda8635070f9ea0

5 years agopjsip_options.c: Fix container operation.
Richard Mudgett [Mon, 11 Jul 2016 15:22:35 +0000 (10:22 -0500)]
pjsip_options.c: Fix container operation.

aor_observer_deleted() needs to operate on all contacts found for the
deleted AOR instead of only the first one found.  This is really only a
problem if there is more than one contact for the AOR.

Change-Id: Id24ac0d5e8c931330231fb45dd2a331a84339dc1

5 years agopjsip_configuration.c: Misc cleanups.
Richard Mudgett [Mon, 11 Jul 2016 15:21:35 +0000 (10:21 -0500)]
pjsip_configuration.c: Misc cleanups.

* Fix some whitespace in various routines.

* Rename i to iter in persistent_endpoint_update_state().

* Fix off-nominal copy/paste message wording in

Change-Id: Id8e34f5d09e7eebac3af22501c44c1110a3e29d8

5 years agochan_sip: Fix reference leak in mwi_event_cb
Corey Farrell [Wed, 13 Jul 2016 18:45:07 +0000 (14:45 -0400)]
chan_sip: Fix reference leak in mwi_event_cb

Cleanup the peer reference when stasis_subscription_final_message is
true.  Also free peer_name even if peer exists, after reload a new
peer_name will be allocated.

ASTERISK-26193 #close

Change-Id: If7ecd52facdc5c227f701c760841e3f6ca53cc69

5 years agothreadpool: Fix leak in ast_threadpool_serializer_group error path.
Corey Farrell [Wed, 13 Jul 2016 16:30:58 +0000 (12:30 -0400)]
threadpool: Fix leak in ast_threadpool_serializer_group error path.

ast_threadpool_serializer_group leaks a reference to ser when listener
is allocated but tps is not.  Although listener takes the reference to
ser cleanup functions are not run without tps.

ASTERISK-26191 #close

Change-Id: Ie3ccf69a3f1e676c2ef62a77067c0cb57dc9a585

5 years agores_rtp_asterisk: Enable Forward Secrecy (PFS) for DTLS.
Alexander Traud [Wed, 22 Jun 2016 12:13:39 +0000 (14:13 +0200)]
res_rtp_asterisk: Enable Forward Secrecy (PFS) for DTLS.

Since July 2014, TLS based protocols (SIP over TLS, Secure WebSockets, HTTPS)
support PFS thanks to ASTERISK-23905. In July 2015, the same feature was added
for DTLS. The source code from main/tcptls.c should have been re-used to ease
security audits. Therefore, this change rolls back the change from July 2015 and
re-uses the code from July 2014. This has the additional benefits to work under
CentOS 7 and enabling not just ECDHE but DHE based cipher suites as well.

ASTERISK-25659 #close
Reported by: StefanEng86, urbaniak, pay123
Tested by: sarumjanuch, traud
res_rtp_asterisk.patch submitted by sarumjanuch
dtls_centos_step_1.patch submitted by traud
dtls_centos_step_2.patch submitted by traud

Change-Id: I537cadf4421f092a613146b230f2c0ee1be28d5c

5 years agores/res_pjsip_session: Check for presence of an active negotiator
Matt Jordan [Sat, 25 Jun 2016 00:55:09 +0000 (19:55 -0500)]
res/res_pjsip_session: Check for presence of an active negotiator

It is possible in a hypothetical situation for a session refresh to be
invoked on a PJSIP when the negotiatior on the INVITE session has not
yet been established. While this shouldn't occur with existing uses of
ast_sip_session_refresh, the crashes that occur due to improperly
calling PJSIP functions that expect a non-NULL negotiatior are
avoidable. PJSIP will create the negotiator in pjsip_inv_reinvite; this
means that simply checking for the presence of the negotiator before
passing it to other PJSIP functions that use it is allowable. As such,
this patch adds checks for the presence of the negotiator before calling
PJSIP functions that assume it is non-NULL.

Change-Id: I1028323e7e01b0a531865e5412a71b6f6ec4276d

5 years agores/res_pjsip_pubsub: Add additional debug statements
Matt Jordan [Mon, 19 Oct 2015 23:55:58 +0000 (18:55 -0500)]
res/res_pjsip_pubsub: Add additional debug statements

When something very sad and wrong occurs, it's challenging sometimes to
figure out why. This patch adds some additional debug statements on
off-nominal paths to try and make debugging easier.

Change-Id: I7bffb73cc733b6f80193a23340881db4a102b640

5 years agores/res_corosync: Raise a Stasis message on node join/leave events
Matt Jordan [Mon, 19 Oct 2015 23:55:33 +0000 (18:55 -0500)]
res/res_corosync: Raise a Stasis message on node join/leave events

When res_corosync detects that a node leaves or joins, it currently is
informed of this via Corosync callbacks. However, there are a few
limitations with the information presented:
(1) While we have information that Corosync is aware of - such as the
    Corosync nodeid - that information is really only useful inside of
    Corosync or res_corosync. There's no way to translate a Corosync
    nodeid to some other internally useful unique identifier for the
    Asterisk instance that just joined or left the cluster.
(2) While res_corosync is notified of the instance joining or leaving
    the cluster, it has no mechanism to inform the Asterisk core or
    other modules of this event. This limits the usefulness of res_corosync
    as a heartbeat mechanism for other modules.

This patch addresses both issues.

First, it adds the notion of a cluster discovery message both within the
Stasis message bus, as well as the binary event messages that
res_corosync uses to transmit data back and forth within the cluster.
When Asterisk joins the cluster, it sends a discovery message to the other
nodes in the cluster, which correlates the Corosync nodeid along with
the Asterisk EID. res_corosync now maintains a hash of Corosync nodeids
to Asterisk EIDs, such that it can map changes in cluster state with the
Asterisk instance that has that nodeid. Likewise, when an Asterisk
instance receives a discovery message from a node in the cluster, it now
sends its own discovery message back to the originating node with the
local Asterisk EID. This lets Asterisk instances within the cluster
build a complete picture of the other Asterisk instances within the

Second, it publishes the discovery messages onto the Stasis message bus.
Said messages are published whenever a node joins or leaves the cluster.
Interested modules can subscribe for the ast_cluster_discovery_type()
message under the ast_system_topic() and be notified when changes in
cluster state occur.

Change-Id: I9015f418d6ae7f47e4994e04e18948df4d49b465

5 years agoBuildSystem: Avoid obsolete warning with pthread.m4 on autoconf.
Alexander Traud [Wed, 13 Jul 2016 13:57:08 +0000 (15:57 +0200)]
BuildSystem: Avoid obsolete warning with pthread.m4 on autoconf.

Updated the macro-set autoconf/ax_pthread.m4 to its latest upstream version.

ASTERISK-26046 #close

Change-Id: I11abc11d17acd2b6a8a5a5be8ae8e0949dab9cc7

5 years agoMerge "rest_api/channels: Fix multiple issues with create and dial"
zuul [Wed, 13 Jul 2016 13:08:41 +0000 (08:08 -0500)]
Merge "rest_api/channels:  Fix multiple issues with create and dial"

5 years agoMerge "res_pjsip: Fix statsd regression."
Joshua Colp [Wed, 13 Jul 2016 12:41:47 +0000 (07:41 -0500)]
Merge "res_pjsip: Fix statsd regression."