asterisk/asterisk.git
17 years agomore formatting cleanup
Luigi Rizzo [Thu, 27 Apr 2006 02:29:32 +0000 (02:29 +0000)]
more formatting cleanup

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@22750 65c4cc65-6c06-0410-ace0-fbb531ad65f3

17 years agocleanup formatting to emphsize common code blocks
Luigi Rizzo [Thu, 27 Apr 2006 02:00:35 +0000 (02:00 +0000)]
cleanup formatting to emphsize common code blocks

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@22730 65c4cc65-6c06-0410-ace0-fbb531ad65f3

17 years agomove similar blocks close to each other to make similarities
Luigi Rizzo [Thu, 27 Apr 2006 01:35:52 +0000 (01:35 +0000)]
move similar blocks close to each other to make similarities
more evident

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@22727 65c4cc65-6c06-0410-ace0-fbb531ad65f3

17 years agonormalize and simplify the code for keeping track of line and column number.
Luigi Rizzo [Thu, 27 Apr 2006 01:27:07 +0000 (01:27 +0000)]
normalize and simplify the code for keeping track of line and column number.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@22726 65c4cc65-6c06-0410-ace0-fbb531ad65f3

17 years agodefine some flex constants for character sets.
Luigi Rizzo [Thu, 27 Apr 2006 01:07:24 +0000 (01:07 +0000)]
define some flex constants for character sets.
partly fix indentation and normalize code layout.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@22725 65c4cc65-6c06-0410-ace0-fbb531ad65f3

17 years agoonly define HAVE_SOMELIB if somelib's header file was found as well
Russell Bryant [Thu, 27 Apr 2006 00:10:56 +0000 (00:10 +0000)]
only define HAVE_SOMELIB if somelib's header file was found as well

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@22703 65c4cc65-6c06-0410-ace0-fbb531ad65f3

17 years agouncomment some functions in the flex code that were actually
Luigi Rizzo [Thu, 27 Apr 2006 00:05:05 +0000 (00:05 +0000)]
uncomment some functions in the flex code that were actually
used in the bison code - detected by making aelparse compile
again.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@22702 65c4cc65-6c06-0410-ace0-fbb531ad65f3

17 years agouse \t to indicate a tab, and fix indentation for
Luigi Rizzo [Wed, 26 Apr 2006 23:36:05 +0000 (23:36 +0000)]
use \t to indicate a tab, and fix indentation for
the whitespace-handling rules

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@22680 65c4cc65-6c06-0410-ace0-fbb531ad65f3

17 years agoremove common blocks of code with a macro (waiting for a better
Luigi Rizzo [Wed, 26 Apr 2006 23:18:03 +0000 (23:18 +0000)]
remove common blocks of code with a macro (waiting for a better
solution).

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@22679 65c4cc65-6c06-0410-ace0-fbb531ad65f3

17 years agostaticize some variables
Luigi Rizzo [Wed, 26 Apr 2006 23:08:47 +0000 (23:08 +0000)]
staticize some variables

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@22678 65c4cc65-6c06-0410-ace0-fbb531ad65f3

17 years agocomment behaviour of pbcwhere in preparation for its use
Luigi Rizzo [Wed, 26 Apr 2006 22:56:18 +0000 (22:56 +0000)]
comment behaviour of pbcwhere in preparation for its use
in more places.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@22656 65c4cc65-6c06-0410-ace0-fbb531ad65f3

17 years agoremove unused variable
Luigi Rizzo [Wed, 26 Apr 2006 22:45:37 +0000 (22:45 +0000)]
remove unused variable

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@22655 65c4cc65-6c06-0410-ace0-fbb531ad65f3

17 years agoinclude/asterisk/ael_structs.h:
Luigi Rizzo [Wed, 26 Apr 2006 22:41:16 +0000 (22:41 +0000)]
include/asterisk/ael_structs.h:
  - protect against multiple includes of ael_structs.h
  - remove prototypes for unused or undeclared functions

pbx/ael/ael.y
  - staticize functions as appropriate
  - constify arguments
  - remove useless extern

pbx/ael/ael.flex
  - ifdef out unused functions

pbx/pbx_ael.c
  - constify some variables and arguments
  - ifdef out unused functions
  - staticize functions as appropriate

update generated files accordingly

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@22654 65c4cc65-6c06-0410-ace0-fbb531ad65f3

17 years agoadds new function QUEUE_WAITING_COUNT and a few
Matt O'Gorman [Wed, 26 Apr 2006 22:04:42 +0000 (22:04 +0000)]
adds new function QUEUE_WAITING_COUNT and a few
warnings if the queue you are looking for in this
function and other queue functions is not found.
patch from 7036

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@22653 65c4cc65-6c06-0410-ace0-fbb531ad65f3

17 years agomore janitor work, patch from bug 6975.
Matt O'Gorman [Wed, 26 Apr 2006 21:44:25 +0000 (21:44 +0000)]
more janitor work, patch from bug 6975.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@22631 65c4cc65-6c06-0410-ace0-fbb531ad65f3

17 years agoMerged revisions 22596 via svnmerge from
Matt O'Gorman [Wed, 26 Apr 2006 19:22:55 +0000 (19:22 +0000)]
Merged revisions 22596 via svnmerge from
https://svn.digium.com/svn/asterisk/branches/1.2

........
r22596 | mogorman | 2006-04-26 14:18:55 -0500 (Wed, 26 Apr 2006) | 3 lines

do not allow for users to forward voicemail to
themselves, patch from 7001

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@22597 65c4cc65-6c06-0410-ace0-fbb531ad65f3

17 years agoadds two new applications, exitwhile, and continuewhile
Matt O'Gorman [Wed, 26 Apr 2006 18:49:07 +0000 (18:49 +0000)]
adds two new applications, exitwhile, and continuewhile
patch from bug 6994.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@22573 65c4cc65-6c06-0410-ace0-fbb531ad65f3

17 years agowhitespace-only change:
Luigi Rizzo [Wed, 26 Apr 2006 18:43:29 +0000 (18:43 +0000)]
whitespace-only change:
partly fix indentation/formatting of the bison source,
and of the generated file

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@22572 65c4cc65-6c06-0410-ace0-fbb531ad65f3

17 years agowhitespace-only change:
Luigi Rizzo [Wed, 26 Apr 2006 18:40:09 +0000 (18:40 +0000)]
whitespace-only change:
fix formatting and indentation of the flex file,
and regenerate the ael_lex.c

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@22571 65c4cc65-6c06-0410-ace0-fbb531ad65f3

17 years agoFacility decoding doesn't work proper yet
Christian Richter [Wed, 26 Apr 2006 14:51:32 +0000 (14:51 +0000)]
Facility decoding doesn't work proper yet

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@22549 65c4cc65-6c06-0410-ace0-fbb531ad65f3

17 years agoadd the missing prototype for the included asprintf
Russell Bryant [Wed, 26 Apr 2006 13:18:32 +0000 (13:18 +0000)]
add the missing prototype for the included asprintf

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@22526 65c4cc65-6c06-0410-ace0-fbb531ad65f3

17 years agoanother Solaris compatability fix - this makes sure u_int64_t is defined
Russell Bryant [Wed, 26 Apr 2006 02:16:30 +0000 (02:16 +0000)]
another Solaris compatability fix - this makes sure u_int64_t is defined

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@22504 65c4cc65-6c06-0410-ace0-fbb531ad65f3

17 years agoBug 7032 - Remove deprecated use of ${CALLERIDNUM}
Tilghman Lesher [Tue, 25 Apr 2006 22:38:31 +0000 (22:38 +0000)]
Bug 7032 - Remove deprecated use of ${CALLERIDNUM}

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@22482 65c4cc65-6c06-0410-ace0-fbb531ad65f3

17 years agoAEL is no longer considered experimental :)
Russell Bryant [Tue, 25 Apr 2006 20:51:55 +0000 (20:51 +0000)]
AEL is no longer considered experimental  :)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@22460 65c4cc65-6c06-0410-ace0-fbb531ad65f3

17 years agodon't rely on default search paths for finding local include files
Kevin P. Fleming [Tue, 25 Apr 2006 18:29:02 +0000 (18:29 +0000)]
don't rely on default search paths for finding local include files

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@22438 65c4cc65-6c06-0410-ace0-fbb531ad65f3

17 years agoif an external library is found, but the associated header file is not, just
Russell Bryant [Tue, 25 Apr 2006 17:22:38 +0000 (17:22 +0000)]
if an external library is found, but the associated header file is not, just
move on without including support for this library.  However, if --with-lib
is explicitly specified, then error out noting the situation.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@22415 65c4cc65-6c06-0410-ace0-fbb531ad65f3

17 years agowrong path in include file.
Luigi Rizzo [Tue, 25 Apr 2006 17:08:41 +0000 (17:08 +0000)]
wrong path in include file.
Maybe it compiled on some platform because of extra -I
statements in the Makefiles.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@22414 65c4cc65-6c06-0410-ace0-fbb531ad65f3

17 years agofix variable declaration in the middle of a block
Luigi Rizzo [Tue, 25 Apr 2006 17:06:37 +0000 (17:06 +0000)]
fix variable declaration in the middle of a block

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@22413 65c4cc65-6c06-0410-ace0-fbb531ad65f3

17 years agodon't list strcompat.o as a dependency in the build_tools Makefile. It is
Russell Bryant [Tue, 25 Apr 2006 13:45:43 +0000 (13:45 +0000)]
don't list strcompat.o as a dependency in the build_tools Makefile.  It is
already listed in the target in the main Makefile.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@22388 65c4cc65-6c06-0410-ace0-fbb531ad65f3

17 years agoremove a bashism ...
Russell Bryant [Tue, 25 Apr 2006 06:07:43 +0000 (06:07 +0000)]
remove a bashism ...

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@22357 65c4cc65-6c06-0410-ace0-fbb531ad65f3

17 years agoapparently some systems may have ncurses that doesn't provide backwards compat
Russell Bryant [Tue, 25 Apr 2006 05:53:58 +0000 (05:53 +0000)]
apparently some systems may have ncurses that doesn't provide backwards compat
with curses.  So, check for both and use whatever is found

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@22346 65c4cc65-6c06-0410-ace0-fbb531ad65f3

17 years agoanother little Solaris fix, unset LIBS before building libmxml
Russell Bryant [Tue, 25 Apr 2006 05:35:11 +0000 (05:35 +0000)]
another little Solaris fix, unset LIBS before building libmxml

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@22345 65c4cc65-6c06-0410-ace0-fbb531ad65f3

17 years agomenuselect needs strcompat.o for strsep on Solaris
Russell Bryant [Tue, 25 Apr 2006 05:26:02 +0000 (05:26 +0000)]
menuselect needs strcompat.o for strsep on Solaris

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@22344 65c4cc65-6c06-0410-ace0-fbb531ad65f3

17 years agocheck for automake before aclocal, so that the error message says automake
Russell Bryant [Mon, 24 Apr 2006 21:32:41 +0000 (21:32 +0000)]
check for automake before aclocal, so that the error message says automake
is missing instead of aclocal, since that's where aclocal comes from

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@22327 65c4cc65-6c06-0410-ace0-fbb531ad65f3

17 years agoMove clueful 'h' more central; alias ESC to left arrow and make ESC quit on main...
Tilghman Lesher [Mon, 24 Apr 2006 20:01:14 +0000 (20:01 +0000)]
Move clueful 'h' more central; alias ESC to left arrow and make ESC quit on main menu

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@22308 65c4cc65-6c06-0410-ace0-fbb531ad65f3

17 years agoadd a note indicating that you can press 'h' for help
Russell Bryant [Mon, 24 Apr 2006 19:15:43 +0000 (19:15 +0000)]
add a note indicating that you can press 'h' for help

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@22306 65c4cc65-6c06-0410-ace0-fbb531ad65f3

17 years agoremove properties added as a part of the AEL merge
Russell Bryant [Mon, 24 Apr 2006 18:47:05 +0000 (18:47 +0000)]
remove properties added as a part of the AEL merge

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@22303 65c4cc65-6c06-0410-ace0-fbb531ad65f3

17 years agoremove some files we don't need
Russell Bryant [Mon, 24 Apr 2006 18:41:44 +0000 (18:41 +0000)]
remove some files we don't need

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@22302 65c4cc65-6c06-0410-ace0-fbb531ad65f3

17 years agoMerge Steve Murphy's (murf) complete re-implementation of AEL, which is now no longer...
Kevin P. Fleming [Mon, 24 Apr 2006 17:41:27 +0000 (17:41 +0000)]
Merge Steve Murphy's (murf) complete re-implementation of AEL, which is now no longer considered experimental :-)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@22273 65c4cc65-6c06-0410-ace0-fbb531ad65f3

17 years agoprint a message before running the autotools
Russell Bryant [Mon, 24 Apr 2006 17:34:35 +0000 (17:34 +0000)]
print a message before running the autotools

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@22272 65c4cc65-6c06-0410-ace0-fbb531ad65f3

17 years agofix kevin's silly typos
Russell Bryant [Mon, 24 Apr 2006 17:24:03 +0000 (17:24 +0000)]
fix kevin's silly typos

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@22269 65c4cc65-6c06-0410-ace0-fbb531ad65f3

17 years agoDeprecate prefixed options in voicemail
Tilghman Lesher [Mon, 24 Apr 2006 17:20:41 +0000 (17:20 +0000)]
Deprecate prefixed options in voicemail

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@22268 65c4cc65-6c06-0410-ace0-fbb531ad65f3

17 years agoThanks to the fine work of Russell Bryant and Dancho Lazarov, we now have autoconf...
Kevin P. Fleming [Mon, 24 Apr 2006 17:11:45 +0000 (17:11 +0000)]
Thanks to the fine work of Russell Bryant and Dancho Lazarov, we now have autoconf and menuselect tools for Asterisk!

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@22267 65c4cc65-6c06-0410-ace0-fbb531ad65f3

17 years agoFix CDR builds when includes are in freetds directory off include
Mark Spencer [Mon, 24 Apr 2006 03:40:12 +0000 (03:40 +0000)]
Fix CDR builds when includes are in freetds directory off include

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@22232 65c4cc65-6c06-0410-ace0-fbb531ad65f3

17 years agoBug 6710 - Move default datetime string to each language function, so each language...
Tilghman Lesher [Sun, 23 Apr 2006 15:26:55 +0000 (15:26 +0000)]
Bug 6710 - Move default datetime string to each language function, so each language can have its own default

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@22201 65c4cc65-6c06-0410-ace0-fbb531ad65f3

17 years ago- Add doxygen documentation for sipsock_read locking
Olle Johansson [Sun, 23 Apr 2006 06:22:29 +0000 (06:22 +0000)]
- Add doxygen documentation for sipsock_read locking
- Improve documentation of pedantic
  (related to issue #7016)

  From the air above Russia...

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@22163 65c4cc65-6c06-0410-ace0-fbb531ad65f3

17 years agoAdded "Operator Services" connection mode for Zap channels, and the 'O' option
Jim Dixon [Sat, 22 Apr 2006 11:30:06 +0000 (11:30 +0000)]
Added "Operator Services" connection mode for Zap channels, and the 'O' option
in app_dial to support the use of this mode.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@22128 65c4cc65-6c06-0410-ace0-fbb531ad65f3

17 years agoconvert to use ast_stream_and_wait
Luigi Rizzo [Fri, 21 Apr 2006 20:57:29 +0000 (20:57 +0000)]
convert to use ast_stream_and_wait

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@22082 65c4cc65-6c06-0410-ace0-fbb531ad65f3

17 years agoconvert to use ast_strem_and_wait
Luigi Rizzo [Fri, 21 Apr 2006 20:51:55 +0000 (20:51 +0000)]
convert to use ast_strem_and_wait

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@22078 65c4cc65-6c06-0410-ace0-fbb531ad65f3

17 years agoconvert to use ast_stream_and_wait
Luigi Rizzo [Fri, 21 Apr 2006 20:39:50 +0000 (20:39 +0000)]
convert to use ast_stream_and_wait

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@22076 65c4cc65-6c06-0410-ace0-fbb531ad65f3

17 years agomove wait_and_stream to ast_wait_and_stream() because equivalent
Luigi Rizzo [Fri, 21 Apr 2006 20:28:32 +0000 (20:28 +0000)]
move wait_and_stream to ast_wait_and_stream() because equivalent
code is replicated in way too many places not to have a global
function for that.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@22075 65c4cc65-6c06-0410-ace0-fbb531ad65f3

17 years agomore stncpy/ast_copy_string replacement.
Luigi Rizzo [Fri, 21 Apr 2006 18:34:38 +0000 (18:34 +0000)]
more stncpy/ast_copy_string replacement.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@22046 65c4cc65-6c06-0410-ace0-fbb531ad65f3

17 years agomore strncpy/ast_copy_string replacement.
Luigi Rizzo [Fri, 21 Apr 2006 18:26:54 +0000 (18:26 +0000)]
more strncpy/ast_copy_string replacement.
On passing, simplify code by using strsep() as appropriate

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@22045 65c4cc65-6c06-0410-ace0-fbb531ad65f3

17 years agomore strncpy/ast_copy_string replacement
Luigi Rizzo [Fri, 21 Apr 2006 18:13:21 +0000 (18:13 +0000)]
more strncpy/ast_copy_string replacement

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@22044 65c4cc65-6c06-0410-ace0-fbb531ad65f3

17 years agoreplace some strncpy with ast_copy string,
Luigi Rizzo [Fri, 21 Apr 2006 18:08:57 +0000 (18:08 +0000)]
replace some strncpy with ast_copy string,
on passing fix some potential null pointer dereference,
and normalize some loops

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@22043 65c4cc65-6c06-0410-ace0-fbb531ad65f3

17 years agoreplace strncpy with ast_copy_string.
Luigi Rizzo [Fri, 21 Apr 2006 17:53:39 +0000 (17:53 +0000)]
replace strncpy with ast_copy_string.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@22016 65c4cc65-6c06-0410-ace0-fbb531ad65f3

17 years agoreplace strncpy with ast_copy_string and fix the -1 offset which
Luigi Rizzo [Fri, 21 Apr 2006 17:47:44 +0000 (17:47 +0000)]
replace strncpy with ast_copy_string and fix the -1 offset which
is not needed now.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@22015 65c4cc65-6c06-0410-ace0-fbb531ad65f3

17 years agocomment a possible memory leak
Luigi Rizzo [Fri, 21 Apr 2006 16:18:12 +0000 (16:18 +0000)]
comment a possible memory leak

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@21988 65c4cc65-6c06-0410-ace0-fbb531ad65f3

17 years agomerge some common code into a function
Luigi Rizzo [Fri, 21 Apr 2006 16:04:25 +0000 (16:04 +0000)]
merge some common code into a function

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@21986 65c4cc65-6c06-0410-ace0-fbb531ad65f3

17 years agoupdate configuration, generalize date format and
Luigi Rizzo [Fri, 21 Apr 2006 15:49:14 +0000 (15:49 +0000)]
update configuration, generalize date format and
start mapping digit strings

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@21960 65c4cc65-6c06-0410-ace0-fbb531ad65f3

17 years ago- use symbolic constants and macros to play with the debug flag
Luigi Rizzo [Fri, 21 Apr 2006 14:49:21 +0000 (14:49 +0000)]
- use symbolic constants and macros to play with the debug flag
  on the frame counters. Document it in the header file.
- provide a single exit point for a function;
- mark XXX some unclear parts of the code.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@21933 65c4cc65-6c06-0410-ace0-fbb531ad65f3

17 years agosimplify pbx_builtin_execiftime
Luigi Rizzo [Fri, 21 Apr 2006 13:44:15 +0000 (13:44 +0000)]
simplify pbx_builtin_execiftime

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@21906 65c4cc65-6c06-0410-ace0-fbb531ad65f3

17 years agosimplify a function
Luigi Rizzo [Fri, 21 Apr 2006 12:58:39 +0000 (12:58 +0000)]
simplify a function

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@21879 65c4cc65-6c06-0410-ace0-fbb531ad65f3

17 years agominor cleanup
Luigi Rizzo [Fri, 21 Apr 2006 12:12:42 +0000 (12:12 +0000)]
minor cleanup

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@21878 65c4cc65-6c06-0410-ace0-fbb531ad65f3

17 years agoone more client for find_context_locked()
Luigi Rizzo [Fri, 21 Apr 2006 11:30:02 +0000 (11:30 +0000)]
one more client for find_context_locked()

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@21851 65c4cc65-6c06-0410-ace0-fbb531ad65f3

17 years agolocalize a variable, and make a minor code rearrangement.
Luigi Rizzo [Fri, 21 Apr 2006 11:19:48 +0000 (11:19 +0000)]
localize a variable, and make a minor code rearrangement.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@21850 65c4cc65-6c06-0410-ace0-fbb531ad65f3

17 years agomore NULL "" equivalence in cid fields.
Luigi Rizzo [Fri, 21 Apr 2006 11:05:54 +0000 (11:05 +0000)]
more NULL "" equivalence in cid fields.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@21849 65c4cc65-6c06-0410-ace0-fbb531ad65f3

17 years agomore NULL "" equivalence in cid fields.
Luigi Rizzo [Fri, 21 Apr 2006 11:02:28 +0000 (11:02 +0000)]
more NULL "" equivalence in cid fields.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@21835 65c4cc65-6c06-0410-ace0-fbb531ad65f3

17 years agomore NULL "" equivalence,
Luigi Rizzo [Fri, 21 Apr 2006 10:57:03 +0000 (10:57 +0000)]
more NULL "" equivalence,
mark a couple of inconsistencies (missing CallerIDnum,
"unknown" instead of "<unknown>") - there are more of the same.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@21821 65c4cc65-6c06-0410-ace0-fbb531ad65f3

17 years agomore NULL "" equivalence in CLI fields.
Luigi Rizzo [Fri, 21 Apr 2006 10:51:31 +0000 (10:51 +0000)]
more NULL "" equivalence in CLI fields.

Mark a place where we don't clear a buffer while we probably should.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@21820 65c4cc65-6c06-0410-ace0-fbb531ad65f3

17 years agomore NULL / "" equivalence for CID fields.
Luigi Rizzo [Fri, 21 Apr 2006 10:47:07 +0000 (10:47 +0000)]
more NULL / "" equivalence for CID fields.

Mark an inconsistency in empty string handling.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@21819 65c4cc65-6c06-0410-ace0-fbb531ad65f3

17 years agomore NULL "" equivalence in CID fields.
Luigi Rizzo [Fri, 21 Apr 2006 10:41:13 +0000 (10:41 +0000)]
more NULL "" equivalence in CID fields.
Mark a potentially missing item in managerevent

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@21818 65c4cc65-6c06-0410-ace0-fbb531ad65f3

17 years agoast_strdup can handle NULL args well, so use it.
Luigi Rizzo [Fri, 21 Apr 2006 10:37:59 +0000 (10:37 +0000)]
ast_strdup can handle NULL args well, so use it.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@21817 65c4cc65-6c06-0410-ace0-fbb531ad65f3

17 years agomore NULL and "" equivalence in cid fields
Luigi Rizzo [Fri, 21 Apr 2006 10:31:23 +0000 (10:31 +0000)]
more NULL and "" equivalence in cid fields

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@21816 65c4cc65-6c06-0410-ace0-fbb531ad65f3

17 years agomake NULL and "" equivalent in cid fields, mark some missing NULL checks.
Luigi Rizzo [Fri, 21 Apr 2006 10:05:45 +0000 (10:05 +0000)]
make NULL and "" equivalent in cid fields, mark some missing NULL checks.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@21814 65c4cc65-6c06-0410-ace0-fbb531ad65f3

17 years agomake NULL and "" equivalent for some cid fields.
Luigi Rizzo [Fri, 21 Apr 2006 10:00:58 +0000 (10:00 +0000)]
make NULL and "" equivalent for some cid fields.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@21792 65c4cc65-6c06-0410-ace0-fbb531ad65f3

17 years agoReplace three replicas of the same code with a function.
Luigi Rizzo [Fri, 21 Apr 2006 09:54:23 +0000 (09:54 +0000)]
Replace three replicas of the same code with a function.
Consider NULL and "" as equivalent in cid strings.

On passing, also remove an extra data copy.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@21786 65c4cc65-6c06-0410-ace0-fbb531ad65f3

17 years agocomment that for callerid field, NULL and "" should be considered
Luigi Rizzo [Thu, 20 Apr 2006 17:39:44 +0000 (17:39 +0000)]
comment that for callerid field, NULL and "" should be considered
equivalent (the reason is, when passing these strings through a
statically allocated buffer, we have no way to tell between NULL and ""
so we would be unable to preserve the difference, if any).

No code changes yet.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@21743 65c4cc65-6c06-0410-ace0-fbb531ad65f3

17 years agoClarify result of sipsock_read
Olle Johansson [Wed, 19 Apr 2006 23:49:36 +0000 (23:49 +0000)]
Clarify result of sipsock_read

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@21707 65c4cc65-6c06-0410-ace0-fbb531ad65f3

17 years agoadd the malloc attribute to the memory allocation wrappers
Russell Bryant [Wed, 19 Apr 2006 22:32:07 +0000 (22:32 +0000)]
add the malloc attribute to the memory allocation wrappers

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@21681 65c4cc65-6c06-0410-ace0-fbb531ad65f3

17 years agoMerged revisions 21638 via svnmerge from
Kevin P. Fleming [Wed, 19 Apr 2006 21:11:31 +0000 (21:11 +0000)]
Merged revisions 21638 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r21638 | kpfleming | 2006-04-19 16:10:41 -0500 (Wed, 19 Apr 2006) | 2 lines

support system-specific scripts in safe_asterisk, before starting Asterisk proper

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@21639 65c4cc65-6c06-0410-ace0-fbb531ad65f3

17 years agoMerged revisions 21597 via svnmerge from
Tilghman Lesher [Wed, 19 Apr 2006 18:56:38 +0000 (18:56 +0000)]
Merged revisions 21597 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r21597 | tilghman | 2006-04-19 13:43:17 -0500 (Wed, 19 Apr 2006) | 2 lines

Bug 6553 - plug memory leaks when ODBC connection is down

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@21600 65c4cc65-6c06-0410-ace0-fbb531ad65f3

17 years agoOops, wasn't revised the way I thought it was
Tilghman Lesher [Wed, 19 Apr 2006 18:50:51 +0000 (18:50 +0000)]
Oops, wasn't revised the way I thought it was

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@21599 65c4cc65-6c06-0410-ace0-fbb531ad65f3

17 years agoBlocked revisions 21597 via svnmerge
Tilghman Lesher [Wed, 19 Apr 2006 18:44:58 +0000 (18:44 +0000)]
Blocked revisions 21597 via svnmerge

........
r21597 | tilghman | 2006-04-19 13:43:17 -0500 (Wed, 19 Apr 2006) | 2 lines

Bug 6553 - plug memory leaks when ODBC connection is down

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@21598 65c4cc65-6c06-0410-ace0-fbb531ad65f3

17 years agomove a replicated block of code in the one place where it belongs.
Luigi Rizzo [Wed, 19 Apr 2006 18:15:20 +0000 (18:15 +0000)]
move a replicated block of code in the one place where it belongs.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@21596 65c4cc65-6c06-0410-ace0-fbb531ad65f3

17 years agomerge two nested 'if' which are really a single block.
Luigi Rizzo [Wed, 19 Apr 2006 18:07:19 +0000 (18:07 +0000)]
merge two nested 'if' which are really a single block.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@21595 65c4cc65-6c06-0410-ace0-fbb531ad65f3

17 years agofix indentation of a large block
Luigi Rizzo [Wed, 19 Apr 2006 18:00:32 +0000 (18:00 +0000)]
fix indentation of a large block

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@21572 65c4cc65-6c06-0410-ace0-fbb531ad65f3

17 years agostart sorting out the duplicated code in the privacy handler
Luigi Rizzo [Wed, 19 Apr 2006 17:58:07 +0000 (17:58 +0000)]
start sorting out the duplicated code in the privacy handler
for future removal

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@21568 65c4cc65-6c06-0410-ace0-fbb531ad65f3

17 years agomerge two nested 'if' which are really a single block.
Luigi Rizzo [Wed, 19 Apr 2006 17:29:15 +0000 (17:29 +0000)]
merge two nested 'if' which are really a single block.
(indentation still to be fixed)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@21566 65c4cc65-6c06-0410-ace0-fbb531ad65f3

17 years agomore localization and variable removal
Luigi Rizzo [Wed, 19 Apr 2006 16:54:04 +0000 (16:54 +0000)]
more localization and variable removal

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@21538 65c4cc65-6c06-0410-ace0-fbb531ad65f3

17 years agomore localization of variables
Luigi Rizzo [Wed, 19 Apr 2006 16:36:15 +0000 (16:36 +0000)]
more localization of variables

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@21537 65c4cc65-6c06-0410-ace0-fbb531ad65f3

17 years agolocalize one more variable;
Luigi Rizzo [Wed, 19 Apr 2006 16:19:52 +0000 (16:19 +0000)]
localize one more variable;
use ast_strdup as it can handle the NULL argument well.
mark a dubious piece of code with XXX

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@21536 65c4cc65-6c06-0410-ace0-fbb531ad65f3

17 years agolocalize some variables
Luigi Rizzo [Wed, 19 Apr 2006 16:10:11 +0000 (16:10 +0000)]
localize some variables

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@21535 65c4cc65-6c06-0410-ace0-fbb531ad65f3

17 years agoextract a common condition.
Luigi Rizzo [Wed, 19 Apr 2006 15:15:03 +0000 (15:15 +0000)]
extract a common condition.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@21508 65c4cc65-6c06-0410-ace0-fbb531ad65f3

17 years agofix indentation of some large blocks after previous changes
Luigi Rizzo [Wed, 19 Apr 2006 14:53:18 +0000 (14:53 +0000)]
fix indentation of some large blocks after previous changes

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@21481 65c4cc65-6c06-0410-ace0-fbb531ad65f3

17 years agomore simplifications - use a local variable c instead of o->chan,
Luigi Rizzo [Wed, 19 Apr 2006 14:50:17 +0000 (14:50 +0000)]
more simplifications - use a local variable c instead of o->chan,
use S_OR as appropriate.

Still need to fix the indentation of some blocks.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@21480 65c4cc65-6c06-0410-ace0-fbb531ad65f3

17 years agomore simplifications
Luigi Rizzo [Wed, 19 Apr 2006 14:14:40 +0000 (14:14 +0000)]
more simplifications

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@21479 65c4cc65-6c06-0410-ace0-fbb531ad65f3

17 years agostart cleaning up this code so we can split the 900 lines function
Luigi Rizzo [Wed, 19 Apr 2006 14:02:49 +0000 (14:02 +0000)]
start cleaning up this code so we can split the 900 lines function
into manageable chunks.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@21468 65c4cc65-6c06-0410-ace0-fbb531ad65f3

17 years agosupport 'languageprefix' in asterisk.conf to modify the algorithm
Luigi Rizzo [Wed, 19 Apr 2006 13:59:34 +0000 (13:59 +0000)]
support 'languageprefix' in asterisk.conf to modify the algorithm
to build pathnames for language-specific files (see file.c for
a description)

Default, of course, to the standard behaviour.

We don't have an asterisk.conf.sample to put an example of use!

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@21451 65c4cc65-6c06-0410-ace0-fbb531ad65f3

17 years agoadd experimental code for new-style "say" application.
Luigi Rizzo [Wed, 19 Apr 2006 10:27:31 +0000 (10:27 +0000)]
add experimental code for new-style "say" application.
The rules for spelling out numbers and dates are in the config
file "say.conf", which can be edited to implement national
or even local language rules.

The new code can be enabled through the cli command
'say load new'
while the old code can be restored with
'say load old'

Eventually, this code should go to a better place,
but for the time being we keep here as it provides
very similar functions.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@21421 65c4cc65-6c06-0410-ace0-fbb531ad65f3