asterisk/asterisk.git
16 years agolocalize some variables, remove useless parentheses
Luigi Rizzo [Wed, 12 Apr 2006 00:15:57 +0000 (00:15 +0000)]
localize some variables, remove useless parentheses

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@19465 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoremove useless \0, and fix formatting.
Luigi Rizzo [Tue, 11 Apr 2006 23:54:33 +0000 (23:54 +0000)]
remove useless \0, and fix formatting.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@19437 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoBug 6943 - transition away from using CallerID header, when we really mean CallerIDNum
Tilghman Lesher [Tue, 11 Apr 2006 23:23:16 +0000 (23:23 +0000)]
Bug 6943 - transition away from using CallerID header, when we really mean CallerIDNum

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@19436 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoMerged revisions 19397 via svnmerge from
Tilghman Lesher [Tue, 11 Apr 2006 22:51:10 +0000 (22:51 +0000)]
Merged revisions 19397 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r19397 | tilghman | 2006-04-11 17:39:59 -0500 (Tue, 11 Apr 2006) | 2 lines

Bug 6490 - telco intercept should report NOANSWER instead of CHANUNAVAIL

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@19398 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agofix various bugs in the DEBUG_THREADS code including:
Luigi Rizzo [Tue, 11 Apr 2006 22:37:27 +0000 (22:37 +0000)]
fix various bugs in the DEBUG_THREADS code including:
- misspelled ast_mutex_logger() instead of __ast_mutex_logger()
- misplaced #define ast_mutex_init(pmutex)
- wrong arguments to __ast_mutex_logger() in one instance.

Clearly this code is too spaghetti!

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@19396 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoMerged revisions 19394 via svnmerge from
Tilghman Lesher [Tue, 11 Apr 2006 22:25:57 +0000 (22:25 +0000)]
Merged revisions 19394 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r19394 | tilghman | 2006-04-11 17:24:46 -0500 (Tue, 11 Apr 2006) | 2 lines

Bug 6061 - Fix ODBC storage of VM on PGSQL and MSSQL

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@19395 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agofix logic error; don't test for rtcache flag unless asked to (issue #6923)
Kevin P. Fleming [Tue, 11 Apr 2006 22:07:52 +0000 (22:07 +0000)]
fix logic error; don't test for rtcache flag unless asked to (issue #6923)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@19393 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoMerged revisions 19353 via svnmerge from
Kevin P. Fleming [Tue, 11 Apr 2006 21:59:40 +0000 (21:59 +0000)]
Merged revisions 19353 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r19353 | kpfleming | 2006-04-11 16:58:47 -0500 (Tue, 11 Apr 2006) | 2 lines

don't create a 'voicemail' symlink in the sounds directory; app_voicemail has not needed it since January of 2005 (issue #6613)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@19354 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoMerged revisions 19351 via svnmerge from
Tilghman Lesher [Tue, 11 Apr 2006 21:58:44 +0000 (21:58 +0000)]
Merged revisions 19351 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r19351 | tilghman | 2006-04-11 16:55:51 -0500 (Tue, 11 Apr 2006) | 2 lines

Bug 6097 - possible descriptor leak

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@19352 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoMerged revisions 19348 via svnmerge from
Kevin P. Fleming [Tue, 11 Apr 2006 21:51:17 +0000 (21:51 +0000)]
Merged revisions 19348 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r19348 | kpfleming | 2006-04-11 16:50:18 -0500 (Tue, 11 Apr 2006) | 2 lines

don't call the originating device as part of the Page() operation (issue #6932)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@19350 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoMerged revisions 19347 via svnmerge from
Kevin P. Fleming [Tue, 11 Apr 2006 21:50:48 +0000 (21:50 +0000)]
Merged revisions 19347 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r19347 | kpfleming | 2006-04-11 16:35:52 -0500 (Tue, 11 Apr 2006) | 2 lines

simplify spy queue flushing logic, and always force a flush when one side gets full, even if the other side is not empty (issue #6457)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@19349 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoMerged revisions 19345 via svnmerge from
Kevin P. Fleming [Tue, 11 Apr 2006 21:18:27 +0000 (21:18 +0000)]
Merged revisions 19345 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r19345 | kpfleming | 2006-04-11 16:14:42 -0500 (Tue, 11 Apr 2006) | 2 lines

don't destroy the entire dialplan during 'reload', just atomically replace it like 'extensions reload' does (issue #6047)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@19346 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoremove unused variable (discovered by the compiler)
Luigi Rizzo [Tue, 11 Apr 2006 20:52:05 +0000 (20:52 +0000)]
remove unused variable (discovered by the compiler)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@19306 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoNo need to do this in here any longer since the linkedlists macro is fixed
Joshua Colp [Tue, 11 Apr 2006 20:51:45 +0000 (20:51 +0000)]
No need to do this in here any longer since the linkedlists macro is fixed

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@19305 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoMerged revisions 19303 via svnmerge from
Joshua Colp [Tue, 11 Apr 2006 20:48:57 +0000 (20:48 +0000)]
Merged revisions 19303 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r19303 | file | 2006-04-11 17:46:38 -0300 (Tue, 11 Apr 2006) | 2 lines

Minor linked lists bug fix. When you're dealing with swapping entries around a lot it can cause a seg fault.

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@19304 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoMerged revisions 19301 via svnmerge from
Kevin P. Fleming [Tue, 11 Apr 2006 20:11:36 +0000 (20:11 +0000)]
Merged revisions 19301 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r19301 | kpfleming | 2006-04-11 15:11:01 -0500 (Tue, 11 Apr 2006) | 2 lines

handle call time limit properly when warning is requested _after_ call would hae already ended (issue #6356)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@19302 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agotypo
Kevin P. Fleming [Tue, 11 Apr 2006 17:03:26 +0000 (17:03 +0000)]
typo

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@19272 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoConvert chan_iax2 to use linked lists for multithreading, and add dynamic threads...
Joshua Colp [Tue, 11 Apr 2006 16:44:10 +0000 (16:44 +0000)]
Convert chan_iax2 to use linked lists for multithreading, and add dynamic threads. These are used when all pool threads are in use, and will stick around until load dies down. The theory is that during high load you'll have more threads available, and during low load you'll only have the normal pool threads sticking around.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@19254 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years ago Minor cleanups and error handling for app_dial #6935 (casper)
BJ Weschke [Tue, 11 Apr 2006 16:15:11 +0000 (16:15 +0000)]
 Minor cleanups and error handling for app_dial #6935 (casper)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@19253 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoremove an unused function
Luigi Rizzo [Tue, 11 Apr 2006 16:00:23 +0000 (16:00 +0000)]
remove an unused function

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@19226 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoas discussed with kevin, move
Luigi Rizzo [Tue, 11 Apr 2006 15:55:56 +0000 (15:55 +0000)]
as discussed with kevin, move
ast_register_atexit()/ ast_unregister_atexit() into asterisk.h
These are general functions, not restricted to modules, so move
them in a more proper place.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@19223 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agouse proper type
Kevin P. Fleming [Tue, 11 Apr 2006 15:52:06 +0000 (15:52 +0000)]
use proper type

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@19222 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years ago Provide the ability to read extension number after name #6938 (delink)
BJ Weschke [Tue, 11 Apr 2006 15:38:17 +0000 (15:38 +0000)]
 Provide the ability to read extension number after name #6938 (delink)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@19221 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agonormalize code preparing for loader changes
Luigi Rizzo [Tue, 11 Apr 2006 15:19:34 +0000 (15:19 +0000)]
normalize code preparing for loader changes

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@19220 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoremove unused fields
Luigi Rizzo [Tue, 11 Apr 2006 15:09:24 +0000 (15:09 +0000)]
remove unused fields

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@19219 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agonormalize code in preparation to module changes
Luigi Rizzo [Tue, 11 Apr 2006 10:01:00 +0000 (10:01 +0000)]
normalize code in preparation to module changes

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@19189 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agostaticize a function, and normalize code in preparation to module changes.
Luigi Rizzo [Tue, 11 Apr 2006 10:00:24 +0000 (10:00 +0000)]
staticize a function, and normalize code in preparation to module changes.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@19188 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agomISDN Messages must be freed with free_msg \!\!
Christian Richter [Tue, 11 Apr 2006 08:31:19 +0000 (08:31 +0000)]
mISDN Messages must be freed with free_msg \!\!

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@19160 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years ago- First stab at removing debug and ignore variables that
Olle Johansson [Tue, 11 Apr 2006 06:09:01 +0000 (06:09 +0000)]
- First stab at removing debug and ignore variables that
  we pass along function calls, instead implementing them as
  flags on the incoming packet.
- Adding forward declarations of handle_request functions

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@19128 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoAdd new documentation files to index file 00README.1st and to doxygen
Olle Johansson [Tue, 11 Apr 2006 05:54:55 +0000 (05:54 +0000)]
Add new documentation files to index file 00README.1st and to doxygen

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@19097 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoBugs 6883, 6930: compiler warnings
Tilghman Lesher [Tue, 11 Apr 2006 05:37:05 +0000 (05:37 +0000)]
Bugs 6883, 6930: compiler warnings

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@19095 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoData stores do not need a lock. As well change the way they are removed from the...
Joshua Colp [Tue, 11 Apr 2006 03:50:17 +0000 (03:50 +0000)]
Data stores do not need a lock. As well change the way they are removed from the channel when it is destroyed (thanks Russell Wussell) and finally... because C++ is silly... change our list macro info thing to be "entry" instead of "list".

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@19062 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoMerged revisions 19008 via svnmerge from
BJ Weschke [Tue, 11 Apr 2006 01:12:13 +0000 (01:12 +0000)]
Merged revisions 19008 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r19008 | bweschke | 2006-04-10 20:05:01 -0500 (Mon, 10 Apr 2006) | 3 lines

 When using the silence detector in ast_play_and_record() and ast_play_and_prepend(), the truncation code never gets called to remove the detected silence, because the value of res is zero when control gets to that point. #6903 w/some mods (softins)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@19009 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoPresenting a revised data stores and oh my, a generic speech recognition API! I wonde...
Joshua Colp [Mon, 10 Apr 2006 23:29:50 +0000 (23:29 +0000)]
Presenting a revised data stores and oh my, a generic speech recognition API! I wonder what we can do with this now...

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18979 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoremove support for BYEXTENSION (which nobody even knows about anymore)
Kevin P. Fleming [Mon, 10 Apr 2006 23:01:22 +0000 (23:01 +0000)]
remove support for BYEXTENSION (which nobody even knows about anymore)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18977 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoFixup fixup - add some debugging and error handling
Olle Johansson [Mon, 10 Apr 2006 20:18:14 +0000 (20:18 +0000)]
Fixup fixup - add some debugging and error handling

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18940 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoResolve conflicts, prepare for next batch of conflicts
Olle Johansson [Mon, 10 Apr 2006 19:55:39 +0000 (19:55 +0000)]
Resolve conflicts, prepare for next batch of conflicts

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18909 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoMerged revisions 18866 via svnmerge from
BJ Weschke [Mon, 10 Apr 2006 17:32:29 +0000 (17:32 +0000)]
Merged revisions 18866 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r18866 | bweschke | 2006-04-10 12:29:51 -0500 (Mon, 10 Apr 2006) | 2 lines

 Don't say that we can pass an 'exten' argument in the documentation of Park() when we really cannot. #6902 (opsys)

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18867 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agofixed some issues, that appear at higher load
Christian Richter [Mon, 10 Apr 2006 16:50:20 +0000 (16:50 +0000)]
fixed some issues, that appear at higher load

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18835 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agowe send nearly everytime a RELEASE, only if we for sure know, that it's a TE and...
Christian Richter [Mon, 10 Apr 2006 14:09:17 +0000 (14:09 +0000)]
we send nearly everytime a RELEASE, only if we for sure know, that it's a TE and we did create the call we don't to hear the Inband Info

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18800 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoMaking sure that cancel destroy is only executed once...
Olle Johansson [Mon, 10 Apr 2006 13:43:54 +0000 (13:43 +0000)]
Making sure that cancel destroy is only executed once...

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18799 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoSmall fix
Olle Johansson [Mon, 10 Apr 2006 13:19:36 +0000 (13:19 +0000)]
Small fix

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18797 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years ago- staticize gettag() complete_sip_peer() get_calleridname() arguments;
Luigi Rizzo [Mon, 10 Apr 2006 12:20:57 +0000 (12:20 +0000)]
- staticize gettag() complete_sip_peer() get_calleridname()  arguments;
- use strsep() instead of strchr() where appropriate
- constify some args and add comments.
- remove a conditional near line 1940 - we already know what to use.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18793 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years ago- constification of some functions (args and return values):
Luigi Rizzo [Mon, 10 Apr 2006 11:57:40 +0000 (11:57 +0000)]
- constification of some functions (args and return values):
        transmit_response_reliable()
        hangup_cause2sip()
- remove useless braces;
- add comments on some slightly cryptic code segments
- mark XXX possible critical pieces of code.
- remove an unneeded string termination after ast_copy_string
- mark usage of some rarely used functions;
- use strsep() instead of emulating it inline;
- replace magic constants with sizeof(array)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18792 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years ago- localize 'struct cfalias' into the only function using it;
Luigi Rizzo [Mon, 10 Apr 2006 11:36:02 +0000 (11:36 +0000)]
- localize 'struct cfalias' into the only function using it;
- remove duplicate code to walk through sdp packets, replacing
  sdpLineNum_iterator_init(&foo); with  "foo = 0";
- remove duplicate code to test ast_test_flag(&p->flags[0], SIP_NAT_ROUTE);

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18791 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoconstify get_sdp*() and friends.
Luigi Rizzo [Mon, 10 Apr 2006 11:19:14 +0000 (11:19 +0000)]
constify get_sdp*() and friends.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18790 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoconstify get_header(), which let me find out and fix one bug (overwriting
Luigi Rizzo [Mon, 10 Apr 2006 11:04:04 +0000 (11:04 +0000)]
constify get_header(), which let me find out and fix one bug (overwriting
a string in the buffer) and finding out another one (not fixed yet,
just marked XXX).

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18789 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years ago- describe how sip packets are stored internally;
Luigi Rizzo [Mon, 10 Apr 2006 10:40:13 +0000 (10:40 +0000)]
- describe how sip packets are stored internally;
- remove useless braces or local variables;
- simplify some code sequences;
- mark with XXX a possible locking issue.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18788 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agostruct sip_request cleanup:
Luigi Rizzo [Mon, 10 Apr 2006 10:30:38 +0000 (10:30 +0000)]
struct sip_request cleanup:
- remove a debug field that was read but never set, so it was basically
  unused as well as the code testing it (also removed);

- make scalar fields contiguous so any array overflow will be
  less harmful;

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18787 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agomore cleanup: remove useless braces, replace "if" with "?",
Luigi Rizzo [Mon, 10 Apr 2006 10:22:42 +0000 (10:22 +0000)]
more cleanup: remove useless braces, replace "if" with "?",
localize a couple of variables, remove trailing whitespace.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18786 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoRe-instate removed comment
Olle Johansson [Mon, 10 Apr 2006 10:01:14 +0000 (10:01 +0000)]
Re-instate removed comment

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18785 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoanother batch of minor code simplifications
Luigi Rizzo [Mon, 10 Apr 2006 09:53:22 +0000 (09:53 +0000)]
another batch of minor code simplifications
(moving repeated expressions into a function, const on
some arguments)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18784 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoBug 6829 - asprintf for Solaris
Tilghman Lesher [Mon, 10 Apr 2006 07:48:52 +0000 (07:48 +0000)]
Bug 6829 - asprintf for Solaris

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18755 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoremove a couple more unnecessary "out of memory" error messages
Russell Bryant [Mon, 10 Apr 2006 02:19:58 +0000 (02:19 +0000)]
remove a couple more unnecessary "out of memory" error messages

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18723 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agouse ast_*alloc and don't create duplicated error messages.
Russell Bryant [Mon, 10 Apr 2006 02:15:47 +0000 (02:15 +0000)]
use ast_*alloc and don't create duplicated error messages.

... as stated in the coding guidelines.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18722 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoInstead of using strncpy, use ast_copy_string. Also, in the case of copying a
Russell Bryant [Mon, 10 Apr 2006 02:05:59 +0000 (02:05 +0000)]
Instead of using strncpy, use ast_copy_string.  Also, in the case of copying a
constant string into a buffer that we know is big enough, don't use a length
limited copy at all, use strcpy.

... as stated in the coding guidelines.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18721 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agorun the module through indent to fix the formatting issues that violate the
Russell Bryant [Mon, 10 Apr 2006 02:01:39 +0000 (02:01 +0000)]
run the module through indent to fix the formatting issues that violate the
coding guidelines

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18704 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agofix typo in the provided indent command
Russell Bryant [Mon, 10 Apr 2006 01:54:13 +0000 (01:54 +0000)]
fix typo in the provided indent command

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18694 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoadd back braces that were removed in a recent commit that leave a bunch of
Russell Bryant [Mon, 10 Apr 2006 01:51:47 +0000 (01:51 +0000)]
add back braces that were removed in a recent commit that leave a bunch of
nested statements in a block without branches, which is a violation of the
coding guidelines.

As a matter of fact, this module violates the coding guidelines in multiple
ways that including formatting and code issues.  In my opinion, this module
should not have been merged into the trunk in this form.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18693 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoa bunch of trivial code normalizations (removal of unnecessary
Luigi Rizzo [Sun, 9 Apr 2006 23:16:29 +0000 (23:16 +0000)]
a bunch of trivial code normalizations (removal of unnecessary
casts and parentheses, formatting fixes, pointing out replicated
code and so on). No functional changes.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18666 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agorename FR_SET_BUF to AST_FRAME_SET_BUFFER
Luigi Rizzo [Sun, 9 Apr 2006 22:31:38 +0000 (22:31 +0000)]
rename FR_SET_BUF to AST_FRAME_SET_BUFFER

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18639 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoIssue 6917 - some cleanups for res_config_pgsql.c (mithraen)
Olle Johansson [Sun, 9 Apr 2006 18:57:25 +0000 (18:57 +0000)]
Issue 6917 - some cleanups for res_config_pgsql.c (mithraen)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18607 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoIssue 6919 - clarify error message
Olle Johansson [Sun, 9 Apr 2006 18:53:46 +0000 (18:53 +0000)]
Issue 6919 - clarify error message

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18603 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoupdate module license key text and update loader to accept it
Kevin P. Fleming [Sat, 8 Apr 2006 22:37:30 +0000 (22:37 +0000)]
update module license key text and update loader to accept it

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18574 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoa few cleanups from the last commit
Kevin P. Fleming [Sat, 8 Apr 2006 22:16:34 +0000 (22:16 +0000)]
a few cleanups from the last commit

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18572 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agosince the module API is changing, it's a good time to const-ify the description(...
Kevin P. Fleming [Sat, 8 Apr 2006 22:01:19 +0000 (22:01 +0000)]
since the module API is changing, it's a good time to const-ify the description() and key() return values

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18552 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agomerge rizzo's codec module rework (very similar to the format module rework)
Kevin P. Fleming [Sat, 8 Apr 2006 21:40:57 +0000 (21:40 +0000)]
merge rizzo's codec module rework (very similar to the format module rework)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18541 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoMerged revisions 18494 via svnmerge from
Tilghman Lesher [Sat, 8 Apr 2006 19:22:29 +0000 (19:22 +0000)]
Merged revisions 18494 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r18494 | tilghman | 2006-04-08 14:20:45 -0500 (Sat, 08 Apr 2006) | 2 lines

Bug 6914 - .txt file fails to rename on operator out

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18495 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agofix bug in smdi config parsing (issue #6908)
Russell Bryant [Sat, 8 Apr 2006 19:16:38 +0000 (19:16 +0000)]
fix bug in smdi config parsing (issue #6908)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18493 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoremove traces of "look", something that does not exist in the tree
Russell Bryant [Sat, 8 Apr 2006 19:13:37 +0000 (19:13 +0000)]
remove traces of "look", something that does not exist in the tree
(issue #6904)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18492 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoMerged revisions 18436 via svnmerge from
Tilghman Lesher [Fri, 7 Apr 2006 22:11:12 +0000 (22:11 +0000)]
Merged revisions 18436 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r18436 | tilghman | 2006-04-07 17:07:38 -0500 (Fri, 07 Apr 2006) | 2 lines

Bug 6913 - fix for possible buffer overflow

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18437 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years ago-Fixing some debugging messages in history and console
Olle Johansson [Fri, 7 Apr 2006 20:19:44 +0000 (20:19 +0000)]
-Fixing some debugging messages in history and console

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18403 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoAdd history events for re-invites
Olle Johansson [Fri, 7 Apr 2006 19:46:50 +0000 (19:46 +0000)]
Add history events for re-invites
(need to nail this issue...)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18373 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agomake history easier to read
Olle Johansson [Fri, 7 Apr 2006 19:36:44 +0000 (19:36 +0000)]
make history easier to read

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18371 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoAdd some more information to SIP history
Olle Johansson [Fri, 7 Apr 2006 19:25:19 +0000 (19:25 +0000)]
Add some more information to SIP history

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18370 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoIssue #6899 - remove OSP support code from chan_sip.c and app_dial.c
Olle Johansson [Fri, 7 Apr 2006 19:11:22 +0000 (19:11 +0000)]
Issue #6899 - remove OSP support code from chan_sip.c and app_dial.c
- implement all functions through internal APIs in res_osp.c and app_osplookup.c
(homesick)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18369 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoHmm. What is that keyword?? Let me see... Wait... Maybe... Ahh! OOPS!
Olle Johansson [Fri, 7 Apr 2006 18:52:23 +0000 (18:52 +0000)]
Hmm. What is that keyword?? Let me see... Wait... Maybe... Ahh! OOPS!

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18342 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agochange a couple uses of !strlen() to ast_strlen_zero(). Oddly enough, one of
Russell Bryant [Fri, 7 Apr 2006 16:28:50 +0000 (16:28 +0000)]
change a couple uses of !strlen() to ast_strlen_zero().  Oddly enough, one of
these used to be this way and got changed ...

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18309 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years ago- sip_alloc failures are also caused by too few available file descriptors, so we...
Olle Johansson [Fri, 7 Apr 2006 16:22:28 +0000 (16:22 +0000)]
- sip_alloc failures are also caused by too few available file descriptors, so we can not
  open socket for RTP (audio/video/rtcp).
  Error message change to clarify.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18307 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years ago- Add cause code for format error
Olle Johansson [Fri, 7 Apr 2006 14:42:25 +0000 (14:42 +0000)]
- Add cause code for format error
- Change to SWITCH_CONGESTION instead of CONGESTION
(imported from 1.2)

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18262 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoImport of revistion 18250 from 1.2
Olle Johansson [Fri, 7 Apr 2006 14:30:14 +0000 (14:30 +0000)]
Import of revistion 18250 from 1.2
- Fix minor memory leak
- Add proper cause codes on memory allocation failures

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18261 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agosorry litle mistake
Christian Richter [Fri, 7 Apr 2006 12:03:51 +0000 (12:03 +0000)]
sorry litle mistake

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18221 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agogit-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18192 65c4cc65-6c06-0410...
Christian Richter [Fri, 7 Apr 2006 09:46:38 +0000 (09:46 +0000)]
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18192 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agofixed a bridging-endless-loop also fixed the rdnis is not exported issue
Christian Richter [Fri, 7 Apr 2006 09:31:27 +0000 (09:31 +0000)]
fixed a bridging-endless-loop also fixed the rdnis is not exported issue

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18190 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoIssue #6674: Set the URI correctly on BYEs when we have an incoming call
Olle Johansson [Fri, 7 Apr 2006 08:19:52 +0000 (08:19 +0000)]
Issue #6674: Set the URI correctly on BYEs when we have an incoming call
Reported by aubergine, fix by oej

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18161 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoIssue #6580 - Unify directory definitions to one section of Makefile (casper)
Olle Johansson [Fri, 7 Apr 2006 07:04:05 +0000 (07:04 +0000)]
Issue #6580 - Unify directory definitions to one section of Makefile (casper)
- Maybe we should define proper directories for OS/X too?
- Should OpenBSD and NetBSD follow the FreeBSD rules?

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18130 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoMerged revisions 18087 via svnmerge from
Kevin P. Fleming [Thu, 6 Apr 2006 22:16:23 +0000 (22:16 +0000)]
Merged revisions 18087 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r18087 | kpfleming | 2006-04-06 17:04:58 -0500 (Thu, 06 Apr 2006) | 3 lines

don't try to support 'i' or 'r' options if chan_zap is not loaded, and warn the user when they attempt to use them (issue #6675)
update application help text to more clearly define when Zaptel and chan_zap are required

........

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18090 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoCosmetic update for outbound REFERs
Olle Johansson [Thu, 6 Apr 2006 21:49:24 +0000 (21:49 +0000)]
Cosmetic update for outbound REFERs

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18060 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoAdd "NewChan" event to history to track the birth of a new ast_chan from a
Olle Johansson [Thu, 6 Apr 2006 21:33:39 +0000 (21:33 +0000)]
Add "NewChan" event to history to track the birth of a new ast_chan from a
SIP invite

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18059 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoImproved handling of 491 responses
Olle Johansson [Thu, 6 Apr 2006 21:29:54 +0000 (21:29 +0000)]
Improved handling of 491 responses

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18058 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoSmall changes to parse_sip_options
Olle Johansson [Thu, 6 Apr 2006 21:18:12 +0000 (21:18 +0000)]
Small changes to parse_sip_options

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18057 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoSmall fixes to handle_request_invite
Olle Johansson [Thu, 6 Apr 2006 21:13:32 +0000 (21:13 +0000)]
Small fixes to handle_request_invite

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18056 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years ago- Don't change channel direction on re-invites
Olle Johansson [Thu, 6 Apr 2006 21:01:06 +0000 (21:01 +0000)]
- Don't change channel direction on re-invites
- Don't re-initialize initreq on re-invites

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18033 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years ago More code optimizations. Thanks kpfleming!
BJ Weschke [Thu, 6 Apr 2006 20:37:29 +0000 (20:37 +0000)]
 More code optimizations. Thanks kpfleming!

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18025 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years ago- Implement handle_request_notify to handle incoming NOTIFY requests
Olle Johansson [Thu, 6 Apr 2006 20:36:25 +0000 (20:36 +0000)]
- Implement handle_request_notify to handle incoming NOTIFY requests
  and respond properly to them.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18024 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years ago Fix a problem where if the channel was hungup during detection, the application...
BJ Weschke [Thu, 6 Apr 2006 20:23:18 +0000 (20:23 +0000)]
 Fix a problem where if the channel was hungup during detection, the application wouldn't block indefinitely looking for another frame from that channel. Don't try to do frame size analysis on a frame that isn't voice, only report DEBUG and VERBOSE msgs to the logger channels when the DEBUG and VERBOSE settings are high enough to require it, and some other minor cleanups.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18023 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoImplement a handle_response_refer function to take care of responses
Olle Johansson [Thu, 6 Apr 2006 20:16:08 +0000 (20:16 +0000)]
Implement a handle_response_refer function to take care of responses
to outbound REFERS. Not that common, but still needed.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@18022 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agoChange transmit_notify_sipfrag to handle other messages than 200 OK, needed for
Olle Johansson [Thu, 6 Apr 2006 19:59:21 +0000 (19:59 +0000)]
Change transmit_notify_sipfrag to handle other messages than 200 OK, needed for
SIPtransfer improvement

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@17993 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years ago- doxygen
Olle Johansson [Thu, 6 Apr 2006 19:39:27 +0000 (19:39 +0000)]
- doxygen
- debug message control

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@17991 65c4cc65-6c06-0410-ace0-fbb531ad65f3

16 years agostructures can be copied with the '=' operators, no need to
Luigi Rizzo [Thu, 6 Apr 2006 19:31:59 +0000 (19:31 +0000)]
structures can be copied with the '=' operators, no need to
use memcpy.

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@17988 65c4cc65-6c06-0410-ace0-fbb531ad65f3