Tilghman Lesher [Thu, 15 Nov 2007 00:01:22 +0000 (00:01 +0000)]
Merged revisions 89275 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r89275 | tilghman | 2007-11-14 17:23:58 -0600 (Wed, 14 Nov 2007) | 5 lines
When a recording ends with '#', we are improperly trimming an extra 200ms from the recording.
Reported by: sim
Patch by: tilghman
Closes issue #11247
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89276
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Wed, 14 Nov 2007 23:08:54 +0000 (23:08 +0000)]
Typo
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89274
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Wed, 14 Nov 2007 22:59:05 +0000 (22:59 +0000)]
Add callerid to the Hangup manager event.
Reported by: outtolunc
Patch by: outtolunc
Closes issue #11248
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89273
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Steve Murphy [Wed, 14 Nov 2007 18:05:50 +0000 (18:05 +0000)]
Rescaled the weights of the patterns to give something more independent of pattern length; and make . less likely to win. Question: which should win for
14102241145-- _1xxxxxxx. or _XXXXXXXXXXX -- right now, the pure X pattern will win.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89272
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Steve Murphy [Wed, 14 Nov 2007 15:43:30 +0000 (15:43 +0000)]
A further problem highlighted by 11233 has been resolved; a certain combination of patterns in a certain order, led to a malformed trie, due to a ptr not being initialized in the loop. Also, some tree printing prettifications.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89271
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Wed, 14 Nov 2007 15:13:22 +0000 (15:13 +0000)]
One more typo in config.c; and missed conversions due to the constifying of ast_variable_new parameters
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89270
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Wed, 14 Nov 2007 14:46:45 +0000 (14:46 +0000)]
Typo
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89269
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Luigi Rizzo [Wed, 14 Nov 2007 13:18:40 +0000 (13:18 +0000)]
make the 'name' and 'value' fields in ast_variable const char *
This prevents modifying the strings in the stored variables,
and catched a few instances where this was actually done.
Given the differences between trunk and 1.4 (and the fact that this
is effectively an API change) it is better to fix 1.4 independently.
These are
chan_sip.c::sip_register()
chan_skinny.c:: near line 2847
config.c:: near line 1774
logger.c::make_components()
res_adsi.c:: near line 1049
I may have missed some instances for modules that do not build here.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89268
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Wed, 14 Nov 2007 03:22:09 +0000 (03:22 +0000)]
Fix up various coding guidelines issues ...
- handle memory allocation failures
- add an ast_ prefix to a publicly exported function
- put curly braces in the right places
- add a bunch of spaces where they should be be used
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89266
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Wed, 14 Nov 2007 02:57:13 +0000 (02:57 +0000)]
- Use the ARRAY_LEN macro in a couple places
- return errors from load_module / unload_module
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89265
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Wed, 14 Nov 2007 01:40:47 +0000 (01:40 +0000)]
Use BEGIN_OPTIONS / END_OPTIONS to make the syntax highlighting in my editor happy
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89264
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Wed, 14 Nov 2007 01:35:28 +0000 (01:35 +0000)]
Instead of reserving 800 bytes for periodic announcements, use an array of
ast_str pointers and only alloate space for the strings as needed.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89263
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Joshua Colp [Wed, 14 Nov 2007 01:16:50 +0000 (01:16 +0000)]
Merged revisions 89260 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r89260 | file | 2007-11-13 21:15:12 -0400 (Tue, 13 Nov 2007) | 4 lines
Return the proper value when the srv_callback function executes properly.
(closes issue #11240)
Reported by: jtodd
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89262
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Wed, 14 Nov 2007 01:15:26 +0000 (01:15 +0000)]
Convert most of the strings in the call_queue struct to use stringfields.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89261
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Kevin P. Fleming [Wed, 14 Nov 2007 00:54:38 +0000 (00:54 +0000)]
use simpler technique for removing known entries from lists
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89259
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Wed, 14 Nov 2007 00:33:52 +0000 (00:33 +0000)]
- Simplify removing an item from a list
- move a verbose message to after the item is added to the list
- make use of the ARRAY_LEN macro in one spot
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89258
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Steve Murphy [Tue, 13 Nov 2007 23:43:41 +0000 (23:43 +0000)]
This hopefully will fix the re-opened 11233. Hadn't covered the case of a context with no patterns. (blush)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89257
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Steve Murphy [Tue, 13 Nov 2007 21:19:11 +0000 (21:19 +0000)]
closes issue #11233 -- where some fine points in the algorithm to build the tree needed to be corrected. Many thanks for the test case, jtodd
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89256
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Jason Parker [Tue, 13 Nov 2007 21:08:23 +0000 (21:08 +0000)]
Blocked revisions 89254 via svnmerge
(closes issue #11238)
........
r89254 | qwell | 2007-11-13 15:07:08 -0600 (Tue, 13 Nov 2007) | 4 lines
Fix building on newer systems which require a third arg to open() when using O_CREAT.
Issue 11238, reported by puzzled.
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89255
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Tue, 13 Nov 2007 21:01:14 +0000 (21:01 +0000)]
This fixes a build error on my mac. It also works on my linux box. Let me
know if it breaks any other platform ...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89253
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Tue, 13 Nov 2007 20:56:32 +0000 (20:56 +0000)]
Fix a typo pointed out by outtolunc, thanks :)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89252
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Tue, 13 Nov 2007 20:53:49 +0000 (20:53 +0000)]
- Convert initialization of a struct to C99 style instead of GNU style
- Fix a minor spelling error in a comment
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89251
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Tue, 13 Nov 2007 20:30:13 +0000 (20:30 +0000)]
Update the ParkedCall application to grab the first available parked call if no
parked extension is provided as an argument.
(closes issue #10803)
Reported by: outtolunc
Patches:
res_features-parkedcall-any.diff4 uploaded by outtolunc (license 237)
- modified by me to work a bit differently ...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89250
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Jason Parker [Tue, 13 Nov 2007 19:48:41 +0000 (19:48 +0000)]
Merged revisions 89248 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
(closes issue #11237)
........
r89248 | qwell | 2007-11-13 13:47:45 -0600 (Tue, 13 Nov 2007) | 7 lines
Revert change from revision 67064.
It is documented behavior that if a parking extension already exists while using PARKINGEXTEN,
dialplan execution will continue. If blind transferring to a Park with PARKINGEXTEN, you
must keep this in mind, and handle the failure yourself.
Issue 11237, reported by jon.
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89249
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Tue, 13 Nov 2007 17:41:02 +0000 (17:41 +0000)]
Merged revisions 89246 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r89246 | tilghman | 2007-11-13 11:34:11 -0600 (Tue, 13 Nov 2007) | 2 lines
If we set a value for qualify, we should actually pay attention to it, instead of overriding the value
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89247
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Mark Michelson [Tue, 13 Nov 2007 16:03:10 +0000 (16:03 +0000)]
Merged revisions 89241 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r89241 | mmichelson | 2007-11-13 10:02:02 -0600 (Tue, 13 Nov 2007) | 5 lines
Reverting commit made in revision 89205 since it is unnecessary.
Thanks to Kevin for pointing this out
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89242
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Tue, 13 Nov 2007 14:03:34 +0000 (14:03 +0000)]
Merged revisions 89239 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r89239 | tilghman | 2007-11-13 07:51:53 -0600 (Tue, 13 Nov 2007) | 4 lines
Debugging is running into the 16-lock limit. Increase to avoid.
(This define is only effective when debugging is turned on, so there's
no effect for most installations.)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89240
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Mark Michelson [Tue, 13 Nov 2007 01:19:53 +0000 (01:19 +0000)]
There is the potential to copy uninitialized memory into the mixmonitor->post_process
string. This fix prevents that.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89207
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Mark Michelson [Tue, 13 Nov 2007 00:57:34 +0000 (00:57 +0000)]
Merged revisions 89205 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r89205 | mmichelson | 2007-11-12 18:56:46 -0600 (Mon, 12 Nov 2007) | 5 lines
Some sanity checking for MixMonitor. If only 1 argument is given, then the args.options
and args.post_process strings are uninitialized and could contain garbage. This change
handles this situation properly by only using arguments that we have parsed.
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89206
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Jason Parker [Tue, 13 Nov 2007 00:19:50 +0000 (00:19 +0000)]
oops, somebody left out the directory here...
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89203
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Jason Parker [Mon, 12 Nov 2007 23:44:20 +0000 (23:44 +0000)]
Doxygen fixes.
Also fix a common typo I kept seeing (arguement) in various files.
Closes issue #11222, patch by snuffy (with arguement > argument by me).
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89202
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Steve Murphy [Mon, 12 Nov 2007 23:33:55 +0000 (23:33 +0000)]
Don't forget the ASTERISK_VERSION for the sake of the mtx_prof stuff.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89201
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Steve Murphy [Mon, 12 Nov 2007 21:50:02 +0000 (21:50 +0000)]
Thanks to snuffy for this doxygen update to hashtab.h; closes issue #11223
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89198
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Steve Murphy [Mon, 12 Nov 2007 20:49:27 +0000 (20:49 +0000)]
Thanks to snuff-work, who brought up that these fixes might need to be made.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89196
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Jason Parker [Mon, 12 Nov 2007 20:48:57 +0000 (20:48 +0000)]
Merged revisions 89194 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r89194 | qwell | 2007-11-12 14:46:52 -0600 (Mon, 12 Nov 2007) | 1 line
Fix a typo pointed out by De_Mon on #asterisk-dev
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89195
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Mon, 12 Nov 2007 20:29:38 +0000 (20:29 +0000)]
Blocked revisions 89191 via svnmerge
........
r89191 | tilghman | 2007-11-12 14:16:18 -0600 (Mon, 12 Nov 2007) | 5 lines
If two config writes collide, file corruption could result. Use a mkstemp() file, instead.
Reported by: paravoid
Patch by: tilghman
Closes issue #10781
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89193
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Kevin P. Fleming [Mon, 12 Nov 2007 20:16:13 +0000 (20:16 +0000)]
(closes issue #11221)
Reported by: eliel
Patches:
utils.Makefile.patch uploaded by eliel (modified by me) (license 64)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89190
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Steve Murphy [Mon, 12 Nov 2007 18:44:36 +0000 (18:44 +0000)]
Based on a note in asterisk-dev by Brian Capouch, I determined I too agressive in not initializing arrays passed to pbx_substitute_variables_xxxx; I reviewed the code (again) and hopefully found every possible spot where substitute_variables is called conditionally, and made sure the char array involved was set to a null string.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89186
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Mon, 12 Nov 2007 17:44:04 +0000 (17:44 +0000)]
Merged revisions 89184 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r89184 | tilghman | 2007-11-12 11:29:17 -0600 (Mon, 12 Nov 2007) | 5 lines
Fix two cases of memory corruption caused by background threads.
Reported by: atis
Patch by: tilghman
Fixes issue #10923
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89185
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Christian Richter [Mon, 12 Nov 2007 13:36:45 +0000 (13:36 +0000)]
Merged revisions 89173 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r89173 | crichter | 2007-11-12 12:26:48 +0100 (Mo, 12 Nov 2007) | 1 line
if we're NT and no number was dialed and overlapdial is set, we wait for the ISDN timeout instead of starting our own timer. added a comment for the misdn.conf.sample for the overlapdial config option.
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89179
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Christian Richter [Mon, 12 Nov 2007 13:33:13 +0000 (13:33 +0000)]
Merged revisions 89172 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r89172 | crichter | 2007-11-12 12:23:57 +0100 (Mo, 12 Nov 2007) | 1 line
added restart all interfaces Restart_Indicator, to automatically send a RESTART after the L2 of a PTP Port comes up. Also fixed some places where we have send a RELEASE without need for it.
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89178
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Joshua Colp [Mon, 12 Nov 2007 13:26:45 +0000 (13:26 +0000)]
Fix building on FreeBSD by including/not including some headers.
(closes issue #11218)
Reported by: ys
Patches:
trunk89169.diff uploaded by ys (license 281)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89177
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Christian Richter [Mon, 12 Nov 2007 13:22:17 +0000 (13:22 +0000)]
Merged revisions 89171 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r89171 | crichter | 2007-11-12 12:13:13 +0100 (Mo, 12 Nov 2007) | 1 line
fixed a state/event issue with overlapdial=yes when no extension matched. removed the general sending of a RELEASE_COMPLETE when we receive a RELEASE, this is done by mISDNuser/mISDN. This makes it possible to use asterisk-1.4 with mISDN trunk, but requires users of mISDN/mISDNuser-1.1.X to upgrade to at least mISDNuser-1.1.6 (when using the NT mode at all)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89176
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Christian Richter [Mon, 12 Nov 2007 13:03:00 +0000 (13:03 +0000)]
Merged revisions 89170 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r89170 | crichter | 2007-11-12 10:57:23 +0100 (Mo, 12 Nov 2007) | 1 line
fixed the support for CW and therefore for the reject_cause option.
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89175
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Christian Richter [Mon, 12 Nov 2007 12:49:19 +0000 (12:49 +0000)]
Merged revisions 89169 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r89169 | crichter | 2007-11-12 10:45:36 +0100 (Mo, 12 Nov 2007) | 1 line
aded ntkeepcalls option, to avoid droÃpping calls when the L2 goes down on a PTP link. There are some pbx which do turn off the L1 for a very short while and restart it immediately. normally T310 should be started and after 10 seconds or so the calls should be dropped, this is a simple fix wihtout this timer.
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89174
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Jason Parker [Fri, 9 Nov 2007 18:57:21 +0000 (18:57 +0000)]
Add usbradio.conf.sample from branches/1.4/configs - r84162.
It was mistakenly deleted in 1.4 without ever being merged to trunk.
Reported by eliel on #asterisk-dev.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89132
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Jason Parker [Fri, 9 Nov 2007 16:32:01 +0000 (16:32 +0000)]
Fix a few potential deadlocks in cdr_sqlite3_custom.
(also rename sample config to .sample)
Closes issue #11208, patch by Laureano.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89130
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Steve Murphy [Fri, 9 Nov 2007 16:00:22 +0000 (16:00 +0000)]
This is the perhaps the biggest, boldest, most daring change I've ever committed to trunk. Forgive me in advance any disruption this may cause, and please, report any problems via the bugtracker. The upside is that this can speed up large dialplans by 20 times (or more). Context, extension, and priority matching are all fairly constant-time searches. I introduce here my hashtables (hashtabs), and a regression for them. I would have used the ast_obj2 tables, but mine are resizeable, and don't need the object destruction capability. The hashtab stuff is well tested and stable. I introduce a data structure, a trie, for extension pattern matching, in which knowledge of all patterns is accumulated, and all matches can be found via a single traversal of the tree. This is per-context. The trie is formed on the first lookup attempt, and stored in the context for future lookups. Destruction routines are in place for hashtabs and the pattern match trie. You can see the contents of the pattern match trie by using the 'dialplan show' cli command when 'core set debug' has been done to put it in debug mode. The pattern tree traversal only traverses those parts of the tree that are interesting. It uses a scoreboard sort of approach to find the best match. The speed of the traversal is more a function of the length of the pattern than the number of patterns in the tree. The tree also contains the CID matching patterns. See the source code comments for details on how everything works. I believe the approach general enough that any issues that might come up involving fine points in the pattern matching algorithm, can be solved by just tweaking things. We shall see. The current pattern matcher is fairly involved, and replicating every nuance of it is difficult. If you find and report problems, I will try to resolve than as quickly as I can. The trie and hashtabs are added to the existing context and exten structs, and none of the old machinery has been removed for the sake of the multitude of functions that use them. In the future, we can (maybe) weed out the linked lists and save some space.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89129
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Jason Parker [Thu, 8 Nov 2007 23:53:00 +0000 (23:53 +0000)]
Merged revisions 89125 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
(closes issue #11203)
........
r89125 | qwell | 2007-11-08 17:52:35 -0600 (Thu, 08 Nov 2007) | 4 lines
Properly say the seconds here..
Issue 11203, fix described by vma.
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89126
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Jason Parker [Thu, 8 Nov 2007 23:38:30 +0000 (23:38 +0000)]
Add check_hangup() method to pbx_lua, which can be used to check whether it is time to hangup a channel.
Closes issue #11202, patch by mnicholson
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89124
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Mark Michelson [Thu, 8 Nov 2007 22:33:59 +0000 (22:33 +0000)]
app_voicemail failed to build when compiling with IMAP_STORAGE
Now it does not.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89123
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Mark Michelson [Thu, 8 Nov 2007 21:31:06 +0000 (21:31 +0000)]
AST_LIST_REMOVE_CURRENT takes only one argument.
Thanks to snuffy for pointing this out on IRC
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89122
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Joshua Colp [Thu, 8 Nov 2007 21:27:37 +0000 (21:27 +0000)]
Make func_env build again.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89121
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Mark Michelson [Thu, 8 Nov 2007 21:01:02 +0000 (21:01 +0000)]
Merged revisions 89119 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r89119 | mmichelson | 2007-11-08 15:00:08 -0600 (Thu, 08 Nov 2007) | 7 lines
Rework of the commit I made yesterday to use the already built-in
ast_uri_decode function as opposed to my home-rolled one. Also added
comments.
Thanks to oej for pointing me in the right direction
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89120
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Kevin P. Fleming [Thu, 8 Nov 2007 20:39:41 +0000 (20:39 +0000)]
convert this code to a more efficient idiom
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89118
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Jason Parker [Thu, 8 Nov 2007 18:49:08 +0000 (18:49 +0000)]
Change a warning to a notice. Issue #11195, patch by eliel
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89117
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Jason Parker [Thu, 8 Nov 2007 18:48:15 +0000 (18:48 +0000)]
Merged revisions 89115 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
(closes issue #11195)
........
r89115 | qwell | 2007-11-08 12:45:15 -0600 (Thu, 08 Nov 2007) | 4 lines
Avoid warnings on load when using sample configuration files.
Issue 11195, patch by eliel.
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89116
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Thu, 8 Nov 2007 17:32:15 +0000 (17:32 +0000)]
Add the FILE() dialplan function and deprecate ReadFile.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89114
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Thu, 8 Nov 2007 17:28:45 +0000 (17:28 +0000)]
Fix missed conversion to linkedlists macro change
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89113
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Mark Michelson [Thu, 8 Nov 2007 16:51:08 +0000 (16:51 +0000)]
Blocking changes from previous 1.4 commit
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89112
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Luigi Rizzo [Thu, 8 Nov 2007 09:21:02 +0000 (09:21 +0000)]
use %f instead of %lf (the 'l' is ignored anyways).
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89110
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Luigi Rizzo [Thu, 8 Nov 2007 09:20:05 +0000 (09:20 +0000)]
use %d and cast to int instead of %zd for size_t object,
this helps portability.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89109
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Luigi Rizzo [Thu, 8 Nov 2007 09:15:05 +0000 (09:15 +0000)]
initialize a variable to silence compiler.
The type of warnings emitted depends on the optimization level,
at the lower levels the compiler doesn't always understand what the
programmer has in mind. In this case I could not understand it either.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89108
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Kevin P. Fleming [Thu, 8 Nov 2007 05:36:28 +0000 (05:36 +0000)]
Merged revisions 89105 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r89105 | kpfleming | 2007-11-08 00:26:47 -0500 (Thu, 08 Nov 2007) | 2 lines
fix a glaring bug in the new SRV record handling that would cause incorrect weight sorting
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89107
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Kevin P. Fleming [Thu, 8 Nov 2007 05:28:47 +0000 (05:28 +0000)]
improve linked-list macros in two ways:
- the *_CURRENT macros no longer need the list head pointer argument
- add AST_LIST_MOVE_CURRENT to encapsulate the remove/add operation when moving entries between lists
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89106
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Thu, 8 Nov 2007 05:00:39 +0000 (05:00 +0000)]
Merged revisions 89103 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r89103 | tilghman | 2007-11-07 22:55:19 -0600 (Wed, 07 Nov 2007) | 2 lines
Typo
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89104
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Joshua Colp [Thu, 8 Nov 2007 02:28:15 +0000 (02:28 +0000)]
Merged revisions 89101 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r89101 | file | 2007-11-07 22:26:48 -0400 (Wed, 07 Nov 2007) | 4 lines
Do not add a sip: to the beginning of the To URI unless needed.
(closes issue #10756)
Reported by: goestelecom
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89102
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Joshua Colp [Thu, 8 Nov 2007 01:30:29 +0000 (01:30 +0000)]
Merged revisions 89099 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r89099 | file | 2007-11-07 21:28:56 -0400 (Wed, 07 Nov 2007) | 6 lines
Improve the devicestate logic for multiple devices. If any are available then the extension is considered available.
(closes issue #10164)
Reported by: nic_bellamy
Patches:
sip-hinting-svn-branch-1.4.patch uploaded by nic (license 299)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89100
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Joshua Colp [Thu, 8 Nov 2007 01:14:31 +0000 (01:14 +0000)]
Merged revisions 89097 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r89097 | file | 2007-11-07 21:11:25 -0400 (Wed, 07 Nov 2007) | 8 lines
Add support for allowing one outgoing transaction. This means if a response comes back out of order chan_sip will still handle it. I dream of a chan_sip with real transaction support.
(closes issue #10946)
Reported by: flefoll
(closes issue #10915)
Reported by: ramonpeek
(closes issue #9567)
Reported by: atca_pres
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89098
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Joshua Colp [Wed, 7 Nov 2007 23:55:08 +0000 (23:55 +0000)]
Merged revisions 89095 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r89095 | file | 2007-11-07 19:53:25 -0400 (Wed, 07 Nov 2007) | 4 lines
If callerid is configured in sip.conf use that for checking the presence of an extension in the dialplan.
(closes issue #11185)
Reported by: spditner
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89096
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Wed, 7 Nov 2007 23:47:45 +0000 (23:47 +0000)]
Merged revisions 89093 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r89093 | tilghman | 2007-11-07 17:39:37 -0600 (Wed, 07 Nov 2007) | 7 lines
The member refcount must be incremented, to avoid using it after deallocation.
A huge thanks go to lvl- for patiently providing the necessary valgrind output
that was necessary to finding this problem of memory corruption.
Reported by: lvl-
Patch by: tilghman
Closes issue #11174
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89094
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Mark Michelson [Wed, 7 Nov 2007 23:18:22 +0000 (23:18 +0000)]
If imapfolder has been specified in voicemail.conf, we should not connect to INBOX...
ever. It may not exist.
(closes issue #11151, reported by selsky, patched by me)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89092
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Mark Michelson [Wed, 7 Nov 2007 22:42:24 +0000 (22:42 +0000)]
Merged revisions 89090 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r89090 | mmichelson | 2007-11-07 16:40:35 -0600 (Wed, 07 Nov 2007) | 6 lines
This patch makes it possible for SIP phones to dial extensions defined with '#' characters
in extensions.conf AND maintain their escaped characters when forming URI's
(closes issue #10681, reported by cahen, patched by me, code review by file)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89091
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Steve Murphy [Wed, 7 Nov 2007 22:09:10 +0000 (22:09 +0000)]
Merged revisions 89088 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r89088 | murf | 2007-11-07 14:40:28 -0700 (Wed, 07 Nov 2007) | 1 line
In response to 10578, I just ran 1.4 thru valgrind; some of the config leakage I've already fixed, but it doesn't hurt to double check. I found and fixed leaks in res_jabber, cdr_tds, pbx_ael. Nothing major, tho.
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89089
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Joshua Colp [Wed, 7 Nov 2007 17:45:31 +0000 (17:45 +0000)]
Minor change so chan_h323 builds again.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89086
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Luigi Rizzo [Wed, 7 Nov 2007 13:12:28 +0000 (13:12 +0000)]
remove enter/exit comments when handling subdirectory.
If we really want them we can remove the --no-print-directory
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89084
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Luigi Rizzo [Wed, 7 Nov 2007 11:33:55 +0000 (11:33 +0000)]
remove a debugging message which i forgot in.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89083
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Luigi Rizzo [Wed, 7 Nov 2007 11:15:42 +0000 (11:15 +0000)]
match changes in menuselect's Makefile
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89082
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Wed, 7 Nov 2007 04:21:27 +0000 (04:21 +0000)]
Suppress erroneous warnings on load.
Reported by: eliel
Patch by: eliel
Closes issue #11177
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89081
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Wed, 7 Nov 2007 04:11:32 +0000 (04:11 +0000)]
Merged revisions 89079 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r89079 | tilghman | 2007-11-06 22:07:49 -0600 (Tue, 06 Nov 2007) | 5 lines
Suppress AEL warnings on load.
Reported by: eliel
Patch by: eliel
Closes issue #11178
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89080
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Wed, 7 Nov 2007 02:14:40 +0000 (02:14 +0000)]
Provide the ability to directly manipulate the TON/NPI bits in the dialstring.
Reported by: thetatag
Patch by: thetatag/stevens/tilghman
Closes issue #5331
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89078
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Wed, 7 Nov 2007 01:08:31 +0000 (01:08 +0000)]
Add contributed EAGI proxy, which provides FastAGI functionality for EAGI, while also
buffering the audio stream.
Reported by: devil_slayer
Patch by: devil_slayer
Closes issue #8921
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89077
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Wed, 7 Nov 2007 00:16:03 +0000 (00:16 +0000)]
Fix another CLI command so it doesn't run the real code when called for initialization.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89076
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Mark Michelson [Wed, 7 Nov 2007 00:04:30 +0000 (00:04 +0000)]
Adding documentation regarding imapfolder, imapgreetings, and greetingsfolder options
in voicemail.conf
(closes issue #11133, reported by selsky, patched by blitzrage)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89075
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Wed, 7 Nov 2007 00:00:38 +0000 (00:00 +0000)]
Print out the channel name as a prefix to the "agi debug" output. This makes
AGI debugging on busy systems much easier.
(closes issue #10730)
Reported by: junky
Patches:
agi_debug_chan.diff uploaded by junky (license 177)
20070923_10730.diff uploaded by mvanbaak (license 7)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89074
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Tue, 6 Nov 2007 23:44:39 +0000 (23:44 +0000)]
Added the ability to do "meetme concise" with the "meetme" CLI command.
This extends the concise capabilities of this CLI command to include
listing all conferences, instead of an addition to the other sub commands
for the "meetme" command.
(closes issue #11078)
Reported by: jthomas
Patches:
meetme-concise.patch uploaded by jthomas (license 293)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89073
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Joshua Colp [Tue, 6 Nov 2007 23:08:36 +0000 (23:08 +0000)]
Fix up some PBX logic that became broken. The code would exit prematurely when it should have been collecting more digits.
(closes issue #11175)
Reported by: pj
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89072
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Tue, 6 Nov 2007 22:51:48 +0000 (22:51 +0000)]
Commit some cleanups to the format type code.
- Remove the AST_FORMAT_MAX_* types, as these are consuming 3 out of our available 32 bits.
- Add a native slin16 type, so that 16kHz codecs can translate without losing resolution.
(This doesn't affect anything immediately, until another codec has wb support.)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89071
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Mark Michelson [Tue, 6 Nov 2007 22:36:55 +0000 (22:36 +0000)]
Adding the queue strategy wrandom
(closes issue #10942, reported and patched by julianjm, documentation changes by me)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89070
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Tue, 6 Nov 2007 22:15:32 +0000 (22:15 +0000)]
Added the S() and L() options to the MeetMe application. These are pretty
much identical to the S() and L() options to Dial(). They let you set
timeouts for the conference, as well as have warning sounds played to
let the caller know how much time is left, and when it is running out.
(closes issue #8030)
Reported by: areski
Patches:
meetme_timeout_timelimit_v2.patch uploaded by areski (license 29)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89069
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Mark Michelson [Tue, 6 Nov 2007 22:05:56 +0000 (22:05 +0000)]
Added CLI and manager commands for changing a queue member's penalty
(closes issue #9374, reported and initially patched by wuwu, intermediate patch by eliel, and final patch by me)
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89068
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Matthew Fredrickson [Tue, 6 Nov 2007 22:01:10 +0000 (22:01 +0000)]
Add some more locking as well as API update for libss7 for new transport types
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89067
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Steve Murphy [Tue, 6 Nov 2007 21:08:38 +0000 (21:08 +0000)]
Merged revisions 89036 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r89036 | murf | 2007-11-06 10:52:50 -0700 (Tue, 06 Nov 2007) | 1 line
closes issue #8786 - where the [catname](!) and [catname](othercat1,othercat2,...) notation gets dropped across a ConfigUpdate (or any other thing that would cause a config file to be written). While I was at it, I also cleaned up some of the destroy routines to free up comments, which was not being done. Made sure the new struct I introduced is also cleaned up properly at destruction time. My code handles multiple template inclusions. Many thanks to ssokol for his patch, which, while not literally used in the final merge, served as a foundation for the fix.
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89062
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Joshua Colp [Tue, 6 Nov 2007 20:55:58 +0000 (20:55 +0000)]
Remove native bridging check for DTMF based transfers. Thanks to the last batch of RTP changes it is no longer required for the media stream to go through Asterisk if DTMF is going over signalling. It will simply reinvite back as needed.
(closes issue #11172)
Reported by: ibc
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89057
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Mark Michelson [Tue, 6 Nov 2007 20:32:49 +0000 (20:32 +0000)]
Instead of trying to callback a local channel on a failed attended transfer, call
the device that made the transfer instead. This makes for much smoother calling back
when queues are involved.
(closes issue #11155, reported by IPetrov)
Tremendous thanks to Russell for pulling me out of my block I was having on this one
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89055
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Tue, 6 Nov 2007 20:22:50 +0000 (20:22 +0000)]
Merged revisions 89053 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r89053 | russell | 2007-11-06 14:18:49 -0600 (Tue, 06 Nov 2007) | 3 lines
Fix init_classes() so that classes that actually do have files loaded aren't
treated as empty, and immediately destroyed ...
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89054
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Russell Bryant [Tue, 6 Nov 2007 19:51:37 +0000 (19:51 +0000)]
Fix the memory show allocations CLI command so that it doesn't spew out all
of the current memory allocations when you start Asterisk, when the command's
handler gets called for initialization.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89052
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Steve Murphy [Tue, 6 Nov 2007 19:40:33 +0000 (19:40 +0000)]
Hoping to avoid a crash in OSX for a problem blitzrage found
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89051
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Olle Johansson [Tue, 6 Nov 2007 19:23:10 +0000 (19:23 +0000)]
Formatting. Illegaly using some spare spaces from Russell's space-bucket.
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89050
65c4cc65-6c06-0410-ace0-
fbb531ad65f3
Tilghman Lesher [Tue, 6 Nov 2007 19:16:02 +0000 (19:16 +0000)]
Merged revisions 89045 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r89045 | tilghman | 2007-11-06 13:09:06 -0600 (Tue, 06 Nov 2007) | 2 lines
We went to the trouble of creating a method of tracking failed trylocks, then never turned it on (oops).
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@89049
65c4cc65-6c06-0410-ace0-
fbb531ad65f3