asterisk/asterisk.git
2 years agocore/buildsystem: check the actual compiler being version
Guido Falsi [Sun, 7 Apr 2019 16:36:55 +0000 (18:36 +0200)]
core/buildsystem: check the actual compiler being version

Make compiler check use the output of the actual compiler being
used as reported by the CC variable, instead of unconditionally
running the "gcc" binary.  Also only run the check if the compiler
is gcc or a cross-compile gcc.

ASTERISK-28374

Change-Id: Icaacf6d93686ad21076878aa1504a23b4fc9d0f4

2 years agoMerge "loader: support for permanent dlopen()"
Friendly Automation [Fri, 19 Apr 2019 14:06:03 +0000 (09:06 -0500)]
Merge "loader: support for permanent dlopen()"

2 years agoMerge "res_pjsip: Added a norefersub configuration setting"
Joshua Colp [Fri, 19 Apr 2019 13:30:14 +0000 (08:30 -0500)]
Merge "res_pjsip:  Added a norefersub configuration setting"

2 years agores_remb_modifier: Propertly initialize bitrate to 0.0
George Joseph [Wed, 17 Apr 2019 19:45:26 +0000 (13:45 -0600)]
res_remb_modifier:  Propertly initialize bitrate to 0.0

...and return the frame unaltered if bitrate can't be determined.

Change-Id: Ib2175ab84f85a3d7060d31625f5a2c7fbcc2ba4c

2 years agoMerge "res_mwi_devstate: Specify AST_MODFLAG_LOAD_ORDER to enable load priority"
Friendly Automation [Thu, 18 Apr 2019 10:44:01 +0000 (05:44 -0500)]
Merge "res_mwi_devstate: Specify AST_MODFLAG_LOAD_ORDER to enable load priority"

2 years agores_pjsip: Added a norefersub configuration setting
Dan Cropp [Mon, 8 Apr 2019 22:04:48 +0000 (17:04 -0500)]
res_pjsip:  Added a norefersub configuration setting

Added a new PJSIP global setting called norefersub.
Default is true to keep support working as before.

res_pjsip_refer:  Configures PJSIP norefersub capability accordingly.

Checks the PJSIP global setting value.
If it is true (default) it adds the norefersub capability to PJSIP.
If it is false (disabled) it does not add the norefersub capability
to PJSIP.

This is useful for Cisco switches that do not follow RFC4488.

ASTERISK-28375 #close
Reported-by: Dan Cropp

Change-Id: I0b1c28ebc905d881f4a16e752715487a688b30e9

2 years agoMerge "pbx.c: Ignore dashes in extensions when using extenpatternmatchnew"
Friendly Automation [Tue, 16 Apr 2019 16:38:52 +0000 (11:38 -0500)]
Merge "pbx.c: Ignore dashes in extensions when using extenpatternmatchnew"

2 years agoMerge "app_voicemail: Don't split mailbox options on comma"
Friendly Automation [Tue, 16 Apr 2019 16:37:09 +0000 (11:37 -0500)]
Merge "app_voicemail: Don't split mailbox options on comma"

2 years agores_mwi_devstate: Specify AST_MODFLAG_LOAD_ORDER to enable load priority
Sean Bright [Tue, 16 Apr 2019 15:58:40 +0000 (11:58 -0400)]
res_mwi_devstate: Specify AST_MODFLAG_LOAD_ORDER to enable load priority

Suggested by abelbeck on the issue tracker.

ASTERISK~28384
Reported by: abelbeck

Change-Id: Icee0fff2b58dbfaa80f2b68270fe69dfb0463fc0

2 years agoMerge "build: Revise CHANGES and UPGRADE.txt handling."
Benjamin Keith Ford [Tue, 16 Apr 2019 15:52:51 +0000 (10:52 -0500)]
Merge "build: Revise CHANGES and UPGRADE.txt handling."

2 years agoMerge "res_ael: Use Gosub in for loop expressions"
Joshua Colp [Tue, 16 Apr 2019 13:11:28 +0000 (08:11 -0500)]
Merge "res_ael: Use Gosub in for loop expressions"

2 years agoMerge "ARI: Run 'make ari-stubs'"
Joshua Colp [Tue, 16 Apr 2019 12:29:45 +0000 (07:29 -0500)]
Merge "ARI:  Run 'make ari-stubs'"

2 years agoMerge "res_ael: Fix pattern matching against literal '+'"
Joshua Colp [Tue, 16 Apr 2019 12:25:40 +0000 (07:25 -0500)]
Merge "res_ael: Fix pattern matching against literal '+'"

2 years agoCI: Move test group config files to Jenkins
George Joseph [Fri, 12 Apr 2019 16:32:44 +0000 (10:32 -0600)]
CI: Move test group config files to Jenkins

One of the downaides of having things like test configuration
in the git repo is that it can't be changed at runtime.  You have
to create a review for the changes and merge it mefore it will
take effect.

This review moves the data currently held in
tests/CI/periodic-dailyTestGroups.json and
tests/CI/gateTestGroups.json into a Jenkins Config File attached
to the job definitions.  This allows us to alter it from the
Jenkins UI at runtime.  The original files stay in the repo
as documentation.

Change-Id: I14b9702f6285ce1fb2420287ba0e7d3b59109763

2 years agoapp_voicemail: Don't split mailbox options on comma
Sean Bright [Sat, 13 Apr 2019 18:36:56 +0000 (14:36 -0400)]
app_voicemail: Don't split mailbox options on comma

Because the per-mailbox options are the last thing on a line, don't look
for or stomp on any subsequent commas.

ASTERISK-27935 #close
Reported by: Sébastien Duthil

Change-Id: I07b2eb4a33c303d0c7114d5b906f8c067c60a153

2 years agoMerge "res_ael: Create consistent label names across reloads"
George Joseph [Fri, 12 Apr 2019 19:16:31 +0000 (14:16 -0500)]
Merge "res_ael: Create consistent label names across reloads"

2 years agoMerge "pbx.c: Properly parse labels with leading digits"
George Joseph [Fri, 12 Apr 2019 19:16:10 +0000 (14:16 -0500)]
Merge "pbx.c: Properly parse labels with leading digits"

2 years agopbx.c: Ignore dashes in extensions when using extenpatternmatchnew
Sean Bright [Fri, 12 Apr 2019 14:33:57 +0000 (10:33 -0400)]
pbx.c: Ignore dashes in extensions when using extenpatternmatchnew

Because hyphens are not matched literally in Asterisk dialplan, we need
to ignore them in our candidate extensions as well.

ASTERISK-17695 #close
Reported by: test011

Change-Id: I227f02301577b1633e8a55b9fe9dc149935c03f0

2 years agoMerge "app_voicemail: Cleanup stale lock files on module load"
Friendly Automation [Fri, 12 Apr 2019 15:00:40 +0000 (10:00 -0500)]
Merge "app_voicemail: Cleanup stale lock files on module load"

2 years agoMerge "chan_ooh323: fix h323 log file path"
Friendly Automation [Fri, 12 Apr 2019 14:19:15 +0000 (09:19 -0500)]
Merge "chan_ooh323: fix h323 log file path"

2 years agoapp_voicemail: Cleanup stale lock files on module load
Sean Bright [Tue, 9 Apr 2019 15:10:12 +0000 (11:10 -0400)]
app_voicemail: Cleanup stale lock files on module load

If Asterisk crashes while a VM directory is locked, lock files in the VM
spool directory will not get properly cleaned up. We now clear them on
module load.

ASTERISK-20207 #close
Reported by: Steven Wheeler

Change-Id: If40ccd508e2f6e5ade94dde2f0bcef99056d0aaf

2 years agoARI: Run 'make ari-stubs'
George Joseph [Fri, 12 Apr 2019 12:33:10 +0000 (06:33 -0600)]
ARI:  Run 'make ari-stubs'

An earlier contributor apparently forgot to run 'make ari-stubs'
before committing after making ARI model changes.

Change-Id: I7813e5638e2821d11f4b968dc2aeab4f725190a6

2 years agores_ael: Create consistent label names across reloads
Sean Bright [Thu, 11 Apr 2019 20:48:49 +0000 (16:48 -0400)]
res_ael: Create consistent label names across reloads

Reset the internal counter that the AEL2 compiler uses for unique label
names before compiling. This keeps dialplan labels consistent across
reloads assuming the AEL2 has not changed.

ASTERISK-17799 #close
Reported by: Kirill Katsnelson

Change-Id: I30b3cc887d1ee0644d3f341e2fef16f525d7fae5

2 years agores_ael: Use Gosub in for loop expressions
Sean Bright [Thu, 11 Apr 2019 20:29:20 +0000 (16:29 -0400)]
res_ael: Use Gosub in for loop expressions

In AEL2, if a 'for' statement contains macro* calls, like:

    for (&iterator(${TRY},A); "${A}" != ""; &iterate(A)) {

The AEL2 parser will translate these into calls to the deprecated Macro
dialplan application and use the antiquated pipe delimiter.

Instead, convert these into calls to the Gosub dialplan application and
use commas as argument separators.

ASTERISK-18593 #close
Reported by: Luke-Jr

* 'macro' in this context means AEL2 macros, not the 'Macro' application

Change-Id: I3d73716033b8e3e42e0209d355bf5f10c97045fc

2 years agores_ael: Fix pattern matching against literal '+'
Sean Bright [Thu, 11 Apr 2019 16:03:07 +0000 (12:03 -0400)]
res_ael: Fix pattern matching against literal '+'

When generating the regular expression that matches against existing
extensions, we need to escape literal characters that can also be
regular expression metacharacters. This was already being done for '*'
but we need to do the same for '+'.

In passing, remove some unreachable code - strcmp() is already run
immediately when entering extension_matches().

ASTERISK-14939 #close
Reported by: klaus3000

Change-Id: I8d2cccb3479168fba1b0a6704c52198b396468f1

2 years agoMerge "res_pjsip: Fix transport_states ref leak"
Friendly Automation [Thu, 11 Apr 2019 19:58:41 +0000 (14:58 -0500)]
Merge "res_pjsip: Fix transport_states ref leak"

2 years agopbx.c: Properly parse labels with leading digits
Sean Bright [Thu, 11 Apr 2019 17:49:38 +0000 (13:49 -0400)]
pbx.c: Properly parse labels with leading digits

If the target of a Goto is a label that starts with a number, we
erroneously treat the leading digits as a priority.

ASTERISK-20182 #close
Reported by: Janu

Change-Id: Ia78408c0805a729103917247ecfc802f6fafc94b

2 years agochan_ooh323: fix h323 log file path
Alexander Anikin [Wed, 10 Apr 2019 23:07:18 +0000 (02:07 +0300)]
chan_ooh323: fix h323 log file path

Change h323 log path relative to AST_LOG_DIR instead of
/var/log/asterisk hardcoded
Add return back error message from OOH323EP initialize

ASTERISK-28348 #close

Reported by: Dmitry Shubin

Change-Id: Ib102dd36bbe6c2a7a4ce6870ae9110d9000d7e98

2 years agoMerge "chan_pjsip: DTMF Mode auto_info fallback lead to both inband and info"
George Joseph [Wed, 10 Apr 2019 17:42:56 +0000 (12:42 -0500)]
Merge "chan_pjsip: DTMF Mode auto_info fallback lead to both inband and info"

2 years agores_pjsip: Fix transport_states ref leak
Alexei Gradinari [Tue, 9 Apr 2019 21:47:59 +0000 (17:47 -0400)]
res_pjsip: Fix transport_states ref leak

Add missing ao2_ref(transport_state, -1) while iterate on a transport_states
container.

Change-Id: I40e35b5a339121300c80075c30db47201a6c374e

2 years agoMerge "config.c: Fix a crash in extconfig parsing"
Joshua Colp [Wed, 10 Apr 2019 11:40:54 +0000 (06:40 -0500)]
Merge "config.c: Fix a crash in extconfig parsing"

2 years agobuild: Revise CHANGES and UPGRADE.txt handling.
Ben Ford [Mon, 1 Apr 2019 20:38:04 +0000 (15:38 -0500)]
build: Revise CHANGES and UPGRADE.txt handling.

This changes the way that we handle adding changes to CHANGES and
UPGRADE.txt. The reason for this is because whenever someone needed to
make a change to one of these files and someone else had already done
so, you would run into merge conflicts. With this new setup, there will
never be merge conflicts since all changes will be documented in the
doc/<file>-staging directory. The release script is now responsible for
merging all of these changes into the appropriate files.

There is a special format that these files have to follow in order to be
parsed. The files do not need to have a meaningful name, but it is
strongly recommended. For example, if you made a change to pjsip, you
may have something like this "res_pjsip_relative_title", where
"relative_title" is something more descriptive than that. Inside each
file, you will need a subject line for your change, followed by a
description. There can be multiple subject lines. The file may look
something like this:

   Subject: res_pjsip
   Subject: Core

   A description that explains the changes made and why. The release
   script will handle the bulleting and section separators!

   You can still separate with new lines within your
   description.

The headers ("Subject" and "Master-Only") are case sensative, but the
value for "Master-Only" ("true" or "True") is not.

For more information, check out the wiki page:
https://wiki.asterisk.org/wiki/display/AST/CHANGES+and+UPGRADE.txt

ASTERISK-28111 #close

Change-Id: I19cf4b569321c88155a65e9b0b80f6d58075dd47

2 years agoMerge "CI: Add --no-dev-mode option to buildAsterisk.sh"
Friendly Automation [Mon, 8 Apr 2019 15:59:54 +0000 (10:59 -0500)]
Merge "CI:  Add --no-dev-mode option to buildAsterisk.sh"

2 years agoMerge "stasis.c: Added topic_all container"
George Joseph [Mon, 8 Apr 2019 15:53:18 +0000 (10:53 -0500)]
Merge "stasis.c: Added topic_all container"

2 years agoMerge "res/res_ari: Added ARI resource /ari/channels/{channelId}/rtp_statistics"
George Joseph [Mon, 8 Apr 2019 15:51:45 +0000 (10:51 -0500)]
Merge "res/res_ari: Added ARI resource /ari/channels/{channelId}/rtp_statistics"

2 years agoMerge "main/json.c: Added app_name, app_data to channel type"
Friendly Automation [Mon, 8 Apr 2019 15:32:16 +0000 (10:32 -0500)]
Merge "main/json.c: Added app_name, app_data to channel type"

2 years agoconfig.c: Fix a crash in extconfig parsing
Chris-Savinovich [Thu, 4 Apr 2019 21:02:42 +0000 (16:02 -0500)]
config.c: Fix a crash in extconfig parsing

When extconfig.conf file is parsed, the code previously searched for
character comma without verifying if error (null or blank).  This caused
a segmentation error.

Change-Id: Id76b452d8f330d11c2742c37232761ad71472a8b

2 years agochan_pjsip: DTMF Mode auto_info fallback lead to both inband and info
Salah Ahmed [Wed, 3 Apr 2019 15:55:07 +0000 (10:55 -0500)]
chan_pjsip: DTMF Mode auto_info fallback lead to both inband and info

When the dtmf_mode on an endpoint is configured as "auto_info"
Asterisk will produce an inband DTMF tone alongside an INFO
message when sending DTMF.

ASTERISK-28371

Change-Id: I1380b82f006e110a1b83fbb50c9873edd13a5d9a

2 years agoloader: support for permanent dlopen()
Sebastian Kemper [Tue, 2 Apr 2019 20:49:52 +0000 (22:49 +0200)]
loader: support for permanent dlopen()

Asterisk assumes that dlopen() will always run the constructor of a
shared library and every dlclose() will run its destructor. But dlopen()
may be permanent, meaning the constructor will only be run once, as is
the case with musl libc.

With a permanent dlopen() the Asterisk module loader does not work
correctly, because it's expectations regarding when the constructors and
destructors are run are not met. In fact a segmentation fault will occur
when the first module is "re-opened" that has AST_MODFLAG_GLOBAL_SYMBOLS
set (the dlopen() does not call the constructor, resource_being_loaded
is not set to NULL, then strlen is called with NULL instead of a string,
see issue ASTERISK-28319).

This commit adds code to the loader that will manually run the
constructors/destructors of the (non-builtin) modules where needed. To
achieve this a new ao2 container (linked list) is started and filled
with objects that contain the names of the modules and the pointers to
their respective info structs.

This behavior can be activated when configuring Asterisk
(--enable-permanent-dlopen). By default this is disabled, of course.

ASTERISK-28319 #close

Signed-off-by: Sebastian Kemper <sebastian_ml@gmx.net>
Change-Id: I86693a0ecf25d5ba81c73773a03df4abc3426875

2 years agoMerge "bridge_softmix: use a float type to store the internal REMB bitrate"
Joshua Colp [Thu, 4 Apr 2019 13:52:47 +0000 (08:52 -0500)]
Merge "bridge_softmix: use a float type to store the internal REMB bitrate"

2 years agoMerge "res/res_rtp_asterisk: Enable rxjitter calculation for video"
Joshua Colp [Thu, 4 Apr 2019 13:32:07 +0000 (08:32 -0500)]
Merge "res/res_rtp_asterisk: Enable rxjitter calculation for video"

2 years agoCI: Add --no-dev-mode option to buildAsterisk.sh
George Joseph [Wed, 3 Apr 2019 22:55:00 +0000 (16:55 -0600)]
CI:  Add --no-dev-mode option to buildAsterisk.sh

The new option disables dev mode, TEST_FRAMEWORK and
MALLOC_DEBUG making the build more production-like.

Change-Id: Ieb72497d4d91d5416684aaed702cc3f532099738

2 years agobuild: Fix compiler warnings/errors.
Ben Ford [Wed, 3 Apr 2019 15:24:06 +0000 (10:24 -0500)]
build: Fix compiler warnings/errors.

The compiler complained about a couple of variables that weren't
initialized but were being used. Initializing them to NULL resolves the
warnings/errors.

ASTERISK-28362 #close

Change-Id: I6243afc5459b416edff6bbf571b0489f6b852e4b

2 years agobridge_softmix: use a float type to store the internal REMB bitrate
Kevin Harwell [Wed, 27 Mar 2019 17:59:30 +0000 (12:59 -0500)]
bridge_softmix: use a float type to store the internal REMB bitrate

REMB's exponent is 6-bits (0..63) and has a mantissa of 18-bits. We were using
an unsigned integer to represent the bitrate. However, that type is not large
enough to hold all potential bitrate values. If the bitrate is large enough
bits were being shifted off the "front" of the mantissa, which caused the
wrong value to be sent to the browser.

This patch makes it so it now uses a float type to hold the bitrate. Using a
float allows for all bitrate values to be correctly represented.

ASTERISK-28255

Change-Id: Ice00fdd16693b16b41230664be5d9f0e465b239e

2 years agoMerge "pjproject: Add timer patch from pjproject r5934"
Friendly Automation [Tue, 2 Apr 2019 15:15:21 +0000 (10:15 -0500)]
Merge "pjproject: Add timer patch from pjproject r5934"

2 years agoapp_queue: Fix a few member pause bugs
Sean Bright [Fri, 29 Mar 2019 13:07:29 +0000 (09:07 -0400)]
app_queue: Fix a few member pause bugs

* Always set member->lastpause when setting member->paused

* Fixed typo (using member->lastcall instead of member->lastpause) in
  'queue show' output.

* Use a constant 'now' in 'queue show' output for a better point-in-time
  view of time based stats.

ASTERISK-27541 #close
Reported by: César Benjamín García Martínez

Change-Id: Ib41ced90cfdb66f9bb1e7b263d0f6fc1ac6e18fa

2 years agoalembic: Fix errors during upgrade head.
Ben Ford [Tue, 26 Mar 2019 19:56:37 +0000 (14:56 -0500)]
alembic: Fix errors during upgrade head.

When trying to upgrade using alembic, a couple different errors kept
popping up that prevented the upgrade. An additional parameter was
needed when changing the schema for mwi_subscribe_replaces_unsolicited
from an integer to an enum. When changing from a string to an enum, the
type needed to be cast for postgresql. The other issue was a parameter
being used during column creation that did not exist.

After fixing the upgrade process, it revealed errors with the downgrade
process. One was a variable not being defined in the downgrade function,
and the other was tables not existing when using MySQL. This was due to
a context check that should have encompassed MySQL, but in the end was
not doing so.

Change-Id: Ib4d70cf3ce5080023a50be496272a777b55d6c8e

2 years agoMerge "pjsip: restrict function PJSIP_PARSE_URI to parse only SIP/SIPS URIs"
George Joseph [Thu, 28 Mar 2019 13:04:51 +0000 (08:04 -0500)]
Merge "pjsip: restrict function PJSIP_PARSE_URI to parse only SIP/SIPS URIs"

2 years agoMerge "manager: Use separate lock for session event notification."
George Joseph [Thu, 28 Mar 2019 13:03:37 +0000 (08:03 -0500)]
Merge "manager: Use separate lock for session event notification."

2 years agostasis.c: Added topic_all container
sungtae kim [Sat, 26 Jan 2019 21:51:48 +0000 (22:51 +0100)]
stasis.c: Added topic_all container

Added topic_all container for centralizing the topic. This makes more
easier to managing the topics.

Added cli commands.
stasis show topics : It shows all registered topics.
stasis show topic <name> : It shows speicifed topic's detail info.

ASTERISK-28264

Change-Id: Ie86d125d2966f93de74ee00f47ae6fbc8c081c5f

2 years agores/res_rtp_asterisk: Enable rxjitter calculation for video
Matthew Fredrickson [Wed, 27 Mar 2019 19:30:45 +0000 (19:30 +0000)]
res/res_rtp_asterisk: Enable rxjitter calculation for video

It looks like we're not properly calculating jitter values on received
video streams.  This patch enables the code that does jitter calculations
for those streams.

Change-Id: Iaac985808829c8f034db8c57318789c4c8c11392

2 years agoMerge "build: Add staging directories for future changes."
George Joseph [Wed, 27 Mar 2019 19:25:25 +0000 (14:25 -0500)]
Merge "build: Add staging directories for future changes."

2 years agoMerge "app_queue: Fix documentation for QUEUE_MEMBER function."
Friendly Automation [Wed, 27 Mar 2019 18:40:36 +0000 (13:40 -0500)]
Merge "app_queue: Fix documentation for QUEUE_MEMBER function."

2 years agobuild: Add staging directories for future changes.
Ben Ford [Wed, 27 Mar 2019 16:03:40 +0000 (11:03 -0500)]
build: Add staging directories for future changes.

This is the first step in changing the release process so that changes
made to the CHANGES and UPGRADE.txt files do not result in merge
conflicts every time multiple people modify these files. The changes
made will go in these new directories: doc/CHANGES-staging and
doc/UPGRADE-staging. The README.md files explain how things will work,
but here's a little overview. When you make a change that would go in
either CHANGES or UPGRADE.txt, this should instead be documented in a
new file in the doc/CHANGES-staging or doc/UPGRADE-staging directory,
respectively. The format will look like this:

   Subject: res_pjsip

   A description that explains the changes made and why. The release
   script will handle the bulleting and section separators! The
   'Subject:' header is case-sensitive.

   You can still separate with new lines within your description.

   Subject: res_ari
   Master-Only: true

   You can have more than one subject, and they don't have to be the
   same! Also, the 'Master-Only' header should always be true and is
   also case-sensitive (but the value is not - you can have 'true' or
   'True'). This header will only ever be present in the master branch.

For more information, check out the wiki page:
https://wiki.asterisk.org/wiki/display/AST/CHANGES+and+UPGRADE.txt

This is an initial change for ASTERISK_28111. Functionally, this will
make no difference, but it will prep the directories for when the
changes from CHANGES and UPGRADE.txt are extracted.

Change-Id: I8d852f284f66ac456b26dcb899ee46babf7d15b6

2 years agopjsip: restrict function PJSIP_PARSE_URI to parse only SIP/SIPS URIs
Alexei Gradinari [Mon, 25 Mar 2019 23:05:28 +0000 (19:05 -0400)]
pjsip: restrict function PJSIP_PARSE_URI to parse only SIP/SIPS URIs

The next usage of PJSIP_PARSE_URI will crash asterisk
${PJSIP_PARSE_URI(tel:+1234567890,host)}
or
${PJSIP_PARSE_URI(192.168.1.1:5060,host)}

The function pjsip_parse_uri successfully parses then, but returns
struct pjsip_other_uri *.

This patch restricts parsing only SIP/SIPS URIs.

Change-Id: I16f255c2b86a80a67e9f9604b94b129a381dd25e

2 years agopjproject: Add timer patch from pjproject r5934
Sean Bright [Tue, 26 Mar 2019 18:07:25 +0000 (14:07 -0400)]
pjproject: Add timer patch from pjproject r5934

ASTERISK-28161 #close
Reported by: Ross Beer

Change-Id: I65331d554695753005eaa66c1d5d4807fe9009c8

2 years agoMerge "chan_sip: Ensure 'qualifygap' isn't negative"
Friendly Automation [Wed, 27 Mar 2019 11:00:11 +0000 (06:00 -0500)]
Merge "chan_sip: Ensure 'qualifygap' isn't negative"

2 years agoapp_queue: Fix documentation for QUEUE_MEMBER function.
Sean Bright [Tue, 26 Mar 2019 21:55:55 +0000 (17:55 -0400)]
app_queue: Fix documentation for QUEUE_MEMBER function.

It was a copy/paste of the QUEUE_MEMBER_COUNT function's synopsis.

ASTERISK-20986 #close
Reported by: Olivier Krief

Change-Id: If51ec481feb35824a4e78ab5600b197b819b10be

2 years agomain/json.c: Added app_name, app_data to channel type
sungtae kim [Thu, 21 Mar 2019 23:09:14 +0000 (00:09 +0100)]
main/json.c: Added app_name, app_data to channel type

It was difficult to check the channel's current application and
parameters using ARI for current channels. Added app_name, app_data
items to show the current application information.

ASTERISK-28343

Change-Id: Ia48972b3850e5099deab0faeaaf51223a1f2f38c

2 years agoMerge "res_config_odbc: set empty extended field as a single whitespace"
George Joseph [Tue, 26 Mar 2019 13:47:48 +0000 (08:47 -0500)]
Merge "res_config_odbc: set empty extended field as a single whitespace"

2 years agomanager: Use separate lock for session event notification.
Joshua Colp [Mon, 25 Mar 2019 11:34:09 +0000 (08:34 -0300)]
manager: Use separate lock for session event notification.

When notifying a manager session that new events were available
the same lock was used that was also held when doing things within
the session (such as sending events out). If the manager session
blocked for a period of time this would cause a back up of messages
in Stasis and would also block any other sessions from receiving
events.

This change adds a separate lock to the manager session which is
strictly used for notifying it that new events are available.

ASTERISK-28350

Change-Id: Ifbcac007faca9ad0231640f5e82a6ca9228f261b

2 years agoMerge "res/res_ari: Added timestamp as a requirement for all ARI events"
Friendly Automation [Tue, 26 Mar 2019 13:32:28 +0000 (08:32 -0500)]
Merge "res/res_ari: Added timestamp as a requirement for all ARI events"

2 years agochan_sip: Ensure 'qualifygap' isn't negative
Sean Bright [Mon, 25 Mar 2019 19:31:23 +0000 (15:31 -0400)]
chan_sip: Ensure 'qualifygap' isn't negative

Passing negative intervals to the scheduler rips a hole in the
space-time continuum.

ASTERISK-25792 #close
Reported by: Paul Sandys

Change-Id: Ie706f21cee05f76ffb6f7d89e9c867930ee7bcd7

2 years agores_config_odbc: set empty extended field as a single whitespace
Alexei Gradinari [Mon, 25 Mar 2019 16:42:27 +0000 (12:42 -0400)]
res_config_odbc: set empty extended field as a single whitespace

If Realtime @ variable value is NULL or empty or contains only whitespaces
then when we try to retrieve it using PJSIP_ENDPOINT we get WARNING
pjsip_endpoint_function_read: Unknown property @my_var for PJSIP endpoint.
And the variable is missing in the result of CLI pjsip show endpoint.

This patch keeps empty sorcery extended field.

ASTERISK-28341 #close

Change-Id: I221fccc04cbfa2be17ce971f64ae0e74e465eea0

2 years agomain/taskprocessor: Increase max name length of taskprocessors
Matthew Fredrickson [Fri, 22 Mar 2019 19:46:34 +0000 (19:46 +0000)]
main/taskprocessor: Increase max name length of taskprocessors

Since the new names went in, the maximum taskprocessor name is too
short.  This patch increases the name field to a length to better
handle the new names.

Change-Id: I32f32d6926f25c8ef5a91303fd2988d2c2858877

2 years agoMerge "sorcery.c: Sorcery enhancements for wizard management"
George Joseph [Tue, 19 Mar 2019 15:23:37 +0000 (10:23 -0500)]
Merge "sorcery.c: Sorcery enhancements for wizard management"

2 years agoMerge "res/res_stasis: Fixed wrong StasisEnd timestamp"
George Joseph [Tue, 19 Mar 2019 14:26:47 +0000 (09:26 -0500)]
Merge "res/res_stasis: Fixed wrong StasisEnd timestamp"

2 years agosorcery.c: Sorcery enhancements for wizard management
George Joseph [Thu, 14 Mar 2019 16:46:53 +0000 (10:46 -0600)]
sorcery.c: Sorcery enhancements for wizard management

Added ability to specifiy a wizard is read-only when applying
it to a specific object type.  This allows you to specify
create, update and delete callbacks for the wizard but limit
which object types can use them.

Added the ability to allow an object type to have multiple
wizards of the same type.  This is indicated when a wizard
is added to a specific object type.

Added 3 new sorcery wizard functions:

* ast_sorcery_object_type_insert_wizard which does the same thing
  as the existing ast_sorcery_insert_wizard_mapping function but
  accepts the new read-only and allot-duplicates flags and also
  returns the ast_sorcery_wizard structure used and it's internal
  data structure. This allows immediate use of the wizard's
  callbacks without having to register a "wizard mapped" observer.

* ast_sorcery_object_type_apply_wizard which does the same
  thing as the existing ast_sorcery_apply_wizard_mapping function
  but has the added capabilities of
  ast_sorcery_object_type_insert_wizard.

* ast_sorcery_object_type_remove_wizard which removes a wizard
  matching both its name and its original argument string.

* The original logic in __ast_sorcery_insert_wizard_mapping was moved
  to __ast_sorcery_object_type_insert_wizard and enhanced for the
  new capabilities, then __ast_sorcery_insert_wizard_mapping was
  refactored to just call __ast_sorcery_insert_wizard_mapping.

* Added a unit test to test_sorcery.c to test the read-only
  capability.

Change-Id: I40f35840252e4313d99e11dbd80e270a3aa10605

2 years agoMerge "vector: Add AST_VECTOR_COMPACT() to reclaim wasted space"
Joshua Colp [Mon, 18 Mar 2019 11:31:46 +0000 (06:31 -0500)]
Merge "vector: Add AST_VECTOR_COMPACT() to reclaim wasted space"

2 years agoMerge "Revert "Test_cel: Fails when DONT_OPTIMIZE is off""
Joshua Colp [Mon, 18 Mar 2019 11:05:31 +0000 (06:05 -0500)]
Merge "Revert "Test_cel: Fails when DONT_OPTIMIZE is off""

2 years agoMerge "Variable ALTCONF ignored when service is used in Debian"
Joshua Colp [Mon, 18 Mar 2019 11:00:06 +0000 (06:00 -0500)]
Merge "Variable ALTCONF ignored when service is used in Debian"

2 years agoMerge "app.c: Remove deletion of pool topic on mwi state delete"
George Joseph [Fri, 15 Mar 2019 23:30:08 +0000 (18:30 -0500)]
Merge "app.c:  Remove deletion of pool topic on mwi state delete"

2 years agores/res_stasis: Fixed wrong StasisEnd timestamp
sungtae kim [Sun, 10 Mar 2019 22:53:36 +0000 (23:53 +0100)]
res/res_stasis: Fixed wrong StasisEnd timestamp

Because StasisEnd's timestamp created it's own timestamp, it makes
wrong timestamp, compare to other channel event(ChannelDestroyed).
Fixed to getting a timestamp from the Channel's timestamp.

ASTERISK-28333

Change-Id: I5eb8380fc472f1100535a6bc4983c64767026116

2 years agovector: Add AST_VECTOR_COMPACT() to reclaim wasted space
Sean Bright [Thu, 14 Mar 2019 14:55:30 +0000 (10:55 -0400)]
vector: Add AST_VECTOR_COMPACT() to reclaim wasted space

This might be useful in situations where you are loading an undetermined number
of items into a vector and don't want to keep (potentially) 2x the necessary
memory around indefinitely.

Change-Id: I9711daa0fe01783fc6f04c5710eba84f2676d7b9

2 years agotaskprocessor.c: Fix printf type mismatch
Richard Mudgett [Thu, 14 Mar 2019 16:53:13 +0000 (11:53 -0500)]
taskprocessor.c: Fix printf type mismatch

A size_t is not always an unsigned long.

* Use the %zu format specifier in the ast_cli() printf format string since
AST_VECTOR_SIZE() returns a size_t value.

Change-Id: Ib102dd36bbe6c2a7a4ce6870ae9110d978dd7e98

2 years agoapp.c: Remove deletion of pool topic on mwi state delete
George Joseph [Fri, 8 Mar 2019 15:40:38 +0000 (08:40 -0700)]
app.c:  Remove deletion of pool topic on mwi state delete

As part of an earlier voicemail refactor, ast_delete_mwi_state_full
was modified to remove the pool topic for a mailbox when the state
was deleted.  This was an attempt to prevent stale topics from
accumulating when app_voicemail was reloaded and a mailbox went
away.  Unfortunately because of the fact that when app_voicemail
reloads, ALL mailboxes are deleted then only current ones recreated,
topics were being removed from the pool that still had subscribers
on them, then recreated as new topics of the same name.  So now
modules like res_pjsip_mwi are listening on a topic that will
never receive any messages because app_voicemail is publishing on
a different topic that happens to have the same name.  The solutiuon
to this is not easy and given that accumulating topics for
deleted mailboxes is less evil that not sending NOTIFYs...

* Removed the call to stasis_topic_pool_delete_topic in
  ast_delete_mwi_state_full.

Also:

* Fixed a topic reference leak in res_pjsip_mwi
  mwi_stasis_subscription_alloc.

* Added some debugging to mwi_stasis_subscription_alloc,
  stasis_topic_create, and topic_dtor.

* Fixed a topic reference leak in an error path in
  internal_stasis_subscribe.

ASTERISK-28306
Reported-by: Jared Hull

Change-Id: Id7da0990b3ac4be4b58491536b35f41291247b27

2 years agoMerge "stasis: Improve topic/subscription names and statistics."
Joshua C. Colp [Thu, 14 Mar 2019 14:22:14 +0000 (09:22 -0500)]
Merge "stasis: Improve topic/subscription names and statistics."

2 years agoMerge "res_musiconhold: Remove redundant option parsing"
Joshua C. Colp [Thu, 14 Mar 2019 14:19:55 +0000 (09:19 -0500)]
Merge "res_musiconhold: Remove redundant option parsing"

2 years agores/res_ari: Added ARI resource /ari/channels/{channelId}/rtp_statistics
sungtae kim [Sat, 2 Mar 2019 11:37:21 +0000 (12:37 +0100)]
res/res_ari: Added ARI resource /ari/channels/{channelId}/rtp_statistics

Added ARI resource for channel statistics.
GET /ari/channels/{channelId}/rtp_statistics : It returns given
channel's rtp statistics detail.

ASTERISK-28320

Change-Id: I4343eec070438cec13f2a4f22e7fd9e574381376

2 years agoMerge "stasis: Allow empty application arguments to move."
Joshua C. Colp [Wed, 13 Mar 2019 16:46:13 +0000 (11:46 -0500)]
Merge "stasis: Allow empty application arguments to move."

2 years agoVariable ALTCONF ignored when service is used in Debian
cirillor [Sat, 9 Mar 2019 14:39:26 +0000 (11:39 -0300)]
Variable ALTCONF ignored when service is used in Debian

When variable ALTCONF is defined, the command start prints the message
"Unable to open specified master config file '"/etc/asterisk/asteris..."
and use default configurations.

ASTERISK-28332

Change-Id: I7595e582a0ee2c1051ea35435e247e27906957ef

2 years agoMerge "app_queue: fix ring_entry to access nativeformats with a channel lock"
Kevin Harwell [Wed, 13 Mar 2019 16:17:48 +0000 (11:17 -0500)]
Merge "app_queue: fix ring_entry to access nativeformats with a channel lock"

2 years agoMerge "chan_dahdi: Add logical group at DAHDIChannel event and CHANNEL function"
Kevin Harwell [Wed, 13 Mar 2019 15:55:20 +0000 (10:55 -0500)]
Merge "chan_dahdi: Add logical group at DAHDIChannel event and CHANNEL function"

2 years agostasis: Allow empty application arguments to move.
Joshua Colp [Wed, 13 Mar 2019 11:05:57 +0000 (08:05 -0300)]
stasis: Allow empty application arguments to move.

Change-Id: I1e4d37415f3034abe36496dc30209c2303e6af5c

2 years agoRevert "Test_cel: Fails when DONT_OPTIMIZE is off"
Corey Farrell [Wed, 13 Mar 2019 01:39:12 +0000 (21:39 -0400)]
Revert "Test_cel: Fails when DONT_OPTIMIZE is off"

This reverts commit 1c8378bbc9639739c079df37897ff02f94af0f07.

Change-Id: I1b9227b263c3dc4246a50aebf52a7640a0f7ea07

2 years agoMerge "partial-inlining: disable partial-inlining if gcc>=8.2.1"
Joshua C. Colp [Wed, 13 Mar 2019 12:24:47 +0000 (07:24 -0500)]
Merge "partial-inlining: disable partial-inlining if gcc>=8.2.1"

2 years agoapp_queue: fix ring_entry to access nativeformats with a channel lock
Dömsödi Gergely [Wed, 6 Mar 2019 13:20:09 +0000 (14:20 +0100)]
app_queue: fix ring_entry to access nativeformats with a channel lock

Fixes an intermittent segmentation fault which occured when accessing
nativeformats of a channel which entered into a queue.

ASTERISK-27964
Reported by: Francisco Seratti

Change-Id: Ic87fa7a363f3b487c24ce07032f4b2201c22db9e

2 years agoMakefile.moddir_rules: Pass PJPROJECT_BUNDLED to download_externals
George Joseph [Tue, 12 Mar 2019 18:25:33 +0000 (12:25 -0600)]
Makefile.moddir_rules: Pass PJPROJECT_BUNDLED to download_externals

The download_externals script wasn't getting the PJPROJECT_BUNDLED
environment variable passed down to it so it wasn't downloading
the appropriate variant of res_digium_phone.  This could cause
crashes in the DPMA.

Change-Id: I5daa9369c7af1fd556d892e89a85f279a2533425

2 years agoMerge "chan_pjsip: add a flag to ignore 183 responses if no SDP present"
Friendly Automation [Tue, 12 Mar 2019 15:10:12 +0000 (10:10 -0500)]
Merge "chan_pjsip: add a flag to ignore 183 responses if no SDP present"

2 years agores/res_ari: Added timestamp as a requirement for all ARI events
sungtae kim [Wed, 6 Mar 2019 22:21:42 +0000 (23:21 +0100)]
res/res_ari: Added timestamp as a requirement for all ARI events

Changed to requirement to having timestamp for all of ARI events.
The below ARI events were changed to having timestamp.
PlaybackStarted, PlaybackContinuing, PlaybackFinished,
RecordingStarted, RecordingFinished, RecordingFailed,
ApplicationReplaced, ApplicationMoveFailed

ASTERISK-28326

Change-Id: I382c2fef58f5fe107e1074869a6d05310accb41f

2 years agopartial-inlining: disable partial-inlining if gcc>=8.2.1
Chris-Savinovich [Thu, 7 Mar 2019 19:48:04 +0000 (13:48 -0600)]
partial-inlining: disable partial-inlining if gcc>=8.2.1

Apply flag -fno-partial-inlining on default optimization if and only if
gcc version >= 8.2.1 (this is the current ver on Fedora and Ubuntu).
This is done to avoid a bug that causes arithmetic calculations to fail
if the following conditions are met:
1. TEST_FRAMEWORK on
2. DONT_OPTIMIZE off
3. Fedora and Ubuntu
4. GCC 8.2.1
5. There must exist a certain combination of multithreading.
6. Optimization level -O2 and -O3
7. Flag -fpartial-inline activated (default when optimization level>=2)
The following link points to a similar gcc bug reported in 2015. This leads me
to believe the bug has regressed. Note I am not able to replicate this bug
in an environment other than Asterisk + Test Framework + Test_cel because the
multithreading combination that causes it seems to be unique. Therefore I
am temporarily abandoning any thoughts of reporting the new occurrence of this
bug to gcc.gnu.org.  https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65307

Change-Id: Ibd1afe60e0a38b88e85fdcd9b051004601c2f102

2 years agoMerge "app_meetme: Don't mute joining admins if conference is muted"
George Joseph [Mon, 11 Mar 2019 14:49:03 +0000 (09:49 -0500)]
Merge "app_meetme: Don't mute joining admins if conference is muted"

2 years agoMerge "res/res_rtp_asterisk.c: Fixing possible divide by zero"
Friendly Automation [Mon, 11 Mar 2019 14:45:28 +0000 (09:45 -0500)]
Merge "res/res_rtp_asterisk.c: Fixing possible divide by zero"

2 years agostasis: Improve topic/subscription names and statistics.
Joshua Colp [Thu, 7 Mar 2019 12:28:31 +0000 (08:28 -0400)]
stasis: Improve topic/subscription names and statistics.

Topic names now follow: <subsystem>:<functionality>[/<object>]

This ensures that they are all unique, and also provides better
insight in to what each topic is for.

Subscriber ids now also use the main topic name they are
subscribed to and an incrementing integer as their identifier to
make it easier to understand what the subscription is primarily
responsible for.

Both the CLI commands for listing topic and subscription statistics
now sort to make it a bit easier to see what is going on.

Subscriptions will now show all topics that they are receiving messages
from, not just the main topic they were subscribed to.

ASTERISK-28335

Change-Id: I484e971a38c3640f2bd156282e532eed84bf220d

2 years agochan_dahdi: Add logical group at DAHDIChannel event and CHANNEL function
cirillor [Tue, 5 Mar 2019 14:15:00 +0000 (11:15 -0300)]
chan_dahdi: Add logical group at DAHDIChannel event and CHANNEL function

Add logical group at DAHDIChannel event
and create "dahdi_group" at CHANNEL function.

ASTERISK-28317

Change-Id: Ic1f834cd53982a9707a9748395ee746d6575086a

2 years agores/res_rtp_asterisk.c: Fixing possible divide by zero
sungtae kim [Sun, 3 Mar 2019 15:20:24 +0000 (16:20 +0100)]
res/res_rtp_asterisk.c: Fixing possible divide by zero

Currently, when the Asterisk calculates rtp statistics, it uses
sample_count as a unsigned integer parameter. This would be fine
for most of cases, but in case of large enough number of sample_count,
this might be causing the divide by zero error.

ASTERISK-28321

Change-Id: If7e0629abaceddd2166eb012456c53033ea26249

2 years agores_musiconhold: Remove redundant option parsing
Sean Bright [Fri, 8 Mar 2019 20:12:24 +0000 (15:12 -0500)]
res_musiconhold: Remove redundant option parsing

Change-Id: I481fabd8eaf2e4e7ffb5c8285b294742826e7d12

2 years agochan_pjsip: add a flag to ignore 183 responses if no SDP present
Torrey Searle [Mon, 4 Mar 2019 07:50:18 +0000 (08:50 +0100)]
chan_pjsip: add a flag to ignore 183 responses if no SDP present

chan_sip will always ignore 183 responses that do not contain SDP
however, chan_pjsip will currently always translate it into a
183 with SDP.  This new flag allows chan_pjsip to have the same
behavior as chan_sip.

ASTERISK-28322 #close

Change-Id: If81cfaa17c11b6ac703e3d71696f259d86c6be4a

2 years agojansson: json_pack with new format to verify required runtime version.
Corey Farrell [Thu, 7 Mar 2019 23:17:49 +0000 (18:17 -0500)]
jansson: json_pack with new format to verify required runtime version.

Add a json_pack at startup that will fail if runtime links against a
library older than jansson-2.11.

Change-Id: I101aebafe0f9407650206f7c552dad3d69377b5a

2 years agoMerge "res_stasis: Add ability to switch applications."
George Joseph [Fri, 8 Mar 2019 18:43:45 +0000 (12:43 -0600)]
Merge "res_stasis: Add ability to switch applications."