5 years agopjproject/patches/config_site: Increase the max number of ICE candidates
Matt Jordan [Wed, 29 Jun 2016 20:09:02 +0000 (15:09 -0500)]
pjproject/patches/config_site: Increase the max number of ICE candidates

When negotiating ICE candidates with WebRTC capable endpoints, many
networks will result in a browser offering ICE candidates that exceeds
the default number of max candidates, 16. This patch bumps the max
candidates to 32, with the max checks at twice the number of candidates.
In practice, this has shown to be sufficient for browser/WebRTC

Change-Id: Ifd8da8b315f5ae14814d4ce20e10d2e6355020e5

5 years agoMerge "codecs: Fix ABI incompatibility created by adding format_name to ast_codec"
zuul [Wed, 29 Jun 2016 17:24:14 +0000 (12:24 -0500)]
Merge "codecs:  Fix ABI incompatibility created by adding format_name to ast_codec"

5 years agoMerge "siren: Add format attribute modules for Siren7 and Siren14."
zuul [Wed, 29 Jun 2016 16:30:53 +0000 (11:30 -0500)]
Merge "siren: Add format attribute modules for Siren7 and Siren14."

5 years agoMerge "BuildSystem: Avoid obsolete warning with AC_TYPE_SIGNAL on autoconf."
zuul [Wed, 29 Jun 2016 16:16:05 +0000 (11:16 -0500)]
Merge "BuildSystem: Avoid obsolete warning with AC_TYPE_SIGNAL on autoconf."

5 years agocodecs: Fix ABI incompatibility created by adding format_name to ast_codec
George Joseph [Tue, 28 Jun 2016 14:00:32 +0000 (08:00 -0600)]
codecs:  Fix ABI incompatibility created by adding format_name to ast_codec

Adding format_name even to the end of ast_codec caused issued with
binary codec modules because the pointer would be garbage in asterisk
when they registered.  So, the ast_codec structure was reverted and an
internal_ast_codec structure was created just for use in codec.c.  A new
internal-only API was also added (__ast_codec_register_with_format) so
that codec_builtin could register codecs with the format_name in a
separate parameter rather than in the ast_codec structure.

ASTERISK-26144 #close
Reported-by: Alexei Gradinari

Change-Id: I6df1b08f6a6ae089db23adfe1ebc8636330265ba

5 years agoMerge "BuildSystem: Fix a few issues hightlighted by gcc 6.x"
Joshua Colp [Tue, 28 Jun 2016 19:57:06 +0000 (14:57 -0500)]
Merge "BuildSystem:  Fix a few issues hightlighted by gcc 6.x"

5 years agoBuildSystem: Fix a few issues hightlighted by gcc 6.x
George Joseph [Tue, 28 Jun 2016 13:22:24 +0000 (07:22 -0600)]
BuildSystem:  Fix a few issues hightlighted by gcc 6.x

gcc 6.1.1 caught a few more issues.
Made sure the unit tests still pass for the func_env and stdtime

ASTERISK-26157 #close

Change-Id: I6664d8f34a45bc1481d2a854481c7878b0c1cf8e

5 years agoconfigs/basic-pbx/modules.conf: Remove 'bad' modules
Matt Jordan [Tue, 28 Jun 2016 15:33:30 +0000 (10:33 -0500)]
configs/basic-pbx/modules.conf: Remove 'bad' modules

This patch removes the following modules:
 - pbx_functions: It never existed.
 - res_pjsip_log_forwarder: It no longer exists.
 - res_hep_pjsip: The base HEP module wasn't loaded, and most basic PBXs
                  aren't going to be installing HOMER
 - res_pjsip_phoneprov_provider: The basic res_phoneprov module isn't
                  loaded, and we aren't configured to make use of the

Change-Id: Id91f68cae7c9c8c3d370029fe1268cb51e4ff5a5

5 years agosiren: Add format attribute modules for Siren7 and Siren14.
Joshua Colp [Wed, 22 Jun 2016 16:19:32 +0000 (13:19 -0300)]
siren: Add format attribute modules for Siren7 and Siren14.

This change removes hardcoded SDP parsing and generation for
Siren7 and Siren14 from chan_sip and moves it to format attribute
modules so it can also be used by chan_pjsip.

With this the fmtp lines for both are added with the bitrate


Change-Id: Ibb004eda37a14c0a35ef0613f6237977fc800037

5 years agoBuildSystem: Avoid obsolete warning with AC_TYPE_SIGNAL on autoconf.
Alexander Traud [Thu, 23 Jun 2016 09:33:06 +0000 (11:33 +0200)]
BuildSystem: Avoid obsolete warning with AC_TYPE_SIGNAL on autoconf.

Removed the obsolete macro AC_TYPE_SIGNAL because Asterisk does not use K&R C
but requires ANSI C anyway.


Change-Id: I914c014385e1862102d90fe7650621def78db02e

5 years agoMerge "res_fax: Fix reference leak in fax_v21_session_new."
zuul [Thu, 23 Jun 2016 02:50:22 +0000 (21:50 -0500)]
Merge "res_fax: Fix reference leak in fax_v21_session_new."

5 years agoMerge "res_rtp_asterisk: Fix a self-comparison identified by gcc 6"
Joshua Colp [Thu, 23 Jun 2016 01:16:03 +0000 (20:16 -0500)]
Merge "res_rtp_asterisk:  Fix a self-comparison identified by gcc 6"

5 years agoMerge "chan_unistim: Fix memcpy in get_to_address"
zuul [Wed, 22 Jun 2016 23:50:57 +0000 (18:50 -0500)]
Merge "chan_unistim:  Fix memcpy in get_to_address"

5 years agoMerge "BuildSystem: Avoid obsolete warning with AC_FUNC_SETVBUF_REVERSED on autoconf."
zuul [Wed, 22 Jun 2016 23:50:48 +0000 (18:50 -0500)]
Merge "BuildSystem: Avoid obsolete warning with AC_FUNC_SETVBUF_REVERSED on autoconf."

5 years agoMerge "Fix Alembic upgrades."
Joshua Colp [Wed, 22 Jun 2016 21:06:06 +0000 (16:06 -0500)]
Merge "Fix Alembic upgrades."

5 years agores_fax: Fix reference leak in fax_v21_session_new.
Corey Farrell [Wed, 22 Jun 2016 20:04:54 +0000 (16:04 -0400)]
res_fax: Fix reference leak in fax_v21_session_new.

fax_v21_session_new created a session details object but only released
the allocation reference during error conditions.  fax_session_new adds
it's own reference to details if needed so the caller is always
responsible for cleaning it's own reference.

ASTERISK-26141 #close

Change-Id: Ie7fc52a83b6596ce9ce2d5a2bd9f3e204f48fc88

5 years agoMerge "res_pjproject.c: Replace inlined DEBUG_ATLEAST() with macro."
zuul [Wed, 22 Jun 2016 19:36:46 +0000 (14:36 -0500)]
Merge "res_pjproject.c: Replace inlined DEBUG_ATLEAST() with macro."

5 years agores_rtp_asterisk: Fix a self-comparison identified by gcc 6
George Joseph [Wed, 22 Jun 2016 18:41:57 +0000 (12:41 -0600)]
res_rtp_asterisk:  Fix a self-comparison identified by gcc 6

gcc 6 caught a previously unidentified self-comparison in
ice_candidate_cmp.  Fixed it and re-ordered the predicates for better

ASTERISK-26140 #close

Change-Id: I3da713c568e24064430257b3502fbdafd35af7a7

5 years agochan_unistim: Fix memcpy in get_to_address
George Joseph [Wed, 22 Jun 2016 15:37:23 +0000 (09:37 -0600)]
chan_unistim:  Fix memcpy in get_to_address

A code block only enabled when HAVE_PKTINFO is not defined (FreeBSD)
was using a pointer to a pointer as the destination of a memcpy and a
'&' instead of '*' in the sizeof.

ASTERISK-26138 #close

Change-Id: Id4927ff256c0e470bdf7bcfc025146a2f656e708

5 years agoFix Alembic upgrades.
Mark Michelson [Mon, 20 Jun 2016 18:21:52 +0000 (13:21 -0500)]
Fix Alembic upgrades.

A non-existent constraint was being referenced in the upgrade script.
This patch corrects the problem by removing the reference.

In addition, the head of the alembic branch referred to a non-existent
revision. This has been fixed by referring to the proper revision.

This patch fixes another realtime problem as well. Our Alembic scripts
store booleans as yes or no values. However, Sorcery tries to insert
"true" or "false" instead. This patch introduces a new boolean type that
translates to "yes" or "no" instead.

ASTERISK-26128 #close

Change-Id: I51574736a881189de695a824883a18d66a52dcef

5 years agotest_res_pjsip_scheduler: Add 'depends' on pjproject in MODULEINFO
George Joseph [Wed, 22 Jun 2016 15:51:14 +0000 (09:51 -0600)]
test_res_pjsip_scheduler: Add 'depends' on pjproject in MODULEINFO

Since the file was missing the depends on pjproject, it wasn't
picking up the pjproject related include path.  If there was no
system installed pjproject and pjproject-bundled was used, a compile
would fail because pjsip.h wasn't found.

ASTERISK-26139 #close

Change-Id: I2ee64a999051452bc198c4e2c168c70769cd3757

5 years agoBuildSystem: Avoid obsolete warning with AC_FUNC_SETVBUF_REVERSED on autoconf.
Alexander Traud [Wed, 22 Jun 2016 15:55:05 +0000 (17:55 +0200)]
BuildSystem: Avoid obsolete warning with AC_FUNC_SETVBUF_REVERSED on autoconf.

Removed the obsolete macro AC_FUNC_SETVBUF_REVERSED because Asterisk does not
support the platform SVR2 from the year 1987 anymore.


Change-Id: I28161b037feb2d29ab46ed20e785928460226c22

5 years agoMerge "res_rtp_asterisk: fix memory leak in dtls"
Joshua Colp [Wed, 22 Jun 2016 15:52:54 +0000 (10:52 -0500)]
Merge "res_rtp_asterisk: fix memory leak in dtls"

5 years agoMerge "res_pjsip_pubsub: Address SEGV when attempting to terminate a subscription"
Joshua Colp [Wed, 22 Jun 2016 10:11:54 +0000 (05:11 -0500)]
Merge "res_pjsip_pubsub: Address SEGV when attempting to terminate a subscription"

5 years agores_rtp_asterisk: fix memory leak in dtls
Torrey Searle [Tue, 21 Jun 2016 11:52:20 +0000 (13:52 +0200)]
res_rtp_asterisk: fix memory leak in dtls

ensure that cert bios get freed after creating the fingerprint

ASTERISK-26129 #close

Change-Id: I44d23aea07dce80176ca1ff877c5ace9452ef451

5 years agoMerge "res_rtp_asterisk: Use latest DTLS version available by underlying platform."
Joshua Colp [Wed, 22 Jun 2016 00:39:51 +0000 (19:39 -0500)]
Merge "res_rtp_asterisk: Use latest DTLS version available by underlying platform."

5 years agoMerge "res_pjsip_session: Handle race condition at shutdown with timer."
Joshua Colp [Tue, 21 Jun 2016 23:53:33 +0000 (18:53 -0500)]
Merge "res_pjsip_session: Handle race condition at shutdown with timer."

5 years agores_pjproject.c: Replace inlined DEBUG_ATLEAST() with macro.
Richard Mudgett [Tue, 21 Jun 2016 22:42:28 +0000 (17:42 -0500)]
res_pjproject.c: Replace inlined DEBUG_ATLEAST() with macro.

Change-Id: I8799fb0a347ad76e747dafd0eacf1ea1086b9a8c

5 years agoMerge "PJSIP: provide transport type with received messages"
zuul [Tue, 21 Jun 2016 20:05:35 +0000 (15:05 -0500)]
Merge "PJSIP: provide transport type with received messages"

5 years agores_pjsip_pubsub: Address SEGV when attempting to terminate a subscription
George Joseph [Sun, 12 Jun 2016 16:19:27 +0000 (10:19 -0600)]
res_pjsip_pubsub: Address SEGV when attempting to terminate a subscription

Occasionally under load we'll attempt to send a final NOTIFY on a
subscription that's already been terminated and a SEGV will occur
down in pjproject's evsub_destroy function.  This is a result of a
race condition between all the paths that can generate a notify
and/or destroy the underlying pjproject evsub object:

 * The client can send a SUBSCRIBE with Expires: 0.
 * The client can send a SUBSCRIBE/refresh.
 * The subscription timer can expire.
 * An extension state can change.
 * An MWI event can be generated.
 * The pjproject transaction timer (timer_b) can expire.

Normally when our pubsub_on_evsub_state is called with a terminate,
we push a task to the serializer and return at which point the dialog
is unlocked.  This is usually not a problem because the task runs
immediately and locks the dialog again.  When the system is heavily
loaded though, there may be a delay between the unlock and relock
during which another event may occur such as the subscription timer
or timer_b expiring, an extension state change, etc.  These may also
cause a terminate to be processed and if so, we could cause pjproject
to try to destroy the evsub structure twice.  There's no way for us to
tell that the evsub was already destroyed and the evsub's group lock
can't tolerate this and SEGVs.

The remedy is twofold.

 * A patch has been submitted to Teluu and added to the bundled
   pjproject which adds add/decrement operations on evsub's group lock.

 * In res_pjsip_pubsub:
   * and pjproject-bundled's configure.m4 were updated
     to check for the new evsub group lock APIs.
   * We now add a reference to the evsub group lock when we create
     the subscription and remove the reference when we clean up the
     subscription.  This prevents evsub from being destroyed before
     we're done with it.
   * A state has been added to the subscription tree structure so
     termination progress can be tracked through the asyncronous tasks.
   * The pubsub_on_evsub_state callback has been split so it's not doing
     double duty.  It now only handles the final cleanup of the
     subscription tree.  pubsub_on_rx_refresh now handles both client
     refreshes and client terminates.  It was always being called for
     both anyway.
   * The serialized_on_server_timeout task was removed since
     serialized_pubsub_on_rx_refresh was almost identical.
   * Missing state checks and ao2_cleanups were added.
   * Some debug levels were adjusted to make seeing only off-nominal
     things at level 1 and nominal or progress things at level 2+.

ASTERISK-26099 #close
Reported-by: Ross Beer.

Change-Id: I779d11802cf672a51392e62a74a1216596075ba1

5 years agores_rtp_asterisk: Use latest DTLS version available by underlying platform.
Alexander Traud [Tue, 21 Jun 2016 12:05:30 +0000 (14:05 +0200)]
res_rtp_asterisk: Use latest DTLS version available by underlying platform.

Do not use DTLSv1_method() but DTLS_method() when available in OpenSSL of the
underlying platform. This change enables DTLS 1.2 since OpenSSL 1.0.2, for
WebRTC (DTLS-SRTP via SIP-over-WebSockets). This change enables AEAD-based

ASTERISK-26130 #close

Change-Id: I41f24448d6d2953e8bdb97c9f4a6bc8a8f055fd0

5 years agoPJSIP: provide transport type with received messages
Scott Griepentrog [Tue, 21 Jun 2016 15:53:05 +0000 (10:53 -0500)]
PJSIP: provide transport type with received messages

The receipt of a SIP MESSAGE may occur over any transport including TCP
and TLS. When the message is received, the original URI is added to the
message in the field PJSIP_RECVADDR, but this is insufficient to ensure
a reply message can reach the originating endpoint. This patch adds the
PJSIP_TRANSPORT field populated with the transport type.

ASTERISK-26132 #close

Change-Id: I28c4b1e40d573a056c81deb213ecf53e968f725e

5 years agoBuildSystem: Avoid obsolete warning with HELP_STRING on autoconf.
Alexander Traud [Tue, 21 Jun 2016 13:01:40 +0000 (15:01 +0200)]
BuildSystem: Avoid obsolete warning with HELP_STRING on autoconf.

Some configure scripts used both AC_HELP_STRING and its replacement
AS_HELP_STRING. For consistency and to avoid obsolete warnings, those were
changed to AS_HELP_STRING.


Change-Id: I8aad4fd2bdee40aa2a31ce3339a1eb33ff4f5b0f

5 years agoMerge "fix: memory leaks, resource leaks, out of bounds and bugs"
zuul [Tue, 21 Jun 2016 12:26:12 +0000 (07:26 -0500)]
Merge "fix: memory leaks, resource leaks, out of bounds and bugs"

5 years agoMerge "app_voicemail.c: Fix IMAP compile error."
zuul [Mon, 20 Jun 2016 19:45:16 +0000 (14:45 -0500)]
Merge "app_voicemail.c: Fix IMAP compile error."

5 years agores_pjsip_session: Handle race condition at shutdown with timer.
Joshua Colp [Mon, 20 Jun 2016 15:29:13 +0000 (12:29 -0300)]
res_pjsip_session: Handle race condition at shutdown with timer.

When shutting down res_pjsip_session will get unloaded before res_pjsip.
The act of unloading unregisters all the PJSIP services and sets
their module IDs to -1. In some cases it is possible for a timer to
occur after this happens which calls into res_pjsip_session. The
res_pjsip_session module can then try to get the session from the
INVITE session using the module ID. Since the module ID is now -1
this fails.

This change stores a copy of the module ID and uses it for the timer
callback scenario. If the module ID is -1 the callback immediately
returns but if the module ID is valid then it continues as normal.

This works as the original ID of the module is guaranteed to still
be valid when used with the INVITE session.

ASTERISK-26127 #close

Change-Id: I88df72525c4e9ef9f19c13aedddd3ac4a335c573

5 years agoMerge "http: leverage 'bindaddr' for TLS in http.conf"
zuul [Mon, 20 Jun 2016 18:28:12 +0000 (13:28 -0500)]
Merge "http: leverage 'bindaddr' for TLS in http.conf"

5 years agoapp_voicemail.c: Fix IMAP compile error.
Richard Mudgett [Mon, 20 Jun 2016 17:13:27 +0000 (12:13 -0500)]
app_voicemail.c: Fix IMAP compile error.

Fix compile error introduced by the patch for

Change-Id: I5b02876266f2824f4cec2b54d6ff4db5de5778d3

5 years agofix: memory leaks, resource leaks, out of bounds and bugs
Alexei Gradinari [Fri, 17 Jun 2016 18:51:57 +0000 (14:51 -0400)]
fix: memory leaks, resource leaks, out of bounds and bugs

ASTERISK-26119 #close

Change-Id: Iecbf7d0f360a021147344c4e83ab242fd1e7512c

5 years agoARI: Ensure announcer channels are destroyed.
Mark Michelson [Mon, 13 Jun 2016 22:40:07 +0000 (17:40 -0500)]
ARI: Ensure announcer channels are destroyed.

Announcer channels were not being destroyed because the
stasis_app_control structure that referenced them was not being
destroyed. The control structure was not being destroyed because it was
not being unlinked from its container. It was not being unlinked from
its container because the after bridge callback for the announcer
channel was not being run. The after bridge callback was not being run
because the after bridge datastore was not being removed from the
channel on destruction. The channel was not being destroyed because the
hangup that used to destroy the channel was now only reducing the
reference count to one. The reference count of the channel was only
being reduced to one because the stasis_app_control structure was
holding the final reference...

The control structure used to not keep a reference to the channel, so
that loop described above did not happen.

The solution is to manually remove the control structure from its
container when the playback on a bridge is complete.

ASTERISK-26083 #close
Reported by Joshua Colp

Change-Id: I0ddc0f64484ea0016245800b409b567dfe85cfb4

5 years agohttp: leverage 'bindaddr' for TLS in http.conf
Alexander Traud [Mon, 20 Jun 2016 13:05:09 +0000 (15:05 +0200)]
http: leverage 'bindaddr' for TLS in http.conf

The internal HTTP/WebSocket server supports both TCP and TLS, which can be
activated separately via the file http.conf. The source code intends to re-use
the TCP parameter 'bindaddr' for TLS, even if 'tlsbindaddr' is not specified
explicitly. This did not work because of a typo. This change resolves this typo.

ASTERISK-26126 #close

Change-Id: I5efb0409ae12044dfb3495b6b97b6d40a8c9c51f

5 years agoMerge "Add support for OGG/Speex file format"
Joshua Colp [Fri, 17 Jun 2016 19:03:57 +0000 (14:03 -0500)]
Merge "Add support for OGG/Speex file format"

5 years agoMerge "chan_sip: bigger buffers for headers, better failure mode"
zuul [Thu, 16 Jun 2016 22:59:32 +0000 (17:59 -0500)]
Merge "chan_sip: bigger buffers for headers, better failure mode"

5 years agores_pjsip_transport_management.c: Misc cleanups to survive shutdown.
Richard Mudgett [Wed, 18 May 2016 22:37:27 +0000 (17:37 -0500)]
res_pjsip_transport_management.c: Misc cleanups to survive shutdown.

* In unload_module(), reordered destroying things to minimize the window
that the global transports container could be used by other threads on
shutdown.  When shutting down you need to stop things in the opposite
order of creation.

* Put the global transports container into an AO2_GLOBAL_OBJ_STATIC to
eliminate the crash potential by other threads using the container on

* Made struct monitored_transport.sip_received not use
ast_atomic_fetchadd_int() since it is used as a boolean value that is only
set TRUE.  It was previously incremented for every received SIP message
and could theoretically overflow.

* In monitored_transport_state_callback(), allocated the monitored
transport object without a lock since the lock was unused.

* In keepalive_global_loaded(), removed releasing the transports container
if the keepalive_thread could not be started.  I set it up to be tried
again if the user reloads the configuration.

Change-Id: I8d12d16ef564290fa6d25a32334bb5ce8fdf87ff

5 years agores_pjsip.c: Add check that timer actually got scheduled.
Richard Mudgett [Wed, 6 Jan 2016 01:08:24 +0000 (19:08 -0600)]
res_pjsip.c: Add check that timer actually got scheduled.

Change-Id: Iabaa2e5dccf0762c258101ea0eb1487cf6959ad1

5 years agoMerge "res_pjsip_session.c: Reorganize ast_sip_session_terminate()."
zuul [Tue, 14 Jun 2016 18:36:41 +0000 (13:36 -0500)]
Merge "res_pjsip_session.c: Reorganize ast_sip_session_terminate()."

5 years agores_rtp_multicast.c: Fix warning message typo.
Richard Mudgett [Mon, 13 Jun 2016 18:33:53 +0000 (13:33 -0500)]
res_rtp_multicast.c: Fix warning message typo.

Change-Id: Ic9928208b9957e09866abe3d9649030942ec52b3

5 years agores_pjsip_session.c: Reorganize ast_sip_session_terminate().
Richard Mudgett [Fri, 12 Feb 2016 00:15:31 +0000 (18:15 -0600)]
res_pjsip_session.c: Reorganize ast_sip_session_terminate().

Change-Id: I68a2128bcba4830985d2d441e70dfd1ac5bd712b

5 years agoMerge "core: Not the configured but granted number of possible file descriptors."
zuul [Fri, 10 Jun 2016 20:50:35 +0000 (15:50 -0500)]
Merge "core: Not the configured but granted number of possible file descriptors."

5 years agocore: Not the configured but granted number of possible file descriptors.
Alexander Traud [Wed, 8 Jun 2016 11:15:15 +0000 (13:15 +0200)]
core: Not the configured but granted number of possible file descriptors.

With CLI "core show settings", simply the parameter maxfiles of the file
asterisk.conf was shown. If that parameter was not set, nothing was displayed
although the environment might have set a default number itself. Or if maxfiles
were not granted (completely), still maxfiles was shown. Now, the maximum number
of possible file descriptors in the environment is shown.


Change-Id: I2df5c58863b5007b34b77adbe28b885dfcdf7e0b

5 years agoMerge "astfd: With RLIMIT_NOFILE only the current value is sensible."
Joshua Colp [Fri, 10 Jun 2016 18:46:48 +0000 (13:46 -0500)]
Merge "astfd: With RLIMIT_NOFILE only the current value is sensible."

5 years agotranslate: Enables native Packet-Loss Concealment (PLC) for supporting codecs.
Joshua Colp [Fri, 10 Jun 2016 15:39:27 +0000 (12:39 -0300)]
translate: Enables native Packet-Loss Concealment (PLC) for supporting codecs.

This reverts commit 5bfef2a8b4674382f959b21a3b8e14cf1d942bab as it
caused fax test failures.


Change-Id: I79de974dc4f63a1cafe0d2509169fd9a6b3cbaf4

5 years agoastfd: With RLIMIT_NOFILE only the current value is sensible.
Alexander Traud [Wed, 8 Jun 2016 11:05:22 +0000 (13:05 +0200)]
astfd: With RLIMIT_NOFILE only the current value is sensible.

With menuselect "DEBUG_FD_LEAKS" and CLI "core show fd", both the maximum max
and current max of possible file descriptors were shown. Both show the same
value always. Not to confuse users, just the current maximum is shown now.


Change-Id: I49cf7952d73aec9e3f6a88942842c39be18380fa

5 years agoMerge "cel: Ensure only one dial status per channel exists."
zuul [Fri, 10 Jun 2016 03:38:52 +0000 (22:38 -0500)]
Merge "cel: Ensure only one dial status per channel exists."

5 years agoMerge "ARI: Ensure proper channel state on operations."
zuul [Fri, 10 Jun 2016 02:50:07 +0000 (21:50 -0500)]
Merge "ARI: Ensure proper channel state on operations."

5 years agoMerge "test_http_media_cache: Fix failing test."
zuul [Fri, 10 Jun 2016 02:50:05 +0000 (21:50 -0500)]
Merge "test_http_media_cache: Fix failing test."

5 years agoMerge "chan_sip: Support auth username for callbackextension feature"
zuul [Fri, 10 Jun 2016 02:35:42 +0000 (21:35 -0500)]
Merge "chan_sip: Support auth username for callbackextension feature"

5 years agoMerge "res_pjsip_registrar.c: Eliminate rx REGISTER request race condition."
Joshua Colp [Thu, 9 Jun 2016 21:45:59 +0000 (16:45 -0500)]
Merge "res_pjsip_registrar.c: Eliminate rx REGISTER request race condition."

5 years agoMerge "stasis: Add setting subscription congestion levels."
Joshua Colp [Thu, 9 Jun 2016 21:45:54 +0000 (16:45 -0500)]
Merge "stasis: Add setting subscription congestion levels."

5 years agoMerge "sorcery: Add setting object type congestion levels."
Joshua Colp [Thu, 9 Jun 2016 21:45:48 +0000 (16:45 -0500)]
Merge "sorcery: Add setting object type congestion levels."

5 years agoMerge "taskprocessors: Implement high/low water mark alerts."
Joshua Colp [Thu, 9 Jun 2016 21:45:44 +0000 (16:45 -0500)]
Merge "taskprocessors: Implement high/low water mark alerts."

5 years agoMerge "res_pjsip_session: Use distributor serializer for incoming calls."
Joshua Colp [Thu, 9 Jun 2016 21:45:39 +0000 (16:45 -0500)]
Merge "res_pjsip_session: Use distributor serializer for incoming calls."

5 years agoMerge "res_pjsip_pubsub.c: Recreate subscriptions using distributor serializer."
Joshua Colp [Thu, 9 Jun 2016 21:45:34 +0000 (16:45 -0500)]
Merge "res_pjsip_pubsub.c: Recreate subscriptions using distributor serializer."

5 years agoMerge "res_pjsip_pubsub.c: Use distributor serializer for incoming subscriptions."
Joshua Colp [Thu, 9 Jun 2016 21:45:29 +0000 (16:45 -0500)]
Merge "res_pjsip_pubsub.c: Use distributor serializer for incoming subscriptions."

5 years agoMerge "pjsip_distributor.c: Consistently pick a serializer for messages."
Joshua Colp [Thu, 9 Jun 2016 21:45:24 +0000 (16:45 -0500)]
Merge "pjsip_distributor.c: Consistently pick a serializer for messages."

5 years agoMerge "pjsip_distributor.c: Ignore messages until fully booted."
zuul [Thu, 9 Jun 2016 21:17:33 +0000 (16:17 -0500)]
Merge "pjsip_distributor.c: Ignore messages until fully booted."

5 years agocel: Ensure only one dial status per channel exists.
Joshua Colp [Tue, 7 Jun 2016 23:45:37 +0000 (20:45 -0300)]
cel: Ensure only one dial status per channel exists.

CEL wrongly assumed that a channel would only have a single dial
event on it. This is incorrect. Particularly in a queue each
call attempt to a member will result in a dial event, adding
a new dial status in CEL without removing the old one. This
would cause the container to grow with only one dial status
being removed when the channel went away. The other dial status
entries would remain leaking memory.

This change fixes the memory leak by ensuring that only one dial
status will only ever exist for each channel.

The behavior during the scenario where multiple events are received
has also been improved. For failure cases the first failure will
be the dial status. If an answer dial status is received, though,
it will take priority and the dial status for the channel will be

Memory usage has also been decreased by storing the minimal
amount of information and the code has been cleaned up slightly.

ASTERISK-25262 #close

Change-Id: I5944eb923db17b6a0faa7317ff6abc9307c009fe

5 years agoARI: Ensure proper channel state on operations.
Mark Michelson [Wed, 1 Jun 2016 18:48:00 +0000 (13:48 -0500)]
ARI: Ensure proper channel state on operations.

ARI was recently outfitted with operations to create and dial channels.
This leads to the ability to try funny stuff. You could create a channel
and then immediately try to play back media on it. You could create a
channel, dial it, and while it is ringing attempt to make it continue in
the dialplan.

This commit attempts to fix this by adding a channel state check to
operations that should not be able to operate on outbound channels that
have not yet answered. If a channel is in an invalid state, we will send
a 412 response.

ASTERISK-26047 #close
Reported by Mark Michelson

Change-Id: I2ca51bf9ef2b44a1dc5a73f2d2de35c62c37dfd8

5 years agotest_http_media_cache: Fix failing test.
Mark Michelson [Wed, 8 Jun 2016 16:27:41 +0000 (11:27 -0500)]
test_http_media_cache: Fix failing test.

The retrieve_cache_control_directives test has been failing occasionally
in Jenkins. The apparent failure occurs when attempting to validate the
expiration of the retrieved file.

After reproducing, the problem was pretty clear. At the beginning of the
test, the current time is retrieved. The seconds value of this timestamp
is X. When the file is retrieved, res_http_media_cache calculates the
expiration and in doing so retrieves the current time. In most cases,
since the test executes quickly, it will also retrieve a timestamp with
X seconds. However, if the test starts very near to when the timestamp
seconds are set to increment, res_http_media_cache may retrieve a
timestamp with X+1 seconds instead.

The test attempted to account for this by allowing a tolerance of 1
second when validating the expiration. However, the problem was that the
comparisons being used in the validation used > and < operations. This
meant that values that fell within the tolerance (because they equaled
the upper bound of the tolerance) would fail.

The solution is to use >= and <= operators in the expiration validation.

However, I estimated that while the one second tolerance should be
fine on most machines, it would still be possible on a very slow machine
to end up falling outside the one second tolerance. So I have also
relaxed the tolerance of expiration validation to be three seconds

The final change here is to add a debug message when validating
expiration so that we can see what values are being compared.

ASTERISK-25959 #close
Reported by Joshua Colp

Change-Id: Ic1a0e10722c1c5d276d5a4d6a67136d6ec26c247

5 years agoAdd support for OGG/Speex file format
Timo Teräs [Fri, 3 Jun 2016 06:20:39 +0000 (09:20 +0300)]
Add support for OGG/Speex file format

ASTERISK-18995 #close

Change-Id: I98518bd28fc8f95668b3fe27d2cab45045ff3f7a

5 years agoMerge "chan_pjsip: Lock channel when checking for RTP changes."
zuul [Thu, 9 Jun 2016 18:53:58 +0000 (13:53 -0500)]
Merge "chan_pjsip: Lock channel when checking for RTP changes."

5 years agocdr.c: Remove assert in base_process_dial_end
George Joseph [Thu, 9 Jun 2016 15:33:48 +0000 (09:33 -0600)]
cdr.c: Remove assert in base_process_dial_end

Scenario: Caller blonde transfer
Bob calls Charlie who answers.
Bob puts Charlie on hold and calls Alice.
Before Alice answers, Bob transfers Charlie to Alice.

Charlie's channel triggers an assert because he gets an "ANSWERED"
event even though he never dialed anything. With recent changes to dial
events, this is now a valid scenario so the assert needed to be removed.

ASTERISK-26103 #close

Change-Id: I2679b517b696e7952ab7fb29403df9140e7d1de2

5 years agochan_pjsip: Lock channel when checking for RTP changes.
Mark Michelson [Thu, 9 Jun 2016 15:37:53 +0000 (10:37 -0500)]
chan_pjsip: Lock channel when checking for RTP changes.

bridge_native_rtp can call into an RTP-capable channel driver in order
for the driver to update information about who the channel is
communicating with. For SIP channel drivers, this means deactivating
RTCP and sending a reinvite so that the endpoints can communicate

bridge_native_rtp does the right thing and has the channel locked when
calling into the channel driver. chan_pjsip can't alter session
properties in this thread, though. chan_pjsip queues a task on the
session serializer in order to update properties there.

The problem is that this queued task was not locking the channel. This
meant that the queued task could attempt to deactivate RTCP at the same
time that the channel thread was attempting to process an incoming RTCP
packet. This could lead to a crash.

This patch fixes the issue by locking the channel in the queued task
when altering RTP properties.

ASTERISK-26092 #close
Reported by Niklas Larsson

Change-Id: I3464e226a3c41f6b915f97891e07fa1599e2a159

5 years agores_pjsip_registrar.c: Eliminate rx REGISTER request race condition.
Richard Mudgett [Sat, 4 Jun 2016 03:44:46 +0000 (22:44 -0500)]
res_pjsip_registrar.c: Eliminate rx REGISTER request race condition.

This patch fixes a race condition processing received REGISTER requests
and their retransmissions caused by REGISTER requests being processed by
two threads.  The "sip_transaction Unable to register REGISTER transaction
(key exists)" message is a notable symptom of this issue.

This issue was more likely to happen before the pjsip/distributor
serializers were created.  Instead of steps one and two below placing the
REGISTER messages into the same pjsip/distributor they were placed in
random pjsip/default serializers.

1) REGISTER requests come in and get placed on the pjsip/distributor

2) Before the first request is processed a retransmission comes in and is
placed on the same pjsip/distributor serializer.

3) The first request goes up the pjsip stack and is then shunted off to
the pjsip/aor/<aor> serializer.

4) Before the first request is completed processing in the pjsip/aor/<aor>
serializer, the second request goes up the pjsip stack and is also shunted
off to the pjsip/aor/<aor> serializer.

5) The first request completes processing and sends out its response.

6) The second request completes processing and tries to send out its
response but pjlib complains that the REGISTER transaction key already

7) Sadness ensues.

* The race is eliminated by removing the pjsip/aor/<aor> serializer and
continuing the processing in the pjsip/distributor serializer.  Now any
retransmissions queued in the pjsip/distributor serializer will be
processed after the first message is completely processed.

ASTERISK-26088 #close
Reported by:  Richard Mudgett

Change-Id: I842d714346088bf717ea27437f1dd85bff0bab5a

5 years agostasis: Add setting subscription congestion levels.
Richard Mudgett [Fri, 3 Jun 2016 16:35:49 +0000 (11:35 -0500)]
stasis: Add setting subscription congestion levels.

Stasis subscriptions and message routers create taskprocessors to process
the event messages.  API calls are needed to be able to set the congestion
levels of these taskprocessors for selected subscriptions and message

* Updated CDR, CEL, and manager's stasis subscription congestion levels
based upon stress testing.  Increased the congestion levels to reduce the
potential for bursty call setup/teardown activity from triggering the
taskprocessor overload alert.  CDRs in particular need an extra high
congestion level because they can take awhile to process the stasis

Reported by:  Richard Mudgett

Change-Id: Id0a716394b4eee746dd158acc63d703902450244

5 years agosorcery: Add setting object type congestion levels.
Richard Mudgett [Thu, 2 Jun 2016 23:19:13 +0000 (18:19 -0500)]
sorcery: Add setting object type congestion levels.

Sorcery creates taskprocessors for object types to process object observer
callbacks.  An API call is needed to be able to set the congestion levels
of these taskprocessors for selected object types.

* Updated PJSIP's contact and contact_status sorcery object type observer
default congestion levels based upon stress testing.  Increased the
congestion levels to reduce the potential for bursty register/unregister
and subscribe/unsubscribe activity from triggering the taskprocessor
overload alert.

Reported by:  Richard Mudgett

Change-Id: I4542e83b556f0714009bfeff89505c801f1218c6

5 years agotaskprocessors: Implement high/low water mark alerts.
Richard Mudgett [Thu, 2 Jun 2016 21:08:19 +0000 (16:08 -0500)]
taskprocessors: Implement high/low water mark alerts.

When taskprocessors get backed up, there is a good chance that we are
being overloaded and need to defer adding new work to the system.

* Implemented a high/low water alert mechanism for modules to check if the
system is being overloaded and take appropriate action.  When a
taskprocessor is created it has default congestion levels set.  A
taskprocessor can later have those congestion levels altered for specific
needs if stress testing shows that the taskprocessor is a symptom of
overloading or needs to handle bursty activity without triggering an
overload alert.

* Add CLI "core show taskprocessor" low/high water columns.

* Fixed __allocate_taskprocessor() to not use RAII_VAR().  RAII_VAR() was
never a good thing to use when creating a taskprocessor because of the
nature of how its references needed to be cleaned up on a partial

* Made res_pjsip's distributor check if the taskprocessor overload alert
is active before placing a message representing brand new work onto a
distributor serializer.

Reported by:  Richard Mudgett

Change-Id: I182f1be603529cd665958661c4c05ff9901825fa

5 years agores_pjsip_session: Use distributor serializer for incoming calls.
Richard Mudgett [Fri, 27 May 2016 22:31:52 +0000 (17:31 -0500)]
res_pjsip_session: Use distributor serializer for incoming calls.

We must continue using the serializer that the original INVITE came in on
for the dialog.  There may be retransmissions already enqueued in the
original serializer that can result in reentrancy and message sequencing

Outgoing call legs create the pjsip/outsess/<endpoint> serializers for
their dialogs.

Reported by:  Richard Mudgett

Change-Id: I24d7948749c582b8045d5389ba3f6588508adbbc

5 years agores_pjsip_pubsub.c: Recreate subscriptions using distributor serializer.
Richard Mudgett [Fri, 27 May 2016 21:28:39 +0000 (16:28 -0500)]
res_pjsip_pubsub.c: Recreate subscriptions using distributor serializer.

* Resolves potential reentrancy problems if system restarted in the middle
of subscription message transactions.

* Fixes memory leak recreating persistent subscriptions when the
subscription resource tree could not be created.

Reported by:  Richard Mudgett

Change-Id: I71e34d7ae8ed35a694f1030e820e2548c48697be

5 years agores_pjsip_pubsub.c: Use distributor serializer for incoming subscriptions.
Richard Mudgett [Fri, 27 May 2016 17:50:14 +0000 (12:50 -0500)]
res_pjsip_pubsub.c: Use distributor serializer for incoming subscriptions.

We must continue using the serializer that the original SUBSCRIBE came in
on for the dialog.  There may be retransmissions already enqueued in the
original serializer that can result in reentrancy and message sequencing
problems.  The "sip_transaction Unable to register SUBSCRIBE transaction
(key exists)" message is a notable symptom of this issue.

Outgoing subscriptions still create the pjsip/pubsub/<endpoint>
serializers for their dialogs.

Reported by:  Richard Mudgett

Change-Id: I18b00bb74a56747b2c8c29543a82440b110bf0b0

5 years agopjsip_distributor.c: Consistently pick a serializer for messages.
Richard Mudgett [Thu, 26 May 2016 22:35:04 +0000 (17:35 -0500)]
pjsip_distributor.c: Consistently pick a serializer for messages.

Incoming messages that are not part of a dialog or a recognized response
to one of our requests need to be sent to a consistent serializer.  Under
load we may be queueing retransmissions before we can process the original
message.  We don't need to throw these messages onto random serializers
and cause reentrancy and message sequencing problems.

* Created a pool of pjsip/distributor serializers that get picked by
hashing the call-id and remote tag strings of the received messages.

* Made ast_sip_destroy_distributor() destroy items in the reverse order of

Reported by:  Richard Mudgett

Change-Id: I2ce769389fc060d9f379977f559026fbcb632407

5 years agopjsip_distributor.c: Ignore messages until fully booted.
Richard Mudgett [Thu, 2 Jun 2016 17:51:31 +0000 (12:51 -0500)]
pjsip_distributor.c: Ignore messages until fully booted.

We should not be processing any incoming messages until we are fully
booted.  We may not have dialplan or other needed configuration loaded

ASTERISK-26089 #close
Reported by: Scott Griepentrog

Reported by:  Richard Mudgett

Change-Id: I584aefb4f34b885a8927e1f13a2c64babd606264

5 years agobuild: Fix ast_sockaddr initialization to be more portable
George Joseph [Thu, 9 Jun 2016 14:20:33 +0000 (08:20 -0600)]
build:  Fix ast_sockaddr initialization to be more portable

A change to glibc 2.22 changed the order of the sockadddr_storage
members which caused the places where we do an initialization of
ast_sockaddr with '{ { 0, 0, } }' to fail compilation.  Those
initializers (which we shouldn't have been using anyway) have been
replaced with memsets.

Change-Id: Idd1b3b320903d8771bfe221f0b015685de628fa4

5 years agoMerge "translate: Enables native Packet-Loss Concealment (PLC) for supporting codecs."
Joshua Colp [Thu, 9 Jun 2016 12:24:46 +0000 (07:24 -0500)]
Merge "translate: Enables native Packet-Loss Concealment (PLC) for supporting codecs."

5 years agoMerge "chan_sip: No rtpmap for static RTP payload IDs in SDP."
Joshua Colp [Thu, 9 Jun 2016 09:40:43 +0000 (04:40 -0500)]
Merge "chan_sip: No rtpmap for static RTP payload IDs in SDP."

5 years agoMerge "BuildSystem: Avoid 'ar cru' and use 'ar cr' instead."
Joshua Colp [Thu, 9 Jun 2016 09:40:37 +0000 (04:40 -0500)]
Merge "BuildSystem: Avoid 'ar cru' and use 'ar cr' instead."

5 years agoMerge "Detect and use proper libraries for musl toolchains"
Joshua Colp [Thu, 9 Jun 2016 09:40:30 +0000 (04:40 -0500)]
Merge "Detect and use proper libraries for musl toolchains"

5 years agoMerge "Fixes to include signal.h"
Joshua Colp [Thu, 9 Jun 2016 09:40:24 +0000 (04:40 -0500)]
Merge "Fixes to include signal.h"

5 years agoMerge "Make use of GLOB_BRACE and GLOB_NOMAGIC optional"
Joshua Colp [Thu, 9 Jun 2016 09:40:14 +0000 (04:40 -0500)]
Merge "Make use of GLOB_BRACE and GLOB_NOMAGIC optional"

5 years agoMerge "res_hep_{pjsip|rtcp}: Decline module loads if res_hep had not loaded"
Joshua Colp [Wed, 8 Jun 2016 22:17:38 +0000 (17:17 -0500)]
Merge "res_hep_{pjsip|rtcp}: Decline module loads if res_hep had not loaded"

5 years agoMerge "Fix res_search usage"
Joshua Colp [Wed, 8 Jun 2016 19:43:35 +0000 (14:43 -0500)]
Merge "Fix res_search usage"

5 years agoMerge "Fix #include poll.h and sys/cdefs.h"
Joshua Colp [Wed, 8 Jun 2016 19:43:13 +0000 (14:43 -0500)]
Merge "Fix #include poll.h and sys/cdefs.h"

5 years agoDetect and use proper libraries for musl toolchains
Timo Teräs [Fri, 3 Jun 2016 05:59:30 +0000 (08:59 +0300)]
Detect and use proper libraries for musl toolchains

Change-Id: I8d9b212f70813404b82918a3f99439e500d4bfcb

5 years agoFixes to include signal.h
Timo Teräs [Fri, 3 Jun 2016 05:57:02 +0000 (08:57 +0300)]
Fixes to include signal.h

POSIX defines signal.h. sys/signal.h should not be used as it is
c-library internal header which may or may not exist. Notably with
musl it generates warning of being incorrect.

Change-Id: Ia56b0aa1d84b5c590114867b1b384a624f39a6fc

5 years agores_hep_{pjsip|rtcp}: Decline module loads if res_hep had not loaded
Matt Jordan [Wed, 8 Jun 2016 17:26:29 +0000 (12:26 -0500)]
res_hep_{pjsip|rtcp}: Decline module loads if res_hep had not loaded

A crash can occur in res_hep_pjsip or res_hep_rtcp if res_hep has not
loaded and does not have a configuration file. Previously when this
occurred, checks were put in to see if the configuration was loaded
successfully. While this is a good idea - and has been added to the
offending function in res_hep - the reality is res_hep_pjsip and
res_hep_rtcp have no business running if res_hep isn't also running.

As such, this patch also adds a function to res_hep that returns whether
or not it successfully loaded. Oddly enough, ast_module_check returns
"everything is peachy" even if a module declined its load - so it cannot
be solely relied on. res_hep_pjsip and res_hep_rtcp now also check this
function to see if they should continue to load; if it fails, they
decline their load as well.

ASTERISK-26096 #close

Change-Id: I007e535fcc2e51c2ca48534f48c5fc2ac38935ea

5 years agoMerge "chan_rtp.c: Simplify options to UnicastRTP channel creation."
Joshua Colp [Wed, 8 Jun 2016 10:13:59 +0000 (05:13 -0500)]
Merge "chan_rtp.c: Simplify options to UnicastRTP channel creation."

5 years agoMerge "apps/app_voicemail.c and main/say.c: Add support for Icelandic language"
Joshua Colp [Wed, 8 Jun 2016 10:13:52 +0000 (05:13 -0500)]
Merge "apps/app_voicemail.c and main/say.c: Add support for Icelandic language"

5 years agoMerge "ari/resource_channels: Add 'formats' to channel create/originate"
Joshua Colp [Wed, 8 Jun 2016 10:13:37 +0000 (05:13 -0500)]
Merge "ari/resource_channels:  Add 'formats' to channel create/originate"

5 years agochan_sip: No rtpmap for static RTP payload IDs in SDP.
Alexander Traud [Wed, 8 Jun 2016 07:11:40 +0000 (09:11 +0200)]
chan_sip: No rtpmap for static RTP payload IDs in SDP.

This saves around 100 bytes when G.711, G.722, G.729, and GSM are advertised in
SDP. This reduces the chance to hit the MTU bearer of 1300 bytes for SIP over
UDP, if many codecs are allowed in Asterisk. This new feature is enabled
together with the optional feature compactheaders=yes via the file sip.conf.

ASTERISK-25578 #close

Change-Id: I16491b1937862de26f84fa0ffe679a6bab925044

5 years agoMerge "res_odbc: Implement a connection pool."
Joshua Colp [Tue, 7 Jun 2016 17:17:16 +0000 (12:17 -0500)]
Merge "res_odbc: Implement a connection pool."